From patchwork Thu Dec 30 11:31:25 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gaston Gonzalez X-Patchwork-Id: 12701397 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 47D82C433F5 for ; Thu, 30 Dec 2021 11:33:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QrC5/vvVUQF5JHsIW4Tfm435eYmfut6sxmbHNjDoT+w=; b=kkMoJ2GOKouIH+ BmBbV9jwBPJwUQ5K4Z+n4ETJ8K4ieuMbelBV6ya6ml5lDSinGC/zjvAWjPPnh3NinEdv0AlQEN+a/ Nv83wZnFUlNsIp7Sa/F4lGcvQtnEcoc+IadXbA5SQ7UqzlEf6M5xsWb+yEfPEdar0IAalLVvXYgdX 8i+NQEXQEGSWSZcFkiytpN8zJBJrh+lSZf5G5dXSedb1dryyVAV4Wdh5x9yav+a/k5aVaIwmDzhOe qCMfMcJl1e+LMnKZCvrrYy6Z+nyHISp8HW+SwnT2IQ/In25JS2M43AXOkJKTz4QoWHa+qXsMRBdlO yTBYk66Hvdw5uuTUPw0g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n2tfk-004I4S-Pa; Thu, 30 Dec 2021 11:32:40 +0000 Received: from mail-qt1-x82a.google.com ([2607:f8b0:4864:20::82a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n2tfh-004I3Q-MP; Thu, 30 Dec 2021 11:32:38 +0000 Received: by mail-qt1-x82a.google.com with SMTP id a1so21393777qtx.11; Thu, 30 Dec 2021 03:32:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nbtCBNF6sxyvZFWUemZV++F4nWdCRsnh+BO2TPv43oo=; b=hUJxB2QDslx3YNl5pocgvID8fPQB1GANa4RM6OjJHB61N+RLR/lcBOf0rIhO91SGyI lYRmPggUcwoQkHJtCL+Uj0XFWe/NdQEZY2lM9Fm8va3qrYKutAxGa+bvrUZbAiggrTm5 CALNPlBfkis2yF869vjq6Q2bDz9X6+dYqx2ZtTzcy9jwDB2K6S3aZ0tGzpqA2kBtRVLT mUZSdtVtv4ilMC9uGg3qE+n3rFlTsaTWkVdWTZswbC5tebqasKFQ0N+x+3lJ6Uyqci52 qVDR3ldhF4heiHeDKBOpqy6C07aYvIkciVnqSF/506SL6HJVKlfza6KfqdO7v8b0LT5A ey4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=nbtCBNF6sxyvZFWUemZV++F4nWdCRsnh+BO2TPv43oo=; b=AdoPCDem3SRjJ/CuXVuS/11Y4RJuGum3f5ErR9EYd+UpKSpyrBRa3Yf1XLHjwP9KM1 qL7oviUaC0LPNYrt6nxHuH6CUk3QZ1wNyvSpUd07E+0u8qPFCLL1Ja/zQ5D0zrnkc3gj GKwT7x+WR4Hb/2ybyIxK1azlxBJpgNccKA70McvRYZL47+6fTN1i3sAbs7eyPIJJL1Cv p4Xdwc3qZ2aCmpla6Rt4koynxMTwDO/CoCHLwCpZNkrvg74DQCG0619ILYGGwkJ98k9L th0eUBVGq+vxvheQgy3LqPt4qecSESP00McDJcyBpIp35Hu2qXCg/4fllDFICYBLk1Ez s4Cw== X-Gm-Message-State: AOAM530u+8s3t1zBAc6p3g0R6h8EpV6w+FitaAQ4cwYntQ11ys6MtYT3 S+of8v4cwGXBST5D9nwJ6+A= X-Google-Smtp-Source: ABdhPJyKW4CawNE3aJaa06FIHWRv2QQ6s4gqoNbfviXivu684EH0slEHhlaQ5RHmGrEkya481hb8mA== X-Received: by 2002:a05:622a:1c6:: with SMTP id t6mr26056580qtw.211.1640863956489; Thu, 30 Dec 2021 03:32:36 -0800 (PST) Received: from localhost.localdomain ([181.23.70.139]) by smtp.gmail.com with ESMTPSA id v5sm20348559qkp.126.2021.12.30.03.32.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Dec 2021 03:32:36 -0800 (PST) From: Gaston Gonzalez To: linux-staging@lists.linux.dev Cc: gregkh@linuxfoundation.org, nsaenz@kernel.org, f.fainelli@gmail.com, rjui@broadcom.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, juerg.haefliger@canonical.com, rdunlap@infradead.org, dave.stevenson@raspberrypi.com, stefan.wahren@i2se.com, unixbhaskar@gmail.com, mitaliborkar810@gmail.com, phil@raspberrypi.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, gascoar@gmail.com Subject: [PATCH v2 1/3] staging: vc04_services: bcm2835-audio: avoid the use of typedef for function pointers Date: Thu, 30 Dec 2021 08:31:25 -0300 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211230_033237_741587_D5854835 X-CRM114-Status: UNSURE ( 9.87 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Replace typedefs bcm2835_audio_newpcm_func and bcm2835_audio_newctl_func with equivalent declarations to better align with the linux kernel coding style. Signed-off-by: Gaston Gonzalez --- .../staging/vc04_services/bcm2835-audio/bcm2835.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835.c b/drivers/staging/vc04_services/bcm2835-audio/bcm2835.c index c250fbef2fa3..628732d7bf6a 100644 --- a/drivers/staging/vc04_services/bcm2835-audio/bcm2835.c +++ b/drivers/staging/vc04_services/bcm2835-audio/bcm2835.c @@ -52,20 +52,14 @@ static int bcm2835_devm_add_vchi_ctx(struct device *dev) return 0; } -typedef int (*bcm2835_audio_newpcm_func)(struct bcm2835_chip *chip, - const char *name, - enum snd_bcm2835_route route, - u32 numchannels); - -typedef int (*bcm2835_audio_newctl_func)(struct bcm2835_chip *chip); - struct bcm2835_audio_driver { struct device_driver driver; const char *shortname; const char *longname; int minchannels; - bcm2835_audio_newpcm_func newpcm; - bcm2835_audio_newctl_func newctl; + int (*newpcm)(struct bcm2835_chip *chip, const char *name, + enum snd_bcm2835_route route, u32 numchannels); + int (*newctl)(struct bcm2835_chip *chip); enum snd_bcm2835_route route; }; From patchwork Thu Dec 30 11:31:27 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gaston Gonzalez X-Patchwork-Id: 12701398 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C1498C433F5 for ; Thu, 30 Dec 2021 11:34:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oWEukMSqOKR5K30A1WSbajYOUZgPMZYQxjC8NLdsIgM=; b=0WyspIKrwfePyP rsBs5/9Sdnr6Uu4B2tQMlKL7Xic+QSba/7AcGr92eUHYkJCa+SMKKbuuJqcH2GPvUoyYR20rMPD+v gxy7159xU7JlncdbsxfPeIts0WwC7DgIbHONvt43aRpri0DaAbE6VH+PyPTqaXscyask3NjjqOxct qjRnGwo+NvOvsBummwoUol4nKpGqeKj++jXPnVquyFcdKb3/gCOUlhj7mFtRdO/zeCKENRijY3brZ Ddm0UjsPRD/Do9yqahHOdKfw0vdfVEg2SCbZUxSFGrOCGjPtXWn/bZMquIXaD0E+Q5fWiBG4GnxzJ oAyNNS5a7LOlTjhUj69w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n2tg4-004I90-9r; Thu, 30 Dec 2021 11:33:00 +0000 Received: from mail-qt1-x82b.google.com ([2607:f8b0:4864:20::82b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n2tg0-004I7B-8j; Thu, 30 Dec 2021 11:32:57 +0000 Received: by mail-qt1-x82b.google.com with SMTP id m25so21370302qtq.13; Thu, 30 Dec 2021 03:32:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=a+3drHr85ha2baZful+nRJ7uBfrZaAbysA+5tvBlqBY=; b=qPtzEAgNBKbi3F8mzlujZv/gYnhOvqhIviEvIuYvKHcBnL1trShVtjmds0pGd2hf79 liFxw3cM75vsuO4svQ2s3GgC7/2uBAes/Vcvy+/v8DC0tRhnv+4xSLcrxzptF2nmQkI8 YV9aKyqADMLP1qpBgZStSDBs6fCLTe3qX08bvjMP+knZB3h1CIQ3XM7r/kBTqitdFn87 Bw5NxzIQ2d6iDtHxBo5vVLZ0FF0dRuNApfGF2BlgH7O2YTETm2Y2eym5o3L7kZ9Gh3M9 9rX2Jul5hJPmEiL37bWzrNIHOoIZFNdPajiUyeB0m96hmwVAT+udeMoeycCHtEzLGuwd LolQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=a+3drHr85ha2baZful+nRJ7uBfrZaAbysA+5tvBlqBY=; b=qk1ud6rxdkKdc9mMqTWE7GMiarFc0v2d90FklnlBIkjvY9kNzNYxUtSrWs6nKQgEoN /pQr6UacJljVCvjk16+p8arMONxKkyHJBdRU2MdrCyMYLYfCFc7S43+XDhPHTtsNpnU4 AMCZIqAxCeskVNbdjQJQ1lfzcbCJ01rPu4l4FceCQQDB8vnL1Ad6oIbkq8o6/fYK3Avr kotYqK36ya30vpIsh9kFAzKl4XGExqLt9uNB/aCXHM/OayTK5GGi+6UJ5shl048l1Ma/ PsUf8ofY10xz6Oyazq4YShFy+Fs6Yh5U+ToJXGzE8Y191ZigLcVLnJ92oYIqDQmoUGb/ Xubw== X-Gm-Message-State: AOAM533f1Xhp6l4lcQyIbrdHttwO/87ovZGc6xSBVdO336jBid4QWBL/ OHrlTmvWQyzcxnKoqV5/ppQ= X-Google-Smtp-Source: ABdhPJycnyd4H24DA5r2pASiGfeQVL5PDTMuBWNjmfl03v0nt+qlhV0ox7sLYQwz0sd6ruO2U1lfQQ== X-Received: by 2002:a05:622a:144:: with SMTP id v4mr25727272qtw.191.1640863975231; Thu, 30 Dec 2021 03:32:55 -0800 (PST) Received: from localhost.localdomain ([181.23.70.139]) by smtp.gmail.com with ESMTPSA id v5sm20348559qkp.126.2021.12.30.03.32.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Dec 2021 03:32:54 -0800 (PST) From: Gaston Gonzalez To: linux-staging@lists.linux.dev Cc: gregkh@linuxfoundation.org, nsaenz@kernel.org, f.fainelli@gmail.com, rjui@broadcom.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, juerg.haefliger@canonical.com, rdunlap@infradead.org, dave.stevenson@raspberrypi.com, stefan.wahren@i2se.com, unixbhaskar@gmail.com, mitaliborkar810@gmail.com, phil@raspberrypi.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, gascoar@gmail.com Subject: [PATCH v2 2/3] staging: vc04_services: bcm2835-camera: avoid the use of typedef for function pointers Date: Thu, 30 Dec 2021 08:31:27 -0300 Message-Id: <0418e6e19e1580fff4abfc4bb2f4269dc206df44.1640776340.git.gascoar@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211230_033256_320567_18D29751 X-CRM114-Status: GOOD ( 11.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Replace typedef bm2835_mmal_v4l2_ctrl_cb with equivalent declaration to better align with the linux kernel coding style. Signed-off-by: Gaston Gonzalez --- .../staging/vc04_services/bcm2835-camera/controls.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/staging/vc04_services/bcm2835-camera/controls.c b/drivers/staging/vc04_services/bcm2835-camera/controls.c index b096a12387f7..3696dfb5a020 100644 --- a/drivers/staging/vc04_services/bcm2835-camera/controls.c +++ b/drivers/staging/vc04_services/bcm2835-camera/controls.c @@ -65,13 +65,6 @@ enum bm2835_mmal_ctrl_type { MMAL_CONTROL_TYPE_CLUSTER, /* special cluster entry */ }; -struct bm2835_mmal_v4l2_ctrl; - -typedef int(bm2835_mmal_v4l2_ctrl_cb)( - struct bm2835_mmal_dev *dev, - struct v4l2_ctrl *ctrl, - const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl); - struct bm2835_mmal_v4l2_ctrl { u32 id; /* v4l2 control identifier */ enum bm2835_mmal_ctrl_type type; @@ -84,7 +77,8 @@ struct bm2835_mmal_v4l2_ctrl { u64 step; /* step size of the control */ const s64 *imenu; /* integer menu array */ u32 mmal_id; /* mmal parameter id */ - bm2835_mmal_v4l2_ctrl_cb *setter; + int (*setter)(struct bm2835_mmal_dev *dev, struct v4l2_ctrl *ctrl, + const struct bm2835_mmal_v4l2_ctrl *mmal_ctrl); }; struct v4l2_to_mmal_effects_setting { From patchwork Thu Dec 30 11:31:29 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gaston Gonzalez X-Patchwork-Id: 12701399 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4106BC433EF for ; Thu, 30 Dec 2021 11:34:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=o1qQm1xmItYlHqzc3yAMb578l9oCcSoLD/8bth6RLrg=; b=qO9dsZgws9aEXy XtIzgsjS1NofRkRqMnkG5NT1RMV4d7unFgBGkn5Fo1nK+kFlwML8PHMEKhfBu4S2ZWdjFksdxAJx4 yu2lE+ur6QpTViKTtE5TDZ3VV6ZMZZO7Ng4+Sh/DAY0PQ4aqAVrcOkCLkpYyVSwu9gfn5DgEjqbQS +sCsH4UU5P+Su0JygbdPJymOM9E9tzAe06tE8lUp5k8NMdGblyH2HZ380PZDDWzkm250pPqcWfMDa xEpEHLRu2Vk6pNRV4rC0pGTpASpPlmh/OVoQQpaHE3KoDG1XN112qf1yErjlMzBXzPLQEVZSL7w59 h3xOngveALq2nHQiTqCQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n2tgL-004IF7-A8; Thu, 30 Dec 2021 11:33:17 +0000 Received: from mail-qv1-xf2d.google.com ([2607:f8b0:4864:20::f2d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n2tgG-004IDB-PQ; Thu, 30 Dec 2021 11:33:14 +0000 Received: by mail-qv1-xf2d.google.com with SMTP id fo11so21790201qvb.4; Thu, 30 Dec 2021 03:33:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0NAb92aP3BvHX/H/r7xcS0pDvxqvrorYUGqTqAdSQus=; b=A9gJExEihB/bAGFoBMIBq18odmtsTOCydFD2wgMeuWGTGJ3MFb6CqvVl7rmzJptGby 45SuFMl4GHtVNDMdIEezv4fpEfhXmJWSJrmsNZXt3EZoL1QFT8BwszUdJU/g1l0d9pHc XtSfHGfHRgiJnZUfSf1P8TaYErGPK/0gGC4qCSS4pMTeiZ/qCt9wrah1f3VMqO3ggNkS dswRWt+db55IzbzIJv8SjnWR4GmbqGK/FxMNjdrLVWiLweC/IO5OvCL0FxEWkOcRSzbH XcGQkyC9oC5gGhYxbOgXfe5uTOTmSpAq2Ugm9FDxN/nDaK6pjirB2SUKVmxPcgzk+MNA vIig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0NAb92aP3BvHX/H/r7xcS0pDvxqvrorYUGqTqAdSQus=; b=esekB0EVJrJNfrEovHJ9krh39+m3NigzlAJWKfMMdX432cnDwk3cRH7bOzrCmfZPjU AIn0wd3/9Eq1XfjTnQgjvBSxJHiLoi2Fe27qjxknSaX7INRw/SfdCTqe6nG1JpFbPazy jNcHpg8BgDor4mKjwQ/tXA0V64jIfDfxihuyy11KN25/N/FYdxkf6L4hmC5zPdjZZ/rK deVTsi4Nj8Yft2YgYbWnKHQQmxveYyaR7beuoeh6H/qVgKSN8YpqRLZwz7iiwfPcsCM9 2tViSNndegFAb05nTxJqLuvk3KOKgLMZANBPvpd82Y88yJg9vNglhDE60AEcUi+gpcN4 W3xA== X-Gm-Message-State: AOAM531BoHTBxU/Ey9Dhz9RfqBwiF8Jlqy9xHF2YB/MCVIct6YdtPxR/ zM3NTTNkBCLTdlse4g3WSgs= X-Google-Smtp-Source: ABdhPJym1DmSfFDOm0+uJkMnhCuNXQ/vZE1Hb0Km0uMhLyBPVYS1yLSZhyh+rXnBWdszqWcIzY3AJg== X-Received: by 2002:a05:6214:2344:: with SMTP id hu4mr11691004qvb.55.1640863991767; Thu, 30 Dec 2021 03:33:11 -0800 (PST) Received: from localhost.localdomain ([181.23.70.139]) by smtp.gmail.com with ESMTPSA id v5sm20348559qkp.126.2021.12.30.03.33.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Dec 2021 03:33:11 -0800 (PST) From: Gaston Gonzalez To: linux-staging@lists.linux.dev Cc: gregkh@linuxfoundation.org, nsaenz@kernel.org, f.fainelli@gmail.com, rjui@broadcom.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, juerg.haefliger@canonical.com, rdunlap@infradead.org, dave.stevenson@raspberrypi.com, stefan.wahren@i2se.com, unixbhaskar@gmail.com, mitaliborkar810@gmail.com, phil@raspberrypi.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, gascoar@gmail.com Subject: [PATCH v2 3/3] staging: vc04_services: update TODO file Date: Thu, 30 Dec 2021 08:31:29 -0300 Message-Id: <3f560a75063a0bb744bb34c410e49f792d2c3d21.1640776340.git.gascoar@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211230_033312_869323_4DA0DCEB X-CRM114-Status: GOOD ( 13.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org There are no struct typedef remaining inside vc04_services/. Hence, remove the task from the TODO file. While at it, fix the items sequential numbering. Signed-off-by: Gaston Gonzalez --- drivers/staging/vc04_services/interface/TODO | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/staging/vc04_services/interface/TODO b/drivers/staging/vc04_services/interface/TODO index 39810ce017cd..241ca004735c 100644 --- a/drivers/staging/vc04_services/interface/TODO +++ b/drivers/staging/vc04_services/interface/TODO @@ -80,11 +80,7 @@ vchiq-core.ko and vchiq-dev.ko. This would also ease the upstreaming process. The code in vchiq_bcm2835_arm.c should fit in the generic platform file. -12) Get rid of all the struct typedefs - -Most structs are typedefd, it's not encouraged in the kernel. - -13) Get rid of all non essential global structures and create a proper per +11) Get rid of all non essential global structures and create a proper per device structure The first thing one generally sees in a probe function is a memory allocation @@ -92,6 +88,6 @@ for all the device specific data. This structure is then passed all over the driver. This is good practice since it makes the driver work regardless of the number of devices probed. -14) Clean up Sparse warnings from __user annotations. See +12) Clean up Sparse warnings from __user annotations. See vchiq_irq_queue_bulk_tx_rx(). Ensure that the address of "&waiter->bulk_waiter" is never disclosed to userspace.