From patchwork Tue Jan 11 07:17:16 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 12709555 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21D04C433EF for ; Tue, 11 Jan 2022 07:18:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348493AbiAKHS3 (ORCPT ); Tue, 11 Jan 2022 02:18:29 -0500 Received: from mx0a-00069f02.pphosted.com ([205.220.165.32]:50102 "EHLO mx0a-00069f02.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348469AbiAKHS2 (ORCPT ); Tue, 11 Jan 2022 02:18:28 -0500 Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 20B3TF0g018675; Tue, 11 Jan 2022 07:17:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : content-type : mime-version; s=corp-2021-07-09; bh=YfVJN+0FzMrzlQh+OXtIOogmYXVQqYQ6e6RXpMUeP/0=; b=zawOmCBAXRbsl0fx7/7plonDbgLKqNSIsjfGKFowh945LMH0JX/uxYC2S4Z74jmj0mYx OMVQFnKyZhuK428tZ5GFzn8vSxKRy8p68wBWO8vDmARoO7WrgbMP6u4KxU6QQyXebjPz e0a8KXkyZ5i5aq0LBrNbeUDPtIaFlEAgn/Pbjc22QViVVBsfjLXeZo+rbGNOtGLCKWWC zTH1eQKDgPq8HnwLUyBdXfZxKRD8IWwXUn/t1W767gt93CaVvfN1iKwcrQlST9stosOD csAM7rLYCOHP0S2HelgccLxYR3Pa3P/reyP4sKsV0bfeSoJO6GFB+YDwZ6hEekbqlVAE gQ== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by mx0b-00069f02.pphosted.com with ESMTP id 3dgp7nj48s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 11 Jan 2022 07:17:30 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 20B7G8p9081734; Tue, 11 Jan 2022 07:17:29 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2046.outbound.protection.outlook.com [104.47.66.46]) by userp3030.oracle.com with ESMTP id 3deyqwp1xe-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 11 Jan 2022 07:17:28 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dGLZ6fNs7WSwYtIwCjiOoyjdLbB9ON1jdkvAwjbG6LZJjJ6bSfw73Mq5vbbLXaJ/12Y1A8sjsPdIrJt5E0o0KT5FaxJqiMtFA5fETR3HUeUygGkvEy929ewS+bAn+ug0kw+f9tlENtYdZRBEPbcBAkLf8BWyJ14/gsP/49GvOsP0kOkvFSOZpOMGGi4kHIf8G+WTXnlMyZV71NBVtLZiWShiKEps18xK5DCesOcTkQQuSrbBvNTLUtRHGB3/2uFZqeVtVGvBko/bc5DIsSPTVGtX4BG/XR2mud1N6YAHKOEyHccM1A42waXbAmXGy0vCDytfix74Q9xEpEAX7VjPgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YfVJN+0FzMrzlQh+OXtIOogmYXVQqYQ6e6RXpMUeP/0=; b=b/SyPYrHQtc3amvylbLOJRi6dPfeJ1/kDjxIxZV7uULe+wBK+1wqluASX7QwUOdfPTO3JC+p+2ML/3qhXF7or/jKqE/y4G3tcmKh1Rq0CZaUNYc5drtQ8HKFDPCAA7J7UUxqGgtyxDsjNo/+/cJlmQq//vnwUEF+vDcONMVYM1SmpJBw3Pe0HVpRbqwVYzrA02FOcu5ZlNzcuWDtKlQGuEm45tnTveUaLOV4dHzUJAWd3KanSwdcKQGkxsLA4BiP/bkp4rJDtx8/psOVyCLURcrZ8bxsy/rnehQ3eICm4A7dExFy+JzfMQhEpjEYtCTkoFN1f5UbAC9Niv4CavVy+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YfVJN+0FzMrzlQh+OXtIOogmYXVQqYQ6e6RXpMUeP/0=; b=yACHvwHA6anvCyWEj4AjOEVv/6unrrgyTdCY13l4nJUMJ9NI5d5KxMeVZN8pgdnyTKGgm6bZFrHNEn1llbXbdAseIOMk5JWe1eTekY05Astc32w2IS3VpgOaXBFCNHhzC6YIqiwFx97ehjNPFh9iYJLg4JXDCE49hjOJ8/4Z8gI= Received: from MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) by MWHPR10MB1421.namprd10.prod.outlook.com (2603:10b6:300:24::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.9; Tue, 11 Jan 2022 07:17:26 +0000 Received: from MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::b889:5c86:23c0:82b8]) by MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::b889:5c86:23c0:82b8%4]) with mapi id 15.20.4867.012; Tue, 11 Jan 2022 07:17:26 +0000 Date: Tue, 11 Jan 2022 10:17:16 +0300 From: Dan Carpenter To: Steve French Cc: Shyam Prasad N , linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, kernel-janitors@vger.kernel.org Subject: [PATCH] cifs: uninitialized variable in cifs_get_next_mid() Message-ID: <20220111071716.GC11243@kili> Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-ClientProxiedBy: ZR0P278CA0061.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:21::12) To MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c1f9cb32-8c5e-4d62-fad2-08d9d4d26baa X-MS-TrafficTypeDiagnostic: MWHPR10MB1421:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2449; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: z/l/g1RWgzIoQrxcAQhEIO9YsotsP6pJHdU3QgRMKLeZDDDf9RlvJEnRxzoom69koaNyy/lMuuZOApxHrzG80mHLNONXq7b8M5f8htvOW1HlJIgLFxDi6jSjZbJ5WaMNc1XWak0tsAgjuMMD2KXyC485q5gN3/wOfP1LTuUAl4CRn4lLPKJUim8UsEAokvdpmZkQOL9ApvPbklrqPWBc5Qvcg+HSfL+pE0vpJhUAf4TsZxzX4i3hwaiIFxgPy4wJb9meA1/a2F4234yEowN7nmPL4Icf04TnDPknfT6JdqE8H5lkvqqhStj21lIS6vRyO3lRQ39LEz4xOhegb0bb5MxOu1QcJaB0MT1NxePqx344bbJwqhszigPw4pRpFKLz83jNXSwucotgmrMDwaq3T3ckTTl4cxB6KsLaTl2dbUgO01AKA3sKQLTjC26s4Tk/t6Yju3xw6ESkXnUeH7w8w7R45cGh20f631Cp8fOq9y31kZL15OaOT5m2w2d3Pl7mDECf59r79yMBpUY56EP10TErSov6xSszvlc7fooG3MfSf7Xsk34JBMKS2cM5XKNfg7lqJ2u0E0OOQuA5NVMPcNPgO7euQvQYbai39mwp6+WLPWvxcTbEzFmI8Cp2g080a18aL127/PkTn8j+xUqfopIGXMhqQj/fRqZgyeJxKdMsQl2JgAIz4bJf1EAuLacJl20P4GesLh1ONyLqbfHndg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2365.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(7916004)(366004)(33716001)(508600001)(4744005)(44832011)(4326008)(52116002)(86362001)(2906002)(186003)(8936002)(6916009)(8676002)(6506007)(66946007)(66556008)(316002)(6486002)(26005)(66476007)(6666004)(9686003)(1076003)(6512007)(38350700002)(5660300002)(33656002)(38100700002)(83380400001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 5Z1Nf2HQn0RZ2rCIUH/uHoUuqYIPMixhSBlTFn5/YhxKm0rAxopmemMJhVy/nsLH7EzcmFkof0BP+n30sjFFAOwP1p5Nufgc3LOfvz3ExdBaHFhntQvSocUTdrIyjQtXc1T9JU1qZ7bKOSOeoa0AWOqt62r76M2ziR9f6hwsQn2bUQJlLhttGmqqsLTwmNL3KsZOAdxuTU7GqZv5aoUNP7ZH//YQNAfDyDq09jyEiJhU8+v1tJrifkNZVHnq2efdIIx53Eav7//DuoY2qzPaZtsx0+D0WjSXWHfKCqV1vnxM1BS88n7yTQZOz21yTJwnO46iXKDtbcn6UpXfIls2blPvmn1LaYz039alsmnPJqHZ5y+B7EP+vl6OgA82mpAwWh+cZyDiGbpxJ71NZady7Dj1KZkR5/eNez7fvLvwfO/7uHuzgwem5iZEpb9FSomBiYk+iUGyzYnqgP0lQEx1va8QcX8uIoid74V8cQUNVd2XmyXvfFSnN3zz1zrqQCq1T1AFWv15bpqnEuI1TSWV0jEfZ8Hgv5mGoOygO2y7l9FZ3+zP44DPWgU+d20Xzh3BI9GEEAfb9IY/C5Y8RqOEyRQijGC/S2xgvBAP9cVyh4btSfroXvOSxxHH9InAgAarZYCf/a2hYco1EDi8UHkSB+1ux5qMVd1/XxsaurLXFKGHYFWUyyQtYZsYFGfy2k/e+b0vwMlaqdNckUNJh0NcxGTsqHplcCCcNuDMwbr1Md/0358qCgm1dvoteu/3OE6FI6M/ln6bOE9SqhKx782JZnoYkU6UPoKH/CN4FCFiCQNjEhCriBxnpXLktZgF7riH7RqDFgUfLB+nCd6rd7IrowoT99NLHMdtKVXFUPcGFiySfm+p+WoOLYY4GggRmlEqzTJHTXL/B7Ku3UMlv1ZbF+n5tM45iWrZpkVzOIK+SeASuP4w393qqEsak+bFyX8TQYnrhxIA6tTUe9QTtyH9N7pnA9RwYgNT3Xl9frwVT/+1M4Nzuyq0HqZyhEXWnHEmlhhjviTHLugLt8w8ENu6mHFVhWoFHgf3CtIVc+Xu/9oNqtGvid/Lpe6nmfWp8McN97Rt7IxHvXswDMJTNDqnPrpFJOOZpOPHFKjNNHJ3Wl0EksBUDDP6EwMzCFAfyZ3oe+exB924LBL4oDHL9f2g6vKjUTqmnKKlxNqOPPzZhR+YqfbfQlo87wsvVs0Dy0WqndNnUPyAqmxgOnvAtOqzamge8qZnw0QC7YtLLAW9Fiyx0zxGqEpdMaoBpRMK7PEy+vTunXMwehHdwSsSTmg3Pp3MrECdYFzJEFeW0CQMvwcH+3JFk+zKoE7WO+GMt5c20M5ncjcE4UQ7NHJ58XECvkxM3z3KVt0j5/HihaO3SbUKvZrROcvm/yZngmh3vA9nNNrfGm5lyyDvQhPiYkRVlNWZ/Ds3lO+e8Fo2JUPJCzTQ4aNu9mQ0zKZs/VMsyACdydYSaSyHYKumUZeAQ5e5p4grRQuiCXVzX49IFN9aFYs7FAmsItOKaKeXy7VvalR+RDvWnD6U3LAwMIkRxWs4Ph5WuWDKvxidiUgQeueykHqWkGjvTLKB2axzqAm9jbyJrpPxl5GCb59W6VBlnzVMHBoGyrnDe5FjambDRoaYEycBhiddcWje8XIdEplZfwCs+6BZONC/hjcUOT86siHbZ/o/O+jRza+X7yKle2H3vkI= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: c1f9cb32-8c5e-4d62-fad2-08d9d4d26baa X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2022 07:17:26.5630 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: b0ByaDKeHlXgVHYLf3zG821mgguNtxeYCnJw7y0xZeMWJB1YpZL+Qzc3uUjICNOKhqp87qHmke/K3z0iD4M0s5Qk9hbh20CEzvI+JxM9A98= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1421 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10223 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 suspectscore=0 spamscore=0 mlxlogscore=999 adultscore=0 phishscore=0 malwarescore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2201110039 X-Proofpoint-GUID: izGAAP2mP9YlDZztbee2eMJxpy3ZwsNf X-Proofpoint-ORIG-GUID: izGAAP2mP9YlDZztbee2eMJxpy3ZwsNf Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org The "reconnect" was never initialized to false. Fixes: 220c5bc25d87 ("cifs: take cifs_tcp_ses_lock for status checks") Signed-off-by: Dan Carpenter --- fs/cifs/smb1ops.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/cifs/smb1ops.c b/fs/cifs/smb1ops.c index 54319a789c92..6b1b048b36ae 100644 --- a/fs/cifs/smb1ops.c +++ b/fs/cifs/smb1ops.c @@ -163,7 +163,8 @@ cifs_get_next_mid(struct TCP_Server_Info *server) { __u64 mid = 0; __u16 last_mid, cur_mid; - bool collision, reconnect; + bool reconnect = false; + bool collision; spin_lock(&GlobalMid_Lock);