From patchwork Fri Jan 21 09:56:44 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Stein X-Patchwork-Id: 12719556 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 65473C433EF for ; Fri, 21 Jan 2022 09:58:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=Nl7qXfCr2760w//qfiaJgNzAnXEQpUhKfxIUMw5uwvU=; b=pRsCAk34q7xdjT SD2cAGy+FwpsqQnfnDnylrXKTukwl50ba1Xh2Xo+lEj5EAKiuXFIIZsZInyjRIrnipT7anF64jUh9 qIBnl0fWmKRKODZhw4o7sVpAT49f6xBtnttK6ReElsCwoT293CxS407lUpqkbtYtlK9X9htkYILoo MP+mLDa1WvRhcNA4nqHKRQwg3s8WVhwWjC7x719GL2YXijkRjLIini93NPohVO9GMAmjInFJEudSQ ExsIGkfr1iit9byMLZx7oy9pyJrGhLMj+tRy8vQbXSGI5W2Hh6zzmDxUkHq7ezHvqNmMS49C2wmUT Z3tkvqNp+5c0eb6//aJg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nAqfD-00EZOD-GW; Fri, 21 Jan 2022 09:56:59 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nAqfA-00EZM5-5s for linux-arm-kernel@lists.infradead.org; Fri, 21 Jan 2022 09:56:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1642759016; x=1674295016; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=2DqpC0yy0TkbIYYMKomD9QegPjZZRZ98zSXyYRDPoXg=; b=IqGRwD6HtmgMtlBVLwvCITYc1nhXBXKow1POUDvdaei3fht3LtCX25gd HGrnTQpm0iMeDPZvVDMf3o7+srhgbc5tpKY8+lO4JI4LGhuJu4XztRrsV WGEmtckdov4DefU9FDTyCEuxMv3rv6exUuhMMn/ZUUzNLs9UBH9H7mKBJ mkngdBxqBV/3fC+WfWsdNtVI88tQOOx9Vxfs8sYS6YJ2HCaxxJEjGVMQS QjrUDjubLYsDse2oruc+9KNGe5FHz9P3Ovyk+IFK55wgHZj96mYcIf7qs DP/K0nA2184Jz2acqsBVeKm0mE1bX0uqYm+ZZ5q353NPRsVq7PQ/WErse w==; X-IronPort-AV: E=Sophos;i="5.88,304,1635199200"; d="scan'208";a="21635078" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 21 Jan 2022 10:56:51 +0100 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Fri, 21 Jan 2022 10:56:51 +0100 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Fri, 21 Jan 2022 10:56:51 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1642759011; x=1674295011; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=2DqpC0yy0TkbIYYMKomD9QegPjZZRZ98zSXyYRDPoXg=; b=NWbUEQuF60WWozQe5zWG2F24dpkrm9nHxSZhBMqak7f9iPTmSCX8DlL/ FcI7LoO/CH8ndS8nyQmHJiXuIycCaoC1q0kYEC9iK5NzFUnrdZLKXKQsh nDgdpeF485j/qT6qYrXmYNTFl4QFP3jB7dD3EsWTZdyH+5z88SGNAwDr/ 51w2uKI04Y1Cp1iK7CGdL8nSLvZitwZdE03PI7P4gG5sB/E3DDlRWNf1J m9ey3Yte6lscvqG0vBd1EmUZJFgzLyp//MDg71q34uNsmLxhnAoiBa+tF ID37u8ksvC3jFweFLqVsDyyjSGx70U8hhdkDSmrhKw5D5n9vxkMsyRhRg A==; X-IronPort-AV: E=Sophos;i="5.88,304,1635199200"; d="scan'208";a="21635077" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 21 Jan 2022 10:56:51 +0100 Received: from steina-w.tq-net.de (unknown [10.123.49.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id BF9AD280065; Fri, 21 Jan 2022 10:56:50 +0100 (CET) From: Alexander Stein To: Marek Vasut , Stefan Agner , David Airlie , Daniel Vetter , Shawn Guo , Sascha Hauer , Fabio Estevam Cc: Alexander Stein , linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org Subject: [PATCH 1/1] drm: mxsfb: Use dev_err_probe() helper Date: Fri, 21 Jan 2022 10:56:44 +0100 Message-Id: <20220121095644.329256-1-alexander.stein@ew.tq-group.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220121_015656_617015_8D874CA0 X-CRM114-Status: GOOD ( 12.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Use the dev_err_probe() helper, instead of open-coding the same operation. This also adds a nice hint in /sys/kernel/debug/devices_deferred. Signed-off-by: Alexander Stein Reviewed-by: Marek Vasut --- Based on next-20220120 drivers/gpu/drm/mxsfb/mxsfb_drv.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c index 86d78634a979..bc0d766d217b 100644 --- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c +++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c @@ -258,8 +258,7 @@ static int mxsfb_load(struct drm_device *drm, ret = mxsfb_attach_bridge(mxsfb); if (ret) { - if (ret != -EPROBE_DEFER) - dev_err(drm->dev, "Cannot connect bridge: %d\n", ret); + dev_err_probe(drm->dev, ret, "Cannot connect bridge\n"); goto err_vblank; }