From patchwork Mon Jan 24 09:42:43 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Andi Shyti X-Patchwork-Id: 12721831 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 96DD4C433F5 for ; Mon, 24 Jan 2022 09:43:52 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EAD4810E158; Mon, 24 Jan 2022 09:43:51 +0000 (UTC) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 95FC110E14B; Mon, 24 Jan 2022 09:43:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643017430; x=1674553430; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=uihijiEqKyBj5j8bBRv+t2EXae9PPZWXlfEE9dkQAJw=; b=I8mkWBfCk/BfmhYaIeLAaeMpOd/S4HIWj99X0P7oOPPmqe4MfT5sjCfn IklVlz2rqGqL4oLweK44m7zJS7eY7LaMkMilAL50nCet8xlV8lsEZmtwx wXo1tNOHvp4ZKI9qzKSDE0ccbRtXyBCm1RwBZh1Zajdap6jCbiwrJDSLI T772Oxd/PkurGjk4zjw2ULTVIErb8GIHVJwy7EaCHRsCGivY1yqrVIvhj WttRjj9EuCzg5WXcz3pHtjar8j7rK9egDuY+aySQPMNJ7l2acSl9Ruk/m gGkIeYxkck0qCbpLOyPe/epsAShL1Au2YGOjWeIZDldoP5yKFRi8uA94N w==; X-IronPort-AV: E=McAfee;i="6200,9189,10236"; a="332361695" X-IronPort-AV: E=Sophos;i="5.88,311,1635231600"; d="scan'208";a="332361695" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jan 2022 01:43:49 -0800 X-IronPort-AV: E=Sophos;i="5.88,311,1635231600"; d="scan'208";a="534157493" Received: from mtarral-mobl.ger.corp.intel.com (HELO intel.com) ([10.252.51.157]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jan 2022 01:43:46 -0800 From: Andi Shyti To: Intel GFX , DRI Devel Date: Mon, 24 Jan 2022 11:42:43 +0200 Message-Id: <20220124094243.2637-1-andi.shyti@linux.intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Subject: [Intel-gfx] [PATCH v2] drm/i915: fix header file inclusion for might_alloc() X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Thomas_Hellstr=C3=B6m?= , Thomas Zimmermann Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Replace "linux/slab.h" with "linux/sched/mm.h" header inclusion as the first is not required, while the second, if not included, prdouces the following error: drivers/gpu/drm/i915/i915_vma_resource.c: In function ‘i915_vma_resource_bind_dep_await’: drivers/gpu/drm/i915/i915_vma_resource.c:381:9: error: implicit declaration of function ‘might_alloc’; did you mean ‘might_lock’? [-Werror=implicit-function-declaration] 381 | might_alloc(gfp); | ^~~~~~~~~~~ | might_lock Fixes: 2f6b90da9192 ("drm/i915: Use vma resources for async unbinding") Signed-off-by: Andi Shyti Cc: Thomas Hellström Reviewed-by: Thomas Hellström --- Hi, in V2 I just added the Fixes tag (I think I got the right commit) and added Thomas r-b. Andi drivers/gpu/drm/i915/i915_vma_resource.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_vma_resource.c b/drivers/gpu/drm/i915/i915_vma_resource.c index 1f41c0c699eb..bbb0ff14272f 100644 --- a/drivers/gpu/drm/i915/i915_vma_resource.c +++ b/drivers/gpu/drm/i915/i915_vma_resource.c @@ -4,7 +4,7 @@ */ #include -#include +#include #include "i915_sw_fence.h" #include "i915_vma_resource.h"