From patchwork Thu Jan 27 17:35:54 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Thompson X-Patchwork-Id: 12727147 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42B9AC433F5 for ; Thu, 27 Jan 2022 17:36:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244541AbiA0RgL (ORCPT ); Thu, 27 Jan 2022 12:36:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37262 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244683AbiA0RgK (ORCPT ); Thu, 27 Jan 2022 12:36:10 -0500 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4B60BC061714 for ; Thu, 27 Jan 2022 09:36:10 -0800 (PST) Received: by mail-wm1-x333.google.com with SMTP id n8so2453835wmk.3 for ; Thu, 27 Jan 2022 09:36:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Nsh+hcHxytqHnqOptN/J8SZirknsijh3VoYvJB/RpO0=; b=JpzTisjrSKaIkSNsb6YJSZq1KWLiQ9HnR1te7+RIqCcWXcChP9Q9jpgOrzsO+5hhF+ 5SDS3y+/o67Pv3fUHaaoqqRI2FtLPlaYMJcfyqGKpnUmNz65F9vuZZtf9SfRlgsjf1V3 IdI8HRZAlF8jIgSqueePmkyonKaEDEIH+NerqfqdFIBz8hWu94kgtoU4kS/10dv96V1X HgNaovIbe8QtQ2HXWqavtg3VsALBQSUgLMCrnXyM4Lc+mQ7wnnVDMlo4lZGZBrj/SlSe CkUbLKHjhVKJKeAD6ixkNQyQGjv2mrSGNKD9JiF8a03npnawg7r0T9x2jgnRQLjeGv8w VRmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Nsh+hcHxytqHnqOptN/J8SZirknsijh3VoYvJB/RpO0=; b=ueBOLDregexQADYEjoRSxe6bfUD9LpTwGfIM0Nv+1Sjxqx+8rhOOqPNx2IDWJmW2gM Va33sLLksYr6cR0o83iKB4NMii973lb4ZQBltcaUJsKlb4s66LMWlbUhFwYKNfYX/88q oylQlMxy2vdJ+vhq8G80UghXWpDpOlHTPYGcClllWBP2ES0U+0UtwP8y1jhjeX73A9fZ C/19LK+ONuTFRBE1CRKWzQRxvi+kbblZVUWfKhO4TsmwO83EziGwI5EG4pbn8UMDtsKJ wqHF9HLEZv+alOTT4BU2CaWTezM5NkaY6IUanzw+69nZ5uZthhoPUXX7A5JyMMF4SVzL s5NA== X-Gm-Message-State: AOAM531FrJ1spydltc19j3jDkOGMzoiNv177nHPK3nwjuiuQSp+sidSf PRVzEa1NSyBYs5Akl3jcgoA0SnQvpRciRj2a X-Google-Smtp-Source: ABdhPJx+yLMw0hnU6dpDTJy2lKioILrA7MHPpNBR7BcuuIRu/xUx3YxPVPDbuZ7SnaF8jR5z+BinuA== X-Received: by 2002:a1c:1f92:: with SMTP id f140mr12152336wmf.31.1643304968788; Thu, 27 Jan 2022 09:36:08 -0800 (PST) Received: from maple.lan (cpc141216-aztw34-2-0-cust174.18-1.cable.virginm.net. [80.7.220.175]) by smtp.gmail.com with ESMTPSA id 31sm3269267wrl.27.2022.01.27.09.36.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Jan 2022 09:36:08 -0800 (PST) From: Daniel Thompson To: Andy Gross , Bjorn Andersson Cc: Daniel Thompson , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] soc: qcom: aoss: remove spurious IRQF_ONESHOT flags Date: Thu, 27 Jan 2022 17:35:54 +0000 Message-Id: <20220127173554.158111-1-daniel.thompson@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Quoting the header comments, IRQF_ONESHOT is "Used by threaded interrupts which need to keep the irq line disabled until the threaded handler has been run.". When applied to an interrupt that doesn't request a threaded irq then IRQF_ONESHOT has a lesser known (undocumented?) side effect, which it to disable the forced threading of the irq. For "normal" kernels (without forced threading) then, if there is no thread_fn, then IRQF_ONESHOT is a nop. In this case disabling forced threading is not appropriate for this driver because it calls wake_up_all() and this API cannot be called from no-thread interrupt handlers on PREEMPT_RT systems (deadlock risk, triggers sleeping-while-atomic warnings). Fix this by removing IRQF_ONESHOT. Signed-off-by: Daniel Thompson --- drivers/soc/qcom/qcom_aoss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: e783362eb54cd99b2cac8b3a9aeac942e6f6ac07 prerequisite-patch-id: 59cdecee7d1b3bdd110f0d01790b92428b91862a -- 2.34.1 diff --git a/drivers/soc/qcom/qcom_aoss.c b/drivers/soc/qcom/qcom_aoss.c index cbe5e39fdaeb0..83f1edcbf7a33 100644 --- a/drivers/soc/qcom/qcom_aoss.c +++ b/drivers/soc/qcom/qcom_aoss.c @@ -497,7 +497,7 @@ static int qmp_probe(struct platform_device *pdev) } irq = platform_get_irq(pdev, 0); - ret = devm_request_irq(&pdev->dev, irq, qmp_intr, IRQF_ONESHOT, + ret = devm_request_irq(&pdev->dev, irq, qmp_intr, 0, "aoss-qmp", qmp); if (ret < 0) { dev_err(&pdev->dev, "failed to request interrupt\n");