From patchwork Fri Jan 28 09:07:35 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Geert Uytterhoeven X-Patchwork-Id: 12728155 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 18F83C433F5 for ; Fri, 28 Jan 2022 09:07:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5GBtWSVpzzR7JNbiHXOO7xpqSbqF1yIXQKjz+lemDtU=; b=LVcgDil/Ug7Yiu 6DozvgrmJlAiZHFK6t6NwL9r7p5j18HocBxzJ0JAaQBx74NBmYYhtanZOTyfbWzEF6eGj45ZGcDo2 TxtPs1TAvGDt5pz5WQcq38jbZ3t7G5aDIXSStS4kATbKikaPxkT7KsZ4dWoODmyVkOIu8Wd6URzuK p1RpslfPXsEkGckYM7qHFBtUHGSgP/4uIjJWzCk3gOQCNirU7I/4iT+H0UoMXVbqCF/pWP6Og9KKX CSccOoKIi98uFqEpuCh+Lw4vPHYbQa0XeU/ANiA+tdjvU8Pf4a2rOjweTxzX/7KwhOfRZl+BysgN3 QYJU7BX5e7mHMZSWrx3A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nDNES-0019Ch-Re; Fri, 28 Jan 2022 09:07:48 +0000 Received: from albert.telenet-ops.be ([2a02:1800:110:4::f00:1a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nDNEN-00199Y-GJ for linux-riscv@lists.infradead.org; Fri, 28 Jan 2022 09:07:45 +0000 Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed40:3999:e79d:cb59:f2ec]) by albert.telenet-ops.be with bizsmtp id o97e2600p04fKGS0697fYU; Fri, 28 Jan 2022 10:07:40 +0100 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1nDNEI-00BjuV-NZ; Fri, 28 Jan 2022 10:07:38 +0100 Received: from geert by rox.of.borg with local (Exim 4.93) (envelope-from ) id 1nDNEH-005psG-W2; Fri, 28 Jan 2022 10:07:37 +0100 From: Geert Uytterhoeven To: Daniel Lezcano , Thomas Gleixner , Palmer Dabbelt , Paul Walmsley , Anup Patel Cc: Rob Herring , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, Geert Uytterhoeven , Rob Herring Subject: [PATCH v4 1/2] dt-bindings: timer: sifive, clint: Fix number of interrupts Date: Fri, 28 Jan 2022 10:07:35 +0100 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220128_010743_759846_A478F552 X-CRM114-Status: UNSURE ( 8.66 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org The number of interrupts lacks an upper bound, thus assuming one, causing properly grouped "interrupts-extended" properties to be flagged as an error by "make dtbs_check". Fix this by adding the missing "maxItems", using the architectural maximum of 4095 interrupts. Signed-off-by: Geert Uytterhoeven Acked-by: Rob Herring Reviewed-by: Anup Patel --- v4: - Use architectural maximum instead of practical maximum of 10, v3: - Add Acked-by, v2: - Split in two patches, - Improve patch description and document limit rationale. --- Documentation/devicetree/bindings/timer/sifive,clint.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/timer/sifive,clint.yaml b/Documentation/devicetree/bindings/timer/sifive,clint.yaml index 8d5f4687add9e81e..fe4b73c3f269fc0f 100644 --- a/Documentation/devicetree/bindings/timer/sifive,clint.yaml +++ b/Documentation/devicetree/bindings/timer/sifive,clint.yaml @@ -44,6 +44,7 @@ properties: interrupts-extended: minItems: 1 + maxItems: 4095 additionalProperties: false From patchwork Fri Jan 28 09:07:36 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Geert Uytterhoeven X-Patchwork-Id: 12728154 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DA520C433F5 for ; Fri, 28 Jan 2022 09:07:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Tcm3BaAx3zyYfeo41KZH1+w1AxU/hxDulPdtxL/2Hxs=; b=EwjR0Lq9IbeklJ vTBZ5mM+rDkm6XNeDqJLxUDMUNTTCkze3Z0OAcK7fIBMZFqj9jPtm7ncfdRlVC1eISdkisCxBOo0i fkK4Ix8U4WU84CTDwZnXI7dmwaJ0HdGVIlFWd/Vh/VL7o6vW3JAy+Eoltay9JMkoIJqoDSt2eJE7I I8LiUvO7GBJB9Eq0lN2fMZXD8DbAIpOWuQV01x3O+Ceb6Cdh0BtYs9k4BCKEB5YwMZYuWZTDsw2Jr k2x4CGwa8ZV2KyMoscozXyD5w/ypQ9EmXybS5xJ/EUVeiTHAaiyvxPquYauQa1PREs3TUmruOcM4s 8J8fJU6YDNV5ALW3O+LQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nDNEQ-0019Bi-F3; Fri, 28 Jan 2022 09:07:46 +0000 Received: from albert.telenet-ops.be ([2a02:1800:110:4::f00:1a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nDNEN-00199Z-GJ for linux-riscv@lists.infradead.org; Fri, 28 Jan 2022 09:07:45 +0000 Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed40:3999:e79d:cb59:f2ec]) by albert.telenet-ops.be with bizsmtp id o97e2600Y04fKGS0697eYM; Fri, 28 Jan 2022 10:07:40 +0100 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1nDNEI-00BjuW-Fe; Fri, 28 Jan 2022 10:07:38 +0100 Received: from geert by rox.of.borg with local (Exim 4.93) (envelope-from ) id 1nDNEI-005psK-0U; Fri, 28 Jan 2022 10:07:38 +0100 From: Geert Uytterhoeven To: Daniel Lezcano , Thomas Gleixner , Palmer Dabbelt , Paul Walmsley , Anup Patel Cc: Rob Herring , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, Geert Uytterhoeven , Rob Herring Subject: [PATCH v4 2/2] dt-bindings: timer: sifive, clint: Group interrupt tuples Date: Fri, 28 Jan 2022 10:07:36 +0100 Message-Id: <62bf4ee6613550c07a99d4bd226ab0d33acae4c4.1643360652.git.geert@linux-m68k.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220128_010743_752388_95C0F0B1 X-CRM114-Status: UNSURE ( 8.76 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org To improve human readability and enable automatic validation, the tuples in "interrupts-extended" properties should be grouped using angle brackets. Signed-off-by: Geert Uytterhoeven Reviewed-by: Rob Herring Reviewed-by: Anup Patel --- v4: - Add Reviewed-by (this time for real ;-), v3: - Add Reviewed-by, v2: - Split in two patches. --- Documentation/devicetree/bindings/timer/sifive,clint.yaml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Documentation/devicetree/bindings/timer/sifive,clint.yaml b/Documentation/devicetree/bindings/timer/sifive,clint.yaml index fe4b73c3f269fc0f..e64f46339079fa3f 100644 --- a/Documentation/devicetree/bindings/timer/sifive,clint.yaml +++ b/Documentation/devicetree/bindings/timer/sifive,clint.yaml @@ -57,10 +57,10 @@ examples: - | timer@2000000 { compatible = "sifive,fu540-c000-clint", "sifive,clint0"; - interrupts-extended = <&cpu1intc 3 &cpu1intc 7 - &cpu2intc 3 &cpu2intc 7 - &cpu3intc 3 &cpu3intc 7 - &cpu4intc 3 &cpu4intc 7>; + interrupts-extended = <&cpu1intc 3>, <&cpu1intc 7>, + <&cpu2intc 3>, <&cpu2intc 7>, + <&cpu3intc 3>, <&cpu3intc 7>, + <&cpu4intc 3>, <&cpu4intc 7>; reg = <0x2000000 0x10000>; }; ...