From patchwork Fri Jan 28 19:31:50 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lutz Koschorreck X-Patchwork-Id: 12728980 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B5818C433F5 for ; Fri, 28 Jan 2022 19:32:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=0z2lXkQ8ik53FJjtJxPEGArWAlMegrkf6n5V8/ysjQE=; b=jGiAJwrr4Za+/j 6yvhK5MPyJDlMOiiqv3KaDPVxyYYaxuoDwhL2RYr/oUZ8FncvWRxnjUAkI9mvcRluNDvtTF7gaCAb 0vkt3nAF2I3j0g2vHcw4qaAcesbNQctVWjUPBJCfXCBeGi3M25DLGqUoaddeJAlN3rmlJMkkMsQ7r DnaAHg8AhjQrVEE3V8u/3gHpUQzWr+vEZ2K2aG1hO23Xh9SilngKghTblwZY9D5Qafg8EgXkjYxLP K5JMtZaNRRnJFPMzZpVw0FVW4h/FwTZTPTaBbD+yYqo2ftoyd2AyQO7ohxjngHOc3Vjur/FW0IoBi +AUG+B3eVEwZD5E0Q7TA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nDWyk-003QHj-DS; Fri, 28 Jan 2022 19:32:14 +0000 Received: from mo4-p01-ob.smtp.rzone.de ([81.169.146.166]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nDWyY-003QEJ-Er; Fri, 28 Jan 2022 19:32:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1643398318; s=strato-dkim-0002; d=ko-hh.de; h=Message-ID:Subject:Cc:To:From:Date:Cc:Date:From:Subject:Sender; bh=5YlNcTtCJN5n71TbHMcDEInsEHXP0BHMHEC9kJEYAL0=; b=RNeiht6tPzmjXga6Dpf/Wv58kWRF/AW13caAhmU6RLT64A5TUYC+PKfnQB4EK6gvJ4 SXKI3eMNMzeKQP9hvKV2C9YOULI522sq7ZYQ0gaswjpEP9/PI6/1WnG0wT9Bqt+LeVsV E9Hw7JZzcL2hd4XlZvQKo6gdZLLJXTDU10fgbYwFX3kkfeEWkBs7/Rfs6lLmsrQf6FbY gThDqfp/3Geyl4rOfT+HG08vNWk2GYKh86iHC3ynScqwmhkNZUAxIwV8yq8332Y3F8sx 4I3VZJNhVfR8xnpZYTQ5hH90TPwnN7SsejLEMvrfPVowQarSTBU366nspbC89w2mWRSf c8gQ== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":OGQBeUWjaN+znm36YqWmJEx4lU5vgP4am+jDJsl40KLIzDO7mhvQTIqgxZ0NBW/c2w==" X-RZG-CLASS-ID: mo00 Received: from odroid-VirtualBox by smtp.strato.de (RZmta 47.38.0 DYNA|AUTH) with ESMTPSA id L5f488y0SJVvxCb (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Fri, 28 Jan 2022 20:31:57 +0100 (CET) Date: Fri, 28 Jan 2022 20:31:50 +0100 From: Lutz Koschorreck To: Rob Herring , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] arm64: dts: meson-sm1-odroid: fix boot loop after reboot Message-ID: <20220128193150.GA1304381@odroid-VirtualBox> MIME-Version: 1.0 Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220128_113202_731686_1AB25A81 X-CRM114-Status: UNSURE ( 9.95 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Since the correct gpio pin is used for enabling tf-io regulator the system did not boot correctly after calling reboot. [ 36.862443] reboot: Restarting system bl31 reboot reason: 0xd bl31 reboot reason: 0x0 system cmd 1. SM1:BL:511f6b:81ca2f;FEAT:A0F83180:20282000;POC:B;RCY:0;SPINOR:0;CHK:1F;EMMC:800;NAND:81;SD?:0;SD:0;READ:0;0.0;CHK:0; bl2_stage_init 0x01 bl2_stage_init 0x81 hw id:▒SM1:BL:511f6b:81ca2f;FEAT:A0F83180:20282000;POC:B;RCY:0;SPINOR:0;CHK:1F;EMMC:800;NAND:81;SD?:0;SD:400;USB:8;LOOP:1;SPINOR:0;CHK:1F;EMMC:800;NAND:81;SD?:0;SD:400;USB:8;LOOP:2;SPINOR:0;CHK:1F;EMMC:800;NAND:81;SD?:0;SD:400;USB:8;LOOP:3;SPINOR:0;CHK:1F;EMMC:800;NAND:81;SD?:0;SD:400;USB:8;LOOP:4;SPINOR:0;CHK:1F;EMMC:800;NAND:81;SD?:0;SD:400;USB:8;LOOP:5;SPINOR:0;CHK:1F;EMMC:800;NAND:81;SD?:0;SD:400;USB:8; Setting the gpio to open drain solves the issue. Signed-off-by: Lutz Koschorreck Reviewed-by: Neil Armstrong --- arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi b/arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi index ed7cd5f53046..ddb1b345397f 100644 --- a/arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi +++ b/arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi @@ -48,7 +48,7 @@ tf_io: gpio-regulator-tf_io { regulator-max-microvolt = <3300000>; vin-supply = <&vcc_5v>; - enable-gpio = <&gpio_ao GPIOE_2 GPIO_ACTIVE_HIGH>; + enable-gpio = <&gpio_ao GPIOE_2 GPIO_OPEN_DRAIN>; enable-active-high; regulator-always-on;