From patchwork Tue Feb 1 06:07:57 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yang Li X-Patchwork-Id: 12731400 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DE0C5C433F5 for ; Tue, 1 Feb 2022 06:09:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=YVZmurnFdp99xqA81VRgBDyJjmZhaN3DvioP2rP/qgQ=; b=3WTW3FP+dYcU5h kBrQaidAdLigf2IMUkRycLgmD4HeJbfCPchfa0/0yiMvESX1NINNKK5qazXWA7IPtXUsubICXW1B+ vMZ8lAZMqFfqV6Aa7K+i7c85cTBWCd8JwWmORxJseM4IvoMVmRnioK2GKuKLPcU7MBlHKPvimlpeZ 8lux1qlg23vR9I1T32AiSBfU1WttbeVR9bUybxf4B7vKL9Lu7LTSd7Cy9bLuoDHapVm1AOKLhRJKr 3fndOGYpLjFNbt3LKKOlGaNxoB6arQgSCA2e5NmxrhzXwjFZ/1NLeMgHb7aQteCjjEellPpyMh0+v NFtB1YphSrAwbxF8bw7Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nEmKm-00BGnV-2P; Tue, 01 Feb 2022 06:08:08 +0000 Received: from out199-7.us.a.mail.aliyun.com ([47.90.199.7]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nEmKi-00BGme-7l for linux-arm-kernel@lists.infradead.org; Tue, 01 Feb 2022 06:08:06 +0000 X-Alimail-AntiSpam: AC=PASS; BC=-1|-1; BR=01201311R201e4; CH=green; DM=||false|; DS=||; FP=0|-1|-1|-1|0|-1|-1|-1; HT=e01e04394; MF=yang.lee@linux.alibaba.com; NM=1; PH=DS; RN=12; SR=0; TI=SMTPD_---0V3MZg10_1643695678; Received: from localhost(mailfrom:yang.lee@linux.alibaba.com fp:SMTPD_---0V3MZg10_1643695678) by smtp.aliyun-inc.com(127.0.0.1); Tue, 01 Feb 2022 14:07:59 +0800 From: Yang Li To: mirela.rabulea@nxp.com Cc: mchehab@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, linux-imx@nxp.com, kernel@pengutronix.de, festevam@gmail.com, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Yang Li , Abaci Robot Subject: [PATCH -next] media: imx-jpeg: Remove unnecessary print function dev_err() Date: Tue, 1 Feb 2022 14:07:57 +0800 Message-Id: <20220201060757.89837-1-yang.lee@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220131_220804_576566_FA758212 X-CRM114-Status: UNSURE ( 8.44 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The print function dev_err() is redundant because platform_get_irq() already prints an error. Eliminate the follow coccicheck warning: ./drivers/media/platform/imx-jpeg/mxc-jpeg.c:2025:3-10: line 2025 is redundant because platform_get_irq() already prints an error Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/media/platform/imx-jpeg/mxc-jpeg.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/platform/imx-jpeg/mxc-jpeg.c b/drivers/media/platform/imx-jpeg/mxc-jpeg.c index fed762491379..77c5134739ea 100644 --- a/drivers/media/platform/imx-jpeg/mxc-jpeg.c +++ b/drivers/media/platform/imx-jpeg/mxc-jpeg.c @@ -2022,7 +2022,6 @@ static int mxc_jpeg_probe(struct platform_device *pdev) for (slot = 0; slot < MXC_MAX_SLOTS; slot++) { dec_irq = platform_get_irq(pdev, slot); if (dec_irq < 0) { - dev_err(&pdev->dev, "Failed to get irq %d\n", dec_irq); ret = dec_irq; goto err_irq; }