From patchwork Tue Feb 15 15:15:25 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markuss Broks X-Patchwork-Id: 12747228 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DCA9C433FE for ; Tue, 15 Feb 2022 15:15:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239584AbiBOPPx (ORCPT ); Tue, 15 Feb 2022 10:15:53 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:38044 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239269AbiBOPPw (ORCPT ); Tue, 15 Feb 2022 10:15:52 -0500 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 97A6F3F309; Tue, 15 Feb 2022 07:15:41 -0800 (PST) Received: by mail-lf1-x134.google.com with SMTP id p22so3928481lfu.5; Tue, 15 Feb 2022 07:15:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vKTphkXZT3foDlA2vu8RQg7J6hKGxIFWk9c2lfj2mpE=; b=n+GFD6nrs6dzOCchDu+dN7CUK/PZehhYcalJouc2j46gQoHuZzs9MJq+v7NbqMutpR 5Th+1cOFpDc8/RDfMkAJM1Fz6cPbHE52Ff4e8qIj673duNTzWxRyMkmdi+N9odMGeeGe MWq0nz4gVf9h4YxV72GlCsZ2PKetcx7f69fJQZ2rfzQMYatRHheGQAdHA7M3B5X9y9xe 0k5iGndcI5qxSufCpqWbX6u8bUQeWnCQifXqS1C0xW2Jk8wUFOnPBHBykQy69UhnX1jo 7FHh1xj4xCB0mz9sSEonI9sJkf3FbQFejTrzVCZfix4MjvHb/wafvPMkNBIMfOZMqSqp qcgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vKTphkXZT3foDlA2vu8RQg7J6hKGxIFWk9c2lfj2mpE=; b=NRnTKa27JxXO40aApdcfzdd68irzEi+pdL+QJ409EUqkzcpF1U47vYwzOYL+1iDSlC cDwbtrMaz2F3F46okfKZkO3jFaYmva24+cutqZyeUHPj+Ts2OG4KaDjMpjcztg7yixi3 sUQfgDAD+A8yuizXiPJJ23MmJNRs8PBgvbQr3xD7sG2vY3RVlWxRSPi5m2cCPXAmTyb7 ZxfEahnfAwvxfve6eXWn75CmFhxqVpS2m7Sd5wwa3cagndFmpLH1Y9IAk5a+ilM0olE2 42sK962GWbDJ8XoonjWOZsdC4Xj8SYn73LqfjIuWSjFQqgeslBofVTWmMVEhELiYeC5Y kbrA== X-Gm-Message-State: AOAM532jHG++wB/YurExEPmjCdNLYoEehEfvq/+lXqqv9Qqi4bOMEIzG hk0ltiGJeLWLRP4NBpdVVIswsr5mzf8V3+eNvho= X-Google-Smtp-Source: ABdhPJxfTQ+Cl50tDzNDqx6vkOnMSUGqfsyDbU+l6JmQOOnJtoIyqhsbn/0Usq11VQcqK6Er9ROv2g== X-Received: by 2002:a05:6512:3ba8:: with SMTP id g40mr1672788lfv.75.1644938139714; Tue, 15 Feb 2022 07:15:39 -0800 (PST) Received: from nergzd-desktop.localdomain ([62.122.67.26]) by smtp.gmail.com with ESMTPSA id t12sm4479598ljc.97.2022.02.15.07.15.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Feb 2022 07:15:39 -0800 (PST) From: Markuss Broks To: linux-kernel@vger.kernel.org Cc: phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, Markuss Broks , Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Henrik Rydberg , Stephen Rothwell , linux-input@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH v3 1/2] dt-bindings: input/touchscreen: bindings for Imagis Date: Tue, 15 Feb 2022 17:15:25 +0200 Message-Id: <20220215151527.84634-2-markuss.broks@gmail.com> X-Mailer: git-send-email 2.35.0 In-Reply-To: <20220215151527.84634-1-markuss.broks@gmail.com> References: <1644531943.391463.3262540.nullmailer@robh.at.kernel.org> <20220215151527.84634-1-markuss.broks@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org This patch adds device-tree bindings for the Imagis IST3038C touch screen IC. Signed-off-by: Markuss Broks --- .../input/touchscreen/imagis,ist3038c.yaml | 75 +++++++++++++++++++ .../devicetree/bindings/vendor-prefixes.yaml | 2 + 2 files changed, 77 insertions(+) create mode 100644 Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml diff --git a/Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml b/Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml new file mode 100644 index 000000000000..7b127817e1f6 --- /dev/null +++ b/Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml @@ -0,0 +1,75 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/input/touchscreen/imagis,ist3038c.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Imagis IST30XXC family touchscreen controller bindings + +maintainers: + - Markuss Broks + +allOf: + - $ref: touchscreen.yaml# + +properties: + $nodename: + pattern: "^touchscreen(@.*)?$" + + compatible: + items: + - enum: + - imagis,ist3038c + + reg: + description: I2C address + + interrupts: + maxItems: 1 + + vdd-supply: + description: Power supply regulator for the chip + + vddio-supply: + description: Power supply regulator for the I2C bus + + touchscreen-size-x: true + touchscreen-size-y: true + touchscreen-fuzz-x: true + touchscreen-fuzz-y: true + touchscreen-inverted-x: true + touchscreen-inverted-y: true + touchscreen-swapped-x-y: true + +additionalProperties: false + +required: + - compatible + - reg + - interrupts + - touchscreen-size-x + - touchscreen-size-y + +examples: + - | + #include + i2c { + #address-cells = <1>; + #size-cells = <0>; + touchscreen@50 { + compatible = "imagis,ist3038c"; + reg = <0x50>; + interrupt-parent = <&gpio>; + interrupts = <13 IRQ_TYPE_EDGE_FALLING>; + vdd-supply = <&ldo1_reg>; + vddio-supply = <&ldo2_reg>; + touchscreen-size-x = <720>; + touchscreen-size-y = <1280>; + touchscreen-fuzz-x = <10>; + touchscreen-fuzz-y = <10>; + touchscreen-inverted-x; + touchscreen-inverted-y; + }; + }; + +... diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml index cdc851e275f1..9357cdc5aef5 100644 --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml @@ -551,6 +551,8 @@ patternProperties: description: Ingenieurburo Fur Ic-Technologie (I/F/I) "^ilitek,.*": description: ILI Technology Corporation (ILITEK) + "^imagis,.*": + description: Imagis Technologies Co., Ltd. "^img,.*": description: Imagination Technologies Ltd. "^imi,.*": From patchwork Tue Feb 15 15:15:26 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markuss Broks X-Patchwork-Id: 12747229 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B20BC43219 for ; Tue, 15 Feb 2022 15:15:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239638AbiBOPP4 (ORCPT ); Tue, 15 Feb 2022 10:15:56 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:38110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239630AbiBOPPz (ORCPT ); Tue, 15 Feb 2022 10:15:55 -0500 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ADC063F314; Tue, 15 Feb 2022 07:15:44 -0800 (PST) Received: by mail-lf1-x12b.google.com with SMTP id o2so37530285lfd.1; Tue, 15 Feb 2022 07:15:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nc4JofXcyCXI9rUAdB6UvvOcQWEW9MqHVDUGV+ka1X4=; b=RkDNoDhIY+o23IUu6tJViFpr9ZJAZEE4aZSns2LPxg4Bwd3rQPDy4E9A8gTbw/6Pkz Z94YEWqZeyDsNBuQNNmJn8v4r3PjyC7HYAEkYnjBu43VCfn4/lWUt+7e1WT8SBjVTOul Q6ivEYBCjBQi2DPD2oJ1GZSWi2ttGRHvEkhodpgevr2QMHd6zEi4vO207Sebm/4Vt0E8 ThkqxICdNCsjkgXURl9xaN+Xd2gVj/qKnqEugbgCfzoLlIiKHfBvujX4oOLG0NXNjNsm ejGPS6/k3TKbmlwYsDztXcArbNlYmjd7sg9dMicIvOJyKrALC+wUKmieBPWjB9TZAL4/ D+mQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=nc4JofXcyCXI9rUAdB6UvvOcQWEW9MqHVDUGV+ka1X4=; b=4PYkiwluRzKk7IsHcuDH1VLdNLHURU3lRfyHqCf5L6unGESUA0LFj8+8EnbkMGeCmz MNqkQEA7HegLpyZ5qTVbHUrsTtC7c3WIDCBPkCvxS30LqIRfjz4uhxkFMnm9zREPfH4G qtIGqJyVFG3pHDemklqpszNv7fhjmq9x59bPM6MesNBumIn70BaAZ1ifFpEkFcZJf3P0 ZZvGX90ycK5FBtYGLfxCbR0tI2nDNT11tEgvXqWNyw1yZCb2z4RYj5BwqHMt1QP+xjwT UQE6iABfrSmKG96wF4HqPVo7cxlPBErN4pv4x3Nj6+/rAG67SKowTNT3nK38CipDaa+N sJBA== X-Gm-Message-State: AOAM532gnadRDb0hSRIsbe2JvKwRWjr8GabTPqFSnBuZgspjMSgdgze1 e32suRRiQJM9+CjbazfxlfxOBtAxmFmEljebmMQ= X-Google-Smtp-Source: ABdhPJytwYQCWqpWA6lxFIBrsGDh6QcZLursEdOTQtSSPiQ2TBhHBEJ4kUXJG+H6Geb3IqWedxkKPA== X-Received: by 2002:a05:6512:138f:: with SMTP id p15mr3477767lfa.597.1644938142757; Tue, 15 Feb 2022 07:15:42 -0800 (PST) Received: from nergzd-desktop.localdomain ([62.122.67.26]) by smtp.gmail.com with ESMTPSA id t12sm4479598ljc.97.2022.02.15.07.15.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Feb 2022 07:15:42 -0800 (PST) From: Markuss Broks To: linux-kernel@vger.kernel.org Cc: phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, Markuss Broks , Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Henrik Rydberg , Stephen Rothwell , linux-input@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH v3 2/2] Input: add Imagis touchscreen driver Date: Tue, 15 Feb 2022 17:15:26 +0200 Message-Id: <20220215151527.84634-3-markuss.broks@gmail.com> X-Mailer: git-send-email 2.35.0 In-Reply-To: <20220215151527.84634-1-markuss.broks@gmail.com> References: <1644531943.391463.3262540.nullmailer@robh.at.kernel.org> <20220215151527.84634-1-markuss.broks@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Add support for the IST3038C touchscreen IC from Imagis, based on downstream driver. The driver supports multi-touch (10 touch points) The IST3038C IC supports touch keys, but the support isn't added because the touch screen used for testing doesn't utilize touch keys. Looking at the downstream driver, it is possible to add support for other Imagis ICs of IST30**C series. Signed-off-by: Markuss Broks --- MAINTAINERS | 6 + drivers/input/touchscreen/Kconfig | 10 + drivers/input/touchscreen/Makefile | 1 + drivers/input/touchscreen/imagis.c | 330 +++++++++++++++++++++++++++++ 4 files changed, 347 insertions(+) create mode 100644 drivers/input/touchscreen/imagis.c diff --git a/MAINTAINERS b/MAINTAINERS index a899828a8d4e..f7f717ae926a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -9405,6 +9405,12 @@ F: Documentation/devicetree/bindings/iio/afe/current-sense-shunt.yaml F: Documentation/devicetree/bindings/iio/afe/voltage-divider.yaml F: drivers/iio/afe/iio-rescale.c +IMAGIS TOUCHSCREEN DRIVER +M: Markuss Broks +S: Maintained +F: Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml +F: drivers/input/touchscreen/imagis.c + IKANOS/ADI EAGLE ADSL USB DRIVER M: Matthieu Castet M: Stanislaw Gruszka diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig index 2f6adfb7b938..6810b4b094e8 100644 --- a/drivers/input/touchscreen/Kconfig +++ b/drivers/input/touchscreen/Kconfig @@ -1367,4 +1367,14 @@ config TOUCHSCREEN_ZINITIX To compile this driver as a module, choose M here: the module will be called zinitix. +config TOUCHSCREEN_IMAGIS + tristate "Imagis touchscreen support" + depends on I2C + help + Say Y here if you have an Imagis IST30xxC touchscreen. + If unsure, say N. + + To compile this driver as a module, choose M here: the + module will be called imagis. + endif diff --git a/drivers/input/touchscreen/Makefile b/drivers/input/touchscreen/Makefile index 39a8127cf6a5..989bb1d563d3 100644 --- a/drivers/input/touchscreen/Makefile +++ b/drivers/input/touchscreen/Makefile @@ -115,3 +115,4 @@ obj-$(CONFIG_TOUCHSCREEN_ROHM_BU21023) += rohm_bu21023.o obj-$(CONFIG_TOUCHSCREEN_RASPBERRYPI_FW) += raspberrypi-ts.o obj-$(CONFIG_TOUCHSCREEN_IQS5XX) += iqs5xx.o obj-$(CONFIG_TOUCHSCREEN_ZINITIX) += zinitix.o +obj-$(CONFIG_TOUCHSCREEN_IMAGIS) += imagis.o diff --git a/drivers/input/touchscreen/imagis.c b/drivers/input/touchscreen/imagis.c new file mode 100644 index 000000000000..5e2f6425cde8 --- /dev/null +++ b/drivers/input/touchscreen/imagis.c @@ -0,0 +1,330 @@ +// SPDX-License-Identifier: GPL-2.0-only + +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#define IST3038C_HIB_ACCESS (0x800B << 16) +#define IST3038C_DIRECT_ACCESS BIT(31) +#define IST3038C_REG_CHIPID 0x40001000 +#define IST3038C_REG_HIB_BASE 0x30000100 +#define IST3038C_REG_TOUCH_STATUS (IST3038C_REG_HIB_BASE | IST3038C_HIB_ACCESS) +#define IST3038C_REG_TOUCH_COORD (IST3038C_REG_HIB_BASE | IST3038C_HIB_ACCESS | 0x8) +#define IST3038C_REG_INTR_MESSAGE (IST3038C_REG_HIB_BASE | IST3038C_HIB_ACCESS | 0x4) +#define IST3038C_WHOAMI 0x38c +#define IST3038C_CHIP_ON_DELAY 60 // ms +#define IST3038C_I2C_RETRY_COUNT 3 +#define IST3038C_MAX_SUPPORTED_FINGER_NUM 10 +#define IST3038C_X_MASK GENMASK(23, 12) +#define IST3038C_X_SHIFT 12 +#define IST3038C_Y_MASK GENMASK(11, 0) +#define IST3038C_AREA_MASK GENMASK(27, 24) +#define IST3038C_AREA_SHIFT 24 +#define IST3038C_FINGER_COUNT_MASK GENMASK(15, 12) +#define IST3038C_FINGER_COUNT_SHIFT 12 +#define IST3038C_FINGER_STATUS_MASK GENMASK(9, 0) + +struct imagis_ts { + struct i2c_client *client; + struct input_dev *input_dev; + struct touchscreen_properties prop; + struct regulator_bulk_data supplies[2]; +}; + +static int imagis_i2c_read_reg(struct imagis_ts *ts, + unsigned int reg, unsigned int *buffer) +{ + __be32 reg_be = cpu_to_be32(reg); + struct i2c_msg msg[] = { + { + .addr = ts->client->addr, + .flags = 0, + .buf = (unsigned char *)®_be, + .len = sizeof(reg_be), + }, { + .addr = ts->client->addr, + .flags = I2C_M_RD, + .buf = (unsigned char *)buffer, + .len = sizeof(reg_be), + }, + }; + int ret, error; + int retry = IST3038C_I2C_RETRY_COUNT; + + do { // The controller might need several reads until it returns a value + ret = i2c_transfer(ts->client->adapter, msg, ARRAY_SIZE(msg)); + if (ret == ARRAY_SIZE(msg)) { + *buffer = be32_to_cpu(*buffer); + return 0; + } + + error = ret < 0 ? ret : -EIO; + dev_err(&ts->client->dev, + "%s - i2c_transfer failed: %d (%d)\n", + __func__, error, ret); + } while (--retry); + + return error; +} + +static irqreturn_t imagis_interrupt(int irq, void *dev_id) +{ + struct imagis_ts *ts = dev_id; + unsigned int finger_status, intr_message; + int error, i, finger_count, finger_pressed; + + error = imagis_i2c_read_reg(ts, IST3038C_REG_INTR_MESSAGE, &intr_message); + if (error) { + dev_err(&ts->client->dev, "failed to read the interrupt message\n"); + return IRQ_HANDLED; + } + + finger_count = (intr_message & IST3038C_FINGER_COUNT_MASK) >> IST3038C_FINGER_COUNT_SHIFT; + finger_pressed = intr_message & IST3038C_FINGER_STATUS_MASK; + if (finger_count > IST3038C_MAX_SUPPORTED_FINGER_NUM) { + dev_err(&ts->client->dev, "finger count is more than maximum supported\n"); + return IRQ_HANDLED; + } + + for (i = 0; i < finger_count; i++) { + error = imagis_i2c_read_reg(ts, IST3038C_REG_TOUCH_COORD + (i * 4), &finger_status); + if (error) { + dev_err(&ts->client->dev, "failed to read coordinates for finger %d\n", i); + return IRQ_HANDLED; + } + input_mt_slot(ts->input_dev, i); + input_mt_report_slot_state(ts->input_dev, MT_TOOL_FINGER, + finger_pressed & BIT(i)); + touchscreen_report_pos(ts->input_dev, &ts->prop, + (finger_status & IST3038C_X_MASK) >> IST3038C_X_SHIFT, + finger_status & IST3038C_Y_MASK, 1); + input_report_abs(ts->input_dev, ABS_MT_TOUCH_MAJOR, + (finger_status & IST3038C_AREA_MASK) >> IST3038C_AREA_SHIFT); + } + input_mt_sync_frame(ts->input_dev); + input_sync(ts->input_dev); + + return IRQ_HANDLED; +} + +static int imagis_start(struct imagis_ts *ts) +{ + int error; + + error = regulator_bulk_enable(ARRAY_SIZE(ts->supplies), + ts->supplies); + if (error) { + dev_err(&ts->client->dev, + "Failed to enable regulators: %d\n", error); + return error; + } + + msleep(IST3038C_CHIP_ON_DELAY); + + enable_irq(ts->client->irq); + return 0; +} + +static int imagis_stop(struct imagis_ts *ts) +{ + int error = 0; + + disable_irq(ts->client->irq); + + error = regulator_bulk_disable(ARRAY_SIZE(ts->supplies), + ts->supplies); + if (error) + dev_err(&ts->client->dev, + "Failed to disable regulators: %d\n", error); + return error; +} + +static int imagis_input_open(struct input_dev *dev) +{ + struct imagis_ts *ts = input_get_drvdata(dev); + + return imagis_start(ts); +} + +static void imagis_input_close(struct input_dev *dev) +{ + struct imagis_ts *ts = input_get_drvdata(dev); + + imagis_stop(ts); +} + +static int imagis_init_input_dev(struct imagis_ts *ts) +{ + struct input_dev *input_dev; + int error; + + input_dev = devm_input_allocate_device(&ts->client->dev); + if (!input_dev) + return -ENOMEM; + + ts->input_dev = input_dev; + + input_dev->name = "Imagis capacitive touchscreen"; + input_dev->phys = "input/ts"; + input_dev->id.bustype = BUS_I2C; + input_dev->open = imagis_input_open; + input_dev->close = imagis_input_close; + + input_set_drvdata(input_dev, ts); + + input_set_capability(input_dev, EV_ABS, ABS_MT_POSITION_X); + input_set_capability(input_dev, EV_ABS, ABS_MT_POSITION_Y); + input_set_abs_params(input_dev, ABS_MT_TOUCH_MAJOR, 0, 255, 0, 0); + + touchscreen_parse_properties(input_dev, true, &ts->prop); + if (!ts->prop.max_x || !ts->prop.max_y) { + dev_err(&ts->client->dev, + "Touchscreen-size-x and/or touchscreen-size-y not set in dts\n"); + return -EINVAL; + } + + error = input_mt_init_slots(input_dev, IST3038C_MAX_SUPPORTED_FINGER_NUM, + INPUT_MT_DIRECT | INPUT_MT_DROP_UNUSED); + if (error) { + dev_err(&ts->client->dev, + "Failed to initialize MT slots: %d", error); + return error; + } + + error = input_register_device(input_dev); + if (error) { + dev_err(&ts->client->dev, + "Failed to register input device: %d", error); + return error; + } + + return 0; +} + +static int imagis_init_regulators(struct imagis_ts *ts) +{ + struct i2c_client *client = ts->client; + int error; + + ts->supplies[0].supply = "vdd"; + ts->supplies[1].supply = "vddio"; + error = devm_regulator_bulk_get(&client->dev, + ARRAY_SIZE(ts->supplies), + ts->supplies); + if (error < 0) { + dev_err(&client->dev, "Failed to get regulators: %d\n", error); + return error; + } + + return 0; +} + +static int imagis_probe(struct i2c_client *i2c) +{ + struct device *dev; + struct imagis_ts *ts; + int chip_id, ret; + + dev = &i2c->dev; + + ts = devm_kzalloc(dev, sizeof(*ts), GFP_KERNEL); + if (!ts) + return -ENOMEM; + + ts->client = i2c; + + ret = imagis_init_regulators(ts); + if (ret) + return dev_err_probe(dev, ret, "regulator init error: %d\n", ret); + + ret = regulator_bulk_enable(ARRAY_SIZE(ts->supplies), + ts->supplies); + if (ret) + return dev_err_probe(dev, ret, "failed to enable regulators: %d\n", ret); + + msleep(IST3038C_CHIP_ON_DELAY); + + ret = imagis_i2c_read_reg(ts, IST3038C_REG_CHIPID | IST3038C_DIRECT_ACCESS, &chip_id); + if (ret) + return dev_err_probe(dev, ret, "chip ID read failure: %d\n", ret); + + if (chip_id == IST3038C_WHOAMI) + dev_dbg(dev, "Detected IST3038C chip\n"); + else + return dev_err_probe(dev, -EINVAL, "unknown chip ID: 0x%x\n", chip_id); + + ret = devm_request_threaded_irq(dev, i2c->irq, + NULL, imagis_interrupt, + IRQF_ONESHOT | IRQF_TRIGGER_FALLING | IRQF_NO_AUTOEN, + "imagis-touchscreen", ts); + if (ret) + return dev_err_probe(dev, ret, "IRQ allocation failure: %d\n", ret); + + ret = imagis_init_input_dev(ts); + if (ret) + return dev_err_probe(dev, ret, "input subsystem init error: %d\n", ret); + + return 0; +} + +static int __maybe_unused imagis_suspend(struct device *dev) +{ + struct i2c_client *client = to_i2c_client(dev); + struct imagis_ts *ts = i2c_get_clientdata(client); + + mutex_lock(&ts->input_dev->mutex); + + if (input_device_enabled(ts->input_dev)) + imagis_stop(ts); + + mutex_unlock(&ts->input_dev->mutex); + + return 0; +} + +static int __maybe_unused imagis_resume(struct device *dev) +{ + struct i2c_client *client = to_i2c_client(dev); + struct imagis_ts *ts = i2c_get_clientdata(client); + int ret = 0; + + mutex_lock(&ts->input_dev->mutex); + + if (input_device_enabled(ts->input_dev)) + ret = imagis_start(ts); + + mutex_unlock(&ts->input_dev->mutex); + + return ret; +} + +static SIMPLE_DEV_PM_OPS(imagis_pm_ops, imagis_suspend, imagis_resume); + +#ifdef CONFIG_OF +static const struct of_device_id imagis_of_match[] = { + { .compatible = "imagis,ist3038c", }, + { }, +}; +MODULE_DEVICE_TABLE(i2c, imagis_of_match); +#endif + +static struct i2c_driver imagis_ts_driver = { + .driver = { + .name = "imagis-touchscreen", + .pm = &imagis_pm_ops, + .of_match_table = of_match_ptr(imagis_of_match), + }, + .probe_new = imagis_probe, +}; + +module_i2c_driver(imagis_ts_driver); + +MODULE_DESCRIPTION("Imagis IST3038C Touchscreen Driver"); +MODULE_AUTHOR("Markuss Broks "); +MODULE_LICENSE("GPL");