From patchwork Thu Feb 17 04:41:32 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dominique Martinet X-Patchwork-Id: 12749371 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E235DC433F5 for ; Thu, 17 Feb 2022 04:43:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LAFNLXaKKA2gNVjCgBy+fKZyhUssf4xVJ870tAvS1X8=; b=LaKG+bFJsJP5bj rD5RB3Hh2sJB2yO70H/hK0gEgZXWyPYMHtnztTgAk13udPGSGmLpg1+DvfXTSjHYCyKQmowE4wXy2 e0rnDQ4OBx35XvyNyj8ETXmhnkENN5LxkxpZSk/LrH6ZO/B6OxCdzdQa+vUxiyI9ki8q2kT5IbMK5 MeYjyFKXYZTH2gq0dtL79TExhdMEVxmz1damt1sEJMUcsroOkYgDK27HDkA6wKSlcbpy/ftEnpTkc QttKueODxta0UcJYDbdL281kQXIxO7MSdq1S+uzjE9yAmRFq+Oxir8Ff/L9aqh5RQTjQI+3ezj331 NcSu924Zp6hPVEAuwKnA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nKYc9-008wDJ-KB; Thu, 17 Feb 2022 04:41:57 +0000 Received: from gw2.atmark-techno.com ([35.74.137.57]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nKYc6-008wCu-7G for linux-arm-kernel@lists.infradead.org; Thu, 17 Feb 2022 04:41:55 +0000 Received: from gw2.atmark-techno.com (localhost [127.0.0.1]) by gw2.atmark-techno.com (Postfix) with ESMTP id 8A40C20D6A for ; Thu, 17 Feb 2022 13:41:48 +0900 (JST) Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by gw2.atmark-techno.com (Postfix) with ESMTPS id AE98820D69 for ; Thu, 17 Feb 2022 13:41:47 +0900 (JST) Received: by mail-pl1-f199.google.com with SMTP id p5-20020a170902bd0500b00148cb2d29ecso2018487pls.4 for ; Wed, 16 Feb 2022 20:41:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BKsjr+x4bYzy8xFM4/3x570D+BJpN9nVsFl77PyeRNg=; b=v35W9mROgGVbVXXrguP67bO8n6GITg1htt4QeAapoE0BKGgdHBM74Y3/ENnEiQ0NW/ ndzPi5B170LCnpHiKE2b7pJpsfJ1yiy2sLFqrjKyHPdX6M9Gk7aata5pDolYMnyzoVEC oqrvgcm6pRfSShIgTkLqDPZQP1jFyB5ilVXm2q6il/joj+byqnsMRn/5rlZvdJ61Q0lY yVYP7XR4Jd3GPUbtkfc735Dcn4nvaVxoZY0ahWOtITh88Inycz0frBRcHyzG5zIJOVaG tDOBnJ6/CdiOPFcRsmP7RMcTNZ7VQPcJ5ebOUif9Ax1jrFHn/Dk5Gx6j/99xh6v5Ln4e 3Lww== X-Gm-Message-State: AOAM533pVOFrUqiQoXYL5kmAiZPZXRNLf+/H8bQXCnzgUFHQZt1pHf8F 1QFYL98AjBanI7LICJYpbe0/p3eqq2cZ2No2eRl3mGzSxNDPyLovfkba6TB6eSd7kR3bWIcID5f B90WsPZxkULUjUcG3IxDi5MVLnt/jEtDQSAmd X-Received: by 2002:a17:902:9a8e:b0:14d:ae35:19f9 with SMTP id w14-20020a1709029a8e00b0014dae3519f9mr1269985plp.66.1645072906407; Wed, 16 Feb 2022 20:41:46 -0800 (PST) X-Google-Smtp-Source: ABdhPJyYHbGg95GLg8jdxKJTeG6Rw5yCJLRLB3wzOYl/Ms2jX2K8wdo8xn1KWLpPl3U31H77CuOH3A== X-Received: by 2002:a17:902:9a8e:b0:14d:ae35:19f9 with SMTP id w14-20020a1709029a8e00b0014dae3519f9mr1269975plp.66.1645072906139; Wed, 16 Feb 2022 20:41:46 -0800 (PST) Received: from pc-0115 (35.112.198.104.bc.googleusercontent.com. [104.198.112.35]) by smtp.gmail.com with ESMTPSA id j15sm48674401pfj.102.2022.02.16.20.41.45 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 16 Feb 2022 20:41:45 -0800 (PST) Received: from martinet by pc-0115 with local (Exim 4.95) (envelope-from ) id 1nKYbv-008JBg-6L; Thu, 17 Feb 2022 13:41:43 +0900 From: Dominique Martinet To: Oleksij Rempel , Daniel Lezcano Cc: "Rafael J . Wysocki" , Amit Kucheria , Zhang Rui , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, =?utf-8?q?Petr_Bene=C5=A1?= , Dominique Martinet Subject: [PATCH] thermal/drivers/imx: add missing pm_runtime_put on error path Date: Thu, 17 Feb 2022 13:41:32 +0900 Message-Id: <20220217044132.1980370-1-dominique.martinet@atmark-techno.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20211117103426.81813-1-o.rempel@pengutronix.de> References: <20211117103426.81813-1-o.rempel@pengutronix.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220216_204154_552781_B96A0BB9 X-CRM114-Status: GOOD ( 12.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org We took a reference so need to put it back when imx_get_temp() returns EAGAIN. Fixes: 4cf2ddf16e17 ("thermal/drivers/imx: Implement runtime PM support") Signed-off-by: Dominique Martinet --- stumbled upon this merging our stable tree, but I don't actually use imx-thermal so haven't tested it. drivers/thermal/imx_thermal.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/thermal/imx_thermal.c b/drivers/thermal/imx_thermal.c index 16663373b682..641f90f9c750 100644 --- a/drivers/thermal/imx_thermal.c +++ b/drivers/thermal/imx_thermal.c @@ -265,6 +265,7 @@ static int imx_get_temp(struct thermal_zone_device *tz, int *temp) if ((val & soc_data->temp_valid_mask) == 0) { dev_dbg(&tz->device, "temp measurement never finished\n"); + pm_runtime_put(data->dev); return -EAGAIN; }