From patchwork Thu Feb 17 22:02:49 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shannon Nelson X-Patchwork-Id: 12750685 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8DEFC433EF for ; Thu, 17 Feb 2022 22:03:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343753AbiBQWDQ (ORCPT ); Thu, 17 Feb 2022 17:03:16 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:52588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237360AbiBQWDP (ORCPT ); Thu, 17 Feb 2022 17:03:15 -0500 Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CCEB141FAF for ; Thu, 17 Feb 2022 14:03:00 -0800 (PST) Received: by mail-pf1-x42f.google.com with SMTP id p8so799592pfh.8 for ; Thu, 17 Feb 2022 14:03:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=CNTw7K+ZNV4HqVHbsbV+Nv600bXCU69KlzCgLh9rjN0=; b=1Zehp62/N7tX1y36b3+ETO5plqoSKwmFOpDwjTB5pMx4WzpZdp9g/VkWFwpA8EnX2J I66Uw1qppQznZDqmoafl+TQlPxWMWz43kdUst8BLsyoONM6W+Jhwz5Fpfj/z91Y6+XZF ScPYqV7T6tEpVk4wpqixrYGcw7uHThogkljnHsjIOFa9AmViPLFws4fIIdHQcrEbqVaF NX+RvzVXut4itDbnmrEHcJbilk8r3ozsWc2OxW1hlaBbAr+X9nSQB6owrB28E8f7pU4+ zT8aH5b9t3cioY0zHVba5THbSsQyQ/h2rpiczR2CQiDDPgw+1xtuYcjZcU977gApkjm3 3pkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=CNTw7K+ZNV4HqVHbsbV+Nv600bXCU69KlzCgLh9rjN0=; b=qKc3d18pcLbAmExu17azjNigru50tWm3TciTUXwdBpDCKRH7HtDbpaz/hyjKzUbrpY F0bdtl8iA4wKfk2gHxK/Bnd2Z52n4FydC87LB8fYHnZmt8E8l+qfA2cHemc0wSoib+QX g2NQ5E8idb6tria0xYSRb3i09qhbvCog8jgvUaGFKyD5/HZxnXTnogAHnus8BUoltPso icOpm13SVYEMv3NOT5z2E/Zp4nzaEYnAwW6QxF0wxZUCneuuooB4Xxk+rG5infgmcJTB fF5NhEdYr2Cp62uF85gdHT2zvY+sN2uIc8PvB+Uo35+HCq/Y4gUPgcqAF/wKmKKv7U45 dbrw== X-Gm-Message-State: AOAM531eavgZ69iXuej9GbEcUvNBFMd8khJPqoHFbGgPZ3+L7Sli2Xdk uLJ6AHqe9Ic1imXV1lAk7WApdw== X-Google-Smtp-Source: ABdhPJwV3W3ZTBGDoDVGjuvhIvhcPeEzUeoZQd01YYH9j5Fo8A4EhenPmsSITQHfeAwaFBoH69/iIw== X-Received: by 2002:a05:6a00:8cc:b0:4cb:b981:2676 with SMTP id s12-20020a056a0008cc00b004cbb9812676mr4762464pfu.5.1645135380338; Thu, 17 Feb 2022 14:03:00 -0800 (PST) Received: from driver-dev1.pensando.io ([12.226.153.42]) by smtp.gmail.com with ESMTPSA id 16sm516119pfm.200.2022.02.17.14.02.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Feb 2022 14:03:00 -0800 (PST) From: Shannon Nelson To: davem@davemloft.net, netdev@vger.kernel.org, kuba@kernel.org Cc: drivers@pensando.io, Shannon Nelson Subject: [PATCH net-next 1/4] ionic: catch transition back to RUNNING with fw_generation 0 Date: Thu, 17 Feb 2022 14:02:49 -0800 Message-Id: <20220217220252.52293-2-snelson@pensando.io> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220217220252.52293-1-snelson@pensando.io> References: <20220217220252.52293-1-snelson@pensando.io> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org In some graceful updates that get initially triggered by the RESET event, especially with older firmware, the fw_generation bits don't change but the fw_status is seen to go to 0 then back to 1. However, the driver didn't perform the restart, remained waiting for fw_generation to change, and got left in limbo. This is because the clearing of idev->fw_status_ready to 0 didn't happen correctly as it was buried in the transition trigger: since the transition down was triggered not here but in the RESET event handler, the clear to 0 didn't happen, so the transition back to 1 wasn't detected. Fix this particular case by bringing the setting of idev->fw_status_ready back out to where it was before. Fixes: 398d1e37f960 ("ionic: add FW_STOPPING state") Signed-off-by: Shannon Nelson --- drivers/net/ethernet/pensando/ionic/ionic_dev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/pensando/ionic/ionic_dev.c b/drivers/net/ethernet/pensando/ionic/ionic_dev.c index 52a1b5cfd8e7..faeedc8db6f4 100644 --- a/drivers/net/ethernet/pensando/ionic/ionic_dev.c +++ b/drivers/net/ethernet/pensando/ionic/ionic_dev.c @@ -206,6 +206,8 @@ int ionic_heartbeat_check(struct ionic *ionic) if (fw_status_ready != idev->fw_status_ready) { bool trigger = false; + idev->fw_status_ready = fw_status_ready; + if (!fw_status_ready && lif && !test_bit(IONIC_LIF_F_FW_RESET, lif->state) && !test_and_set_bit(IONIC_LIF_F_FW_STOPPING, lif->state)) { @@ -222,8 +224,6 @@ int ionic_heartbeat_check(struct ionic *ionic) if (trigger) { struct ionic_deferred_work *work; - idev->fw_status_ready = fw_status_ready; - work = kzalloc(sizeof(*work), GFP_ATOMIC); if (work) { work->type = IONIC_DW_TYPE_LIF_RESET; From patchwork Thu Feb 17 22:02:50 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shannon Nelson X-Patchwork-Id: 12750686 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6447FC433F5 for ; Thu, 17 Feb 2022 22:03:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343758AbiBQWDU (ORCPT ); Thu, 17 Feb 2022 17:03:20 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:52688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237360AbiBQWDQ (ORCPT ); Thu, 17 Feb 2022 17:03:16 -0500 Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5CA5403FC for ; Thu, 17 Feb 2022 14:03:01 -0800 (PST) Received: by mail-pl1-x629.google.com with SMTP id x11so5612413pll.10 for ; Thu, 17 Feb 2022 14:03:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=jQJ7pFSm21WercEn0AYeLf5norbKGaKCEfK7COBn1I8=; b=gU9gh+eqM0ufzbMZgLJBU5+wIO3m4m2422Haz3qSQLfsI6FSJ+Pmi5s/JTZa1aOoqk CAcEOp+NILU1S3csecgOLmcUhRr6wG68wNxZp9f+/59pvPIZZqw5+1jDS/+p37XA5gL+ OyZbZFZ/AbzQn3EFT3IqpQFd3P+9EX5rhQE4Gl32j7QDihmnIL6ywTR846FlbmZNTRvk doeU8S/AzmUX5SDFERVxrPnS7DhHrE3i518NhVWupKotUX3XDkbxQM+rx5ierIZRIa5g WJ2KGJsnKMJA8YEM/jhH1NmS/u914XjDvn0O25THcE/4nkF8bUkmgZ/l0IfTQCSBdO33 nI2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=jQJ7pFSm21WercEn0AYeLf5norbKGaKCEfK7COBn1I8=; b=ucuPZQWqYbqX3fdwvRRVW+fG2D40xeMCMObR8EtFwbywoQPk/hrmLLDbbTpipSU6XH jvuyk4OR2bAMlV01HfDvoNSCkk5tOgWOZqi29P6NiyxscS5wHdY42PkLLjaV7F6WgabI 45CrPfTNmPZUtCEKfnCUrEh2Gqls841OaOXPpbDoRRsnrbxhac/Xl0rGiKxbuzudXS3T CL5icA7OxOaz/sSsTWambUDwnhHN83AYueQ6FQFpmQTw4Tw6/f4MOemhsMYqVhBMjeIK 49pX7RW+Zt5fvG0DI5x196OV3cFUpVSbDo6GwwfFfDlklOJPtNwDZolH80oYs+K9Pty7 Gavg== X-Gm-Message-State: AOAM5304Wm4TyXrM2pdk/5+tm6+hfc193Ud1wBiznCQTTsXRdZv94v7H bHGm59mfTzdQ/crFqO6TXYmoXC0NlYKXMA== X-Google-Smtp-Source: ABdhPJya8DrrVQ7/tbbki0NE/DNhlpTJtNtNoAUQFgYI2aflK7etkTZ+wrIAMxj/Bs4oLv/+xQzoNQ== X-Received: by 2002:a17:902:d2c9:b0:14d:c8dd:7716 with SMTP id n9-20020a170902d2c900b0014dc8dd7716mr4692316plc.138.1645135381397; Thu, 17 Feb 2022 14:03:01 -0800 (PST) Received: from driver-dev1.pensando.io ([12.226.153.42]) by smtp.gmail.com with ESMTPSA id 16sm516119pfm.200.2022.02.17.14.03.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Feb 2022 14:03:01 -0800 (PST) From: Shannon Nelson To: davem@davemloft.net, netdev@vger.kernel.org, kuba@kernel.org Cc: drivers@pensando.io, Brett Creeley Subject: [PATCH net-next 2/4] ionic: Use vzalloc for large per-queue related buffers Date: Thu, 17 Feb 2022 14:02:50 -0800 Message-Id: <20220217220252.52293-3-snelson@pensando.io> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220217220252.52293-1-snelson@pensando.io> References: <20220217220252.52293-1-snelson@pensando.io> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org From: Brett Creeley Use vzalloc for per-queue info structs that don't need any DMA mapping to help relieve memory pressure found when used in our limited SOC environment. Signed-off-by: Brett Creeley --- drivers/net/ethernet/pensando/ionic/ionic_lif.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/net/ethernet/pensando/ionic/ionic_lif.c b/drivers/net/ethernet/pensando/ionic/ionic_lif.c index 542e395fb037..4101529c300b 100644 --- a/drivers/net/ethernet/pensando/ionic/ionic_lif.c +++ b/drivers/net/ethernet/pensando/ionic/ionic_lif.c @@ -393,11 +393,11 @@ static void ionic_qcq_free(struct ionic_lif *lif, struct ionic_qcq *qcq) ionic_qcq_intr_free(lif, qcq); if (qcq->cq.info) { - devm_kfree(dev, qcq->cq.info); + vfree(qcq->cq.info); qcq->cq.info = NULL; } if (qcq->q.info) { - devm_kfree(dev, qcq->q.info); + vfree(qcq->q.info); qcq->q.info = NULL; } } @@ -528,8 +528,7 @@ static int ionic_qcq_alloc(struct ionic_lif *lif, unsigned int type, new->q.dev = dev; new->flags = flags; - new->q.info = devm_kcalloc(dev, num_descs, sizeof(*new->q.info), - GFP_KERNEL); + new->q.info = vzalloc(num_descs * sizeof(*new->q.info)); if (!new->q.info) { netdev_err(lif->netdev, "Cannot allocate queue info\n"); err = -ENOMEM; @@ -550,8 +549,7 @@ static int ionic_qcq_alloc(struct ionic_lif *lif, unsigned int type, if (err) goto err_out; - new->cq.info = devm_kcalloc(dev, num_descs, sizeof(*new->cq.info), - GFP_KERNEL); + new->cq.info = vzalloc(num_descs * sizeof(*new->cq.info)); if (!new->cq.info) { netdev_err(lif->netdev, "Cannot allocate completion queue info\n"); err = -ENOMEM; @@ -640,14 +638,14 @@ static int ionic_qcq_alloc(struct ionic_lif *lif, unsigned int type, err_out_free_q: dma_free_coherent(dev, new->q_size, new->q_base, new->q_base_pa); err_out_free_cq_info: - devm_kfree(dev, new->cq.info); + vfree(new->cq.info); err_out_free_irq: if (flags & IONIC_QCQ_F_INTR) { devm_free_irq(dev, new->intr.vector, &new->napi); ionic_intr_free(lif->ionic, new->intr.index); } err_out_free_q_info: - devm_kfree(dev, new->q.info); + vfree(new->q.info); err_out_free_qcq: devm_kfree(dev, new); err_out: From patchwork Thu Feb 17 22:02:51 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shannon Nelson X-Patchwork-Id: 12750687 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27E33C433FE for ; Thu, 17 Feb 2022 22:03:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343759AbiBQWDU (ORCPT ); Thu, 17 Feb 2022 17:03:20 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:52760 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343755AbiBQWDR (ORCPT ); Thu, 17 Feb 2022 17:03:17 -0500 Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D049255488 for ; Thu, 17 Feb 2022 14:03:02 -0800 (PST) Received: by mail-pj1-x1033.google.com with SMTP id k60-20020a17090a4cc200b001b932781f3eso7071171pjh.0 for ; Thu, 17 Feb 2022 14:03:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=9efb25S9TOVCfzp6gKYKn5qGYCYbeJHo3Eb9jSUYesU=; b=bSic3ysthZkvwx24bYP7r5oK5rBAoJbbPe7ekuSM7YA1S6T6haT7MIyAOptf3ENfRE 5xL4+Dsr8thQqcFjBN6NqjVRw2dmBdEYfcULMZF50l7wzvDknbFOLqxxdBzyt/7/Msmj o+h1YeOrpDgNiL9purAi7ZsXM3b1xJyQ20UcvOGS7rjFE7v+KVgBQ/Uif+HIJ4t2bHf5 dzSgv81ApeG+qwMSpIp48MrW67kZ5VyH7f0a0+ehtCs2HwkH6Q33nxK2SeaXK6YL1N7g TGGTHl2IWa1bOrZ12bUvLq17blzyD240YrCvtPaDA3wGtT/IhdLCHynB06hLJcnYltun iBcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=9efb25S9TOVCfzp6gKYKn5qGYCYbeJHo3Eb9jSUYesU=; b=wO0a/q6p4Btns6YGbcBXSmiM63JXHsPWVX0j54ZIZilHyVxVVL3v0UC4zLasTtBJXu jr07bBkWwLpgWjvml79kes1bVb2JZFsH6YnAUDIMyAf/QVLjW8gkABP2tkRgFW7QI0AW pg9k0mk3vQcn++Nc83jRLhW/NXAHMlyvfilM9jFy7FDifI7m18sWcF6vGm+CznGZSykD C/UU46Of8GSUbRu8jFBZbWtCRFZCov+pR76FBzmg3ASRpdXAP6o41KP6ohNxfalzjoYi aVRO06ysL0CuSaQntdBn9e3IiYk4L9Sf5SgkkpBhuaeLrL7HWTNR13i+G311foDlh9yK 3mRQ== X-Gm-Message-State: AOAM532EcLaUx9M3m8ByMnBhI1DjtTxGc/p8g7M9rU/17dx9bKBXYuLi BSkfPhgHhgSH2iG9JiGHiMoUzQ== X-Google-Smtp-Source: ABdhPJxeM6Uy9RVgLEKl5/8NwFS6ePUTrd0QM1TzTdgprwiKHC5MsCFVq15nJjFIPj7yj7eeJhBqyA== X-Received: by 2002:a17:90b:3907:b0:1b8:c6d2:5376 with SMTP id ob7-20020a17090b390700b001b8c6d25376mr9339044pjb.29.1645135382374; Thu, 17 Feb 2022 14:03:02 -0800 (PST) Received: from driver-dev1.pensando.io ([12.226.153.42]) by smtp.gmail.com with ESMTPSA id 16sm516119pfm.200.2022.02.17.14.03.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Feb 2022 14:03:02 -0800 (PST) From: Shannon Nelson To: davem@davemloft.net, netdev@vger.kernel.org, kuba@kernel.org Cc: drivers@pensando.io, Shannon Nelson Subject: [PATCH net-next 3/4] ionic: prefer strscpy over strlcpy Date: Thu, 17 Feb 2022 14:02:51 -0800 Message-Id: <20220217220252.52293-4-snelson@pensando.io> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220217220252.52293-1-snelson@pensando.io> References: <20220217220252.52293-1-snelson@pensando.io> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Replace strlcpy with strscpy to clean up a checkpatch complaint. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/pensando/ionic/ionic_ethtool.c | 6 +++--- drivers/net/ethernet/pensando/ionic/ionic_lif.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c b/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c index 386a5cf1e224..01c22701482d 100644 --- a/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c +++ b/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c @@ -74,10 +74,10 @@ static void ionic_get_drvinfo(struct net_device *netdev, struct ionic_lif *lif = netdev_priv(netdev); struct ionic *ionic = lif->ionic; - strlcpy(drvinfo->driver, IONIC_DRV_NAME, sizeof(drvinfo->driver)); - strlcpy(drvinfo->fw_version, ionic->idev.dev_info.fw_version, + strscpy(drvinfo->driver, IONIC_DRV_NAME, sizeof(drvinfo->driver)); + strscpy(drvinfo->fw_version, ionic->idev.dev_info.fw_version, sizeof(drvinfo->fw_version)); - strlcpy(drvinfo->bus_info, ionic_bus_info(ionic), + strscpy(drvinfo->bus_info, ionic_bus_info(ionic), sizeof(drvinfo->bus_info)); } diff --git a/drivers/net/ethernet/pensando/ionic/ionic_lif.c b/drivers/net/ethernet/pensando/ionic/ionic_lif.c index 4101529c300b..d19d977e5ee6 100644 --- a/drivers/net/ethernet/pensando/ionic/ionic_lif.c +++ b/drivers/net/ethernet/pensando/ionic/ionic_lif.c @@ -3301,7 +3301,7 @@ static void ionic_lif_set_netdev_info(struct ionic_lif *lif) }, }; - strlcpy(ctx.cmd.lif_setattr.name, lif->netdev->name, + strscpy(ctx.cmd.lif_setattr.name, lif->netdev->name, sizeof(ctx.cmd.lif_setattr.name)); ionic_adminq_post_wait(lif, &ctx); From patchwork Thu Feb 17 22:02:52 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shannon Nelson X-Patchwork-Id: 12750688 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0781CC4332F for ; Thu, 17 Feb 2022 22:03:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343762AbiBQWDV (ORCPT ); Thu, 17 Feb 2022 17:03:21 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:52836 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343757AbiBQWDS (ORCPT ); Thu, 17 Feb 2022 17:03:18 -0500 Received: from mail-pg1-x535.google.com (mail-pg1-x535.google.com [IPv6:2607:f8b0:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B21AF606EA for ; Thu, 17 Feb 2022 14:03:03 -0800 (PST) Received: by mail-pg1-x535.google.com with SMTP id p23so6176942pgj.2 for ; Thu, 17 Feb 2022 14:03:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=xgM661NLrkQQIxwVuW6GOr66Aj7/zlrjSXJDGhsTVQw=; b=g1TwXHavscXYPjk9WGovrma7Tu+IUwwoEP22XqPT980krCLMyNg5Xr7h1vZKuA+ar+ v5qjg/cofBVpjLu7NDuJSeuRt74ls0v7RVLWcgODWjNcsuJEv1mnJQxKnYuXpwxsbg0u 4SwDQPeuzexBN63wDr82RlQ0TRuSV2zpNv5nqvJILCMiiVBfwMZocx2YMrRF3bRI9h4Q TH0SZSheLy2NgbWWrCjH7LIBaWJE3Wr25aJux4BLybrgBLKqzCevvDBpPUyoPX0+S0ve zR9xtnlzppxrDt0uXPNqOdDXN8xG0IEhRbd8pIn/bwkHKh9zfKAKPxMI9LrrTo9nvban EpOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=xgM661NLrkQQIxwVuW6GOr66Aj7/zlrjSXJDGhsTVQw=; b=c0jDZph8HgTyPMUuIkRTlL9+WDG5kTxSeIc34tm9DaBNZa2EbeSTnXv6wp4O6kVqST 6Idqx9Oh9rQAKs7CuSXPcDcBKMfxJZOzjmxMMQ2KmBSwRp9yJARshVJdYksWPRdFHq/n gfQ0YXa4HF3yBTM9N9PidU97G8bPDVMBaDV1oW+BHRG1+nL8yrS0+OkBB9kAawX5bcD8 Y8WXNMs22NrMBZKoZbAP5z6STXNlQeRqOfizpc1z+fsT2k1QARTxRevomqo0U/IJv1RR KTQ0YGA3L7S3lx9iYr4nkN1HwfGHq5PYTwk0chXDSI2cLoW1b8bIOvUzefQkOUsHXW7O ODIQ== X-Gm-Message-State: AOAM532ggEExY05ye9nwlUxWWf5Zm6JELBjNdvFolFMu8GQ0F3qmmQ1F 8SIOKGeB0OtblKjzMHi+pBQNbBSs2OU98g== X-Google-Smtp-Source: ABdhPJwysRtY62Dw0oi+8bcui26rNaxl5bWcAYpMfPwSv/WfQFVn2BE2+Os9/lQEdnBl+cJejqCVkw== X-Received: by 2002:a05:6a00:2387:b0:4e0:5414:da5c with SMTP id f7-20020a056a00238700b004e05414da5cmr4953014pfc.85.1645135383238; Thu, 17 Feb 2022 14:03:03 -0800 (PST) Received: from driver-dev1.pensando.io ([12.226.153.42]) by smtp.gmail.com with ESMTPSA id 16sm516119pfm.200.2022.02.17.14.03.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Feb 2022 14:03:02 -0800 (PST) From: Shannon Nelson To: davem@davemloft.net, netdev@vger.kernel.org, kuba@kernel.org Cc: drivers@pensando.io, Shannon Nelson Subject: [PATCH net-next 4/4] ionic: clean up comments and whitespace Date: Thu, 17 Feb 2022 14:02:52 -0800 Message-Id: <20220217220252.52293-5-snelson@pensando.io> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220217220252.52293-1-snelson@pensando.io> References: <20220217220252.52293-1-snelson@pensando.io> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Fix up some checkpatch complaints that have crept in: doubled words words, mispellled words, doubled lines. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/pensando/ionic/ionic_if.h | 6 +++--- drivers/net/ethernet/pensando/ionic/ionic_stats.c | 1 - drivers/net/ethernet/pensando/ionic/ionic_txrx.c | 1 - 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/pensando/ionic/ionic_if.h b/drivers/net/ethernet/pensando/ionic/ionic_if.h index 278610ed7227..4a90f611c611 100644 --- a/drivers/net/ethernet/pensando/ionic/ionic_if.h +++ b/drivers/net/ethernet/pensando/ionic/ionic_if.h @@ -759,7 +759,7 @@ enum ionic_txq_desc_opcode { * IONIC_TXQ_DESC_OPCODE_CSUM_HW: * Offload 16-bit checksum computation to hardware. * If @csum_l3 is set then the packet's L3 checksum is - * updated. Similarly, if @csum_l4 is set the the L4 + * updated. Similarly, if @csum_l4 is set the L4 * checksum is updated. If @encap is set then encap header * checksums are also updated. * @@ -1368,9 +1368,9 @@ union ionic_port_config { * @status: link status (enum ionic_port_oper_status) * @id: port id * @speed: link speed (in Mbps) - * @link_down_count: number of times link went from from up to down + * @link_down_count: number of times link went from up to down * @fec_type: fec type (enum ionic_port_fec_type) - * @xcvr: tranceiver status + * @xcvr: transceiver status */ struct ionic_port_status { __le32 id; diff --git a/drivers/net/ethernet/pensando/ionic/ionic_stats.c b/drivers/net/ethernet/pensando/ionic/ionic_stats.c index fd6806b4a1b9..9859a4432985 100644 --- a/drivers/net/ethernet/pensando/ionic/ionic_stats.c +++ b/drivers/net/ethernet/pensando/ionic/ionic_stats.c @@ -151,7 +151,6 @@ static const struct ionic_stat_desc ionic_rx_stats_desc[] = { IONIC_RX_STAT_DESC(vlan_stripped), }; - #define IONIC_NUM_LIF_STATS ARRAY_SIZE(ionic_lif_stats_desc) #define IONIC_NUM_PORT_STATS ARRAY_SIZE(ionic_port_stats_desc) #define IONIC_NUM_TX_STATS ARRAY_SIZE(ionic_tx_stats_desc) diff --git a/drivers/net/ethernet/pensando/ionic/ionic_txrx.c b/drivers/net/ethernet/pensando/ionic/ionic_txrx.c index d197a70a49c9..f54035455ad6 100644 --- a/drivers/net/ethernet/pensando/ionic/ionic_txrx.c +++ b/drivers/net/ethernet/pensando/ionic/ionic_txrx.c @@ -10,7 +10,6 @@ #include "ionic_lif.h" #include "ionic_txrx.h" - static inline void ionic_txq_post(struct ionic_queue *q, bool ring_dbell, ionic_desc_cb cb_func, void *cb_arg) {