From patchwork Thu Jan 3 07:02:30 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 10746951 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0C4636C2 for ; Thu, 3 Jan 2019 06:56:09 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EED972811A for ; Thu, 3 Jan 2019 06:56:08 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E2ABA285A9; Thu, 3 Jan 2019 06:56:08 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 968FC2811A for ; Thu, 3 Jan 2019 06:56:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=dZ/WmRziQ+nZiR/tSzMXrd2lv04Msj7buYvWn9ooAoo=; b=HBe65Z9lSjnYSU qBGdpuNqd15KWIThgUaTHUjKfupiStbL21yKWY+QussSKYagmOB9LiTGfmxoH9n59D3WOQfwp9ec7 rzKSNGLxhns4cKl4FyZrg99nDXsTB+syZsYSF+gTsM6dlrBtNBfUyz/h2iVXqEYsHsfdd2iw5K0Y+ lUZtqxK6KqEwiiaPgq+bzHUz/SQujIUkbSdkAED/ZkqYawnOJnGs08DUUM47u0ZqFVLe2wqkFvSnA SqRTQ6zR5PuA/obqe/5NGJ7qTtEQuSRtv9XnJuGexaV0PXxWLi/0B7KAK2fPTa+S1sahsJY9+GIfL AQenpTYTN5LEpuIIMMWg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gewvE-00012n-UH; Thu, 03 Jan 2019 06:56:04 +0000 Received: from szxga07-in.huawei.com ([45.249.212.35] helo=huawei.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gewvC-00012D-9B for linux-arm-kernel@lists.infradead.org; Thu, 03 Jan 2019 06:56:03 +0000 Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id DA56ED55FBC52; Thu, 3 Jan 2019 14:55:50 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id 14.3.408.0; Thu, 3 Jan 2019 14:55:43 +0800 From: Wei Yongjun To: Ohad Ben-Cohen , Bjorn Andersson , Maxime Coquelin , Alexandre Torgue , Benjamin Gaignard Subject: [PATCH -next] hwspinlock: fix return value check in stm32_hwspinlock_probe() Date: Thu, 3 Jan 2019 07:02:30 +0000 Message-ID: <1546498950-105456-1-git-send-email-weiyongjun1@huawei.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190102_225602_496611_73BB5436 X-CRM114-Status: UNSURE ( 9.27 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-remoteproc@vger.kernel.org, kernel-janitors@vger.kernel.org, Wei Yongjun , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP In case of error, the function devm_ioremap_resource() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Fixes: f24fcff1d267 ("hwspinlock: add STM32 hwspinlock device") Signed-off-by: Wei Yongjun Acked-by: Benjamin Gaignard --- drivers/hwspinlock/stm32_hwspinlock.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/hwspinlock/stm32_hwspinlock.c b/drivers/hwspinlock/stm32_hwspinlock.c index 34a8e00..4418392 100644 --- a/drivers/hwspinlock/stm32_hwspinlock.c +++ b/drivers/hwspinlock/stm32_hwspinlock.c @@ -57,8 +57,8 @@ static int stm32_hwspinlock_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); io_base = devm_ioremap_resource(&pdev->dev, res); - if (!io_base) - return -ENOMEM; + if (IS_ERR(io_base)) + return PTR_ERR(io_base); array_size = STM32_MUTEX_NUM_LOCKS * sizeof(struct hwspinlock); hw = devm_kzalloc(&pdev->dev, sizeof(*hw) + array_size, GFP_KERNEL);