From patchwork Fri Feb 25 11:23:56 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 12760120 X-Patchwork-Delegate: johannes@sipsolutions.net Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FFADC433FE for ; Fri, 25 Feb 2022 11:24:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239416AbiBYLZW (ORCPT ); Fri, 25 Feb 2022 06:25:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47252 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240081AbiBYLZU (ORCPT ); Fri, 25 Feb 2022 06:25:20 -0500 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam08on2056.outbound.protection.outlook.com [40.107.100.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 14D1C22A254; Fri, 25 Feb 2022 03:24:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FkqG7jIo3Yf82R5DmlVX2Mzo269UUKXefCsTMyvqp+IUfFl6OGR1DBNc88VhdIZXmu+6FcFsl91RVxggzYspZLzpvp2VhtyW+JJvcOcIJxVcK2gWbItCar+cL5XdPuSh9kg5qPX0gzJKap6vit+Ta42Gg/LX+kvnujZWx872b2jErVfsipZZI7lgBo6AEKWhr0z9VF+rNE7TkAXCR5Sy2t4gElYDEWhRviQD3r2rmGPDXvFprYoxjVZGpTalxsjT6heOVXW/2QgliDg04RDICYiB+DtZy2WCrI3Ss7VAg0nKqydZf7cd8Y0CJrWcNkJfRUx1ONadzkaDvBkG7VnjmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wsbao9AgFsXWr7CSUqDXFNwV0J6dnNO5APitxIFWGE4=; b=ATE8gS1F54hVOIl+ubvaxTalAgfQ5jXaNd9IwAQkrvPZKWRrGD0KPWbCYdzCbkVntI/umO1sAU7WMNiVrc5ErQYm2glSIvSSZL7xu+TZ8o2m+T5bfVEV8ozrUJ/Ovha2I+2LT7DT8nCfUXfuKK1zB6yrsAABrE7qfAsSOxMMEu8PW8SWRiOEQvaNtFByBPUlObOXmw0s2VyEtkcPcGIycCYUYTPZyzJHDwFjcNG6ucHfdhDlcK5Iad/OyJ6Y7ZY63yzy2DhdqF7poOds9F2KQBhxR0TOOr1nGkuv1Xd5QZV9gZMgY5kHVjQ7XKpdCMkVua6jJx3bWBdstVnp9L7zQQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wsbao9AgFsXWr7CSUqDXFNwV0J6dnNO5APitxIFWGE4=; b=Fs2RI3TlRS+eDI29bCJJF0qyp3plVkXRbILdhI0iNj1D4/2RVTcfaQa4VmIP1LmQ7TS8N9eTBFaXb45BPBhV87i4Ja5XQ7qwH8ahuG9J8nf4qjddGihyhDQFT0UAadNPnovBXcCoKsNz5/HRoVNf9agLI+RAUhtPsrcZ/uUqu38= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=silabs.com; Received: from PH0PR11MB5657.namprd11.prod.outlook.com (2603:10b6:510:ee::19) by DM6PR11MB4362.namprd11.prod.outlook.com (2603:10b6:5:1dd::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Fri, 25 Feb 2022 11:24:36 +0000 Received: from PH0PR11MB5657.namprd11.prod.outlook.com ([fe80::dd2e:8a4e:fc77:1e66]) by PH0PR11MB5657.namprd11.prod.outlook.com ([fe80::dd2e:8a4e:fc77:1e66%5]) with mapi id 15.20.5017.023; Fri, 25 Feb 2022 11:24:36 +0000 From: Jerome Pouiller To: linux-wireless@vger.kernel.org, Kalle Valo Cc: devel@driverdev.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , =?utf-8?b?SsOpcsO0bWUgUG91?= =?utf-8?b?aWxsZXI=?= Subject: [PATCH 01/10] staging: wfx: sta.o was linked twice Date: Fri, 25 Feb 2022 12:23:56 +0100 Message-Id: <20220225112405.355599-2-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220225112405.355599-1-Jerome.Pouiller@silabs.com> References: <20220225112405.355599-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: PR3P189CA0052.EURP189.PROD.OUTLOOK.COM (2603:10a6:102:53::27) To PH0PR11MB5657.namprd11.prod.outlook.com (2603:10b6:510:ee::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5435dbe8-71fc-423e-ba65-08d9f8516798 X-MS-TrafficTypeDiagnostic: DM6PR11MB4362:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oulICj8vE813wRr2ccSFsMmgnNu6Ze5yW8lVo84u++gQqQ39CKjqSx+1NDWWxJXqtWYWXl7/Ix4f1a1bGiZF50oNocOh/0E/E+SmEZN46PYx84dSYihRyEGzwX/EEa4uS1QydP9ycAh9WwdLFIT8qdsl/kn7t6IEyspOYDXn08V9nusbLwoVpri5mbAWpz61UHKXeK5IdrNpoLfPrLmZ4KNf7uRp7mLIJMV+V2mRv0OqsoKT83msdFdoFJDHNOzC1q5efYazza/H5S8NRO72Hwe64x7e/fuHQhsg0bfhR8Iej4ubG/HCWQ5bpiiOyjyvWhCFIUMe5wLboT5Y/C9xiFj80jXEMV5TfjnHKXKohAiVdI/ZzDpXXkj9X8avu/8joy+IxpsJ6Zlb1ItaDDzAd/ORI65DtGjZdW+ZnoeZsMXrsG+2qpQLik3BpuusvBshpWtB0fbOJssA2UXwMp6dIWrg/J82BlcHZP7Z72yjR4WlJt8osfwtro2Z8LgrFvCrFTBCaMgc2EYiD4HsYg74sQIR9cHWeeJS87qtFfZyvsgc6WMFWA34lZwoPqgyIlR5MNG4MAVxAhpl4kWPmADRRTZECx+9+I6KFSNFTcGnAeAySF/Y9u6kW2x4H4a5nrb4v/g5q5ViTsk+GOJEwfpudKwqLlYvtN2jbSpAlydiHAXINKXYTlixtcrDRTB43L9L9Wq2xynWG8iKJRAfoCcQiAwYJX3lnlShyhDdYs/i5KDeT09NY0URvrcPendYwBxu X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5657.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6512007)(6506007)(1076003)(66946007)(52116002)(8676002)(2616005)(66574015)(26005)(66476007)(5660300002)(66556008)(508600001)(2906002)(83380400001)(54906003)(38100700002)(4326008)(86362001)(6486002)(8936002)(4744005)(186003)(6666004)(107886003)(36756003)(316002)(38350700002)(6916009);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?Hdu0sRAPoLhBzFc4yAMepKYpKmyy?= =?utf-8?q?IJqP5WBhL28tYCxZMT+6NKUukuZMV6ssOEErC9mEPoGiQGsgD1edulKq32WjrArRA?= =?utf-8?q?MNxKc4ZpR/4RuqsgSnHivest7VwS+d+Vwt7B55+uAcfMh9HCm9BiewlYS8n0qTSbJ?= =?utf-8?q?Z4v1KfjBzMojoBoX0jm7nV40FpLXi6xWFo1rDlDDxZ/dLxIGYG+Zt57r+9RPl+jiW?= =?utf-8?q?q97QadmMk3aOrMiudfPkzfCaYt+1tpx9NCs9U7IJI/0SvfWz+HwYkLOKah4bmzo+3?= =?utf-8?q?bfN4Wdia5u4o+oYrSg4Ng/a8tUQSxqc7srTagjggrsr2MFd2Rfl8gLZwfRU9klIs3?= =?utf-8?q?4TwvQ7ejnFhbp4+c1zoW1diIRF4ieo5zSrFlLLNUoqE0NnQdfWNOGJ3w1vtkG0boG?= =?utf-8?q?MagJQp5lpMoboof9AMlyH11nAtVDxM3AXRqCm8CVLcJnRdgNJm4R0UBaHJ1V7ovmH?= =?utf-8?q?jSGyFbdndqukczdj1nAgo1v2avqAqk3NhIYuRdy7iEwn6xsf2lNbO15cJx+G9dPdy?= =?utf-8?q?uDBbaTxvU3yBqe5tIekmyqkXHN0B48maehekPorPohg9Y+8eQJcauhGhMcXX2sO3f?= =?utf-8?q?Q1kPelnGRSfkmIiVkyCoLsq9CyWlhJ1mBqf6dSkkefz7vN1rawJhSHwfP/JMGCql5?= =?utf-8?q?VnxYXffnOuUR62Nt7XZuby1fZ3xkXIQxjgvQhlgoX1Pc0VBEilj1tBSzzWXgaNzin?= =?utf-8?q?WFsugbovCn3AOPLGEiJvfEkzONKT92l/G/q3KQ0ARHc6O63UDI1z/XMm1o7C58vNl?= =?utf-8?q?K2qnCr1txrGtq3D5ZRiFXVoTtvgVLgyiwqGqh5yQC/oqh+o0Z+4nyKHwcgxVXel51?= =?utf-8?q?3hNKVakEWTxJh9qU18ydv+2wSsN31Fj/JNQpoyDL96VYb/fWNbC/Z8B9Ksb5HuWwS?= =?utf-8?q?Qh2TC1reP19/RODDCmC5ruKViqP5ZzpGOzjrbSpdnSsNsVMvK2ARR4Z9RzzSyr2IC?= =?utf-8?q?+pT/SuSKNWp/7PPIoy5jgXwPFuza74I5xz5r5mZETBqvThT59o+LH1k0nshcJK8mO?= =?utf-8?q?64EB6UDAJmWzM8GpA8aOfyaAwHFDXQetr+8TTKIZjaomSjqmWKLjJWQ2+Ov9bTDWZ?= =?utf-8?q?BbFj67MrwhWeXi5LkHoACg4bUg8xEECitD9eCRhJhKX4rnMSAebI6TIwbH73Tc4bl?= =?utf-8?q?hI9P61Fz46JopHP+/qFmrHJGxGmBeGOh/Tya8MRyp4MMcMRlC51ZAxqNNUKgaZYCC?= =?utf-8?q?TPITIzJ4TAsjhf0z34noGwWEzYIjFHwCPrN6kGQ3gSSqK6uiv0umMNDFS2bsmx0hI?= =?utf-8?q?GUHeTZahroVMFSwxG8ajL8vUG9Uk4BcjWS2wp/cPk3fylq9FgKxcNXUNG38HrlUAy?= =?utf-8?q?EC5MS+dOr1XDFkA67dzFttoKSfC3p7HfQed/+SjStReJuWlEwOv6IwbGHRKOZ62I2?= =?utf-8?q?FMZzRlIkiQfwn8YnciKpRR8i9y07AgPybXN3/NShwyF5dGw7C8plPQZaHQI7XiFc6?= =?utf-8?q?BQ8U5Bzmo5apnGOTeea9M37UiO1nH2P0wgRi+3QE/t0tY9PfADoydVD4cMevIAFkp?= =?utf-8?q?UvJSSSY05Q+cqnmy9sJYtNLBByfvmD7nUP/fJeNiAWDmZkF4N+Xi7jc=3D?= X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5435dbe8-71fc-423e-ba65-08d9f8516798 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5657.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2022 11:24:36.6705 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OY3jDGBRcT2H9YG0wQr5nIbsRF82zOLtgkaSmvAdTSuo7pGRWOpWtE2Kxq5F+o4VbIsTGrPPD0LcSO9GCKcdig== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4362 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Jérôme Pouiller sta.o was listed twice in the Makefile. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/Makefile | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/wfx/Makefile b/drivers/staging/wfx/Makefile index ae94c6552d77..c8b356f71c99 100644 --- a/drivers/staging/wfx/Makefile +++ b/drivers/staging/wfx/Makefile @@ -17,7 +17,6 @@ wfx-y := \ sta.o \ key.o \ main.o \ - sta.o \ debug.o wfx-$(CONFIG_SPI) += bus_spi.o # When CONFIG_MMC == m, append to 'wfx-y' (and not to 'wfx-m') From patchwork Fri Feb 25 11:23:57 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 12760121 X-Patchwork-Delegate: johannes@sipsolutions.net Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA9D1C433F5 for ; Fri, 25 Feb 2022 11:24:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240086AbiBYLZZ (ORCPT ); Fri, 25 Feb 2022 06:25:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47292 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239859AbiBYLZV (ORCPT ); Fri, 25 Feb 2022 06:25:21 -0500 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam08on2056.outbound.protection.outlook.com [40.107.100.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4CF8B25314F; Fri, 25 Feb 2022 03:24:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BloQQEUvdjbSvBAdK05vBZRjwgmFqdGh9jeswrv4uuEFqBcQy2frNt+mcAWYVa1rYw80NaXuBFE36cDb5l09jtnUyKlm3cBknFoC5j0CRfdBzO2FijtU/yWszijawNtmDde4OeLsLHDhj9frU+WQU13lr7iaBdFiutuWgDvqYAjkSGINbUeJeLkJY5MFMybEFxxmk87srm/GHH+mi4j4yPTZYk+Dn9UNvDxj7svoGqSvmNMSBAk8LN0Ldp7yByeb7Z2qjQEbhem2oquKf706jqBaSSlmZgzd9UbkdvQo/lEY9tpPSpP7PHkBrCU+jznCV5tOsHj8lkfE09pGg7IJCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aw5J+x9WmNrQK85UXgLKbBaVcp0mTbgxGqM4PrVtJbQ=; b=DIfRPF3HbbBWnmKwuqAMG6DmKaUg1tUVEA0DWb43nqEyCNWU+b6FVCJwzyoRhrjY60PnTg/oG9Q4FgfE4BnzMHeLPpAxx265/o8lYACa+D/wqSGCW9gWqRc8sA6aUO1a19XTRDqL3ON6W2bkKtlVxKOWrGfPrZfM0ZCMlXXWgEEVIkeKseu7igODOzjGmh0ZON4VUHIXDzWA3RWiA0RgDycCBvtin+CemLyI5N6zihkAcH4dxeoy0cGgRD2fKWxj/3JUSUvPM+USn/hzXjKkm3sQaBdqVWXmdCFxMWD2DYK9DDlwBfFUTwDR72Fy7dxR40Gg275LTcb2kyxEGplyFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aw5J+x9WmNrQK85UXgLKbBaVcp0mTbgxGqM4PrVtJbQ=; b=Tvo2lB6BXDwL0Wll+2JmDPIM5mmX5qCCaVuxh0T+OoVe2YXEQvHkuYjcoOwgs2Gn+dmFq+aVkB0nzIrw2tpQI2Y4U9KqeIhJOre5el/hFLclW7ctCOvCxmKTQzdhEWrZ4T47bTvEhCWx35SZvIjljCrHIYyHhzWCDZyP+NWZXYA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=silabs.com; Received: from PH0PR11MB5657.namprd11.prod.outlook.com (2603:10b6:510:ee::19) by DM6PR11MB4362.namprd11.prod.outlook.com (2603:10b6:5:1dd::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Fri, 25 Feb 2022 11:24:41 +0000 Received: from PH0PR11MB5657.namprd11.prod.outlook.com ([fe80::dd2e:8a4e:fc77:1e66]) by PH0PR11MB5657.namprd11.prod.outlook.com ([fe80::dd2e:8a4e:fc77:1e66%5]) with mapi id 15.20.5017.023; Fri, 25 Feb 2022 11:24:41 +0000 From: Jerome Pouiller To: linux-wireless@vger.kernel.org, Kalle Valo Cc: devel@driverdev.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , =?utf-8?b?SsOpcsO0bWUgUG91?= =?utf-8?b?aWxsZXI=?= Subject: [PATCH 02/10] staging: wfx: fix struct alignment Date: Fri, 25 Feb 2022 12:23:57 +0100 Message-Id: <20220225112405.355599-3-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220225112405.355599-1-Jerome.Pouiller@silabs.com> References: <20220225112405.355599-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: PR3P189CA0052.EURP189.PROD.OUTLOOK.COM (2603:10a6:102:53::27) To PH0PR11MB5657.namprd11.prod.outlook.com (2603:10b6:510:ee::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a9933a11-877b-407a-54e8-08d9f85168f7 X-MS-TrafficTypeDiagnostic: DM6PR11MB4362:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9mc2nP4yoyxUqk0RHwN88RLkwOrSmYRx7SRgpGo+xuu8wwHuki/qHiE7KNxyHSXd0guGC4h+jbBtlS6CsdT6e/vpWAEHzOY9b2IuQUKYcStmmCjunU6vwdRvHTJdscOVHuXqbkuNFYvTpm0Yd/e7bvD6g+gJ4gs20RyBZmvSAxp8aC146jF5B4fPLHr36IzcowDsVShMfzYUo9A2JuYMKX0jmc4iMVSLpQRPNyJQ3n3wHNRb12egmbdjau/g4Ar+PlP0vhD9rFQgQyHip7/FJ2TF69uh7ziGPeP1Ps+SKNuFggltiAGteZJS94gjlUlGxcda9e3IyMq7wdqPImGfckanvKw7NkyVhp+LLZaYZx19rHd41UWinTRC1LyDy1N+oGDLisb7DHE0vybGn3um5X8+BTuQmf4zrUbOSAy7sFg6Sn/qrZPWdxMVKBVo4RIzKJsnRuZXOZmD3KuxRF88rpXdRWDcT5wMjVh+10vpPCQujifZUwrojcYCxKBjL852SQr4TdeVrXjRFEULnMOyvscSa5+Dw7KvlPC4ifV7OE/tCtXa/Q7vUQOhPdQBN9nRA51ldBvZj7XvcN8oMaF1vlASlor8Zaq8fyLFnUA1skTPaU8Kj+GWZPz60cI/qqhAVXDBwYUfyJYGbQO8OWTYgCR/Ek/YoqBJs+J1qt7aaAUqM0hCA5ve2pE4g4ja3OEdrlmVBBfdhKF7rdATW8bn3fVItk03CIJUQf11KQamij6cLmBo3fJ4agELtiNEqIbh X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5657.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6512007)(6506007)(1076003)(66946007)(52116002)(8676002)(2616005)(26005)(66476007)(5660300002)(66556008)(508600001)(2906002)(83380400001)(54906003)(38100700002)(4326008)(86362001)(6486002)(8936002)(186003)(6666004)(107886003)(36756003)(316002)(38350700002)(6916009);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?EkbFE9NzifGj6aLC524cPBVjOLGe?= =?utf-8?q?LlIAkc0vIUfi+RrHqS762rPDJMgakaSFGSjsRu1Eqk9bBqPP0a19X0Odch9b9pwo2?= =?utf-8?q?wD4VDwBKVn/k+1KMe+9mzZT61H/v4XamkLOrkjkuafVnCgIO3gBpkSsFnYS+ZJqdK?= =?utf-8?q?8aoMIW2x022GpPTBNUl0VKWcydjO83fuIZFdt2bL1JsZLdi4JLy/MwQUdLXUyGksf?= =?utf-8?q?iLhmhehentV9qIPGCbMqTmx5hXUvUdEEMkz4SA+S/mBo+y0t2xoREJ8Te6xAez06h?= =?utf-8?q?A41vtwIceHsFYN9adrYAcFvbAn2vp9rr/zB9jtKcpsKTiX2z4uj+P/9Amo5dHfOHk?= =?utf-8?q?NmO0krSaJXwZY1pFkWdaIwmrjIF4wLET20ntmcL02UZxlYDpAYLte1DElKxvXuTRs?= =?utf-8?q?NPECWHpWc2YImEkC+mdvjydM64aLkwZebIrHIG4bd5mCU4gxl+/Zm4gMMDuV0NVt9?= =?utf-8?q?quNL0BtTSOi+ICcPk+qT2C2Pjc8CXMqUHLcXrJxFec6XJVa5xx2nO6E6pA7tsiel/?= =?utf-8?q?qdFMiASqOoVu3Hjfp4oAR5Rs19e4HXbzQgXSRiOeExiu7Y/z9Fvi71Ah+J+CHSpMC?= =?utf-8?q?DkiqJtSXkxIb/19Wrtwe+G0ZuxrfG/OEQhHDoeZ0JX2NfjF8Booq6zs5fBGFxcvgC?= =?utf-8?q?Cibn8VWthIIzX6HuDACHPNP3aDz5SdFuEKWZy4LknujvfEQfC5B/7VuwRWOVWwnjO?= =?utf-8?q?Rw+WYQ8IpnEB69IIHETiqg6DRivPbv3W84Xvq692NG494feSFkNj8RN8rG8iYVShF?= =?utf-8?q?U8ibzIsedydwTQhCOamxHG+XVt8buZefsoLK/aSHFfGTvrfn55OyrOlRRLUFS5O5R?= =?utf-8?q?M06w21tHRoimnAsBApPfE8P+jOtmJi/lJ+AwkXAWMVyuOmglopuWbgQ6iL1jz+oSg?= =?utf-8?q?JybZ3cglVnhDSoqC1T7zBIgCdo3qGd6S1M77YiZ2SnAo990HV1Im4ccGkA0cXWjk3?= =?utf-8?q?UQuxauXMBPLt0j1lExrSQwhPQ8uOoNsndAK6iq1zk4e2svRrHAZUewyyBbID0Vtmc?= =?utf-8?q?Qu8mliyv2R/PILFaGzDY+tGFikcfnFVXU5LvRRPNWxt7ZAQGE/hQKayZiKbEhlTwB?= =?utf-8?q?C/O9LOag+gQ72c3qkcOnWvvOoXCMCWvnpUSX2hpVg0hr11ktOdPmkURgknu7e2W3o?= =?utf-8?q?/HBCDbJD13ZC2juH575hXWfwvJlVUildfFl/EJ7c4v/AXyoUtsE+F1YirSmUkWhue?= =?utf-8?q?lDQjkZewPq58ANfubcu276hBbX5HomojSykbm6wyjlkKgWHd4o95W5nf3+I0dhjDs?= =?utf-8?q?SDMSgiOCOz4afPaBz2zhDCMbBkaOo9ZuYMFoac4qL27Y3l7h1z8T5OsI5EFk/0yxW?= =?utf-8?q?9uhIreobQthDI9laNm1rB1qqJ59cR37FN7qRtxBVF16w/DjugmaspmRr5sh58Hxyp?= =?utf-8?q?er0fAxilki3AVbBlY6Xg68Kc2VjYGHRL/cQJNQIJUUXthpg+1ELmfTrSw9eLr8tIS?= =?utf-8?q?1CmAWZZYR5CnFrRH0YA7Mn8ynCSAQmq7Rhm6iOA744/xAtmlpfwihtSUDlY8VckTc?= =?utf-8?q?MVTGasFnfLiMLcfHyWXrXDg/F/rYs6ZVDXHU8I4aX2HkrabzEv20FLM=3D?= X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: a9933a11-877b-407a-54e8-08d9f85168f7 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5657.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2022 11:24:38.7964 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jpG/cEnxn0km1ldQADCooeStKrLyRvpWxkh5h4ospj5PzvkGOlVdw9L6L9+KA794Htnx+gwonODlrSHFztG7Kw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4362 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Jérôme Pouiller There is no reason to add multiple spaces between a variable name and its type. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/bus_spi.c | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/staging/wfx/bus_spi.c b/drivers/staging/wfx/bus_spi.c index 062826aa7e6c..a0a98c074cb5 100644 --- a/drivers/staging/wfx/bus_spi.c +++ b/drivers/staging/wfx/bus_spi.c @@ -65,14 +65,14 @@ static int wfx_spi_copy_from_io(void *priv, unsigned int addr, void *dst, size_t { struct wfx_spi_priv *bus = priv; u16 regaddr = (addr << 12) | (count / 2) | SET_READ; - struct spi_message m; - struct spi_transfer t_addr = { - .tx_buf = ®addr, - .len = sizeof(regaddr), + struct spi_message m; + struct spi_transfer t_addr = { + .tx_buf = ®addr, + .len = sizeof(regaddr), }; - struct spi_transfer t_msg = { - .rx_buf = dst, - .len = count, + struct spi_transfer t_msg = { + .rx_buf = dst, + .len = count, }; u16 *dst16 = dst; int ret, i; @@ -101,14 +101,14 @@ static int wfx_spi_copy_to_io(void *priv, unsigned int addr, const void *src, si /* FIXME: use a bounce buffer */ u16 *src16 = (void *)src; int ret, i; - struct spi_message m; - struct spi_transfer t_addr = { - .tx_buf = ®addr, - .len = sizeof(regaddr), + struct spi_message m; + struct spi_transfer t_addr = { + .tx_buf = ®addr, + .len = sizeof(regaddr), }; - struct spi_transfer t_msg = { - .tx_buf = src, - .len = count, + struct spi_transfer t_msg = { + .tx_buf = src, + .len = count, }; WARN(count % 2, "buffer size must be a multiple of 2"); From patchwork Fri Feb 25 11:23:58 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 12760122 X-Patchwork-Delegate: johannes@sipsolutions.net Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DA2CC433F5 for ; Fri, 25 Feb 2022 11:24:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240099AbiBYLZ2 (ORCPT ); Fri, 25 Feb 2022 06:25:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240105AbiBYLZ0 (ORCPT ); Fri, 25 Feb 2022 06:25:26 -0500 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam08on2056.outbound.protection.outlook.com [40.107.100.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F5B41DBA91; Fri, 25 Feb 2022 03:24:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T0IzxDssojy0s0/kNJLPqddgCTscyaTVgcUXJk3WwnQl4f79r8A+KMNIITf+AwCAWu8ZlvTcV2SB4KDh1dNG4doZnUIfUXLL3NPZ35HZTfSnl0utko6GB/gtmIZ8HOy98cBQwThZToVdQNFYb9V+wPuvE5lOmXquhctgpqj5PPBqWIji15ECt1vXOdfYjjwIEmOKsm7POBM8wV7LLZmMYTK927tB3HXe15HAKNOWMarCXfhNLlonVJP/d5qQJlupPj4QHPt/xE//Q9z5Ep5OEV363DlT2Ssn0oabYPrIFJO39POpf/xYU8U+3wBXb5eC9Wn9n3eVJfW3j7J1rHgofg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=028fwsTfDIyITA6iQaqifK+WmjUP+SPDAeGTjiM6TDU=; b=QIRVeONeDiwyoyqRQrgw9qvhiB0kB6bqexXpWCEbUGTxDrKMSGTqMRB/mq5I9byNhC+/XIPdt214Oq9sCJrdCX3gxK368oZTyfXs0Ei2EJtkSAChv7ZLGKJKBYDua7Pg8Qsv7emrBk/11eN/r0QhkK8XbM0OtC0xHLUd3d0t9St5NR6ZedDA5DIMrMa5DqzG64tHnyY7rB4egRSisYkYNlsT24c6ICm57n9rSxY3FHqTAVX1KJ533meDRAUH97Bpwo7UKFs41YQHd6gtE2TOFNbxV1VkFSIgEUcCvQncPL4iJGpExaQnR3bo+GY7iCmJCUl6bzTHM6f//9OYvYvMUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=028fwsTfDIyITA6iQaqifK+WmjUP+SPDAeGTjiM6TDU=; b=NMGEkD65IA39wQh2FfyaONzgpyM9KFOaatZZ3MKD3Q4n414ukoIPuKiDY/a0UW/l9F6dDve3WL8kmNAafXH0JRDNauPbYKhgeMit2EfIFdK9srKJ7LWinyW7dQR7+a0gVceIa7dByzmaabTOaPosO5c8ojVBup/co9j2lAf8wi8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=silabs.com; Received: from PH0PR11MB5657.namprd11.prod.outlook.com (2603:10b6:510:ee::19) by DM6PR11MB4362.namprd11.prod.outlook.com (2603:10b6:5:1dd::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Fri, 25 Feb 2022 11:24:41 +0000 Received: from PH0PR11MB5657.namprd11.prod.outlook.com ([fe80::dd2e:8a4e:fc77:1e66]) by PH0PR11MB5657.namprd11.prod.outlook.com ([fe80::dd2e:8a4e:fc77:1e66%5]) with mapi id 15.20.5017.023; Fri, 25 Feb 2022 11:24:41 +0000 From: Jerome Pouiller To: linux-wireless@vger.kernel.org, Kalle Valo Cc: devel@driverdev.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , =?utf-8?b?SsOpcsO0bWUgUG91?= =?utf-8?b?aWxsZXI=?= Subject: [PATCH 03/10] staging: wfx: format comments on 100 columns Date: Fri, 25 Feb 2022 12:23:58 +0100 Message-Id: <20220225112405.355599-4-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220225112405.355599-1-Jerome.Pouiller@silabs.com> References: <20220225112405.355599-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: PR3P189CA0052.EURP189.PROD.OUTLOOK.COM (2603:10a6:102:53::27) To PH0PR11MB5657.namprd11.prod.outlook.com (2603:10b6:510:ee::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8e236a48-cd28-41a1-8250-08d9f8516a02 X-MS-TrafficTypeDiagnostic: DM6PR11MB4362:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uStitFjVazwJCymupZaVSIEEQZPWRP+ufbyfCuL0lEy0M7S4JOAFhLswoJsFfbNAaHKPTJZzLgZpHYGYr0wc9t7FbzJgbIJdZI1dWe3J0jWiqHHpDZJJE/9/8gkynTkpv/H5sfPtUIiiuZ5pFSiU2rct/e8ExEMZKnSvRRDa7p6UJV1S6ILXCTV8bt/mgvynawvO72mMLLYzhTuPwm51U7+qkpf33QDFwxQCA86RbIA5sqCdzl/b67IKfDDmCW+Uf2licJ5qVsGGdSaQX0B4bjVtXnk+VZMFIFRkwlB6DiIfmE/ETT/RqaCWJj+PoIXo1Ylc8jxAzl+EO5mP9gp014+BXGsO7DWN+E8c1jt7tuWQjliKVLssYQYokDHrlli7tchaLSBasfalRYI1PWbCy61bpv6MPjQD8xBDOn37TeYosdIIFjx1G0IaOEe978FkNiTsh8ERNVq6MV5o8VHOawEjaHDz4Jqr7enW1rX3Ml7VGOiDV0bWqwYHBdc20gbS6WG5dpjr11yfIm9YaNwcHmVmCv5EeuUVMesO7ekOAannFpCMmbKW2gfc7ZBxpuKX8izbol2bUp/yy1M+inZatv9KRszgAGEuZcA87Fvj1BlNi1esHO26xudtrmFPEV0XAnSI3kE7JhLso0g70qhLjdPOu5LznILPCumYexBGGrrcBdel2UlrN4lCYSGioHERoqHj4ESv+meoHXQ/bfAhWkMsT0ct4rYDCiaero74R2977zpcuLesWm87v9yqHDNP X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5657.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6512007)(6506007)(1076003)(66946007)(52116002)(8676002)(2616005)(66574015)(26005)(66476007)(5660300002)(66556008)(508600001)(2906002)(83380400001)(54906003)(38100700002)(4326008)(86362001)(6486002)(8936002)(186003)(6666004)(107886003)(36756003)(316002)(38350700002)(6916009);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?NtGlQzY7kBeQpT5pfUAGaLv5FgHZ?= =?utf-8?q?x7au5D4zCiSp47+rqZZ5lAWVtqoqDd2LAyFTZ9CEbj43u7fgZLbMVjnAZ/3tJm18F?= =?utf-8?q?tzQe6Wed5cEB8nxkQj/07UsJhgx8op6xqlz2U5A+pxy5p/QWKKBGc+c6fGy+Wc9aW?= =?utf-8?q?9cnd+7eV0TzPZ3ABM9v5TuqHiFiA2WP05SNWv/mKI1CK0si1CgCX8HywfHnPbl/cD?= =?utf-8?q?2g9/S5bZML5JttSSKRygbooqg93IjvQ4xSc427V6jpxtvb01FvonweJ7U1DtsZOQn?= =?utf-8?q?sVRtZIkMCIW8XJAc4pjxeyqh94wX8+i+JSOLJLmD1Yf62aVmcPVUswiprgvvdMC4Z?= =?utf-8?q?gHryeARXpFSVTF50+dDnwuNUpbjF5McfArSKi6jn/glK3zBkHtGydzzldCENTA3iP?= =?utf-8?q?HPQOnt4rOQ7cOEy1CUu3w74Uji2oM0ys7hKQQNPjF8ZmTX2FAQY13O/M2AgnkujeY?= =?utf-8?q?mC+RqwCioYLgz8rXeGLAgRfP+y7bVUekM3RBlvE/ib485JQj0uzatMsOCVMQtgsWE?= =?utf-8?q?cW1toC0JwsFyqMqKcxAM3ITxG7bL6gDXvr/13oMTubg2UV+cLCAfczwPVuDysQetU?= =?utf-8?q?HwlLhvwpbH1SL5Ft6oyD7gxhMITvWdg+Zb1YzAEn32naHO8WQZHmRi6c+aD8sKIJg?= =?utf-8?q?nUlkmq6MDkhA1U1jLp0ISKolSPKPmuM4xfcUjz7vP+4+nR3KJ8bVN0SYO/O5qcTu3?= =?utf-8?q?0q3Kw13z/SivqGlkwZQWEg4R8iVCPoO/F1BwNs+1CYKqN5cQU7NjPj5xqKe2vMU2V?= =?utf-8?q?xfoNItrn3yaBwJKyKkkxKwm7HAbwx+dWw7VSWNng4KiDvIbT62CF3v8Wi3zWN5QOP?= =?utf-8?q?Ekls78+DfYHX7NEuClmfsQGuvQ4lib7b3e4jemDNr7l9Yx676ZM5dVUQrZd3xvzU7?= =?utf-8?q?R72HWjJJhHRpU3394iTGkoYNMVRavT1Ihq1UzNCeuaAyg3PPzqh3azvuE/AggV8XF?= =?utf-8?q?6YBAgtG1WRA6yDT/4DNl/C2piLtKCPb98WIZW6SHwWlN+MvbWZK0F9NY+n0CA5RUi?= =?utf-8?q?Y3mXZvCAjvgR7OpRvZz5fysRu5r6DaLKio76eN1STCx9CzsiI4n+OKFi7CV0S9S3/?= =?utf-8?q?rl6eKirW18lJx3p5GSVy+waiACeEYL8lchl1i3Wt5maIAAQDHOvGjuK1CS8shfnZH?= =?utf-8?q?5B22tiPKzoz5GpHKeb4ATJTSJ8SamWCOnTtfX20YuUKtASyPPWIT5exmPn1B9qL+r?= =?utf-8?q?L2RmSuZME2kL12s27vaHicmskFagqEgxENoNc7TdDgUmycXKqLAwcpiIO4PQ+klEb?= =?utf-8?q?O/tbTLi+rPNSjvLN+ZSmW0FEAdV9HMSKh/7QYTe9YHxq3hOZMY+LwnUyM+QOkUbzd?= =?utf-8?q?cUfQMqrQSQ3SfULR+L2/UwM5a8z81UmPATRF9adePFy+aqYTh7xRmLpsiPURHGXO1?= =?utf-8?q?HUx24oMK+BqF0ZWdVr+xFq9PiR0W1XPo8bQbvmdJnyNtgVrv9jC+w3H0eY80qPn0p?= =?utf-8?q?KPYTxzrVOAs+dg9FrZa1o8CZHe32iSdxq4FMk62asgTW7hfAwO9tSVoTcV5ecEwlo?= =?utf-8?q?fcKVZSiU2Q7UP7p/PdXqNFHuGcipb7IQrDixQRmD1SCcrvYCzlrs8Ss=3D?= X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8e236a48-cd28-41a1-8250-08d9f8516a02 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5657.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2022 11:24:40.5453 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WD3kmLrIpsxNlv1kplirVznwDkyJdrnzgfooO2dcPtO6dvXQZUVvbdRPuwDt8fSgYYBhMt67j6ObgVjR43RGZw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4362 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Jérôme Pouiller A few comments were not yet formatted on 100 columns. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/data_tx.c | 8 ++------ drivers/staging/wfx/queue.c | 9 ++++----- 2 files changed, 6 insertions(+), 11 deletions(-) diff --git a/drivers/staging/wfx/data_tx.c b/drivers/staging/wfx/data_tx.c index d7bcf3bae08a..e07381b2ff4d 100644 --- a/drivers/staging/wfx/data_tx.c +++ b/drivers/staging/wfx/data_tx.c @@ -117,9 +117,7 @@ static int wfx_tx_policy_get(struct wfx_vif *wvif, struct ieee80211_tx_rate *rat if (idx >= 0) { *renew = false; } else { - /* If policy is not found create a new one using the oldest - * entry in "free" list - */ + /* If policy is not found create a new one using the oldest entry in "free" list */ *renew = true; entry = list_entry(cache->free.prev, struct wfx_tx_policy, link); memcpy(entry->rates, wanted.rates, sizeof(entry->rates)); @@ -494,9 +492,7 @@ void wfx_tx_confirm_cb(struct wfx_dev *wdev, const struct wfx_hif_cnf_tx *arg) wfx_tx_fill_rates(wdev, tx_info, arg); skb_trim(skb, skb->len - tx_priv->icv_size); - /* From now, you can touch to tx_info->status, but do not touch to - * tx_priv anymore - */ + /* From now, you can touch to tx_info->status, but do not touch to tx_priv anymore */ /* FIXME: use ieee80211_tx_info_clear_status() */ memset(tx_info->rate_driver_data, 0, sizeof(tx_info->rate_driver_data)); memset(tx_info->pad, 0, sizeof(tx_info->pad)); diff --git a/drivers/staging/wfx/queue.c b/drivers/staging/wfx/queue.c index 9186726ff07f..729825230db2 100644 --- a/drivers/staging/wfx/queue.c +++ b/drivers/staging/wfx/queue.c @@ -210,8 +210,8 @@ bool wfx_tx_queues_has_cab(struct wfx_vif *wvif) if (wvif->vif->type != NL80211_IFTYPE_AP) return false; for (i = 0; i < IEEE80211_NUM_ACS; ++i) - /* Note: since only AP can have mcast frames in queue and only - * one vif can be AP, all queued frames has same interface id + /* Note: since only AP can have mcast frames in queue and only one vif can be AP, + * all queued frames has same interface id */ if (!skb_queue_empty_lockless(&wvif->tx_queue[i].cab)) return true; @@ -253,9 +253,8 @@ static struct sk_buff *wfx_tx_queues_get_skb(struct wfx_dev *wdev) skb = skb_dequeue(&queues[i]->cab); if (!skb) continue; - /* Note: since only AP can have mcast frames in queue - * and only one vif can be AP, all queued frames has - * same interface id + /* Note: since only AP can have mcast frames in queue and only one vif can + * be AP, all queued frames has same interface id */ hif = (struct wfx_hif_msg *)skb->data; WARN_ON(hif->interface != wvif->id); From patchwork Fri Feb 25 11:23:59 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 12760124 X-Patchwork-Delegate: johannes@sipsolutions.net Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BDFBC433F5 for ; Fri, 25 Feb 2022 11:25:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236830AbiBYLZu (ORCPT ); Fri, 25 Feb 2022 06:25:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236604AbiBYLZs (ORCPT ); Fri, 25 Feb 2022 06:25:48 -0500 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam08on2056.outbound.protection.outlook.com [40.107.100.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F3B41DBAAC; Fri, 25 Feb 2022 03:24:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XkZaiRREES6S3U6A/HOEkCuiwuMcncgXkUZeS0qOMlUB2HvuP6xRau0U5iN8Xpau6NJeh0r19kE5PWyvidjHzMxSoFbVyiB+u2oQmSVdTOLH6nb3oDMWljT6ghYRUgJYt59amgMCCafk9vDXrMRJGkCTix/gYBE9BrxbYt3wk1NrOhxfPOsIeg4Tno9tQzFOlzMk6ElHJtMgO3zRFJa/P5djtBJbZQvz7fJ2ShETe9PXE3YC4Bk0WU0tGESVPtLnsy6Ev5yDtw9e06QKjJFED/6rXLbqbVGU41j9FEzd9wh5I0p474eTXOH7i2JvPumx1N1CT8tTXPEYVW0HnlQ8CQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=t/SElU7QRT2qlTl9sDfTxXwac/naMIM8CHp19G+iQMw=; b=m9rAQxaY99N7e9F7TvQ/Q0GMHDpFmlXVsCeHLUA5d/6qmVyu3ysVN088XeSfqgH8vMXBJTiQrTS4xmV2NGvVv/jWXCT4FOk8uN2rQ8n7pmU8nD+Lo8AMjlo3Nsh+DgKUyfwN1yVX/7bAP99gj+PLLx++IPoWVShv0WF3JjYJvf89UrM136YlabrxuAVcuK6gKuv7ygSwcPqCe36xPFz+CQiCqs6b/SoeMCDexqoMM52ViuXXzYik6yfyEI9G4q3xfNxaMHWslM4g64GZBAcjSCpgJ/tOxQeyb2QhyD8ZCjtq0DruH4pYeCBt1EaAgvObdJR8/FkOQMzyg8WZzq0/Bw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t/SElU7QRT2qlTl9sDfTxXwac/naMIM8CHp19G+iQMw=; b=bZ9aUIZ7qkLghYuz/r5OHQnZxPx5vg0I3slmq8X+tLKuyvFY2jj0/gpfSiRpx8v5VE3NCrvsAtIPwffBdsdEEbyalrs+hP8zESUE0opTsTl32ck3m+GCRMTQILURUfvRe/mdOKg0zx52IroLhl0daJ+2er3sT9q7aCtfvEqhP5U= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=silabs.com; Received: from PH0PR11MB5657.namprd11.prod.outlook.com (2603:10b6:510:ee::19) by DM6PR11MB4362.namprd11.prod.outlook.com (2603:10b6:5:1dd::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Fri, 25 Feb 2022 11:24:42 +0000 Received: from PH0PR11MB5657.namprd11.prod.outlook.com ([fe80::dd2e:8a4e:fc77:1e66]) by PH0PR11MB5657.namprd11.prod.outlook.com ([fe80::dd2e:8a4e:fc77:1e66%5]) with mapi id 15.20.5017.023; Fri, 25 Feb 2022 11:24:42 +0000 From: Jerome Pouiller To: linux-wireless@vger.kernel.org, Kalle Valo Cc: devel@driverdev.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , =?utf-8?b?SsOpcsO0bWUgUG91?= =?utf-8?b?aWxsZXI=?= Subject: [PATCH 04/10] staging: wfx: format code on 100 columns Date: Fri, 25 Feb 2022 12:23:59 +0100 Message-Id: <20220225112405.355599-5-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220225112405.355599-1-Jerome.Pouiller@silabs.com> References: <20220225112405.355599-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: PR3P189CA0052.EURP189.PROD.OUTLOOK.COM (2603:10a6:102:53::27) To PH0PR11MB5657.namprd11.prod.outlook.com (2603:10b6:510:ee::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 472d8c78-c193-4274-8d54-08d9f8516b0f X-MS-TrafficTypeDiagnostic: DM6PR11MB4362:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8Y+l8Bqwy+/kIOiMJvWd89hKhHYE7xTgnPkFhIHkqtZbPkTXaKiXRg6tU2L64p7mMj5f4d/TC+LXSPmBNKJBGkFuk5oViAeV3/rNFeup/Yy4Zz43G+cwPqigQfp9jNCaZpdzJciobBvHnm02YQW0d2yUA8kxC8Igjg7Akrxrsggh74z0LxuNTJcd4+Nbpl9PDr4IN/3/M7M6QJ5UAXNhhEn+nl69ct9mznzPSteq2W+DXpB/vck/VevKABfZqvReizgp62EBKKXTTFbR9UkP2sW3vvAfGanybN8jUQtDW4u4RbwBB8qhOmh0Z/nZMHjDm3QQsU0ueRm3nhWof9ufPWUiNjNbSUHamNBDjYSkCN3f81RXhtjy0gKFsvSEZWIX4+UlYk2hVOtTWwS2t0zsiin+bIeQwyg8vjbrtaAyBH2vxek/kw1/37e36fY+v8gV3a5hde5e4QpKtXaL2uWbYqmMOrrL6kUhANNc+A4M2zaTmR/817VfsGwDowHu3SCiWQ2teZeBipyqbhRewixnAI2G94JcWqcZsXTeKgah9qFXqXABXbIR7pTxIUqVi3dIe0fm70RQq32kq7lbkCFdwq7DIzfXbCIJfzdZGfMiOYUCbcAX5o0mjW7LPynNyW09lXbhj76/46ivMccjbwj9mRcVGgzkYIQbZCKr4R2PM2BMXs00Nv+I1oLKKLRRdwIPHBdwgkJZDm9wqUE2iJ356KK0j8yq+ixTD5Bqm/GeOJG3hiaIX7ny9nzfy9OIwCKz X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5657.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6512007)(6506007)(1076003)(66946007)(52116002)(8676002)(2616005)(66574015)(26005)(66476007)(5660300002)(66556008)(508600001)(2906002)(83380400001)(54906003)(38100700002)(4326008)(86362001)(6486002)(8936002)(186003)(6666004)(107886003)(36756003)(316002)(38350700002)(6916009);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?fBZJ0w1bNOjgA7hAFJBSLuScmBl0?= =?utf-8?q?CtYsfxFfM3C5HaN36Jrl2XQW+rq+TcyegJLOqIF0F7HcTJo6KtOV7t06slDQqBGo/?= =?utf-8?q?sosJHBz8JsY8Nrmo3w+OxohWgxCB+c+128olouNxsfNKYh4Nd1CYpzk52qGLyVUoD?= =?utf-8?q?x0YE9DanWdecFP5pkvNggBrZn4/QXKvY+xiAY/ZUo1jfCOCdyT1/xGK8uu6uDdR65?= =?utf-8?q?kbEw/BR05DbZsWufX1QRj8VYM1wKWZkJIDd4zfMj3jtW71EGzORhnqD6PJ7JmDV/x?= =?utf-8?q?kAtecmb2LtbnM9P66RlpTtEMyTtCWhwxG+d0KrcmGT/UaCRhjDOxIcsojZAKKQBor?= =?utf-8?q?PZlU678/rsUmTNLPMR53no//bigD0fxmdcScuvTultHKIN9JXOTUJRKumaStKUUCO?= =?utf-8?q?kBGofiRoD1iZTmuP70G6L9NxMyq1ivlOq2HU6r977NuDPlCrgo3fBJgtXMQgqra/x?= =?utf-8?q?jo2WdJnBQU6dwgXHMtHqzXybr4FiJEA7PV8r9BawplYN5GMBCEYwPH6CZroa7GcvE?= =?utf-8?q?rJkoHj+Frk99NpOsjDWN9jdOKw/d2JD5hADW7ktFrgyMAXgS1qW09K8liKvpfInup?= =?utf-8?q?j2bQSa5ucOI4R9VyZ3ykoeu0Gv1ddhFaLpHCJxLHHFmACeoYnUI/ewpayD40tVJux?= =?utf-8?q?Qd7wPdR0XsV6GEw4wmyhYqe5aUEYgzQJ0BIQH8NhjYG5+a8CRzpHHJFVarrnA2CaD?= =?utf-8?q?EN2vMmLkq4wVgEArw+lgQAdfwbJpKI6WqcXt2OrHmFdMNcm7DKFVcEr9ezNDjjcoP?= =?utf-8?q?5BsNhGa2xU6i/vTIb9ciwM4mXGm29X2+L3aoMYJxjDlJPwcDbO9RKggo9UnAvit9H?= =?utf-8?q?Lq5SkYrnldrS1PWKxKAJ3jmFWw+dGp5NMCn4AEiZa91nkb9JEhxXc0kJpT7KlSNgw?= =?utf-8?q?V4HXowxsvKtZSSh1WS20K8y4DAW+Jam1Aph8A8xC/a7+wxQ9fWDRJFISn8LF9c6Rg?= =?utf-8?q?pxPXfpS6rzPaisBWqffpBwHtrd33mHGmVMRl85sMFWEh/p4sMDy1H1iXLAgUKG/1P?= =?utf-8?q?Mn6r2E5Ld7CGaL52svkGYACmXZ2Qj6KDpr86OxLQGHPNEtvWD4FDgmK3etwJSDlM1?= =?utf-8?q?Xg1rdx1eZy9IC+rEvi7bDmZPHZSIFZrDGOGI3zNnf8WisVaUfTw4pchcRNjw+NF9N?= =?utf-8?q?YVcW04lylqxRT7DYBPAhTWAf3n3WMc3eD4l5gStTOq4naPDnCv/AEsnx2VXyuZc9L?= =?utf-8?q?msNgcUYeSGrtUVk70HibtHOgOSaQEQH8N3HT4Bdz6N9qukNiD7ZWEAkkJ7Dwen/to?= =?utf-8?q?wSKlz+/CfS7Ll5m/pJvcSy5Z2mXmJeoj/gYWfPMZlZ33LG56h7KscnzuamDmGoZcR?= =?utf-8?q?Pr8bJ4u/O1KLTA+/0bU822gr/3oPASF02H18kvQ695WrNZ02338vrDhnoB1Gi/WHa?= =?utf-8?q?m/4ZA2abneothRVMDNVOI6oFGvquUL4yIINdyMPtzCZfsP0Dwe/kyLoc0uO60j2rj?= =?utf-8?q?vj7CYnEpD8j5WSmb/JhmWMcp5X8APeWKww6yPbz9N8BFfWkYpRoBc37z/HZ85OxYB?= =?utf-8?q?Njv1BsypIIKvUD6k80c/qZTUpxQiIb/NqJd8W9BijgZlAU7OlmXDj68=3D?= X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: 472d8c78-c193-4274-8d54-08d9f8516b0f X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5657.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2022 11:24:42.4055 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XWqKolCniSlG3ZfzNtnalJrt3MfZjpZBT5nrqF/r7vHDXry6OBkQaKHJlHgzovT+T3E891kVN9X6tTmpgKfBmQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4362 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Jérôme Pouiller A few lines were not yet formatted on 100 columns. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/fwio.c | 3 +-- drivers/staging/wfx/hif_rx.c | 3 +-- drivers/staging/wfx/hif_tx.c | 3 +-- drivers/staging/wfx/hif_tx_mib.c | 3 +-- drivers/staging/wfx/hwio.c | 9 +++------ drivers/staging/wfx/sta.c | 7 +++---- drivers/staging/wfx/sta.h | 3 +-- 7 files changed, 11 insertions(+), 20 deletions(-) diff --git a/drivers/staging/wfx/fwio.c b/drivers/staging/wfx/fwio.c index 9005a6fe48c8..3d1b8a135dc0 100644 --- a/drivers/staging/wfx/fwio.c +++ b/drivers/staging/wfx/fwio.c @@ -192,8 +192,7 @@ static int upload_firmware(struct wfx_dev *wdev, const u8 *data, size_t len) return ret; } if (ktime_compare(now, start)) - dev_dbg(wdev->dev, "answer after %lldus\n", - ktime_us_delta(now, start)); + dev_dbg(wdev->dev, "answer after %lldus\n", ktime_us_delta(now, start)); ret = wfx_sram_write_dma_safe(wdev, WFX_DNLD_FIFO + (offs % DNLD_FIFO_SIZE), data + offs, DNLD_BLOCK_SIZE); diff --git a/drivers/staging/wfx/hif_rx.c b/drivers/staging/wfx/hif_rx.c index 302bdb2bf036..64ca8acb8e4f 100644 --- a/drivers/staging/wfx/hif_rx.c +++ b/drivers/staging/wfx/hif_rx.c @@ -244,8 +244,7 @@ static int wfx_hif_generic_indication(struct wfx_dev *wdev, mutex_unlock(&wdev->tx_power_loop_info_lock); return 0; default: - dev_err(wdev->dev, "generic_indication: unknown indication type: %#.8x\n", - type); + dev_err(wdev->dev, "generic_indication: unknown indication type: %#.8x\n", type); return -EIO; } } diff --git a/drivers/staging/wfx/hif_tx.c b/drivers/staging/wfx/hif_tx.c index ea2582714bb9..236f9d62e3a9 100644 --- a/drivers/staging/wfx/hif_tx.c +++ b/drivers/staging/wfx/hif_tx.c @@ -169,8 +169,7 @@ int wfx_hif_reset(struct wfx_vif *wvif, bool reset_stat) return ret; } -int wfx_hif_read_mib(struct wfx_dev *wdev, int vif_id, u16 mib_id, - void *val, size_t val_len) +int wfx_hif_read_mib(struct wfx_dev *wdev, int vif_id, u16 mib_id, void *val, size_t val_len) { int ret; struct wfx_hif_msg *hif; diff --git a/drivers/staging/wfx/hif_tx_mib.c b/drivers/staging/wfx/hif_tx_mib.c index 1c57dd2b697c..df1bcb1e2c02 100644 --- a/drivers/staging/wfx/hif_tx_mib.c +++ b/drivers/staging/wfx/hif_tx_mib.c @@ -84,8 +84,7 @@ int wfx_hif_set_macaddr(struct wfx_vif *wvif, u8 *mac) &arg, sizeof(arg)); } -int wfx_hif_set_rx_filter(struct wfx_vif *wvif, - bool filter_bssid, bool filter_prbreq) +int wfx_hif_set_rx_filter(struct wfx_vif *wvif, bool filter_bssid, bool filter_prbreq) { struct wfx_hif_mib_rx_filter arg = { }; diff --git a/drivers/staging/wfx/hwio.c b/drivers/staging/wfx/hwio.c index c15810bdaecb..3f9750b470be 100644 --- a/drivers/staging/wfx/hwio.c +++ b/drivers/staging/wfx/hwio.c @@ -71,8 +71,7 @@ static int wfx_write32_locked(struct wfx_dev *wdev, int reg, u32 val) return ret; } -static int wfx_write32_bits_locked(struct wfx_dev *wdev, - int reg, u32 mask, u32 val) +static int wfx_write32_bits_locked(struct wfx_dev *wdev, int reg, u32 mask, u32 val) { int ret; u32 val_r, val_w; @@ -94,8 +93,7 @@ static int wfx_write32_bits_locked(struct wfx_dev *wdev, return ret; } -static int wfx_indirect_read(struct wfx_dev *wdev, int reg, u32 addr, - void *buf, size_t len) +static int wfx_indirect_read(struct wfx_dev *wdev, int reg, u32 addr, void *buf, size_t len) { int ret; int i; @@ -199,8 +197,7 @@ static int wfx_indirect_read32_locked(struct wfx_dev *wdev, int reg, u32 addr, u return ret; } -static int wfx_indirect_write32_locked(struct wfx_dev *wdev, int reg, - u32 addr, u32 val) +static int wfx_indirect_write32_locked(struct wfx_dev *wdev, int reg, u32 addr, u32 val) { int ret; __le32 *tmp = kmalloc(sizeof(u32), GFP_KERNEL); diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c index ba53e4d70c4f..28474614a8e5 100644 --- a/drivers/staging/wfx/sta.c +++ b/drivers/staging/wfx/sta.c @@ -432,8 +432,7 @@ static void wfx_join(struct wfx_vif *wvif) wfx_tx_unlock(wvif->wdev); } -static void wfx_join_finalize(struct wfx_vif *wvif, - struct ieee80211_bss_conf *info) +static void wfx_join_finalize(struct wfx_vif *wvif, struct ieee80211_bss_conf *info) { struct ieee80211_sta *sta = NULL; int ampdu_density = 0; @@ -539,8 +538,8 @@ void wfx_bss_info_changed(struct ieee80211_hw *hw, struct ieee80211_vif *vif, wfx_enable_beacon(wvif, info->enable_beacon); if (changed & BSS_CHANGED_KEEP_ALIVE) - wfx_hif_keep_alive_period(wvif, info->max_idle_period * - USEC_PER_TU / USEC_PER_MSEC); + wfx_hif_keep_alive_period(wvif, + info->max_idle_period * USEC_PER_TU / USEC_PER_MSEC); if (changed & BSS_CHANGED_ERP_CTS_PROT) wfx_hif_erp_use_protection(wvif, info->use_cts_prot); diff --git a/drivers/staging/wfx/sta.h b/drivers/staging/wfx/sta.h index 082329d7bbcd..c69b2227e9ac 100644 --- a/drivers/staging/wfx/sta.h +++ b/drivers/staging/wfx/sta.h @@ -46,8 +46,7 @@ int wfx_ampdu_action(struct ieee80211_hw *hw, struct ieee80211_vif *vif, struct ieee80211_ampdu_params *params); int wfx_add_chanctx(struct ieee80211_hw *hw, struct ieee80211_chanctx_conf *conf); void wfx_remove_chanctx(struct ieee80211_hw *hw, struct ieee80211_chanctx_conf *conf); -void wfx_change_chanctx(struct ieee80211_hw *hw, struct ieee80211_chanctx_conf *conf, - u32 changed); +void wfx_change_chanctx(struct ieee80211_hw *hw, struct ieee80211_chanctx_conf *conf, u32 changed); int wfx_assign_vif_chanctx(struct ieee80211_hw *hw, struct ieee80211_vif *vif, struct ieee80211_chanctx_conf *conf); void wfx_unassign_vif_chanctx(struct ieee80211_hw *hw, struct ieee80211_vif *vif, From patchwork Fri Feb 25 11:24:00 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 12760126 X-Patchwork-Delegate: johannes@sipsolutions.net Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1E84C433F5 for ; Fri, 25 Feb 2022 11:25:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240180AbiBYLZy (ORCPT ); Fri, 25 Feb 2022 06:25:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48300 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240133AbiBYLZu (ORCPT ); Fri, 25 Feb 2022 06:25:50 -0500 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam08on2056.outbound.protection.outlook.com [40.107.100.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F6941DBABF; Fri, 25 Feb 2022 03:25:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jRTnrrcSeNt5FM6FFBn4Lg82qHMGgi6QliKgMEItQm9uUkW7eTyJ7lvsx252k6sqP9ssl8ARODbJCfgJN4sYz2yjbneRDoShoDSuZAx1NahI0RT9yB0JpNIAn5VggAzkbmX0IHpwuIf75r7bdp1bVyfiebqG+Fgq3q72ExBXUz+35dA7KxG57f1rql8d8R5ycTECrkqlnq0nB5k2PSBCugk3f8G00cKQHLnC6FMVEkOSwAnKFrfiLVvwDQguiyunuWlneC39Dls5BlFIA1iBEEQRluGIN316TuUyQr69ksxk8Qfd5cAJNCkJx/8SHHy4RroCLx83Ftj8PhchkJN8Wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IpPXMkuokgI2KorYtPu/iTSAZ4jYtlCWIdBT4Wkdngg=; b=haXmBqont2YqY+cdJnzJO1cOUtJe6ktuvuhN7E+0wyEqMrpQiVus7XqT+jG4hdfSgrub//JPWxBt4ZVcSAY+4HT/NLge/VG+q5u5btXN+9Zgrn2C6iLRWkn7JKVKeBSgjcbS2V/zw8kfJwmWss8AZi/p1Uc7iXpL43mMzq0KcHkAQX6rWVDFHM1w4Y2jiwyWN9TIDtJpP0zRf/2fn/4T7czI5LEJBUj/YWI7cRwRzBfYiGBBJQ8fasNAsB2SKqWAMZ7OTxYZPWKf7FlLBCIz93q5PoyE+O5EsOE0zmEL0US4x5iEcDHbv4m03mObDXNqn3rZMafyf4ZcctSKmcdVQQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IpPXMkuokgI2KorYtPu/iTSAZ4jYtlCWIdBT4Wkdngg=; b=Ax4PwFrBBx0PZmqPEVl6s0JDluD/aA0yXkyxJBrCnaXibF3j+V5G4JKEDeZcStim6jBvYBDQIM2tCq77tmZb0BCD+UuYGen1P1NOdosx2yW9PjQhsvySK4BE6tS6jJLGDrnQp6LieHXv2oqorbXpmvUqyVZStonSlrPg1OXNYb8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=silabs.com; Received: from PH0PR11MB5657.namprd11.prod.outlook.com (2603:10b6:510:ee::19) by DM6PR11MB4362.namprd11.prod.outlook.com (2603:10b6:5:1dd::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Fri, 25 Feb 2022 11:24:44 +0000 Received: from PH0PR11MB5657.namprd11.prod.outlook.com ([fe80::dd2e:8a4e:fc77:1e66]) by PH0PR11MB5657.namprd11.prod.outlook.com ([fe80::dd2e:8a4e:fc77:1e66%5]) with mapi id 15.20.5017.023; Fri, 25 Feb 2022 11:24:44 +0000 From: Jerome Pouiller To: linux-wireless@vger.kernel.org, Kalle Valo Cc: devel@driverdev.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , =?utf-8?b?SsOpcsO0bWUgUG91?= =?utf-8?b?aWxsZXI=?= Subject: [PATCH 05/10] staging: wfx: remove useless variable Date: Fri, 25 Feb 2022 12:24:00 +0100 Message-Id: <20220225112405.355599-6-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220225112405.355599-1-Jerome.Pouiller@silabs.com> References: <20220225112405.355599-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: PR3P189CA0052.EURP189.PROD.OUTLOOK.COM (2603:10a6:102:53::27) To PH0PR11MB5657.namprd11.prod.outlook.com (2603:10b6:510:ee::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: dd10e88c-e59a-412c-96de-08d9f8516c2b X-MS-TrafficTypeDiagnostic: DM6PR11MB4362:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uhJCkmG2WAZXip4qdoljjfXR9oQUc+LXApBWG2yhDS5XFNuIiaclsTmEf3L+zvH7UzCgsSdEDExyrFB4Dz1upXgrlJfzLsvgOcskjB6uqw0mqaFCp07w5YOEgCVpjzKsSEGYgWhmxl9jNxSW/l7R5Aos7F6B7arql60ohIGmBSwpu8m67wwyo+7+x8XKg4f5gQbWExIIWdoFHOZbHSLdTfc8TJYcSApmblI1cGGQRqVybNFtvahVPaJQ+umFR7T3KdQ7qXsm9MgZWFOzIKSNK/JvaxREYMZrflT8riJQA6e0vabWSKdlEsD2/DULqvxNjXXxSI9ESzKugGLWODvMtjy7sTBs1A6NWp5OOuOnZ6HbNOC8WLGa4co729BCi7nYUMFsl5WdOx8LKyRc38VCwtvK/vFnlDKnqd4R7SAFkCgVJJODLkSRPNRiwvpmrGsj48vxg/KoOuXuYw+QY6qF6UHEMfEombaCk1Qu7Stehg3xlj+Q3KF8DeoEZmEnouebn4lNBbGNK0VJJfxykD2kGj20X+elm5awRGcutw2M2RzWpzKVhd0og1k+sJrjFme/jpFsgIjGkiNB2RQHgP7fwCM69RaH9dMSZ4aBHILSuVPz3HJKpC5B80LLTw52f3FUAdFqXtPbU/ZARKa60HViTjNjZ//pMH/JMOO0b+k6zCZ77b+g7jRJRbJlfeYDiXEwookQb5JPgJfHvfA1beTyMZUrg0dw1vw369DRBQUREwZt1EqMMYgy/VjGF1XEML7M X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5657.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6512007)(6506007)(1076003)(66946007)(52116002)(8676002)(2616005)(26005)(66476007)(5660300002)(66556008)(508600001)(2906002)(83380400001)(54906003)(38100700002)(4326008)(86362001)(6486002)(8936002)(4744005)(186003)(6666004)(107886003)(36756003)(316002)(38350700002)(6916009);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?ZmCKyMH7L7wfUcIe6kjjUjhcpizT?= =?utf-8?q?A4qRagqhWoKCU/LWXb5S119zardRjpS9/2Gru8oxp1tyF7yILakelF6wac7E2eNF/?= =?utf-8?q?Xe+xMqOZa/d9KSsJPaI3kKQ4PCFcSvemo/KM4/GI1ERf7cLlnp5wF+n5hqBqyFUo3?= =?utf-8?q?T+8dURnMCQdlkYbSv5GTPcYNElAH586WFVA/5GUOCEVARDheP65LpAFGreriwOeUU?= =?utf-8?q?Zfv3jZ1VWa492zGbS7Ce4KVLB02ZdsWbeViO7egwM6swgFkAv26M6hb8+DtGFh264?= =?utf-8?q?X0hiRtdPUnWp1etmUQGgSbOZdV2hJpaHHERatv4WQMrp6iZIXyeMRnTQAnGDguIDY?= =?utf-8?q?EYsWRjA4xBlSxSnbCHas7U2HS1yXh0NiPyhzGlv69VM7xW/6LfCkKa5l+XYrItfDb?= =?utf-8?q?6F8P+D+0d0Hrz7Er3AjnQ+4MGiYZkloEdrGJ5MQ7wBV5LcJG4AAVRAYRXx/RhqPsf?= =?utf-8?q?3jA6UL/KfVZkvM3uq4LBQDJ8+c+oWKO3hEPXdS5iHCofnurpmyIGcq5Vb0yt6Rtla?= =?utf-8?q?Jls9myFOw8e+bcMbhytKrNVuj7mLmF8ELkF+yrN4yiJDh5ENQ4SmGOExOGFo1HkYX?= =?utf-8?q?NakyziJ6bVgtaL3Axd5WOTEhL0e0QAnNy/mkyT5abM4/AafVbB9MwezyS7pj0lYog?= =?utf-8?q?bwLdxuqBsc/X+NHUpr5POJ4BdlWoBdq23V6apFM4MIKfmj60LM9c2TfORrYeCIO5o?= =?utf-8?q?5f9nT2HkWUuwWC4KeGU/1l9n24rGdMtcuJZlUsqohXtT5J3/FJYvt3Bg9m3QG3/AV?= =?utf-8?q?clgUrenzNe2ouUXr71UQaoO4mezFafhwgY6Gb46wiHSbKux89OkVY6QU2CvMpmPsP?= =?utf-8?q?wQ//iEv+6ZvMLk5zNc7kCP/rrPGDj3FtZuC8ixiQp+11lBz8O7oxkRSVdwNlLqlgt?= =?utf-8?q?ourtRYjJeQDZuPIkPtwNC4FQuaXavwJbBMelZuBqDqjZuSMF8AFfoa6z98lEVBzZL?= =?utf-8?q?09vR5oY11iOHFPBIupSYfgFFbt/xuitqgnggmPSOHoXbVnJ5XllQoVEFYA3uXtVV/?= =?utf-8?q?NJilXC14nPmpCZ05EzgDhUzfcdwsJ/8KL8MJTBVJic/vDh/B1dTRp+KBPPu+47XKy?= =?utf-8?q?mJUYrrhEcqgKUwDDXUWZSvzzyxLBlvsXq9RhHtk9GXoTgt4zQ6MWXy2b78UianJse?= =?utf-8?q?OfBjb9PGS2dTHGBGmDj3PzXMzXiyTozMwZx6MlZ9SnMeL1LT1LaWL9jo3YPwnhQwR?= =?utf-8?q?fzM0MsKf8hsYqL3I/1fEZcYs8rtUPH5jgP7mGiqonIk7GpaXhKotLCwYEssROR2wI?= =?utf-8?q?Ae7cl9jtlClCPdWyCUcF2FFnIHGq+nxOuoAYKVwr5dNRbru6HKu8uXTdXcFSJO1G3?= =?utf-8?q?rF3r2IO2Gk5IiqU5SPZdqZ9liPNtxw1hViCCHS2Eeqa0gCzFYhDANRZscmyB7PVJl?= =?utf-8?q?DcNnPWAItjVeOftLNY0HKva5Fi78HuKWmEGyZrI0/SsGfeId1vvLnYwmz18v6rGUY?= =?utf-8?q?et6kCTNm/Ly8fTr8eC17z+PzJj6ILD3hc+y9gsJYYiOfq5tib0QewhEGw307afMgm?= =?utf-8?q?wItiBbicfB7a7+aBicy8oM6KHpW8/6giONYAVIFxoKGrIe5KOQcWZqc=3D?= X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: dd10e88c-e59a-412c-96de-08d9f8516c2b X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5657.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2022 11:24:44.3127 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QgvTpa1v4KQ55c390GPES//S+5Jhn8kT3wuEaH8ppEUfa8PMbYzlFmoALFKtK3yB1sZ4fWy7FNFVF+oFwCeN8w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4362 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Jérôme Pouiller Obviously, the variable "ret" was useless. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/sta.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c index 28474614a8e5..b1e9fb14d2b4 100644 --- a/drivers/staging/wfx/sta.c +++ b/drivers/staging/wfx/sta.c @@ -687,7 +687,7 @@ int wfx_config(struct ieee80211_hw *hw, u32 changed) int wfx_add_interface(struct ieee80211_hw *hw, struct ieee80211_vif *vif) { - int i, ret = 0; + int i; struct wfx_dev *wdev = hw->priv; struct wfx_vif *wvif = (struct wfx_vif *)vif->drv_priv; @@ -747,7 +747,7 @@ int wfx_add_interface(struct ieee80211_hw *hw, struct ieee80211_vif *vif) else wfx_hif_set_block_ack_policy(wvif, 0x00, 0x00); } - return ret; + return 0; } void wfx_remove_interface(struct ieee80211_hw *hw, struct ieee80211_vif *vif) From patchwork Fri Feb 25 11:24:01 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 12760128 X-Patchwork-Delegate: johannes@sipsolutions.net Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C223EC433FE for ; Fri, 25 Feb 2022 11:25:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240206AbiBYL0Q (ORCPT ); Fri, 25 Feb 2022 06:26:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48280 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240154AbiBYLZw (ORCPT ); Fri, 25 Feb 2022 06:25:52 -0500 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam08on2056.outbound.protection.outlook.com [40.107.100.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 03A88254560; Fri, 25 Feb 2022 03:25:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SRr/U4kiiqcLrXXOuDpej/TXsP/0jvjH7q2Os4FrjW/tOTs5rwHHmmXHIQZ3BEBoDHoffc8sO1rEm2ch1nClFAi3Uc1YXcZeli0pHEBCZiVHBm34ozAR25wIQHVC3HaBaHKjJvGY+R9+jpKdQh2XJJT3x4Jar1it141XPC+VFk+W1m8MWEFlF68WZjuUD4oXgMJjyRV5qDtbMMsn74wNufnlwhMG7JT276nm6KdgrkXck5GV6q2w955Vq3f2W0mCRvEvyWSuEc0jHc7LfxUkGiSrU93EG33dG5lDDtOCBql5HQJ4Ke/9Nso43RIFY74Z2Zp8fqHZVfTz8QJjc0o2Mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dBF/deFcuPx3YnSCa6P/J4ZK/WddcvmsCxGDRUCsRrc=; b=ffkwMQKE5Y9ykmNt+hNX5ovglI53oJ9mMpxExFmWHf0I2nLBy8bQ9f6N2o1EOCfBlRyKJUOtcsHF6GKOrYjMYI3ETP8OT8gZ+VP6iVqOVQ0zg1KvaPkr1YrmKuHP+pTHmE3/XiK3N6myEs78uHHTzE05LNa3G8n3IcOYTWnksMCJCGU1VPnGAIrnu1EgFtdzZ2hjc4XKjx2NBfP/0cTLiPA8rEgV5LjnBnQJGyZtBQUskFIAFQq73O3ojHufqxw5EMEc/+6Djj8iptLxbP5lM0Zxui6B9Nl/mpREwjz3HL+W1tBOHKci4Ch1XGr+BBGfx4rnyEtiYvZp+VLN0hhRQQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dBF/deFcuPx3YnSCa6P/J4ZK/WddcvmsCxGDRUCsRrc=; b=CpWO0oyyo7Y08XNha1M3sN4xapKKoiDV2ApK2Gh58qvdvjfX+ET9tfwNhUpCQzA5ywZ7t3sAE3Xp1+r8k7hDR4oo9ZJEE7IkhvrteFyDixAL3pBjgSxbQvoLe5mdJO8wQ7BRd4yeaK6yQ/1TL46kc8coDFFmez0vIZrbAyE1h8s= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=silabs.com; Received: from PH0PR11MB5657.namprd11.prod.outlook.com (2603:10b6:510:ee::19) by DM6PR11MB4362.namprd11.prod.outlook.com (2603:10b6:5:1dd::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Fri, 25 Feb 2022 11:24:46 +0000 Received: from PH0PR11MB5657.namprd11.prod.outlook.com ([fe80::dd2e:8a4e:fc77:1e66]) by PH0PR11MB5657.namprd11.prod.outlook.com ([fe80::dd2e:8a4e:fc77:1e66%5]) with mapi id 15.20.5017.023; Fri, 25 Feb 2022 11:24:46 +0000 From: Jerome Pouiller To: linux-wireless@vger.kernel.org, Kalle Valo Cc: devel@driverdev.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , =?utf-8?b?SsOpcsO0bWUgUG91?= =?utf-8?b?aWxsZXI=?= Subject: [PATCH 06/10] staging: wfx: drop useless include Date: Fri, 25 Feb 2022 12:24:01 +0100 Message-Id: <20220225112405.355599-7-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220225112405.355599-1-Jerome.Pouiller@silabs.com> References: <20220225112405.355599-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: PR3P189CA0052.EURP189.PROD.OUTLOOK.COM (2603:10a6:102:53::27) To PH0PR11MB5657.namprd11.prod.outlook.com (2603:10b6:510:ee::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9f87549f-f2b0-419c-cce6-08d9f8516d50 X-MS-TrafficTypeDiagnostic: DM6PR11MB4362:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hBgpbV6BpZC6E3EJnPdcqWeM/gJenatSJtCNkmnaTxYT0ek2zX4G3IosN0GkZXysLL1ul3QPgWs7LTy9fvovvmbhcqNHqQ8eVSdDRj4s9v60m4FrH2yCDJgNvCQVRSp+Nr/CZRMWfZFoWFdNsoJX/yOBlx5KJN2knCg3zD7vK3s69c/SG04bTuM3J6V2h9Yz8RoeJ0PiKZAL3dhIgqu7mLN6p9NOkcZu4jbkStKYYTrw0o9XgFZdQtJP6BTMxEtvFdBOFTadjMZlAXCWKp+7gN5Zhfc7YTaFOGKhvTCuEHJcNPm3hStkEXhGJDu88CkmMXoki38+ly6M9p3/hvo0Xa2I4cMCL0XJTb2koEEzYfTAFxmjqPgMvy5Z9iP5IcOMEt9LFY3k6zh1LpiOFYslCE9+DHsWoa/rzaJ+l0JHtF2SYICElwTEsQaZZzY+rr1ubdQZaBFGZGT0u0EhpbBbAfszFNWRq7BFhuI5WwSJC6lYbd/IfPvKyRCRM0572N7W83TmdS7IphQ+VERF0O9KPaRSa24sBqYn2ymeM8U3uBxSznYIGcidHPZGGZDllbWNs4y/3pl6KePWCum304Q6V/9Fhw82e4zSC/vciKF5h2l89r+qjuXG5FzzpJMaoS+e89OPe0bWl/XgOVtHEDMcFADMvGaWDiNSUwmBrrw32bzKYFPThAr8xyV9uLfpODFPpxnmbXsATDM7r/N/CIb+dsm9un8bO6e+zNyNNAtmx3ptiB2LAElQIZYCVyWMl2iL X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5657.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6512007)(6506007)(1076003)(66946007)(52116002)(8676002)(2616005)(26005)(66476007)(5660300002)(66556008)(508600001)(2906002)(83380400001)(54906003)(38100700002)(4326008)(86362001)(6486002)(8936002)(4744005)(186003)(6666004)(107886003)(36756003)(316002)(38350700002)(6916009);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?4AMrK2EdCzDwhfi3F+KPkb4g8RB+?= =?utf-8?q?bI2jTTVt0tWbVuVu1M+rDvtlywPzvW6VzW50NhYWSUs3uhjdIKJXCmjV1t3hSAZMQ?= =?utf-8?q?8fp+yLNgEjJPc/XBQgw2weGvuewG/4pbC1Q7jkvQ6AmRIOA8U5nG82oSf9JHsNgs0?= =?utf-8?q?0A9me4tReEpLfBXCewNlG0aVpIgjr/qTy0TyJPr3ahoJwyC/7WuxwMpSl+X9Osoj2?= =?utf-8?q?QN2Nak306AW/AzNQV4rCF93s3+DSRvRe+ryowrNuLNBIcc1MscYmxgMtXWT4lUa+w?= =?utf-8?q?e3oaAux9Nk2TvnOqJn5dF0U2QwMx+yxp1pd7RqdHaYzlgJW+lpiiY1m6ODKp86xua?= =?utf-8?q?3EESLmlK+xipyU5r5Ji2/ji3nsYhXWodmDkGoiKgkZkwjum+nQmcl3Ek5LrVuzxBm?= =?utf-8?q?j8sDIzcMNjePLFduXDBn/YxXAg8kVum8T7SUqTmGJu/ViVDli6xAWRQ11bfWt7zP7?= =?utf-8?q?AFot76K/NbY1zqsA0wyOco6IG7XViKDpw03UumDj8MDRt49SkuERPQ2RXGDkwFQUZ?= =?utf-8?q?rJX1xkO0XxKoTKjpLKNYCOE2u/qjv+XloTvw94gDOtkkTLgQ5VjFOmQZDsmcOo3KP?= =?utf-8?q?5+ia2fbtop7zt9Hu6iPuGN1j21MfkPLa9rd9v9JoousUTlH7taygRBPL+xTYsSd+0?= =?utf-8?q?rwkAnqwayQtqYr0Q5qdjBfMMAX0wP90sSNKOHM5LyRr2qnlDPexl6K8D5R6nt7aLv?= =?utf-8?q?/DOVnOhLt2XXQ87rhxbclKX/rC4JgPirI/oPZM4x0RKu5NKyDQ6tviOuq5liFxftr?= =?utf-8?q?fabIb/BoxJlPlX/eagoDwb9NVGceTqcmWUWTIRVIb0kgjsJx9NkBRjttXkM1ouSWF?= =?utf-8?q?AdMEVmn818M5hSFj/pj9kQ2sslrjHRHDJMVOjG/9UySyTnQT2oj/iqsgF3E7V9+rs?= =?utf-8?q?qYesnB+KE2qmzkxUHemVLmtCAbPEjyqUcw3qtF8xyw5rdUb2wFz30R2tS+xlKh+1U?= =?utf-8?q?jrmqcU/5YggwBMfpmRS9mXW39rwn2mLv39xPz6CW5NhB7CZnnWLpNvTDXY/4hSVEp?= =?utf-8?q?6bGMZsqZWvBfNB8A2KZO1H1t+vwDkzZDHbp1ba9psksyj3e8GqFUiG3kgvYc/dSRa?= =?utf-8?q?iYs3dchQjJvOfmw/8Y9cyu3YxiCYUl/8ZsZEmvX/3/NnU9hdw/r4WcmKO5X5TEyBu?= =?utf-8?q?LSMhHrMfG/LUEVeS+hQ/EnQdveRTdiX6rDB8rySQs/8H/Omns7wYpIBUhZsKu20YM?= =?utf-8?q?fXw/BYnEE/oRrQdaVXLDU1nMTPr3gjFfLHQhL5SOhN7bFDaDv5NHsUe0vJ7Uw5Sy2?= =?utf-8?q?JFgJDfoDbvYWFg+GtKvHRKgfvEaWG6A0IJm3rXDcqlGsyBK59/13LbCiPw2XqpO+z?= =?utf-8?q?8Mtf5FL40bM2Sho8j4aLwNDbAggyZD85t0dv38+qp6MgU/FB1wvIlVngqJSs76TFw?= =?utf-8?q?Z7lBkGLFhWQjbXkNDgMfKt63zVIC22oeVvNy07BQMHInzzB/PcWFe/H9/MvZ7eOvw?= =?utf-8?q?dWsWa0UmLc54TWvcm8D1SMI5ywuaRpwisYqbB9xKihHK+C6L0vBs4Qo3Oa5cBWSyP?= =?utf-8?q?ai0mDfRrMC4LPQriB4iT+SZq0Y25AlNVlqo/JIRTZRP/nPNgwzhXuyc=3D?= X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9f87549f-f2b0-419c-cce6-08d9f8516d50 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5657.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2022 11:24:46.2499 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GKaGFHRdxVkzUxsIV7nad9IA9tiIDZGwpqqVBIeGn+jZddD0B8Bcc9rVrMClqwjDYaYj5Fq8HYnfcUmQrQMgMQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4362 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Jérôme Pouiller ieee80211.h is useless since commit 5e911c3d9dbc9 ("staging: wfx: avoid defining array of flexible struct") Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/hif_api_cmd.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/wfx/hif_api_cmd.h b/drivers/staging/wfx/hif_api_cmd.h index 444ff7ed882d..8b91b1d4a46b 100644 --- a/drivers/staging/wfx/hif_api_cmd.h +++ b/drivers/staging/wfx/hif_api_cmd.h @@ -8,8 +8,6 @@ #ifndef WFX_HIF_API_CMD_H #define WFX_HIF_API_CMD_H -#include - #include "hif_api_general.h" enum wfx_hif_requests_ids { From patchwork Fri Feb 25 11:24:02 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 12760123 X-Patchwork-Delegate: johannes@sipsolutions.net Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DD0DC433FE for ; Fri, 25 Feb 2022 11:25:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240107AbiBYLZ3 (ORCPT ); Fri, 25 Feb 2022 06:25:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47528 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240108AbiBYLZ0 (ORCPT ); Fri, 25 Feb 2022 06:25:26 -0500 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2068.outbound.protection.outlook.com [40.107.243.68]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B64811DBA97; Fri, 25 Feb 2022 03:24:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FvTp0dteQO/R5/fuvq41FnlcyCD+m9LLLPuhVrvrWoDk7y7i/FCH5Mb8zRGyTy37oaGRoH1A3TP1ExAj0UnFY+46G3BRE/pHqFduqbQKus7P5q9S79PwuT6nv6eXmu99XUAkR+s2ufU0c2TKO1kDG0V0q93ARBUPiSlYcDRsufUu9XOGMIsLXF100EYajY8HpuNQCWxtpnhzYi2VYJcVzVveZTdA9vaBxv/gVpf9w1Htbmr7ThqAbWRh/tZMX3egdCH6OnZRWV7P4+ECYuf7VsZhWJx3S4RYHKi7UlfjYlNDXsV3s7XBTx4rzMfvNGzLHBvZxOVSCcsfJ+3+3kb4MQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cPgAmOkX5sJxMaWem9w9O563KMNa+WJAEihzAKyai/c=; b=Xzb6X+UQt2gXs0nSwF+dl08tSktailfhr7dcOQ8aZ9jpL0SoJOA5X4MWnLfI/Pbnxx1YJUmoIettAGLTLtQvuOREG1+lcJ9Np7TNS9AZVNA+ml7x10H4witTnnEvG/A4Q2aUxUNZp3i7f/CUjls+n0lShOVgLDNILRBBtYTrhRje/SCD2pglF0BqpeY/hBxw4Iypym/P3f64BW5grvhLICw9an518FszNibDU9fvefNXPPnqhhifOUcgKfJkxNf3hClIwHbi6KnEXasMEky0vsEYEXry2Y5WZwcgv1HBmFVYFPyBkTv03s+ccsHOfiGBOCEOJ74ePvB+HrbpMdDypg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cPgAmOkX5sJxMaWem9w9O563KMNa+WJAEihzAKyai/c=; b=fyPnLhf5/M8AJfoWgSbKwvOMGJFuzfTBaSo5mqk4ne3EuFQJwmmlbByFFCplXEylbWb6LmyL8GktjzS5Djhz8niR0cHEA3QwZgwsLsAeRbQo/+QRTQ3APdlwkI5ech3U67pdAEGQ0Ky1QFhDBQoA+BmQtflPdmOVmTZevq+BxPo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=silabs.com; Received: from PH0PR11MB5657.namprd11.prod.outlook.com (2603:10b6:510:ee::19) by BN6PR11MB1428.namprd11.prod.outlook.com (2603:10b6:405:a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.24; Fri, 25 Feb 2022 11:24:48 +0000 Received: from PH0PR11MB5657.namprd11.prod.outlook.com ([fe80::dd2e:8a4e:fc77:1e66]) by PH0PR11MB5657.namprd11.prod.outlook.com ([fe80::dd2e:8a4e:fc77:1e66%5]) with mapi id 15.20.5017.023; Fri, 25 Feb 2022 11:24:48 +0000 From: Jerome Pouiller To: linux-wireless@vger.kernel.org, Kalle Valo Cc: devel@driverdev.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , =?utf-8?b?SsOpcsO0bWUgUG91?= =?utf-8?b?aWxsZXI=?= Subject: [PATCH 07/10] staging: wfx: remove duplicated code in wfx_cmd_send() Date: Fri, 25 Feb 2022 12:24:02 +0100 Message-Id: <20220225112405.355599-8-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220225112405.355599-1-Jerome.Pouiller@silabs.com> References: <20220225112405.355599-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: PR3P189CA0052.EURP189.PROD.OUTLOOK.COM (2603:10a6:102:53::27) To PH0PR11MB5657.namprd11.prod.outlook.com (2603:10b6:510:ee::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 43e7a45a-8628-4241-6cb8-08d9f8516e71 X-MS-TrafficTypeDiagnostic: BN6PR11MB1428:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wTEU1WqzsgbmGw1BpvjM0z4lmRwqsJXEG4W3Zp86oQ2La0v70ixL6HEVZ92j2LmQtdjGugQ1sT2evV5KpADMiVRL6pZ53juADtC/kq3vINPReecHFEQQjFMXsJXIlNacjLXqfjfgu2yUV1QxWg0Vp5CD+uMPF4D3OawjsFXV4YAqZtW6/NlJo0Rpd8UvyTtqVdyCZ3oVwqQFoHEgrWjISqbNG0128YamPkyJdlDIhrCHT7sH4eor9rHThewkmxMNT3f6c/EC2+ithBIitB1nf4T0p6CI+MSOZw5BeORbIyk26Uw5EOcbqnc27+KWiyAhouMozxSL8wH9hXnh3RLsGSt05bdpxpPtelQLw69g1EY3/yrnQzdMUd40rYtRfMs/R9AN2asmYs5d0Yw+1gfi9rScsfpO6/ZniJOEMkoSICEONdNueAAm75fZr3R6ruGUczTFiemRG8A9aehjFZ+MnM8RKdPs7r9aPocOMncdwqKwxUFUGZJZzlY3ZuYvsl44dcv0izgP04/DZE9bNcCv2mKa45ylZbVoDoCPt7a9d3x9MkAa5UPpfOTaWoU6SLxyd3+QWBoZY9UmTEBPxh08IrOv0Q3pimR1Ta7zF9ORagMgdI2GWUDNNJ2xwMCb7ZFKpllnItzq1lV4cIfo5OwM5EYE9FqKSFRz89bvk0H6E5q91B/5CCUIcIxlnKlfOMoCBI/TFRuFUnkFMp6holoq0g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5657.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2616005)(36756003)(66574015)(107886003)(83380400001)(6506007)(6512007)(4744005)(8676002)(26005)(8936002)(2906002)(38350700002)(186003)(5660300002)(38100700002)(1076003)(508600001)(54906003)(66946007)(66556008)(6486002)(66476007)(52116002)(6916009)(86362001)(4326008)(316002)(6666004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?/GUBmEazBLsKO7rqjxwkk9OH42iR?= =?utf-8?q?xdfAwIc5eiAQ8D+J5Uj254VwLUXciHSwWZFwxbARC3eTyAIHduSwSIJZ9QXb7dkE5?= =?utf-8?q?onc8t+UV4lCT3CkbtJfe2NZfjFlXseD6XF4OTKjt+IGGwxo0exthJYy7jw4uAiQ8b?= =?utf-8?q?mgmEEn05c3644vRjVKI4wvCebW0+sb7cbw+GkDrH5gBipena725pSNE2ljDdpXrg3?= =?utf-8?q?ZUCRL2ydvkrwyiT0C+Uy7tdWh6nda6LEw3r7E7tgEs0JvjNNkl9/pF9Z13exmBUFy?= =?utf-8?q?iU7U2z3vepb9msiF1o6Dqh6XnUIAUdLpALXk9mwFfVj/OGmEsO2yt42ppr23qwrLf?= =?utf-8?q?faKvaR1D3W33RpwsdVTPpWuEfBvvYBslXB6bjHdoSKREJILooO7zc6LOEiOwhakT+?= =?utf-8?q?lX/SAywbJExwZgziCZf8egCg+2xTO24R6u8rA99xa6Az7cfjKwYghQMn4oY4RyVfV?= =?utf-8?q?jBt04sC+W/LHvtVA4RCRWZ9/KJxn7XcVex6BuS+2IMt1gDCzwtatgFgaysSbjiWB2?= =?utf-8?q?4QzytadC2AJ5NlLCvejo78tKHZmMNs0woJ6FpSrnvRQGBvg40A+LLjLWBnQLfGgxT?= =?utf-8?q?QU7V1rVK9w9vx6NKIg94W3yaXBSnUKD2k+ml4DdAnMfnlzDsRL+tYjyh13StXY6H/?= =?utf-8?q?a1LdWN+qRWhi1ruspnUh66dVosQ8kvYqBVvdRIasjhfOlEmV68UUUADjENRxZDLF+?= =?utf-8?q?7AAA9jjNeUx7AFAni1h4EwH0nTvLtbgHit7jxdVrYpRxxcmAa7HXi+S4oA5DwcPAL?= =?utf-8?q?HMQUPtjaCHZaVHsIg2+BrZxzY/JZRKtcOhEExq2P0RMSsACzxvoDbCL/+p+Yhwlej?= =?utf-8?q?AKhRK1fG3V/JMtyvCkZ3tz4wLG3MdZ4G96k2A8VfXf1uKPAut9tuQMii4qMHbXp0X?= =?utf-8?q?nEoD8TRhbp+G1T1KDhaqjEthujr1uahzq52OgUiMfHTJ9LRibaUdb0iLjfm5NySIr?= =?utf-8?q?kzdAXL5MfQhaEHrDBQYufMIyYbhFJKOsw6IPRNj/Cccc1IrTnc2oyh9gRuC4Y22Qm?= =?utf-8?q?36HTALwCji/ea51GoVs+cNPSBDmtIvPcgVV5awCPLAJldR1z4BbLAikHbLkIPd4zr?= =?utf-8?q?MncZalL2wi+9wR6hTrmVq4a8F6iO/pmOuAsFS8/VHxvyyHYA6qCqQ29pII7hW+ynV?= =?utf-8?q?20e7wSvLZSa54CzHsZKlI/Z5hFXQAOH9MiBVGg+g/zm0ndIotTM6im9nAiekY8kRa?= =?utf-8?q?aT/ZEUzH4f3ckxjbpqCUH9mT/WAG0ihbVjOJj+kLSPkj9WgQRvQ+nRdqaC2ULG8tz?= =?utf-8?q?grzS18wzlcSWnhI3sC5rhKlqIx7n7k/BZGnjPKki6DwuZ4ZAkUKpwq/VfEPDGOnmi?= =?utf-8?q?NNVRPLolzn7sFw6rH8zMI+x2tGXr4zgutwcwu5rh4ggA/Xqxug+3gJ06Bmwp1ujFk?= =?utf-8?q?8yDwET1D53FOkR65K5ky60uPWGCyyT5k5rg4EkLlGivJtUHzW6ng13lYEqHxdkJo+?= =?utf-8?q?yEyzXfLa3JMeO/7LIzVtEJUbWRePqBnBUfLJnhY8KHdg8HrHVCQuTUQ+oZiXr95u/?= =?utf-8?q?Gs+EwaoCvPEZCrUHkLw5W649sAZQcWGJyFW572Cn/KPYuUYmFbgiYWE=3D?= X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: 43e7a45a-8628-4241-6cb8-08d9f8516e71 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5657.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2022 11:24:47.9695 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5jIB1XFM3XD5FOZL6SGWh0abpZd5nNzaOjsy4GseNf7qejiavaIYzY8qD9PL0GnsIdiwuPDDtJdZHJLoFC/YRw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1428 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Jérôme Pouiller The code to execute on end of the function is the same whatever the command replies or not. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/hif_tx.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wfx/hif_tx.c b/drivers/staging/wfx/hif_tx.c index 236f9d62e3a9..0b1ed12c0e83 100644 --- a/drivers/staging/wfx/hif_tx.c +++ b/drivers/staging/wfx/hif_tx.c @@ -74,9 +74,8 @@ int wfx_cmd_send(struct wfx_dev *wdev, struct wfx_hif_msg *request, if (no_reply) { /* Chip won't reply. Give enough time to the wq to send the buffer. */ msleep(100); - wdev->hif_cmd.buf_send = NULL; - mutex_unlock(&wdev->hif_cmd.lock); - return 0; + ret = 0; + goto end; } if (wdev->poll_irq) @@ -98,6 +97,7 @@ int wfx_cmd_send(struct wfx_dev *wdev, struct wfx_hif_msg *request, ret = wdev->hif_cmd.ret; } +end: wdev->hif_cmd.buf_send = NULL; mutex_unlock(&wdev->hif_cmd.lock); From patchwork Fri Feb 25 11:24:03 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 12760125 X-Patchwork-Delegate: johannes@sipsolutions.net Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 606A7C43219 for ; Fri, 25 Feb 2022 11:25:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240164AbiBYLZw (ORCPT ); Fri, 25 Feb 2022 06:25:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238811AbiBYLZs (ORCPT ); Fri, 25 Feb 2022 06:25:48 -0500 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2068.outbound.protection.outlook.com [40.107.243.68]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE8041DBA80; Fri, 25 Feb 2022 03:24:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NAJVydU8fMGkCwJvL6GR1C9vZyJ/7wFbW0FJKNyy0d2GLDCPRWGLiiVEpIcMYfutUdelek1Eho5g4wBubljfii4ulY+rqAVFnyXEREOJVOG6LSUbtvlS/YaWtqvQVR4O6vVtxXxlk1u9eSyWL6FG/z1Dd2LBLg6Gt4z7FkA+Y3h9T7s+UQydD+1ToCfKMFPOl502dzyEClWEIIPBGOKcmsL8Bsn9pZIWTNqSOw3TVOsgFS9FSY4dES2qzp28zt2lfZhWc2UDgQjh/q7XoNla6xOtW7FPql8k+lXVmdGFH7IA0SRy01Lk3EbHkEo1tHmFUCRQ5AP2lXLdrMKvm/DVOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nFG80ytckh9LmzJFSxoW+PmAHRd0OhkLgBzAq1w2Oe4=; b=mmzt496gvDd31ZTJlZKnBfgIPcRGSpyv+ipdk7n+AKeFh98W1KCD0UWOn3jtCLFbZuUEQL6iDu6bdRhZLyL8XF4AK70Neho4dmH6sFeB+Lp37Us9BO1dTxH/oTwKRUeaUxvq36tcgTRcABj5trpNxTlTn18O8YuTkpb89ZWYoYJO3IP3eChIRJ4HxlzLntCXGWRwAWHEfP1zY9gN1q93WYij4e/hMe8xSTWNp2tN92xpM73M9WimxT30O+w+k/EZ+YHvIflfq9VA5cwPZNhcz66gOZYedp0a+vQjtJrxjxZw/DYKZxJ5pJVfqI+XYJzaYvp6gKVgu06OB36uv/Cb3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nFG80ytckh9LmzJFSxoW+PmAHRd0OhkLgBzAq1w2Oe4=; b=VI71eWw1P9nuJtXSnR/y2MmlMuPhzVki3okbWOfAHnIOO+DBgHWsstfoQjWmC3Xh75o3yyCPCNFb1H20XCGEDbtGDazX1onH2rOofmOvOh0VC0Hsp8a69BTKo2dj4O56ZhHPIKdLX0tVxGgRqMQm8aQwucG/Sam5xwj0Q9z7mwk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=silabs.com; Received: from PH0PR11MB5657.namprd11.prod.outlook.com (2603:10b6:510:ee::19) by BN6PR11MB1428.namprd11.prod.outlook.com (2603:10b6:405:a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.24; Fri, 25 Feb 2022 11:24:50 +0000 Received: from PH0PR11MB5657.namprd11.prod.outlook.com ([fe80::dd2e:8a4e:fc77:1e66]) by PH0PR11MB5657.namprd11.prod.outlook.com ([fe80::dd2e:8a4e:fc77:1e66%5]) with mapi id 15.20.5017.023; Fri, 25 Feb 2022 11:24:50 +0000 From: Jerome Pouiller To: linux-wireless@vger.kernel.org, Kalle Valo Cc: devel@driverdev.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , =?utf-8?b?SsOpcsO0bWUgUG91?= =?utf-8?b?aWxsZXI=?= Subject: [PATCH 08/10] staging: wfx: prefer to wait for an event instead to sleep Date: Fri, 25 Feb 2022 12:24:03 +0100 Message-Id: <20220225112405.355599-9-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220225112405.355599-1-Jerome.Pouiller@silabs.com> References: <20220225112405.355599-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: PR3P189CA0052.EURP189.PROD.OUTLOOK.COM (2603:10a6:102:53::27) To PH0PR11MB5657.namprd11.prod.outlook.com (2603:10b6:510:ee::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9991364d-8612-4a67-545c-08d9f8516fa0 X-MS-TrafficTypeDiagnostic: BN6PR11MB1428:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: C+q80jbDTT74yumiQqauKqJYz+rrhGyI1fMfhWteCFBJeHfoRCrynEAj2MXya8AR37OjBOpG7on0xEu2lzNBvUOr2vqLC+lbp50ji+sNGaSBccA537jCNTaMiKYt4e0py3sJjjYJvw1ltot4dbhkNSm/u3WPkOE+CH1SM5QnhuAIofmBWKt3EV6HLGE9XQk+KSXrlU/3O0ri82lFD5TI4HtbW9aSyT5c1zoU3ZwIjQiYKEQDiCBtbM7p2iptwA2dG48oTY3riliBqfKf0ZaUvUMP3SJINWduXIZqZrdTf8+8ThYBt4sE1yoghzyU+q7h6yb5kHX9opfcr0pPBQGJaFpZzdN4HZu0jDJJJl5OqkvatT7vMXcHQn4j6DLgHfqsG1gYxT8X/jrRgggvdvKbupWVCVs0XIZQptepAU2xFyUyn7/EY2XLjBhncE9SBQXVwyPs3DomWBL7fuMx2nI5yR+H5xV0p3NcpFBtV9UPuAwRV3OSrNK2Wsu8XFxA2gmg9Tmv6DwXG9en1R0B1hHFRof51lMhgqZCLx3AGL9uk5U4hl0WVFS6Qz9awQjXcEqx/2sIUlvBaeC67dfW3h10UY6FXtiUIb3m6MIPJuc9yDqgjFQvNg+VwgLjVj8g0vGWgztznJt8/zfTLkNtKXZB0YvLLNFDqB3I7dlXNtEkoZEjpBpbUrojekjd7Pga22vLqhnMd83AEMGBeAhDukRyPQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5657.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2616005)(36756003)(66574015)(107886003)(83380400001)(6506007)(6512007)(4744005)(8676002)(26005)(8936002)(2906002)(38350700002)(186003)(5660300002)(38100700002)(1076003)(508600001)(54906003)(66946007)(66556008)(6486002)(66476007)(52116002)(6916009)(86362001)(4326008)(316002)(6666004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?o/6jrvEgKdPKcKPiPrlS5L0Avuzp?= =?utf-8?q?ODNwkte9th+EVE7A6d0fyxesH9ei1q26bP5pm4NnYY28JOIiU1G4MApzjxSqDdrXW?= =?utf-8?q?QVoIfXof3uPYo2fir7LqzNO35m2uRF7n+Yrr7v1xKnkys8IzyieepTj95O2zKNjt7?= =?utf-8?q?mVgjc3vmEMB2Qhfh+0Ze/6vzhX5iFIm3vF0rN5GvxMUxXRqlq4Sc6E+IH/Fd47pD7?= =?utf-8?q?f6Sn0tB9Fa0RMn5QFufRQvarckUpFJcyezWGFw2Udp850kAThOXytllpSQXJllVIy?= =?utf-8?q?trYG2I2kf/vH+a+TOIl3j2Ax9PpBDqlPEENH6F83Eiv4hntzh/Bf6CAe4J6nMvQ/j?= =?utf-8?q?kRoLe7i6eDrKIbCXWQLvpSB8WDh0d5JqpntHOm+7UmY3HXBQaFi1OB0doNosXnsWI?= =?utf-8?q?cUAHu94z4UBVcq1eyWK3xossfzou+AzojCqH/GHiWSLCroE6Z3D+EL1RGWRW2kiv+?= =?utf-8?q?I7xwu899eXaxmUZnXZ96eK1hu4g7P+uZtW+kb7EKT9GV6u8x0faTOuhBzOhQRouXx?= =?utf-8?q?zL7ye2AWZwScXe7DLRD2FNducSs9Uvh2fUJfPtldkaWWm8X1Z273rmir4Lg5qqetd?= =?utf-8?q?6xFbu3xDgcfXrSvR9Fnqa6wVDl7TUnrryyajCCFzJ7+SAzoDDvMvkUc+MV/KeVQB1?= =?utf-8?q?pIi5lhf/r2ihq+IE5ZG3t+FFGpuUojcIhqMCXUSYPQLxfC4aFyf8rw85tG8jHQBn6?= =?utf-8?q?MTZCjN1r/wcssTI0eQAFu5oKSO8elmuEWR+17hXIKAtBXxtN7dCGsFzlqc+FxImdE?= =?utf-8?q?RfohAe8Jwp7Btu7qqJNijKkLOWFLOrrMnBbqu3GmzER5GtRZYzMacUTTse59Rg4I9?= =?utf-8?q?YvbNXVA6KUxeINh4x0BWh45iOYUrUFOTgPSFsuhgKHmTVhNkYkWDh/kIxGORJNcIZ?= =?utf-8?q?2Ca+up2n74YaBK4tg/RWz9utFZwemwQ39EWsnJ7+etVin3W598ii4gFmAQMdA6B3M?= =?utf-8?q?VwDElDtg2BCbENCzowCqTuZ6VEpvsM/baaAvcwWx/pMN96tgWhA3Y7fipmjhm2JAT?= =?utf-8?q?dC4Y6ds6rfK7zry1PCJHVGo+Dv4E/IYLXZCfXslXbkHcDVezvlVNEvtlxGBh7JSHE?= =?utf-8?q?1WHyJInFIYff22XGSOu9+2psi2v2KTV/Z33btRmoNjosc/2+TJZt2PuXkc5VMgRkV?= =?utf-8?q?jzgPbJF4LoJfNWwbUX32boZmfYoxsQt0SGkiENBoqZEvswiQeKyb3nkmrxiqLo6K5?= =?utf-8?q?t/T4l+WctS8/7vjOSnW9nwvVekOqB3JmZrJkjmOL1X8qvI50tTW19yDZHfWJWwE1q?= =?utf-8?q?aRLR4iN8TBAgyQzv1WsxvR6P6anPlf+Gxr/51VSiFImTB60ZtMD5wAOszKSHP59kU?= =?utf-8?q?sKfHKTA+6SqnpKnhEmD9x0C0AuwWTy9sSH3aYWk0uq0p36HJ9XkhmByJzQJ6eg3/c?= =?utf-8?q?BwAvNpV62Kv4dE1Sw7c/WD4taopmHMsc0hUhmkGe9sTUKRcbpUli28uRhoQ5jHtKR?= =?utf-8?q?ATrkJrB9ZnB79xYeyZF6Wd5T/WiG8G2YSaRCQpxeTIfc4u6QkvY872lOerxL+7oNW?= =?utf-8?q?tZQwygHqrbiMjiYUjJFC5t7op9WknX/LyLCVPLKp2WkaCH5m/u4S3bs=3D?= X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9991364d-8612-4a67-545c-08d9f8516fa0 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5657.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2022 11:24:50.0953 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YHi4xf5+fn3lZgAz08MANi+D4XdrD7wTQE1bJLO9RgyA2TFk/XP6TOowpeYxUKuCJf0cBexxOf++ZjKdJZkxeg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1428 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Jérôme Pouiller When possible it is better to wait for an explicit event instead of wait an arbitrary amount of time. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/hif_tx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wfx/hif_tx.c b/drivers/staging/wfx/hif_tx.c index 0b1ed12c0e83..ae3cc5919dcd 100644 --- a/drivers/staging/wfx/hif_tx.c +++ b/drivers/staging/wfx/hif_tx.c @@ -72,8 +72,8 @@ int wfx_cmd_send(struct wfx_dev *wdev, struct wfx_hif_msg *request, wfx_bh_request_tx(wdev); if (no_reply) { - /* Chip won't reply. Give enough time to the wq to send the buffer. */ - msleep(100); + /* Chip won't reply. Ensure the wq has send the buffer before to continue. */ + flush_workqueue(system_highpri_wq); ret = 0; goto end; } From patchwork Fri Feb 25 11:24:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 12760127 X-Patchwork-Delegate: johannes@sipsolutions.net Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16E4FC43219 for ; Fri, 25 Feb 2022 11:25:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240185AbiBYLZ4 (ORCPT ); Fri, 25 Feb 2022 06:25:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48308 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240134AbiBYLZu (ORCPT ); Fri, 25 Feb 2022 06:25:50 -0500 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2068.outbound.protection.outlook.com [40.107.243.68]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD75E22322E; Fri, 25 Feb 2022 03:25:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NeeTMdjKTn6bPGX08tc3dYcgi9kEPaWayW/jgqAI0UbXRBe7erf07JqGT2mG5wIUuB0mcCpQ1qvPvZVSAvflBo8BwdtpHpwd5nPCTzOqvlQrf4/+mE0WbrRZm1FYRdBKR0ak7XvGs9YT0uoX4HqI9IbywDnKV8YUxMg7DVn8VhQp+tIOLiybTTO1oH6O2j88mtxWDxEXRQn/HZQdeA3swpkx5bQMUbB8XQW0AaK7QinSU9jEAlmjJRSbgf73BnUrIGQfdhhpT7PqvegtHr8q9F2U2LY1FRA5S4ZshoX9l3VYFW6RFyTk8GwACLMOCRJesFm/ufKDMwqkwng/bDewTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+wETx1RzKZhiyXs6XkuVCaiMw7ryaf3FENz497+pcUc=; b=d1Uc+59hesBx0Hie44MCA20z2mXYmUxh3Ue0O/E1MToAB5PP42Uha90yLCJoSQARV98FhEfE1SWNx/mS506AGc5K7mQDTD6HZeDpo0itPiMFs7bQz8V/HgUWrTYg6dqbYc3Ht8nP1NUx/dnT+7b4k3klZS3F9f3kFa+/k8O8TkJuI7H0Pnr8b1w6d3oFkDAwp7Gklx7IjMBGzSe5QWu8f1Im0A/2R8zRNmPN/G9SadSsUSOXVt+3xVC64m3fNm3UnyGLDIsSpp/WAE2QqAVRj8qbNgX9Fv+B7LNImFGkqWQRm7HZaoolYDVYjRhvlTUEJDyPEhMmbY0nrHTmc16MIg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+wETx1RzKZhiyXs6XkuVCaiMw7ryaf3FENz497+pcUc=; b=MuhxZMdbJM05Ltn8/MkejffnNimowOWYeXj5HbCF8NEN74ehSRPz46OQE3EzTd/y2Vvxbz8Q6HaAP8h8r9EAgIa3LX+hDgdrPZL1fYPnS40xDUhSuFZa6m94de7Ok85L9us4ZcJqYqJMi+p3lS39tGMNgn6hfcAgCq0TiX79xl4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=silabs.com; Received: from PH0PR11MB5657.namprd11.prod.outlook.com (2603:10b6:510:ee::19) by BN6PR11MB1428.namprd11.prod.outlook.com (2603:10b6:405:a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.24; Fri, 25 Feb 2022 11:24:52 +0000 Received: from PH0PR11MB5657.namprd11.prod.outlook.com ([fe80::dd2e:8a4e:fc77:1e66]) by PH0PR11MB5657.namprd11.prod.outlook.com ([fe80::dd2e:8a4e:fc77:1e66%5]) with mapi id 15.20.5017.023; Fri, 25 Feb 2022 11:24:52 +0000 From: Jerome Pouiller To: linux-wireless@vger.kernel.org, Kalle Valo Cc: devel@driverdev.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , =?utf-8?b?SsOpcsO0bWUgUG91?= =?utf-8?b?aWxsZXI=?= Subject: [PATCH 09/10] staging: wfx: ensure HIF request has been sent before polling Date: Fri, 25 Feb 2022 12:24:04 +0100 Message-Id: <20220225112405.355599-10-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220225112405.355599-1-Jerome.Pouiller@silabs.com> References: <20220225112405.355599-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: PR3P189CA0052.EURP189.PROD.OUTLOOK.COM (2603:10a6:102:53::27) To PH0PR11MB5657.namprd11.prod.outlook.com (2603:10b6:510:ee::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1486d1e9-6050-4246-0475-08d9f85170bc X-MS-TrafficTypeDiagnostic: BN6PR11MB1428:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vj/BIq0uLHmBl2hKBTrGmj9AmH2tmwp9fzRQG5/9wj6wlfA4zQ+oU12MEh8DGx2aMT4c+xlys8ieQ0XRSlcLrAWfX4NzX8jJb0CSNDLREEO6nu6M7CurnkctOzcKi2cH5vqzKUm+V1eQMxSySrc9Gc7omVU+kyIMa1KWnZ/abUM1CjmLxTtD3EjvwvDpjHMGeL0VOL5SQVWeejJsrp6cxhyFRwFb3J2sNd+kAhHrWUG/uJwwHPxDIcLNssvl0lowWFkx7HKiZOZD3YWruuuV+fpbz81YCPwSZMTI7n59BIUFgJXuJ7h3t9DA6QjsvAeWfHYvBQQxlyvL9oyThLUme1wGe94/t/ChC/fNJLjQP+Di1EWYwUf6Y7dpOnQmm6wO3WY0ACisxI/p71yIeYiK19HQ1PNGA9romVL4gbne+yalddJI6oDJCbOFCc8WwU6Lu0vZuw1G0GXnen238CvbxPXDSKjhC5IlZwz/1pMZmDovGYCPzRtpD2O1GVLCYwR3iNKTAW2L9xP/PLZ39ct8H8WUswGpB+O13dNTSUsIwPT+9QcCNaSYEBS62IoKt3zH/DUYp3XVkL9F8Ut2aC6psihOzr9FiI03mUS9MHvgyT23Rf8HjNNXrxdoRvukpbCO1Zr6sdE8XHhrPsC3mru6+hXAhfeo1LEpX8u4ivbx+AyPRiEK6BFh8V0YAs9mAmLZODai41oG3rQ4TY1wRm2SIw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5657.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2616005)(36756003)(66574015)(107886003)(83380400001)(6506007)(6512007)(8676002)(26005)(8936002)(2906002)(38350700002)(186003)(5660300002)(38100700002)(1076003)(508600001)(54906003)(66946007)(66556008)(6486002)(66476007)(52116002)(6916009)(86362001)(4326008)(316002)(6666004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?54cnj8cJ2L6+GM3mhJp+1Mn81HVl?= =?utf-8?q?pngwamB0HSyHmZVjgK0IzD5upw530qTqAkPswUPayVK6GeKJ+3Md9ExnlmTzyp13e?= =?utf-8?q?r8TvP0Oazk3ST5StIGixcnarbVcUVlOwbYnhZZ0UHYmQ+bM+bsG2upngtlXOPwFTZ?= =?utf-8?q?ny9mn2OxGMhnSpky+7pfqDCsuI8gZAa8k+Ss+u5Uc8BqqyjcQEH/AKn2SiU4j18R0?= =?utf-8?q?fKrwAO44cUurYDVjWyKvpNQEzCzUA1JZq9+SrpGpHAypCqLeYXMDfo8XUwsoSbB6e?= =?utf-8?q?E2jOLmYYagoAGDuoOMIjnhJtDAcMpWdHH5tY5suXxL7R+6tkcBmqDnw0gxjRBJZWO?= =?utf-8?q?iqWtVHHy8ULzaZAyGru+NwPj/8J/xiQqOswy9KCU7qv0mPckBg3VDgMIJ6oeB5WQT?= =?utf-8?q?v1av89f0IEt18AasngXgHcOoYQOvSm2/s6pFhbEvgtik/eD/IFZqgDAqCeV9cTGr0?= =?utf-8?q?UwI8WFxR2TFT0rtjgqJ8t83S0VRCmU7Sz34cwss6RrGmgAcU1f+pbOuoB9Tb1NKqp?= =?utf-8?q?uLohYl34zYudSU5MF7W4psUUNjzOERFniZe9ysYlNqfSTn1QBlHuCNC/GFJ6FC3ge?= =?utf-8?q?8cpjIHCX87Xim3IzX1q8n5SiAoQAazvvW6zqzh7WlPHgmGxF1eiN8ACjnhrS+4QmK?= =?utf-8?q?luT9yDtRztRGo4cwAfbcQuuQKapNhtWPmmWST09tgYceSJuhAGdTA6R4waMKns720?= =?utf-8?q?wCfT6UzVLNPoDO6OibU/31IrpNiSQBXZL29mn9u8degRv38x01aa8E+Fo/O65aZuJ?= =?utf-8?q?R5BlHtwox0t/nvKtO1C5dfm0nj1N6i+1Yhw/8sRboP8cBioMjwd3hlpXAVnbnOV4U?= =?utf-8?q?KbYGVnOiBjfEMCHSslnz3f76murFlSF8UFk+3FqnwdgCAWveKsNttGGHylW5/pXUU?= =?utf-8?q?HQ/pMhmI0DjyRDYEEIoK9J4qQBmt/2/NFLcJ1VsY5eNlep4UOUkCZbW2wpIGYJJ0U?= =?utf-8?q?lhl2hS6NLm3McgA4JhS5wDXpu4UkmKX3i7LVrAaZad8/4GsPRhYpu1/5JtKX4ZGl5?= =?utf-8?q?YQw9irFYhA5LYIaBuH72lQsDb6NF+CyN/OwRf5+yBEW/s2k5a+onTRwgBPu5VD8PP?= =?utf-8?q?gkdBtrriutTBzZkuT5wH3cKqtm6SxHWeUldln5NCUs2cx3R4aX/Z8l3TM7pEy44cB?= =?utf-8?q?CFrJVllwMPFNKWVoDvhUKGJtOEOUkKJXcH0nyTDAbxtiRIuLIOh31Pm8D6pTFJUb0?= =?utf-8?q?yipRSC7I0HT648nJNuTHIzkRDS+hNGTFmTw89t+c/E7dPo7iT97oETpGObhIJpNpd?= =?utf-8?q?QZZGrRQkeCKj5tJdSnR+pyntEOBKF0OzSJ8NecV+0Y3qtKjYOVIZ4smkJupUUTOo5?= =?utf-8?q?kXtkLappR7FSjqPfyLmrocRXE1Tc4RZ5sESIpTgQRvTXQeViRMSIr1AxIjZcgWpJA?= =?utf-8?q?LZRjt+1+Q3frBzaHDGQrFCDBme7B/ET9Zefd58swwaCo9pAFKz1vhUSQrM7TKrnbR?= =?utf-8?q?Ubc+v5rvMI5mALVXRmgYx7GxFYVMmgrvrSYJ+/pEbFx1ZA0FXfwJCunLIS1kIf8FS?= =?utf-8?q?azrZDQEWW37gaq67sx0PuCpSXvOBXq+5q1O7NKQl/DIfER61Acaz7pc=3D?= X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1486d1e9-6050-4246-0475-08d9f85170bc X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5657.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2022 11:24:51.8451 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tXiYJhqspmp0srUILO1L9mn5mND768RdzNQDk4ruklTqdL7WtkdjmSdlSwit5aAgHCl5zQuSQRq3PZlRyduSGQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1428 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Jérôme Pouiller wfx_bh_request_tx() send HIF request asynchronously through bh_work(). Then the caller will run wfx_bh_poll_irq() to poll the answer. However it useless to burn CPU cycles for the polling while the request has yet been sent. Worse, wfx_bh_poll_irq() may get the CPU and prevent wfx_bh_request_tx() to run. This problem has been observed on mono core architecture. This first exchange is correct: kworker/u2:1-24 [000] .... : io_read32: CONTROL: 00003000 kworker/u2:1-24 [000] .... : io_read32: CONTROL: 00003000 kworker/u2:1-24 [000] .... : io_read32: CONTROL: 00003004 kworker/u2:1-24 [000] .... : io_read32: CONTROL: 00003004 kworker/0:1H-40 [000] .... : io_read: QUEUE: 08 00 09 0c 00 00 00 00 3a 7b 00 30 (12 bytes) kworker/0:1H-40 [000] .... : piggyback: CONTROL: 00003000 kworker/0:1H-40 [000] .... : hif_recv: 0:2:CNF_CONFIGURATION: 00 00 00 00 (8 bytes) kworker/0:1H-40 [000] .... : io_read32: CONFIG: 03010200 kworker/0:1H-40 [000] .... : bh_stats: IND/REQ/CNF: 0/ 0/ 1, REQ in progress: 0, WUP: release ... while the following is not: kworker/u2:1-24 [000] .... : io_read32: CONTROL: 00003000 kworker/u2:1-24 [000] .... : io_read32: CONTROL: 00003000 kworker/u2:1-24 [000] .... : io_read32: CONTROL: 00003000 [...loop until timeout...] wfx-sdio mmc0:0001:1: time out while polling control register Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/bh.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/wfx/bh.c b/drivers/staging/wfx/bh.c index 4c6ba9c342a6..bcea9d5b119c 100644 --- a/drivers/staging/wfx/bh.c +++ b/drivers/staging/wfx/bh.c @@ -295,6 +295,7 @@ void wfx_bh_poll_irq(struct wfx_dev *wdev) u32 reg; WARN(!wdev->poll_irq, "unexpected IRQ polling can mask IRQ"); + flush_workqueue(system_highpri_wq); start = ktime_get(); for (;;) { wfx_control_reg_read(wdev, ®); From patchwork Fri Feb 25 11:24:05 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 12760129 X-Patchwork-Delegate: johannes@sipsolutions.net Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58118C4332F for ; Fri, 25 Feb 2022 11:25:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240214AbiBYL0S (ORCPT ); Fri, 25 Feb 2022 06:26:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48256 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240157AbiBYLZw (ORCPT ); Fri, 25 Feb 2022 06:25:52 -0500 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2068.outbound.protection.outlook.com [40.107.243.68]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A1F72614B4; Fri, 25 Feb 2022 03:25:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WUTuDXh3IiS2uxMrgCDoqvuGbbbcYflVd7xeaU9i309vT2e8vGVmsFjGAr4p4c+n5zfPwkPRMiaebTexzEpq2LZMZ7AP7RgWf7LIM7vbe4zi5KR304ml+drJVXOJPMJSOR55f6fO9jgUM0y/9gZf/094j8x8S0Dfq1MhjJwChdXNbd/OZia+McC+y6ytbBhMu0rf/bhE6koxqJUp3T2wgm3u1OkkkerMCCi/sgco0wu3gu4xgSyrn4te8yqoNoFiPp5WUAD83hMZUY4MJKFX17KE8WNTJD2YqZgL3+xRKID/o4xnzpw4Ao+nKr//3+nBtcXI+kQvhcpDvJG8NiXMDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BFAy+Um3O0RTckh+dCumjqPCOmK2mSPn9LLw0VQbGCk=; b=VHnBNIvDzJlHvgOQKy5iHKnpi34iEXwl94AC6GGuRf62G/J6EcV3wswp46AikQRVGx0ICylSMwuiGTYWTtk3loON/vB94OIUqtInPDAflaUvGWj/IM5pdik78UQQc2dKMzjiWrZehgtE0uMfcBzfPYG6CF45Kng5Vjt+GRrHg/swmHXph8RGZT4Ij8siiK06qFYhajUQ0rPD3VtJ8vuIlOGTPGvhl+3JZ/tem9gS5AEtm0tTYoOJDKZJ1zqJr4te0ePlQ/3rZCvPQajZHXZf+ULtxfUZ5juLp+rc27o5xDOJ9B1IRn7dmFI0E5YhDrtxp38yRWXzuC/8B9UoNaLucQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BFAy+Um3O0RTckh+dCumjqPCOmK2mSPn9LLw0VQbGCk=; b=nHB9Aj8L5fxeDB/nC2s1sw5bM9tI0VOtAt1cJkAVKiNdPYZ+r2tm1kkkaVUcP/v0pU1Np/9SwwCAY/ztP05oKm7vXcpyc0CoQKp7ntm2POOkPe9IRQAlwc8b+c57ISCa7GRq8/vya5j1yaLa7F2pqM6zSBawzx5g7HTtFeQSg4M= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=silabs.com; Received: from PH0PR11MB5657.namprd11.prod.outlook.com (2603:10b6:510:ee::19) by BN6PR11MB1428.namprd11.prod.outlook.com (2603:10b6:405:a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.24; Fri, 25 Feb 2022 11:24:54 +0000 Received: from PH0PR11MB5657.namprd11.prod.outlook.com ([fe80::dd2e:8a4e:fc77:1e66]) by PH0PR11MB5657.namprd11.prod.outlook.com ([fe80::dd2e:8a4e:fc77:1e66%5]) with mapi id 15.20.5017.023; Fri, 25 Feb 2022 11:24:54 +0000 From: Jerome Pouiller To: linux-wireless@vger.kernel.org, Kalle Valo Cc: devel@driverdev.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , =?utf-8?b?SsOpcsO0bWUgUG91?= =?utf-8?b?aWxsZXI=?= Subject: [PATCH 10/10] staging: wfx: flags for SPI IRQ were ignored Date: Fri, 25 Feb 2022 12:24:05 +0100 Message-Id: <20220225112405.355599-11-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220225112405.355599-1-Jerome.Pouiller@silabs.com> References: <20220225112405.355599-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: PR3P189CA0052.EURP189.PROD.OUTLOOK.COM (2603:10a6:102:53::27) To PH0PR11MB5657.namprd11.prod.outlook.com (2603:10b6:510:ee::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 255d334f-be68-4d56-ad79-08d9f85171dc X-MS-TrafficTypeDiagnostic: BN6PR11MB1428:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0noAKHnapktj4wFOAkKphno8mUiWBhORw6/IEbvltzBnVVL4jc0BVvCqo1qGU/gZlKoSsNROeYGj9U2H+iNaqQQThfE38vZg136fcH3h9jU72/HGmgG5pADge/7vLvqOlpRliYEKUcuc3KlL/NAMzKXuijlDDMF3aK+um6gc7XRzB/lyhMJahWz9D7bCBTrFR9ZixBoIwuAqbdwzwsINgTnkZZHI/fBQYu/kt1r9qFoWt1u8Uyopm5I27YiNKQt2LJitJaJIJabv2eujeOnX1bd1ZtMvd1dXGrnCluC985s2Kyfet3iXV85kEjI0TwaQdOHEgY0dhuUxhitDO5kYCjxVIECURr8GHzmiqBq03fLaH2+3OgyxqBmC2YZ+/AVmkzq5KXejJeq+b/4phD6OWuTgvHre+1t5HJWdL437/0ntEwB7nKXwQcK1RPhHrS3QRvLkEw+UeMNqxzLKl6uL3hLwg7YjvX+adCzdTZTm5fldNtyx2qV8/zXq7wtCX53AHhVpV4gbFRXFxVaHCD+5nED5Dsx3NI3CLj97YKwE+0M8VG/HNbvVY7HRRg2DIjMY8xKq73S+zeBxBvt0K1nVn1TBtvXujjlei6kFSQ6+9n1UoEWvCkeDcTsiXZaHYM33hJvdumiK8iZBJZRLNYdnOkhEQAm/mQyjmA5YV9hXkqJeaJwAlJca9xYjYlIEuAFFNydoUIkBDZ6XtBv0ZGqFnQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5657.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2616005)(36756003)(66574015)(107886003)(83380400001)(6506007)(6512007)(4744005)(8676002)(26005)(8936002)(2906002)(38350700002)(186003)(5660300002)(38100700002)(1076003)(508600001)(54906003)(66946007)(66556008)(6486002)(66476007)(52116002)(6916009)(86362001)(4326008)(316002)(6666004);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?cxeBPi50j5Ub5mK2D3Bg4nAvWgIv?= =?utf-8?q?2dCIKBbGHobOCQ7ZuXsbLuxEIASvdTfwX8JJ0vKStUSAc5iejS3mf1eigec0THYSp?= =?utf-8?q?fed3/6RM1meL91tNMfYl2V5mwM8bqzezlAfWG0VKMuwmIWxhMTmyAVH02lEgmEnlY?= =?utf-8?q?xXoHcZJaNyoPYrZab4Z+d4Ib1OWngHPmN5hfv9DGyLVYRao1lQDKfHZ+yiOoQMpzs?= =?utf-8?q?KPhv0ldpzy/QDhy1JgD3UWcfnUTCcVvgWb6pQDmVL1SUzQzrFEmIE6/F+X/2QfYEm?= =?utf-8?q?rv0pyouBvHApnjBkg2e8EEqcIe9lzse4Tfyh6DaEBA7gzBkJHMkr65rDunrOQ6zyp?= =?utf-8?q?HSMuCCVldGKrJYBZNPeTLPHU0/UMD5mo7rKAOSPIrzDVUXGD7KjZyVpxUb2RAFEwZ?= =?utf-8?q?hzvcoG/C3fd2uhn4SViczkujZGa43RScAxfcaPLKkYo/6boyHigK/ptJkG2Gb4Up2?= =?utf-8?q?TL99p3oJv1jp5ajkrasBbAZRtqocdXWXuHBrYU0DRqsO4oO6f7ByIyDgopVdVZhVk?= =?utf-8?q?NRoThJk7grPxkFSzBQE8kSiE4CffFk5P8svl8Z4BY8FHl7q58Y8xwMVc1zCdwH7KP?= =?utf-8?q?QXqItZucI11H7b0ZMdx1OLBY5x9UFS356MX7JRWwJZ+Pc7FadLy/P5EuaiV7JF0sO?= =?utf-8?q?yObwbCjTkM7+9r9OPaeUbYhF/pXoHMS7fj9GOC6Ii/Lj/u2WYz2rOHCEnz5l4Yh8V?= =?utf-8?q?KzUW2Kw5NfklpcEOH2jy8zOwDcbAOVt83xDi3/A99BSEBNKthzB544f3D7lz2MSIu?= =?utf-8?q?V8T1TO+aA+mLvI+oAhMY7tMYkTBpK7Wz5s+/955TeSO7J3kjqsXL6hjhW2TmB/+ZY?= =?utf-8?q?Pl9tBncOOBEddSMBsW//ptPjCuI1WlBGFn63SJlrYKThDIOOBcqfxRmOvjaAq2Qc4?= =?utf-8?q?MLDUlIfwKvpNDQYeysWy3DUgeXQ3s9qDiifCjiJK2EiCo683rTjhkBReQdrfxlLe/?= =?utf-8?q?2kd/LZeid8xivDJVXo3vEAeFWYTL+TkCmfQGOfLAcKnyOmcEqULs1Js0BMlYuKJcN?= =?utf-8?q?k1nLW2NVQ/GhYKpTooCUtMxl6HYw0SBvUsu3B52+TrY172Q+JNvNkemZt6B4bryo4?= =?utf-8?q?binsWDm1/0+Hp1G4FfPOAF0r/l3vK0ZOQxup8Z0epg4uss477X22hlGrswvnjxPo4?= =?utf-8?q?wIL6U7/l0SNJIV2LNyeY+FfdkOUpct/yP5zetAWzJR5yrycf/S/KooLCjenghVtp4?= =?utf-8?q?NAtfNwisswdHxo2N4+mwe8kYtbNaSDIXMwxj2Msseryq+0hpAHvYer936axxJqa4j?= =?utf-8?q?iLRwULdMU3VOPoFM2MZ7BW9O7Dp2cN0ariHPTzXYOCIu2H8B8A5NtlYmLm9rpu8yd?= =?utf-8?q?4GNstEV/yx2FgqtipqobbQEyvMK/VaYXzNRsMV8jIAgwi6mbP51w6rQmTjo9DTltr?= =?utf-8?q?m6vgk9+6au5E/TrxTb1OL6/i53os0Vxkf18AnvY0UbDsNbJLXc2OkWDsSoEcxd/UR?= =?utf-8?q?q1oxA1Q6kKuZq6CxZMHbW4zq8i04ArplHlxUA1UApGMhQYqo/BX+ZHsySltB+0Qvj?= =?utf-8?q?8rNw6rsJuhCpCnfJ2vB5oeKD+3gknc+1ghQbmkzCrd8Mwl6suGTJjx4=3D?= X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: 255d334f-be68-4d56-ad79-08d9f85171dc X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5657.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2022 11:24:53.8631 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TxwSQXMgrVnJInIGZ5a+ZeUQ1A9JvIuFvjWcXs6yP1KzbFy6GRrkDqCvUW++8PDvtQhhUcFWRRUsA2yUe/6g2g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1428 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Jérôme Pouiller The flags declared in the DT were not forwarded to request_irq(). Fixes: a7efb62509d8 ("staging: wfx: use threaded IRQ with SPI") Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/bus_spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wfx/bus_spi.c b/drivers/staging/wfx/bus_spi.c index a0a98c074cb5..bb31f8a005bf 100644 --- a/drivers/staging/wfx/bus_spi.c +++ b/drivers/staging/wfx/bus_spi.c @@ -162,7 +162,7 @@ static int wfx_spi_irq_subscribe(void *priv) flags = IRQF_TRIGGER_HIGH; flags |= IRQF_ONESHOT; return devm_request_threaded_irq(&bus->func->dev, bus->func->irq, NULL, - wfx_spi_irq_handler, IRQF_ONESHOT, "wfx", bus); + wfx_spi_irq_handler, flags, "wfx", bus); } static int wfx_spi_irq_unsubscribe(void *priv)