From patchwork Tue Mar 1 15:31:20 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe Branchereau X-Patchwork-Id: 12764848 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 203B2C433FE for ; Tue, 1 Mar 2022 15:31:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234985AbiCAPc3 (ORCPT ); Tue, 1 Mar 2022 10:32:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50748 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231533AbiCAPc3 (ORCPT ); Tue, 1 Mar 2022 10:32:29 -0500 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 451325FF24; Tue, 1 Mar 2022 07:31:47 -0800 (PST) Received: by mail-wr1-x435.google.com with SMTP id p9so21084887wra.12; Tue, 01 Mar 2022 07:31:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kABsl8nFckhHhGe72PdD4LYbj+x9bM4gFy/8W5Qq+ys=; b=Y3t0gFOybWi0MCei9ZUc6VbMi31QOTaeoMi0EEuB9EGC8sXZVldqOJmDzlxTlRAKhr sHJAuqEiWaDoxD8VxLmmZj9TBDOQlMYzaZ2hkOB3rx+KPUygSYGFzYt0RPHK8bBjlXMy tXJZxdv8M4GQzCp4EX8K17PD+n6qyDiWQawvs3wLUtkPHy25dQSjBLhYjsqPF7/DgVPr N0gkSCJTvnYALhOOcAIECIXyB39CT3+kUoyVs95Y6salojTsWXvJcptr2hOpA5Lbx+Ps hlHN3GXJq06VPtv8B3Y767p8ClFl6VftI6aMw8vzYPD4HVlpmMkJdl2L7dKBogLTrsSS Jj9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kABsl8nFckhHhGe72PdD4LYbj+x9bM4gFy/8W5Qq+ys=; b=YjJXXHADj+Fl1koxc843DGJtMCn7GtrcJNRJHjmTfRkHoUGPihgqBRKpeSvO+r0Tye Q3OFzHaAJQxiVtIBz1Z8QcKSLe4wQsWATA4CQqR20ul8T/+uZpznAMgHCYEgw7SaGdjx CvtvyB08IhRAzXlWTxsWEcGqFOIi50v0frz7j6a9zZlEl8okG7N7Xn5TnjXXCXU3ZJaY 0gf+7BOBXLUeRZOkJa26X4acXOo1kiRdATROwVlDGuP26KMwlGM+flj2ZD26EjbJDcN0 LWycgDx2qnujFWcH/+K3/FV5Mlee9LH0J7YC2I7STlx+hqqGE78xw0SG0HDsB1Hd/NBI xTzA== X-Gm-Message-State: AOAM531iZhPCRaSQMCJ2jh3tOrwiuyaFbyFMqzYHleEHLG8ZuE8sJrwK 9uU+JDVDORjZ70uRb6++ZMY= X-Google-Smtp-Source: ABdhPJzIkkJjFN+Ll7MM/KbLuKabD6lSAVrRlRI0D/yR4BBSZY9LHIvA4txOSvNmXtoPjUKKd4ipDg== X-Received: by 2002:adf:e6c7:0:b0:1ed:9f7c:c99e with SMTP id y7-20020adfe6c7000000b001ed9f7cc99emr19458323wrm.0.1646148705791; Tue, 01 Mar 2022 07:31:45 -0800 (PST) Received: from monk.home ([2a01:cb10:430:ec00:4737:d56e:186b:af1]) by smtp.gmail.com with ESMTPSA id b13-20020a05600c4e0d00b003816cb4892csm5797377wmq.0.2022.03.01.07.31.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Mar 2022 07:31:45 -0800 (PST) From: Christophe Branchereau To: Paul Cercueil , David Airlie , Daniel Vetter , Thierry Reding , Sam Ravnborg Cc: linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [PATCH v1 1/3] drm/ingenic : add ingenic_drm_bridge_atomic_enable Date: Tue, 1 Mar 2022 16:31:20 +0100 Message-Id: <20220301153122.20660-2-cbranchereau@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220301153122.20660-1-cbranchereau@gmail.com> References: <20220301153122.20660-1-cbranchereau@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org This allows the CRTC to be enabled after panels have slept out, and before their display is turned on, solving a graphical bug on the newvision nv3502c Signed-off-by: Christophe Branchereau --- drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c index dcf44cb00821..51512f41263e 100644 --- a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c +++ b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c @@ -226,6 +226,18 @@ static int ingenic_drm_update_pixclk(struct notifier_block *nb, } } +static void ingenic_drm_bridge_atomic_enable(struct drm_bridge *bridge, + struct drm_bridge_state *old_bridge_state) +{ + struct ingenic_drm *priv = drm_device_get_priv(bridge->dev); + + regmap_write(priv->map, JZ_REG_LCD_STATE, 0); + + regmap_update_bits(priv->map, JZ_REG_LCD_CTRL, + JZ_LCD_CTRL_ENABLE | JZ_LCD_CTRL_DISABLE, + JZ_LCD_CTRL_ENABLE); +} + static void ingenic_drm_crtc_atomic_enable(struct drm_crtc *crtc, struct drm_atomic_state *state) { @@ -237,17 +249,11 @@ static void ingenic_drm_crtc_atomic_enable(struct drm_crtc *crtc, if (WARN_ON(IS_ERR(priv_state))) return; - regmap_write(priv->map, JZ_REG_LCD_STATE, 0); - /* Set addresses of our DMA descriptor chains */ next_id = priv_state->use_palette ? HWDESC_PALETTE : 0; regmap_write(priv->map, JZ_REG_LCD_DA0, dma_hwdesc_addr(priv, next_id)); regmap_write(priv->map, JZ_REG_LCD_DA1, dma_hwdesc_addr(priv, 1)); - regmap_update_bits(priv->map, JZ_REG_LCD_CTRL, - JZ_LCD_CTRL_ENABLE | JZ_LCD_CTRL_DISABLE, - JZ_LCD_CTRL_ENABLE); - drm_crtc_vblank_on(crtc); } @@ -968,6 +974,7 @@ static const struct drm_encoder_helper_funcs ingenic_drm_encoder_helper_funcs = static const struct drm_bridge_funcs ingenic_drm_bridge_funcs = { .attach = ingenic_drm_bridge_attach, + .atomic_enable = ingenic_drm_bridge_atomic_enable, .atomic_check = ingenic_drm_bridge_atomic_check, .atomic_reset = drm_atomic_helper_bridge_reset, .atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state, From patchwork Tue Mar 1 15:31:21 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe Branchereau X-Patchwork-Id: 12764849 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA5CAC433F5 for ; Tue, 1 Mar 2022 15:31:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235102AbiCAPcb (ORCPT ); Tue, 1 Mar 2022 10:32:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235197AbiCAPcb (ORCPT ); Tue, 1 Mar 2022 10:32:31 -0500 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 599E5245AC; Tue, 1 Mar 2022 07:31:49 -0800 (PST) Received: by mail-wm1-x333.google.com with SMTP id 6-20020a05600c024600b0038125fa8e43so1414842wmj.0; Tue, 01 Mar 2022 07:31:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=AcFIzjsZokuLvaSvmAWJOq61tNoIHiYSYpbbWlxLmBk=; b=d/T51Q11+kQoua+DIks++L8WGjY2LIbqI6TdjaQMCYRls8xuPpUPt5PFjaayrTdkqH gmujYE9u7GNO0Z9HyLqbf12v3wpiRbB3LBxqiAfuZGMJCoda1l2oZcK23Pfwdjpbb1UC WyugQzpdtV7MQCGJuXNY7geimlE9xiQ7v2pRD0xzxYNk0JitsGrW5VqmUx5A3JP1LiDy W5x9IbyglvNCOsO5j3xTZO0tJpngKYoROqZfJTBvTQQdEtZmoqu1jqUNOkuxOFcVItn9 oFcK3f1xe6pYMTHfB/r2uDa3uJ+K8liZ5IDYlCQB1zO8c6EZNHpHbt4XqvyBroykXvhu esog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=AcFIzjsZokuLvaSvmAWJOq61tNoIHiYSYpbbWlxLmBk=; b=Alx8TSjf1oXZLdEAd3q1jSsqlJolo1rXJ0IvUs1zEeWS7gnvlw883hzYYVqp3ty12v MC7f84GLWAXjmB4UrU6Syzzuym691QN77vpZYrVb+1lql2EJKu/tKzgzHCujG5btLYIu 1dSHZlVdHDSRzzJP5bKDVoX6ENJIczu4qYtPhc6JkykZGaLKiijJ3FgEwxx5TVunT9Xl NVe2k1DdpjfUE4l+0lMj+fsE1niaFnK2mTgZVu013E1wx0IQdMVLAiPeOrfbJOdiwihO azSbmziMGOcL47/SG7wNQgAA24wwwUkAshlFR6LQYtbiHguyPYx/sNPEz3Kb619/Ilor W2eQ== X-Gm-Message-State: AOAM531f72f8n/Kp7G/aLH0ZOQs2XXYxqkXUus4dxsEiY3FpnKkvB6mY htgS5L6zpNsVNrIM2f6GjrLlFzrt9Yw= X-Google-Smtp-Source: ABdhPJxBvjgoECNx0hXV0K29nYcbXhLGmltAH9m7qgn0P5+03jJfHC6W/dYWRnxGGmNLh5O79jwFlA== X-Received: by 2002:a7b:c04e:0:b0:380:ead9:254a with SMTP id u14-20020a7bc04e000000b00380ead9254amr17403465wmc.58.1646148707674; Tue, 01 Mar 2022 07:31:47 -0800 (PST) Received: from monk.home ([2a01:cb10:430:ec00:4737:d56e:186b:af1]) by smtp.gmail.com with ESMTPSA id b13-20020a05600c4e0d00b003816cb4892csm5797377wmq.0.2022.03.01.07.31.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Mar 2022 07:31:47 -0800 (PST) From: Christophe Branchereau To: Paul Cercueil , David Airlie , Daniel Vetter , Thierry Reding , Sam Ravnborg Cc: linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [PATCH v1 2/3] drm/panel: Add panel driver for NewVision NV3052C based LCDs Date: Tue, 1 Mar 2022 16:31:21 +0100 Message-Id: <20220301153122.20660-3-cbranchereau@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220301153122.20660-1-cbranchereau@gmail.com> References: <20220301153122.20660-1-cbranchereau@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org This driver supports the NewVision NV3052C based LCDs. Right now, it only supports the LeadTek LTK035C5444T 2.4" 640x480 TFT LCD panel, which can be found in the Anbernic RG-350M handheld console. Signed-off-by: Christophe Branchereau --- drivers/gpu/drm/panel/Kconfig | 9 + drivers/gpu/drm/panel/Makefile | 1 + .../gpu/drm/panel/panel-newvision-nv3052c.c | 504 ++++++++++++++++++ 3 files changed, 514 insertions(+) create mode 100644 drivers/gpu/drm/panel/panel-newvision-nv3052c.c diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig index bb2e47229c68..40084f709789 100644 --- a/drivers/gpu/drm/panel/Kconfig +++ b/drivers/gpu/drm/panel/Kconfig @@ -283,6 +283,15 @@ config DRM_PANEL_NEC_NL8048HL11 panel (found on the Zoom2/3/3630 SDP boards). To compile this driver as a module, choose M here. +config DRM_PANEL_NEWVISION_NV3052C + tristate "NewVision NV3052C RGB/SPI panel" + depends on OF && SPI + depends on BACKLIGHT_CLASS_DEVICE + select DRM_MIPI_DBI + help + Say Y here if you want to enable support for the panels built + around the NewVision NV3052C display controller. + config DRM_PANEL_NOVATEK_NT35510 tristate "Novatek NT35510 RGB panel driver" depends on OF diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile index 5740911f637c..42a7ab54234b 100644 --- a/drivers/gpu/drm/panel/Makefile +++ b/drivers/gpu/drm/panel/Makefile @@ -26,6 +26,7 @@ obj-$(CONFIG_DRM_PANEL_LEADTEK_LTK500HD1829) += panel-leadtek-ltk500hd1829.o obj-$(CONFIG_DRM_PANEL_LG_LB035Q02) += panel-lg-lb035q02.o obj-$(CONFIG_DRM_PANEL_LG_LG4573) += panel-lg-lg4573.o obj-$(CONFIG_DRM_PANEL_NEC_NL8048HL11) += panel-nec-nl8048hl11.o +obj-$(CONFIG_DRM_PANEL_NEWVISION_NV3052C) += panel-newvision-nv3052c.o obj-$(CONFIG_DRM_PANEL_NOVATEK_NT35510) += panel-novatek-nt35510.o obj-$(CONFIG_DRM_PANEL_NOVATEK_NT35560) += panel-novatek-nt35560.o obj-$(CONFIG_DRM_PANEL_NOVATEK_NT35950) += panel-novatek-nt35950.o diff --git a/drivers/gpu/drm/panel/panel-newvision-nv3052c.c b/drivers/gpu/drm/panel/panel-newvision-nv3052c.c new file mode 100644 index 000000000000..08a3b33bcce0 --- /dev/null +++ b/drivers/gpu/drm/panel/panel-newvision-nv3052c.c @@ -0,0 +1,504 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * NevVision NV3052C IPS LCD panel driver + * + * Copyright (C) 2020, Paul Cercueil + * Copyright (C) 2022, Christophe Branchereau + */ + +#include +#include +#include +#include +#include +#include +#include +#include + +#include