From patchwork Tue Mar 1 18:56:19 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 12765075 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 336E6C433F5 for ; Tue, 1 Mar 2022 18:56:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 80D118D0002; Tue, 1 Mar 2022 13:56:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7BCB58D0001; Tue, 1 Mar 2022 13:56:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6AB1D8D0002; Tue, 1 Mar 2022 13:56:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id 5AEFD8D0001 for ; Tue, 1 Mar 2022 13:56:29 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 23CDC121945 for ; Tue, 1 Mar 2022 18:56:29 +0000 (UTC) X-FDA: 79196723298.12.41F0618 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf25.hostedemail.com (Postfix) with ESMTP id 501F7A0006 for ; Tue, 1 Mar 2022 18:56:29 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A1FB0B81CB2; Tue, 1 Mar 2022 18:56:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CFFE8C340EE; Tue, 1 Mar 2022 18:56:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646160985; bh=usfHRRJQxk5ZPBBjY5lM+QOMJJruSA25LZ2RYqAjsk8=; h=From:To:Cc:Subject:Date:From; b=boS0m3SGvvVYdSDPMbk2vmPxKby2L4qP2A0CRlh1JLasCXH718Gwc5zuNqHnFHDDo 1bS2HQCfW730Eb+VPYoyxy7qyvC0X4GRiFaOTQiRRcwzEnto9FfSjh8juc7OiGgVWa 7kCGiW0awUpro2719e0IwyMHrcZDNvpDf2PCYtkGX8RIYBeLD4rYxYmYOo5LCJcztA 6Dc+k0R8Jhd0M5cN49XzxpxULfU/yV76oE8PlIKTpI4uxs+MS+vyLv2pLZinng0u12 9ZoVseoreMsjOmJZXMzMLgWxjewxjnyfBXMDH0DTSdkA4bV/FKZPfrw37po1BURHgz Zaw4XH5rzM/1g== From: SeongJae Park To: akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, SeongJae Park Subject: [PATCH for-mm] mm/damon/sysfs: Fix out-of-bound array access for wmark_metric_strs[] Date: Tue, 1 Mar 2022 18:56:19 +0000 Message-Id: <20220301185619.2904-1-sj@kernel.org> X-Mailer: git-send-email 2.17.1 X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 501F7A0006 X-Stat-Signature: 315cjr4tmbnxucbrxmn4qu6qt7uku6s3 Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=boS0m3SG; spf=pass (imf25.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-HE-Tag: 1646160989-411380 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Commit 7a8630be880e ("mm/damon/sysfs: support DAMOS watermarks") on -mm tree which introduced by a patch[1] titled mm-damon-sysfs-support-damos-watermarks.patch allows out-of-bound access to damon_sysfs_wmark_metric_strs[] array due to wrong bound check. This commit fixes the wrong bound check. The issue has found by Coverity report for linux-next. [1] https://www.ozlabs.org/~akpm/mmotm/broken-out/mm-damon-sysfs-support-damos-watermarks.patch Addresses-Coverity: ("Out-of-bounds read") Fixes: 7a8630be880e ("mm/damon/sysfs: support DAMOS watermarks") Signed-off-by: SeongJae Park --- mm/damon/sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c index 32a9d21c0db5..fda2506c676f 100644 --- a/mm/damon/sysfs.c +++ b/mm/damon/sysfs.c @@ -266,7 +266,7 @@ static ssize_t metric_store(struct kobject *kobj, struct kobj_attribute *attr, struct damon_sysfs_watermarks, kobj); enum damos_wmark_metric metric; - for (metric = 0; metric <= NR_DAMOS_WMARK_METRICS; metric++) { + for (metric = 0; metric < NR_DAMOS_WMARK_METRICS; metric++) { if (sysfs_streq(buf, damon_sysfs_wmark_metric_strs[metric])) { watermarks->metric = metric; return count;