From patchwork Wed Mar 2 21:36:36 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gaston Gonzalez X-Patchwork-Id: 12766829 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 50DB1C433EF for ; Wed, 2 Mar 2022 21:41:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AINsofxDAjqLnvSNPI4MtwuKtDvKTp3MFssZ9vXLQEc=; b=od3vR2bD2WcEGl 4w453VOCTIF5eUVvgI3kT0WMMgtaXphlm4zye4+HtOXeDvmZ7l2DNOWOUJrmytM9AiaJ87b2Rryxw iRTKdg2I/67I31aSCNLqjHjeon52IoRozSSksVJ7lMD9sgkMU7lv3GbN4SVYiCmKRARGKcR4y7FOS h5+LLZOsberPwdZwGLuIxPbIxV6xfEWMUUqEmWGUYgzb+06OHHweyxOVzvCsYt0Q2SqYxH0ZyI2i1 l5mVMrE7oL/XeHtx3fXFGkFvBuS/s2+3LdLApKd8+IvqxgvGPvftM29+1LY4G5p1N4OrpBP/0DI8F yIITkn7c1qtWCZSNzQHQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nPWhE-004NyN-BN; Wed, 02 Mar 2022 21:39:47 +0000 Received: from mail-oo1-xc32.google.com ([2607:f8b0:4864:20::c32]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nPWfX-004NLQ-79; Wed, 02 Mar 2022 21:38:00 +0000 Received: by mail-oo1-xc32.google.com with SMTP id d134-20020a4a528c000000b00319244f4b04so3509743oob.8; Wed, 02 Mar 2022 13:37:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=39y1JmWcKgDkVIZCA/4u9cM4DjLQrzKHYaevJAooNPE=; b=AH8ueK28p6pMJytSWAUsygXRasrNFt/rufhA7WrD4agv/SPSDMBsKBsat3+QsLGRnb YO3NZ+23JUKmEtoHWVVvpgsHzGwlXNVY9QKT3YcKungAI8rzTTRZwNiQ8dJp0uraiPjP ju4w02XAxGa2QphVfNC6s4if/sLwX2Gt8JJi1x3/XRB4kOo3eWraIiKmEiVjQTPG2BgP qrKwBFH+DBG0rGDXj8COcM90liOClnUDWQMFGfUn3iibJDd4uUicxYSSfNzhyaqFu5x7 P9f9bcyybZmqS1ktvLZh3DXxZiezJsSVEPnOO6o0PmRnNoc7Pe8sWvSKNVA8mrNEE1Aa 9gOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=39y1JmWcKgDkVIZCA/4u9cM4DjLQrzKHYaevJAooNPE=; b=YE9Tsxxx/6NYt1thFnNZBB1DMIhvSS0N7xdfon7t4sa/LrAthpbjg+gmMueY93asCm TvpZTKQF3T5wwgibnDoKa46pH3HNiM4kpqdRgxXpv7F1Slt7oljc9sUCj0lgPz0IGJKD 3FRnmHPYz7h40Wicudqx/Yb3WYgZlYJEoMSVcWHdueIPdaBwwmYVtkEew6POltSSBjwj JkLnQBzOMFQ//zCWSEFRKN965JdxMnU5CqecA2iL9Bv3dcxYEzGOkDGwqj0VC32tUbYB aRFE9bpW6v6mwyemShw3FGfJjZ86LLKlU/KpPRbkLe7lu4F9daZzy6CnDlzSvrE2AJRM HvOA== X-Gm-Message-State: AOAM5303oN7j7lVdOto4spcVab7ZQ2Yh3jcLLoTHzxCl7D+VFExs1KeW yylv655Un96WANtb0Vxv6e4= X-Google-Smtp-Source: ABdhPJx5YFHmvUhcSIDSxDbWRjt7BMPVnB2sQ0swaLBzOkzp5cyI6uZkDS1I0+Dwcr/asDsfWTk3GQ== X-Received: by 2002:a05:6870:a2d0:b0:d9:ae66:b8e2 with SMTP id w16-20020a056870a2d000b000d9ae66b8e2mr1240660oak.7.1646257077997; Wed, 02 Mar 2022 13:37:57 -0800 (PST) Received: from localhost.localdomain ([181.23.87.56]) by smtp.gmail.com with ESMTPSA id s12-20020a0568302a8c00b005b010d92dadsm69132otu.69.2022.03.02.13.37.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Mar 2022 13:37:57 -0800 (PST) From: Gaston Gonzalez To: linux-staging@lists.linux.dev Cc: gregkh@linuxfoundation.org, nsaenz@kernel.org, stefan.wahren@i2se.com, ojaswin98@gmail.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, gascoar@gmail.com Subject: [PATCH 1/2] staging: vchiq_arm: make vchiq_platform_get_arm_state() static Date: Wed, 2 Mar 2022 18:36:36 -0300 Message-Id: <216ad30d674b80e0051ecc233ac26ddb1d3e0e75.1646255044.git.gascoar@gmail.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: References: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220302_133759_301209_3F88137C X-CRM114-Status: UNSURE ( 9.55 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Fix "no previous prototype" W=1 warning by making the function vchiq_platform_get_arm_state() static. While at it, realign the function declaration in one line and reposition the asterisk symbol to fulfill the 'foo *bar' syntax. Signed-off-by: Gaston Gonzalez --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c index 54ab6208ddae..f0bfacfdea80 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c @@ -593,8 +593,7 @@ vchiq_platform_init_state(struct vchiq_state *state) return 0; } -struct vchiq_arm_state* -vchiq_platform_get_arm_state(struct vchiq_state *state) +static struct vchiq_arm_state *vchiq_platform_get_arm_state(struct vchiq_state *state) { struct vchiq_2835_state *platform_state; From patchwork Wed Mar 2 21:36:38 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gaston Gonzalez X-Patchwork-Id: 12766830 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C82E3C433EF for ; Wed, 2 Mar 2022 21:43:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Kwd25Zsk4Fyvw27WwYRVTdQknhepp2mhj9isoiaYnZ0=; b=qvSgkZyE8YYNOl o7UYNMlt8b01fyiU0dqNUmO6eB/vRRciL8mQi+X89pVvo3NvGiTcp/ikX5fOSr+AaG7DLVh47uc6n /g0LlSGWxrrSlSI0SoQp8MtGE+6AFSXFbcdtq4LdaBKEzEl5Bh7eAuUT9EhqzfA3pA/zqbQev+FGq sWNVVNpa6h7Xl0CWXc7+kfMNx6b6z1einPYr2NLPPPpbK1Nqz9wOQ/elHS/fpMNP077Hp1gYczV6M dJpfP00JIYH8tjGXXq9TGybNayRoa/FKN3VB9BI8J1DnwQx6ZMuyUcjfuZUsn2XY28HEFHjTm8TA6 RtZR6tfNj+vdqTnnq8Tg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nPWjZ-004OlG-CO; Wed, 02 Mar 2022 21:42:11 +0000 Received: from mail-oo1-xc2b.google.com ([2607:f8b0:4864:20::c2b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nPWgA-004NaB-2d; Wed, 02 Mar 2022 21:38:39 +0000 Received: by mail-oo1-xc2b.google.com with SMTP id k13-20020a4a948d000000b003172f2f6bdfso3531531ooi.1; Wed, 02 Mar 2022 13:38:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wAluUivNSRI0mrtPJNKUEXcouPOkO+X3IXT465oBrOw=; b=ACoMsJ2Mn/SOG3Ze7RxKSgj5WSgeDliONFFe/Zacv8MMyTD+5zX1YRwy8BT2NSTWOv vWrDxXwWKD16SLaDbAvoKwM+He8s8J930uuTlPJ5LIdaXe7Ne7x8jW4nv7tohThlKf4g ylsLgmIqgkoJ1LbJ6Gj1NS91PpCGn9pewcS1Rs1qkQf24pLPpcpq137W0ae3sBDu2FX0 Vo4nbzalqW8o0gE2L94prKFRD61N2KwfgYKo2iiKPq7gky7ITNT3sHKESacetDMcSGgU vgLwyhSnDu3DLR0IHrBUehjE3hvpo2hRDZ4ZsiWi9H/ss86zr5FNvnaqQ9nXQkjF0cgw 8Wig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wAluUivNSRI0mrtPJNKUEXcouPOkO+X3IXT465oBrOw=; b=PYUHS66Rhlg33ZbEXNB3/blCvGSdn7d5+xRiRxN5MrNo5+avDu/4hCdmkX6UB45RRg EW9mIjLG/3fQ3qGdB6t7pQO/JRtv9kYwMi25Q/46jnI2HITdptb16vFHQkmOzEst14jO Ki18EqDj6pIy2aUBSzoBprsgL1em5Eso98hVsvXQeWt1yANLv0eOpKoC8rvBzxyo0XsQ mPv6T9mo3QAFDj+SjxBE6ZWpNAwkNJjbTReQHHAi+7y6drg8KRIo7nKB+fC13K9TkfN+ qVMAqFWoj3QxhjPemo67bkZEyYS80QjspGsfxA0mGnzzlOowZ/AeAixNIubhJtGK23Fa 2y3A== X-Gm-Message-State: AOAM533P/HnnP+T/hTjV1d1fak6ddqj8d4lB8tmmNCOUdkIO7MHoGj3A TunHTIK9VzXjaaZRIMuD4cs= X-Google-Smtp-Source: ABdhPJyXeYXONnVXkUqChLuC1mmm3Ye7mTwg0kIZZfs3SJeTlobZacBugYfKSzTmJSUI2rOxPJD0og== X-Received: by 2002:a05:6870:54ce:b0:d6:efb6:5fe1 with SMTP id g14-20020a05687054ce00b000d6efb65fe1mr1577880oan.25.1646257117221; Wed, 02 Mar 2022 13:38:37 -0800 (PST) Received: from localhost.localdomain ([181.23.87.56]) by smtp.gmail.com with ESMTPSA id s12-20020a0568302a8c00b005b010d92dadsm69132otu.69.2022.03.02.13.38.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Mar 2022 13:38:36 -0800 (PST) From: Gaston Gonzalez To: linux-staging@lists.linux.dev Cc: gregkh@linuxfoundation.org, nsaenz@kernel.org, stefan.wahren@i2se.com, ojaswin98@gmail.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, gascoar@gmail.com Subject: [PATCH 2/2] staging: vchiq_arm: add prototype of function vchiq_platform_init() Date: Wed, 2 Mar 2022 18:36:38 -0300 Message-Id: X-Mailer: git-send-email 2.35.1 In-Reply-To: References: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220302_133838_159505_BBA6D31B X-CRM114-Status: UNSURE ( 9.71 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Fix "no previous prototype" W=1 warning by adding the prototype of the function vchiq_platform_init(). Note: vchiq_platform_init() is only called once in vchiq_probe(), so presumably should be static function. However, making the function static breaks the build. Signed-off-by: Gaston Gonzalez --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.h b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.h index 2aa46b119a46..d72edaf7e5e9 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.h +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.h @@ -122,6 +122,8 @@ vchiq_instance_get_trace(struct vchiq_instance *instance); extern void vchiq_instance_set_trace(struct vchiq_instance *instance, int trace); +int vchiq_platform_init(struct platform_device *pdev, struct vchiq_state *state); + #if IS_ENABLED(CONFIG_VCHIQ_CDEV) extern void