From patchwork Thu Mar 3 02:43:34 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jia-Ju Bai X-Patchwork-Id: 12766977 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1A96CC433EF for ; Thu, 3 Mar 2022 02:45:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject:Cc:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=WdcRO1eQxQ2fQX0uFUnMi3oIS9YIuNQV2QEkIGQL3sU=; b=jh3NYI2WGeOZxk GOBuMNgBFFPtq5xE6SJ8CeAPfueOGiEKpwq47PLW2I1IHioAyyEebiG8Zr7NmK8RElY2uvZ+TJohl y5uyk4dJSXl4kqutQZIuX8NeeNoUCDJBbX9WLHko24TerUxaX5ACjgOB1BMzsm6bzT9tTRiWDfsA7 TUV6cEfk/NUuc4xEfhlfjR9CLplwudz45EcIAZ1JQ0K/VDoCba7OyIwLOtDBy8nCmSeOtSkZgc9KK tzxP7h0HfBRi1OxL4T6qDNo+FEdRn13aS6c4LMZB5BHy9+3HWlyKF50kq1U8+8/2wzRldLkY96EXN 7IE1CICNTfpIBgL368GQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nPbRa-0052XC-SY; Thu, 03 Mar 2022 02:43:55 +0000 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nPbRW-0052WK-S1 for linux-arm-kernel@lists.infradead.org; Thu, 03 Mar 2022 02:43:52 +0000 Received: by mail-wm1-x329.google.com with SMTP id i66so2303581wma.5 for ; Wed, 02 Mar 2022 18:43:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id; bh=X4lL1PvOagfTI9D2Cq0N1Z99LjMee5r39OHywdd0uu8=; b=Qw9e3RXwingIRwGEOQG1r7xPywiwHiyTC2+iiblBghPVdrEE6vs1HXQ4OVuavFolk9 hw33KZbgyJo+G1wgw46v2VhQzteuHiXcnS9PJ/gPUe3oigd9DTKS1fx8PXpE+opGQ3NB xryT5B6EjLgCNBiRIbN30YmQpMJR+G38zxaHd7PKRSWi3pKEk7dL+mjiTpWET2P6F+G+ JmFksjC48cfv22Ap1DjX7ED4xq8nrRS7o1Pq5pda0H3/baQ+Wq6w3ASxWA1imAe4hsGu 7meFP3SDA0ea1RvurF6flgsVV1mHVIUm1ejivgQ9zNHiK4NO9mSrLcP8CIeMn36cZyk8 +Zng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=X4lL1PvOagfTI9D2Cq0N1Z99LjMee5r39OHywdd0uu8=; b=yF2jZ7GJ4f3JT/C+txp4ytkZZKRW3e0l1IqVwxoHQj5ZdEz1F3M3QL2AFJzGAMqq1+ 45MZezXf/J9Oah4pxmm9b3bkjz6/ZiF7ujdKGZw4P/vWEEODemN3uVhRqZFQCMzYexts p5uZMZ3iGaFjlzEjUFnvCM+Z20plADKsUp+Q0OF7OBA7zcpQZwjvr93E8NZ9FGRzWAEo yDQ6KncKcA2MryC21irkxow7OlAx4ihJRFfPdjAvuJNsvV/lS3fqwhw3GJudft7HDrU2 htohVKVXnkRv7XUiksOA3jdMYM2krmRCHP3xM1G/O5UJZJctz5CgWm1lyUkRXyaPaJ0E bnyg== X-Gm-Message-State: AOAM531f1e1WgTuj9uXeS8aavefywWb4SpU6qwe37664IpegpFW3BqYM FnQgH5KOmvQe2PjWHeR8t/o= X-Google-Smtp-Source: ABdhPJxoj+S2W0yqu83WsZhNy6k07kS+Sq8CCCc5eOJevVcQneDb1UEN4cL4PZw8yE5BR8c4sdxIbQ== X-Received: by 2002:a05:600c:4182:b0:381:42:ac91 with SMTP id p2-20020a05600c418200b003810042ac91mr2055013wmh.116.1646275428817; Wed, 02 Mar 2022 18:43:48 -0800 (PST) Received: from localhost.localdomain ([64.64.123.48]) by smtp.gmail.com with ESMTPSA id f22-20020a1cc916000000b00380d3e49e89sm649222wmb.22.2022.03.02.18.43.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Mar 2022 18:43:48 -0800 (PST) From: Jia-Ju Bai To: vkoul@kernel.org, michal.simek@xilinx.com, m.tretter@pengutronix.de, yukuai3@huawei.com, lars@metafoo.de, libaokun1@huawei.com Cc: dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jia-Ju Bai Subject: [PATCH] dma: xilinx: check the return value of dma_set_mask() in zynqmp_dma_probe() Date: Wed, 2 Mar 2022 18:43:34 -0800 Message-Id: <20220303024334.813-1-baijiaju1990@gmail.com> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220302_184350_929787_95396B8C X-CRM114-Status: GOOD ( 11.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The function dma_set_mask() in zynqmp_dma_probe() can fail, so its return value should be checked. Fixes: b0cc417c1637 ("dmaengine: Add Xilinx zynqmp dma engine driver support") Reported-by: TOTE Robot Signed-off-by: Jia-Ju Bai --- drivers/dma/xilinx/zynqmp_dma.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/dma/xilinx/zynqmp_dma.c b/drivers/dma/xilinx/zynqmp_dma.c index 7aa63b652027..963fb1de93af 100644 --- a/drivers/dma/xilinx/zynqmp_dma.c +++ b/drivers/dma/xilinx/zynqmp_dma.c @@ -1050,7 +1050,8 @@ static int zynqmp_dma_probe(struct platform_device *pdev) zdev->dev = &pdev->dev; INIT_LIST_HEAD(&zdev->common.channels); - dma_set_mask(&pdev->dev, DMA_BIT_MASK(44)); + if (dma_set_mask(&pdev->dev, DMA_BIT_MASK(44))) + return -EIO; dma_cap_set(DMA_MEMCPY, zdev->common.cap_mask); p = &zdev->common;