From patchwork Fri Mar 4 11:52:55 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ani Sinha X-Patchwork-Id: 12769022 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5571FC433EF for ; Fri, 4 Mar 2022 11:58:08 +0000 (UTC) Received: from localhost ([::1]:49650 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nQ6ZT-0006OJ-7P for qemu-devel@archiver.kernel.org; Fri, 04 Mar 2022 06:58:07 -0500 Received: from eggs.gnu.org ([209.51.188.92]:33132) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nQ6Ux-0006t0-LS for qemu-devel@nongnu.org; Fri, 04 Mar 2022 06:53:28 -0500 Received: from [2607:f8b0:4864:20::632] (port=41837 helo=mail-pl1-x632.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nQ6Uw-0005Nl-A1 for qemu-devel@nongnu.org; Fri, 04 Mar 2022 06:53:27 -0500 Received: by mail-pl1-x632.google.com with SMTP id z2so7519996plg.8 for ; Fri, 04 Mar 2022 03:53:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anisinha-ca.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=untwttg2h9MUzs6wtedAKndtsuh/tYZaw3CDKZL3ZkM=; b=y13iFTqDCatdTUdF+XvDYh1UK9pfV+FQM3QtuXniHjN4pn1U55j6eooXeIHVvmnCPh OETKZBvRfitwJ4a+tiCOnK2qTaaA4eUbHIzkyNu3HjrAB+tWljfALf/ICqyqPehTl0wb l2nfiNelK4qxcmnl7n7P0gyVisj7OOTm7NeMx0UW7wGecZsxzpbWNHxSsOckToycdh/5 5vqHpDE/IXybg0lwkXWw4fbnTHo+WCiKqT1rFDuk6zdazACJWzyaDQ0F5COwy0MhhMZ5 294tMh0M84wRXDcGq8BPCpQK5KVLNSRY3GU79OFCdUjdLVAbd0+rga7upPfh8/JPRUVe lICQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=untwttg2h9MUzs6wtedAKndtsuh/tYZaw3CDKZL3ZkM=; b=nNIUvaCc5c7Z3TChHBg4X/dnQ0WlDnrzY7DlfV/KvIz6f2Mba8hZ8HgAJ4BIFOAb6c Z5x5056dGXVSXHts/Gb9c7xy2c5GzPMHC7jitI1hGBMltrKXF/OpQ5axNzgUY/GCRDm0 s/kng4pbqjt3EanG+IKnw6WEkv+SE0b72bTxmSF5Lhs+FhKBaE+eEjpVJGE4hfT9NcHd KOMnhvLpIwUlsGQ1UTPh0HkuKnf/98IffreE8Su+0MgSS627kGVQsfLhERseoF8s9Jus twhdMmlsKDoILRwpltkWQVzMVpexiBeG8VeRn+oTzhK3AIG8LjZiSlvzvI9ls+BbqOLF 6aFg== X-Gm-Message-State: AOAM530x+yE85WWoPojnQo7Yv15Wo4fab64uZTe6uXQYcNBgvLccCHa5 oe6+4kArMomgjhqgikja0uNYD+bXn20gNA== X-Google-Smtp-Source: ABdhPJzPQGxFnQTnY9GMhg3o5emmo3dDEoM6QQ3aggN8FBnIBker3+Wkl+5isDZhSN50NANEn4cwtA== X-Received: by 2002:a17:902:6acb:b0:150:c60:294a with SMTP id i11-20020a1709026acb00b001500c60294amr41129779plt.71.1646394804460; Fri, 04 Mar 2022 03:53:24 -0800 (PST) Received: from anisinha-lenovo.ba.nuagenetworks.net ([115.96.152.50]) by smtp.googlemail.com with ESMTPSA id s7-20020a056a00178700b004e1a15e7928sm6334878pfg.145.2022.03.04.03.53.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Mar 2022 03:53:24 -0800 (PST) From: Ani Sinha To: qemu-devel@nongnu.org, "Michael S. Tsirkin" , Igor Mammedov , Ani Sinha Subject: [PATCH v5 1/3] tests/acpi: i386: allow FACP acpi table changes Date: Fri, 4 Mar 2022 17:22:55 +0530 Message-Id: <20220304115257.1816983-2-ani@anisinha.ca> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220304115257.1816983-1-ani@anisinha.ca> References: <20220304115257.1816983-1-ani@anisinha.ca> MIME-Version: 1.0 X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::632 (failed) Received-SPF: none client-ip=2607:f8b0:4864:20::632; envelope-from=ani@anisinha.ca; helo=mail-pl1-x632.google.com X-Spam_score_int: -4 X-Spam_score: -0.5 X-Spam_bar: / X-Spam_report: (-0.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: liavalb@gmail.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" From: Liav Albani The FACP table is going to be changed for x86/q35 machines. To be sure the following changes are not breaking any QEMU test this change follows step 2 from the bios-tables-test.c guide on changes that affect ACPI tables. Signed-off-by: Liav Albani Acked-by: Ani Sinha --- tests/qtest/bios-tables-test-allowed-diff.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h index dfb8523c8b..7570e39369 100644 --- a/tests/qtest/bios-tables-test-allowed-diff.h +++ b/tests/qtest/bios-tables-test-allowed-diff.h @@ -1 +1,5 @@ /* List of comma-separated changed AML files to ignore */ +"tests/data/acpi/q35/FACP", +"tests/data/acpi/q35/FACP.nosmm", +"tests/data/acpi/q35/FACP.slic", +"tests/data/acpi/q35/FACP.xapic", From patchwork Fri Mar 4 11:52:56 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ani Sinha X-Patchwork-Id: 12769020 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0BDF8C433F5 for ; Fri, 4 Mar 2022 11:55:08 +0000 (UTC) Received: from localhost ([::1]:41138 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nQ6WZ-0000b6-6s for qemu-devel@archiver.kernel.org; Fri, 04 Mar 2022 06:55:07 -0500 Received: from eggs.gnu.org ([209.51.188.92]:33156) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nQ6V3-0006ul-LQ for qemu-devel@nongnu.org; Fri, 04 Mar 2022 06:53:34 -0500 Received: from [2607:f8b0:4864:20::62f] (port=38871 helo=mail-pl1-x62f.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nQ6V2-0005OV-2c for qemu-devel@nongnu.org; Fri, 04 Mar 2022 06:53:33 -0500 Received: by mail-pl1-x62f.google.com with SMTP id t19so3969379plr.5 for ; Fri, 04 Mar 2022 03:53:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anisinha-ca.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=clOeteuA8EZcrtppgT5FyAaJW8k+p99dHASEHpY1SMA=; b=v8nKGLs5dl07vH48jbGjmIviHEE4L8WeHpZY55kmmF187kCdwb1otM8aAGHaAki9IU 2yZ1d5S8n+SZNPg8UuEjIh8z8wAHpoGeXZKcX1cAV8fMiEqoAlHklTzB9t5CAxMLJLXm lznHoR08dbCa/cZ7xmgMzCL5kK0kH0NwYrqztjf5Y1kV+g/su/4xhqLKj4JHR9u9Nlzb 03DbGHb7xCp6N7AvHYqcCnrtr/JdnaqeM4f3rWm5933W9zRhAeKjfkRp2Ey0MVxb/K9W iPcnkseOBXhVCEaPBHNtHjPXTms1ecdzvpLbqX5nngduklTUAM5EZyucylr7Ziu5jRqd jP9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=clOeteuA8EZcrtppgT5FyAaJW8k+p99dHASEHpY1SMA=; b=pDlwRlf2Vl2RvAxMURZgWbmzeewCOgD16Dqg8CkRY6VQ6pnf+httnbIfx6CIlUCBsV 81hpm+eaNaAYxcEYntU4KpllPIHxqTGFOtkplegPlZgv57tbqMqc5gCKLIaa1Aq+uth8 n057zQfdyW3axyVCd4ufVUmg4CtWFPV30MiYB7t+EPF0lJhQoSe3RS/HsH+UHGBCh+8N XwsbYpUp1HOUhr2mL74H+IUXcnkCfV2d2e7h/3AoixH8lctlz+xzt3FS62+9TCrVh48W 19MB5+Uye86NktpIqXT9BlVB9IG9T/TwxdKS0L+qwR9dbZjtcxjCVmurqBOX0IpypebS /wcg== X-Gm-Message-State: AOAM533e1sRM6Yt1/EZV+VgPxK0ukbAf6vzg39BdLpZE/rv6+ZPJmwQI 9uPpwrrw11sUUcn45TiShWLhvym02RsI6w== X-Google-Smtp-Source: ABdhPJw9NMO5cfSg3oMnjhYgNPcPAjcoDuvszmmJmhEf9Scsg6xqj4OMlcrpiU021UQKWxd/e12okg== X-Received: by 2002:a17:90a:c6:b0:1bc:c0be:4696 with SMTP id v6-20020a17090a00c600b001bcc0be4696mr10290247pjd.7.1646394809475; Fri, 04 Mar 2022 03:53:29 -0800 (PST) Received: from anisinha-lenovo.ba.nuagenetworks.net ([115.96.152.50]) by smtp.googlemail.com with ESMTPSA id s7-20020a056a00178700b004e1a15e7928sm6334878pfg.145.2022.03.04.03.53.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Mar 2022 03:53:29 -0800 (PST) From: Ani Sinha To: qemu-devel@nongnu.org, "Michael S. Tsirkin" , Igor Mammedov , Ani Sinha , Marcel Apfelbaum , Paolo Bonzini , Richard Henderson , Eduardo Habkost Subject: [PATCH v5 2/3] hw/acpi: add indication for i8042 in IA-PC boot flags of the FADT table Date: Fri, 4 Mar 2022 17:22:56 +0530 Message-Id: <20220304115257.1816983-3-ani@anisinha.ca> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220304115257.1816983-1-ani@anisinha.ca> References: <20220304115257.1816983-1-ani@anisinha.ca> MIME-Version: 1.0 X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::62f (failed) Received-SPF: none client-ip=2607:f8b0:4864:20::62f; envelope-from=ani@anisinha.ca; helo=mail-pl1-x62f.google.com X-Spam_score_int: -4 X-Spam_score: -0.5 X-Spam_bar: / X-Spam_report: (-0.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: liavalb@gmail.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" From: Liav Albani This can allow the guest OS to determine more easily if i8042 controller is present in the system or not, so it doesn't need to do probing of the controller, but just initialize it immediately, before enumerating the ACPI AML namespace. This change only applies to the x86/q35 machine type, as it uses FACP ACPI table with revision higher than 1, which should implement at least ACPI 2.0 features within the table, hence it can also set the IA-PC boot flags register according to the ACPI 2.0 specification. Signed-off-by: Liav Albani Signed-off-by: Ani Sinha --- hw/acpi/aml-build.c | 8 +++++++- hw/i386/acpi-build.c | 8 ++++++++ include/hw/acpi/acpi-defs.h | 1 + include/hw/input/i8042.h | 6 ++++++ 4 files changed, 22 insertions(+), 1 deletion(-) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index 8966e16320..1773cf55f1 100644 --- a/hw/acpi/aml-build.c +++ b/hw/acpi/aml-build.c @@ -2152,7 +2152,13 @@ void build_fadt(GArray *tbl, BIOSLinker *linker, const AcpiFadtData *f, build_append_int_noprefix(tbl, 0, 1); /* DAY_ALRM */ build_append_int_noprefix(tbl, 0, 1); /* MON_ALRM */ build_append_int_noprefix(tbl, f->rtc_century, 1); /* CENTURY */ - build_append_int_noprefix(tbl, 0, 2); /* IAPC_BOOT_ARCH */ + /* IAPC_BOOT_ARCH */ + if (f->rev == 1) { + build_append_int_noprefix(tbl, 0, 2); + } else { + /* since ACPI v2.0 */ + build_append_int_noprefix(tbl, f->iapc_boot_arch, 2); + } build_append_int_noprefix(tbl, 0, 1); /* Reserved */ build_append_int_noprefix(tbl, f->flags, 4); /* Flags */ diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index ebd47aa26f..28ca75fb50 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386/acpi-build.c @@ -38,6 +38,7 @@ #include "hw/nvram/fw_cfg.h" #include "hw/acpi/bios-linker-loader.h" #include "hw/isa/isa.h" +#include "hw/input/i8042.h" #include "hw/block/fdc.h" #include "hw/acpi/memory_hotplug.h" #include "sysemu/tpm.h" @@ -192,6 +193,13 @@ static void init_common_fadt_data(MachineState *ms, Object *o, .address = object_property_get_uint(o, ACPI_PM_PROP_GPE0_BLK, NULL) }, }; + + /* + * ACPI v2, Table 5-10 - Fixed ACPI Description Table Boot Architecture + * Flags, bit offset 1 - 8042. + */ + fadt.iapc_boot_arch = i8042_present() ? 0x1 << 1 : 0x0; + *data = fadt; } diff --git a/include/hw/acpi/acpi-defs.h b/include/hw/acpi/acpi-defs.h index c97e8633ad..2b42e4192b 100644 --- a/include/hw/acpi/acpi-defs.h +++ b/include/hw/acpi/acpi-defs.h @@ -77,6 +77,7 @@ typedef struct AcpiFadtData { uint16_t plvl2_lat; /* P_LVL2_LAT */ uint16_t plvl3_lat; /* P_LVL3_LAT */ uint16_t arm_boot_arch; /* ARM_BOOT_ARCH */ + uint16_t iapc_boot_arch; /* IAPC_BOOT_ARCH */ uint8_t minor_ver; /* FADT Minor Version */ /* diff --git a/include/hw/input/i8042.h b/include/hw/input/i8042.h index 1d90432dae..c739f30be8 100644 --- a/include/hw/input/i8042.h +++ b/include/hw/input/i8042.h @@ -23,4 +23,10 @@ void i8042_mm_init(qemu_irq kbd_irq, qemu_irq mouse_irq, void i8042_isa_mouse_fake_event(ISAKBDState *isa); void i8042_setup_a20_line(ISADevice *dev, qemu_irq a20_out); +static inline bool i8042_present(void) +{ + bool amb = false; + return object_resolve_path_type("", TYPE_I8042, &amb) || amb; +} + #endif /* HW_INPUT_I8042_H */ From patchwork Fri Mar 4 11:52:57 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ani Sinha X-Patchwork-Id: 12769021 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 380DDC433F5 for ; Fri, 4 Mar 2022 11:56:33 +0000 (UTC) Received: from localhost ([::1]:46656 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nQ6Xw-0004Oh-CH for qemu-devel@archiver.kernel.org; Fri, 04 Mar 2022 06:56:32 -0500 Received: from eggs.gnu.org ([209.51.188.92]:33170) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nQ6V7-0006vW-21 for qemu-devel@nongnu.org; Fri, 04 Mar 2022 06:53:37 -0500 Received: from [2607:f8b0:4864:20::102a] (port=43529 helo=mail-pj1-x102a.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nQ6V5-0005Os-IL for qemu-devel@nongnu.org; Fri, 04 Mar 2022 06:53:36 -0500 Received: by mail-pj1-x102a.google.com with SMTP id z12-20020a17090ad78c00b001bf022b69d6so6631441pju.2 for ; Fri, 04 Mar 2022 03:53:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anisinha-ca.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mt6B7mT4/5OJ0gJ2i6HNdOP8FrYBdmtR2VW9Nn/GzUA=; b=Nd/oCUcwZ5qaxkHSx1YJLzKgglFj3ntUJKt7bNPNPgrrssnEj2lazauPOLzLa4Vwpi 4dlt6Zaimuc05xJ/0KhMqimacPNQlaOMwBocdAnGxh+nUxIpPfmAD044+sfXP/vF4IZV MSF+7TOiK8gfnyS5ACdh7G4QWkbXgKB57wEVmffD8ozXIb1tuxg4iPb8vuhSrm1vZSed 8zTvB2LRotd6TcEBJdHdeYzwFXwtuzSt+pxnPcPRoDR4LMX59g4Vnm2ur+mpwKW+OtAm xXzS3MAkWu1hGVkBckkfV0WyzqRFh20GQhsGdJc7bjKRoNR3+6EVmYeWpuWxr8alAaHa QGsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mt6B7mT4/5OJ0gJ2i6HNdOP8FrYBdmtR2VW9Nn/GzUA=; b=te5qG8qkmsUGHSkAEdiwL2u9VgDDzcA+j9qmeQuVOo9isUZhCyOkbtGmJxxwy2rDLV knSngC95sgExrb29SixHKhUMWKEpVfFO5nQ0V4lsH6j8Ky3rmcvWBLG7L3K4MbzO2unX 37a6I5Qp7DgpDtu6Pz0uahBV08JH+HHMM0ThzXfR8guGGYApoLb5bSAvo9ZcH3ZitTHT /MDAFin5GReRt6Ifz1AzmOO4++yJXmBf5y3unVLLUeBRpCFErzanbCQrAbeK5vnmo3T7 Gg8rukCij2yg+Wg24gd3RBYnMc1qnXcAH8V8DbS4wwiQEamLbeRzVqGIKq3J9tlFo9d2 xJYQ== X-Gm-Message-State: AOAM530lmUhNpahK1vVywe8vEWnQhs3IbjGvcxtKxVb+fnBuf7XNBYhi AoQuP/ckFK3wJ0pdMTk8/3+huuJ8ES/gbQ== X-Google-Smtp-Source: ABdhPJxkzF5Id2TVa7TXQxv4u//ApElWpgFBxxiY3zrt2kegu2kHvO2j0GwuMpSepZicniyQ1QRgpw== X-Received: by 2002:a17:90a:7385:b0:1b9:6492:c107 with SMTP id j5-20020a17090a738500b001b96492c107mr10186517pjg.103.1646394813563; Fri, 04 Mar 2022 03:53:33 -0800 (PST) Received: from anisinha-lenovo.ba.nuagenetworks.net ([115.96.152.50]) by smtp.googlemail.com with ESMTPSA id s7-20020a056a00178700b004e1a15e7928sm6334878pfg.145.2022.03.04.03.53.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Mar 2022 03:53:33 -0800 (PST) From: Ani Sinha To: qemu-devel@nongnu.org, "Michael S. Tsirkin" , Igor Mammedov , Ani Sinha Subject: [PATCH v5 3/3] tests/acpi: i386: update FACP table differences Date: Fri, 4 Mar 2022 17:22:57 +0530 Message-Id: <20220304115257.1816983-4-ani@anisinha.ca> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220304115257.1816983-1-ani@anisinha.ca> References: <20220304115257.1816983-1-ani@anisinha.ca> MIME-Version: 1.0 X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::102a (failed) Received-SPF: none client-ip=2607:f8b0:4864:20::102a; envelope-from=ani@anisinha.ca; helo=mail-pj1-x102a.google.com X-Spam_score_int: -4 X-Spam_score: -0.5 X-Spam_bar: / X-Spam_report: (-0.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: liavalb@gmail.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" From: Liav Albani After changing the IAPC boot flags register to indicate support of i8042 in the machine chipset to help the guest OS to determine its existence "faster", we need to have the updated FACP ACPI binary images in tree. The ASL changes introduced are shown by the following diff: @@ -42,35 +42,35 @@ [059h 0089 1] PM1 Control Block Length : 02 [05Ah 0090 1] PM2 Control Block Length : 00 [05Bh 0091 1] PM Timer Block Length : 04 [05Ch 0092 1] GPE0 Block Length : 10 [05Dh 0093 1] GPE1 Block Length : 00 [05Eh 0094 1] GPE1 Base Offset : 00 [05Fh 0095 1] _CST Support : 00 [060h 0096 2] C2 Latency : 0FFF [062h 0098 2] C3 Latency : 0FFF [064h 0100 2] CPU Cache Size : 0000 [066h 0102 2] Cache Flush Stride : 0000 [068h 0104 1] Duty Cycle Offset : 00 [069h 0105 1] Duty Cycle Width : 00 [06Ah 0106 1] RTC Day Alarm Index : 00 [06Bh 0107 1] RTC Month Alarm Index : 00 [06Ch 0108 1] RTC Century Index : 32 -[06Dh 0109 2] Boot Flags (decoded below) : 0000 +[06Dh 0109 2] Boot Flags (decoded below) : 0002 Legacy Devices Supported (V2) : 0 - 8042 Present on ports 60/64 (V2) : 0 + 8042 Present on ports 60/64 (V2) : 1 VGA Not Present (V4) : 0 MSI Not Supported (V4) : 0 PCIe ASPM Not Supported (V4) : 0 CMOS RTC Not Present (V5) : 0 [06Fh 0111 1] Reserved : 00 [070h 0112 4] Flags (decoded below) : 000084A5 WBINVD instruction is operational (V1) : 1 WBINVD flushes all caches (V1) : 0 All CPUs support C1 (V1) : 1 C2 works on MP system (V1) : 0 Control Method Power Button (V1) : 0 Control Method Sleep Button (V1) : 1 RTC wake not in fixed reg space (V1) : 0 RTC can wake system from S4 (V1) : 1 32-bit PM Timer (V1) : 0 Docking Supported (V1) : 0 Signed-off-by: Liav Albani Acked-by: Ani Sinha --- tests/data/acpi/q35/FACP | Bin 244 -> 244 bytes tests/data/acpi/q35/FACP.nosmm | Bin 244 -> 244 bytes tests/data/acpi/q35/FACP.slic | Bin 244 -> 244 bytes tests/data/acpi/q35/FACP.xapic | Bin 244 -> 244 bytes tests/qtest/bios-tables-test-allowed-diff.h | 4 ---- 5 files changed, 4 deletions(-) diff --git a/tests/data/acpi/q35/FACP b/tests/data/acpi/q35/FACP index f6a864cc863c7763f6c09d3814ad184a658fa0a0..a8f6a8961109d01059aceef9f1869cde09a2f10c 100644 GIT binary patch delta 23 ecmeyu_=S