From patchwork Sat Mar 5 09:31:20 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jia-Ju Bai X-Patchwork-Id: 12770298 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8EBB6C433F5 for ; Sat, 5 Mar 2022 09:33:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject:Cc:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=5jQRSNKaT9jsmPDSGuQG2wmJ+4b+P3C/laW96VlQyKU=; b=Oekh6fQsci2SpT ng4unpxiishNRYUesU01M/Q04VFi5cRHSBfwau5CPuOkAoyM4iTNzkC1nSiPlZkKsbGcdQh5/gPvB mUg5NxwM5D3oK4R/z6Wl23Scwi6+C4aLKRxyjHGsYwlEO8FzhgBTDu+hjj0ps4Ofpi4vhfPTpLmV0 ZZB1abZyx7kVtioQDunCeybBgv7mbILVuXyzW+AX3YiOZscEbUs8HutKtLYeZc4u3WWbL8expmE6i eKkLgQPFLhNSu3aow9vNaqefwfcPwOvE7SSQ/H/VAlueBOI7dcPKTSpHTHZNsKrth3uvbX7GHs3Sl Yv0mB28iBVmI+nfUQDIQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nQQlN-00D3Ol-AA; Sat, 05 Mar 2022 09:31:45 +0000 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nQQlK-00D3OB-Ne for linux-arm-kernel@lists.infradead.org; Sat, 05 Mar 2022 09:31:44 +0000 Received: by mail-wr1-x42e.google.com with SMTP id r10so15987453wrp.3 for ; Sat, 05 Mar 2022 01:31:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id; bh=vaa9FvdTpNZqd2d6Oc0OE/r/3v+vyBiqAeaP9xPqhtk=; b=PLt55TC8ooVxjZu9AvFK2v1j+G96W0UgGdDzbdJRgr574mn+3ocI/XWPIag0brCkqh qPKm0QIt2TIZqgFcKeMnuhntUPRKpS5dZXt2P/ybJzgaFM3WFhMOBNSm1H1Oi0b9XJDF f8+5CFiiULzuSpnjgXgR5NP5Xi9GxHuvqjaZBjCP7tBAedD4HS4DYlLNWtyLtQ6Z04L7 ELg6kfnDOF1ZBI8P3DS0pfJ7j34kYRtCyP/ydIQ4gXJMWl1O5IW7xlnX4Uao70I7k6BF aCfjLCg7QrTHDTup7nIziH6xieH+cwjwAfGe/iBwusKIArVJJrWFOBrK4np5aAIIHyrM 0lCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=vaa9FvdTpNZqd2d6Oc0OE/r/3v+vyBiqAeaP9xPqhtk=; b=VBHCAvbzB5hkHsseMNVWVEmRuJJdnZU8zjA0G7jHO4dSgTkIAK2LoMSRy5PAWgLXeL GFyLieaj3YVgoOVguFegkTuRASaMS8D+hvCfYxjIRs3crViYQ2hkhM5DsbARiSiWPYfu yGJUtdpsSPIZMR5dFcYvbVfgXJ4TK3LgMFqjYyCGf3tqnwb954gf5AtEnEWeNQflVwI2 MMwOCncsJAGjl4g3ss0KqbXYHBWqg8aF8RhLnbXzzhy8V2KYOXsvSo/cUk8ZHnlZvjRe Ynn8wLiaO8CWNKyDIMfb8FJ3WkokZQeVBAVU/a/OrErh2YIR+tnAXEv6lD/d7Kafwv1o bVOg== X-Gm-Message-State: AOAM5337sBio4qLnq9cw6Sifz/IMfdxpM/ebsREFPd3mMb3fffaBU77w 723+ii/q/NowIQzmBJAGq/A= X-Google-Smtp-Source: ABdhPJy/tC4m3vdDhR0KEM6zPir0uboL2kBiAzK6ABjxHV5vi4YaMGIV0n45OnWHEnCDxV2XvT9hEQ== X-Received: by 2002:a05:6000:137a:b0:1f1:d6ec:7b69 with SMTP id q26-20020a056000137a00b001f1d6ec7b69mr1837889wrz.78.1646472701182; Sat, 05 Mar 2022 01:31:41 -0800 (PST) Received: from localhost.localdomain ([64.64.123.48]) by smtp.gmail.com with ESMTPSA id r15-20020a05600c35cf00b003808165fbc2sm7909863wmq.25.2022.03.05.01.31.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Mar 2022 01:31:40 -0800 (PST) From: Jia-Ju Bai To: vkoul@kernel.org, michal.simek@xilinx.com, m.tretter@pengutronix.de, lars@metafoo.de, libaokun1@huawei.com, yukuai3@huawei.com Cc: dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jia-Ju Bai Subject: [PATCH v2] dma: xilinx: check the return value of dma_set_mask() in zynqmp_dma_probe() Date: Sat, 5 Mar 2022 01:31:20 -0800 Message-Id: <20220305093120.28999-1-baijiaju1990@gmail.com> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220305_013142_829583_14CA7301 X-CRM114-Status: GOOD ( 12.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The function dma_set_mask() in zynqmp_dma_probe() can fail, so its return value should be checked. Fixes: b0cc417c1637 ("dmaengine: Add Xilinx zynqmp dma engine driver support") Reported-by: TOTE Robot Signed-off-by: Jia-Ju Bai Reviewed-by: Michael Tretter --- v2: * Print an error message and forward the return value of dma_set_mask(). Thank Michael for good advice. --- drivers/dma/xilinx/zynqmp_dma.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/dma/xilinx/zynqmp_dma.c b/drivers/dma/xilinx/zynqmp_dma.c index 7aa63b652027..2791e9c6a4ea 100644 --- a/drivers/dma/xilinx/zynqmp_dma.c +++ b/drivers/dma/xilinx/zynqmp_dma.c @@ -1050,7 +1050,10 @@ static int zynqmp_dma_probe(struct platform_device *pdev) zdev->dev = &pdev->dev; INIT_LIST_HEAD(&zdev->common.channels); - dma_set_mask(&pdev->dev, DMA_BIT_MASK(44)); + ret = dma_set_mask(&pdev->dev, DMA_BIT_MASK(44)); + if (ret) + return dev_err_probe(&pdev->dev, ret, "No usable DMA available\n"); + dma_cap_set(DMA_MEMCPY, zdev->common.cap_mask); p = &zdev->common;