From patchwork Tue Mar 8 13:06:40 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe Branchereau X-Patchwork-Id: 12773773 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AF9C9C433EF for ; Tue, 8 Mar 2022 13:06:59 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DEEE710E6D5; Tue, 8 Mar 2022 13:06:57 +0000 (UTC) Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by gabe.freedesktop.org (Postfix) with ESMTPS id BBB1110E6D5 for ; Tue, 8 Mar 2022 13:06:56 +0000 (UTC) Received: by mail-wr1-x432.google.com with SMTP id i8so28425372wrr.8 for ; Tue, 08 Mar 2022 05:06:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kABsl8nFckhHhGe72PdD4LYbj+x9bM4gFy/8W5Qq+ys=; b=CeNbbGSqvyasiw3aKrSWBu+ByZiMzoj0xOyu80rURPjmzSMameTQ41nAx19Gr6BGiR rvKB/ErAp7bOr0L8qDoNIYLdOEAUvQYU12U8QGY6McoiVecBP+DzZa+EojmmHKqfFfaF d570wz2HMUlTB6yeNWfcoM1b3TwXxa5eEphl++JfoJN7aUPEW3OIeG0yJmV/w+gSBthD msrX+vxehJVzaksBhyXTJcNdefwZzeGDEmoyRcJtaNiXOajJpX7bZKpn/+OMF6rPTOpD 28Dj0H0G9MuiLhBVAylZLydjWTQ941HvZ9fNALjvr7IbBKx3Jz/pkIxYmaNVXRtncmSi onoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kABsl8nFckhHhGe72PdD4LYbj+x9bM4gFy/8W5Qq+ys=; b=PtIZNLiDVVn9KAMn4Z0KLaPzKGMGmG3WyKfIsqLG/oyNzlprid8Q7Hfvt366j6UYEJ VP3FeRiLGUDfo3tLQe1iTHjcXvjMtL5ntBTZF2PrJfjyRWwie2RSPDKLa4iezSbvo+SA Dx7tXjC10D/UHhGgyFdwK7PMhpaI2f0CNxiZyYQ9xzKtUhgQIoKbA9OaeRXKR2yKanii suhR6dsi7Ds+eyegP8yBNo/Z2pQW2sf4OOPUfO19YtrpmAwegXQVjD4KsDgIaYMXSyrl ZmfKhI/LxJTVWpfsbNfaWrHIjejD6tJuprYVSnac85kXW5SpPta6+VLyVvaVNgxYYAPU 63Dg== X-Gm-Message-State: AOAM533O/i/4hYtpf59ccSHxQlwP31Rbqw6ZXaaxbA1ND9ybBcpxNxbJ HP1wGoVnNf9bQuhDm5ZP8Es= X-Google-Smtp-Source: ABdhPJyQTsNDK4VxbuzBVRU4ohQD6eHLp6t1D2aSuYrQhwZeUjA0ogkAH1NuopdvNJL7wd5OE6WbLw== X-Received: by 2002:a5d:5850:0:b0:1f0:2d5b:dc35 with SMTP id i16-20020a5d5850000000b001f02d5bdc35mr12095290wrf.344.1646744815193; Tue, 08 Mar 2022 05:06:55 -0800 (PST) Received: from monk.home ([2a01:cb10:430:ec00:4737:d56e:186b:af1]) by smtp.gmail.com with ESMTPSA id p15-20020a05600c1d8f00b003899d50f01csm2129159wms.6.2022.03.08.05.06.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Mar 2022 05:06:54 -0800 (PST) From: Christophe Branchereau To: Paul Cercueil , David Airlie , Daniel Vetter , Thierry Reding , Sam Ravnborg , Rob Herring Subject: [PATCH v2 1/4] drm/ingenic : add ingenic_drm_bridge_atomic_enable Date: Tue, 8 Mar 2022 14:06:40 +0100 Message-Id: <20220308130643.260683-2-cbranchereau@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220308130643.260683-1-cbranchereau@gmail.com> References: <20220308130643.260683-1-cbranchereau@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" This allows the CRTC to be enabled after panels have slept out, and before their display is turned on, solving a graphical bug on the newvision nv3502c Signed-off-by: Christophe Branchereau --- drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c index dcf44cb00821..51512f41263e 100644 --- a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c +++ b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c @@ -226,6 +226,18 @@ static int ingenic_drm_update_pixclk(struct notifier_block *nb, } } +static void ingenic_drm_bridge_atomic_enable(struct drm_bridge *bridge, + struct drm_bridge_state *old_bridge_state) +{ + struct ingenic_drm *priv = drm_device_get_priv(bridge->dev); + + regmap_write(priv->map, JZ_REG_LCD_STATE, 0); + + regmap_update_bits(priv->map, JZ_REG_LCD_CTRL, + JZ_LCD_CTRL_ENABLE | JZ_LCD_CTRL_DISABLE, + JZ_LCD_CTRL_ENABLE); +} + static void ingenic_drm_crtc_atomic_enable(struct drm_crtc *crtc, struct drm_atomic_state *state) { @@ -237,17 +249,11 @@ static void ingenic_drm_crtc_atomic_enable(struct drm_crtc *crtc, if (WARN_ON(IS_ERR(priv_state))) return; - regmap_write(priv->map, JZ_REG_LCD_STATE, 0); - /* Set addresses of our DMA descriptor chains */ next_id = priv_state->use_palette ? HWDESC_PALETTE : 0; regmap_write(priv->map, JZ_REG_LCD_DA0, dma_hwdesc_addr(priv, next_id)); regmap_write(priv->map, JZ_REG_LCD_DA1, dma_hwdesc_addr(priv, 1)); - regmap_update_bits(priv->map, JZ_REG_LCD_CTRL, - JZ_LCD_CTRL_ENABLE | JZ_LCD_CTRL_DISABLE, - JZ_LCD_CTRL_ENABLE); - drm_crtc_vblank_on(crtc); } @@ -968,6 +974,7 @@ static const struct drm_encoder_helper_funcs ingenic_drm_encoder_helper_funcs = static const struct drm_bridge_funcs ingenic_drm_bridge_funcs = { .attach = ingenic_drm_bridge_attach, + .atomic_enable = ingenic_drm_bridge_atomic_enable, .atomic_check = ingenic_drm_bridge_atomic_check, .atomic_reset = drm_atomic_helper_bridge_reset, .atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state, From patchwork Tue Mar 8 13:06:41 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe Branchereau X-Patchwork-Id: 12773774 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B8C3DC433F5 for ; Tue, 8 Mar 2022 13:07:02 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 83B1110E6F0; Tue, 8 Mar 2022 13:07:00 +0000 (UTC) Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8E9C110E6F0 for ; Tue, 8 Mar 2022 13:06:58 +0000 (UTC) Received: by mail-wr1-x430.google.com with SMTP id q14so12884850wrc.4 for ; Tue, 08 Mar 2022 05:06:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=yT/jLMavWzWNWxYJnbgv8x0+7fWNMgopN7NzlMWbIS4=; b=XPbT52w0uzrr8Ok+bC8w8kgPPYtYYdQwpUW7e5oyH4XgSLUWgRnbr2iob5dgTAKl9o 6NZk6dLQCyl1c2I+FzgU8M8lsCcclhh7FgL8lyY/Gu//aM3EHZqwfec4NmFT+3ygwrf1 QKRMM/HxjWb94GkqRJYu1Ur/kN4ddFwtv7VWpbxfJS7nihgVd0i/MIdfW4WcIgLMHAFX b/7ATHj8zLOf8h2MnJXRnxHDNqnhqMUsBS98zfXNwD9cYW761PVW4gWIXwKHSlYgzW/2 I0aMuvDwLJoPITFfrXp8boj0aRleoiPrvTKWVtkgmQ5AmyrsKqAPDnm56Ss3nQ2KVAzl fGdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=yT/jLMavWzWNWxYJnbgv8x0+7fWNMgopN7NzlMWbIS4=; b=BXYOS+yym/2x9ffK7yECzPeVVzowAqQh+9iq2V6FVHu8HdqPhx96VUwp9kZ2p81fCj hqoWsst20o1eZ2+lcZf0nQ2qeKmLhDLjzAtKdxm8zwxXxN5xgWjfsmFCJMt46AFuK+ML Q7OWiIMLuElJR9OmeYZf8GNHu8KK++6PUgQOsRymDerUQ1bXgqRAnPn23/Ci3iwDhZ6S L1BACzP66ealFXuszb0totTnfGsBE+K6SbmZ3EKFpFKszsP1c0dRrWVE6STN5t7Bzive 5bKtN0DhwDyROxDh8URjhS90K50Z7bmB+grQcJk304lS4HhUHLN/RnmnDzu6uB7CVgED +ydQ== X-Gm-Message-State: AOAM533Nid4pAJeU31TQIw/hHuCQoWQFEP391nvtwoSjW65hc3jLsQDI Eu6e2OnCk3G9GjiSX+z53UU= X-Google-Smtp-Source: ABdhPJwgJWWuXM1CTl8oNejWj59U2IcCVbFdKz8V2LmHQ5GoUnWDHCnlGwDXmgl4RZnB/6viCa2GDQ== X-Received: by 2002:a5d:6d0c:0:b0:1fc:71c0:4a1b with SMTP id e12-20020a5d6d0c000000b001fc71c04a1bmr5043205wrq.186.1646744817043; Tue, 08 Mar 2022 05:06:57 -0800 (PST) Received: from monk.home ([2a01:cb10:430:ec00:4737:d56e:186b:af1]) by smtp.gmail.com with ESMTPSA id p15-20020a05600c1d8f00b003899d50f01csm2129159wms.6.2022.03.08.05.06.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Mar 2022 05:06:56 -0800 (PST) From: Christophe Branchereau To: Paul Cercueil , David Airlie , Daniel Vetter , Thierry Reding , Sam Ravnborg , Rob Herring Subject: [PATCH v2 2/4] drm/panel: Add panel driver for NewVision NV3052C based LCDs Date: Tue, 8 Mar 2022 14:06:41 +0100 Message-Id: <20220308130643.260683-3-cbranchereau@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220308130643.260683-1-cbranchereau@gmail.com> References: <20220308130643.260683-1-cbranchereau@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" This driver supports the NewVision NV3052C based LCDs. Right now, it only supports the LeadTek LTK035C5444T 2.4" 640x480 TFT LCD panel, which can be found in the Anbernic RG-350M handheld console. Signed-off-by: Christophe Branchereau --- drivers/gpu/drm/panel/Kconfig | 9 + drivers/gpu/drm/panel/Makefile | 1 + .../gpu/drm/panel/panel-newvision-nv3052c.c | 497 ++++++++++++++++++ 3 files changed, 507 insertions(+) create mode 100644 drivers/gpu/drm/panel/panel-newvision-nv3052c.c diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig index bb2e47229c68..40084f709789 100644 --- a/drivers/gpu/drm/panel/Kconfig +++ b/drivers/gpu/drm/panel/Kconfig @@ -283,6 +283,15 @@ config DRM_PANEL_NEC_NL8048HL11 panel (found on the Zoom2/3/3630 SDP boards). To compile this driver as a module, choose M here. +config DRM_PANEL_NEWVISION_NV3052C + tristate "NewVision NV3052C RGB/SPI panel" + depends on OF && SPI + depends on BACKLIGHT_CLASS_DEVICE + select DRM_MIPI_DBI + help + Say Y here if you want to enable support for the panels built + around the NewVision NV3052C display controller. + config DRM_PANEL_NOVATEK_NT35510 tristate "Novatek NT35510 RGB panel driver" depends on OF diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile index 5740911f637c..42a7ab54234b 100644 --- a/drivers/gpu/drm/panel/Makefile +++ b/drivers/gpu/drm/panel/Makefile @@ -26,6 +26,7 @@ obj-$(CONFIG_DRM_PANEL_LEADTEK_LTK500HD1829) += panel-leadtek-ltk500hd1829.o obj-$(CONFIG_DRM_PANEL_LG_LB035Q02) += panel-lg-lb035q02.o obj-$(CONFIG_DRM_PANEL_LG_LG4573) += panel-lg-lg4573.o obj-$(CONFIG_DRM_PANEL_NEC_NL8048HL11) += panel-nec-nl8048hl11.o +obj-$(CONFIG_DRM_PANEL_NEWVISION_NV3052C) += panel-newvision-nv3052c.o obj-$(CONFIG_DRM_PANEL_NOVATEK_NT35510) += panel-novatek-nt35510.o obj-$(CONFIG_DRM_PANEL_NOVATEK_NT35560) += panel-novatek-nt35560.o obj-$(CONFIG_DRM_PANEL_NOVATEK_NT35950) += panel-novatek-nt35950.o diff --git a/drivers/gpu/drm/panel/panel-newvision-nv3052c.c b/drivers/gpu/drm/panel/panel-newvision-nv3052c.c new file mode 100644 index 000000000000..30ab7a9fc828 --- /dev/null +++ b/drivers/gpu/drm/panel/panel-newvision-nv3052c.c @@ -0,0 +1,497 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * NevVision NV3052C IPS LCD panel driver + * + * Copyright (C) 2020, Paul Cercueil + * Copyright (C) 2022, Christophe Branchereau + */ + +#include +#include +#include +#include +#include +#include +#include +#include + +#include