From patchwork Fri Jan 4 14:31:16 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nikolay Borisov X-Patchwork-Id: 10748397 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 324F41399 for ; Fri, 4 Jan 2019 14:31:20 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1FF73284B3 for ; Fri, 4 Jan 2019 14:31:20 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 135A5284BD; Fri, 4 Jan 2019 14:31:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A9034284B3 for ; Fri, 4 Jan 2019 14:31:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726529AbfADObT (ORCPT ); Fri, 4 Jan 2019 09:31:19 -0500 Received: from mx2.suse.de ([195.135.220.15]:47254 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726488AbfADObT (ORCPT ); Fri, 4 Jan 2019 09:31:19 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 05738AF1B; Fri, 4 Jan 2019 14:31:18 +0000 (UTC) From: Nikolay Borisov To: fstests@vger.kernel.org Cc: guaneryu@gmail.com, Nikolay Borisov Subject: [PATCH] Revert "common/config: create $RESULT_BASE before dumping kmemleak leaks" Date: Fri, 4 Jan 2019 16:31:16 +0200 Message-Id: <20190104143116.5698-1-nborisov@suse.com> X-Mailer: git-send-email 2.17.1 Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This commit tried to fix the brokennes of the kmemleak support but it inadvertently broke the creation of the RESULT_BASE directory which lead to problems creating check.time file. Turns out kmemleak support in xfstests has more problems and it needs to be majorly refactor and this commit doesn't really solve the problem. For the time being just revert to at least allow older configuration files, which have explicitly set RESULT_BASE to work. This reverts commit 7fc034868d5dce9aaf3517c9c2197221b9a772e4. Signed-off-by: Nikolay Borisov --- check | 7 +++++++ common/config | 5 ----- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/check b/check index e4d767375b57..77a06b00dbba 100755 --- a/check +++ b/check @@ -538,6 +538,13 @@ for section in $HOST_OPTIONS_SECTIONS; do fi fi + mkdir -p $RESULT_BASE + if [ ! -d $RESULT_BASE ]; then + echo "failed to create results directory $RESULT_BASE" + status=1 + exit + fi + if $OPTIONS_HAVE_SECTIONS; then echo "SECTION -- $section" fi diff --git a/common/config b/common/config index fb664cf0a967..5b48e1e7323b 100644 --- a/common/config +++ b/common/config @@ -663,11 +663,6 @@ get_next_config() { # set default RESULT_BASE if [ -z "$RESULT_BASE" ]; then export RESULT_BASE="$here/results/" - mkdir -p ${RESULT_BASE} - if [ ! -d ${RESULT_BASE} ]; then - echo "failed to create results directory $RESULT_BASE" - exit 1 - fi fi if [ "$FSTYP" == "tmpfs" ]; then