From patchwork Thu Mar 24 17:50:02 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Victor Toso X-Patchwork-Id: 12790939 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 24667C433F5 for ; Thu, 24 Mar 2022 17:54:09 +0000 (UTC) Received: from localhost ([::1]:46834 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nXRex-0005NT-VZ for qemu-devel@archiver.kernel.org; Thu, 24 Mar 2022 13:54:08 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53154) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXRcS-0002Us-4C for qemu-devel@nongnu.org; Thu, 24 Mar 2022 13:51:41 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:27723) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXRcP-0006Xb-2z for qemu-devel@nongnu.org; Thu, 24 Mar 2022 13:51:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648144287; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OG3SGzxUyg8w+R2DLS2Z3RhgRMZdmtAZAIXaL+Bstp4=; b=P+MWBXayISjhZF0qMJ2HVFIzFPC3/g37a6ovGohFfMK6ARB+QrL1iRRYnyRmbY/aDSMqdG CIpdMvotr1BeTKN4OrZInV7deLyvmAxNcuAEVV1gTfMuwLUbhauQRVomTEZWOupzep+M0G CMlt+pk4pHU65UrGoEsExv87HCsDZvU= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-60-9G8q8rvoO-u8tAdCc497CQ-1; Thu, 24 Mar 2022 13:50:19 -0400 X-MC-Unique: 9G8q8rvoO-u8tAdCc497CQ-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 489B880281D for ; Thu, 24 Mar 2022 17:50:19 +0000 (UTC) Received: from tapioca.redhat.com (unknown [10.40.195.110]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0C164417E47; Thu, 24 Mar 2022 17:50:17 +0000 (UTC) From: Victor Toso To: qemu-devel@nongnu.org Subject: [PATCH 01/14] qapi: BlockExportRemoveMode: move comments to TODO Date: Thu, 24 Mar 2022 18:50:02 +0100 Message-Id: <20220324175015.232794-2-victortoso@redhat.com> In-Reply-To: <20220324175015.232794-1-victortoso@redhat.com> References: <20220324175015.232794-1-victortoso@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=victortoso@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.133.124; envelope-from=victortoso@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , Eric Blake , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" @hide and @soft are potential additions which fits the TODO section perfectly. The main motivation is to avoid this whole block of comment entering the wrong section in the python parser. Signed-off-by: Victor Toso Reviewed-by: Markus Armbruster Reviewed-by: John Snow --- qapi/block-export.json | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/qapi/block-export.json b/qapi/block-export.json index f183522d0d..1e34927f85 100644 --- a/qapi/block-export.json +++ b/qapi/block-export.json @@ -219,13 +219,13 @@ # # @hard: Drop all connections immediately and remove export. # -# Potential additional modes to be added in the future: +# TODO: Potential additional modes to be added in the future: # -# hide: Just hide export from new clients, leave existing connections as is. -# Remove export after all clients are disconnected. +# hide: Just hide export from new clients, leave existing connections as is. +# Remove export after all clients are disconnected. # -# soft: Hide export from new clients, answer with ESHUTDOWN for all further -# requests from existing clients. +# soft: Hide export from new clients, answer with ESHUTDOWN for all further +# requests from existing clients. # # Since: 2.12 ## From patchwork Thu Mar 24 17:50:03 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Victor Toso X-Patchwork-Id: 12790955 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D89BDC433F5 for ; Thu, 24 Mar 2022 18:02:48 +0000 (UTC) Received: from localhost ([::1]:41602 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nXRnL-000437-QB for qemu-devel@archiver.kernel.org; Thu, 24 Mar 2022 14:02:47 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53448) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXRcx-0002hd-9D for qemu-devel@nongnu.org; Thu, 24 Mar 2022 13:52:03 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:35956) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXRcv-0006by-HO for qemu-devel@nongnu.org; Thu, 24 Mar 2022 13:52:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648144321; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4XqnZSjF8beLtYn4tBCCJD63qXkUy53jPXMYjSLurfs=; b=Wan12veOEX53EyqJ8fZd+28gVndVI17IQ39GHwpvAQ+701S/K3ASWCB9D3vOGeBM3eZwmo hhPqXVLdkPTh1DWT34N9/jQgcH6DlERl6X40eghyeaxeEakBSgDGWIVaLYkIbGys2LJa5Z s7RvF0AFduT7WxNwOJwNmbFJ1V5Cam0= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-287-pi9vJSfKP9Woc6WC77wsIg-1; Thu, 24 Mar 2022 13:50:21 -0400 X-MC-Unique: pi9vJSfKP9Woc6WC77wsIg-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E43FC85A5BE for ; Thu, 24 Mar 2022 17:50:20 +0000 (UTC) Received: from tapioca.redhat.com (unknown [10.40.195.110]) by smtp.corp.redhat.com (Postfix) with ESMTP id A8552400DC9; Thu, 24 Mar 2022 17:50:19 +0000 (UTC) From: Victor Toso To: qemu-devel@nongnu.org Subject: [PATCH 02/14] qapi: fix example of BLOCK_IMAGE_CORRUPTED event Date: Thu, 24 Mar 2022 18:50:03 +0100 Message-Id: <20220324175015.232794-3-victortoso@redhat.com> In-Reply-To: <20220324175015.232794-1-victortoso@redhat.com> References: <20220324175015.232794-1-victortoso@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=victortoso@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.129.124; envelope-from=victortoso@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , Eric Blake , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Fatal is not optional. Signed-off-by: Victor Toso --- qapi/block-core.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index e89f2dfb5b..585a9e020e 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -5008,7 +5008,7 @@ # <- { "event": "BLOCK_IMAGE_CORRUPTED", # "data": { "device": "ide0-hd0", "node-name": "node0", # "msg": "Prevented active L1 table overwrite", "offset": 196608, -# "size": 65536 }, +# "size": 65536, "fatal": false }, # "timestamp": { "seconds": 1378126126, "microseconds": 966463 } } # # Since: 1.7 From patchwork Thu Mar 24 17:50:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Victor Toso X-Patchwork-Id: 12790944 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 59480C433F5 for ; Thu, 24 Mar 2022 17:57:37 +0000 (UTC) Received: from localhost ([::1]:55366 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nXRiK-0002l4-H4 for qemu-devel@archiver.kernel.org; Thu, 24 Mar 2022 13:57:36 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53194) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXRcV-0002Vq-FL for qemu-devel@nongnu.org; Thu, 24 Mar 2022 13:51:41 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:45571) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXRcU-0006YK-6L for qemu-devel@nongnu.org; Thu, 24 Mar 2022 13:51:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648144293; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ddfITHt2XBGIrZKnv5oVGdrSZIq/OigF3Ff+nX6l2SY=; b=P3H4suFLioy8CcSI9Qmds4liw5T9uwMu5Vi5n9nF/yKg3BExM6OMTe8TXJvnlSeRZp96SC L2l2QKhoa57LbUsrHZr1JMluIHcuxnaqhmq6oWVDtWcq0TR7zR4zgldD41ok6c2b/99yiY omnjnItqqIqPvN0ApIQCZ0iOO6NtkMU= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-147-kdBrkOhGNXiS_QBp1GUWMQ-1; Thu, 24 Mar 2022 13:50:23 -0400 X-MC-Unique: kdBrkOhGNXiS_QBp1GUWMQ-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A2A7985A5BE for ; Thu, 24 Mar 2022 17:50:22 +0000 (UTC) Received: from tapioca.redhat.com (unknown [10.40.195.110]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4F9E1401E89; Thu, 24 Mar 2022 17:50:21 +0000 (UTC) From: Victor Toso To: qemu-devel@nongnu.org Subject: [PATCH 03/14] qapi: fix example of BLOCK_IO_ERROR event Date: Thu, 24 Mar 2022 18:50:04 +0100 Message-Id: <20220324175015.232794-4-victortoso@redhat.com> In-Reply-To: <20220324175015.232794-1-victortoso@redhat.com> References: <20220324175015.232794-1-victortoso@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=victortoso@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.133.124; envelope-from=victortoso@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , Eric Blake , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Reason is not optional. Signed-off-by: Victor Toso --- qapi/block-core.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index 585a9e020e..5b6c069dd9 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -5059,7 +5059,8 @@ # "data": { "device": "ide0-hd1", # "node-name": "#block212", # "operation": "write", -# "action": "stop" }, +# "action": "stop", +# "reason": "Driver requires too large request alignment" }, # "timestamp": { "seconds": 1265044230, "microseconds": 450486 } } # ## From patchwork Thu Mar 24 17:50:05 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Victor Toso X-Patchwork-Id: 12790940 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5B669C433EF for ; Thu, 24 Mar 2022 17:54:09 +0000 (UTC) Received: from localhost ([::1]:46828 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nXRey-0005NG-E8 for qemu-devel@archiver.kernel.org; Thu, 24 Mar 2022 13:54:08 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53212) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXRcX-0002Vw-Ia for qemu-devel@nongnu.org; Thu, 24 Mar 2022 13:51:43 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:55835) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXRcU-0006YM-9u for qemu-devel@nongnu.org; Thu, 24 Mar 2022 13:51:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648144293; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=x4z70FRKTarV3jQDHa1LDBZ8QN3de5hm5tiSw1Led2g=; b=IQh+nmW816ocUBzlGD2tOSyk+gBGmplr7wyoz/yUgGT+6xmG7Jc98gwRDiAUhgUfpVSt0d 2ZVjuHM4Xv82swxIiIwHfMgQjryaUru9Rcn9Xw7dgSzcde4uY/hgKdzqbDEPUe+LRY3lDq 2JoICxXI3INId5QIuIAjRRzOBGffees= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-55-1GR9MZqNNbCB_-2-mCXylA-1; Thu, 24 Mar 2022 13:50:24 -0400 X-MC-Unique: 1GR9MZqNNbCB_-2-mCXylA-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 34CB83C163E1 for ; Thu, 24 Mar 2022 17:50:24 +0000 (UTC) Received: from tapioca.redhat.com (unknown [10.40.195.110]) by smtp.corp.redhat.com (Postfix) with ESMTP id 10A1D401E89; Thu, 24 Mar 2022 17:50:22 +0000 (UTC) From: Victor Toso To: qemu-devel@nongnu.org Subject: [PATCH 04/14] qapi: fix example of BLOCK_JOB_PENDING event Date: Thu, 24 Mar 2022 18:50:05 +0100 Message-Id: <20220324175015.232794-5-victortoso@redhat.com> In-Reply-To: <20220324175015.232794-1-victortoso@redhat.com> References: <20220324175015.232794-1-victortoso@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=victortoso@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.133.124; envelope-from=victortoso@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , Eric Blake , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Event's name: BLOCK_JOB_WAITING -> BLOCK_JOB_PENDING * Argument device -> id Signed-off-by: Victor Toso Reviewed-by: John Snow Reviewed-by: Markus Armbruster --- qapi/block-core.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index 5b6c069dd9..ea96e1b009 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -5226,8 +5226,8 @@ # # Example: # -# <- { "event": "BLOCK_JOB_WAITING", -# "data": { "device": "drive0", "type": "mirror" }, +# <- { "event": "BLOCK_JOB_PENDING", +# "data": { "type": "mirror", "id": "backup_1" }, # "timestamp": { "seconds": 1265044230, "microseconds": 450486 } } # ## From patchwork Thu Mar 24 17:50:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Victor Toso X-Patchwork-Id: 12790942 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 646F8C433F5 for ; Thu, 24 Mar 2022 17:56:38 +0000 (UTC) Received: from localhost ([::1]:53166 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nXRhN-0001C3-Gj for qemu-devel@archiver.kernel.org; Thu, 24 Mar 2022 13:56:37 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53264) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXRcd-0002WM-1l for qemu-devel@nongnu.org; Thu, 24 Mar 2022 13:51:47 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:56628) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXRcX-0006Yl-GT for qemu-devel@nongnu.org; Thu, 24 Mar 2022 13:51:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648144296; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UsuJwRwnsXtlAuqG0zmjel4KOd+sv2ji9Hr8ZaXEtIM=; b=hWVlNf/VcQwSwbrRuun+w3K5jajYx7Evr0/A6GHlm1m7y/aqaX5boCdSqsRsQbVfa37ch1 HYVQ1K57yz88aUEE5odKMRWLHkdjyf4UlVkrgEXX7rGPH1NP1MYedmeeB1Vukfes/yzFJX /oZU/FgEW/FV4/p4K4eqU6KZPZW3EwY= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-517-wnsrti72PqySa__6qRVSoA-1; Thu, 24 Mar 2022 13:50:25 -0400 X-MC-Unique: wnsrti72PqySa__6qRVSoA-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8554E803D67 for ; Thu, 24 Mar 2022 17:50:25 +0000 (UTC) Received: from tapioca.redhat.com (unknown [10.40.195.110]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7EC20400DC9; Thu, 24 Mar 2022 17:50:24 +0000 (UTC) From: Victor Toso To: qemu-devel@nongnu.org Subject: [PATCH 05/14] qapi: fix example of DUMP_COMPLETED event Date: Thu, 24 Mar 2022 18:50:06 +0100 Message-Id: <20220324175015.232794-6-victortoso@redhat.com> In-Reply-To: <20220324175015.232794-1-victortoso@redhat.com> References: <20220324175015.232794-1-victortoso@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=victortoso@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.129.124; envelope-from=victortoso@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , Eric Blake , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Timestamp is not optional, let's add for completeness. * Add '<-' to signalize it is receiving the data * While at it, add extra space before "result" and "total" Signed-off-by: Victor Toso Reviewed-by: John Snow Reviewed-by: Markus Armbruster --- qapi/dump.json | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/qapi/dump.json b/qapi/dump.json index f7c4267e3f..d3ed79e8cd 100644 --- a/qapi/dump.json +++ b/qapi/dump.json @@ -161,9 +161,10 @@ # # Example: # -# { "event": "DUMP_COMPLETED", -# "data": {"result": {"total": 1090650112, "status": "completed", -# "completed": 1090650112} } } +# <- { "event": "DUMP_COMPLETED", +# "data": { "result": { "total": 1090650112, "status": "completed", +# "completed": 1090650112} }, +# "timestamp": { "seconds": 1265044230, "microseconds": 450486 } } # ## { 'event': 'DUMP_COMPLETED' , From patchwork Thu Mar 24 17:50:07 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Victor Toso X-Patchwork-Id: 12790953 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 97D03C433F5 for ; Thu, 24 Mar 2022 17:59:40 +0000 (UTC) Received: from localhost ([::1]:35772 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nXRkJ-0008TR-JN for qemu-devel@archiver.kernel.org; Thu, 24 Mar 2022 13:59:39 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53478) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXRcy-0002kS-GC for qemu-devel@nongnu.org; Thu, 24 Mar 2022 13:52:04 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:22919) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXRcw-0006cB-MG for qemu-devel@nongnu.org; Thu, 24 Mar 2022 13:52:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648144322; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AaCRxeJ7WpVdw6OO+lxAnd0XdJduR1VyS2aMpksYaQ8=; b=U0Vle0mPA7+47/huI/jmMh4O830OZHT43Y6Je1pEhemk4b9HVjAKRdnLCMCnJWCKLntOFL tlBrn49VngMsTzxBwJyOCZFlBTjlFnFQ2W0E73wJMrA51U+0FaAeuUeHxDNw/UEJldiaCA WiDMx9PRV2LmfgRIvs5b6r4vWAfxwaM= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-34-65K_5OR5PqKqHMea3B5Erw-1; Thu, 24 Mar 2022 13:50:27 -0400 X-MC-Unique: 65K_5OR5PqKqHMea3B5Erw-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EA8643C163E1 for ; Thu, 24 Mar 2022 17:50:26 +0000 (UTC) Received: from tapioca.redhat.com (unknown [10.40.195.110]) by smtp.corp.redhat.com (Postfix) with ESMTP id E517F401E89; Thu, 24 Mar 2022 17:50:25 +0000 (UTC) From: Victor Toso To: qemu-devel@nongnu.org Subject: [PATCH 06/14] qapi: fix example of MEMORY_DEVICE_SIZE_CHANGE event Date: Thu, 24 Mar 2022 18:50:07 +0100 Message-Id: <20220324175015.232794-7-victortoso@redhat.com> In-Reply-To: <20220324175015.232794-1-victortoso@redhat.com> References: <20220324175015.232794-1-victortoso@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=victortoso@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.129.124; envelope-from=victortoso@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , Eric Blake , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * qom-path is not optional Signed-off-by: Victor Toso --- qapi/machine.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/qapi/machine.json b/qapi/machine.json index 42fc68403d..9c460ec450 100644 --- a/qapi/machine.json +++ b/qapi/machine.json @@ -1356,7 +1356,8 @@ # Example: # # <- { "event": "MEMORY_DEVICE_SIZE_CHANGE", -# "data": { "id": "vm0", "size": 1073741824}, +# "data": { "id": "vm0", "size": 1073741824, +# "qom-path": "/machine/unattached/device[2]" }, # "timestamp": { "seconds": 1588168529, "microseconds": 201316 } } # ## From patchwork Thu Mar 24 17:50:08 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Victor Toso X-Patchwork-Id: 12790941 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B0364C433FE for ; Thu, 24 Mar 2022 17:54:09 +0000 (UTC) Received: from localhost ([::1]:46900 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nXRey-0005Q4-Pd for qemu-devel@archiver.kernel.org; Thu, 24 Mar 2022 13:54:08 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53306) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXRce-0002Wg-1m for qemu-devel@nongnu.org; Thu, 24 Mar 2022 13:51:48 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:48723) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXRcb-0006Yq-IO for qemu-devel@nongnu.org; Thu, 24 Mar 2022 13:51:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648144296; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UMMGot0Mx+flR+e3CFOvkdxix69Bs+PvLJ2jK2/GgnI=; b=KdBdQCRHmlpe+nOyp9nhPM8BJKgkupqy/0bKmp+XA1hJ8CAh4yoCcmqoWBfHcb+TcRPq3g 8NYMKDY33o2tunkSUWBh0zzjAHAKart8pH6TGVKSdcpjYeS1SunmYEu6TOm6UhhxKyqc+f 5xFtoG+o0x3O9qN5eGzel8lDqDesFhs= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-574-_itca7wJM3eLsiMoN1AsbA-1; Thu, 24 Mar 2022 13:50:28 -0400 X-MC-Unique: _itca7wJM3eLsiMoN1AsbA-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4B001802C16 for ; Thu, 24 Mar 2022 17:50:28 +0000 (UTC) Received: from tapioca.redhat.com (unknown [10.40.195.110]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4038A400DC9; Thu, 24 Mar 2022 17:50:27 +0000 (UTC) From: Victor Toso To: qemu-devel@nongnu.org Subject: [PATCH 07/14] qapi: fix example of UNPLUG_PRIMARY event Date: Thu, 24 Mar 2022 18:50:08 +0100 Message-Id: <20220324175015.232794-8-victortoso@redhat.com> In-Reply-To: <20220324175015.232794-1-victortoso@redhat.com> References: <20220324175015.232794-1-victortoso@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=victortoso@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.133.124; envelope-from=victortoso@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , Eric Blake , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Timestamp is not optional, let's add for completeness. * Add '<-' to signalize it is receiving the data * Break likes like most of examples do Signed-off-by: Victor Toso Reviewed-by: John Snow --- qapi/migration.json | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/qapi/migration.json b/qapi/migration.json index 18e2610e88..092a63354b 100644 --- a/qapi/migration.json +++ b/qapi/migration.json @@ -1736,7 +1736,9 @@ # Since: 4.2 # # Example: -# {"event": "UNPLUG_PRIMARY", "data": {"device-id": "hostdev0"} } +# <- { "event": "UNPLUG_PRIMARY", +# "data": { "device-id": "hostdev0" }, +# "timestamp": { "seconds": 1265044230, "microseconds": 450486 } } # ## { 'event': 'UNPLUG_PRIMARY', From patchwork Thu Mar 24 17:50:09 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Victor Toso X-Patchwork-Id: 12790956 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 664A8C433EF for ; Thu, 24 Mar 2022 18:03:14 +0000 (UTC) Received: from localhost ([::1]:43182 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nXRnl-00058P-DW for qemu-devel@archiver.kernel.org; Thu, 24 Mar 2022 14:03:13 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53304) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXRce-0002Wf-1h for qemu-devel@nongnu.org; Thu, 24 Mar 2022 13:51:48 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:37465) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXRcb-0006Yt-EW for qemu-devel@nongnu.org; Thu, 24 Mar 2022 13:51:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648144296; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7Qa/XQ3L39MElje1ju0/dyNy6pFCMHl0B/UCeXtBQqs=; b=XcPqZBT6J0tYoQl9fOLw9/3ndNFNImys1fst4bqkMt2r3oCTTimZ3gy7Ua1GjLcmtxpcx3 +pQS6lUsNqWV6XcIoPSrsNx2IgyAr2+qcLPCK2dLyWpm4ZzAyjQ0g5wneVJlp5m8pf/a0j ckb+78ww9cYpNxRhZqgJj8N7lowLDEg= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-631-P8_nny42PtikQlYDT9yZHQ-1; Thu, 24 Mar 2022 13:50:29 -0400 X-MC-Unique: P8_nny42PtikQlYDT9yZHQ-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 85E241066542 for ; Thu, 24 Mar 2022 17:50:29 +0000 (UTC) Received: from tapioca.redhat.com (unknown [10.40.195.110]) by smtp.corp.redhat.com (Postfix) with ESMTP id 958F4400DC9; Thu, 24 Mar 2022 17:50:28 +0000 (UTC) From: Victor Toso To: qemu-devel@nongnu.org Subject: [PATCH 08/14] qapi: fix example of FAILOVER_NEGOTIATED event Date: Thu, 24 Mar 2022 18:50:09 +0100 Message-Id: <20220324175015.232794-9-victortoso@redhat.com> In-Reply-To: <20220324175015.232794-1-victortoso@redhat.com> References: <20220324175015.232794-1-victortoso@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=victortoso@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.129.124; envelope-from=victortoso@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , Eric Blake , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Data is an object, not a string. It generates a qdict. * Timestamp is not optional, let's add for completeness. Signed-off-by: Victor Toso Reviewed-by: John Snow --- qapi/net.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/qapi/net.json b/qapi/net.json index 7fab2e7cd8..82c0d9e778 100644 --- a/qapi/net.json +++ b/qapi/net.json @@ -691,7 +691,8 @@ # Example: # # <- { "event": "FAILOVER_NEGOTIATED", -# "data": "net1" } +# "data": { "device-id": "net1" }, +# "timestamp": { "seconds": 1368697518, "microseconds": 326866 } } # ## { 'event': 'FAILOVER_NEGOTIATED', From patchwork Thu Mar 24 17:50:10 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Victor Toso X-Patchwork-Id: 12790943 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 354EEC433EF for ; Thu, 24 Mar 2022 17:57:32 +0000 (UTC) Received: from localhost ([::1]:55318 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nXRiF-0002i4-5Q for qemu-devel@archiver.kernel.org; Thu, 24 Mar 2022 13:57:31 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53268) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXRcd-0002WN-2J for qemu-devel@nongnu.org; Thu, 24 Mar 2022 13:51:47 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:41074) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXRcb-0006Yp-87 for qemu-devel@nongnu.org; Thu, 24 Mar 2022 13:51:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648144296; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NpwHrDqbMHjrkK2eP/o3gtH561K1xDGC5RDBzd0tZQ4=; b=C1uSRv1x1irPFiviFJvEo7Sgse3riyj8+AqXvi59vcUS3y0YAERg1F1DuC/0JUO5rnYjrv FG8dSkx5CLPS8MBs+igDqPCsVcx9nyxUk4pP5TotLlZVuUR8r9vWxmCoYYZU8YtpSBNmkE oUnhyx4YjL7RfquiRxQCpZyQnXe9Lmg= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-664-cG4D5pY3MSeGTjoh8GDytg-1; Thu, 24 Mar 2022 13:50:31 -0400 X-MC-Unique: cG4D5pY3MSeGTjoh8GDytg-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EC7C885A5BC for ; Thu, 24 Mar 2022 17:50:30 +0000 (UTC) Received: from tapioca.redhat.com (unknown [10.40.195.110]) by smtp.corp.redhat.com (Postfix) with ESMTP id E2987401E89; Thu, 24 Mar 2022 17:50:29 +0000 (UTC) From: Victor Toso To: qemu-devel@nongnu.org Subject: [PATCH 09/14] qapi: run-state examples: add missing member Date: Thu, 24 Mar 2022 18:50:10 +0100 Message-Id: <20220324175015.232794-10-victortoso@redhat.com> In-Reply-To: <20220324175015.232794-1-victortoso@redhat.com> References: <20220324175015.232794-1-victortoso@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=victortoso@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.133.124; envelope-from=victortoso@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , Eric Blake , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" As reason member in not optional. Signed-off-by: Victor Toso Reviewed-by: John Snow --- qapi/run-state.json | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/qapi/run-state.json b/qapi/run-state.json index 43d66d700f..1b9f64c9cd 100644 --- a/qapi/run-state.json +++ b/qapi/run-state.json @@ -150,7 +150,8 @@ # # Example: # -# <- { "event": "SHUTDOWN", "data": { "guest": true }, +# <- { "event": "SHUTDOWN", +# "data": { "guest": true, "reason": "guest-shutdown" }, # "timestamp": { "seconds": 1267040730, "microseconds": 682951 } } # ## @@ -188,7 +189,8 @@ # # Example: # -# <- { "event": "RESET", "data": { "guest": false }, +# <- { "event": "RESET", +# "data": { "guest": false, "reason": "guest-reset" }, # "timestamp": { "seconds": 1267041653, "microseconds": 9518 } } # ## From patchwork Thu Mar 24 17:50:11 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Victor Toso X-Patchwork-Id: 12790958 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4CFD7C433EF for ; Thu, 24 Mar 2022 18:07:02 +0000 (UTC) Received: from localhost ([::1]:49208 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nXRrR-0000wN-4o for qemu-devel@archiver.kernel.org; Thu, 24 Mar 2022 14:07:01 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53476) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXRcy-0002kM-Ff for qemu-devel@nongnu.org; Thu, 24 Mar 2022 13:52:04 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:29595) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXRcw-0006cD-MM for qemu-devel@nongnu.org; Thu, 24 Mar 2022 13:52:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648144322; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e3m4zHYkWvajuUHEz0pmOTJs4cvSTtxOJlXuYjo0qpo=; b=JBGBFH2P/A0r/NIdOnwUtziNEEbH+fGMpchDCRVvPLlj8otFo81JC2bEkFQ6+a/Era+jZk HBWgBWoW3NXbxB2OfWX2QeJd62PdmksIXL1rCM3U91oQJ5Afsvp/2hYUSGKiJ021RTas1G djmxAF9LVLqcRDwZ7b+ieL5pYjBbVwc= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-544-1nD7Cg9_MQSjdslyzKEFaA-1; Thu, 24 Mar 2022 13:50:32 -0400 X-MC-Unique: 1nD7Cg9_MQSjdslyzKEFaA-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 76A64380351E for ; Thu, 24 Mar 2022 17:50:32 +0000 (UTC) Received: from tapioca.redhat.com (unknown [10.40.195.110]) by smtp.corp.redhat.com (Postfix) with ESMTP id 58575400DC9; Thu, 24 Mar 2022 17:50:31 +0000 (UTC) From: Victor Toso To: qemu-devel@nongnu.org Subject: [PATCH 10/14] qapi: run-state examples: add missing timestamp Date: Thu, 24 Mar 2022 18:50:11 +0100 Message-Id: <20220324175015.232794-11-victortoso@redhat.com> In-Reply-To: <20220324175015.232794-1-victortoso@redhat.com> References: <20220324175015.232794-1-victortoso@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=victortoso@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.129.124; envelope-from=victortoso@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , Eric Blake , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Victor Toso Reviewed-by: John Snow --- qapi/run-state.json | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/qapi/run-state.json b/qapi/run-state.json index 1b9f64c9cd..f87b9378ac 100644 --- a/qapi/run-state.json +++ b/qapi/run-state.json @@ -426,7 +426,8 @@ # Example: # # <- { "event": "GUEST_PANICKED", -# "data": { "action": "pause" } } +# "data": { "action": "pause" }, +# "timestamp": { "seconds": 1267061043, "microseconds": 959568 } } # ## { 'event': 'GUEST_PANICKED', @@ -446,7 +447,8 @@ # Example: # # <- { "event": "GUEST_CRASHLOADED", -# "data": { "action": "run" } } +# "data": { "action": "run" }, +# "timestamp": { "seconds": 1267061043, "microseconds": 959568 } } # ## { 'event': 'GUEST_CRASHLOADED', From patchwork Thu Mar 24 17:50:12 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Victor Toso X-Patchwork-Id: 12790957 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C2C64C433F5 for ; Thu, 24 Mar 2022 18:03:16 +0000 (UTC) Received: from localhost ([::1]:43238 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nXRnn-0005AO-P8 for qemu-devel@archiver.kernel.org; Thu, 24 Mar 2022 14:03:15 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53474) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXRcy-0002kC-Db for qemu-devel@nongnu.org; Thu, 24 Mar 2022 13:52:04 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:56651) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXRcv-0006c5-Tu for qemu-devel@nongnu.org; Thu, 24 Mar 2022 13:52:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648144321; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8EQf/N3WUJ7yTrCZgvODhz+6TCeivAISmW1XfQVBEik=; b=EN3F1v2OXGktOn65I01T49MJu4TGXEN4y1A0VV9pAhegVTNTMZH7NpD97FXyKXwrtPZQd3 MGeJU2RfSjIs3qUd6j8FI+z5GTGE2BUj+hRcyJiR2WubhHw+rZZ0JU3mEkIy2C/Nfvyd6o Ss0hSnI54q/YP2xDI0e13W7xHqrAPW8= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-674-U3MMYSMCO6CJjLPVIY8nXQ-1; Thu, 24 Mar 2022 13:50:34 -0400 X-MC-Unique: U3MMYSMCO6CJjLPVIY8nXQ-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B2C8D3C163E4 for ; Thu, 24 Mar 2022 17:50:33 +0000 (UTC) Received: from tapioca.redhat.com (unknown [10.40.195.110]) by smtp.corp.redhat.com (Postfix) with ESMTP id C25EC417E45; Thu, 24 Mar 2022 17:50:32 +0000 (UTC) From: Victor Toso To: qemu-devel@nongnu.org Subject: [PATCH 11/14] qapi: fix example of MEMORY_FAILURE Date: Thu, 24 Mar 2022 18:50:12 +0100 Message-Id: <20220324175015.232794-12-victortoso@redhat.com> In-Reply-To: <20220324175015.232794-1-victortoso@redhat.com> References: <20220324175015.232794-1-victortoso@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=victortoso@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.129.124; envelope-from=victortoso@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , Eric Blake , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Minor issues found and fixed with the example: * The JSON object of EVENT was not closed * Missing timestamp * Flags are optional but if defined then all members should be include so we add "recursive" member. * Changed string from '' to "" in action-required member. Signed-off-by: Victor Toso Reviewed-by: John Snow --- qapi/run-state.json | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/qapi/run-state.json b/qapi/run-state.json index f87b9378ac..ee21decdec 100644 --- a/qapi/run-state.json +++ b/qapi/run-state.json @@ -571,7 +571,9 @@ # <- { "event": "MEMORY_FAILURE", # "data": { "recipient": "hypervisor", # "action": "fatal", -# "flags": { 'action-required': false } } +# "flags": { "action-required": false, +# "recursive": false } }, +# "timestamp": { "seconds": 1267061043, "microseconds": 959568 } } # ## { 'event': 'MEMORY_FAILURE', From patchwork Thu Mar 24 17:50:13 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Victor Toso X-Patchwork-Id: 12790950 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 816DEC433EF for ; Thu, 24 Mar 2022 17:59:08 +0000 (UTC) Received: from localhost ([::1]:33468 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nXRjn-0006v7-9u for qemu-devel@archiver.kernel.org; Thu, 24 Mar 2022 13:59:07 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53326) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXRcf-0002XV-QS for qemu-devel@nongnu.org; Thu, 24 Mar 2022 13:51:48 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:51808) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXRcd-0006Za-Bu for qemu-devel@nongnu.org; Thu, 24 Mar 2022 13:51:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648144302; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1WzZNYft3le1DBsbEK65sOITrawoJBjohcDhpJjrnL8=; b=XwnwCURWz/OPgAYOQi3BL5HFc3HlGWJxUqdHJhO4/UMVFZkUXHoR7J3PY1C+IcCbUY6xdI EmOwDJUfDR2PqnlBRlK24U32Exs9GLi8DobZOKqYcS8VaiIzDqi+pkckZLrn3Zw/ot4ODc rfp6riz0nAgPDfRlQdRtrgyrlOb4uqk= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-357-fI2WrmBmPTGFSdADXUtdcw-1; Thu, 24 Mar 2022 13:50:35 -0400 X-MC-Unique: fI2WrmBmPTGFSdADXUtdcw-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0633D801E80 for ; Thu, 24 Mar 2022 17:50:35 +0000 (UTC) Received: from tapioca.redhat.com (unknown [10.40.195.110]) by smtp.corp.redhat.com (Postfix) with ESMTP id 08EF4400DC9; Thu, 24 Mar 2022 17:50:33 +0000 (UTC) From: Victor Toso To: qemu-devel@nongnu.org Subject: [PATCH 12/14] qapi: ui examples: add missing websocket member Date: Thu, 24 Mar 2022 18:50:13 +0100 Message-Id: <20220324175015.232794-13-victortoso@redhat.com> In-Reply-To: <20220324175015.232794-1-victortoso@redhat.com> References: <20220324175015.232794-1-victortoso@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=victortoso@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.133.124; envelope-from=victortoso@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , Eric Blake , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" As the websocket is not optional in VncBasicInfo. Signed-off-by: Victor Toso Reviewed-by: John Snow --- qapi/ui.json | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/qapi/ui.json b/qapi/ui.json index 664da9e462..a810ed680c 100644 --- a/qapi/ui.json +++ b/qapi/ui.json @@ -710,10 +710,10 @@ # # <- { "event": "VNC_CONNECTED", # "data": { -# "server": { "auth": "sasl", "family": "ipv4", +# "server": { "auth": "sasl", "family": "ipv4", "websocket": false, # "service": "5901", "host": "0.0.0.0" }, # "client": { "family": "ipv4", "service": "58425", -# "host": "127.0.0.1" } }, +# "host": "127.0.0.1", "websocket": false } }, # "timestamp": { "seconds": 1262976601, "microseconds": 975795 } } # ## @@ -738,9 +738,9 @@ # # <- { "event": "VNC_INITIALIZED", # "data": { -# "server": { "auth": "sasl", "family": "ipv4", +# "server": { "auth": "sasl", "family": "ipv4", "websocket": false, # "service": "5901", "host": "0.0.0.0"}, -# "client": { "family": "ipv4", "service": "46089", +# "client": { "family": "ipv4", "service": "46089", "websocket": false, # "host": "127.0.0.1", "sasl_username": "luiz" } }, # "timestamp": { "seconds": 1263475302, "microseconds": 150772 } } # @@ -765,9 +765,9 @@ # # <- { "event": "VNC_DISCONNECTED", # "data": { -# "server": { "auth": "sasl", "family": "ipv4", +# "server": { "auth": "sasl", "family": "ipv4", "websocket": false, # "service": "5901", "host": "0.0.0.0" }, -# "client": { "family": "ipv4", "service": "58425", +# "client": { "family": "ipv4", "service": "58425", "websocket": false, # "host": "127.0.0.1", "sasl_username": "luiz" } }, # "timestamp": { "seconds": 1262976601, "microseconds": 975795 } } # From patchwork Thu Mar 24 17:50:14 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Victor Toso X-Patchwork-Id: 12790951 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 68650C433F5 for ; Thu, 24 Mar 2022 17:59:37 +0000 (UTC) Received: from localhost ([::1]:35578 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nXRkG-0008MB-Ge for qemu-devel@archiver.kernel.org; Thu, 24 Mar 2022 13:59:36 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53322) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXRce-0002XS-Tp for qemu-devel@nongnu.org; Thu, 24 Mar 2022 13:51:48 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:46723) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXRcd-0006ZU-51 for qemu-devel@nongnu.org; Thu, 24 Mar 2022 13:51:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648144302; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=f+wbxsYJB5dDYGRE/nr3UaNLxm0jHeTUELROzfvNCB0=; b=Sq9em1NuFOleLSjhqxnSjVFFnToqTnY7uiL/f4RfTMuBL4Bt05H9XIfsMAOeUSjwogXIOf 3lKOCT2hbZQEA/RRuQxHguQukyI6yKEVXR/mPefCoa2/N7h5yYcjmLWO5OWuFEY5bBUVGC WdEvg1s95Gx98pQRkM0v9LTVNHv3NKc= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-389-sLY8wuqRORKCusoG9UuwYw-1; Thu, 24 Mar 2022 13:50:36 -0400 X-MC-Unique: sLY8wuqRORKCusoG9UuwYw-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 927B48039D7 for ; Thu, 24 Mar 2022 17:50:36 +0000 (UTC) Received: from tapioca.redhat.com (unknown [10.40.195.110]) by smtp.corp.redhat.com (Postfix) with ESMTP id 50DC3401E89; Thu, 24 Mar 2022 17:50:35 +0000 (UTC) From: Victor Toso To: qemu-devel@nongnu.org Subject: [PATCH 13/14] qapi: fix example of ACPI_DEVICE_OST event Date: Thu, 24 Mar 2022 18:50:14 +0100 Message-Id: <20220324175015.232794-14-victortoso@redhat.com> In-Reply-To: <20220324175015.232794-1-victortoso@redhat.com> References: <20220324175015.232794-1-victortoso@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=victortoso@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.133.124; envelope-from=victortoso@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , Eric Blake , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Missing the timestamp * Missing the "info" object in the "data" member Signed-off-by: Victor Toso Reviewed-by: John Snow --- qapi/acpi.json | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/qapi/acpi.json b/qapi/acpi.json index 51f0d55db7..d148f6db9f 100644 --- a/qapi/acpi.json +++ b/qapi/acpi.json @@ -133,8 +133,9 @@ # Example: # # <- { "event": "ACPI_DEVICE_OST", -# "data": { "device": "d1", "slot": "0", -# "slot-type": "DIMM", "source": 1, "status": 0 } } +# "data": { "info": { "device": "d1", "slot": "0", +# "slot-type": "DIMM", "source": 1, "status": 0 } }, +# "timestamp": { "seconds": 1265044230, "microseconds": 450486 } } # ## { 'event': 'ACPI_DEVICE_OST', From patchwork Thu Mar 24 17:50:15 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Victor Toso X-Patchwork-Id: 12790945 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 17E6AC433EF for ; Thu, 24 Mar 2022 17:57:39 +0000 (UTC) Received: from localhost ([::1]:55486 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nXRiL-0002q9-Gs for qemu-devel@archiver.kernel.org; Thu, 24 Mar 2022 13:57:38 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53324) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXRcf-0002XU-34 for qemu-devel@nongnu.org; Thu, 24 Mar 2022 13:51:48 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:33219) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXRcd-0006Zg-Bl for qemu-devel@nongnu.org; Thu, 24 Mar 2022 13:51:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648144302; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hPo/eMCa+nbvp/EXalDw2NAMdcuJOEpQFJoCJ0kf/rw=; b=LWSyIvaiz18W4BEgYNfEXqkxUdplOkjB1eu+48xFkbVqkT+FC+yMDrItkf/OC/2LSE4G/6 lCTzjtfWx1J07HjUkiMPGRklmKaKLwIH8/Lwdjp5amEusvpld3mmITUZWyNdkAC1aPuyJ+ +2riQpxNzDjiH6F5iLpRJL4N4eh9ZIc= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-606-neKQBKg6OQajSTDjAmEnPA-1; Thu, 24 Mar 2022 13:50:38 -0400 X-MC-Unique: neKQBKg6OQajSTDjAmEnPA-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E2E5E801E80 for ; Thu, 24 Mar 2022 17:50:37 +0000 (UTC) Received: from tapioca.redhat.com (unknown [10.40.195.110]) by smtp.corp.redhat.com (Postfix) with ESMTP id DC4C2400DC9; Thu, 24 Mar 2022 17:50:36 +0000 (UTC) From: Victor Toso To: qemu-devel@nongnu.org Subject: [PATCH 14/14] qapi: fix example of dump-guest-memory Date: Thu, 24 Mar 2022 18:50:15 +0100 Message-Id: <20220324175015.232794-15-victortoso@redhat.com> In-Reply-To: <20220324175015.232794-1-victortoso@redhat.com> References: <20220324175015.232794-1-victortoso@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=victortoso@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.133.124; envelope-from=victortoso@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , Eric Blake , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" The member "paging" is not optional Signed-off-by: Victor Toso Reviewed-by: John Snow --- qapi/dump.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qapi/dump.json b/qapi/dump.json index d3ed79e8cd..0873f16e5c 100644 --- a/qapi/dump.json +++ b/qapi/dump.json @@ -83,7 +83,7 @@ # Example: # # -> { "execute": "dump-guest-memory", -# "arguments": { "protocol": "fd:dump" } } +# "arguments": { "paging": false, "protocol": "fd:dump" } } # <- { "return": {} } # ##