From patchwork Fri Mar 25 01:03:28 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chuansheng Liu X-Patchwork-Id: 12791215 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 28C28C433F5 for ; Fri, 25 Mar 2022 01:19:47 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8121F89B60; Fri, 25 Mar 2022 01:19:46 +0000 (UTC) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id D89DB89B60 for ; Fri, 25 Mar 2022 01:19:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1648171184; x=1679707184; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=6Dtbe2t8Agnn46DxITZgYPQpiah6xy7Fzhkn08LE2P4=; b=n9a0ej9DRNY3Bc4Tx60gRWQ3W0DWWNhJPrMYPcyFvX+CwTx8MEhFk+PF sVKPmRoIHBYbAVlca1Z8rqsCWgfoY1/yNOu/1huYCaBtXmubbgOG9pVCs Wc6Y0X/WZX3iyg7SauIKAGCfvldH68jD3UE/pcyR3wpH5geYVZo8R3PEF 1jchJDs6aDbJLaGcjBlYCmcI7bExXFsGkP/Ez02/vBuWjKDJ31OGUqMlE HiV7C3Rbl5boRJ+9qrAztghtw89PdaERnrZpDTcOemABDeQkBpOQz2ADp CUbf4QEduUWaTA4e8qvv2Zkf6OUvdmjOcFbgHwzudzWzfnKODI4x5tZMp A==; X-IronPort-AV: E=McAfee;i="6200,9189,10296"; a="344965436" X-IronPort-AV: E=Sophos;i="5.90,209,1643702400"; d="scan'208";a="344965436" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Mar 2022 18:19:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,209,1643702400"; d="scan'208";a="561626046" Received: from cliu38-mobl3.sh.intel.com ([10.239.147.106]) by orsmga008.jf.intel.com with ESMTP; 24 Mar 2022 18:19:42 -0700 From: Chuansheng Liu To: intel-gfx@lists.freedesktop.org Date: Fri, 25 Mar 2022 09:03:28 +0800 Message-Id: <20220325010328.32963-1-chuansheng.liu@intel.com> X-Mailer: git-send-email 2.25.0.rc2 MIME-Version: 1.0 Subject: [Intel-gfx] [PATCH v2] drm/i915: fix one mem leak in mmap_offset_attach() X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: stable@vger.kernel.org, Chris Wilson Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" The below memory leak information is caught: unreferenced object 0xffff997dd4e3b240 (size 64): comm "gem_tiled_fence", pid 10332, jiffies 4294959326 (age 220778.420s) hex dump (first 32 bytes): 01 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ 00 00 00 00 00 00 00 00 00 be f2 d4 7d 99 ff ff ............}... backtrace: [] kmem_cache_alloc_trace+0x2e5/0x450 [] drm_vma_node_allow+0x2c/0xe0 [drm] [] __assign_mmap_offset_handle+0x1da/0x4a0 [i915] [] i915_gem_mmap_offset_ioctl+0x55/0xb0 [i915] [] drm_ioctl_kernel+0xb4/0x140 [drm] [] drm_ioctl+0x257/0x410 [drm] [] __x64_sys_ioctl+0x8e/0xc0 [] do_syscall_64+0x38/0xc0 [] entry_SYSCALL_64_after_hwframe+0x44/0xae The issue is always reproduced with the test: gem_tiled_fence_blits --run-subtest basic It tries to mmap_gtt the same object several times, it is like: create BO mmap_gtt BO unmap BO mmap_gtt BO <== second time mmap_gtt unmap close BO The leak happens at the second time mmap_gtt in function mmap_offset_attach(),it will simply increase the reference count to 2 by calling drm_vma_node_allow() directly since the mmo has been created at the first time. However the driver just revokes the vma_node only one time when closing the object, it leads to memory leak easily. This patch is to fix the memory leak by calling drm_vma_node_allow() one time also. V2: add "Fixes and Cc stable". (Tvrtko Ursulin) Fixes: 786555987207 ("drm/i915/gem: Store mmap_offsets in an rbtree rather than a plain list") Cc: # v5.7+ Cc: Chris Wilson Cc: Tvrtko Ursulin Signed-off-by: Chuansheng Liu Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gem/i915_gem_mman.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_mman.c b/drivers/gpu/drm/i915/gem/i915_gem_mman.c index c3ea243d414d..fda346d687fd 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_mman.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_mman.c @@ -680,7 +680,7 @@ mmap_offset_attach(struct drm_i915_gem_object *obj, mmo = insert_mmo(obj, mmo); GEM_BUG_ON(lookup_mmo(obj, mmap_type) != mmo); out: - if (file) + if (file && !drm_vma_node_is_allowed(&mmo->vma_node, file)) drm_vma_node_allow(&mmo->vma_node, file); return mmo;