From patchwork Fri Mar 25 22:06:54 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Victor Toso X-Patchwork-Id: 12792095 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 68799C433EF for ; Fri, 25 Mar 2022 22:09:14 +0000 (UTC) Received: from localhost ([::1]:42102 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nXs7M-00070D-VH for qemu-devel@archiver.kernel.org; Fri, 25 Mar 2022 18:09:13 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35390) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXs5U-0004Se-4G for qemu-devel@nongnu.org; Fri, 25 Mar 2022 18:07:16 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:58851) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXs5R-0002kt-RM for qemu-devel@nongnu.org; Fri, 25 Mar 2022 18:07:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648246033; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vcMYkzs+SdOWIAdNnYWwFluyta0X0IVzhusqVoPMs8I=; b=ImhsDlOL6GMV2g1GWHWfuRADoHl9oKDpmdlkeq2LgEDTIpLR+al03HhQeYm6tWpO2rhhUp Rm23n+y1DZlHrh1mbupajA9IRK5eftU4Spp54J2nLOrbXBlz1Oc9TETE5XOVlNcp4YpynH 0+K925785TfbTKMmZ0k30uQbk2gUtLk= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-141-kpPfmZcgM_aI5RTEdspsag-1; Fri, 25 Mar 2022 18:07:12 -0400 X-MC-Unique: kpPfmZcgM_aI5RTEdspsag-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C3352802809 for ; Fri, 25 Mar 2022 22:07:11 +0000 (UTC) Received: from tapioca.redhat.com (unknown [10.40.192.95]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6D4C9400F8C2; Fri, 25 Mar 2022 22:07:10 +0000 (UTC) From: Victor Toso To: qemu-devel@nongnu.org Subject: [PATCH v2 01/14] qapi: BlockExportRemoveMode: move comments to TODO Date: Fri, 25 Mar 2022 23:06:54 +0100 Message-Id: <20220325220707.52118-2-victortoso@redhat.com> In-Reply-To: <20220325220707.52118-1-victortoso@redhat.com> References: <20220325220707.52118-1-victortoso@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=victortoso@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.129.124; envelope-from=victortoso@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , Eric Blake , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" @hide and @soft are potential additions which fits the TODO section perfectly. The main motivation is to avoid this whole block of comment entering the wrong section in the python parser. Signed-off-by: Victor Toso Reviewed-by: Markus Armbruster Reviewed-by: John Snow --- qapi/block-export.json | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/qapi/block-export.json b/qapi/block-export.json index f183522d0d..1e34927f85 100644 --- a/qapi/block-export.json +++ b/qapi/block-export.json @@ -219,13 +219,13 @@ # # @hard: Drop all connections immediately and remove export. # -# Potential additional modes to be added in the future: +# TODO: Potential additional modes to be added in the future: # -# hide: Just hide export from new clients, leave existing connections as is. -# Remove export after all clients are disconnected. +# hide: Just hide export from new clients, leave existing connections as is. +# Remove export after all clients are disconnected. # -# soft: Hide export from new clients, answer with ESHUTDOWN for all further -# requests from existing clients. +# soft: Hide export from new clients, answer with ESHUTDOWN for all further +# requests from existing clients. # # Since: 2.12 ## From patchwork Fri Mar 25 22:06:55 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Victor Toso X-Patchwork-Id: 12792098 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B5DB4C433FE for ; Fri, 25 Mar 2022 22:09:22 +0000 (UTC) Received: from localhost ([::1]:42754 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nXs7V-0007Qf-MX for qemu-devel@archiver.kernel.org; Fri, 25 Mar 2022 18:09:21 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35420) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXs5g-0004Yd-F1 for qemu-devel@nongnu.org; Fri, 25 Mar 2022 18:07:28 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:20152) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXs5T-0002lA-Jr for qemu-devel@nongnu.org; Fri, 25 Mar 2022 18:07:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648246034; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H5sXVKToU5efpJhHCnZNL4W5uAR7zExJe9wxd9FNBlA=; b=g0oo7HED6TY91NdSjKS9xeQx+Wd5lPEypr91vCjI0sXBbq0ajJcQ2VLEDIK4W0lIKhbzf8 qzQmEajJAnLZOSMkf1Bs16jJ3+8fwXRz3Z6NeW2JX718TCXg9VZ/uRtihycZLyMPel16e8 jGb5muQ1KUkZPVKCAPYDHOAXCTD5X4M= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-528-7lIJROmYOoS_yLB4xE5Zcw-1; Fri, 25 Mar 2022 18:07:13 -0400 X-MC-Unique: 7lIJROmYOoS_yLB4xE5Zcw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6A42A85A5A8 for ; Fri, 25 Mar 2022 22:07:13 +0000 (UTC) Received: from tapioca.redhat.com (unknown [10.40.192.95]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2E155403D188; Fri, 25 Mar 2022 22:07:11 +0000 (UTC) From: Victor Toso To: qemu-devel@nongnu.org Subject: [PATCH v2 02/14] qapi: fix example of BLOCK_IMAGE_CORRUPTED event Date: Fri, 25 Mar 2022 23:06:55 +0100 Message-Id: <20220325220707.52118-3-victortoso@redhat.com> In-Reply-To: <20220325220707.52118-1-victortoso@redhat.com> References: <20220325220707.52118-1-victortoso@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=victortoso@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.133.124; envelope-from=victortoso@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , Eric Blake , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Fatal is not optional. Signed-off-by: Victor Toso --- qapi/block-core.json | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index e89f2dfb5b..63c30a5378 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -5006,10 +5006,9 @@ # Example: # # <- { "event": "BLOCK_IMAGE_CORRUPTED", -# "data": { "device": "ide0-hd0", "node-name": "node0", -# "msg": "Prevented active L1 table overwrite", "offset": 196608, -# "size": 65536 }, -# "timestamp": { "seconds": 1378126126, "microseconds": 966463 } } +# "data": { "device": "", "node-name": "drive", "fatal": false, +# "msg": "L2 table offset 0x2a2a2a00 unaligned (L1 index: 0)" }, +# "timestamp": { "seconds": 1648243240, "microseconds": 906060 } } # # Since: 1.7 ## From patchwork Fri Mar 25 22:06:56 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Victor Toso X-Patchwork-Id: 12792113 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E362EC433FE for ; Fri, 25 Mar 2022 22:14:01 +0000 (UTC) Received: from localhost ([::1]:59138 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nXsC0-0001j4-VE for qemu-devel@archiver.kernel.org; Fri, 25 Mar 2022 18:14:01 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35492) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXs5g-0004c9-R6 for qemu-devel@nongnu.org; Fri, 25 Mar 2022 18:07:28 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:34176) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXs5f-0002lR-1e for qemu-devel@nongnu.org; Fri, 25 Mar 2022 18:07:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648246036; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+M/xLxFa5Y1Wx/hoV4FeiemKig2JTfYb/HpGBZZk6cQ=; b=XbkI+GKncbPIh8dYDNuXaK+qGBenKzHypAiwqU+OlNI8mA8/UIsLqAuIzAO1MafwWY/zBu 4bN9ZlDzHCnFPAnQEGUglUM2YGoefhYvxpwTLwDecgLjW4xR5jMtyaLBcZcBpPKE6/0Bws hjX0JSKQX2+5O7PM1BxDgeEd7m6xCSU= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-301-ly1QLum1MuqQdKtVSihiWw-1; Fri, 25 Mar 2022 18:07:15 -0400 X-MC-Unique: ly1QLum1MuqQdKtVSihiWw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 124023C14CC2 for ; Fri, 25 Mar 2022 22:07:15 +0000 (UTC) Received: from tapioca.redhat.com (unknown [10.40.192.95]) by smtp.corp.redhat.com (Postfix) with ESMTP id C9E5240D2970; Fri, 25 Mar 2022 22:07:13 +0000 (UTC) From: Victor Toso To: qemu-devel@nongnu.org Subject: [PATCH v2 03/14] qapi: fix example of BLOCK_IO_ERROR event Date: Fri, 25 Mar 2022 23:06:56 +0100 Message-Id: <20220325220707.52118-4-victortoso@redhat.com> In-Reply-To: <20220325220707.52118-1-victortoso@redhat.com> References: <20220325220707.52118-1-victortoso@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=victortoso@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.129.124; envelope-from=victortoso@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , Eric Blake , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Reason is not optional. Signed-off-by: Victor Toso --- qapi/block-core.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index 63c30a5378..46580ac551 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -5058,7 +5058,8 @@ # "data": { "device": "ide0-hd1", # "node-name": "#block212", # "operation": "write", -# "action": "stop" }, +# "action": "stop", +# "reason": "No space left on device" }, # "timestamp": { "seconds": 1265044230, "microseconds": 450486 } } # ## From patchwork Fri Mar 25 22:06:57 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Victor Toso X-Patchwork-Id: 12792114 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4722DC433EF for ; Fri, 25 Mar 2022 22:14:07 +0000 (UTC) Received: from localhost ([::1]:59694 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nXsC6-00025v-F9 for qemu-devel@archiver.kernel.org; Fri, 25 Mar 2022 18:14:06 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35506) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXs5h-0004cv-1z for qemu-devel@nongnu.org; Fri, 25 Mar 2022 18:07:29 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:41946) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXs5f-0002lZ-05 for qemu-devel@nongnu.org; Fri, 25 Mar 2022 18:07:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648246038; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nVZ2WY4c561Tl/PZUI3ZnvwntUTj+V+eBf9RGKeuzPI=; b=iijB2NAMmfSlSvtERYca8qU5X40tYwGDwMIVnNGRAQ7+b5vSZz4G0b5m0XsQm+aJ/QKi5g a+GIhHr4J86FxVtzWZOfLqXMfW9p3MRwc7M1VwCWyjD42ybzP9RhrcwlQN4AS3c0t9R4dX x9FOFk8UgBcb4/6ztBfI+1DBOdQCLrE= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-622-1fXb4aRXNbic2PF_lkEkKQ-1; Fri, 25 Mar 2022 18:07:16 -0400 X-MC-Unique: 1fXb4aRXNbic2PF_lkEkKQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 945612999B20 for ; Fri, 25 Mar 2022 22:07:16 +0000 (UTC) Received: from tapioca.redhat.com (unknown [10.40.192.95]) by smtp.corp.redhat.com (Postfix) with ESMTP id 729B4400F8C2; Fri, 25 Mar 2022 22:07:15 +0000 (UTC) From: Victor Toso To: qemu-devel@nongnu.org Subject: [PATCH v2 04/14] qapi: fix example of BLOCK_JOB_PENDING event Date: Fri, 25 Mar 2022 23:06:57 +0100 Message-Id: <20220325220707.52118-5-victortoso@redhat.com> In-Reply-To: <20220325220707.52118-1-victortoso@redhat.com> References: <20220325220707.52118-1-victortoso@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=victortoso@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.133.124; envelope-from=victortoso@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , Eric Blake , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Event's name: BLOCK_JOB_WAITING -> BLOCK_JOB_PENDING * Argument device -> id Signed-off-by: Victor Toso Reviewed-by: John Snow Reviewed-by: Markus Armbruster --- qapi/block-core.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index 46580ac551..4a7a6940a3 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -5225,8 +5225,8 @@ # # Example: # -# <- { "event": "BLOCK_JOB_WAITING", -# "data": { "device": "drive0", "type": "mirror" }, +# <- { "event": "BLOCK_JOB_PENDING", +# "data": { "type": "mirror", "id": "backup_1" }, # "timestamp": { "seconds": 1265044230, "microseconds": 450486 } } # ## From patchwork Fri Mar 25 22:06:58 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Victor Toso X-Patchwork-Id: 12792097 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8F50AC433EF for ; Fri, 25 Mar 2022 22:09:22 +0000 (UTC) Received: from localhost ([::1]:42786 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nXs7V-0007Re-GT for qemu-devel@archiver.kernel.org; Fri, 25 Mar 2022 18:09:21 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35504) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXs5h-0004cs-1f for qemu-devel@nongnu.org; Fri, 25 Mar 2022 18:07:29 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:59936) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXs5f-0002ld-32 for qemu-devel@nongnu.org; Fri, 25 Mar 2022 18:07:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648246039; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GaAbKcRlgHNCUO2E8Bt8QiiL2zx8UnILoxweGHI8Xw8=; b=OYko6GuuRNtrfxGiAFj3HCFWnctFP12FJ0UT04ks2wKEf1tTq530hpSFFigQZErjygEulV QQrDmOFE4JSJKnaj6JRpmE/EgT94O/yR6BXFUzN3ykIA5D/MrQXieV6zQDgj6c4u7PVyWZ 3YyEgk9Ahov64OjXCRZpp4R/lHnGCsU= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-546-Mn3BvJWyN62Ju4_vDBARcg-1; Fri, 25 Mar 2022 18:07:18 -0400 X-MC-Unique: Mn3BvJWyN62Ju4_vDBARcg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 12A38811E78 for ; Fri, 25 Mar 2022 22:07:18 +0000 (UTC) Received: from tapioca.redhat.com (unknown [10.40.192.95]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0048F400F8C2; Fri, 25 Mar 2022 22:07:16 +0000 (UTC) From: Victor Toso To: qemu-devel@nongnu.org Subject: [PATCH v2 05/14] qapi: fix example of DUMP_COMPLETED event Date: Fri, 25 Mar 2022 23:06:58 +0100 Message-Id: <20220325220707.52118-6-victortoso@redhat.com> In-Reply-To: <20220325220707.52118-1-victortoso@redhat.com> References: <20220325220707.52118-1-victortoso@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=victortoso@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.133.124; envelope-from=victortoso@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , Eric Blake , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Timestamp is not optional, let's add for completeness. * Add '<-' to signalize it is receiving the data * While at it, add extra space before "result" and "total" and after "completed" value. Signed-off-by: Victor Toso Reviewed-by: Markus Armbruster Reviewed-by: John Snow --- qapi/dump.json | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/qapi/dump.json b/qapi/dump.json index f7c4267e3f..9119c82b14 100644 --- a/qapi/dump.json +++ b/qapi/dump.json @@ -161,9 +161,10 @@ # # Example: # -# { "event": "DUMP_COMPLETED", -# "data": {"result": {"total": 1090650112, "status": "completed", -# "completed": 1090650112} } } +# <- { "event": "DUMP_COMPLETED", +# "data": { "result": { "total": 1090650112, "status": "completed", +# "completed": 1090650112 } }, +# "timestamp": { "seconds": 1648244171, "microseconds": 950316 } } # ## { 'event': 'DUMP_COMPLETED' , From patchwork Fri Mar 25 22:06:59 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Victor Toso X-Patchwork-Id: 12792101 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 57535C433F5 for ; Fri, 25 Mar 2022 22:11:48 +0000 (UTC) Received: from localhost ([::1]:51284 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nXs9r-0004nj-Gj for qemu-devel@archiver.kernel.org; Fri, 25 Mar 2022 18:11:47 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35502) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXs5h-0004cm-1M for qemu-devel@nongnu.org; Fri, 25 Mar 2022 18:07:29 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:47337) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXs5f-0002lj-7V for qemu-devel@nongnu.org; Fri, 25 Mar 2022 18:07:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648246041; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iSiGYedV9kQEqX9T5Lwa+9ZWSrAWjMRqUuDhcbKJizw=; b=I3am10VI99MojmeHc1l7TwC2NcX8g03QFLUeYlWgeCeKpr+vkrXhJ8EFer9fi1KQxmwI9b whLdKmHsr4wiX7Z+I1EtPiLFQFZTet8Np2ugINg6cyvlyo+O2UoUzeM++p34OrWlOveWCd A1qTRgLE7WzslrIx5mvqZzLVrfbBWV4= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-81-qqrz6PBgNGCuotryWf7peg-1; Fri, 25 Mar 2022 18:07:20 -0400 X-MC-Unique: qqrz6PBgNGCuotryWf7peg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 488E01011607 for ; Fri, 25 Mar 2022 22:07:20 +0000 (UTC) Received: from tapioca.redhat.com (unknown [10.40.192.95]) by smtp.corp.redhat.com (Postfix) with ESMTP id 635C0403D186; Fri, 25 Mar 2022 22:07:18 +0000 (UTC) From: Victor Toso To: qemu-devel@nongnu.org Subject: [PATCH v2 06/14] qapi: fix example of MEMORY_DEVICE_SIZE_CHANGE event Date: Fri, 25 Mar 2022 23:06:59 +0100 Message-Id: <20220325220707.52118-7-victortoso@redhat.com> In-Reply-To: <20220325220707.52118-1-victortoso@redhat.com> References: <20220325220707.52118-1-victortoso@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=victortoso@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.129.124; envelope-from=victortoso@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , Eric Blake , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * qom-path is not optional Signed-off-by: Victor Toso Reviewed-by: John Snow Reviewed-by: Markus Armbruster --- qapi/machine.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/qapi/machine.json b/qapi/machine.json index 42fc68403d..9c460ec450 100644 --- a/qapi/machine.json +++ b/qapi/machine.json @@ -1356,7 +1356,8 @@ # Example: # # <- { "event": "MEMORY_DEVICE_SIZE_CHANGE", -# "data": { "id": "vm0", "size": 1073741824}, +# "data": { "id": "vm0", "size": 1073741824, +# "qom-path": "/machine/unattached/device[2]" }, # "timestamp": { "seconds": 1588168529, "microseconds": 201316 } } # ## From patchwork Fri Mar 25 22:07:00 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Victor Toso X-Patchwork-Id: 12792099 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A0FF0C433EF for ; Fri, 25 Mar 2022 22:11:40 +0000 (UTC) Received: from localhost ([::1]:50606 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nXs9j-0004MD-Px for qemu-devel@archiver.kernel.org; Fri, 25 Mar 2022 18:11:39 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35542) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXs5i-0004g0-5c for qemu-devel@nongnu.org; Fri, 25 Mar 2022 18:07:30 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:54431) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXs5f-0002lr-7d for qemu-devel@nongnu.org; Fri, 25 Mar 2022 18:07:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648246043; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YcyASfqWeLEX2ydcFNDQ5lxmIVaxdA/2jTGvzn82Gj4=; b=COojuE24TdgnqeyRTBzapuoiKWUwx26gp0RNA0BVZMgM9MhwS1HdcZ4FeMAph91EmLPYyb CqkjBySwW/SsGNLxvuab8++Fe2FytwPNhot3slwyQmmT8IraxkTRs87R5w578Q0DqCbSdE U8XHvNpEXCdjwKBDvyQG5xStRqIxgCE= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-628-QOAPKtY8NgeHmeIPNPznsA-1; Fri, 25 Mar 2022 18:07:22 -0400 X-MC-Unique: QOAPKtY8NgeHmeIPNPznsA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E49D910115FA for ; Fri, 25 Mar 2022 22:07:21 +0000 (UTC) Received: from tapioca.redhat.com (unknown [10.40.192.95]) by smtp.corp.redhat.com (Postfix) with ESMTP id A819B40C1438; Fri, 25 Mar 2022 22:07:20 +0000 (UTC) From: Victor Toso To: qemu-devel@nongnu.org Subject: [PATCH v2 07/14] qapi: fix example of UNPLUG_PRIMARY event Date: Fri, 25 Mar 2022 23:07:00 +0100 Message-Id: <20220325220707.52118-8-victortoso@redhat.com> In-Reply-To: <20220325220707.52118-1-victortoso@redhat.com> References: <20220325220707.52118-1-victortoso@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=victortoso@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.133.124; envelope-from=victortoso@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , Eric Blake , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Timestamp is not optional, let's add for completeness. * Add '<-' to signalize it is receiving the data * Break lines like most of examples do Signed-off-by: Victor Toso Reviewed-by: John Snow --- qapi/migration.json | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/qapi/migration.json b/qapi/migration.json index 18e2610e88..092a63354b 100644 --- a/qapi/migration.json +++ b/qapi/migration.json @@ -1736,7 +1736,9 @@ # Since: 4.2 # # Example: -# {"event": "UNPLUG_PRIMARY", "data": {"device-id": "hostdev0"} } +# <- { "event": "UNPLUG_PRIMARY", +# "data": { "device-id": "hostdev0" }, +# "timestamp": { "seconds": 1265044230, "microseconds": 450486 } } # ## { 'event': 'UNPLUG_PRIMARY', From patchwork Fri Mar 25 22:07:01 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Victor Toso X-Patchwork-Id: 12792117 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A1EABC433EF for ; Fri, 25 Mar 2022 22:15:57 +0000 (UTC) Received: from localhost ([::1]:38798 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nXsDs-0007Is-QV for qemu-devel@archiver.kernel.org; Fri, 25 Mar 2022 18:15:56 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35548) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXs5i-0004ga-BF for qemu-devel@nongnu.org; Fri, 25 Mar 2022 18:07:30 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:28116) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXs5f-0002lx-8z for qemu-devel@nongnu.org; Fri, 25 Mar 2022 18:07:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648246044; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cpHETraRzg+3htz1KK9kjXeIW88SwSUSk6cfsOL/QYM=; b=S8SY4ccI4QXKpe4w2dnRXW8CDO+/9j4I/xVCvfY1g+t9QrGuYtdMPQyp5ZE6G55vyjpp2V RVC1bVvo4QylyXxJI6u6+j/v0Ky6SXO6jKFLqG4iysd+/r0fZDAOafed02dKKjFuXx2NC2 RXkEvi9wTP7A7DsTVonVnQoC+yjFBIo= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-618-8Vi51-7MPcu_SzVKbe9_hg-1; Fri, 25 Mar 2022 18:07:23 -0400 X-MC-Unique: 8Vi51-7MPcu_SzVKbe9_hg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 73A57380051E for ; Fri, 25 Mar 2022 22:07:23 +0000 (UTC) Received: from tapioca.redhat.com (unknown [10.40.192.95]) by smtp.corp.redhat.com (Postfix) with ESMTP id 50B6D40D2970; Fri, 25 Mar 2022 22:07:22 +0000 (UTC) From: Victor Toso To: qemu-devel@nongnu.org Subject: [PATCH v2 08/14] qapi: fix example of FAILOVER_NEGOTIATED event Date: Fri, 25 Mar 2022 23:07:01 +0100 Message-Id: <20220325220707.52118-9-victortoso@redhat.com> In-Reply-To: <20220325220707.52118-1-victortoso@redhat.com> References: <20220325220707.52118-1-victortoso@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=victortoso@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.133.124; envelope-from=victortoso@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , Eric Blake , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Data is an object, not a string. It generates a qdict. * Timestamp is not optional, let's add for completeness. * Add missing "@" to proper document "device-id" * Add extra space for "Since" section Signed-off-by: Victor Toso Reviewed-by: John Snow --- qapi/net.json | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/qapi/net.json b/qapi/net.json index 7fab2e7cd8..0d4578bd07 100644 --- a/qapi/net.json +++ b/qapi/net.json @@ -685,13 +685,15 @@ # Failover primary devices which were hidden (not hotplugged when requested) # before will now be hotplugged by the virtio-net standby device. # -# device-id: QEMU device id of the unplugged device +# @device-id: QEMU device id of the unplugged device +# # Since: 4.2 # # Example: # # <- { "event": "FAILOVER_NEGOTIATED", -# "data": "net1" } +# "data": { "device-id": "net1" }, +# "timestamp": { "seconds": 1368697518, "microseconds": 326866 } } # ## { 'event': 'FAILOVER_NEGOTIATED', From patchwork Fri Mar 25 22:07:02 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Victor Toso X-Patchwork-Id: 12792100 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ABA46C433F5 for ; Fri, 25 Mar 2022 22:11:41 +0000 (UTC) Received: from localhost ([::1]:50700 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nXs9k-0004Pp-Pn for qemu-devel@archiver.kernel.org; Fri, 25 Mar 2022 18:11:40 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35488) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXs5g-0004b7-Fu for qemu-devel@nongnu.org; Fri, 25 Mar 2022 18:07:28 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:24299) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXs5f-0002m8-06 for qemu-devel@nongnu.org; Fri, 25 Mar 2022 18:07:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648246046; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1RCMkn9zccUk0CDKFlXMaRqhdJDh7iodo6vKDki/2fc=; b=HEStdfFl+m+fVNtZOjFCfRSJBFeC2QiThiXPmBSRe9c17qqVVTBQmz/akrGlcgrC84QxeV G/kCVuv6dZsbL4mwTA1opCreQqfcjPGtHvotr7fs48N55efaTVFGnBRwTq0H+aq5YFcJeG WzmjkNoB/xU2+KEM+ikxaaO6VQ9DDsc= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-461-sC24jfYRMmODoPv5iQpsJg-1; Fri, 25 Mar 2022 18:07:25 -0400 X-MC-Unique: sC24jfYRMmODoPv5iQpsJg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 02AAD9219A4 for ; Fri, 25 Mar 2022 22:07:25 +0000 (UTC) Received: from tapioca.redhat.com (unknown [10.40.192.95]) by smtp.corp.redhat.com (Postfix) with ESMTP id D250140C1438; Fri, 25 Mar 2022 22:07:23 +0000 (UTC) From: Victor Toso To: qemu-devel@nongnu.org Subject: [PATCH v2 09/14] qapi: fix examples: SHUTDOWN and RESET events Date: Fri, 25 Mar 2022 23:07:02 +0100 Message-Id: <20220325220707.52118-10-victortoso@redhat.com> In-Reply-To: <20220325220707.52118-1-victortoso@redhat.com> References: <20220325220707.52118-1-victortoso@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=victortoso@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.129.124; envelope-from=victortoso@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , Eric Blake , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" The 'reason' member in not optional. Signed-off-by: Victor Toso Reviewed-by: John Snow --- qapi/run-state.json | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/qapi/run-state.json b/qapi/run-state.json index 43d66d700f..1b9f64c9cd 100644 --- a/qapi/run-state.json +++ b/qapi/run-state.json @@ -150,7 +150,8 @@ # # Example: # -# <- { "event": "SHUTDOWN", "data": { "guest": true }, +# <- { "event": "SHUTDOWN", +# "data": { "guest": true, "reason": "guest-shutdown" }, # "timestamp": { "seconds": 1267040730, "microseconds": 682951 } } # ## @@ -188,7 +189,8 @@ # # Example: # -# <- { "event": "RESET", "data": { "guest": false }, +# <- { "event": "RESET", +# "data": { "guest": false, "reason": "guest-reset" }, # "timestamp": { "seconds": 1267041653, "microseconds": 9518 } } # ## From patchwork Fri Mar 25 22:07:03 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Victor Toso X-Patchwork-Id: 12792102 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 48C5CC433F5 for ; Fri, 25 Mar 2022 22:11:59 +0000 (UTC) Received: from localhost ([::1]:51420 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nXsA1-0004uQ-RN for qemu-devel@archiver.kernel.org; Fri, 25 Mar 2022 18:11:57 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35552) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXs5i-0004gx-Ec for qemu-devel@nongnu.org; Fri, 25 Mar 2022 18:07:30 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:57604) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXs5g-0002mU-UF for qemu-devel@nongnu.org; Fri, 25 Mar 2022 18:07:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648246048; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IlwMSJ8CpOVQAgNoUg17Qt/Wa7C23ZqHdPPa/ui9BJ0=; b=GRMnTaxl3SgBAISoqM2h/J/6TQ92D5sdGPJHqWuO3mvSuJfcHRoKvdrPHlvP2KCNzJtHww /xQyXicJLOEE9BqEZoWY3taO5gqtlpIpIzbqOpg5g/WeRMwn4akdtPYjHrI58VsWJhhbUC XPv7Eu5pvzIW5aTUXliAyUXXkzE2Pbs= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-135-Cz1MJj7TNzS8AOj3yjWDHA-1; Fri, 25 Mar 2022 18:07:26 -0400 X-MC-Unique: Cz1MJj7TNzS8AOj3yjWDHA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9D384811E78 for ; Fri, 25 Mar 2022 22:07:26 +0000 (UTC) Received: from tapioca.redhat.com (unknown [10.40.192.95]) by smtp.corp.redhat.com (Postfix) with ESMTP id 60EAB403D188; Fri, 25 Mar 2022 22:07:25 +0000 (UTC) From: Victor Toso To: qemu-devel@nongnu.org Subject: [PATCH v2 10/14] qapi: run-state examples: add missing timestamp Date: Fri, 25 Mar 2022 23:07:03 +0100 Message-Id: <20220325220707.52118-11-victortoso@redhat.com> In-Reply-To: <20220325220707.52118-1-victortoso@redhat.com> References: <20220325220707.52118-1-victortoso@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=victortoso@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.129.124; envelope-from=victortoso@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , Eric Blake , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Victor Toso Reviewed-by: John Snow --- qapi/run-state.json | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/qapi/run-state.json b/qapi/run-state.json index 1b9f64c9cd..7f1c788c4e 100644 --- a/qapi/run-state.json +++ b/qapi/run-state.json @@ -426,7 +426,8 @@ # Example: # # <- { "event": "GUEST_PANICKED", -# "data": { "action": "pause" } } +# "data": { "action": "pause" }, +# "timestamp": { "seconds": 1648245231, "microseconds": 900001 } } # ## { 'event': 'GUEST_PANICKED', @@ -446,7 +447,8 @@ # Example: # # <- { "event": "GUEST_CRASHLOADED", -# "data": { "action": "run" } } +# "data": { "action": "run" }, +# "timestamp": { "seconds": 1648245259, "microseconds": 893771 } } # ## { 'event': 'GUEST_CRASHLOADED', From patchwork Fri Mar 25 22:07:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Victor Toso X-Patchwork-Id: 12792118 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 81CD5C433F5 for ; Fri, 25 Mar 2022 22:16:31 +0000 (UTC) Received: from localhost ([::1]:41272 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nXsEQ-0000Z2-IM for qemu-devel@archiver.kernel.org; Fri, 25 Mar 2022 18:16:30 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35592) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXs5l-0004sf-RR for qemu-devel@nongnu.org; Fri, 25 Mar 2022 18:07:34 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:58409) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXs5k-0002oZ-BT for qemu-devel@nongnu.org; Fri, 25 Mar 2022 18:07:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648246051; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GPrjR++JXZL8Jwfm1wYE6uuwSwdytnw620tS+Utbu28=; b=T8kYgw2GIlz5Wf+5zwwZdT3exy8CT9XCS6NBmnD2cv5192HcRZEaK9uRPgxuUt6tqyPh9d z3ifnbedULQvlGKEtnAn/V6H12WXdmxk1785ZEgyxyaWhTBwKuhqIE9vhHr4Wn5ebgpUD6 0VwV3Vpg8ewJj/cNT6novra6OG8fm3c= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-86-x9V6VFPsM-iF3KioLxlCwg-1; Fri, 25 Mar 2022 18:07:28 -0400 X-MC-Unique: x9V6VFPsM-iF3KioLxlCwg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2B66F2999B22 for ; Fri, 25 Mar 2022 22:07:28 +0000 (UTC) Received: from tapioca.redhat.com (unknown [10.40.192.95]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0880840C1438; Fri, 25 Mar 2022 22:07:26 +0000 (UTC) From: Victor Toso To: qemu-devel@nongnu.org Subject: [PATCH v2 11/14] qapi: fix example of MEMORY_FAILURE Date: Fri, 25 Mar 2022 23:07:04 +0100 Message-Id: <20220325220707.52118-12-victortoso@redhat.com> In-Reply-To: <20220325220707.52118-1-victortoso@redhat.com> References: <20220325220707.52118-1-victortoso@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=victortoso@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.133.124; envelope-from=victortoso@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , Eric Blake , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Minor issues found and fixed with the example: * The JSON object of EVENT was not closed * Missing timestamp * Flags are optional but if defined then all members should be include so we add "recursive" member. * Changed string from '' to "" in action-required member. Signed-off-by: Victor Toso Reviewed-by: John Snow --- qapi/run-state.json | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/qapi/run-state.json b/qapi/run-state.json index 7f1c788c4e..8124220bd9 100644 --- a/qapi/run-state.json +++ b/qapi/run-state.json @@ -571,7 +571,9 @@ # <- { "event": "MEMORY_FAILURE", # "data": { "recipient": "hypervisor", # "action": "fatal", -# "flags": { 'action-required': false } } +# "flags": { "action-required": false, +# "recursive": false } }, +# "timestamp": { "seconds": 1267061043, "microseconds": 959568 } } # ## { 'event': 'MEMORY_FAILURE', From patchwork Fri Mar 25 22:07:05 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Victor Toso X-Patchwork-Id: 12792120 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 958A9C433EF for ; Fri, 25 Mar 2022 22:17:55 +0000 (UTC) Received: from localhost ([::1]:45606 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nXsFm-0003VJ-O2 for qemu-devel@archiver.kernel.org; Fri, 25 Mar 2022 18:17:54 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35586) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXs5l-0004ra-E8 for qemu-devel@nongnu.org; Fri, 25 Mar 2022 18:07:33 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:56368) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXs5j-0002oV-PG for qemu-devel@nongnu.org; Fri, 25 Mar 2022 18:07:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648246051; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UbVyOaW6fEKcOG8BYDc2I0X3PP7z2B3dlzgHpCDd/5I=; b=Id9RAFaCyAAu8qPb7V6DaPTnDXtg95UHMgJYA3VVsSbvO/Vb6Eh7TmdHyoIp302r9Pe/fE 1aVStB/H06a/U0vgstdk8DfEAfYU+XN5qZCbXWtxzM+NafzY4d9r1Jr6boeUEA8hWwoAKk qj3+nz1e3ZB4easXLwO/hvjwERJg1eM= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-237-z0tEBuVGNCGNPT-ydoe4Mw-1; Fri, 25 Mar 2022 18:07:30 -0400 X-MC-Unique: z0tEBuVGNCGNPT-ydoe4Mw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C4C4B811E7A for ; Fri, 25 Mar 2022 22:07:29 +0000 (UTC) Received: from tapioca.redhat.com (unknown [10.40.192.95]) by smtp.corp.redhat.com (Postfix) with ESMTP id 88FDE40D2970; Fri, 25 Mar 2022 22:07:28 +0000 (UTC) From: Victor Toso To: qemu-devel@nongnu.org Subject: [PATCH v2 12/14] qapi: ui examples: add missing websocket member Date: Fri, 25 Mar 2022 23:07:05 +0100 Message-Id: <20220325220707.52118-13-victortoso@redhat.com> In-Reply-To: <20220325220707.52118-1-victortoso@redhat.com> References: <20220325220707.52118-1-victortoso@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=victortoso@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.129.124; envelope-from=victortoso@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , Eric Blake , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" As the websocket is not optional in VncBasicInfo. Signed-off-by: Victor Toso Reviewed-by: John Snow --- qapi/ui.json | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/qapi/ui.json b/qapi/ui.json index 664da9e462..a810ed680c 100644 --- a/qapi/ui.json +++ b/qapi/ui.json @@ -710,10 +710,10 @@ # # <- { "event": "VNC_CONNECTED", # "data": { -# "server": { "auth": "sasl", "family": "ipv4", +# "server": { "auth": "sasl", "family": "ipv4", "websocket": false, # "service": "5901", "host": "0.0.0.0" }, # "client": { "family": "ipv4", "service": "58425", -# "host": "127.0.0.1" } }, +# "host": "127.0.0.1", "websocket": false } }, # "timestamp": { "seconds": 1262976601, "microseconds": 975795 } } # ## @@ -738,9 +738,9 @@ # # <- { "event": "VNC_INITIALIZED", # "data": { -# "server": { "auth": "sasl", "family": "ipv4", +# "server": { "auth": "sasl", "family": "ipv4", "websocket": false, # "service": "5901", "host": "0.0.0.0"}, -# "client": { "family": "ipv4", "service": "46089", +# "client": { "family": "ipv4", "service": "46089", "websocket": false, # "host": "127.0.0.1", "sasl_username": "luiz" } }, # "timestamp": { "seconds": 1263475302, "microseconds": 150772 } } # @@ -765,9 +765,9 @@ # # <- { "event": "VNC_DISCONNECTED", # "data": { -# "server": { "auth": "sasl", "family": "ipv4", +# "server": { "auth": "sasl", "family": "ipv4", "websocket": false, # "service": "5901", "host": "0.0.0.0" }, -# "client": { "family": "ipv4", "service": "58425", +# "client": { "family": "ipv4", "service": "58425", "websocket": false, # "host": "127.0.0.1", "sasl_username": "luiz" } }, # "timestamp": { "seconds": 1262976601, "microseconds": 975795 } } # From patchwork Fri Mar 25 22:07:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Victor Toso X-Patchwork-Id: 12792112 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C74C4C433EF for ; Fri, 25 Mar 2022 22:14:00 +0000 (UTC) Received: from localhost ([::1]:59010 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nXsBz-0001dw-Uc for qemu-devel@archiver.kernel.org; Fri, 25 Mar 2022 18:13:59 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35612) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXs5n-0004vu-21 for qemu-devel@nongnu.org; Fri, 25 Mar 2022 18:07:35 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:28555) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXs5l-0002oe-Fq for qemu-devel@nongnu.org; Fri, 25 Mar 2022 18:07:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648246052; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ku2shpfyYJCPuAMurMb5YGI1c+0R7sP9y0BwzD+rOAc=; b=RR4vLGk/y10N5jai4G+QBdikPkOYjh/XuRBCE+6PN2FnvR8RDcNLfvLVBwxB1sDGY1qUV8 mnb64cF/UfwHlYy/GCHhbupkOK0lwetnQQeyk7DAJGNaIrIANcj2ZQlWQYaJ3QlV4b1E6E miZDZahqO1VWFDWJBTvqfxgz1Eop+Ic= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-122-AaPlIPWGMhO5__VWVSZoKg-1; Fri, 25 Mar 2022 18:07:31 -0400 X-MC-Unique: AaPlIPWGMhO5__VWVSZoKg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6CCCD811E78 for ; Fri, 25 Mar 2022 22:07:31 +0000 (UTC) Received: from tapioca.redhat.com (unknown [10.40.192.95]) by smtp.corp.redhat.com (Postfix) with ESMTP id 30F9140D2970; Fri, 25 Mar 2022 22:07:30 +0000 (UTC) From: Victor Toso To: qemu-devel@nongnu.org Subject: [PATCH v2 13/14] qapi: fix example of ACPI_DEVICE_OST event Date: Fri, 25 Mar 2022 23:07:06 +0100 Message-Id: <20220325220707.52118-14-victortoso@redhat.com> In-Reply-To: <20220325220707.52118-1-victortoso@redhat.com> References: <20220325220707.52118-1-victortoso@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=victortoso@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.133.124; envelope-from=victortoso@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , Eric Blake , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Missing the timestamp * Missing the "info" object in the "data" member Signed-off-by: Victor Toso Reviewed-by: John Snow --- qapi/acpi.json | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/qapi/acpi.json b/qapi/acpi.json index 51f0d55db7..d148f6db9f 100644 --- a/qapi/acpi.json +++ b/qapi/acpi.json @@ -133,8 +133,9 @@ # Example: # # <- { "event": "ACPI_DEVICE_OST", -# "data": { "device": "d1", "slot": "0", -# "slot-type": "DIMM", "source": 1, "status": 0 } } +# "data": { "info": { "device": "d1", "slot": "0", +# "slot-type": "DIMM", "source": 1, "status": 0 } }, +# "timestamp": { "seconds": 1265044230, "microseconds": 450486 } } # ## { 'event': 'ACPI_DEVICE_OST', From patchwork Fri Mar 25 22:07:07 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Victor Toso X-Patchwork-Id: 12792122 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 69C2AC433EF for ; Fri, 25 Mar 2022 22:21:11 +0000 (UTC) Received: from localhost ([::1]:50934 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nXsIw-0007bK-GV for qemu-devel@archiver.kernel.org; Fri, 25 Mar 2022 18:21:10 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35626) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXs5q-0005Cv-SV for qemu-devel@nongnu.org; Fri, 25 Mar 2022 18:07:38 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:32206) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nXs5p-0002p6-Bs for qemu-devel@nongnu.org; Fri, 25 Mar 2022 18:07:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648246056; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=R+Ubpffmhj93kWOG4AHz7LZQeKZOoFnKSgXwNw9TVgk=; b=Qqrh9XHypuiUFK/p3C7Wmn80XxSJjGHu4tZyDGYONP2a5jVR/9tOmcqG6GxKdzKgHt8cTQ k+JRCEVolIk60P6gYnptjhlTDOmiwwnC9wVGIeQ5Xmvn4M+1uAoe0YxPgC9ZIRydT6VO5w ESYt/qggObOdC2PobqUtK82Ylm8uXoA= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-374-RIOc-YwtMROkGyq5dCRxCA-1; Fri, 25 Mar 2022 18:07:33 -0400 X-MC-Unique: RIOc-YwtMROkGyq5dCRxCA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 178331C04B40 for ; Fri, 25 Mar 2022 22:07:33 +0000 (UTC) Received: from tapioca.redhat.com (unknown [10.40.192.95]) by smtp.corp.redhat.com (Postfix) with ESMTP id CCF2040C1438; Fri, 25 Mar 2022 22:07:31 +0000 (UTC) From: Victor Toso To: qemu-devel@nongnu.org Subject: [PATCH v2 14/14] qapi: fix example of dump-guest-memory Date: Fri, 25 Mar 2022 23:07:07 +0100 Message-Id: <20220325220707.52118-15-victortoso@redhat.com> In-Reply-To: <20220325220707.52118-1-victortoso@redhat.com> References: <20220325220707.52118-1-victortoso@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=victortoso@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.133.124; envelope-from=victortoso@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , Eric Blake , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" The member "paging" is not optional Signed-off-by: Victor Toso Reviewed-by: John Snow --- qapi/dump.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qapi/dump.json b/qapi/dump.json index 9119c82b14..29441af9d8 100644 --- a/qapi/dump.json +++ b/qapi/dump.json @@ -83,7 +83,7 @@ # Example: # # -> { "execute": "dump-guest-memory", -# "arguments": { "protocol": "fd:dump" } } +# "arguments": { "paging": false, "protocol": "fd:dump" } } # <- { "return": {} } # ##