From patchwork Mon Mar 28 14:05:51 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Victor Toso X-Patchwork-Id: 12793673 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4341CC433F5 for ; Mon, 28 Mar 2022 14:22:09 +0000 (UTC) Received: from localhost ([::1]:38582 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nYqG0-0002kZ-BK for qemu-devel@archiver.kernel.org; Mon, 28 Mar 2022 10:22:08 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41556) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nYq0e-0006PX-Ip for qemu-devel@nongnu.org; Mon, 28 Mar 2022 10:06:16 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:33023) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nYq0Z-0005GH-4w for qemu-devel@nongnu.org; Mon, 28 Mar 2022 10:06:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648476370; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vcMYkzs+SdOWIAdNnYWwFluyta0X0IVzhusqVoPMs8I=; b=DP1fUh9FjB1ry2c6qLEqU1J3YshWCvKSJvw+wBmhOH7jKXGDe7AsohAeb8eHbDSThe6SAo cg9uIDCwLsfU3/MsmpzadmslxQqlINYw7qoER3xI0b/o25PY2KB8pzr5OV/ZG1xwMiB56e bq3w7hLVV7ShIj5OP2LVuYjUub0nLq4= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-639-4JzqZjRJNbG-m6QQPnrMZA-1; Mon, 28 Mar 2022 10:06:09 -0400 X-MC-Unique: 4JzqZjRJNbG-m6QQPnrMZA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 098A91C0E343 for ; Mon, 28 Mar 2022 14:06:09 +0000 (UTC) Received: from tapioca.home (unknown [10.40.195.83]) by smtp.corp.redhat.com (Postfix) with ESMTP id D2D70140240A; Mon, 28 Mar 2022 14:06:07 +0000 (UTC) From: Victor Toso To: qemu-devel@nongnu.org Subject: [PATCH v3 01/14] qapi: BlockExportRemoveMode: move comments to TODO Date: Mon, 28 Mar 2022 16:05:51 +0200 Message-Id: <20220328140604.41484-2-victortoso@redhat.com> In-Reply-To: <20220328140604.41484-1-victortoso@redhat.com> References: <20220328140604.41484-1-victortoso@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=victortoso@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.129.124; envelope-from=victortoso@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , Eric Blake , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" @hide and @soft are potential additions which fits the TODO section perfectly. The main motivation is to avoid this whole block of comment entering the wrong section in the python parser. Signed-off-by: Victor Toso Reviewed-by: Markus Armbruster Reviewed-by: John Snow --- qapi/block-export.json | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/qapi/block-export.json b/qapi/block-export.json index f183522d0d..1e34927f85 100644 --- a/qapi/block-export.json +++ b/qapi/block-export.json @@ -219,13 +219,13 @@ # # @hard: Drop all connections immediately and remove export. # -# Potential additional modes to be added in the future: +# TODO: Potential additional modes to be added in the future: # -# hide: Just hide export from new clients, leave existing connections as is. -# Remove export after all clients are disconnected. +# hide: Just hide export from new clients, leave existing connections as is. +# Remove export after all clients are disconnected. # -# soft: Hide export from new clients, answer with ESHUTDOWN for all further -# requests from existing clients. +# soft: Hide export from new clients, answer with ESHUTDOWN for all further +# requests from existing clients. # # Since: 2.12 ## From patchwork Mon Mar 28 14:05:52 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Victor Toso X-Patchwork-Id: 12793675 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F2C80C433EF for ; Mon, 28 Mar 2022 14:22:11 +0000 (UTC) Received: from localhost ([::1]:38676 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nYqG3-0002o8-3C for qemu-devel@archiver.kernel.org; Mon, 28 Mar 2022 10:22:11 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41534) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nYq0d-0006Mx-PQ for qemu-devel@nongnu.org; Mon, 28 Mar 2022 10:06:15 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:48617) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nYq0b-0005Gs-Uo for qemu-devel@nongnu.org; Mon, 28 Mar 2022 10:06:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648476373; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=i8ZxgGDunzxBS4F+NM0V3NOsMIEu9B0ZSIFgzM0Q3zA=; b=JvqearoQsaxuMgBoMAmRkZDIGnUpjsTCjj/dbL4KYnZruiVDY951+UQZmV2OKob0l2vSda Qr2KbXNZzy1LxHG6FA/o6dCmaK6/Q6dt4edX1CurA4jYgmSFojANlGDi9sqYnh3DLhpe4u oTWCrCGNkA01eEIQaIBJHK+PYOdjUf4= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-115-BGEqMvsrN3-T_KCM9odLWw-1; Mon, 28 Mar 2022 10:06:12 -0400 X-MC-Unique: BGEqMvsrN3-T_KCM9odLWw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D2BC9185A7BA for ; Mon, 28 Mar 2022 14:06:10 +0000 (UTC) Received: from tapioca.home (unknown [10.40.195.83]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5998A140241F; Mon, 28 Mar 2022 14:06:09 +0000 (UTC) From: Victor Toso To: qemu-devel@nongnu.org Subject: [PATCH v3 02/14] qapi: fix example of BLOCK_IMAGE_CORRUPTED event Date: Mon, 28 Mar 2022 16:05:52 +0200 Message-Id: <20220328140604.41484-3-victortoso@redhat.com> In-Reply-To: <20220328140604.41484-1-victortoso@redhat.com> References: <20220328140604.41484-1-victortoso@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=victortoso@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.129.124; envelope-from=victortoso@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , Eric Blake , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Example output lacks mandatory member @fatal. Provide it. Example output shows a value of @msg no version of the code produces. No big deal, but replace it anyway by one that today's code does produce. Signed-off-by: Victor Toso Reviewed-by: Markus Armbruster --- qapi/block-core.json | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index e89f2dfb5b..63c30a5378 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -5006,10 +5006,9 @@ # Example: # # <- { "event": "BLOCK_IMAGE_CORRUPTED", -# "data": { "device": "ide0-hd0", "node-name": "node0", -# "msg": "Prevented active L1 table overwrite", "offset": 196608, -# "size": 65536 }, -# "timestamp": { "seconds": 1378126126, "microseconds": 966463 } } +# "data": { "device": "", "node-name": "drive", "fatal": false, +# "msg": "L2 table offset 0x2a2a2a00 unaligned (L1 index: 0)" }, +# "timestamp": { "seconds": 1648243240, "microseconds": 906060 } } # # Since: 1.7 ## From patchwork Mon Mar 28 14:05:53 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Victor Toso X-Patchwork-Id: 12793676 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D3D94C433F5 for ; Mon, 28 Mar 2022 14:22:53 +0000 (UTC) Received: from localhost ([::1]:42298 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nYqGi-0005CQ-W1 for qemu-devel@archiver.kernel.org; Mon, 28 Mar 2022 10:22:53 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41536) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nYq0d-0006NZ-Uf for qemu-devel@nongnu.org; Mon, 28 Mar 2022 10:06:15 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:36768) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nYq0c-0005H2-AK for qemu-devel@nongnu.org; Mon, 28 Mar 2022 10:06:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648476373; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LBV/5/+KKA5Pf8XW3eAch+0mC/EZFA9g03YwByB6VGQ=; b=WtLKfPhi6xdXgfTb5GgotNQj/2zni6C388i0Z5IuoiW2OkZLeGjnc7dZ7NyaXYs9ITLbfd 6TEfEnbr2OIyrvql+qsfRHdE53deiKuUcmxP+NIQESMbHO3IfqaKuXQ6YYLzVPff3zkyrz BHzzwApFvnX7lEgi+E2ygszXMG7aWzw= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-313-ckgjYUTcMeCCpGvfQxbkpg-1; Mon, 28 Mar 2022 10:06:12 -0400 X-MC-Unique: ckgjYUTcMeCCpGvfQxbkpg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 21C27802E5B for ; Mon, 28 Mar 2022 14:06:12 +0000 (UTC) Received: from tapioca.home (unknown [10.40.195.83]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1A5D51402642; Mon, 28 Mar 2022 14:06:10 +0000 (UTC) From: Victor Toso To: qemu-devel@nongnu.org Subject: [PATCH v3 03/14] qapi: fix example of BLOCK_IO_ERROR event Date: Mon, 28 Mar 2022 16:05:53 +0200 Message-Id: <20220328140604.41484-4-victortoso@redhat.com> In-Reply-To: <20220328140604.41484-1-victortoso@redhat.com> References: <20220328140604.41484-1-victortoso@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=victortoso@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.129.124; envelope-from=victortoso@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , Eric Blake , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Example output lacks mandatory member @reason. Provide it. Signed-off-by: Victor Toso Reviewed-by: Markus Armbruster --- qapi/block-core.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index 63c30a5378..46580ac551 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -5058,7 +5058,8 @@ # "data": { "device": "ide0-hd1", # "node-name": "#block212", # "operation": "write", -# "action": "stop" }, +# "action": "stop", +# "reason": "No space left on device" }, # "timestamp": { "seconds": 1265044230, "microseconds": 450486 } } # ## From patchwork Mon Mar 28 14:05:54 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Victor Toso X-Patchwork-Id: 12793677 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AF6E2C433F5 for ; Mon, 28 Mar 2022 14:26:12 +0000 (UTC) Received: from localhost ([::1]:47078 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nYqJv-0008O2-C0 for qemu-devel@archiver.kernel.org; Mon, 28 Mar 2022 10:26:11 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41596) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nYq0g-0006Uj-A4 for qemu-devel@nongnu.org; Mon, 28 Mar 2022 10:06:18 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:48893) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nYq0e-0005HY-MH for qemu-devel@nongnu.org; Mon, 28 Mar 2022 10:06:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648476376; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VPqA5hG/zHRQ7/4wIUOkGPds0YJ+aXWMH279/6bHDCc=; b=Sl+ri55B15g/0nVNRYOB+WbKJe8knNulXxRpaToao07n/rxOMaVa8Hnicnm1THzYH4dSXi dxACeFmWqTmlhevYCSowNgJ1JMofYT4s+J6y3yvrRftn2oDZLIm2RgQ0IsX4rCpdUm0o1O SWSFHFBQLAijGBiscs24OKBPdHkR6UQ= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-270-dzu4NgzDPpOtXFWrgW3Sbg-1; Mon, 28 Mar 2022 10:06:14 -0400 X-MC-Unique: dzu4NgzDPpOtXFWrgW3Sbg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9E6E5100BAA7 for ; Mon, 28 Mar 2022 14:06:13 +0000 (UTC) Received: from tapioca.home (unknown [10.40.195.83]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8360A140240A; Mon, 28 Mar 2022 14:06:12 +0000 (UTC) From: Victor Toso To: qemu-devel@nongnu.org Subject: [PATCH v3 04/14] qapi: fix example of BLOCK_JOB_PENDING event Date: Mon, 28 Mar 2022 16:05:54 +0200 Message-Id: <20220328140604.41484-5-victortoso@redhat.com> In-Reply-To: <20220328140604.41484-1-victortoso@redhat.com> References: <20220328140604.41484-1-victortoso@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=victortoso@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.133.124; envelope-from=victortoso@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , Eric Blake , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Example output has the wrong event's name in it. Fix it. Example output shows incorrect member @device. Fix it. Signed-off-by: Victor Toso Reviewed-by: John Snow Reviewed-by: Markus Armbruster --- qapi/block-core.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index 46580ac551..4a7a6940a3 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -5225,8 +5225,8 @@ # # Example: # -# <- { "event": "BLOCK_JOB_WAITING", -# "data": { "device": "drive0", "type": "mirror" }, +# <- { "event": "BLOCK_JOB_PENDING", +# "data": { "type": "mirror", "id": "backup_1" }, # "timestamp": { "seconds": 1265044230, "microseconds": 450486 } } # ## From patchwork Mon Mar 28 14:05:55 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Victor Toso X-Patchwork-Id: 12793724 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 68976C433EF for ; Mon, 28 Mar 2022 14:38:38 +0000 (UTC) Received: from localhost ([::1]:44596 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nYqVx-0001MZ-3h for qemu-devel@archiver.kernel.org; Mon, 28 Mar 2022 10:38:37 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41650) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nYq0k-0006ip-JB for qemu-devel@nongnu.org; Mon, 28 Mar 2022 10:06:22 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:58431) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nYq0f-0005Hj-Bs for qemu-devel@nongnu.org; Mon, 28 Mar 2022 10:06:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648476376; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=seq9Nwh8IWyLQkRA/F2epUzWYv7xieFH33Aoeddn6SA=; b=hJvBXKG9ifYKyk57Fhiuv7NChMBbx8svC62iBP7UgqRWNAaaavl5cHN4D8voapRkiWocZG pljjvcghL4oT9ALZjML89dfja74YFltf6R9WqN5MoctkvJuM1huXTzFAuNqTibhyGvlBTT wrw2eGJrT3NkIycwZSXs73KEDe3r2ko= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-613-yJQjN0N5ODyyqBfWM_9whQ-1; Mon, 28 Mar 2022 10:06:15 -0400 X-MC-Unique: yJQjN0N5ODyyqBfWM_9whQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 158AC3803503 for ; Mon, 28 Mar 2022 14:06:15 +0000 (UTC) Received: from tapioca.home (unknown [10.40.195.83]) by smtp.corp.redhat.com (Postfix) with ESMTP id 022601417201; Mon, 28 Mar 2022 14:06:13 +0000 (UTC) From: Victor Toso To: qemu-devel@nongnu.org Subject: [PATCH v3 05/14] qapi: fix example of DUMP_COMPLETED event Date: Mon, 28 Mar 2022 16:05:55 +0200 Message-Id: <20220328140604.41484-6-victortoso@redhat.com> In-Reply-To: <20220328140604.41484-1-victortoso@redhat.com> References: <20220328140604.41484-1-victortoso@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=victortoso@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.129.124; envelope-from=victortoso@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , Eric Blake , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Example output lacks mandatory member @timestamp. Provide it. Example output is not properly formatted. Fixing it by: - Adding '<-' to signalize it is receiving the data; - Adding extra spaces around members @result, @total and @completed Signed-off-by: Victor Toso Reviewed-by: Markus Armbruster Reviewed-by: John Snow --- qapi/dump.json | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/qapi/dump.json b/qapi/dump.json index f7c4267e3f..9119c82b14 100644 --- a/qapi/dump.json +++ b/qapi/dump.json @@ -161,9 +161,10 @@ # # Example: # -# { "event": "DUMP_COMPLETED", -# "data": {"result": {"total": 1090650112, "status": "completed", -# "completed": 1090650112} } } +# <- { "event": "DUMP_COMPLETED", +# "data": { "result": { "total": 1090650112, "status": "completed", +# "completed": 1090650112 } }, +# "timestamp": { "seconds": 1648244171, "microseconds": 950316 } } # ## { 'event': 'DUMP_COMPLETED' , From patchwork Mon Mar 28 14:05:56 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Victor Toso X-Patchwork-Id: 12793682 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1DD8EC433EF for ; Mon, 28 Mar 2022 14:30:24 +0000 (UTC) Received: from localhost ([::1]:55828 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nYqNz-00066Y-7f for qemu-devel@archiver.kernel.org; Mon, 28 Mar 2022 10:30:23 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41624) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nYq0i-0006br-DI for qemu-devel@nongnu.org; Mon, 28 Mar 2022 10:06:20 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:60664) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nYq0g-0005I9-PB for qemu-devel@nongnu.org; Mon, 28 Mar 2022 10:06:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648476378; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pZ6i3FZR3lGS1qFMHs4ymgGUHGj3QFKEk+IGOruig78=; b=HmhKxdqshVRL802Lxsz25Ezr4LsFvhWoTmNb5JI6xeHLp4tOtzguMjMLfUfmeOfsJCxtWL KHqzjO6XaU3IDHQwYHi4U8L7URvCF3TuKUYo8ejHCXg/A4IzXac+WpvXughX0jNs+xHrFo 5YpnEbE1R8d8pVLjEGLkftY2aqoci4c= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-620-2l8_RxmjNuWbEf02myEqHw-1; Mon, 28 Mar 2022 10:06:16 -0400 X-MC-Unique: 2l8_RxmjNuWbEf02myEqHw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 78C9C80379F for ; Mon, 28 Mar 2022 14:06:16 +0000 (UTC) Received: from tapioca.home (unknown [10.40.195.83]) by smtp.corp.redhat.com (Postfix) with ESMTP id 69B0D1402642; Mon, 28 Mar 2022 14:06:15 +0000 (UTC) From: Victor Toso To: qemu-devel@nongnu.org Subject: [PATCH v3 06/14] qapi: fix example of MEMORY_DEVICE_SIZE_CHANGE event Date: Mon, 28 Mar 2022 16:05:56 +0200 Message-Id: <20220328140604.41484-7-victortoso@redhat.com> In-Reply-To: <20220328140604.41484-1-victortoso@redhat.com> References: <20220328140604.41484-1-victortoso@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=victortoso@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.133.124; envelope-from=victortoso@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , Eric Blake , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Example output lacks mandatory member @qom-path. Provide it. Signed-off-by: Victor Toso Reviewed-by: John Snow Reviewed-by: Markus Armbruster --- qapi/machine.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/qapi/machine.json b/qapi/machine.json index 42fc68403d..9c460ec450 100644 --- a/qapi/machine.json +++ b/qapi/machine.json @@ -1356,7 +1356,8 @@ # Example: # # <- { "event": "MEMORY_DEVICE_SIZE_CHANGE", -# "data": { "id": "vm0", "size": 1073741824}, +# "data": { "id": "vm0", "size": 1073741824, +# "qom-path": "/machine/unattached/device[2]" }, # "timestamp": { "seconds": 1588168529, "microseconds": 201316 } } # ## From patchwork Mon Mar 28 14:05:57 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Victor Toso X-Patchwork-Id: 12793696 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F620C4332F for ; Mon, 28 Mar 2022 14:34:56 +0000 (UTC) Received: from localhost ([::1]:36198 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nYqSN-0003yZ-Hp for qemu-devel@archiver.kernel.org; Mon, 28 Mar 2022 10:34:55 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41638) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nYq0j-0006fx-P2 for qemu-devel@nongnu.org; Mon, 28 Mar 2022 10:06:21 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:49825) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nYq0i-0005IF-0Z for qemu-devel@nongnu.org; Mon, 28 Mar 2022 10:06:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648476379; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=87vN3ZxXxp5gsy94R/Q63nJ0ZJu0kNCU3acXv9UizRQ=; b=fUrzEh06qalGv9OKLj4Ml6eb7HT84L+LgZrOGV0e4mvWyD3yyA0fNESQI3B1yg5ZI4GI4c 8PTS2GH69xqmBRzI4HVY4DZfk3v/m0hpk7+Ln+7n58lYHvLgvkpyDklAyrPUut7vEZdw1v L0qS3Slwo6RwoTvYSjwiNLQDH1uIy+E= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-204-npd5KtodMe2ekFOHMFQpbg-1; Mon, 28 Mar 2022 10:06:18 -0400 X-MC-Unique: npd5KtodMe2ekFOHMFQpbg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C7B292A2AD51 for ; Mon, 28 Mar 2022 14:06:17 +0000 (UTC) Received: from tapioca.home (unknown [10.40.195.83]) by smtp.corp.redhat.com (Postfix) with ESMTP id C769A1402642; Mon, 28 Mar 2022 14:06:16 +0000 (UTC) From: Victor Toso To: qemu-devel@nongnu.org Subject: [PATCH v3 07/14] qapi: fix example of UNPLUG_PRIMARY event Date: Mon, 28 Mar 2022 16:05:57 +0200 Message-Id: <20220328140604.41484-8-victortoso@redhat.com> In-Reply-To: <20220328140604.41484-1-victortoso@redhat.com> References: <20220328140604.41484-1-victortoso@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=victortoso@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.133.124; envelope-from=victortoso@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , Eric Blake , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Example output lacks mandatory member @timestamp. Provide it. Example output is not properly formatted. Fixing it by: - Adding '<-' to signalize it is receiving the data; - Breaking lines similar to the other examples. Signed-off-by: Victor Toso Reviewed-by: John Snow Reviewed-by: Markus Armbruster --- qapi/migration.json | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/qapi/migration.json b/qapi/migration.json index 18e2610e88..092a63354b 100644 --- a/qapi/migration.json +++ b/qapi/migration.json @@ -1736,7 +1736,9 @@ # Since: 4.2 # # Example: -# {"event": "UNPLUG_PRIMARY", "data": {"device-id": "hostdev0"} } +# <- { "event": "UNPLUG_PRIMARY", +# "data": { "device-id": "hostdev0" }, +# "timestamp": { "seconds": 1265044230, "microseconds": 450486 } } # ## { 'event': 'UNPLUG_PRIMARY', From patchwork Mon Mar 28 14:05:58 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Victor Toso X-Patchwork-Id: 12793678 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5A805C433EF for ; Mon, 28 Mar 2022 14:26:15 +0000 (UTC) Received: from localhost ([::1]:47274 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nYqJy-00005F-Cx for qemu-devel@archiver.kernel.org; Mon, 28 Mar 2022 10:26:14 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41654) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nYq0l-0006kk-Aj for qemu-devel@nongnu.org; Mon, 28 Mar 2022 10:06:23 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:39382) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nYq0j-0005IX-Ng for qemu-devel@nongnu.org; Mon, 28 Mar 2022 10:06:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648476381; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IPQgd+Dj3pVYdKgKRR+ErYN5s6FYEfNPg/vxvxQNJgw=; b=GCO6ADrqYP83JBQLUPJ2YQUi8mPeXS3/yQJmg0AvEci+zQGCq3KVTBocgDP2zDsSnwFMw6 +6BKTQjOdXxcLLXwWLGf346a+HS3rex2IGAmbHk7XXMcXfgv/4XFVtaQmFHuSExrCoVZ+W PQad/u9T2uPftdHTKxVV1MGMxXizNuY= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-491-gNpyVzWLM1eqvoZl5-kSlw-1; Mon, 28 Mar 2022 10:06:19 -0400 X-MC-Unique: gNpyVzWLM1eqvoZl5-kSlw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2BAD3811E83 for ; Mon, 28 Mar 2022 14:06:19 +0000 (UTC) Received: from tapioca.home (unknown [10.40.195.83]) by smtp.corp.redhat.com (Postfix) with ESMTP id 21AA31402642; Mon, 28 Mar 2022 14:06:17 +0000 (UTC) From: Victor Toso To: qemu-devel@nongnu.org Subject: [PATCH v3 08/14] qapi: fix example of FAILOVER_NEGOTIATED event Date: Mon, 28 Mar 2022 16:05:58 +0200 Message-Id: <20220328140604.41484-9-victortoso@redhat.com> In-Reply-To: <20220328140604.41484-1-victortoso@redhat.com> References: <20220328140604.41484-1-victortoso@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=victortoso@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.129.124; envelope-from=victortoso@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , Eric Blake , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Example output lacks mandatory member @timestamp. Provide it. Event's documentation is not properly formatted. Fix it by: - Adding @ to "device-id" - Adding extra line for "Since" section Signed-off-by: Victor Toso Reviewed-by: John Snow Reviewed-by: Markus Armbruster --- qapi/net.json | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/qapi/net.json b/qapi/net.json index 7fab2e7cd8..0d4578bd07 100644 --- a/qapi/net.json +++ b/qapi/net.json @@ -685,13 +685,15 @@ # Failover primary devices which were hidden (not hotplugged when requested) # before will now be hotplugged by the virtio-net standby device. # -# device-id: QEMU device id of the unplugged device +# @device-id: QEMU device id of the unplugged device +# # Since: 4.2 # # Example: # # <- { "event": "FAILOVER_NEGOTIATED", -# "data": "net1" } +# "data": { "device-id": "net1" }, +# "timestamp": { "seconds": 1368697518, "microseconds": 326866 } } # ## { 'event': 'FAILOVER_NEGOTIATED', From patchwork Mon Mar 28 14:05:59 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Victor Toso X-Patchwork-Id: 12793679 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 06E4AC433F5 for ; Mon, 28 Mar 2022 14:26:17 +0000 (UTC) Received: from localhost ([::1]:47370 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nYqJz-0000Ak-Q3 for qemu-devel@archiver.kernel.org; Mon, 28 Mar 2022 10:26:16 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41684) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nYq0n-0006rE-EL for qemu-devel@nongnu.org; Mon, 28 Mar 2022 10:06:25 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:27934) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nYq0l-0005It-RE for qemu-devel@nongnu.org; Mon, 28 Mar 2022 10:06:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648476383; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=N83hhQ7B0IfZePi1X+O71YR3AsxmIX82lmxy7qxC/PU=; b=FggNhopMge/1vrxFSgAAoHHRhy+Lygqjxo66VucLdzyfuKn+QBLjPnCcni6CaFkQVUhkiv ky87oaL0wxkb8vbmEMIUYF3A4bMWkJ2i++ysdmuoD8lJGAr268JFKSaROEVzO+ggqcJWUX WVMyuhnYKBuuAVXmPEv/hbr39BQZaLI= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-553-IDwD-_9KP_uZumUG_HWpfg-1; Mon, 28 Mar 2022 10:06:20 -0400 X-MC-Unique: IDwD-_9KP_uZumUG_HWpfg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 961321C0E340 for ; Mon, 28 Mar 2022 14:06:20 +0000 (UTC) Received: from tapioca.home (unknown [10.40.195.83]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7A2161400B19; Mon, 28 Mar 2022 14:06:19 +0000 (UTC) From: Victor Toso To: qemu-devel@nongnu.org Subject: [PATCH v3 09/14] qapi: fix examples: SHUTDOWN and RESET events Date: Mon, 28 Mar 2022 16:05:59 +0200 Message-Id: <20220328140604.41484-10-victortoso@redhat.com> In-Reply-To: <20220328140604.41484-1-victortoso@redhat.com> References: <20220328140604.41484-1-victortoso@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=victortoso@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.129.124; envelope-from=victortoso@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , Eric Blake , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Example output lacks mandatory member @reason. Provide it. Signed-off-by: Victor Toso Reviewed-by: John Snow Reviewed-by: Markus Armbruster --- qapi/run-state.json | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/qapi/run-state.json b/qapi/run-state.json index 43d66d700f..1b9f64c9cd 100644 --- a/qapi/run-state.json +++ b/qapi/run-state.json @@ -150,7 +150,8 @@ # # Example: # -# <- { "event": "SHUTDOWN", "data": { "guest": true }, +# <- { "event": "SHUTDOWN", +# "data": { "guest": true, "reason": "guest-shutdown" }, # "timestamp": { "seconds": 1267040730, "microseconds": 682951 } } # ## @@ -188,7 +189,8 @@ # # Example: # -# <- { "event": "RESET", "data": { "guest": false }, +# <- { "event": "RESET", +# "data": { "guest": false, "reason": "guest-reset" }, # "timestamp": { "seconds": 1267041653, "microseconds": 9518 } } # ## From patchwork Mon Mar 28 14:06:00 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Victor Toso X-Patchwork-Id: 12793681 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6D795C433EF for ; Mon, 28 Mar 2022 14:29:36 +0000 (UTC) Received: from localhost ([::1]:53882 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nYqND-0004it-7b for qemu-devel@archiver.kernel.org; Mon, 28 Mar 2022 10:29:35 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41702) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nYq0o-0006um-T7 for qemu-devel@nongnu.org; Mon, 28 Mar 2022 10:06:27 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:46790) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nYq0m-0005J0-Jm for qemu-devel@nongnu.org; Mon, 28 Mar 2022 10:06:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648476384; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h/lGreUdaPtAmH56gi46C/KXzFFw9GCJcVumtSRsGQs=; b=L8cMWBwrUVe2BWIJ0rtP5zpy7XO6aYFZWpvnTarS+dxy6EErPgABL1djGHfyO97lCamIOD SqkCHjRomkwJtSW3O7XYkVLZHB/lY/n2P4izVo279SpWC26abZuTrNu5RRC8Z1KcncYfjQ kVcN5w95Ku3Jr9u3ozpPDBFqju3C8yw= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-531-YoKWFupTMuSOGyvtH1iXMA-1; Mon, 28 Mar 2022 10:06:22 -0400 X-MC-Unique: YoKWFupTMuSOGyvtH1iXMA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3CFC23803502 for ; Mon, 28 Mar 2022 14:06:22 +0000 (UTC) Received: from tapioca.home (unknown [10.40.195.83]) by smtp.corp.redhat.com (Postfix) with ESMTP id 015951402642; Mon, 28 Mar 2022 14:06:20 +0000 (UTC) From: Victor Toso To: qemu-devel@nongnu.org Subject: [PATCH v3 10/14] qapi: run-state examples: add missing @timestamp Date: Mon, 28 Mar 2022 16:06:00 +0200 Message-Id: <20220328140604.41484-11-victortoso@redhat.com> In-Reply-To: <20220328140604.41484-1-victortoso@redhat.com> References: <20220328140604.41484-1-victortoso@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=victortoso@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.129.124; envelope-from=victortoso@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , Eric Blake , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" The changed examples were lacking mandatory member @timestamp. Provide it. Signed-off-by: Victor Toso Reviewed-by: John Snow Reviewed-by: Markus Armbruster --- qapi/run-state.json | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/qapi/run-state.json b/qapi/run-state.json index 1b9f64c9cd..7f1c788c4e 100644 --- a/qapi/run-state.json +++ b/qapi/run-state.json @@ -426,7 +426,8 @@ # Example: # # <- { "event": "GUEST_PANICKED", -# "data": { "action": "pause" } } +# "data": { "action": "pause" }, +# "timestamp": { "seconds": 1648245231, "microseconds": 900001 } } # ## { 'event': 'GUEST_PANICKED', @@ -446,7 +447,8 @@ # Example: # # <- { "event": "GUEST_CRASHLOADED", -# "data": { "action": "run" } } +# "data": { "action": "run" }, +# "timestamp": { "seconds": 1648245259, "microseconds": 893771 } } # ## { 'event': 'GUEST_CRASHLOADED', From patchwork Mon Mar 28 14:06:01 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Victor Toso X-Patchwork-Id: 12793695 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4FEA5C433EF for ; Mon, 28 Mar 2022 14:33:53 +0000 (UTC) Received: from localhost ([::1]:34202 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nYqRM-0002Xl-7M for qemu-devel@archiver.kernel.org; Mon, 28 Mar 2022 10:33:52 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41720) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nYq0r-0006x1-8C for qemu-devel@nongnu.org; Mon, 28 Mar 2022 10:06:29 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:50405) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nYq0o-0005JC-69 for qemu-devel@nongnu.org; Mon, 28 Mar 2022 10:06:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648476385; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UJGRHXb/SAOiBjCjDgHW1waiGvkuX5QVuHcHxUCxquI=; b=VKt2khgmvkxgkvSGXaJ+5eCDvy9SMOn9Cf4blRGFqoxuKCs5YF33p3fXP3yJw+pJ67bZW9 RCTK+Ae5dnPjDNVHLyXvG/Wb4gJrpge1svuicRZPnckl3zh4qbhzlGf3if3XMMD7G+sY12 IjdZmYNN5J7ySNgHCJCgOH9kNqPnex0= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-593-zqcDYLT0NHCIdyIf49w-Ag-1; Mon, 28 Mar 2022 10:06:24 -0400 X-MC-Unique: zqcDYLT0NHCIdyIf49w-Ag-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DA773833960 for ; Mon, 28 Mar 2022 14:06:23 +0000 (UTC) Received: from tapioca.home (unknown [10.40.195.83]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9D1701400B19; Mon, 28 Mar 2022 14:06:22 +0000 (UTC) From: Victor Toso To: qemu-devel@nongnu.org Subject: [PATCH v3 11/14] qapi: fix example of MEMORY_FAILURE Date: Mon, 28 Mar 2022 16:06:01 +0200 Message-Id: <20220328140604.41484-12-victortoso@redhat.com> In-Reply-To: <20220328140604.41484-1-victortoso@redhat.com> References: <20220328140604.41484-1-victortoso@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=victortoso@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.129.124; envelope-from=victortoso@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , Eric Blake , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Example output lacks mandatory member @timestamp. Provide it. While @flags is an optional member, if it is defined then all its members should be include. For that reason, we add @recursive member. Minor: Change quotes from '' to "" in @action-required member. Signed-off-by: Victor Toso Reviewed-by: John Snow Reviewed-by: Markus Armbruster --- qapi/run-state.json | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/qapi/run-state.json b/qapi/run-state.json index 7f1c788c4e..8124220bd9 100644 --- a/qapi/run-state.json +++ b/qapi/run-state.json @@ -571,7 +571,9 @@ # <- { "event": "MEMORY_FAILURE", # "data": { "recipient": "hypervisor", # "action": "fatal", -# "flags": { 'action-required': false } } +# "flags": { "action-required": false, +# "recursive": false } }, +# "timestamp": { "seconds": 1267061043, "microseconds": 959568 } } # ## { 'event': 'MEMORY_FAILURE', From patchwork Mon Mar 28 14:06:02 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Victor Toso X-Patchwork-Id: 12793726 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D76BEC433F5 for ; Mon, 28 Mar 2022 14:41:34 +0000 (UTC) Received: from localhost ([::1]:51050 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nYqYn-0005l8-Uw for qemu-devel@archiver.kernel.org; Mon, 28 Mar 2022 10:41:33 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41738) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nYq0t-0006zn-9Q for qemu-devel@nongnu.org; Mon, 28 Mar 2022 10:06:31 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:33929) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nYq0q-0005JQ-Tx for qemu-devel@nongnu.org; Mon, 28 Mar 2022 10:06:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648476387; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QxhRTGBKhMw2+7cpgg3oKH+o84eve0BuZ7N4wOpSK8I=; b=QCq/fyrt1EPQ81Ajilq49IpLBjIfEqrazZEJdcfp4BXk0xGJMvZk9Q7oEZw/NYoeYjCTFS 437GQJnwUVw8tgQ5xX3aHH1Nvi5GuZIXLmaOTHGZrpIeFIpkRm7+9462ArmguPVY8TGfix CJVmNVdSWh1OHQ5FkiJeGgYegpy4b5k= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-179-AEOcpkQ7NiqwPtgFxUiDgQ-1; Mon, 28 Mar 2022 10:06:25 -0400 X-MC-Unique: AEOcpkQ7NiqwPtgFxUiDgQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 997E4899EC1 for ; Mon, 28 Mar 2022 14:06:25 +0000 (UTC) Received: from tapioca.home (unknown [10.40.195.83]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5EA01140240A; Mon, 28 Mar 2022 14:06:24 +0000 (UTC) From: Victor Toso To: qemu-devel@nongnu.org Subject: [PATCH v3 12/14] qapi: ui examples: add missing @websocket member Date: Mon, 28 Mar 2022 16:06:02 +0200 Message-Id: <20220328140604.41484-13-victortoso@redhat.com> In-Reply-To: <20220328140604.41484-1-victortoso@redhat.com> References: <20220328140604.41484-1-victortoso@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=victortoso@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.129.124; envelope-from=victortoso@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , Eric Blake , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" The examples were missing mandatory member @websocket. Provide it. Signed-off-by: Victor Toso Reviewed-by: John Snow Reviewed-by: Markus Armbruster --- qapi/ui.json | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/qapi/ui.json b/qapi/ui.json index 664da9e462..a810ed680c 100644 --- a/qapi/ui.json +++ b/qapi/ui.json @@ -710,10 +710,10 @@ # # <- { "event": "VNC_CONNECTED", # "data": { -# "server": { "auth": "sasl", "family": "ipv4", +# "server": { "auth": "sasl", "family": "ipv4", "websocket": false, # "service": "5901", "host": "0.0.0.0" }, # "client": { "family": "ipv4", "service": "58425", -# "host": "127.0.0.1" } }, +# "host": "127.0.0.1", "websocket": false } }, # "timestamp": { "seconds": 1262976601, "microseconds": 975795 } } # ## @@ -738,9 +738,9 @@ # # <- { "event": "VNC_INITIALIZED", # "data": { -# "server": { "auth": "sasl", "family": "ipv4", +# "server": { "auth": "sasl", "family": "ipv4", "websocket": false, # "service": "5901", "host": "0.0.0.0"}, -# "client": { "family": "ipv4", "service": "46089", +# "client": { "family": "ipv4", "service": "46089", "websocket": false, # "host": "127.0.0.1", "sasl_username": "luiz" } }, # "timestamp": { "seconds": 1263475302, "microseconds": 150772 } } # @@ -765,9 +765,9 @@ # # <- { "event": "VNC_DISCONNECTED", # "data": { -# "server": { "auth": "sasl", "family": "ipv4", +# "server": { "auth": "sasl", "family": "ipv4", "websocket": false, # "service": "5901", "host": "0.0.0.0" }, -# "client": { "family": "ipv4", "service": "58425", +# "client": { "family": "ipv4", "service": "58425", "websocket": false, # "host": "127.0.0.1", "sasl_username": "luiz" } }, # "timestamp": { "seconds": 1262976601, "microseconds": 975795 } } # From patchwork Mon Mar 28 14:06:03 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Victor Toso X-Patchwork-Id: 12793683 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 14F4FC433EF for ; Mon, 28 Mar 2022 14:30:43 +0000 (UTC) Received: from localhost ([::1]:56012 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nYqOE-0006DS-Po for qemu-devel@archiver.kernel.org; Mon, 28 Mar 2022 10:30:38 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41752) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nYq0w-00070f-Af for qemu-devel@nongnu.org; Mon, 28 Mar 2022 10:06:34 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:33864) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nYq0t-0005Jd-09 for qemu-devel@nongnu.org; Mon, 28 Mar 2022 10:06:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648476389; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9eoAeMd6HHzO45er7Yoq7rBj0fzq4orPvP/vB6ylmo4=; b=UhkZosUuJKy8TVxGBRTvD83ioy9k+nqTgcKTcGX3vx17rNfA9PqHzge4phzjZ6yRSAgoQG qOuhKhLwgkXtcKm48F92mygRnFkiQT4oLeA3q9jqIYxYbqNi81F3qmieZ6AofSjOIfdKKi 4J5sittfXnEr3yPaJsSbjLp01nD9lPw= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-617-9wksWD7pN3qpMyH4FE9qyg-1; Mon, 28 Mar 2022 10:06:27 -0400 X-MC-Unique: 9wksWD7pN3qpMyH4FE9qyg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 71557899EC1 for ; Mon, 28 Mar 2022 14:06:27 +0000 (UTC) Received: from tapioca.home (unknown [10.40.195.83]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4B37B140241F; Mon, 28 Mar 2022 14:06:25 +0000 (UTC) From: Victor Toso To: qemu-devel@nongnu.org Subject: [PATCH v3 13/14] qapi: fix example of ACPI_DEVICE_OST event Date: Mon, 28 Mar 2022 16:06:03 +0200 Message-Id: <20220328140604.41484-14-victortoso@redhat.com> In-Reply-To: <20220328140604.41484-1-victortoso@redhat.com> References: <20220328140604.41484-1-victortoso@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=victortoso@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.129.124; envelope-from=victortoso@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , Eric Blake , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Example output lacks mandatory member @timestamp. Provide it. Event's @data member is missing @info object. Provide it. Signed-off-by: Victor Toso Reviewed-by: John Snow Reviewed-by: Markus Armbruster --- qapi/acpi.json | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/qapi/acpi.json b/qapi/acpi.json index 51f0d55db7..d148f6db9f 100644 --- a/qapi/acpi.json +++ b/qapi/acpi.json @@ -133,8 +133,9 @@ # Example: # # <- { "event": "ACPI_DEVICE_OST", -# "data": { "device": "d1", "slot": "0", -# "slot-type": "DIMM", "source": 1, "status": 0 } } +# "data": { "info": { "device": "d1", "slot": "0", +# "slot-type": "DIMM", "source": 1, "status": 0 } }, +# "timestamp": { "seconds": 1265044230, "microseconds": 450486 } } # ## { 'event': 'ACPI_DEVICE_OST', From patchwork Mon Mar 28 14:06:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Victor Toso X-Patchwork-Id: 12793727 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 82F61C433F5 for ; Mon, 28 Mar 2022 14:44:28 +0000 (UTC) Received: from localhost ([::1]:57464 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nYqbb-00022V-A2 for qemu-devel@archiver.kernel.org; Mon, 28 Mar 2022 10:44:27 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41768) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nYq0z-00072W-7m for qemu-devel@nongnu.org; Mon, 28 Mar 2022 10:06:37 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:53266) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nYq0w-0005K5-RC for qemu-devel@nongnu.org; Mon, 28 Mar 2022 10:06:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648476394; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Nyk5gYlgJTerRUpjDFPSPIjgzeE246QWos6H8jgskjo=; b=fpxpCT9BFx1Hpgh0ekqBHFStOtST1enNf5CWcbotvYB7gCCVh5Q+hSf/dmCOGZVjPMpi8G Q/nhoRxKiJO+kPxYYaY8pVGcZOy7hFoS7FKuttwNMurE8g9J/T8VaKTDFoCKk2WRmDjO0I nsP3JXP5yYWrhhOQcMUH0BDJgPVRF4Q= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-63-W7WIFnpQPVevcxgFqxrlLA-1; Mon, 28 Mar 2022 10:06:29 -0400 X-MC-Unique: W7WIFnpQPVevcxgFqxrlLA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1AF1E811E76 for ; Mon, 28 Mar 2022 14:06:29 +0000 (UTC) Received: from tapioca.home (unknown [10.40.195.83]) by smtp.corp.redhat.com (Postfix) with ESMTP id D3BAF1402642; Mon, 28 Mar 2022 14:06:27 +0000 (UTC) From: Victor Toso To: qemu-devel@nongnu.org Subject: [PATCH v3 14/14] qapi: fix example of dump-guest-memory Date: Mon, 28 Mar 2022 16:06:04 +0200 Message-Id: <20220328140604.41484-15-victortoso@redhat.com> In-Reply-To: <20220328140604.41484-1-victortoso@redhat.com> References: <20220328140604.41484-1-victortoso@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=victortoso@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=170.10.129.124; envelope-from=victortoso@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Snow , Eric Blake , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Example output lacks mandatory member @paging. Provide it. Signed-off-by: Victor Toso Reviewed-by: John Snow Reviewed-by: Markus Armbruster --- qapi/dump.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qapi/dump.json b/qapi/dump.json index 9119c82b14..29441af9d8 100644 --- a/qapi/dump.json +++ b/qapi/dump.json @@ -83,7 +83,7 @@ # Example: # # -> { "execute": "dump-guest-memory", -# "arguments": { "protocol": "fd:dump" } } +# "arguments": { "paging": false, "protocol": "fd:dump" } } # <- { "return": {} } # ##