From patchwork Thu Mar 31 01:58:18 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xiaomeng Tong X-Patchwork-Id: 12796650 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1045C433EF for ; Thu, 31 Mar 2022 01:58:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346569AbiCaCAM (ORCPT ); Wed, 30 Mar 2022 22:00:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50036 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241393AbiCaCAM (ORCPT ); Wed, 30 Mar 2022 22:00:12 -0400 Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 152A46405; Wed, 30 Mar 2022 18:58:25 -0700 (PDT) Received: by mail-pj1-x1029.google.com with SMTP id d30so5575431pjk.0; Wed, 30 Mar 2022 18:58:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id; bh=qbepWknWAIx3U4lZWaC4n3p6Chx94Z3VQB0ZwMzdJMk=; b=h7ijxiAvouZL8iZgZWu7eaWS/RH+wjTdZKm3b6c99deOb8Vnal6qnndGjq9ibGkEnJ m9Vrbd1b0gMK97gnesAM2/CwID3OiuHbPWy36wLugfDoXSHgs8Lcw2FehNNJaqRPuDEK FtunEwqdsp7eV/dPA9PRHnmXTZr6PodRRVaelzn8v3skl4IRxVZBgp7ekYMIDNbpq5xH oW+Lh+Z8WTP9K3u5EdM4poos1UFzOOinTi9IuTJK7OJGhvV9HSFbEiQROjMGru46qDeU eP3uznYuhzi9L2MnekolSo09RxyOIlI8NcpnGPYjjIA0mHGeVeuZ4B7SXjtRyWInEG27 fhkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=qbepWknWAIx3U4lZWaC4n3p6Chx94Z3VQB0ZwMzdJMk=; b=N6Igq6muFlVekHV8KEUmH6j+roKR8zaNsfJiAqIM8ytUUHfQQkLksSFnmpxIv9LN/x ZUb0CZ3FVDNIuiDhh6BI8PCspgOlCEyFnaLIUzHexGtVQOqw0qyl/YTrq6OS1Q7LPEL/ Ghm9MN5UOnSXegxV10xq7WWaS1nTiUEZ+ON86eMo2AfWkxF4tSPkW6AQ7u6vrCWwMfoz eX5yLCx2FbJqcETMTjtGjvp5+YOCGdNfl2sxeUnBxAHQffu2dKS/urVbvKiP0bOQHegW XU3IqCbCeUPXOwGg7wisZu7oC0PbTPivIG9FTGWKOczK1a2VkIAgf1yrxbCqXlfnFM3L iiNg== X-Gm-Message-State: AOAM532wr9876s5JZCxNuBa2B4zWtdRpawhVlb3Jl7Iwe0d3sjxqFQ41 hdyT3PPvnLgwBcTCOecySiQ= X-Google-Smtp-Source: ABdhPJy2BE5OpsL1Gb6vbNqQBQaGTpQazhKtwLsJneD7r49h5PoVSruOJV6pWM7b9DonkRNprQd+gQ== X-Received: by 2002:a17:903:32ce:b0:155:db89:e3ee with SMTP id i14-20020a17090332ce00b00155db89e3eemr2589769plr.164.1648691904467; Wed, 30 Mar 2022 18:58:24 -0700 (PDT) Received: from ubuntu.huawei.com ([119.3.119.18]) by smtp.googlemail.com with ESMTPSA id w13-20020a17090a5e0d00b001c7d4099670sm7568639pjf.28.2022.03.30.18.58.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Mar 2022 18:58:23 -0700 (PDT) From: Xiaomeng Tong To: vireshk@kernel.org, nm@ti.com, sboyd@kernel.org Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Xiaomeng Tong Subject: [PATCH] opp: use list iterator only inside the loop Date: Thu, 31 Mar 2022 09:58:18 +0800 Message-Id: <20220331015818.28045-1-xiam0nd.tong@gmail.com> X-Mailer: git-send-email 2.17.1 Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org dev = new_dev->dev; As discussed before, we should avoid to use a list iterator variable outside the loop which is considered harmful[1]. In this case, use a new variable 'iter' as the list iterator, while use the old variable 'new_dev' as a dedicated pointer to point to the found entry. [1]: https://lkml.org/lkml/2022/2/17/1032 Signed-off-by: Xiaomeng Tong --- drivers/opp/debugfs.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/opp/debugfs.c b/drivers/opp/debugfs.c index 596c185b5dda..a4476985e4ce 100644 --- a/drivers/opp/debugfs.c +++ b/drivers/opp/debugfs.c @@ -187,14 +187,19 @@ void opp_debug_register(struct opp_device *opp_dev, struct opp_table *opp_table) static void opp_migrate_dentry(struct opp_device *opp_dev, struct opp_table *opp_table) { - struct opp_device *new_dev; + struct opp_device *new_dev = NULL, *iter; const struct device *dev; struct dentry *dentry; /* Look for next opp-dev */ - list_for_each_entry(new_dev, &opp_table->dev_list, node) - if (new_dev != opp_dev) + list_for_each_entry(iter, &opp_table->dev_list, node) + if (iter != opp_dev) { + new_dev = iter; break; + } + + if (!new_dev) + return; /* new_dev is guaranteed to be valid here */ dev = new_dev->dev;