From patchwork Thu Mar 31 03:56:17 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: CGEL X-Patchwork-Id: 12796724 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BB67C433F5 for ; Thu, 31 Mar 2022 03:57:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 89FC38D0001; Wed, 30 Mar 2022 23:57:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 84EFA6B0075; Wed, 30 Mar 2022 23:57:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6EF248D0001; Wed, 30 Mar 2022 23:57:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0073.hostedemail.com [216.40.44.73]) by kanga.kvack.org (Postfix) with ESMTP id 5CF5F6B0074 for ; Wed, 30 Mar 2022 23:57:00 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 0C6DA8249980 for ; Thu, 31 Mar 2022 03:57:00 +0000 (UTC) X-FDA: 79303320600.19.36BBF35 Received: from mail-qk1-f182.google.com (mail-qk1-f182.google.com [209.85.222.182]) by imf29.hostedemail.com (Postfix) with ESMTP id 768A212000E for ; Thu, 31 Mar 2022 03:56:59 +0000 (UTC) Received: by mail-qk1-f182.google.com with SMTP id p25so18819713qkj.10 for ; Wed, 30 Mar 2022 20:56:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=tYlHPxM0iDi5VXE98hgeozahqYJk78JaFFeV+qzNw5U=; b=mTmT7+N63PXuIwB75+CKvFI6cw/jzFICsKFlmrX98DCY4KgVobDxkUkLrPbILjWEVd zOpsJzohasYTU2cri3mhczLOHO+85IFJWAcIzlnZ8sYbVwKoGAyN3ZrI0vtWoa7Qu3eu CsqMCtZFWjlutPRNC7lKg6mZUe8Sh5MDsmm5GAacxLBCKifK/EA4n2cFQBko12jzZ9sS WKQUNIcMTTE9y9FtrLpqhMIlKbYvWdq1U+ww/1au0hwzkHBamg7+Phf1Jd5WuYcisENx lCO2kL34hCyKaR+8Rf8wpTYtiFvSRdvzMZ6EfRXAZk+xbijJO3mI2cpMPxQ0aZw2TTYf kybg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=tYlHPxM0iDi5VXE98hgeozahqYJk78JaFFeV+qzNw5U=; b=rKBartC5im4SiF7oClSDZehh9gy5+01dTqH6lyAp9RN1wcvw8bN+Ctph26ULp853BJ L1L9uq15WyzmOt2JGrWXjJIn276QuZ8vaOtcQoVPJw0fPGWaeiI0J6ucVauompFxlPdE vvf3VQDePffk4Ji7tqfd6iOA+XjQ7evSl66XlF2vlm35wYlYA9zqcPJHqwFEZwn4AzEk QMcp8DSDsNfEJ3irKQz83RizhhRuerCBJap1dKbgJzAd+P+sNAaGTLGCzR3xggU4e4BC 76wcpBuUDaPkrdfrIoMS0hKUFSVbOj8HGaQsfEKCZbyUuBUwJyDlM0KR6/qTCBYCTsOJ dvpQ== X-Gm-Message-State: AOAM532XLSzAthltTksrrziMKNTpZ81FXS6oG52W6wuwfst8q4//070c qT+3b5Z+tg1XxxrUwYi5PAQ= X-Google-Smtp-Source: ABdhPJzyPrz0p+L/ALJneQJkAZo6ZUHwvs4kf6iDO0DACiqXPcs8bbEYZ5Igo5IyJWR4z4os6/CMDA== X-Received: by 2002:a37:9503:0:b0:67e:977:9ff6 with SMTP id x3-20020a379503000000b0067e09779ff6mr2101575qkd.10.1648699018774; Wed, 30 Mar 2022 20:56:58 -0700 (PDT) Received: from localhost.localdomain ([193.203.214.57]) by smtp.gmail.com with ESMTPSA id f17-20020ac87f11000000b002e1e831366asm18698404qtk.77.2022.03.30.20.56.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Mar 2022 20:56:57 -0700 (PDT) From: cgel.zte@gmail.com X-Google-Original-From: yang.yang29@zte.com.cn To: akpm@linux-foundation.org, david@redhat.com, willy@infradead.org Cc: corbet@lwn.net, yang.yang29@zte.com.cn, yang.shi@linux.alibaba.com, dave.hansen@linux.intel.com, saravanand@fb.com, minchan@kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, jhubbard@nvidia.com, xu xin , Ran Xiaokai Subject: [PATCH v5] mm/vmstat: add events for ksm cow Date: Thu, 31 Mar 2022 03:56:17 +0000 Message-Id: <20220331035616.2390805-1-yang.yang29@zte.com.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=mTmT7+N6; spf=pass (imf29.hostedemail.com: domain of cgel.zte@gmail.com designates 209.85.222.182 as permitted sender) smtp.mailfrom=cgel.zte@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Stat-Signature: wx4jwr8roxf4gctfuya7dpbgez6ws3ct X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 768A212000E X-HE-Tag: 1648699019-564188 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Yang Yang Users may use ksm by calling madvise(, , MADV_MERGEABLE) when they want to save memory, it's a tradeoff by suffering delay on ksm cow. Users can get to know how much memory ksm saved by reading /sys/kernel/mm/ksm/pages_sharing, but they don't know what's the costs of ksm cow, and this is important of some delay sensitive tasks. So add ksm cow events to help users evaluate whether or how to use ksm. Also update Documentation/admin-guide/mm/ksm.rst with new added events. Signed-off-by: Yang Yang Reviewed-by: David Hildenbrand Reviewed-by: xu xin Reviewed-by: Ran Xiaokai --- v2: - fix compile error when CONFIG_KSM is not set v3: - delete KSM_COW_FAIL event v4: - modify /Documentation/admin-guide/mm/ksm.rst. And let cow_ksm before - ksm_swpin_copy, so if new cow_* event could add before cow_ksm. v5: - fix compile error when CONFIG_SWAP is not set --- Documentation/admin-guide/mm/ksm.rst | 18 ++++++++++++++++++ include/linux/vm_event_item.h | 3 +++ mm/memory.c | 4 ++++ mm/vmstat.c | 3 +++ 4 files changed, 28 insertions(+) diff --git a/Documentation/admin-guide/mm/ksm.rst b/Documentation/admin-guide/mm/ksm.rst index 97d816791aca..b244f0202a03 100644 --- a/Documentation/admin-guide/mm/ksm.rst +++ b/Documentation/admin-guide/mm/ksm.rst @@ -184,6 +184,24 @@ The maximum possible ``pages_sharing/pages_shared`` ratio is limited by the ``max_page_sharing`` tunable. To increase the ratio ``max_page_sharing`` must be increased accordingly. +Monitoring KSM events +===================== + +There are some counters in /proc/vmstat that may be used to monitor KSM events. +KSM might help save memory, it's a tradeoff by may suffering delay on KSM COW +or on swapping in copy. Those events could help users evaluate whether or how +to use KSM. For example, if cow_ksm increases too fast, user may decrease the +range of madvise(, , MADV_MERGEABLE). + +cow_ksm + is incremented every time a KSM page triggers copy on write (COW) + when users try to write to a KSM page, we have to make a copy. + +ksm_swpin_copy + is incremented every time a KSM page is copied when swapping in + note that KSM page might be copied when swapping in because do_swap_page() + cannot do all the locking needed to reconstitute a cross-anon_vma KSM page. + -- Izik Eidus, Hugh Dickins, 17 Nov 2009 diff --git a/include/linux/vm_event_item.h b/include/linux/vm_event_item.h index 16a0a4fd000b..e83967e4c20e 100644 --- a/include/linux/vm_event_item.h +++ b/include/linux/vm_event_item.h @@ -133,6 +133,9 @@ enum vm_event_item { PGPGIN, PGPGOUT, PSWPIN, PSWPOUT, KSM_SWPIN_COPY, #endif #endif +#ifdef CONFIG_KSM + COW_KSM, +#endif #ifdef CONFIG_X86 DIRECT_MAP_LEVEL2_SPLIT, DIRECT_MAP_LEVEL3_SPLIT, diff --git a/mm/memory.c b/mm/memory.c index 4111f97c91a0..12925ceaf745 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -3339,6 +3339,10 @@ static vm_fault_t do_wp_page(struct vm_fault *vmf) get_page(vmf->page); pte_unmap_unlock(vmf->pte, vmf->ptl); +#ifdef CONFIG_KSM + if (PageKsm(vmf->page)) + count_vm_event(COW_KSM); +#endif return wp_page_copy(vmf); } diff --git a/mm/vmstat.c b/mm/vmstat.c index d5cc8d739fac..79015f144b15 100644 --- a/mm/vmstat.c +++ b/mm/vmstat.c @@ -1392,6 +1392,9 @@ const char * const vmstat_text[] = { "ksm_swpin_copy", #endif #endif +#ifdef CONFIG_KSM + "cow_ksm", +#endif #ifdef CONFIG_X86 "direct_map_level2_splits", "direct_map_level3_splits",