From patchwork Thu Mar 31 12:37:28 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florent Fourcot X-Patchwork-Id: 12797055 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20608C433EF for ; Thu, 31 Mar 2022 12:44:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236265AbiCaMqd (ORCPT ); Thu, 31 Mar 2022 08:46:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59406 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236261AbiCaMqb (ORCPT ); Thu, 31 Mar 2022 08:46:31 -0400 Received: from olfflo.fourcot.fr (fourcot.fr [217.70.191.14]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6DAE6210471 for ; Thu, 31 Mar 2022 05:44:43 -0700 (PDT) From: Florent Fourcot To: netdev@vger.kernel.org Cc: Florent Fourcot , Brian Baboch Subject: [PATCH net-next] rtnetlink: enable alt_ifname for setlink/newlink Date: Thu, 31 Mar 2022 14:37:28 +0200 Message-Id: <20220331123728.7267-1-florent.fourcot@wifirst.fr> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org buffer is always valid when called by setlink/newlink, but contains only empty string when IFLA_IFNAME is not given. So IFLA_ALT_IFNAME is always ignored Fixes: 76c9ac0ee878 ("net: rtnetlink: add possibility to use alternative names as message handle") Signed-off-by: Florent Fourcot Signed-off-by: Brian Baboch --- net/core/rtnetlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index 3313419bbcba..613065a53b34 100644 --- a/net/core/rtnetlink.c +++ b/net/core/rtnetlink.c @@ -2979,7 +2979,7 @@ static struct net_device *rtnl_dev_get(struct net *net, { char buffer[ALTIFNAMSIZ]; - if (!ifname) { + if (!ifname || !ifname[0]) { ifname = buffer; if (ifname_attr) nla_strscpy(ifname, ifname_attr, IFNAMSIZ);