From patchwork Sun Apr 3 05:16:37 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nava kishore Manne X-Patchwork-Id: 12799459 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5DEDC433FE for ; Sun, 3 Apr 2022 05:18:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236197AbiDCFSt (ORCPT ); Sun, 3 Apr 2022 01:18:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59560 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229566AbiDCFSs (ORCPT ); Sun, 3 Apr 2022 01:18:48 -0400 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2042.outbound.protection.outlook.com [40.107.94.42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4326A36E03; Sat, 2 Apr 2022 22:16:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YTizUN0mVLqqmDXGRU+S81uuE0izu9abJG2axRLOof11SQx3gr+TmwvQ/eY0DVnMMAGf1aAS9FNzQJucDGYGBRCvSTtk24lcXRUsCcSzdmdMH+oFmH7MAEUKc0XXcrBApLJTyFye7lXl3AwkpAFkx4Ewr+Dslj9Ys9EeaKP7bpZBjJrIBp688b2y70ndwI/H8i9OKKOC1m+dG84u6QcVlIGelFhabB6JO/Ugzj2KSLrbpasclpvu42fR+K75iHxvvBA0+AqwoG3YosIdbdZhn1PKKnAF3HThFtXsajst5jE55vVqiztTDwH1HflSqnSVLLRTdl5DnDNTJn75A07XVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SA06ekR20e2oZeTaZX/BKA58rCuMnKu3rjWxe5gFLjQ=; b=MmwItFeoP+ZiUXoLLlKlpVEWxxRO/ICAN9EheB4yJZdpt/KSc87R2lCOyQJsry6o8ulfoEjsoo0Fig8aMkyCylKQMLy0AMDRvAOxoWa4eEpbxg0e/jtcIANbNxy7xAq0eNryHj297StC5xpTKI7xBNq/uZDldOBDXlkqnlcXMvKmlWkNVmd4spy0ILGD0DfARoLJwQsmF59zeRtQ4rFB087HIUNu62fr5XDnyuhDjuI9quUp6ANO1b102oD9nCwLGLlvAbY+4e6J1zCqFSnv6uiUxtfkqb0nReCvEkQwDiL/i3kgiTB2pU9dwQbZFApzbzjzEZ3hCUajrTh70qfYTA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=kernel.org smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SA06ekR20e2oZeTaZX/BKA58rCuMnKu3rjWxe5gFLjQ=; b=EiZUWII6r8MyeFIwk86zMHtUGefeghWZ0ZqU9EksaCQUfme/a4z52wpux7p3WCz2yjiDilXOLMq9vBys0aUkbOurVKjUvzKETYjorFbWQeAcPfStXEUgGhPLmvmgK/dJ1hMnioh163JvWCt0CUKc92dLepgJFo/p8X1DYTrhozI= Received: from BN6PR2001CA0022.namprd20.prod.outlook.com (2603:10b6:404:b4::32) by SJ0PR02MB7405.namprd02.prod.outlook.com (2603:10b6:a03:29f::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.30; Sun, 3 Apr 2022 05:16:53 +0000 Received: from BN1NAM02FT022.eop-nam02.prod.protection.outlook.com (2603:10b6:404:b4:cafe::2c) by BN6PR2001CA0022.outlook.office365.com (2603:10b6:404:b4::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.30 via Frontend Transport; Sun, 3 Apr 2022 05:16:53 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch01.xlnx.xilinx.com; Received: from xsj-pvapexch01.xlnx.xilinx.com (149.199.62.198) by BN1NAM02FT022.mail.protection.outlook.com (10.13.2.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5123.19 via Frontend Transport; Sun, 3 Apr 2022 05:16:53 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch01.xlnx.xilinx.com (172.19.86.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Sat, 2 Apr 2022 22:16:52 -0700 Received: from smtp.xilinx.com (172.19.127.95) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Sat, 2 Apr 2022 22:16:52 -0700 Envelope-to: git@xilinx.com, mdf@kernel.org, hao.wu@intel.com, yilun.xu@intel.com, trix@redhat.com, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Received: from [10.140.6.60] (port=54274 helo=xhdnavam40.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1nasbb-0007vd-HS; Sat, 02 Apr 2022 22:16:51 -0700 From: Nava kishore Manne To: , , , , , , , , CC: Nava kishore Manne Subject: [PATCH v3 1/5] fpga: zynq: Fix incorrect variable type Date: Sun, 3 Apr 2022 10:46:37 +0530 Message-ID: <20220403051641.3867610-2-nava.manne@xilinx.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220403051641.3867610-1-nava.manne@xilinx.com> References: <20220403051641.3867610-1-nava.manne@xilinx.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c7943ae3-4f05-4664-fefe-08da15312a54 X-MS-TrafficTypeDiagnostic: SJ0PR02MB7405:EE_ X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /6jPcWj6U+ZCUMl1JblBbN6gTkaF1zJ5gAX0WBs/Jv/BbF9vwGmOxHcSlGE58H1GeC0Vmol1RZux87fPiVovoTSObMWo5aeood1mNHl46mrGwoSBeWydx9SqewG2vNv1JTaDzOnQGXnRIrHeyfDHXjQGhLBp99uo42t2xYKffQ2aI1kNtFmoZDdVWdIT7YQxV1tApRD37xeN1TNSl/2vkKdSauMdih+evHO8wauC9x9qzFioHTJr/0KKEAl7aoeKZ6gpebTu6c2Ujmlnt/5o/wDzBPf6vROn6X2zj9B8YFyj43z2cWx7XQyO8kXKCGRUew/mgsjovDnBsZFMZ5AY1pobDU88j2XSkk3DB+DwSHArMuLMAkTJOI+CcyMNOPqHCr6QBGeFnXGh7tfQuAwZ+VIo0UJgUsPxb7Atl5x9gemTp8UUDEx7gcgOLR9L5vv/uQ6lj1K7CwhqP14D/eOiY9VA+3xioFl4RueX4k+/pJuyd5s/ZqJLvbqVkY8SeqqGhdO39Q0hzF04wjWkciGsU/OJr6CKJtBHwvNyDlWr33HLa5zBhSLD2tgB57aUeK28uLVGs3LvDAodquVhP0EirrIXuUs4X0s/yc4zyj88xSi7MoMW2hjk1kT9BcYlbKSTJaiCiD+hxZQbtuitrEF8esqbHCPwKTx8QczHly1ZdBUMaMl51MWy/kE3QPkWIUGA82hRLQQq0cBYEIOs5jBEe5yWCpEbDJV8FqMzFrMVvdc= X-Forefront-Antispam-Report: CIP:149.199.62.198;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapexch01.xlnx.xilinx.com;PTR:unknown-62-198.xilinx.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(36756003)(186003)(26005)(6666004)(7696005)(508600001)(110136005)(70586007)(5660300002)(6636002)(83380400001)(70206006)(8676002)(47076005)(4326008)(8936002)(40460700003)(36860700001)(9786002)(1076003)(426003)(2616005)(107886003)(2906002)(316002)(82310400004)(7636003)(356005)(336012)(102446001)(2101003);DIR:OUT;SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2022 05:16:53.2890 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c7943ae3-4f05-4664-fefe-08da15312a54 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: BN1NAM02FT022.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR02MB7405 Precedence: bulk List-ID: X-Mailing-List: linux-fpga@vger.kernel.org zynq_fpga_has_sync () API is expecting "u8 *" but the formal parameter that was passed is of type "const char *". fixes this issue by changing the buf type to "const char *" This patch will also update zynq_fpga_has_sync () API description to align with API functionality. Signed-off-by: Nava kishore Manne --- Changes for v2: -None. Changes for v3: - Changed arg buf type to "const char *" as suggested by Tom. drivers/fpga/zynq-fpga.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/fpga/zynq-fpga.c b/drivers/fpga/zynq-fpga.c index 426aa34c6a0d..ada07eea64bc 100644 --- a/drivers/fpga/zynq-fpga.c +++ b/drivers/fpga/zynq-fpga.c @@ -235,11 +235,11 @@ static irqreturn_t zynq_fpga_isr(int irq, void *data) return IRQ_HANDLED; } -/* Sanity check the proposed bitstream. It must start with the sync word in - * the correct byte order, and be dword aligned. The input is a Xilinx .bin - * file with every 32 bit quantity swapped. +/* Sanity check the proposed bitstream. The sync word must be found in the + * correct byte order and it should be dword aligned. The input is a + * Xilinx.bin file with every 32 bit quantity swapped. */ -static bool zynq_fpga_has_sync(const u8 *buf, size_t count) +static bool zynq_fpga_has_sync(const char *buf, size_t count) { for (; count >= 4; buf += 4, count -= 4) if (buf[0] == 0x66 && buf[1] == 0x55 && buf[2] == 0x99 && From patchwork Sun Apr 3 05:16:38 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nava kishore Manne X-Patchwork-Id: 12799460 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E37CC433F5 for ; Sun, 3 Apr 2022 05:18:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236531AbiDCFS5 (ORCPT ); Sun, 3 Apr 2022 01:18:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59768 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229566AbiDCFS4 (ORCPT ); Sun, 3 Apr 2022 01:18:56 -0400 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2072.outbound.protection.outlook.com [40.107.237.72]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6965E377E4; Sat, 2 Apr 2022 22:17:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jU1rkpFkZEtazeHfRQ2a7nWYbL1SVU8zAr0lQKfe2Mlc738yY+jhgQtmshB3LID89aosyyWqO2ReG8XRSGMkm/XMYsnt5OV0xTFG+WxHsARqRMBT2O922TbpCtC+OHLDqw7oUrVDKo2CMwHI54mrD5FhViuC+H1I+HPsfizFxc+Y/naxcCcKcnas33o9Hcp7RE+gWIjpOkhiz/AkDoQeEkMwwFouElxIIwBz33Z7Nim+TBNQk2HPYbtqLbtlW+4spBWHTWlfy7jNHqh9JoJaIeOgQkAmxDFtQdZXfWoziyQoUwXGPJQIO/k8vkhCPmVUUfT2n78IWnzZM392f7WiPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XE7hlEQ2JTlsiNShhYgWYOW7EmndVHyOKu+Vch0iGKE=; b=N7HTtakWlIu+IRXJJK1tzu3K1nGxVvkXMywPgeC9bAZbYNa7//OmienEwRC4gDoXtOMV5E8E3sKMw3kasJZRCZHVbaworhgLMhwjcJKpc4f2oFA7QIFi8P2GVCiHPTy5J+UIb6WhutI2uUaS5RjpCnmH7ubEuOHmKPa9oj8rxNY4td/uy6yRh/HjaacflbRtXbUxK4DijUM9S7R1AF6R0R5bpkGjYYkEXE7f7BYS7OWL3p+FKYZuKZusUOo4fFOrajMI9K/yb8oR/evSMWXhsZ5ZHqwZGnfmuQhA4cODAaMnG+N8g9rqQZA5PcCOYY0tPlw4hYwUBsAXKkO/s1BmUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=kernel.org smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XE7hlEQ2JTlsiNShhYgWYOW7EmndVHyOKu+Vch0iGKE=; b=jaUn1kyIwMD0N5zIcRf7IbfJ5WPC5yIcrf56In9Msx3zeG4bDBd842RGsB/VKToUbvsQjoyeLynHDvbawKOZFBgCYFFj1xHdWgQ6QuonZK/lWESepZs8LDxU/TS+DWEaCpE8QuW0Kp+4dPxijEPV/TdvA2laOujq5BbSVQvCPdg= Received: from DS7PR03CA0097.namprd03.prod.outlook.com (2603:10b6:5:3b7::12) by SA1PR02MB8495.namprd02.prod.outlook.com (2603:10b6:806:1fa::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.30; Sun, 3 Apr 2022 05:17:00 +0000 Received: from DM3NAM02FT007.eop-nam02.prod.protection.outlook.com (2603:10b6:5:3b7:cafe::90) by DS7PR03CA0097.outlook.office365.com (2603:10b6:5:3b7::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.28 via Frontend Transport; Sun, 3 Apr 2022 05:17:00 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch02.xlnx.xilinx.com; Received: from xsj-pvapexch02.xlnx.xilinx.com (149.199.62.198) by DM3NAM02FT007.mail.protection.outlook.com (10.13.4.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5123.19 via Frontend Transport; Sun, 3 Apr 2022 05:16:59 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Sat, 2 Apr 2022 22:16:56 -0700 Received: from smtp.xilinx.com (172.19.127.95) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Sat, 2 Apr 2022 22:16:56 -0700 Envelope-to: git@xilinx.com, mdf@kernel.org, hao.wu@intel.com, yilun.xu@intel.com, trix@redhat.com, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Received: from [10.140.6.60] (port=54274 helo=xhdnavam40.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1nasbg-0007vd-1b; Sat, 02 Apr 2022 22:16:56 -0700 From: Nava kishore Manne To: , , , , , , , , CC: Nava kishore Manne Subject: [PATCH v3 2/5] fpga: fix for coding style issues Date: Sun, 3 Apr 2022 10:46:38 +0530 Message-ID: <20220403051641.3867610-3-nava.manne@xilinx.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220403051641.3867610-1-nava.manne@xilinx.com> References: <20220403051641.3867610-1-nava.manne@xilinx.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 557d6abe-cfc1-42f7-fba8-08da15312e46 X-MS-TrafficTypeDiagnostic: SA1PR02MB8495:EE_ X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tcHkjpehytoovadu9oAAKjsqWK7pZ8JXiRWb163sKbeRifDgt8Qizq2KslcqY6EhlHWY/XzMzHT0Ah13OZ63ro6bkLARCnVmgvmwXqY8AYNLapSH7TMaEMF77f2Gc3XUh2GHJZcZG2T+5FqyCspcPXDRwj72C78/TqPO8uNgPusf76PmU8PGF0sMW1NimLp/V2eSGhPl7euiQ+BIAvQ4hWUsAAkwsVokSpVhZi9zmTlyuzUf+kQTvOXyPDjBvMkNsyUUwVGSgSZ4R+YfEtmDbd0IUnWW0psF+M7Ln+/TfY1Bfb1KrsxfS0qkk+jHZKKzcJqVK3VgkKDuOANg1jDn431X6/iEfAFRKKDQkAFuYjk05SQl2rbbLkyROrJP0Dw+uqRIzDXaZw5WF4pCllVqJugBwcBYNIxcLX5H/SJSCsyHhnvAdsnYHv7CEemqrNCCAdBuGeEEunwPovHGsViPHoddnCcthEc7Duf/GkxzVDRM9cxREkCNxW03H0u0ajRIOC4OM4E0dI7588P5zFCiTl7cm/vFPN53zlJLcCrf6TJmBcpa12MWNfUD8Iv4t+mE4y+SkIDKtFTs/5pCGS1bc/ysQ0D4CQqewdK6CelbPOG4xXm0x6YVmOIYB9sXsS39SnWKEIfX1+XNWikSerLSxub3q0NMojVp0gxyHDMLXzvVR/2jWfee6si9FdKWo38XrP1PFNoqzcyXiJzUXW5CeeZHJ4r9tYn11WtWXyWxLTk= X-Forefront-Antispam-Report: CIP:149.199.62.198;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapexch02.xlnx.xilinx.com;PTR:unknown-62-198.xilinx.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(8936002)(2906002)(508600001)(47076005)(83380400001)(36756003)(70586007)(70206006)(110136005)(6636002)(316002)(82310400004)(107886003)(9786002)(7636003)(426003)(336012)(186003)(26005)(4326008)(8676002)(1076003)(5660300002)(2616005)(36860700001)(6666004)(7696005)(40460700003)(356005)(102446001)(2101003);DIR:OUT;SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2022 05:16:59.9393 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 557d6abe-cfc1-42f7-fba8-08da15312e46 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: DM3NAM02FT007.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR02MB8495 Precedence: bulk List-ID: X-Mailing-List: linux-fpga@vger.kernel.org fixes the below checks reported by checkpatch.pl Lines should not end with a '(' Alignment should match open parenthesis Signed-off-by: Nava kishore Manne --- Changes for v2: -None. Changes for v3: -Fixed similar issue exists in "drivers/fpga/*". drivers/fpga/fpga-mgr.c | 4 ++-- drivers/fpga/fpga-region.c | 7 ++++--- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/fpga/fpga-mgr.c b/drivers/fpga/fpga-mgr.c index d49a9ce34568..a699cc8e2fa6 100644 --- a/drivers/fpga/fpga-mgr.c +++ b/drivers/fpga/fpga-mgr.c @@ -151,8 +151,8 @@ static int fpga_mgr_write_init_buf(struct fpga_manager *mgr, if (!mgr->mops->initial_header_size) ret = fpga_mgr_write_init(mgr, info, NULL, 0); else - ret = fpga_mgr_write_init( - mgr, info, buf, min(mgr->mops->initial_header_size, count)); + ret = fpga_mgr_write_init(mgr, info, buf, + min(mgr->mops->initial_header_size, count)); if (ret) { dev_err(&mgr->dev, "Error preparing FPGA for writing\n"); diff --git a/drivers/fpga/fpga-region.c b/drivers/fpga/fpga-region.c index b0ac18de4885..3864bf4f8920 100644 --- a/drivers/fpga/fpga-region.c +++ b/drivers/fpga/fpga-region.c @@ -18,9 +18,10 @@ static DEFINE_IDA(fpga_region_ida); static struct class *fpga_region_class; -struct fpga_region *fpga_region_class_find( - struct device *start, const void *data, - int (*match)(struct device *, const void *)) +struct fpga_region *fpga_region_class_find(struct device *start, + const void *data, + int (*match)(struct device *, + const void *)) { struct device *dev; From patchwork Sun Apr 3 05:16:39 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nava kishore Manne X-Patchwork-Id: 12799463 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C4ADC433EF for ; Sun, 3 Apr 2022 05:19:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237197AbiDCFTI (ORCPT ); Sun, 3 Apr 2022 01:19:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59838 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236826AbiDCFTH (ORCPT ); Sun, 3 Apr 2022 01:19:07 -0400 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2040.outbound.protection.outlook.com [40.107.244.40]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E0F3C36E13; Sat, 2 Apr 2022 22:17:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AsVRNDjcdhUV/wWFEPrwB++gtGPdPWpyUo1WS0c4h9ZIY3157p1qfJUw24GYFhclnV8GTPhcnesyEkxS5d1F7PMNg78j9/lDZJpm54EHlUq6xDDufo5s3eyW3rG8a1t2PVaJS7E579+RU/XZob5zt8RkM0y3Al4Ib6BYxoDRkZlsJhyrvKI3fSWNwSMRTDFxE+aImad5F/MiYx2U9/xsI3XZysJg4mkvlH0LORSpPhK8ORiQya7yuoS7QFGFP6vuJaywycomivmtq9TMLXX67tpShLymXTW/9S5i3Hcj7Db0dGockMnsBkDJbUAhRK155mfV39Yd5A+etwDxQyPvxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uQ5GYvtegcsURwB8tmcx0w6ob90PJadJRjYGo3P/TaE=; b=WL10F5dJOzJuQAehi1RF18wBaKcRZSvJGVp9V1EeCF52RUZV2QzYyfCwMmY2sIYPvj/Itzu3r9AV4AuXQ5u0TwkHuZUDzfr+a775u9RnnHhTUl2WgmneGoEBOcjNV5bRvs4QwdaWrc4+ODAgL/TMOvV6txHLl5QvNKhZO8f5BlptNBuYO6tbCTOs5/tRva4qbmjEvOaY0DYPB3ey/dnlstbcRHHCspsGqE8i4e0jsvCwMP+aViudS3jykt6L/Vg4V2Tv6kxSocN2RDtYxTw2jlND+F+IP1Ejqm7Kr65aC5qgBDjVH2hbtBnyp3+QjK9aL4UhSN/uNYZ+nqloPZ+9qA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=kernel.org smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uQ5GYvtegcsURwB8tmcx0w6ob90PJadJRjYGo3P/TaE=; b=qFLy8Sd8OlaTSOEO4judxosaWupBeML2L8RRolXFBgGsCMUVXE0aUuZFXAsDlhH24Xgd+xDuZukG4MVUkQp+jDxzj32gVVJ9j498EScOZhvq1VCDJpep85bt1Bd7kpEkM4OJ7Y9AVFfnFc8fHY9JCAjKhoawSoS7McEMgVLzka4= Received: from BN9PR03CA0766.namprd03.prod.outlook.com (2603:10b6:408:13a::21) by DM8PR02MB8264.namprd02.prod.outlook.com (2603:10b6:8:7::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.30; Sun, 3 Apr 2022 05:17:11 +0000 Received: from BN1NAM02FT061.eop-nam02.prod.protection.outlook.com (2603:10b6:408:13a:cafe::89) by BN9PR03CA0766.outlook.office365.com (2603:10b6:408:13a::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.30 via Frontend Transport; Sun, 3 Apr 2022 05:17:11 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch01.xlnx.xilinx.com; Received: from xsj-pvapexch01.xlnx.xilinx.com (149.199.62.198) by BN1NAM02FT061.mail.protection.outlook.com (10.13.3.184) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5123.19 via Frontend Transport; Sun, 3 Apr 2022 05:17:10 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch01.xlnx.xilinx.com (172.19.86.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Sat, 2 Apr 2022 22:17:01 -0700 Received: from smtp.xilinx.com (172.19.127.95) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Sat, 2 Apr 2022 22:17:01 -0700 Envelope-to: git@xilinx.com, mdf@kernel.org, hao.wu@intel.com, yilun.xu@intel.com, trix@redhat.com, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Received: from [10.140.6.60] (port=54274 helo=xhdnavam40.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1nasbk-0007vd-Gj; Sat, 02 Apr 2022 22:17:00 -0700 From: Nava kishore Manne To: , , , , , , , , CC: Nava kishore Manne Subject: [PATCH v3 3/5] fpga: fpga-mgr: Add missing kernel-doc description Date: Sun, 3 Apr 2022 10:46:39 +0530 Message-ID: <20220403051641.3867610-4-nava.manne@xilinx.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220403051641.3867610-1-nava.manne@xilinx.com> References: <20220403051641.3867610-1-nava.manne@xilinx.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 991e3621-c7ca-4162-5154-08da153134d8 X-MS-TrafficTypeDiagnostic: DM8PR02MB8264:EE_ X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: M5RdPlbew4iMaBf7L9AJb1HNSPFVzrtlbXE4YftQh9UUUrYzIMPvq7tXVy3szeMbMHCOkyjfdEX6CfBxM+2u3q0WUnTSmz6GZA42ojbcYNjQqhyEOBl88Rww6bNTwD9la3SJA58g54W9pg8m2TFbaN175YmymE0p+MMG8D7H5rJU2C4LJU/F5+HT58FsrtIcjdzLo3X9RotqO36lnw1gOkBJ/rqCpuDqw7pk3pWBALjPqxyj3hct94Inaw1EwMgW8VlMeui62VJ3arVFMLr+BFGSRXngRk8AUFHjuSV9IGjZ2/aVGPwEg4O6cBBjcuKn5ea5Mf1LEEXwbviyOEOKx8SEfABo5QoZ7Ziy0w/k1wEzsu9W8rKuyW2mAjP6TyZqT0EK4LcFO1U+W3XR40ZwxdFKsfvdBRuX42IZKbljrSyjYZIVCr8lvkQRqjPL9433weqrr7nkjf3UH4kMBpP2TTXNwR/RcOulyooXKcQF5OzJjbRrloARXVzrGLtiTl94RA99UJBZ9zwFmuv4TrGyg34t0UhsoSxodN/yp8HAn5i5h1v0zygfyJ2iVOVVCRgtwIiwgeKk2LEiX4IoXPi9O0saxGyNcV3VR5joxe913JZy8+VvJ1E8A1MRSBZISzPnfgTH/jyLfPajJTjIilxYo13Cw6rXq8fviyDuzJ7hQAIsZn4QQQU17vBRlwx2owvXJ3FvjbIFzQAwsqdhYISa/0TpUHF7aB3Mm1zMJbUu0CcRZXEu8D09jmfdEk/6L2MI X-Forefront-Antispam-Report: CIP:149.199.62.198;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapexch01.xlnx.xilinx.com;PTR:unknown-62-198.xilinx.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(36756003)(186003)(6666004)(7696005)(26005)(508600001)(110136005)(70206006)(70586007)(83380400001)(6636002)(8676002)(4326008)(47076005)(8936002)(40460700003)(36860700001)(9786002)(426003)(1076003)(2616005)(107886003)(2906002)(316002)(82310400004)(7636003)(5660300002)(356005)(336012)(102446001)(21314003)(2101003);DIR:OUT;SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2022 05:17:10.9269 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 991e3621-c7ca-4162-5154-08da153134d8 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: BN1NAM02FT061.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR02MB8264 Precedence: bulk List-ID: X-Mailing-List: linux-fpga@vger.kernel.org Fixed the warnings: No description found for return value of 'xxx' Signed-off-by: Nava kishore Manne --- Changes for v2: -Replaced s/@return:/Return:/ Changes for v3: -Updated commit description. drivers/fpga/fpga-mgr.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/fpga/fpga-mgr.c b/drivers/fpga/fpga-mgr.c index a699cc8e2fa6..0f2b28538f17 100644 --- a/drivers/fpga/fpga-mgr.c +++ b/drivers/fpga/fpga-mgr.c @@ -730,6 +730,8 @@ static void devm_fpga_mgr_unregister(struct device *dev, void *res) * @parent: fpga manager device from pdev * @info: parameters for fpga manager * + * Return: fpga manager pointer on success, negative error code otherwise. + * * This is the devres variant of fpga_mgr_register_full() for which the unregister * function will be called automatically when the managing device is detached. */ @@ -763,6 +765,8 @@ EXPORT_SYMBOL_GPL(devm_fpga_mgr_register_full); * @mops: pointer to structure of fpga manager ops * @priv: fpga manager private data * + * Return: fpga manager pointer on success, negative error code otherwise. + * * This is the devres variant of fpga_mgr_register() for which the * unregister function will be called automatically when the managing * device is detached. From patchwork Sun Apr 3 05:16:40 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nava kishore Manne X-Patchwork-Id: 12799462 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36476C433F5 for ; Sun, 3 Apr 2022 05:19:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237041AbiDCFTN (ORCPT ); Sun, 3 Apr 2022 01:19:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237442AbiDCFTK (ORCPT ); Sun, 3 Apr 2022 01:19:10 -0400 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2064.outbound.protection.outlook.com [40.107.220.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 937F6377C1; Sat, 2 Apr 2022 22:17:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IHdQn0apS6tcTNx44RuUqP/SR07PI3DKtCaf+XqCxtO9a6epI0QP76Qh1TSDVtMp5xLK6LoXMhQxWW+AApoATGuDMLlgnrXz7WAQZOOVHGAdDJ9lwSZ4TZ4R1MlXqRYW5HMhFuN/fezhIed7b4f15MJtuD4vNhHakINNvrWruV+g350pi2BgSRKPZN+uudmNQ+0mP6+DsuxfEE41RmQuh2/199xsEWlfApFPI25lStBhqd9F3Y95UjuK9jwWgCSZCebp8v+djuzV1YW4ixCFa2S9d6jKhatgrHeF5DzEiwVcfOFRDFWjUspRdEJ7rR+gf+OATOiK1pBcsuq+K/N2bA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8OZSXHY3nIzm6y3mxAPj0bpzniQWDGT0n6H3Flnv4kY=; b=J8CRvp0tTfARKBwYU7UtmRRENjiYr5Tcng73t7tWraqRzp+1Pic8mXVcDBIfTAaP92BHmC7jggOvRVlIOv14YR5EZac0NTnlYip1QDokRTqh9OEMyv79kWdy7hLASnvOguO2+1Rob6GhT9LKlLsEeXc8HzVIUDwIzYoJkER7f623BFvtT+CH35/cg5ElqJBw7DX4NdKDhhBvKTSRU1lCmrrRBVZUCPCwpOYnUQLjbh4skhjRuSG4S5qHxDd7+JI8ICgPX5KosHixZ1HLj0XiPeGk4JNhQRzp1J/fq4aU57mzibGes3Q1OCpjBD/tSr5xDeO0Opk7KCf+GODPquGPJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=kernel.org smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8OZSXHY3nIzm6y3mxAPj0bpzniQWDGT0n6H3Flnv4kY=; b=Ct7zL3JspZo/k1kLkPJGl3/TPf/Ah85nCKmJEKZHlr3fDx9+AkQOQFFAaI6qeYy6HnTIjOY8w+CciC8F1aEHl8iScgz2uEyteXbfUpjGfFQ0ic0CPURd45FfIeL/66yfKdNSZnr2EkMexPgvREKx2p+SEgO903gBzEWa4m2jpGY= Received: from BN9PR03CA0752.namprd03.prod.outlook.com (2603:10b6:408:13a::7) by PH0PR02MB8373.namprd02.prod.outlook.com (2603:10b6:510:100::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.30; Sun, 3 Apr 2022 05:17:14 +0000 Received: from BN1NAM02FT061.eop-nam02.prod.protection.outlook.com (2603:10b6:408:13a:cafe::fb) by BN9PR03CA0752.outlook.office365.com (2603:10b6:408:13a::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31 via Frontend Transport; Sun, 3 Apr 2022 05:17:14 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch01.xlnx.xilinx.com; Received: from xsj-pvapexch01.xlnx.xilinx.com (149.199.62.198) by BN1NAM02FT061.mail.protection.outlook.com (10.13.3.184) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5123.19 via Frontend Transport; Sun, 3 Apr 2022 05:17:14 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch01.xlnx.xilinx.com (172.19.86.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Sat, 2 Apr 2022 22:17:05 -0700 Received: from smtp.xilinx.com (172.19.127.95) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Sat, 2 Apr 2022 22:17:05 -0700 Envelope-to: git@xilinx.com, mdf@kernel.org, hao.wu@intel.com, yilun.xu@intel.com, trix@redhat.com, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Received: from [10.140.6.60] (port=54274 helo=xhdnavam40.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1nasbp-0007vd-9A; Sat, 02 Apr 2022 22:17:05 -0700 From: Nava kishore Manne To: , , , , , , , , CC: Nava kishore Manne Subject: [PATCH v3 4/5] fpga: Use tab instead of space indentation Date: Sun, 3 Apr 2022 10:46:40 +0530 Message-ID: <20220403051641.3867610-5-nava.manne@xilinx.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220403051641.3867610-1-nava.manne@xilinx.com> References: <20220403051641.3867610-1-nava.manne@xilinx.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bd150066-1f5c-4fba-6aa1-08da15313701 X-MS-TrafficTypeDiagnostic: PH0PR02MB8373:EE_ X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GOTRmhPwaG5FecWR+oUOEZrqzodA9OBDyZ0Ov17wwlRPmuMlWAJON35+2zyGWfbpEB+yiLJGePIAZMLqH9XJsqaVj7itroBbiKhGeSZWCbhLI564XOcxBrh2y/v5LO6n3/O1PI3ztKxsMxosU65wJdwBjFFQcFW0p6YRJ7oEeSoaAnh1YJYF3kSwEz+AFnAzD5XWQl2MZwS9/vHHp98qoSri1wzZYw51fUl6/BaGQ63YmK9gujuip8zI1V+MKTZJ7I2cx9aTnIaZdCVfnR0cHDlVOdw3Zw7VOfJculyEc34GR29iqaAL7lJdBsJLnVwb7ILceEi7TBIdhoryyOXgfaORomEWU+YGIbWONzP6kv1dCkSxf+O1NvKEACcCRU/ovgcyB3wZnWZ6GJaRPx9TU443cM24qyPH978WH4OQDCZzrr9ZWku8ieo1BHKlv18InjlsK/Ew6ybIb0F87AvUYxSigDdEQRCPaXxCWKJ8T8Zf/32rFKSYtDRErjyZ9p9INd/O9SAjIjjtBSIH0Zj1BQVJtoXFRNtaCp6TtJ6XW/QXwqkgkzCO1Ge7Wl+oxg4godeB2ZMLaUBwbk7dZLqJY4PSCHjPsGjJU1UuANtKYdIduBs2tSKaveqEwKwS9q0cznhaG0BeJAO3xEowFoirsRUW2lr9r3BWc4rBYQqn1FUzlguv/Q9IMBOxztoGoVY9E4VYLsftlLqBUpQPlGD1lxd3DvzIo7Vs7haOztzAPXM= X-Forefront-Antispam-Report: CIP:149.199.62.198;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapexch01.xlnx.xilinx.com;PTR:unknown-62-198.xilinx.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(186003)(82310400004)(7696005)(356005)(508600001)(426003)(2906002)(36860700001)(336012)(6666004)(70586007)(70206006)(26005)(316002)(47076005)(7636003)(9786002)(1076003)(83380400001)(107886003)(2616005)(8936002)(5660300002)(40460700003)(8676002)(6636002)(110136005)(36756003)(4326008)(102446001)(2101003);DIR:OUT;SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2022 05:17:14.5517 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bd150066-1f5c-4fba-6aa1-08da15313701 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: BN1NAM02FT061.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR02MB8373 Precedence: bulk List-ID: X-Mailing-List: linux-fpga@vger.kernel.org In FPGA Make file has both space and tab indentation to make them align use tab instead of space indentation. Signed-off-by: Nava kishore Manne --- Changes for v2: -None. Changes for v3: -Updated commit description. drivers/fpga/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/fpga/Makefile b/drivers/fpga/Makefile index 0bff783d1b61..5935b3d0abd5 100644 --- a/drivers/fpga/Makefile +++ b/drivers/fpga/Makefile @@ -18,9 +18,9 @@ obj-$(CONFIG_FPGA_MGR_TS73XX) += ts73xx-fpga.o obj-$(CONFIG_FPGA_MGR_XILINX_SPI) += xilinx-spi.o obj-$(CONFIG_FPGA_MGR_ZYNQ_FPGA) += zynq-fpga.o obj-$(CONFIG_FPGA_MGR_ZYNQMP_FPGA) += zynqmp-fpga.o -obj-$(CONFIG_FPGA_MGR_VERSAL_FPGA) += versal-fpga.o -obj-$(CONFIG_ALTERA_PR_IP_CORE) += altera-pr-ip-core.o -obj-$(CONFIG_ALTERA_PR_IP_CORE_PLAT) += altera-pr-ip-core-plat.o +obj-$(CONFIG_FPGA_MGR_VERSAL_FPGA) += versal-fpga.o +obj-$(CONFIG_ALTERA_PR_IP_CORE) += altera-pr-ip-core.o +obj-$(CONFIG_ALTERA_PR_IP_CORE_PLAT) += altera-pr-ip-core-plat.o # FPGA Bridge Drivers obj-$(CONFIG_FPGA_BRIDGE) += fpga-bridge.o From patchwork Sun Apr 3 05:16:41 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nava kishore Manne X-Patchwork-Id: 12799461 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3ACD9C433F5 for ; Sun, 3 Apr 2022 05:19:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236970AbiDCFTN (ORCPT ); Sun, 3 Apr 2022 01:19:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237729AbiDCFTL (ORCPT ); Sun, 3 Apr 2022 01:19:11 -0400 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2047.outbound.protection.outlook.com [40.107.94.47]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5BDB237026; Sat, 2 Apr 2022 22:17:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MrCI3jjR+yp9nzJ5lBHdJmtqrZSFdzFA94/wo+qxFE9kPpPfZVMUE5U9oeiBdhJmleUjpTx72+7YdtacsY9cDLKROI7PsbAUkfvwVSso7zZgeQbSszpD+4t1tHsgAY1NRaMKM2qWLjlhXX9DamYb2/MlNOl4dv32/DNf/yA4Eft3lvrCdccvhO+YLvtX7mcWI+E2S7ihLbbVrHVEHbuB9jMeG/OwmhWMWMLxDQ1XLNC50aePicDBUsAYBT2fHrRCFEn0R7mWkI6mlUFkHFwn0iAVMCD4+772tpUOykzG6nkzh3iCVSbCCFQgVAtSSjWLtV3M1ZKSAb9rARWlf7oAhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/bDLCRcQqsLDW3o4Kv8XZfprDMFd0u/5utggCmt/lG4=; b=Vken6r1INVME5u2XHOUUrzCOd6xEcBiU8RH+g8zfcvGZPCI08HYHC2u4ItL9cxd2aeR/AChLjIdb8UMIzlOmOyYJS1oGJTcA0rUM4Fy74CmMhz/Tt2DBOnsbHGLb36MRa5UXw4n873fp17/KaLVnCFxEQOeYN481Y/OTrHuDKlJ6yN9oqZ4sQiv4DLvzFHAOqxQWawGo5Wai4W8erOnJN+kLoGiLIqH4IfcS10jtQaMbDOAiSsnyz2TJeI5K2GyNFynnN+FK6T8eyq3+Ogjh1yb728QHSKkvBm4ZIktN5sqPS5fR0r3ZZk2TJA5MadKZv88xFaW/8JOUBGJ76+3/7g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=kernel.org smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/bDLCRcQqsLDW3o4Kv8XZfprDMFd0u/5utggCmt/lG4=; b=s77X1EPLYNi/pSK7wQ/OHRuHUKlmI/Px5XyIGNKy5bT9rWwqtCT3Ab/n03wSGbgim2DKGwmz167ib7rXuhwYgoc4sYX0Rr/B3gI9MoDKmLV75ddjMTw+USii3QODcskf30WiWpIyImNx7ertpRLyFQB0i3qjSOmpGZ962E0Z6Gc= Received: from DM5PR07CA0106.namprd07.prod.outlook.com (2603:10b6:4:ae::35) by SJ0PR02MB7742.namprd02.prod.outlook.com (2603:10b6:a03:320::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.30; Sun, 3 Apr 2022 05:17:15 +0000 Received: from DM3NAM02FT063.eop-nam02.prod.protection.outlook.com (2603:10b6:4:ae:cafe::49) by DM5PR07CA0106.outlook.office365.com (2603:10b6:4:ae::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.30 via Frontend Transport; Sun, 3 Apr 2022 05:17:15 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch02.xlnx.xilinx.com; Received: from xsj-pvapexch02.xlnx.xilinx.com (149.199.62.198) by DM3NAM02FT063.mail.protection.outlook.com (10.13.5.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5123.19 via Frontend Transport; Sun, 3 Apr 2022 05:17:15 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Sat, 2 Apr 2022 22:17:12 -0700 Received: from smtp.xilinx.com (172.19.127.95) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Sat, 2 Apr 2022 22:17:12 -0700 Envelope-to: git@xilinx.com, mdf@kernel.org, hao.wu@intel.com, yilun.xu@intel.com, trix@redhat.com, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Received: from [10.140.6.60] (port=54274 helo=xhdnavam40.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1nasbv-0007vd-IF; Sat, 02 Apr 2022 22:17:11 -0700 From: Nava kishore Manne To: , , , , , , , , CC: Nava kishore Manne Subject: [PATCH v3 5/5] fpga: fpga-region: Add missing kernel-doc description Date: Sun, 3 Apr 2022 10:46:41 +0530 Message-ID: <20220403051641.3867610-6-nava.manne@xilinx.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220403051641.3867610-1-nava.manne@xilinx.com> References: <20220403051641.3867610-1-nava.manne@xilinx.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d070c189-461b-4c5c-f411-08da15313785 X-MS-TrafficTypeDiagnostic: SJ0PR02MB7742:EE_ X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lmCmWkYPuVLaU4oLFh9VNJs+RCvL3jE9Qzp77IYzYg/Z6HbaoRk6xm/kXW3ZQWP+nRfjxzP895/NZaIIS392ML91VH+ynh4ZOQAVNpbhdd9Bc9VzqMDAoyP4sdPMDneKuT3DGmDo7sCYKNn2c/0nIoyW2yGJo26Xa7ghj8wG7k6T1DnaIhB31l9jEsWq8PjY8tG83NSbU8qKFupEF9FVEGTxYZgZSvUhTBjRCPGB3jsPezqp0edB+ClZuMWr+2TNsXroTRAB/RR+NPszqON0zZ6aFm/b8GLhRA8WCmYSi2HHdrJPcaQ5tKBfMu/aBJUTafMhOqGneWeGCHkT1PGGGO3h2oSLpn2Z1QPpSHwXN2ORCTr1nJQ7iCLPmtx7AxkdrWaiuqAk2w1FZqRBBM7fITTas4vwaIzSz7fB52LZAD/sQE0GzmVqPEFstsQPd9zg/u6jqqItW60dWaJR1vTgW9jjgBuANhj4uvenmv9RxOsYS83KpBkJt5SRMBmk5DmFQIxBS7IPY2cPhWjaleGnhuaV8lp0FX5P0mPd6asGOHpz6qjytv/BVdFs7OTnYhiEaYEclFCjp5si4n277lUzF0cLsIUkEpMxCg7fIzXZaWd2zCGLGfgb1YexWgP0iYMZRyR8b2FDYPTvNWTRhfJCUSJ38pLVy9F4yJjDYVbj/UMn5Dkhx4g/YMsk6SJjuEHvDaLX2kxhuezHA2XBFkZTPPEqJCaR1Dixj9fT0ogI6G63PY1FxtUr1Tlt6+FhLvpJ X-Forefront-Antispam-Report: CIP:149.199.62.198;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapexch02.xlnx.xilinx.com;PTR:unknown-62-198.xilinx.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(2616005)(8936002)(40460700003)(316002)(7636003)(1076003)(83380400001)(107886003)(36756003)(47076005)(7696005)(110136005)(9786002)(2906002)(186003)(26005)(336012)(426003)(82310400004)(6666004)(70206006)(70586007)(36860700001)(5660300002)(508600001)(6636002)(8676002)(356005)(4326008)(102446001)(21314003)(2101003);DIR:OUT;SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2022 05:17:15.4515 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d070c189-461b-4c5c-f411-08da15313785 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: DM3NAM02FT063.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR02MB7742 Precedence: bulk List-ID: X-Mailing-List: linux-fpga@vger.kernel.org Fixed the warnings: No description found for return value of 'xxx' Signed-off-by: Nava kishore Manne --- Changes for v2: -Replaced s/@return:/Return:/ Changes for v3: -Updated commit description. drivers/fpga/of-fpga-region.c | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/fpga/of-fpga-region.c b/drivers/fpga/of-fpga-region.c index 50b83057c048..9e330a2c0a1b 100644 --- a/drivers/fpga/of-fpga-region.c +++ b/drivers/fpga/of-fpga-region.c @@ -28,7 +28,7 @@ MODULE_DEVICE_TABLE(of, fpga_region_of_match); * * Caller will need to put_device(®ion->dev) when done. * - * Returns FPGA Region struct or NULL + * Return: FPGA Region struct or NULL */ static struct fpga_region *of_fpga_region_find(struct device_node *np) { @@ -80,7 +80,7 @@ static struct fpga_manager *of_fpga_region_get_mgr(struct device_node *np) * Caller should call fpga_bridges_put(®ion->bridge_list) when * done with the bridges. * - * Return 0 for success (even if there are no bridges specified) + * Return: 0 for success (even if there are no bridges specified) * or -EBUSY if any of the bridges are in use. */ static int of_fpga_region_get_bridges(struct fpga_region *region) @@ -139,13 +139,13 @@ static int of_fpga_region_get_bridges(struct fpga_region *region) } /** - * child_regions_with_firmware + * child_regions_with_firmware - Used to check the child region info. * @overlay: device node of the overlay * * If the overlay adds child FPGA regions, they are not allowed to have * firmware-name property. * - * Return 0 for OK or -EINVAL if child FPGA region adds firmware-name. + * Return: 0 for OK or -EINVAL if child FPGA region adds firmware-name. */ static int child_regions_with_firmware(struct device_node *overlay) { @@ -184,7 +184,7 @@ static int child_regions_with_firmware(struct device_node *overlay) * Given an overlay applied to an FPGA region, parse the FPGA image specific * info in the overlay and do some checking. * - * Returns: + * Return: * NULL if overlay doesn't direct us to program the FPGA. * fpga_image_info struct if there is an image to program. * error code for invalid overlay. @@ -279,7 +279,7 @@ static struct fpga_image_info *of_fpga_region_parse_ov( * If the checks fail, overlay is rejected and does not get added to the * live tree. * - * Returns 0 for success or negative error code for failure. + * Return: 0 for success or negative error code for failure. */ static int of_fpga_region_notify_pre_apply(struct fpga_region *region, struct of_overlay_notify_data *nd) @@ -339,7 +339,7 @@ static void of_fpga_region_notify_post_remove(struct fpga_region *region, * This notifier handles programming an FPGA when a "firmware-name" property is * added to an fpga-region. * - * Returns NOTIFY_OK or error if FPGA programming fails. + * Return: NOTIFY_OK or error if FPGA programming fails. */ static int of_fpga_region_notify(struct notifier_block *nb, unsigned long action, void *arg) @@ -446,6 +446,8 @@ static struct platform_driver of_fpga_region_driver = { /** * of_fpga_region_init - init function for fpga_region class * Creates the fpga_region class and registers a reconfig notifier. + * + * Return: 0 on success, negative error code otherwise. */ static int __init of_fpga_region_init(void) {