From patchwork Mon Apr 4 13:41:35 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gabriel Krisman Bertazi X-Patchwork-Id: 12800235 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C487AC433EF for ; Mon, 4 Apr 2022 13:42:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 21FC36B0073; Mon, 4 Apr 2022 09:42:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1D01F6B0074; Mon, 4 Apr 2022 09:42:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 070396B0075; Mon, 4 Apr 2022 09:42:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id EC1B06B0073 for ; Mon, 4 Apr 2022 09:42:01 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id CD2296102D for ; Mon, 4 Apr 2022 13:41:51 +0000 (UTC) X-FDA: 79319309622.07.8FC3AA1 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by imf22.hostedemail.com (Postfix) with ESMTP id 3F519C0031 for ; Mon, 4 Apr 2022 13:41:51 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: krisman) with ESMTPSA id 139EE1F44928 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1649079710; bh=zfBsf2RUnAkmYRtu6lmk/b8dTq1cQYpREmaCwhUzUEE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AnT/UR63cC5l6sLe3j41I1/03cTiqLpPv7znsIhGOe3hKFamGkleq6DNScyLfjqvf SyKdvOC82qGsZcSQ2BibFMuSzE8RavVYPz+B8VhcunTKJxz9r642l4IElNR3h83I3Z f3L8O+hwmVdgzuEbYGlUmPY1CjOwIk0Byap/OWuBSzB5val0kPi2pTQ9SJsoSG4Ciw oLmShkblV58QDu5s3ahSNCPjhViEXGLZN8SsRgLpcOTqbOWHOLRaY1m3nmsljzb6/F IROTEnz06yLmIuVGDVoQnAXZtg0JlEPID8QyoQSB9FoQwRJ/w2Z8H2aInLrskXhrDW XTvPBLzHEt3TA== From: Gabriel Krisman Bertazi To: Hugh Dickins , Andrew Morton , Amir Goldstein Cc: Gabriel Krisman Bertazi , kernel@collabora.com, Khazhismel Kumykov , Linux MM , linux-fsdevel Subject: [PATCH RESEND 1/3] shmem: Keep track of out-of-memory and out-of-space errors Date: Mon, 4 Apr 2022 09:41:35 -0400 Message-Id: <20220404134137.26284-2-krisman@collabora.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220404134137.26284-1-krisman@collabora.com> References: <20220404134137.26284-1-krisman@collabora.com> MIME-Version: 1.0 Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b="AnT/UR63"; spf=pass (imf22.hostedemail.com: domain of krisman@collabora.com designates 46.235.227.227 as permitted sender) smtp.mailfrom=krisman@collabora.com; dmarc=pass (policy=none) header.from=collabora.com X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 3F519C0031 X-Stat-Signature: 71qj3izxrz34myx19imm4j8xt17iwxw3 X-HE-Tag: 1649079711-21786 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Keep a per-sb counter of failed shmem allocations for ENOMEM/ENOSPC to be reported on sysfs. The sysfs support is done separately on a later patch. Signed-off-by: Gabriel Krisman Bertazi --- include/linux/shmem_fs.h | 3 +++ mm/shmem.c | 5 ++++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/include/linux/shmem_fs.h b/include/linux/shmem_fs.h index e65b80ed09e7..1a7cd9ea9107 100644 --- a/include/linux/shmem_fs.h +++ b/include/linux/shmem_fs.h @@ -44,6 +44,9 @@ struct shmem_sb_info { spinlock_t shrinklist_lock; /* Protects shrinklist */ struct list_head shrinklist; /* List of shinkable inodes */ unsigned long shrinklist_len; /* Length of shrinklist */ + + unsigned long acct_errors; + unsigned long space_errors; }; static inline struct shmem_inode_info *SHMEM_I(struct inode *inode) diff --git a/mm/shmem.c b/mm/shmem.c index a09b29ec2b45..c350fa0a0fff 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -212,8 +212,10 @@ static inline bool shmem_inode_acct_block(struct inode *inode, long pages) struct shmem_inode_info *info = SHMEM_I(inode); struct shmem_sb_info *sbinfo = SHMEM_SB(inode->i_sb); - if (shmem_acct_block(info->flags, pages)) + if (shmem_acct_block(info->flags, pages)) { + sbinfo->acct_errors += 1; return false; + } if (sbinfo->max_blocks) { if (percpu_counter_compare(&sbinfo->used_blocks, @@ -225,6 +227,7 @@ static inline bool shmem_inode_acct_block(struct inode *inode, long pages) return true; unacct: + sbinfo->space_errors += 1; shmem_unacct_blocks(info->flags, pages); return false; } From patchwork Mon Apr 4 13:41:36 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gabriel Krisman Bertazi X-Patchwork-Id: 12800236 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E237C433EF for ; Mon, 4 Apr 2022 13:42:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 183DF6B0074; Mon, 4 Apr 2022 09:42:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 133536B0075; Mon, 4 Apr 2022 09:42:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F16966B0078; Mon, 4 Apr 2022 09:42:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id E29216B0074 for ; Mon, 4 Apr 2022 09:42:05 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B221B242E8 for ; Mon, 4 Apr 2022 13:41:55 +0000 (UTC) X-FDA: 79319309790.06.0D4249D Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by imf16.hostedemail.com (Postfix) with ESMTP id 2E166180026 for ; Mon, 4 Apr 2022 13:41:55 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: krisman) with ESMTPSA id 0AB7E1F44928 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1649079714; bh=Q62XHry7RU5EKa0FvuVG2Xq8LLMlLOBVxsPhfZeA3sU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HwY2EsFEp5c8vwG0jMYWuhyuhIbTzrZRvgvcnW/j/ZjdMxW7uaE6McSWk4tkLmYgM MxQA8loR8Wj9+I9ro8PtvUu7YGGsDhuKuQZ8dNlbzS5+9sUEzgqQ2450K2Ka+FeJCL YYRQvfaf5BcHlNHK2Suf4dSbhVhTPCv4kgmWr7G5z43FQFwPkowLEB0KmL5YRpmuw4 hMHq7uKsj5vD1sM8dN7ihPxdPXJjVXXZsA/41dk6XWucpKOHSWGlUIeJ2X9kZasSrT Uj8kTA/iF9XQA3tsybApdd0Jb/KGyYLxEJ9rPAUfspWjE9nHwD4sccfymnFrt5dORS 1W4cFuGE4Pvpg== From: Gabriel Krisman Bertazi To: Hugh Dickins , Andrew Morton , Amir Goldstein Cc: Gabriel Krisman Bertazi , kernel@collabora.com, Khazhismel Kumykov , Linux MM , linux-fsdevel Subject: [PATCH RESEND 2/3] shmem: Introduce /sys/fs/tmpfs support Date: Mon, 4 Apr 2022 09:41:36 -0400 Message-Id: <20220404134137.26284-3-krisman@collabora.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220404134137.26284-1-krisman@collabora.com> References: <20220404134137.26284-1-krisman@collabora.com> MIME-Version: 1.0 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 2E166180026 X-Stat-Signature: 9uwagujqp7doh5otsqoc3y4pgumyp4z6 Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=HwY2EsFE; dmarc=pass (policy=none) header.from=collabora.com; spf=pass (imf16.hostedemail.com: domain of krisman@collabora.com designates 46.235.227.227 as permitted sender) smtp.mailfrom=krisman@collabora.com X-Rspam-User: X-HE-Tag: 1649079715-645244 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: In order to expose tmpfs statistics on sysfs, add the boilerplate code to create the /sys/fs/tmpfs structure. As suggested on a previous review, this uses the minor as the volume directory in /sys/fs/. This takes care of not exposing SB_NOUSER mounts. I don't think we have a usecase for showing them and, since they don't appear elsewhere, they might be confusing to users. Signed-off-by: Gabriel Krisman Bertazi --- Changes since v1: - Use minor instead of fsid for directory in sysfs. (Amir) --- include/linux/shmem_fs.h | 4 +++ mm/shmem.c | 72 +++++++++++++++++++++++++++++++++++++++- 2 files changed, 75 insertions(+), 1 deletion(-) diff --git a/include/linux/shmem_fs.h b/include/linux/shmem_fs.h index 1a7cd9ea9107..c27ecf0e1b3b 100644 --- a/include/linux/shmem_fs.h +++ b/include/linux/shmem_fs.h @@ -47,6 +47,10 @@ struct shmem_sb_info { unsigned long acct_errors; unsigned long space_errors; + + /* sysfs */ + struct kobject s_kobj; /* /sys/fs/tmpfs/ */ + struct completion s_kobj_unregister; }; static inline struct shmem_inode_info *SHMEM_I(struct inode *inode) diff --git a/mm/shmem.c b/mm/shmem.c index c350fa0a0fff..665d417ba8a8 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -250,6 +250,7 @@ static const struct inode_operations shmem_dir_inode_operations; static const struct inode_operations shmem_special_inode_operations; static const struct vm_operations_struct shmem_vm_ops; static struct file_system_type shmem_fs_type; +static struct kobject *shmem_root; bool vma_is_shmem(struct vm_area_struct *vma) { @@ -3584,6 +3585,56 @@ static int shmem_show_options(struct seq_file *seq, struct dentry *root) #endif /* CONFIG_TMPFS */ +#if defined(CONFIG_TMPFS) && defined(CONFIG_SYSFS) +#define TMPFS_SB_ATTR_RO(name) \ + static struct kobj_attribute tmpfs_sb_attr_##name = __ATTR_RO(name) + +static struct attribute *tmpfs_attrs[] = { + NULL +}; +ATTRIBUTE_GROUPS(tmpfs); + +static void tmpfs_sb_release(struct kobject *kobj) +{ + struct shmem_sb_info *sbinfo = + container_of(kobj, struct shmem_sb_info, s_kobj); + + complete(&sbinfo->s_kobj_unregister); +} + +static struct kobj_type tmpfs_sb_ktype = { + .default_groups = tmpfs_groups, + .sysfs_ops = &kobj_sysfs_ops, + .release = tmpfs_sb_release, +}; + +static void shmem_unregister_sysfs(struct super_block *sb) +{ + struct shmem_sb_info *sbinfo = SHMEM_SB(sb); + + kobject_del(&sbinfo->s_kobj); + kobject_put(&sbinfo->s_kobj); + wait_for_completion(&sbinfo->s_kobj_unregister); +} + +static int shmem_register_sysfs(struct super_block *sb) +{ + int err; + struct shmem_sb_info *sbinfo = SHMEM_SB(sb); + + init_completion(&sbinfo->s_kobj_unregister); + err = kobject_init_and_add(&sbinfo->s_kobj, &tmpfs_sb_ktype, + shmem_root, "%d", MINOR(sb->s_dev)); + if (err) { + kobject_put(&sbinfo->s_kobj); + wait_for_completion(&sbinfo->s_kobj_unregister); + return err; + } + + return 0; +} +#endif /* CONFIG_TMPFS && CONFIG_SYSFS */ + static void shmem_put_super(struct super_block *sb) { struct shmem_sb_info *sbinfo = SHMEM_SB(sb); @@ -3591,6 +3642,12 @@ static void shmem_put_super(struct super_block *sb) free_percpu(sbinfo->ino_batch); percpu_counter_destroy(&sbinfo->used_blocks); mpol_put(sbinfo->mpol); + +#if IS_ENABLED(CONFIG_TMPFS) && IS_ENABLED(CONFIG_SYSFS) + if (!(sb->s_flags & SB_NOUSER)) + shmem_unregister_sysfs(sb); +#endif + kfree(sbinfo); sb->s_fs_info = NULL; } @@ -3673,6 +3730,13 @@ static int shmem_fill_super(struct super_block *sb, struct fs_context *fc) sb->s_root = d_make_root(inode); if (!sb->s_root) goto failed; + +#if IS_ENABLED(CONFIG_TMPFS) && IS_ENABLED(CONFIG_SYSFS) + if (!(sb->s_flags & SB_NOUSER)) + if (shmem_register_sysfs(sb)) + goto failed; +#endif + return 0; failed: @@ -3889,11 +3953,15 @@ int __init shmem_init(void) goto out2; } + shmem_root = kobject_create_and_add("tmpfs", fs_kobj); + if (!shmem_root) + goto out1; + shm_mnt = kern_mount(&shmem_fs_type); if (IS_ERR(shm_mnt)) { error = PTR_ERR(shm_mnt); pr_err("Could not kern_mount tmpfs\n"); - goto out1; + goto put_kobj; } #ifdef CONFIG_TRANSPARENT_HUGEPAGE @@ -3904,6 +3972,8 @@ int __init shmem_init(void) #endif return 0; +put_kobj: + kobject_put(shmem_root); out1: unregister_filesystem(&shmem_fs_type); out2: From patchwork Mon Apr 4 13:41:37 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gabriel Krisman Bertazi X-Patchwork-Id: 12800267 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6AFAC433EF for ; Mon, 4 Apr 2022 13:43:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 973BC6B0075; Mon, 4 Apr 2022 09:42:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 922086B0078; Mon, 4 Apr 2022 09:42:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7EB086B007B; Mon, 4 Apr 2022 09:42:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0019.hostedemail.com [216.40.44.19]) by kanga.kvack.org (Postfix) with ESMTP id 70C0D6B0075 for ; Mon, 4 Apr 2022 09:42:09 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 26E2E183B95BE for ; Mon, 4 Apr 2022 13:41:59 +0000 (UTC) X-FDA: 79319309958.30.5101569 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by imf22.hostedemail.com (Postfix) with ESMTP id A7B2BC003D for ; Mon, 4 Apr 2022 13:41:58 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: krisman) with ESMTPSA id 820CE1F44928 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1649079717; bh=ZuYFeCaQsdCLMnheFQIhRwZM/6Dp8P5T0ofZ9ffnljU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KWXMRl0zbkAs2k9MO2sK3se2kssklJSRRLwjnVlVMF2s5B7XVFz6mzcz2LV7Xl/he n0YVFG/mwufSjL96TitZEYtxZFEod9tUVbjBU1nnswxXjcxNfroB/+TTamZmuADHyU QlcE8HgoPXk8GUkBEejRSJYIxcvZN5Tds0edRQatDr/sTN1kw8DZ+GVfjmcnKSqnj7 XVw1Wey4ta3441uh2Y1t7HofW0Km7IZIgb7/ybYRu/7Fc+zvRkXM6eW6z0I2TL8hKr eLW2wMlFNovHZ4PXsw52wLjbnfrbj8Vzoi41HOU+HFSsHiGzldaBbjiyV0r5JcwhGj kYxnad75vSmVw== From: Gabriel Krisman Bertazi To: Hugh Dickins , Andrew Morton , Amir Goldstein Cc: Gabriel Krisman Bertazi , kernel@collabora.com, Khazhismel Kumykov , Linux MM , linux-fsdevel Subject: [PATCH RESEND 3/3] shmem: Expose space and accounting error count Date: Mon, 4 Apr 2022 09:41:37 -0400 Message-Id: <20220404134137.26284-4-krisman@collabora.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220404134137.26284-1-krisman@collabora.com> References: <20220404134137.26284-1-krisman@collabora.com> MIME-Version: 1.0 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: mztja6fjfxy8qspzoemo7gwn6qfbd7nd Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=KWXMRl0z; dmarc=pass (policy=none) header.from=collabora.com; spf=pass (imf22.hostedemail.com: domain of krisman@collabora.com designates 46.235.227.227 as permitted sender) smtp.mailfrom=krisman@collabora.com X-Rspamd-Queue-Id: A7B2BC003D X-HE-Tag: 1649079718-782343 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Exposing these shmem counters through sysfs is particularly useful for container provisioning, to allow administrators to differentiate between insufficiently provisioned fs size vs. running out of memory. Suggested-by: Amir Goldstein Suggested-by: Khazhy Kumykov Signed-off-by: Gabriel Krisman Bertazi --- Documentation/ABI/testing/sysfs-fs-tmpfs | 13 ++++++++++++ mm/shmem.c | 25 ++++++++++++++++++++++++ 2 files changed, 38 insertions(+) create mode 100644 Documentation/ABI/testing/sysfs-fs-tmpfs diff --git a/Documentation/ABI/testing/sysfs-fs-tmpfs b/Documentation/ABI/testing/sysfs-fs-tmpfs new file mode 100644 index 000000000000..d32b90949710 --- /dev/null +++ b/Documentation/ABI/testing/sysfs-fs-tmpfs @@ -0,0 +1,13 @@ +What: /sys/fs/tmpfs//acct_errors +Date: March 2022 +Contact: "Gabriel Krisman Bertazi" +Description: + Track the number of IO errors caused by lack of memory to + perform the allocation of a tmpfs block. + +What: /sys/fs/tmpfs//space_errors +Date: March 2022 +Contact: "Gabriel Krisman Bertazi" +Description: + Track the number of IO errors caused by lack of space + in the filesystem to perform the allocation of a tmpfs block. diff --git a/mm/shmem.c b/mm/shmem.c index 665d417ba8a8..50d22449d99e 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -214,6 +214,7 @@ static inline bool shmem_inode_acct_block(struct inode *inode, long pages) if (shmem_acct_block(info->flags, pages)) { sbinfo->acct_errors += 1; + sysfs_notify(&sbinfo->s_kobj, NULL, "acct_errors"); return false; } @@ -228,6 +229,7 @@ static inline bool shmem_inode_acct_block(struct inode *inode, long pages) unacct: sbinfo->space_errors += 1; + sysfs_notify(&sbinfo->s_kobj, NULL, "space_errors"); shmem_unacct_blocks(info->flags, pages); return false; } @@ -3586,10 +3588,33 @@ static int shmem_show_options(struct seq_file *seq, struct dentry *root) #endif /* CONFIG_TMPFS */ #if defined(CONFIG_TMPFS) && defined(CONFIG_SYSFS) +static ssize_t acct_errors_show(struct kobject *kobj, + struct kobj_attribute *attr, char *page) +{ + struct shmem_sb_info *sbinfo = + container_of(kobj, struct shmem_sb_info, s_kobj); + + return sysfs_emit(page, "%lu\n", sbinfo->acct_errors); +} + +static ssize_t space_errors_show(struct kobject *kobj, + struct kobj_attribute *attr, char *page) +{ + struct shmem_sb_info *sbinfo = + container_of(kobj, struct shmem_sb_info, s_kobj); + + return sysfs_emit(page, "%lu\n", sbinfo->space_errors); +} + #define TMPFS_SB_ATTR_RO(name) \ static struct kobj_attribute tmpfs_sb_attr_##name = __ATTR_RO(name) +TMPFS_SB_ATTR_RO(acct_errors); +TMPFS_SB_ATTR_RO(space_errors); + static struct attribute *tmpfs_attrs[] = { + &tmpfs_sb_attr_acct_errors.attr, + &tmpfs_sb_attr_space_errors.attr, NULL }; ATTRIBUTE_GROUPS(tmpfs);