From patchwork Mon Apr 4 21:01:08 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Toke_H=C3=B8iland-J=C3=B8rgensen?= X-Patchwork-Id: 12800799 X-Patchwork-Delegate: johannes@sipsolutions.net Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 857A6C4332F for ; Mon, 4 Apr 2022 21:23:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379030AbiDDVSf (ORCPT ); Mon, 4 Apr 2022 17:18:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1380692AbiDDVDR (ORCPT ); Mon, 4 Apr 2022 17:03:17 -0400 Received: from mail.toke.dk (mail.toke.dk [45.145.95.4]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80E9238A3 for ; Mon, 4 Apr 2022 14:01:20 -0700 (PDT) From: =?utf-8?q?Toke_H=C3=B8iland-J=C3=B8rgensen?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; t=1649106079; bh=F0pmMQO96ia8+/SEA9XaTI2abIY52/1JRNbsDWWFqVE=; h=From:To:Cc:Subject:Date:From; b=T5yioeBf8JNcZc5KcPfMzEm4qocZya63qBwzPuDm9w1/7n+tMLLgyJgaSgE7cgA9m R8ZUymBVho88iiERcoIi1IvDngbnw20AcXUrBkpAHQlT0ocnmO4fjmP8+rfo3fn2Cg zDqtI15gTo0F56H3e7X9UWHsksFQ4xw5QNVKMgESGvL56E0MNyKV65rhF1p2uZvCSZ 3xlI/dnhCS4eXuOKtfg8dGbYSUCOLPcLliQjIRKCDMCicRMgW+ERawf90DsImmguSp CstJmYRvM7MO1iSuA4FEhVAoiq9K6xHp3Mu9+XB5u+hV9cd05cMxr865OQeHkooNZa TleRlTQGKBm9w== To: Johannes Berg Cc: linux-wireless@vger.kernel.org, =?utf-8?q?Toke_H=C3=B8iland-J=C3=B8rgens?= =?utf-8?q?en?= Subject: [PATCH] mac80211: Improve confusing comment around tx_info clearing Date: Mon, 4 Apr 2022 23:01:08 +0200 Message-Id: <20220404210108.2684907-1-toke@toke.dk> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org The comment above the ieee80211_tx_info_clear_status() helper was somewhat confusing as to which fields it was or wasn't clearing. So replace it by something that is hopefully more, well, clear. Signed-off-by: Toke Høiland-Jørgensen --- include/net/mac80211.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/net/mac80211.h b/include/net/mac80211.h index 382ebb862ea8..db992f71604d 100644 --- a/include/net/mac80211.h +++ b/include/net/mac80211.h @@ -1201,9 +1201,9 @@ static inline struct ieee80211_rx_status *IEEE80211_SKB_RXCB(struct sk_buff *skb * in the TX status but the rate control information (it does clear * the count since you need to fill that in anyway). * - * NOTE: You can only use this function if you do NOT use - * info->driver_data! Use info->rate_driver_data - * instead if you need only the less space that allows. + * NOTE: While the rates array is kept intact, this will wipe all of the + * driver_data fields in info, so it's up to the driver to restore + * any fields it needs after calling this helper. */ static inline void ieee80211_tx_info_clear_status(struct ieee80211_tx_info *info)