From patchwork Wed Apr 6 16:50:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gwendal Grignou X-Patchwork-Id: 12803957 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F1F1C433FE for ; Wed, 6 Apr 2022 18:11:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239877AbiDFSNP (ORCPT ); Wed, 6 Apr 2022 14:13:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240232AbiDFSNK (ORCPT ); Wed, 6 Apr 2022 14:13:10 -0400 Received: from mail-pg1-x52f.google.com (mail-pg1-x52f.google.com [IPv6:2607:f8b0:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B195129862 for ; Wed, 6 Apr 2022 09:50:31 -0700 (PDT) Received: by mail-pg1-x52f.google.com with SMTP id k14so2726849pga.0 for ; Wed, 06 Apr 2022 09:50:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GW2h7uu/G+YD6BBAeZyxfMtvERVI7M6Q3BgRXDcSV4A=; b=a1KL0Vafp4K4XREnlA3e1N5MECziD/SZsjf2K+Hpuv5hfmogDWxNdlysx3Ekb7TEdn 5wsbHuueaPKFcONHLT/5VJHooiOyzZquXUwtNyRKM4phqPPG0GKMoM1XtreweA3Ixn8Z mKYJZREC9gTSGJAxjq4/9OA3961nSCP+Jzi+E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GW2h7uu/G+YD6BBAeZyxfMtvERVI7M6Q3BgRXDcSV4A=; b=w1aClTolDDTkzV29dYfIkqKzwWUkavMl2/3UkL1L1/lOGXHAQaCsNfc7mrjVo5370D uxXUiA6dSU6uAYbZHmK73RzBgbG8U9zvz9CR7J4bVbVlObOJgO14Drx0JE6TNUtooyuG gkebUQqxAsXEDXh7w79WMj2Ks6S06tfR3On5NkH9Fd0Ibag8TgpuPSS3VBkBk/2Nd4CL MRSk85jFqsbHEc8Bu+MJSJnPJpFbnG3+U+UfQkqxjc0WXqxFx4iR0eMdTvPe0alrkMY/ Kg2T9nf7K8I3PEAGZICMAbPJzQ3duqB4fdmJJptX9Furkqf1gY+KEnJpdsqdt5uJyAnc 8blA== X-Gm-Message-State: AOAM530voyWVcMsHcAEDLEwvSEiAul9KqH71TFMcJLLfxWU6Ve8ZmLY/ ZRwDwjuJU2dl8Tl5ZxFn+ZGoNA== X-Google-Smtp-Source: ABdhPJzw8im6C+w2FNo2HMIGFsmoGHqaaZ0XpHY9mxxQOUtuyAq8unohXz0ANiytA4yABbl1dnmDtw== X-Received: by 2002:a63:5023:0:b0:399:2202:2f80 with SMTP id e35-20020a635023000000b0039922022f80mr7766059pgb.621.1649263830920; Wed, 06 Apr 2022 09:50:30 -0700 (PDT) Received: from localhost ([2620:15c:202:201:c9d3:469f:91e4:c022]) by smtp.gmail.com with UTF8SMTPSA id x5-20020aa79a45000000b00504a1c8b75asm101255pfj.165.2022.04.06.09.50.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Apr 2022 09:50:30 -0700 (PDT) From: Gwendal Grignou To: jic23@kernel.org, robh+dt@kernel.org, swboyd@chromium.org Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, Gwendal Grignou , stable@vger.kernel.org Subject: [PATCH v4 1/8] iio: sx9324: Fix default precharge internal resistance register Date: Wed, 6 Apr 2022 09:50:04 -0700 Message-Id: <20220406165011.10202-2-gwendal@chromium.org> X-Mailer: git-send-email 2.35.1.1094.g7c7d902a7c-goog In-Reply-To: <20220406165011.10202-1-gwendal@chromium.org> References: <20220406165011.10202-1-gwendal@chromium.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Fix the default value for the register that set the resistance: it has to be 0x10 per datasheet. Fixes: 4c18a890dff8d ("iio:proximity:sx9324: Add SX9324 support") Cc: stable@vger.kernel.org Signed-off-by: Gwendal Grignou Reviewed-by: Stephen Boyd --- Changes since v3: - Fix commit, use RESERVED instead of RSVD. Changes since v2: - no changes Changes since v1: - new patch. drivers/iio/proximity/sx9324.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/iio/proximity/sx9324.c b/drivers/iio/proximity/sx9324.c index 0d9bbbb50cb45..378c2a17bae6e 100644 --- a/drivers/iio/proximity/sx9324.c +++ b/drivers/iio/proximity/sx9324.c @@ -70,7 +70,8 @@ #define SX9324_REG_AFE_PH2 0x2a #define SX9324_REG_AFE_PH3 0x2b #define SX9324_REG_AFE_CTRL8 0x2c -#define SX9324_REG_AFE_CTRL8_RESFILTN_4KOHM 0x02 +#define SX9324_REG_AFE_CTRL8_RESERVED 0x10 +#define SX9324_REG_AFE_CTRL8_RESFILTIN_4KOHM 0x02 #define SX9324_REG_AFE_CTRL9 0x2d #define SX9324_REG_AFE_CTRL9_AGAIN_1 0x08 @@ -781,7 +782,8 @@ static const struct sx_common_reg_default sx9324_default_regs[] = { { SX9324_REG_AFE_PH2, 0x1a }, { SX9324_REG_AFE_PH3, 0x16 }, - { SX9324_REG_AFE_CTRL8, SX9324_REG_AFE_CTRL8_RESFILTN_4KOHM }, + { SX9324_REG_AFE_CTRL8, SX9324_REG_AFE_CTRL8_RESERVED | + SX9324_REG_AFE_CTRL8_RESFILTIN_4KOHM }, { SX9324_REG_AFE_CTRL9, SX9324_REG_AFE_CTRL9_AGAIN_1 }, { SX9324_REG_PROX_CTRL0, SX9324_REG_PROX_CTRL0_GAIN_1 | From patchwork Wed Apr 6 16:50:05 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gwendal Grignou X-Patchwork-Id: 12803959 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C319C433F5 for ; Wed, 6 Apr 2022 18:11:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240227AbiDFSNa (ORCPT ); Wed, 6 Apr 2022 14:13:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240244AbiDFSNK (ORCPT ); Wed, 6 Apr 2022 14:13:10 -0400 Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D686F129866 for ; Wed, 6 Apr 2022 09:50:32 -0700 (PDT) Received: by mail-pj1-x102b.google.com with SMTP id h23-20020a17090a051700b001c9c1dd3acbso3303506pjh.3 for ; Wed, 06 Apr 2022 09:50:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XEPPHqz4VApOEdnh9NNG69o7HuIEHeO+mlldHsXKCc4=; b=j2pPhljMH/Ql1zSdh5+CtZj3JpKuJmDJBO3Dd/Y7Z4NadiMCBuF8Fr4cJFdbmmEVCg sMDVuB32i96iBRZ5zECo0aZqE1CwN3HSgweNQOYRy49WARMwqt/Z2n2M+GIL9ZWh9J14 9smvu3gAaAqhx/PRLKCRlHL0KbpBWJkB3VSuE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XEPPHqz4VApOEdnh9NNG69o7HuIEHeO+mlldHsXKCc4=; b=U9sSKrIo8fVxBh6tDAfgJ2bO42BcRrc5Vgi1n5HBRnnjfBts1YFt+E4Jti3jF239P/ K4uJph8dorG3kj2oE0fB32NQ9YUTIbeJcaj+M7d1aJS8pFJeat1AWDrjHrl/7L1ACMsv 86rTRlHMa6iS52Kp9vdoYdcuu1MiLTMjdcSVjrewLUZLkzodXPsmRd+j0TTQ+eHogeL3 3ZmiAEhkr8YqnbmcUzqTJVCMIDUa1T3uQiCQn/Dejyv+M0R0hJtlJWr50f2vFuUMD3bM RmmLvV4nSzPvwU76fG7RMHnNhCwRfr+l2CQNwHCFSs3l05jdA1wq6idAPdLF1CB8G5dY 6bUg== X-Gm-Message-State: AOAM530IIISkjGDEEXYnZf8swypU74+fnW7EI3aavjpXLwno4hoxc6tw Q9Tz/Yi7E6oq6h9XbYQKWVP4+A== X-Google-Smtp-Source: ABdhPJxmExWR8o1VB4zLfYOJTgaHMqjEUh4d63DquBVWHk+OmmypFPtF6/Zcvmcermydd68ltPFevw== X-Received: by 2002:a17:90b:3907:b0:1c6:a16b:12e3 with SMTP id ob7-20020a17090b390700b001c6a16b12e3mr10896386pjb.157.1649263832284; Wed, 06 Apr 2022 09:50:32 -0700 (PDT) Received: from localhost ([2620:15c:202:201:c9d3:469f:91e4:c022]) by smtp.gmail.com with UTF8SMTPSA id v10-20020a63ac0a000000b0039901c45810sm13669836pge.47.2022.04.06.09.50.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Apr 2022 09:50:31 -0700 (PDT) From: Gwendal Grignou To: jic23@kernel.org, robh+dt@kernel.org, swboyd@chromium.org Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, Gwendal Grignou Subject: [PATCH v4 2/8] iio: sx9324: Fix register field spelling Date: Wed, 6 Apr 2022 09:50:05 -0700 Message-Id: <20220406165011.10202-3-gwendal@chromium.org> X-Mailer: git-send-email 2.35.1.1094.g7c7d902a7c-goog In-Reply-To: <20220406165011.10202-1-gwendal@chromium.org> References: <20220406165011.10202-1-gwendal@chromium.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Field for PROX_CTRL4 should contain PROX_CTRL4. Fixes: 4c18a890dff8d ("iio:proximity:sx9324: Add SX9324 support") Signed-off-by: Gwendal Grignou Reviewed-by: Stephen Boyd --- Changes since v3: - Added Review tags. Changes since v2: - no changes Changes since v1: - Add Fixes keyword in commit message. drivers/iio/proximity/sx9324.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/proximity/sx9324.c b/drivers/iio/proximity/sx9324.c index 378c2a17bae6e..a7d9a53692a6d 100644 --- a/drivers/iio/proximity/sx9324.c +++ b/drivers/iio/proximity/sx9324.c @@ -90,7 +90,7 @@ #define SX9324_REG_PROX_CTRL4_AVGNEGFILT_MASK GENMASK(5, 3) #define SX9324_REG_PROX_CTRL4_AVGNEG_FILT_2 0x08 #define SX9324_REG_PROX_CTRL4_AVGPOSFILT_MASK GENMASK(2, 0) -#define SX9324_REG_PROX_CTRL3_AVGPOS_FILT_256 0x04 +#define SX9324_REG_PROX_CTRL4_AVGPOS_FILT_256 0x04 #define SX9324_REG_PROX_CTRL5 0x35 #define SX9324_REG_PROX_CTRL5_HYST_MASK GENMASK(5, 4) #define SX9324_REG_PROX_CTRL5_CLOSE_DEBOUNCE_MASK GENMASK(3, 2) @@ -794,7 +794,7 @@ static const struct sx_common_reg_default sx9324_default_regs[] = { { SX9324_REG_PROX_CTRL3, SX9324_REG_PROX_CTRL3_AVGDEB_2SAMPLES | SX9324_REG_PROX_CTRL3_AVGPOS_THRESH_16K }, { SX9324_REG_PROX_CTRL4, SX9324_REG_PROX_CTRL4_AVGNEG_FILT_2 | - SX9324_REG_PROX_CTRL3_AVGPOS_FILT_256 }, + SX9324_REG_PROX_CTRL4_AVGPOS_FILT_256 }, { SX9324_REG_PROX_CTRL5, 0x00 }, { SX9324_REG_PROX_CTRL6, SX9324_REG_PROX_CTRL6_PROXTHRESH_32 }, { SX9324_REG_PROX_CTRL7, SX9324_REG_PROX_CTRL6_PROXTHRESH_32 }, From patchwork Wed Apr 6 16:50:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gwendal Grignou X-Patchwork-Id: 12803958 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEA01C4332F for ; Wed, 6 Apr 2022 18:11:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240101AbiDFSNb (ORCPT ); Wed, 6 Apr 2022 14:13:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60344 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240279AbiDFSNK (ORCPT ); Wed, 6 Apr 2022 14:13:10 -0400 Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ADC2D13366A for ; Wed, 6 Apr 2022 09:50:34 -0700 (PDT) Received: by mail-pf1-x42f.google.com with SMTP id z16so2997204pfh.3 for ; Wed, 06 Apr 2022 09:50:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GdvKq2bscTZt/VsXb1uunFIxTYvgH9XB58umwCf0yGg=; b=Pp/FPeYEqE+g40Rj8Vhn3PoKm2vryAt+M56GT2dHwPoyHHFJ+f0Zlwg4BqnfrF5jr7 259EwePTCaB2ZJel1eCL1qe6pjf5HA46zSYF1fbMxMXJrITsitLThA1bFKf/XXtam1ek 1+AvecIPIyOxW81SvM0Nw3WEYEOECnRFr16bk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GdvKq2bscTZt/VsXb1uunFIxTYvgH9XB58umwCf0yGg=; b=PX6+XFoNf85TMio+bWpO5P0xtb6oTxWCoLa9uyHXX2uFJOuNspU2giaUPk3ftL5XM3 mmScZ6BKFU4YesBVGzi8V3tzLqvYZa3oAUSEhku+Ur7h4VsN2yfhB8QLMSZa3+jQEopA bJtIJlD+jEI8hNWP7k7XLQmp3CHXWZyPOqksWsTcphQTAtd3YjFjd/35e6VPRz9cqrnR RD1CL5yvVRl0iQBy2rNbPfFefw+fHomk+f4cRfs15rC9YYdWrhmaBI4W2qBOEAAsr4kw GKCxApMsRrLIuj810QLZaCVhMkKiv0xMIP+mzfPgDI+S46U4PPN+NymEuuhj26jlMrLA FiqA== X-Gm-Message-State: AOAM531E+gGf1IHr7VPJJqHWQSj3+ujacwazvEqA6XvJMlTjlZOotF49 1Slq8bgtTcgZNgs0SMUb2ESR4Q== X-Google-Smtp-Source: ABdhPJw9n47rUsn59e8ap37YHUSGCW8Y62MEhOpU+JsO6DxlGg1HjTG0r4Ej5JPzXtgmrK8QrbxXmg== X-Received: by 2002:a05:6a00:134d:b0:4fb:1307:cef3 with SMTP id k13-20020a056a00134d00b004fb1307cef3mr10000560pfu.79.1649263834079; Wed, 06 Apr 2022 09:50:34 -0700 (PDT) Received: from localhost ([2620:15c:202:201:c9d3:469f:91e4:c022]) by smtp.gmail.com with UTF8SMTPSA id x123-20020a623181000000b004fdf99d25f6sm12463906pfx.80.2022.04.06.09.50.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Apr 2022 09:50:33 -0700 (PDT) From: Gwendal Grignou To: jic23@kernel.org, robh+dt@kernel.org, swboyd@chromium.org Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, Gwendal Grignou , Rob Herring Subject: [PATCH v4 3/8] dt-bindings: iio: sx9324: Add precharge resistor setting Date: Wed, 6 Apr 2022 09:50:06 -0700 Message-Id: <20220406165011.10202-4-gwendal@chromium.org> X-Mailer: git-send-email 2.35.1.1094.g7c7d902a7c-goog In-Reply-To: <20220406165011.10202-1-gwendal@chromium.org> References: <20220406165011.10202-1-gwendal@chromium.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Allow configure the resistance used during precharge. Signed-off-by: Gwendal Grignou Reviewed-by: Stephen Boyd Acked-by: Rob Herring --- Changes since v3: - Added Review tags. Changes since v2: - Change kOhms into ohms. Changes since v1: - Suffix field with kOhms unit. .../bindings/iio/proximity/semtech,sx9324.yaml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/Documentation/devicetree/bindings/iio/proximity/semtech,sx9324.yaml b/Documentation/devicetree/bindings/iio/proximity/semtech,sx9324.yaml index b8a6ee16854ff..a22cad1507b6b 100644 --- a/Documentation/devicetree/bindings/iio/proximity/semtech,sx9324.yaml +++ b/Documentation/devicetree/bindings/iio/proximity/semtech,sx9324.yaml @@ -126,6 +126,14 @@ properties: UINT_MAX (4294967295) represents infinite. Other values represent 1-1/N. + semtech,input-precharge-resistor-ohms: + default: 4000 + description: + Pre-charge input resistance in Ohm. + Rounded down to a 2000 Ohm multiple. + minimum: 0 + maximum: 30000 + required: - compatible - reg @@ -157,5 +165,6 @@ examples: semtech,ph01-proxraw-strength = <2>; semtech,ph23-proxraw-strength = <2>; semtech,avg-pos-strength = <64>; + semtech,input-precharge-resistor-ohms = <2000>; }; }; From patchwork Wed Apr 6 16:50:07 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gwendal Grignou X-Patchwork-Id: 12803960 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B112FC43219 for ; Wed, 6 Apr 2022 18:11:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240256AbiDFSNc (ORCPT ); Wed, 6 Apr 2022 14:13:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240286AbiDFSNL (ORCPT ); Wed, 6 Apr 2022 14:13:11 -0400 Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [IPv6:2607:f8b0:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2E2515EDC0 for ; Wed, 6 Apr 2022 09:50:35 -0700 (PDT) Received: by mail-pl1-x630.google.com with SMTP id n9so2467724plc.4 for ; Wed, 06 Apr 2022 09:50:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4P7e/QTs8wn6qj47LPpoe55zLRy/s7mxgSDGXvObcso=; b=mosDJgMTbuAEeGWSBBOJVYKHWb+uy+JM0xVt0xBaBGIyKSVcTL4B/LYGbiituFQk1x B/F1GzKThGl5xysLEVBANk8L4+eCtzcma7L8E5YKFAhOeiplWVp0xTV2T6kya+7/6jLF t0iCM4WIgF06f08W+OJk4uiPrRN+8nROUxPp8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4P7e/QTs8wn6qj47LPpoe55zLRy/s7mxgSDGXvObcso=; b=7w+V+SdkZCJjmM0lr/zeZkwD9JnHEseAqVwaou7KsYKQX1lT1/90zf/0sryq4A3uFx EviBwVqCz+rkXJ1d+amDdvX2I0zhnbOVKs+Ci/rqUN0CjAWW20N87tHSCRNRj5lr+kf0 s6Aplj5ySgq3RuShNsvzU3u7gmb514tQOP3c0PN4mYJ8wDXxl3rhPvmgH3qfl3V11+ht i8tCztI1f2/+123akf4uH525ue7A66g61yr34gKbNf4+KI6A9pPXCYLEdCe0wXDzW9M+ 4/t3901aGOqcMDh6p6X0vJHN3muzZ3vVzj9IponsKqMtj63BbH0JGZ6+aud7xFf/Acwv eS4A== X-Gm-Message-State: AOAM533sJOMlPfYFm4G5U4JLPASz4iQpktb+FSZQV4Ojm65z2TsE5gg4 mT2+it4WqKgghHkHNVfvdeawGA== X-Google-Smtp-Source: ABdhPJwe8dCFzb9OfeXN77GAVr2XjO9CyDChxHb1+7waxxZhuqHrqJ/ujHDyCYBYqIQLV8Ms1c1KqA== X-Received: by 2002:a17:902:da90:b0:154:1510:acc7 with SMTP id j16-20020a170902da9000b001541510acc7mr9517536plx.103.1649263835520; Wed, 06 Apr 2022 09:50:35 -0700 (PDT) Received: from localhost ([2620:15c:202:201:c9d3:469f:91e4:c022]) by smtp.gmail.com with UTF8SMTPSA id q203-20020a632ad4000000b003987c421eb2sm17122321pgq.34.2022.04.06.09.50.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Apr 2022 09:50:35 -0700 (PDT) From: Gwendal Grignou To: jic23@kernel.org, robh+dt@kernel.org, swboyd@chromium.org Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, Gwendal Grignou Subject: [PATCH v4 4/8] iio: sx9324: Add precharge internal resistance setting Date: Wed, 6 Apr 2022 09:50:07 -0700 Message-Id: <20220406165011.10202-5-gwendal@chromium.org> X-Mailer: git-send-email 2.35.1.1094.g7c7d902a7c-goog In-Reply-To: <20220406165011.10202-1-gwendal@chromium.org> References: <20220406165011.10202-1-gwendal@chromium.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Add ability to set the precharge internal resistance from the device tree. Signed-off-by: Gwendal Grignou Reviewed-by: Stephen Boyd --- Changes since v3: - Added Review tags. Changes since v2: - Change kOhms into ohms. Changes since v1: - Suffix field with kOhms unit. - Split patch in 2. drivers/iio/proximity/sx9324.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/iio/proximity/sx9324.c b/drivers/iio/proximity/sx9324.c index a7d9a53692a6d..691700de0b9d4 100644 --- a/drivers/iio/proximity/sx9324.c +++ b/drivers/iio/proximity/sx9324.c @@ -72,6 +72,7 @@ #define SX9324_REG_AFE_CTRL8 0x2c #define SX9324_REG_AFE_CTRL8_RESERVED 0x10 #define SX9324_REG_AFE_CTRL8_RESFILTIN_4KOHM 0x02 +#define SX9324_REG_AFE_CTRL8_RESFILTIN_MASK GENMASK(3, 0) #define SX9324_REG_AFE_CTRL9 0x2d #define SX9324_REG_AFE_CTRL9_AGAIN_1 0x08 @@ -893,6 +894,15 @@ sx9324_get_default_reg(struct device *dev, int idx, reg_def->def |= FIELD_PREP(SX9324_REG_AFE_CTRL4_RESOLUTION_MASK, raw); break; + case SX9324_REG_AFE_CTRL8: + ret = device_property_read_u32(dev, + "semtech,input-precharge-resistor-ohms", + &raw); + reg_def->def &= ~SX9324_REG_AFE_CTRL8_RESFILTIN_MASK; + reg_def->def |= FIELD_PREP(SX9324_REG_AFE_CTRL8_RESFILTIN_MASK, + raw / 2000); + break; + case SX9324_REG_ADV_CTRL5: ret = device_property_read_u32(dev, "semtech,startup-sensor", &start); From patchwork Wed Apr 6 16:50:08 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gwendal Grignou X-Patchwork-Id: 12803964 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D22C6C4332F for ; Wed, 6 Apr 2022 18:11:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240283AbiDFSNs (ORCPT ); Wed, 6 Apr 2022 14:13:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240340AbiDFSNL (ORCPT ); Wed, 6 Apr 2022 14:13:11 -0400 Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98D2D140DD7 for ; Wed, 6 Apr 2022 09:50:37 -0700 (PDT) Received: by mail-pf1-x433.google.com with SMTP id w7so2956695pfu.11 for ; Wed, 06 Apr 2022 09:50:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=EReQwLDpITzSuxpuTYCqKmyFkRWM0fiL0s9dOZnYNMU=; b=mIRy35eLzAo2AiUAQ6+6rDIAiJubAwwbFJc3kAnYE9ezR3KBdyDW4+pu1kEk3pzF/N veWNjSdrrNovXqLVA4IQxvTKISSEh9kXg+RfSnx4bJPbC7YKgCcd4ikci00xCkowRKLX Tggq12vtt2zc2PvOyUgxt42ILEud9VdAgyhHY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EReQwLDpITzSuxpuTYCqKmyFkRWM0fiL0s9dOZnYNMU=; b=rseOqqWejYmaq294AvJOfgB5buCImjo03Ob77pGetvCB8riLXipqEDbMokOvN6oDdr c1fXjV8WrIYLIYuI7FqH35ptKZ5ppdLKM/visPI3PMaKECPJ/vd96xlblseJC+sUgIGv HJSd//Pi7FBiKNGgBww+NOYNATAHGB8buqmtcjSFewLKFim8mbiSn+xPxoc7OcLfxdGM nf5e0ciO4HcgqSGYcppZufaViEDssPagXJ0vTvAwR6aUKqNITdmmd/juvU3AVU8s5d+l VNvjfQMQRgXb/Y998bGpeADl7vEobLnms/z3l7PDE5DdSx4RqNNe4t+k04k0n5cIQYeX Q56Q== X-Gm-Message-State: AOAM532z5yQmrmOhmSqrKgj2I1mAlySUO1bYvKaBu6aX0QGyR7AC4Q5l K6+2611wBQyTu5p7GCTdjyRYrJnUngRqVA== X-Google-Smtp-Source: ABdhPJw/8XSEVADvPjMzxdOkS3KsGOu811RyfZc/zr7UYu6EwjWvN6h4kn7jWZ1PT7+7NCX7X0DQnQ== X-Received: by 2002:a63:7741:0:b0:386:330e:1dcd with SMTP id s62-20020a637741000000b00386330e1dcdmr7641821pgc.71.1649263837029; Wed, 06 Apr 2022 09:50:37 -0700 (PDT) Received: from localhost ([2620:15c:202:201:c9d3:469f:91e4:c022]) by smtp.gmail.com with UTF8SMTPSA id x29-20020aa79a5d000000b004f0ef1822d3sm19617880pfj.128.2022.04.06.09.50.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Apr 2022 09:50:36 -0700 (PDT) From: Gwendal Grignou To: jic23@kernel.org, robh+dt@kernel.org, swboyd@chromium.org Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, Gwendal Grignou , Rob Herring Subject: [PATCH v4 5/8] dt-bindings: iio: sx9324: Add internal compensation resistor setting Date: Wed, 6 Apr 2022 09:50:08 -0700 Message-Id: <20220406165011.10202-6-gwendal@chromium.org> X-Mailer: git-send-email 2.35.1.1094.g7c7d902a7c-goog In-Reply-To: <20220406165011.10202-1-gwendal@chromium.org> References: <20220406165011.10202-1-gwendal@chromium.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Allow setting the internal resistor used for compensation. Signed-off-by: Gwendal Grignou Reviewed-by: Stephen Boyd Acked-by: Rob Herring --- Changes since v3: - Added Review tags. Changes since v2: - no changes Changes since v1: - no changes .../bindings/iio/proximity/semtech,sx9324.yaml | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/Documentation/devicetree/bindings/iio/proximity/semtech,sx9324.yaml b/Documentation/devicetree/bindings/iio/proximity/semtech,sx9324.yaml index a22cad1507b6b..f99b2c1cd3ac2 100644 --- a/Documentation/devicetree/bindings/iio/proximity/semtech,sx9324.yaml +++ b/Documentation/devicetree/bindings/iio/proximity/semtech,sx9324.yaml @@ -126,6 +126,15 @@ properties: UINT_MAX (4294967295) represents infinite. Other values represent 1-1/N. + semtech,int-comp-resistor: + description: + Internal resistor setting for compensation. + enum: + - lowest + - low + - high + - highest + semtech,input-precharge-resistor-ohms: default: 4000 description: @@ -165,6 +174,7 @@ examples: semtech,ph01-proxraw-strength = <2>; semtech,ph23-proxraw-strength = <2>; semtech,avg-pos-strength = <64>; + semtech,int-comp-resistor = "lowest"; semtech,input-precharge-resistor-ohms = <2000>; }; }; From patchwork Wed Apr 6 16:50:09 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gwendal Grignou X-Patchwork-Id: 12803961 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26091C433EF for ; Wed, 6 Apr 2022 18:11:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240564AbiDFSNd (ORCPT ); Wed, 6 Apr 2022 14:13:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240342AbiDFSNL (ORCPT ); Wed, 6 Apr 2022 14:13:11 -0400 Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 26377163E10 for ; Wed, 6 Apr 2022 09:50:39 -0700 (PDT) Received: by mail-pf1-x42b.google.com with SMTP id x16so2960075pfa.10 for ; Wed, 06 Apr 2022 09:50:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ILuDkANZMc0VPh49kP2rw7U3VdF/Cux1eFEmm5f7NZo=; b=RTymHclKzIwHxBbRZ3wjjyu/OJ9qr7wvbTGDhnbypS8SWUZvJJFvNTGyGiNvOhN0nM rZVPhXodK2X4vptC/yYH34d8o98cQULNBssFx7FTG8JnABkGwvme9EtG3sLURxTA8rjP mRFvLUnck7JUPOwO1NoGXduZzQKFSPpjIlmAI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ILuDkANZMc0VPh49kP2rw7U3VdF/Cux1eFEmm5f7NZo=; b=Z58qpwSEJgRUYOiWLlVzfbsxTMDpvaeb3HVgG7pnbnWzBOqmg7EQLQUIpRaMJsvpsO I8LMBKSxh9K3O2DYxIhqYq74ikqPUqoNnYblkb+mmohZ8mpJQS0RQe0h3H92QD0kuHlz rVObXZmX2DGa63iLzaK9NyNATVSwHssNWFAmsT1JeNbYVpXpKMihWM58cdfPGyDUu/Fn B/7L1ePn1I55WdTpxS9BY0CB4xTkk3p4pDuv3ttLT3kMNPucvs0i185u2OGrp5HwGBEC q02ZiGy4RVq/29d4Z16iCfPbdc8lsEet0iqqzJImvoeUzkm2NE5tMiJTh4X+F1K0RTDk HoKQ== X-Gm-Message-State: AOAM533ba0LcBVWdOb7+URtpO0+FBV21CTP1uE+lQVIWs/FHKBSqGpoW 4Rnz3wuA628bHJ19F5vy50JsOQ== X-Google-Smtp-Source: ABdhPJwMZXpSA5PcA7qhIlkx+9PQeQZdwuNPyEa5GqVR1r+P0B4s01HoM9Lc5sqHEizqRt3kP0pj1w== X-Received: by 2002:a05:6a00:1a12:b0:4fd:a5b4:b4c0 with SMTP id g18-20020a056a001a1200b004fda5b4b4c0mr9663702pfv.16.1649263838627; Wed, 06 Apr 2022 09:50:38 -0700 (PDT) Received: from localhost ([2620:15c:202:201:c9d3:469f:91e4:c022]) by smtp.gmail.com with UTF8SMTPSA id h13-20020a056a00230d00b004f427ffd485sm22025915pfh.143.2022.04.06.09.50.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Apr 2022 09:50:38 -0700 (PDT) From: Gwendal Grignou To: jic23@kernel.org, robh+dt@kernel.org, swboyd@chromium.org Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, Gwendal Grignou Subject: [PATCH v4 6/8] iio: sx9324: Add Setting for internal compensation resistor Date: Wed, 6 Apr 2022 09:50:09 -0700 Message-Id: <20220406165011.10202-7-gwendal@chromium.org> X-Mailer: git-send-email 2.35.1.1094.g7c7d902a7c-goog In-Reply-To: <20220406165011.10202-1-gwendal@chromium.org> References: <20220406165011.10202-1-gwendal@chromium.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Based on device tree setting, set the internal compensation resistor. Signed-off-by: Gwendal Grignou Reviewed-by: Stephen Boyd --- Changes since v3: - Use match_string() to prevent incorrect matching. Changes since v2: - No changes. Changes since v1: - No changes. drivers/iio/proximity/sx9324.c | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/drivers/iio/proximity/sx9324.c b/drivers/iio/proximity/sx9324.c index 691700de0b9d4..2dcfac09644bd 100644 --- a/drivers/iio/proximity/sx9324.c +++ b/drivers/iio/proximity/sx9324.c @@ -52,6 +52,11 @@ #define SX9324_REG_CLK_SPRD 0x15 #define SX9324_REG_AFE_CTRL0 0x20 +#define SX9324_REG_AFE_CTRL0_RINT_SHIFT 6 +#define SX9324_REG_AFE_CTRL0_RINT_MASK \ + GENMASK(SX9324_REG_AFE_CTRL0_RINT_SHIFT + 1, \ + SX9324_REG_AFE_CTRL0_RINT_SHIFT) +#define SX9324_REG_AFE_CTRL0_RINT_LOWEST 0x00 #define SX9324_REG_AFE_CTRL1 0x21 #define SX9324_REG_AFE_CTRL2 0x22 #define SX9324_REG_AFE_CTRL3 0x23 @@ -769,7 +774,7 @@ static const struct sx_common_reg_default sx9324_default_regs[] = { */ { SX9324_REG_GNRL_CTRL1, SX9324_REG_GNRL_CTRL1_PAUSECTRL }, - { SX9324_REG_AFE_CTRL0, 0x00 }, + { SX9324_REG_AFE_CTRL0, SX9324_REG_AFE_CTRL0_RINT_LOWEST }, { SX9324_REG_AFE_CTRL3, 0x00 }, { SX9324_REG_AFE_CTRL4, SX9324_REG_AFE_CTRL4_FREQ_83_33HZ | SX9324_REG_AFE_CTRL4_RES_100 }, @@ -848,6 +853,8 @@ static const struct sx_common_reg_default * sx9324_get_default_reg(struct device *dev, int idx, struct sx_common_reg_default *reg_def) { + static const char * const sx9324_rints[] = { "lowest", "low", "high", + "highest" }; #define SX9324_PIN_DEF "semtech,ph0-pin" #define SX9324_RESOLUTION_DEF "semtech,ph01-resolution" #define SX9324_PROXRAW_DEF "semtech,ph01-proxraw-strength" @@ -855,6 +862,7 @@ sx9324_get_default_reg(struct device *dev, int idx, char prop[] = SX9324_PROXRAW_DEF; u32 start = 0, raw = 0, pos = 0; int ret, count, ph, pin; + const char *res; memcpy(reg_def, &sx9324_default_regs[idx], sizeof(*reg_def)); switch (reg_def->reg) { @@ -875,6 +883,17 @@ sx9324_get_default_reg(struct device *dev, int idx, SX9324_REG_AFE_PH0_PIN_MASK(pin); reg_def->def = raw; break; + case SX9324_REG_AFE_CTRL0: + ret = device_property_read_string(dev, + "semtech,int-comp-resistor", &res); + if (ret) + break; + ret = match_string(sx9324_rints, ARRAY_SIZE(sx9324_rints), res); + if (ret < 0) + break; + reg_def->def &= ~SX9324_REG_AFE_CTRL0_RINT_MASK; + reg_def->def |= ret << SX9324_REG_AFE_CTRL0_RINT_SHIFT; + break; case SX9324_REG_AFE_CTRL4: case SX9324_REG_AFE_CTRL7: if (reg_def->reg == SX9324_REG_AFE_CTRL4) From patchwork Wed Apr 6 16:50:10 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gwendal Grignou X-Patchwork-Id: 12803963 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75A7EC433FE for ; Wed, 6 Apr 2022 18:11:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240189AbiDFSNr (ORCPT ); Wed, 6 Apr 2022 14:13:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51816 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240355AbiDFSNL (ORCPT ); Wed, 6 Apr 2022 14:13:11 -0400 Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9BCCCC5581 for ; Wed, 6 Apr 2022 09:50:40 -0700 (PDT) Received: by mail-pl1-x629.google.com with SMTP id d15so2448339pll.10 for ; Wed, 06 Apr 2022 09:50:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NwTLIXG6NYLkv6EJfl+8yB7+FdoszwL8ecou1g8gaKU=; b=gAYgnpBhrJuU2f4NBc/dm8OQkvdpbiPCRd7pRfz+XFIZnhlznJD/juizzx8B5zyBlA ai4qdK80/jW4ayldRym39ExLDEqAYXKAXFS7ipgobYAWHq9YZiHR6WJ7LcMNv32Dy+DJ UsRC+zlmb+1b7T8EmVf1IUrl33WHC1qzOEK98= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NwTLIXG6NYLkv6EJfl+8yB7+FdoszwL8ecou1g8gaKU=; b=Bvr3uqzkqtit2BWvjGWBp2xWZHkuupHB9dWKn4cmes6EvxXTthtbhJqFmamnvB5w59 ZLUd837HTnslCEtodvem4FIsRxHHjbrolioWO3ZQPXjh7/p04deRIMP8bzhROWsZEwWQ NTh8vGC8Mfq4exEk1fLiDlBQTr4RBPx4MMAAUqh7qRRpqvt25pNyhB/Z7TW2JXIJ5t0v u8rFrN80VMj+6GGJDOdQsgs4e8r8JFqfg+lw22gmVHpswtZrGdzqt02A1RFuxDdjWj9W YEPFoWKqDVmgi9U1XoQveuv+gOSMipIOWWVyx01r6iaehK+emeiIP3HFKSUKMIOUvPYd aKXQ== X-Gm-Message-State: AOAM533TV/+WyRstyuzFmQHuSmHGiaSUzYqYfbFiVNuCgzneAJGopi9D RU/Yt4Am/QjIWE1gQ1+QJurOhg== X-Google-Smtp-Source: ABdhPJxVKSQyEeWuWPRgm4Cp+DK1+VnKA2WARnQ3Ieg/UkHByCHKs3ljooT3+ArhQdIgP1+adZaSXw== X-Received: by 2002:a17:90b:2246:b0:1c6:5781:7193 with SMTP id hk6-20020a17090b224600b001c657817193mr11201226pjb.48.1649263840123; Wed, 06 Apr 2022 09:50:40 -0700 (PDT) Received: from localhost ([2620:15c:202:201:c9d3:469f:91e4:c022]) by smtp.gmail.com with UTF8SMTPSA id 68-20020a621647000000b004fa763ef1easm19547512pfw.125.2022.04.06.09.50.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Apr 2022 09:50:39 -0700 (PDT) From: Gwendal Grignou To: jic23@kernel.org, robh+dt@kernel.org, swboyd@chromium.org Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, Gwendal Grignou Subject: [PATCH v4 7/8] dt-bindings: iio: sx9360: Add precharge resistor setting Date: Wed, 6 Apr 2022 09:50:10 -0700 Message-Id: <20220406165011.10202-8-gwendal@chromium.org> X-Mailer: git-send-email 2.35.1.1094.g7c7d902a7c-goog In-Reply-To: <20220406165011.10202-1-gwendal@chromium.org> References: <20220406165011.10202-1-gwendal@chromium.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Allow configure the resistance used during precharge. Signed-off-by: Gwendal Grignou Reviewed-by: Stephen Boyd --- Changes since v3: - Fix maximum field. Check make dt_binding_check passes. Changes since v2: - Change kOhms into ohms. Changes since v1: - Suffix property with kOhms. .../bindings/iio/proximity/semtech,sx9360.yaml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/Documentation/devicetree/bindings/iio/proximity/semtech,sx9360.yaml b/Documentation/devicetree/bindings/iio/proximity/semtech,sx9360.yaml index 63e1a1fd00d4c..20c2759ced436 100644 --- a/Documentation/devicetree/bindings/iio/proximity/semtech,sx9360.yaml +++ b/Documentation/devicetree/bindings/iio/proximity/semtech,sx9360.yaml @@ -61,6 +61,14 @@ properties: UINT_MAX (4294967295) represents infinite. Other values represent 1-1/N. + semtech,input-precharge-resistor-ohms: + default: 0 + description: + Pre-charge input resistance in Ohm. + Rounded down to a 2000 Ohm multiple. + minimum: 0 + maximum: 30000 + required: - compatible - reg @@ -85,5 +93,6 @@ examples: semtech,resolution = <256>; semtech,proxraw-strength = <2>; semtech,avg-pos-strength = <64>; + semtech,input-precharge-resistor-ohms = <4000>; }; }; From patchwork Wed Apr 6 16:50:11 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gwendal Grignou X-Patchwork-Id: 12803962 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9265CC4332F for ; Wed, 6 Apr 2022 18:11:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240442AbiDFSNd (ORCPT ); Wed, 6 Apr 2022 14:13:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42724 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240358AbiDFSNM (ORCPT ); Wed, 6 Apr 2022 14:13:12 -0400 Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E6B237676 for ; Wed, 6 Apr 2022 09:50:41 -0700 (PDT) Received: by mail-pl1-x635.google.com with SMTP id n8so2482691plh.1 for ; Wed, 06 Apr 2022 09:50:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=53sX0CQ0dSON0UrxsaG2RHL4F5xS2YOFLLPeADqFZXc=; b=nJOnU3mFPmzMNMMWYADu/x5bs+vys214sWEUHjki9biwd0uDPdNyflMt3p4loIxQoD YYR98iSr4RI1SteBsjtXI2quY1Ofbx4sMmMZLOpRJ7i8SDYJ8O+I7qJCQJOxI+hvkkL8 fH9Th5Rl7MuBOcLdIoW96IV58FXjFfOit7foY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=53sX0CQ0dSON0UrxsaG2RHL4F5xS2YOFLLPeADqFZXc=; b=okjBtCIzlOK3Zm48e9UFhntBZZ6VqqT7RdfOOw4g0+a2mmpR+IeoJWSpomru1hgxiM PvfewBEDCe6zi8HUmhl8KSZ9juVa1Beb4iyqMX0vkPe7g3hyxMSQtDOKy7z6sO0eSnj3 q2GJg8uA2LQ8OFiYzutFmqdMEU+2fGAKOskhhzjuH5jztPoHANozLoBTSyxJcsiP3LZV qq7OhWYRxQ1vUiCrXRkvcKj7uAtuWvvvzMzXe19hoFTh+HLzylgrDsQyyMGpCnNNSee0 4DNXNmyhXZnxocdzbRrs/abl/rU2YoQP0Na8ZR5lHVwCHyyFet8wll2yS/BHlH0+LTi9 DRtQ== X-Gm-Message-State: AOAM532jgY5I07KnmttWm7QibfO2x0XKj9YsDUuzBnM3RLQg0VX8Wefm 20vg/XFAKgaJjDoAJ7eFSvXKPQ== X-Google-Smtp-Source: ABdhPJzDtKK4ffie+FK5FYkGI38BvdFWKS60/cXQ0DEADdP15hgakmPadlbxTklI6kRa6OcmBgxfbg== X-Received: by 2002:a17:90b:4a47:b0:1c6:42c6:fef2 with SMTP id lb7-20020a17090b4a4700b001c642c6fef2mr10717342pjb.147.1649263841428; Wed, 06 Apr 2022 09:50:41 -0700 (PDT) Received: from localhost ([2620:15c:202:201:c9d3:469f:91e4:c022]) by smtp.gmail.com with UTF8SMTPSA id s3-20020a056a00194300b004f6da3a1a3bsm22030709pfk.8.2022.04.06.09.50.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Apr 2022 09:50:41 -0700 (PDT) From: Gwendal Grignou To: jic23@kernel.org, robh+dt@kernel.org, swboyd@chromium.org Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, Gwendal Grignou Subject: [PATCH v4 8/8] iio: sx9360: Add pre-charge resistor setting Date: Wed, 6 Apr 2022 09:50:11 -0700 Message-Id: <20220406165011.10202-9-gwendal@chromium.org> X-Mailer: git-send-email 2.35.1.1094.g7c7d902a7c-goog In-Reply-To: <20220406165011.10202-1-gwendal@chromium.org> References: <20220406165011.10202-1-gwendal@chromium.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Add ability to set the precharge internal resistance from the device tree. Signed-off-by: Gwendal Grignou Reviewed-by: Stephen Boyd --- Changes since v3: - Added Review tags. Changes since v2: - Change kOhms into ohms. Changes since v1: - Suffix field with kOhms unit. drivers/iio/proximity/sx9360.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/iio/proximity/sx9360.c b/drivers/iio/proximity/sx9360.c index 3ebb30c8a4f61..21cade4358aeb 100644 --- a/drivers/iio/proximity/sx9360.c +++ b/drivers/iio/proximity/sx9360.c @@ -51,6 +51,8 @@ #define SX9360_REG_GNRL_REG_2_FREQ(_r) (SX9360_FOSC_HZ / ((_r) * 8192)) #define SX9360_REG_AFE_CTRL1 0x21 +#define SX9360_REG_AFE_CTRL1_RESFILTIN_MASK GENMASK(3, 0) +#define SX9360_REG_AFE_CTRL1_RESFILTIN_0OHMS 0 #define SX9360_REG_AFE_PARAM0_PHR 0x22 #define SX9360_REG_AFE_PARAM1_PHR 0x23 #define SX9360_REG_AFE_PARAM0_PHM 0x24 @@ -671,7 +673,7 @@ static const struct sx_common_reg_default sx9360_default_regs[] = { { SX9360_REG_GNRL_CTRL1, 0x00 }, { SX9360_REG_GNRL_CTRL2, SX9360_REG_GNRL_CTRL2_PERIOD_102MS }, - { SX9360_REG_AFE_CTRL1, 0x00 }, + { SX9360_REG_AFE_CTRL1, SX9360_REG_AFE_CTRL1_RESFILTIN_0OHMS }, { SX9360_REG_AFE_PARAM0_PHR, SX9360_REG_AFE_PARAM0_RSVD | SX9360_REG_AFE_PARAM0_RESOLUTION_128 }, { SX9360_REG_AFE_PARAM1_PHR, SX9360_REG_AFE_PARAM1_AGAIN_PHM_6PF | @@ -722,6 +724,14 @@ sx9360_get_default_reg(struct device *dev, int idx, memcpy(reg_def, &sx9360_default_regs[idx], sizeof(*reg_def)); switch (reg_def->reg) { + case SX9360_REG_AFE_CTRL1: + ret = device_property_read_u32(dev, + "semtech,input-precharge-resistor-ohms", + &raw); + reg_def->def &= ~SX9360_REG_AFE_CTRL1_RESFILTIN_MASK; + reg_def->def |= FIELD_PREP(SX9360_REG_AFE_CTRL1_RESFILTIN_MASK, + raw / 2000); + break; case SX9360_REG_AFE_PARAM0_PHR: case SX9360_REG_AFE_PARAM0_PHM: ret = device_property_read_u32(dev, "semtech,resolution", &raw);