From patchwork Sat Apr 9 04:51:44 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Drew Fustini X-Patchwork-Id: 12807702 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3F629C433F5 for ; Sat, 9 Apr 2022 05:26:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=q7sQszVssqsT5drvnTXQAlEAn2eDYb9NOtjoSuvQbSA=; b=PQWeS2Cz2vz451 99/IFFe1kj8wGLSUV7++55BrRm4I3fyaksM1zn7uHmkkxxjDUlq2CkB0fg2dNPvfecu+GAlljH+p2 Gxq5IkPi9KByi9JcXkReSOTOWcw2+eNMFBHGPwnkj1i4ZpWHhPo8ljIpfZYfMr7tnMMGaYzDSrL67 W3KVD/KjsVadAltuXy5rkDNNTDBOr+QEx+di4OqcAwrQ+kF0YlZOHiUAXzqDSGnyeS8VBn3k58dy6 962IPvI1GXc9v8QdBkGWmzSyC9sYe2c3N4xXYU/2KFLtfcnhwXQPvW9H3u165QdpuhHZvJLnCziIl jRMpyCxos1tTzkoJWStw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nd3aX-002H82-Sn; Sat, 09 Apr 2022 05:24:46 +0000 Received: from mail-pj1-x1030.google.com ([2607:f8b0:4864:20::1030]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nd36v-00234Q-G9 for linux-arm-kernel@lists.infradead.org; Sat, 09 Apr 2022 04:54:11 +0000 Received: by mail-pj1-x1030.google.com with SMTP id n6-20020a17090a670600b001caa71a9c4aso11571080pjj.1 for ; Fri, 08 Apr 2022 21:54:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mAVbfi6r8F9XdOp98CXkQS4IikBYdUQdfQIzN1ojFoM=; b=I/IQJ8d02ZalKbRD9x+9un6Ur9ihwCEn62DFrCYP+LUJvcEkMy9zT8j/xjMogTUfmh ysLEGeTTqw0Vhbye1/P/HnC50F4qlhJFGhJigwefnD01sx14HbPaHv2BthwBJsnssT28 K6anhWrgGSNN6b3RkXUODbFA2UJRBLjgM2NPq07x4Wqiz7qSkU5Aw4WHUGmT+Q+xtpkZ ffJawzl9HF5OIkuTB7aEXpl/BbFCjzZFolSj6F4P/S4SHfhJ1CY/CInaLlKBqGdIlfVk yFao5G+t81Nx1ib4TCQugWBpgHaiApTjoquKJzFir51tTOA5ErQmmmLE8qcNpwrqa+gP HSFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mAVbfi6r8F9XdOp98CXkQS4IikBYdUQdfQIzN1ojFoM=; b=FUVZA77xVYJnHUOJdxgtTb23nb5+JRQQgLfJTSk8kPt+BTcf0lQpHbO1HDwo76144O cjBRTo6JuN6JMk/ssceGWE5OQgfE3HGXkWk2V07pgLDg1YN11pRux2mEboLTnypLuZCp Cl0vp7WCqo3D7OQ27BeEYRsKSPSzMulUOceQX8dUymRkJTa1sQ5Phx9xT27oM0455PYy CNY1GyDzeFITvBz8fJXsyukghAdpKFOzl2sdalqa6vRD9RYEXDcbJSL7b747ZJuolCf1 mYcGmOa1TvHBtJ1kRiIFA7qAiYLvZFVifcKrk7IuKAEkio700jCnu5bWP0CtLIZ9s2D2 /Ghg== X-Gm-Message-State: AOAM5331iF6IjbD8EVWQFpzETVl56DQB/p+7vBgb5uq9O7SqwWKmXlpi nrpEU8Obn0pXQN8gWxzeItk79A== X-Google-Smtp-Source: ABdhPJzOiK3fWm5z6/3iLAE1BHB2BQCOndg+LCsa9XjF4l26qFeIxpOju+iIkW8wAUi3K5Aq2LN5pw== X-Received: by 2002:a17:902:e883:b0:153:f7b8:fa9 with SMTP id w3-20020a170902e88300b00153f7b80fa9mr22711094plg.96.1649480047757; Fri, 08 Apr 2022 21:54:07 -0700 (PDT) Received: from x1.hsd1.or.comcast.net ([2601:1c2:1001:7090:8fa3:3402:f693:9f86]) by smtp.gmail.com with ESMTPSA id k6-20020a056a00134600b004faba67f9d4sm28423050pfu.197.2022.04.08.21.54.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Apr 2022 21:54:07 -0700 (PDT) From: Drew Fustini To: Rob Herring , Krzysztof Kozlowski , Nishanth Menon , Santosh Shilimkar , Dave Gerlach , Tony Lindgren Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Drew Fustini Subject: [PATCH 1/2] dt-bindings: wkup-m3-ipc: Add vtt toggle bindings Date: Fri, 8 Apr 2022 21:51:44 -0700 Message-Id: <20220409045145.2434096-2-dfustini@baylibre.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220409045145.2434096-1-dfustini@baylibre.com> References: <20220409045145.2434096-1-dfustini@baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220408_215409_646750_74D94F17 X-CRM114-Status: GOOD ( 14.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Document the Wakeup M3 IPC properties that can be used to toggle the VTT regulator during low power mode transitions. Signed-off-by: Dave Gerlach [dfustini: converted to YAML] Signed-off-by: Drew Fustini --- .../bindings/soc/ti/wkup-m3-ipc.yaml | 21 +++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/Documentation/devicetree/bindings/soc/ti/wkup-m3-ipc.yaml b/Documentation/devicetree/bindings/soc/ti/wkup-m3-ipc.yaml index d855c01ce61c..6a8fcad8b2fd 100644 --- a/Documentation/devicetree/bindings/soc/ti/wkup-m3-ipc.yaml +++ b/Documentation/devicetree/bindings/soc/ti/wkup-m3-ipc.yaml @@ -24,6 +24,16 @@ description: |+ A wkup_m3_ipc device node is used to represent the IPC registers within an SoC. + Support for VTT Toggle + ================================== + In order to enable the support for VTT toggle during Suspend/Resume sequence + needed by some boards (like AM335x EVM-SK & AM437x GP EVM), the vtt properties + below are required. It is possible to toggle VTT using one of two methods + depending on the SoC being used, either GPIO0 toggle (AM335x and AM437x), or + any GPIO with DS_PAD_CONFIG bits in the control module (AM437x only). Please + note that only pins on the GPIO0 module can be used for GPIO toggle. It will + not work with any other GPIO module. + properties: compatible: enum: @@ -51,6 +61,15 @@ properties: mbox_wkupm3 child node. maxItems: 1 + ti,needs-vtt-toggle: + type: boolean + description: boards requires VTT toggling during suspend/resume + + ti,vtt-gpio-pin: + $ref: /schemas/types.yaml#/definitions/uint32 + description: pin on the GPIO0 module used for VTT toggle + maxItems: 1 + required: - compatible - reg @@ -76,6 +95,8 @@ examples: interrupts = <78>; ti,rproc = <&wkup_m3>; mboxes = <&mailbox &mbox_wkupm3>; + ti,needs-vtt-toggle; + ti,vtt-gpio-pin = <7>; }; }; ... From patchwork Sat Apr 9 04:51:45 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Drew Fustini X-Patchwork-Id: 12807703 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4B04AC433EF for ; Sat, 9 Apr 2022 05:27:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=C2y+qDiAISQ95w7xhQbi0vfMLF24HnE8IIYqKwkgBTs=; b=b52YldcvhYHBoi +/9+gSvlAGpKLQG6rkI3F7wUSPMfewm67+fPn8eDW9YANVpAIZwlvIYuwBLpdmzF3gc6Fk8eZmGR8 zJCdDfxgzeUKl3r0oMchUF4uDPuN5+32d8RmWpdmKtVv3mlRgZvJ9WJp+f0BTg+0cFwr9o3d66aNL Aw6KeZscFOEdgN/yseK0F6iRqpqNFFNlYulLqKO5BCLk4VSYsbO9Ob2MLnq9bMGEQFThE6hj02hQu 8X/Gus40aVT/Bar/4QSpFHqwcHc6gEjIQOlhaPofupF0eXb7npf9SXuMTNF9imNoYmK4V+iYOxGGT dqC/qCE9Hlbwo7SHjqsw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nd3bN-002HWV-SG; Sat, 09 Apr 2022 05:25:41 +0000 Received: from mail-pf1-x435.google.com ([2607:f8b0:4864:20::435]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nd36w-00235O-Uh for linux-arm-kernel@lists.infradead.org; Sat, 09 Apr 2022 04:54:12 +0000 Received: by mail-pf1-x435.google.com with SMTP id h19so10165397pfv.1 for ; Fri, 08 Apr 2022 21:54:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0FSMl2l16K/gl13Zkq9p7J1+n7AVpMqSjL319MjBslk=; b=f8q2LsZ3fu25tNPoP1dPPW2SWEZHiYPUc4dmuQsuRQX3RIHDgHRLRvFjBPTMCHgdTA uwIfQ6fvE0GBFYMYzWYK0s4GWH73EHZLDQewePd9t4fPn1sq57fyXWZCCizSlRcR9Q0n Voj3Z4uDMztrsQFnhFSw/3neUlL4Ho/DQh8v5zhBDHslgurbPd8NmMTlFpZJXjyDoCdJ UCkKn726gTrnEZf2broMTcG6pF/9ucVFhLc0uGfbIb7PfaIRBj+TaWebt44CKDwrN/Up 6P5Cws4IrW2Aa+yJweZcX7b5RfG3Fbj0JfXCnYSMIT4M3WyJGiYlTL/SpW9/cqLKjUV2 PSKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0FSMl2l16K/gl13Zkq9p7J1+n7AVpMqSjL319MjBslk=; b=W/CtKnYb7dTi7nY7WZ29dBvCe8lEplDPCMO3L5bLQvrHl/ngbnO7n7XI+/ppuI1Kxh oG8R8vEkx/WSjU4mgOK1p8bKOLkDFEMFu0RhvCv9npimxl6elx7n5ER/549PUFfQYOrk k0nzbB92I8dx2UuEosjiXacWN7+3iytT2OocWcWmMy/U4JQdX0Cs6y0CDo8jgppphj5B XV2PcfRjLerm2fh6zHH5Yh6g+0Jn/e1BjB5GcQXqF+nw/ixpfdiGa3AT/lDFsb2MQDSP bXf4GLfJ7r8uBOCNqD4cimBCnkSdRq0Tb3ZdnKfsPj8IRikJ9JTEELvNo3fVIDq27xi5 AX4Q== X-Gm-Message-State: AOAM532co87mZcvbjgRwlH3ZNUw3mQMYcdroiP45q1PXE4gX/WUI47rb YRhoKAlmpIp/YPA+l5UCQ8AB7Te/GjcUtA== X-Google-Smtp-Source: ABdhPJylLEgTAoaTFJvLKSHpb+nVvTv8/O/u2Nrurc3h+pvbM18KHPe0h0KE2zYt5zXkslcbp65K1A== X-Received: by 2002:a63:5d1c:0:b0:39c:c5d7:ebbb with SMTP id r28-20020a635d1c000000b0039cc5d7ebbbmr9722766pgb.54.1649480049291; Fri, 08 Apr 2022 21:54:09 -0700 (PDT) Received: from x1.hsd1.or.comcast.net ([2601:1c2:1001:7090:8fa3:3402:f693:9f86]) by smtp.gmail.com with ESMTPSA id k6-20020a056a00134600b004faba67f9d4sm28423050pfu.197.2022.04.08.21.54.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Apr 2022 21:54:08 -0700 (PDT) From: Drew Fustini To: Rob Herring , Krzysztof Kozlowski , Nishanth Menon , Santosh Shilimkar , Dave Gerlach , Tony Lindgren Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Drew Fustini , Keerthy Subject: [PATCH 2/2] soc: ti: wkup_m3_ipc: Add support for toggling VTT regulator Date: Fri, 8 Apr 2022 21:51:45 -0700 Message-Id: <20220409045145.2434096-3-dfustini@baylibre.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220409045145.2434096-1-dfustini@baylibre.com> References: <20220409045145.2434096-1-dfustini@baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220408_215411_095533_B79B47C4 X-CRM114-Status: GOOD ( 23.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Dave Gerlach Some boards (currently AM335x EVM-SK) provides s/w control via GPIO to toggle VTT regulator to reduce power consumption in low power state. The VTT regulator should be disabled after enabling self-refresh on suspend, and should be enabled before disabling self-refresh on resume. This is to allow proper self-refresh entry/exit commands to be transmitted to the memory. Add support for toggling VTT regulator using DT properties. Actual toggling happens in CM3 Firmware. The enable option & the GPIO pin used is collected in A8 Core and then sent to CM3 using IPC registers. Note: Here it is assumed that VTT Toggle will be done using a pin on GPIO-0 Instance. The reason is GPIO-0 is in wakeup domain. Signed-off-by: Dave Gerlach Signed-off-by: Keerthy Signed-off-by: Drew Fustini --- drivers/soc/ti/wkup_m3_ipc.c | 27 +++++++++++++++++++++++++-- include/linux/wkup_m3_ipc.h | 1 + 2 files changed, 26 insertions(+), 2 deletions(-) diff --git a/drivers/soc/ti/wkup_m3_ipc.c b/drivers/soc/ti/wkup_m3_ipc.c index 2f03ced0f411..8b92425255a2 100644 --- a/drivers/soc/ti/wkup_m3_ipc.c +++ b/drivers/soc/ti/wkup_m3_ipc.c @@ -40,6 +40,13 @@ #define M3_FW_VERSION_MASK 0xffff #define M3_WAKE_SRC_MASK 0xff +#define IPC_MEM_TYPE_SHIFT (0x0) +#define IPC_MEM_TYPE_MASK (0x7 << 0) +#define IPC_VTT_STAT_SHIFT (0x3) +#define IPC_VTT_STAT_MASK (0x1 << 3) +#define IPC_VTT_GPIO_PIN_SHIFT (0x4) +#define IPC_VTT_GPIO_PIN_MASK (0x3f << 4) + #define M3_STATE_UNKNOWN 0 #define M3_STATE_RESET 1 #define M3_STATE_INITED 2 @@ -215,6 +222,12 @@ static int wkup_m3_is_available(struct wkup_m3_ipc *m3_ipc) (m3_ipc->state != M3_STATE_UNKNOWN)); } +static void wkup_m3_set_vtt_gpio(struct wkup_m3_ipc *m3_ipc, int gpio) +{ + m3_ipc->vtt_conf = (1 << IPC_VTT_STAT_SHIFT) | + (gpio << IPC_VTT_GPIO_PIN_SHIFT); +} + /* Public functions */ /** * wkup_m3_set_mem_type - Pass wkup_m3 which type of memory is in use @@ -294,7 +307,8 @@ static int wkup_m3_prepare_low_power(struct wkup_m3_ipc *m3_ipc, int state) /* Program each required IPC register then write defaults to others */ wkup_m3_ctrl_ipc_write(m3_ipc, m3_ipc->resume_addr, 0); wkup_m3_ctrl_ipc_write(m3_ipc, m3_power_state, 1); - wkup_m3_ctrl_ipc_write(m3_ipc, m3_ipc->mem_type, 4); + wkup_m3_ctrl_ipc_write(m3_ipc, m3_ipc->mem_type | + m3_ipc->vtt_conf, 4); wkup_m3_ctrl_ipc_write(m3_ipc, DS_IPC_DEFAULT, 2); wkup_m3_ctrl_ipc_write(m3_ipc, DS_IPC_DEFAULT, 3); @@ -433,12 +447,13 @@ static int wkup_m3_rproc_boot_thread(void *arg) static int wkup_m3_ipc_probe(struct platform_device *pdev) { struct device *dev = &pdev->dev; - int irq, ret; + int irq, ret, temp; phandle rproc_phandle; struct rproc *m3_rproc; struct resource *res; struct task_struct *task; struct wkup_m3_ipc *m3_ipc; + struct device_node *np = dev->of_node; m3_ipc = devm_kzalloc(dev, sizeof(*m3_ipc), GFP_KERNEL); if (!m3_ipc) @@ -496,6 +511,14 @@ static int wkup_m3_ipc_probe(struct platform_device *pdev) m3_ipc->ops = &ipc_ops; + if (of_find_property(np, "ti,needs-vtt-toggle", NULL) && + !(of_property_read_u32(np, "ti,vtt-gpio-pin", &temp))) { + if (temp >= 0 && temp <= 31) + wkup_m3_set_vtt_gpio(m3_ipc, temp); + else + dev_warn(dev, "Invalid VTT GPIO(%d) pin\n", temp); + } + /* * Wait for firmware loading completion in a thread so we * can boot the wkup_m3 as soon as it's ready without holding diff --git a/include/linux/wkup_m3_ipc.h b/include/linux/wkup_m3_ipc.h index 3f496967b538..2bc52c6381d5 100644 --- a/include/linux/wkup_m3_ipc.h +++ b/include/linux/wkup_m3_ipc.h @@ -33,6 +33,7 @@ struct wkup_m3_ipc { int mem_type; unsigned long resume_addr; + int vtt_conf; int state; struct completion sync_complete;