From patchwork Sat Apr 16 13:37:15 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nava kishore Manne X-Patchwork-Id: 12815831 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29D7AC433F5 for ; Sat, 16 Apr 2022 13:39:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232076AbiDPNkH (ORCPT ); Sat, 16 Apr 2022 09:40:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55406 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231387AbiDPNkG (ORCPT ); Sat, 16 Apr 2022 09:40:06 -0400 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2079.outbound.protection.outlook.com [40.107.223.79]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 91F1BD3737; Sat, 16 Apr 2022 06:37:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UmbQzA6j1flGWbXciRZqUsNRzLhC01HcaWKU5s6yNZZZhajmvHZ/MAhyfzaNUB5FMzpl6S4xYxBbaJOYLqvs8z++dsCzo60nUel2EntK38U8sYcEymaY5FKefa226jrpFQDkI4cryHj5ndR3NdcyiEAvYfFf7cVaQuqyg+ZQsTZblt1Lxu+KMahRXGWXC71oLWJ5DFQ5j8AY/iBw2sncrvzRLQKWCdsOHpDWcz7OHRWYTEi1dZrOLlc73d2RGVbHoILWzdTbH7YO6pG3XedTwxUgOWQ4qX+xSguL20+F4ZDgnke5nP8NdIrQOyR34wrp/Fvd6vc3f8b4tjacxaq3wA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wREnmfHXmJi/4pzRfxLgzRdTnMxt4bSq6450Laxcd+o=; b=W+jUv7QELzKxi/TnvAhGfYFno6VEz0lVHKeS15a6nSc88PWEMcFFC2aZM66N6tchAGI3bvKrp6k+rU2JeVBcYBszK55Nm4DF9DyqSto/0FuNx9c3+tX3ecgzXsOLpU3PDqEMScS6uOhAsoYKlUVXE5isdsVjeVBeNWIPxDfyqhhRthWiRjhPyBbPLV0iUaA015IU+HAX69Z39QF4TjPLpthjO/ljVsi3VKdqMmt9wb8HJfDGtMSHc753vSb4VMJD8LdrR8C5PCwmzNalO+VCtw4RbeChzmhv9jbSpXwGiuvd/WAP/7EAcx8bxb0eLXqe7ob3ECEEguu+CyzZL/Pi/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=kernel.org smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wREnmfHXmJi/4pzRfxLgzRdTnMxt4bSq6450Laxcd+o=; b=HGUq2vw0EWkbz2lar+UF8leIvVwtX8KByI8ZaBbfkq6jqXrPk2Wv6Z/AselOLw7CVr75y8QiZtQ5rYJaW559PUbehnl9gA0i1sUUnQQWA5Z5UIgywGz6FsKvbHJ1yjf5bsiYIprRh3Pu8FXl0FwjnxQHivYqJ79r0vuojMhCsf8= Received: from BN0PR04CA0167.namprd04.prod.outlook.com (2603:10b6:408:eb::22) by SA0PR02MB7338.namprd02.prod.outlook.com (2603:10b6:806:ec::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Sat, 16 Apr 2022 13:37:31 +0000 Received: from BN1NAM02FT048.eop-nam02.prod.protection.outlook.com (2603:10b6:408:eb:cafe::e8) by BN0PR04CA0167.outlook.office365.com (2603:10b6:408:eb::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20 via Frontend Transport; Sat, 16 Apr 2022 13:37:30 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch01.xlnx.xilinx.com; Received: from xsj-pvapexch01.xlnx.xilinx.com (149.199.62.198) by BN1NAM02FT048.mail.protection.outlook.com (10.13.2.157) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5164.19 via Frontend Transport; Sat, 16 Apr 2022 13:37:30 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch01.xlnx.xilinx.com (172.19.86.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Sat, 16 Apr 2022 06:37:28 -0700 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Sat, 16 Apr 2022 06:37:28 -0700 Envelope-to: git@xilinx.com, mdf@kernel.org, hao.wu@intel.com, yilun.xu@intel.com, trix@redhat.com, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Received: from [10.140.6.60] (port=32988 helo=xhdnavam40.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1nficC-00088I-C0; Sat, 16 Apr 2022 06:37:28 -0700 From: Nava kishore Manne To: , , , , , , , , CC: Nava kishore Manne Subject: [PATCH v4 1/5] fpga: zynq: Fix incorrect variable type Date: Sat, 16 Apr 2022 19:07:15 +0530 Message-ID: <20220416133719.3382895-2-nava.manne@xilinx.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220416133719.3382895-1-nava.manne@xilinx.com> References: <20220416133719.3382895-1-nava.manne@xilinx.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 45cfdab7-0b99-4d09-94bc-08da1fae4150 X-MS-TrafficTypeDiagnostic: SA0PR02MB7338:EE_ X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0YXzMV3JNJ/pIrLzOVPc+5+V0PhjPJV0xE5lbXltkvYfIGH/iZC2oCtXuf/sDT6GfZDp8uzsjHhsV+fxNinD5u6H+pxIoyqdUHAhXHsNxtNjOsJB05FhQx0O48JqcytlvrjXXQQ1yC8+9fhK25ZWEjPw90oZheyGHYnQsi+7d3gKJwNCWoFgrMUwCZ4AT3scQvjcMLLKRevqWZ0KWex8refMmr2LZYmfi4mx9sXSnlbun+wysG0cNrMtoqB8hek6vOhgtjuG3f8TeoGQs80OKzwMu1XJqgGIRSH7Br3oHn5wkPRKcM3Gjp7MG/cyo1U2X668rdnfTMhUzq4GPjWyVzfic1tYjMtq3qrC5ZitWE4BzvFaa7LUG48zscIlllt3TlMAXGuTmkhrXggq4Hio1cxyEpHdppdEwstHF9chctHAdHKe2ODvYAzo3pHRfzsLXntDp8m5oYIULxHNO49zdfBJ1Nk8edLDwSWSEGoNDszXDG6ppk9LZQ/Qa/ujd+KdVtg/ILN46MFKGuuOoM2yez5hCYCHBQOBwO1zdAU07K6J99TNjKd9DTsyfaNPzz1BCkG8vdnvX3XN5hNpRWBnvFMl13SHreX8qi//tyooqRJy/JFnazelOGA1H5uE2wr5+8GPcQp6b4iqEIIgtmZYtq7lKiaq2D9ZJgfCZCnK8jTQvftvaF3FP67R38FmB0whMryUVYigsshCg/MsEKPaETozUHcynPIo0fR+mh2kmRk= X-Forefront-Antispam-Report: CIP:149.199.62.198;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapexch01.xlnx.xilinx.com;PTR:unknown-62-198.xilinx.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(356005)(36756003)(6636002)(8936002)(36860700001)(110136005)(70206006)(47076005)(83380400001)(316002)(7636003)(82310400005)(336012)(426003)(2906002)(8676002)(4326008)(107886003)(6666004)(70586007)(1076003)(186003)(7696005)(5660300002)(508600001)(9786002)(26005)(40460700003)(2616005)(102446001)(2101003);DIR:OUT;SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Apr 2022 13:37:30.5510 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 45cfdab7-0b99-4d09-94bc-08da1fae4150 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: BN1NAM02FT048.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR02MB7338 Precedence: bulk List-ID: X-Mailing-List: linux-fpga@vger.kernel.org zynq_fpga_has_sync () API is expecting "u8 *" but the formal parameter that was passed is of type "const char *". fixes this issue by changing the buf type to "const char *" This patch will also update zynq_fpga_has_sync () API description to align with API functionality. Signed-off-by: Nava kishore Manne --- Changes for v2: -None. Changes for v3: - Changed arg buf type to "const char *" as suggested by Tom. - update zynq_fpga_has_sync () API description to align with API functionality. Changes for v4: - None. drivers/fpga/zynq-fpga.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/fpga/zynq-fpga.c b/drivers/fpga/zynq-fpga.c index 426aa34c6a0d..ada07eea64bc 100644 --- a/drivers/fpga/zynq-fpga.c +++ b/drivers/fpga/zynq-fpga.c @@ -235,11 +235,11 @@ static irqreturn_t zynq_fpga_isr(int irq, void *data) return IRQ_HANDLED; } -/* Sanity check the proposed bitstream. It must start with the sync word in - * the correct byte order, and be dword aligned. The input is a Xilinx .bin - * file with every 32 bit quantity swapped. +/* Sanity check the proposed bitstream. The sync word must be found in the + * correct byte order and it should be dword aligned. The input is a + * Xilinx.bin file with every 32 bit quantity swapped. */ -static bool zynq_fpga_has_sync(const u8 *buf, size_t count) +static bool zynq_fpga_has_sync(const char *buf, size_t count) { for (; count >= 4; buf += 4, count -= 4) if (buf[0] == 0x66 && buf[1] == 0x55 && buf[2] == 0x99 && From patchwork Sat Apr 16 13:37:16 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nava kishore Manne X-Patchwork-Id: 12815833 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE9A2C433F5 for ; Sat, 16 Apr 2022 13:39:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232083AbiDPNkQ (ORCPT ); Sat, 16 Apr 2022 09:40:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56202 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232093AbiDPNkO (ORCPT ); Sat, 16 Apr 2022 09:40:14 -0400 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2070.outbound.protection.outlook.com [40.107.236.70]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 10761D39A7; Sat, 16 Apr 2022 06:37:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iMxVfUNP/KNPXHB8bAd3jJtssu//qm/bali53flSqwbNOsHAYamWHQ187dd0NBlT39Zvk7hF6cl1rLLIvKun1SHdW2X1hjf0H9/dLpT5QUWKNcQqZNvhPK7em/jtwSGYBOLYZXAO3Q0vhPkeRnUU4nlBjMkklmsPZmInU4t/TWwfpxKrHkYbME7nOvfdITIETZhk2prUDoB00B/V4Ztqy4FcA3XB1O7wimJJSL2Oqh4buPDOzHsAo/isia5qIV4WIP8Xn2ky652x2fuT9d7+RZDdaj1MeKoNuLpo5w6u3asn0FmR9uJ9Ln1X2HBCbdMHI5x89MAhwuQNGHTbJQj5fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GIKD7jfG/l6nA1zGhjG9YLGX6jUh2n7kdavS5YneHjs=; b=Cz9VFrtY1DWOPUrmHuS6h0cIM5yYgIfmfTt8FuY+YJuE7Q665y6DVm17AXrECRnLHDCXzeDK8DlFqZ3T1CovYbvKW9KpQgin4cXRHyv+scTcWVMJBTGqBFMe8xI4Qm8WX0Q7EBYNOEj/chLMOzCEtSmWdg3S2zUn6ZfTYNuiYy+B5uGtQvHhihM0Xp9OTeV94Ci/OLCo10tV6NPvGCI7PdGfIHp/Ppl7hmlUlB/qrZQGBjt9hgkJsrWe0FgBRTl9Mn860XRnhq76uIU0gKWWfL/BP4TNtuzoMFnothwsnRlnlJx2oFfr9Y9uGx/oGWtvrhTJtFz8QjJRabr21Jm4wQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=kernel.org smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GIKD7jfG/l6nA1zGhjG9YLGX6jUh2n7kdavS5YneHjs=; b=gn4kXS+Ipyc8hzQBefVpHTmKQE10vdeJaw+zgVPtLS5uhE6Z53yQ0wSwqA+PP1ircdqAoWCeb746XtVVkUlExQdcwklbKicRxN4v3BW8skodOkMxrYANJVADiC7u1FB0/AdvuxhibnNGXgA1eaTQyn+PJtodEVrE1B8oAKBCctA= Received: from BN0PR04CA0157.namprd04.prod.outlook.com (2603:10b6:408:eb::12) by DM6PR02MB4618.namprd02.prod.outlook.com (2603:10b6:5:2c::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Sat, 16 Apr 2022 13:37:36 +0000 Received: from BN1NAM02FT048.eop-nam02.prod.protection.outlook.com (2603:10b6:408:eb:cafe::e6) by BN0PR04CA0157.outlook.office365.com (2603:10b6:408:eb::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20 via Frontend Transport; Sat, 16 Apr 2022 13:37:36 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch01.xlnx.xilinx.com; Received: from xsj-pvapexch01.xlnx.xilinx.com (149.199.62.198) by BN1NAM02FT048.mail.protection.outlook.com (10.13.2.157) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5164.19 via Frontend Transport; Sat, 16 Apr 2022 13:37:36 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch01.xlnx.xilinx.com (172.19.86.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Sat, 16 Apr 2022 06:37:31 -0700 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Sat, 16 Apr 2022 06:37:31 -0700 Envelope-to: git@xilinx.com, mdf@kernel.org, hao.wu@intel.com, yilun.xu@intel.com, trix@redhat.com, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Received: from [10.140.6.60] (port=32988 helo=xhdnavam40.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1nficF-00088I-C3; Sat, 16 Apr 2022 06:37:31 -0700 From: Nava kishore Manne To: , , , , , , , , CC: Nava kishore Manne Subject: [PATCH v4 2/5] fpga: fix for coding style issues Date: Sat, 16 Apr 2022 19:07:16 +0530 Message-ID: <20220416133719.3382895-3-nava.manne@xilinx.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220416133719.3382895-1-nava.manne@xilinx.com> References: <20220416133719.3382895-1-nava.manne@xilinx.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0359884a-ac9b-4478-a77f-08da1fae44ed X-MS-TrafficTypeDiagnostic: DM6PR02MB4618:EE_ X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AvhWMjAqmJwKFB7phtQdWr7E4TdsOBiO9x1SRGIZBlXg0hnwU4AZ3GPG7903+wDAJGj5PInzuu8gIBtfg+UQAkFDN0Twf/0NTzE1ZRza8wH0WLOCc2KuQF/T1trKSNBuQ/ufdoNKK/+TGM7Khi41Msvda2RXYc+gfUc5it3hKUl8lMqcDY5cP4K5Ht5Y4n/fKXloanxdAQARfZPoDDxhKRlWnHjM4Mx6kVCE7u3ciCvmgshXYbJ+9fDPH24OGo0PuUcmbtNoscYQ4mQ1fQyblIXtGZySn5+A14UX9VvDG4SYD7IQeC3yyXQckcjKiMcpFC7gJoFXT7LRVNHP4oSdijGxI+K1uBgtJabFlktncJww0SI4eurekJHAnWjBv110HJvovSK9UukcUdds6UXdTxug2Bp6AIqh8pD/2mtPntyVymVvdj8nLnj+NhI1+tuRS8JRIB9YsKGmwGsWYYTsuf+qkETZCFLjtF6SXeTDeX0dfruWY1dzkm3g4nWFGQjpA0yHbvBYW2XztcJGtHzMN4tic0I7PS+xTU3fjff3Bhw4EG95QZYhSt7dmiaZ1iKb4UkGdZzq4aXboDhlKn/AubU0NTwQNyzps70EkMy+ODM4d9wqHIL3bckZT3lBfwAX7l/6HjKuS270eiLobyR0/EjJoEIE+g81MCBES03VmeEK/pB4U4i/Xs1Ncp957/V4cjIF3Xq2cnGR9o2/711U0lxJuGseRWRHcyuu2+cp1WI= X-Forefront-Antispam-Report: CIP:149.199.62.198;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapexch01.xlnx.xilinx.com;PTR:unknown-62-198.xilinx.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(36860700001)(7636003)(47076005)(2906002)(356005)(9786002)(5660300002)(8676002)(4326008)(70586007)(70206006)(8936002)(110136005)(6636002)(7696005)(83380400001)(508600001)(36756003)(40460700003)(336012)(426003)(186003)(26005)(2616005)(6666004)(107886003)(1076003)(82310400005)(316002)(102446001)(2101003);DIR:OUT;SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Apr 2022 13:37:36.6136 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0359884a-ac9b-4478-a77f-08da1fae44ed X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: BN1NAM02FT048.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR02MB4618 Precedence: bulk List-ID: X-Mailing-List: linux-fpga@vger.kernel.org fixes the below checks reported by checkpatch.pl Lines should not end with a '(' Alignment should match open parenthesis Signed-off-by: Nava kishore Manne Acked-by: Xu Yilun --- Changes for v2: -None. Changes for v3: -Fixed similar issue exists in "drivers/fpga/*". Changes for v4: -None. drivers/fpga/fpga-mgr.c | 4 ++-- drivers/fpga/fpga-region.c | 7 ++++--- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/fpga/fpga-mgr.c b/drivers/fpga/fpga-mgr.c index d49a9ce34568..a699cc8e2fa6 100644 --- a/drivers/fpga/fpga-mgr.c +++ b/drivers/fpga/fpga-mgr.c @@ -151,8 +151,8 @@ static int fpga_mgr_write_init_buf(struct fpga_manager *mgr, if (!mgr->mops->initial_header_size) ret = fpga_mgr_write_init(mgr, info, NULL, 0); else - ret = fpga_mgr_write_init( - mgr, info, buf, min(mgr->mops->initial_header_size, count)); + ret = fpga_mgr_write_init(mgr, info, buf, + min(mgr->mops->initial_header_size, count)); if (ret) { dev_err(&mgr->dev, "Error preparing FPGA for writing\n"); diff --git a/drivers/fpga/fpga-region.c b/drivers/fpga/fpga-region.c index b0ac18de4885..3864bf4f8920 100644 --- a/drivers/fpga/fpga-region.c +++ b/drivers/fpga/fpga-region.c @@ -18,9 +18,10 @@ static DEFINE_IDA(fpga_region_ida); static struct class *fpga_region_class; -struct fpga_region *fpga_region_class_find( - struct device *start, const void *data, - int (*match)(struct device *, const void *)) +struct fpga_region *fpga_region_class_find(struct device *start, + const void *data, + int (*match)(struct device *, + const void *)) { struct device *dev; From patchwork Sat Apr 16 13:37:17 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nava kishore Manne X-Patchwork-Id: 12815836 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3A1CC433F5 for ; Sat, 16 Apr 2022 13:40:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232096AbiDPNkQ (ORCPT ); Sat, 16 Apr 2022 09:40:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56002 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232089AbiDPNkM (ORCPT ); Sat, 16 Apr 2022 09:40:12 -0400 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2040.outbound.protection.outlook.com [40.107.223.40]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98DF7D3737; Sat, 16 Apr 2022 06:37:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OLhuJtGAJLYtxVcVzvp2N0A2Aq//GHBiyfXbBb9EUEX5yxgo5B81xZ7rNHKXxJ4DQSFPgKbf2AiPcFlKNdbnKFUoigdGvJ3AY+RFmvtZuIjOOQL8tS6tBR0pE1ZhsY58+xMLulv9ej61URsdk7RT6mbPRuMg7dSO0CvhCVbUY2tmkmCUXXBfJulZ0lDxIZv+eL9B3byTqFEF/J5X4kAlESinRfZX1psZ0SPaSD9okrH3huIaM6+53xC7KnJAVmh2EGm1kAwZElEOkI0I59Ru8EwSKRLXawz16ZUtxw9LZnJdcFnuE83Li5q1PEFEMyb/MkgT6Oh0yf73mZMMvbQHdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vRsaVB95ZHuGq5Jua8kkJjsgbn8mhdHcOxo2GJV+QCk=; b=SpP7talo6migOePxOQ+Y0rIm0I9UJtWZhZPS0mPfQNPzXWrGYeuN9o9h7m9RPuptuo+t1fwJd4sn/jz/JafApFR1RJa6TJCkN8YVGwwRHZNJUzDBr2QhkEyNLlz3cANDMxFDBwXBNt/o1+Iyx8ob0Ncc6ukrL0GCagv/roStEC/eYbvk6Pxpy3J3P6dhbF8C5WMfl0kRO9lNn9AOsvk1jACybiB0zLx1mzPwUKB6zRH2MjesCyLGmqmOms8mHdYL6Po4iy+MB6VBPc1vd4ftu31CpvEROH/VgMlI26GkxMrSdx5OlT8xxycTuTVAnbf7fkwHnOk+HyPv9Zly4PcUOA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=kernel.org smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vRsaVB95ZHuGq5Jua8kkJjsgbn8mhdHcOxo2GJV+QCk=; b=tOLh5+tHSXj5ZnkIBMWg2d0uTP+nPT7mOFituBj4ElsdmGZgSlwOGOQzlk25xze9Rfms1FKxJK8lGc7FSqiunpOCFsXnafq07HHtpELuYZhE0KiGPVkevhkMP3PkEKeCcK5oAWUI3146Te33xVXN6JxkcB4qAhgo0UP3yLn3Cj0= Received: from BN9PR03CA0391.namprd03.prod.outlook.com (2603:10b6:408:111::6) by DM6PR02MB5721.namprd02.prod.outlook.com (2603:10b6:5:152::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Sat, 16 Apr 2022 13:37:38 +0000 Received: from BN1NAM02FT026.eop-nam02.prod.protection.outlook.com (2603:10b6:408:111:cafe::27) by BN9PR03CA0391.outlook.office365.com (2603:10b6:408:111::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.18 via Frontend Transport; Sat, 16 Apr 2022 13:37:37 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch02.xlnx.xilinx.com; Received: from xsj-pvapexch02.xlnx.xilinx.com (149.199.62.198) by BN1NAM02FT026.mail.protection.outlook.com (10.13.2.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5164.19 via Frontend Transport; Sat, 16 Apr 2022 13:37:37 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Sat, 16 Apr 2022 06:37:34 -0700 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Sat, 16 Apr 2022 06:37:34 -0700 Envelope-to: git@xilinx.com, mdf@kernel.org, hao.wu@intel.com, yilun.xu@intel.com, trix@redhat.com, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Received: from [10.140.6.60] (port=32988 helo=xhdnavam40.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1nficI-00088I-Bn; Sat, 16 Apr 2022 06:37:34 -0700 From: Nava kishore Manne To: , , , , , , , , CC: Nava kishore Manne Subject: [PATCH v4 3/5] fpga: fpga-mgr: fix kernel-doc warnings Date: Sat, 16 Apr 2022 19:07:17 +0530 Message-ID: <20220416133719.3382895-4-nava.manne@xilinx.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220416133719.3382895-1-nava.manne@xilinx.com> References: <20220416133719.3382895-1-nava.manne@xilinx.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 041ac202-fc6b-4577-0333-08da1fae4544 X-MS-TrafficTypeDiagnostic: DM6PR02MB5721:EE_ X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QyU86aDGDJgCuCh82DYLqesIZh4U9+CCvJzRSr7HwJ1e4fGnue6V4iev7pIXPfsg9aPwd0Wgc3zoFYIYeZeLqAX2yIH72DEXyLWjgc0xZfESAD0WwCqBDiSn9aDOOd4zLkFUQ7IX+XVUzpqz1r7YPRfJaQt2UfjUnXz2r4syxZp6SusGig8tFbX5NsI4EGQ7RFH69BAFDkc4DVuTlp6XW3sAVKZMvpH6PGb1rQeRAOtdQqmA8CuVcm7iytwZ4FEZ05O68HMsfoi5wXpbDhzBdBSudB87XWmSsgVl+G2dl4sHRt6kju9J9mjZocgIq78L8RnIP3anDJYG3jFGbdXPMvbpJ7QsujNU1c0yBjleXCszBg5cDHvqThRRE5Lkcc1FwmODdYCnG7iWgAmhtH3Xr3t3ny8fwlzF7UU7PDo6izYMVzzuL3SRH9jYbnGesULbO/qcn8uggKyRzA0WzqnnuxZEJVeL2VHZwxU1rBwi1mpcEW7TK4k40IpWXx1ku1mb6ZjknUOTviL/LojVzyuaelAlib2YVwZ/ZLZGNiTOaPVDrsUMUZ2LBkbO3v7nJLhUkcFBkq28JXFbrI2lXxGgS1lfOHOsKrzopIPAkmDjRq+emBnrvhegMWFk8F52vXh0/SaHdlsXT34vMQ80ubwszyxVQEt1uB9QIZsIrTdriwYlbyUXhsFfpDYDvmrKBDMXmO1zW4BA9UNUKVil5EfQ2/D3qU6fx3SjHai424cc3FS5Y/vfZbZF/PX1RdOeVtjj X-Forefront-Antispam-Report: CIP:149.199.62.198;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapexch02.xlnx.xilinx.com;PTR:unknown-62-198.xilinx.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(82310400005)(316002)(110136005)(36860700001)(6636002)(36756003)(426003)(83380400001)(336012)(47076005)(356005)(7636003)(6666004)(9786002)(5660300002)(40460700003)(2906002)(8936002)(7696005)(70206006)(70586007)(8676002)(186003)(4326008)(508600001)(26005)(107886003)(1076003)(2616005)(102446001)(21314003)(2101003);DIR:OUT;SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Apr 2022 13:37:37.1796 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 041ac202-fc6b-4577-0333-08da1fae4544 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: BN1NAM02FT026.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR02MB5721 Precedence: bulk List-ID: X-Mailing-List: linux-fpga@vger.kernel.org warnings: No description found for return value of 'xxx' In-order to fix the above kernel-doc warnings added the 'Return' description for 'devm_fpga_mgr_register_full()' and 'devm_fpga_mgr_register()' API's. Signed-off-by: Nava kishore Manne Acked-by: Xu Yilun --- Changes for v2: -Replaced s/@return:/Return:/ Changes for v3: -Updated commit description. Changes for v4: -Updated commit description. drivers/fpga/fpga-mgr.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/fpga/fpga-mgr.c b/drivers/fpga/fpga-mgr.c index a699cc8e2fa6..0f2b28538f17 100644 --- a/drivers/fpga/fpga-mgr.c +++ b/drivers/fpga/fpga-mgr.c @@ -730,6 +730,8 @@ static void devm_fpga_mgr_unregister(struct device *dev, void *res) * @parent: fpga manager device from pdev * @info: parameters for fpga manager * + * Return: fpga manager pointer on success, negative error code otherwise. + * * This is the devres variant of fpga_mgr_register_full() for which the unregister * function will be called automatically when the managing device is detached. */ @@ -763,6 +765,8 @@ EXPORT_SYMBOL_GPL(devm_fpga_mgr_register_full); * @mops: pointer to structure of fpga manager ops * @priv: fpga manager private data * + * Return: fpga manager pointer on success, negative error code otherwise. + * * This is the devres variant of fpga_mgr_register() for which the * unregister function will be called automatically when the managing * device is detached. From patchwork Sat Apr 16 13:37:18 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nava kishore Manne X-Patchwork-Id: 12815834 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 280FFC433F5 for ; Sat, 16 Apr 2022 13:39:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232119AbiDPNkY (ORCPT ); Sat, 16 Apr 2022 09:40:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57026 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232124AbiDPNkW (ORCPT ); Sat, 16 Apr 2022 09:40:22 -0400 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2056.outbound.protection.outlook.com [40.107.92.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 32021D3ACD; Sat, 16 Apr 2022 06:37:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VcNbQ2Lqj148Lft/e++PAZ7fSBVLyDhXqCnK7u/iiVACZ6CdwSVHCwHMHCSHdkLVv6JQ8g+jWj/rbQuUY1tOl6xf9chPeq0GwOyPCAUvEWeVBiosoMrDEeYn4uujhYGyv8T+6MvCW3dEYbV3qJYWf5o5VdYzFHynSdXKkDONAFk7BQLCP0sMQrNJl24g/1CsmXOrEwpFw7tyCClvjNArhKtqPru9LeFYQGAKNW9Kg4TNKphfROWORqd3YQ5FK6jA7f5AbEiK6R+/BGpYa6HHRJcSq8cR+AcfyALN3WOekp6MktjieowkGSppnzwGW4M3TUNebPbA5sHsd9WKg+o/XQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7ppXbW7xlxAO4m3+3JY3uSmnSyhVMzDYpFYUxyAN2Uk=; b=WLHA1lVhbqsuFxyWof7t1t8duno0nsmmIedVNiTgNln2y6p2ekcb1fxJRXwgcOKh0C5A00CioPgVJ/k+qxMvVAP0yHieAF5AeTVffSlCA8JdiihBYjHTlyOnJ9+DFFlnOqoMR/Cnj9PNH+4J5t+/AJFKdWVuXevrEYOh5dXGIbrDJQJxVMQjnUpTIJs7Ag2tbLUSxFTcEbSGF/mtY25uZd2yrhASvs/gzcXUyqLgCykVJ61gBDYCtbRbLzxaR9vUa7kkGfc6bdpTxVZZV1390v1W0I3VVRmGX1FyQW5ed/17ulOushIznV151g0L7mfGOzRlUzE6rukTW9nlP2Df6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=kernel.org smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7ppXbW7xlxAO4m3+3JY3uSmnSyhVMzDYpFYUxyAN2Uk=; b=E44b9LlCSKhxbYX/K5LdXkgCeA6fCkiTMTp+NIOOs6OBTzkWZFh5n3rfJSuwL5qeTKmpIUWRxvImEgJeCtH4Kqv53+JacrD++VK3B+yKGKRGdmVdvy2Y2BKa53ywPWLV/CsUDdYz5oUUACroP1P1WALcEmH8s/GWMrJkKbfXFDA= Received: from BN9PR03CA0571.namprd03.prod.outlook.com (2603:10b6:408:10d::6) by DM6PR02MB5529.namprd02.prod.outlook.com (2603:10b6:5:30::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Sat, 16 Apr 2022 13:37:47 +0000 Received: from BN1NAM02FT036.eop-nam02.prod.protection.outlook.com (2603:10b6:408:10d:cafe::d4) by BN9PR03CA0571.outlook.office365.com (2603:10b6:408:10d::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20 via Frontend Transport; Sat, 16 Apr 2022 13:37:47 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch01.xlnx.xilinx.com; Received: from xsj-pvapexch01.xlnx.xilinx.com (149.199.62.198) by BN1NAM02FT036.mail.protection.outlook.com (10.13.2.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5164.19 via Frontend Transport; Sat, 16 Apr 2022 13:37:47 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch01.xlnx.xilinx.com (172.19.86.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Sat, 16 Apr 2022 06:37:37 -0700 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Sat, 16 Apr 2022 06:37:37 -0700 Envelope-to: git@xilinx.com, mdf@kernel.org, hao.wu@intel.com, yilun.xu@intel.com, trix@redhat.com, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Received: from [10.140.6.60] (port=32988 helo=xhdnavam40.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1nficL-00088I-Bl; Sat, 16 Apr 2022 06:37:37 -0700 From: Nava kishore Manne To: , , , , , , , , CC: Nava kishore Manne Subject: [PATCH v4 4/5] fpga: Use tab instead of space indentation Date: Sat, 16 Apr 2022 19:07:18 +0530 Message-ID: <20220416133719.3382895-5-nava.manne@xilinx.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220416133719.3382895-1-nava.manne@xilinx.com> References: <20220416133719.3382895-1-nava.manne@xilinx.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 43b76460-f1d9-4190-ab0c-08da1fae4b2c X-MS-TrafficTypeDiagnostic: DM6PR02MB5529:EE_ X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EKkcCRnShDFXAxqp0Eyrgjv1r7QW0I7wRqNFCsG/lsSL5tWp5xc4XvzPcNovJklvGiShjyEipX8cex4HirTQqK2DDTTaDWsU6fUmRqDBOk+PwO/CajNIS6+d4BVNk0vDk0r8bLPFdN3QgoENHZBEPs1rQ9XYoE48N3cCRjBnZztJ4VGm+GcTEaLpC/T7W4EEZ5pLBsKgBltZ9KsVwMjKtFdlb3LO3w0Jh7gSo76lW60ZFNNSRrpDRCM8k4O4EnN/qqJ49kAOQZt7jeWW72UxPCeWCpJyGUFhi/vy2oB8gezWXnQNELjR5oNAin29BqKAlEuLm53a0vVyCd36OrHnwedaNVoaDFPgGX4564CR3P7AZ44zYmautCZ5EI+UgQZzph/bEreslpFldMxWDjjsnR/eJa5h9l2XlB2UVx2SRIfXl1KsQocwH6tSBo6FQorFMRtwqDtpnJVQ5abeIVT2SKLaGPaCt0A86ZXl1YSx3CfHe01q6PBlJGjxhItxrMo+A9OMt8prlt7ghp4hfOooWvfWa3t8K3+QBpH8A0J0CDc/k6/e57KIKJehjmmpEC0lYyaVVEJX3PE6VR28G7qoJ9oXvUPaqJAEHI6tIzKO17ccAewdD0eIINuw/oAJbiZXFhRCpRRp9PosVV/RaI9tM8jwZNAMXrZI/p8YeyZEt7yyNuKfSAUoH3wHdTdk4FVAwx02aEn2Q3gAvCyY3QAZUa8lp1dJRdx8UPH6KZi9Y8Q= X-Forefront-Antispam-Report: CIP:149.199.62.198;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapexch01.xlnx.xilinx.com;PTR:unknown-62-198.xilinx.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(426003)(8936002)(4326008)(70586007)(508600001)(6636002)(1076003)(70206006)(36756003)(47076005)(336012)(82310400005)(5660300002)(186003)(26005)(40460700003)(2906002)(36860700001)(2616005)(83380400001)(107886003)(110136005)(9786002)(8676002)(6666004)(7696005)(356005)(7636003)(316002)(102446001)(2101003);DIR:OUT;SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Apr 2022 13:37:47.0929 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 43b76460-f1d9-4190-ab0c-08da1fae4b2c X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: BN1NAM02FT036.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR02MB5529 Precedence: bulk List-ID: X-Mailing-List: linux-fpga@vger.kernel.org In FPGA Make file has both space and tab indentation to make them align use tab instead of space indentation. Signed-off-by: Nava kishore Manne Acked-by: Xu Yilun --- Changes for v2: -None. Changes for v3: -Updated commit description. Changes for v4: -None. drivers/fpga/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/fpga/Makefile b/drivers/fpga/Makefile index 0bff783d1b61..5935b3d0abd5 100644 --- a/drivers/fpga/Makefile +++ b/drivers/fpga/Makefile @@ -18,9 +18,9 @@ obj-$(CONFIG_FPGA_MGR_TS73XX) += ts73xx-fpga.o obj-$(CONFIG_FPGA_MGR_XILINX_SPI) += xilinx-spi.o obj-$(CONFIG_FPGA_MGR_ZYNQ_FPGA) += zynq-fpga.o obj-$(CONFIG_FPGA_MGR_ZYNQMP_FPGA) += zynqmp-fpga.o -obj-$(CONFIG_FPGA_MGR_VERSAL_FPGA) += versal-fpga.o -obj-$(CONFIG_ALTERA_PR_IP_CORE) += altera-pr-ip-core.o -obj-$(CONFIG_ALTERA_PR_IP_CORE_PLAT) += altera-pr-ip-core-plat.o +obj-$(CONFIG_FPGA_MGR_VERSAL_FPGA) += versal-fpga.o +obj-$(CONFIG_ALTERA_PR_IP_CORE) += altera-pr-ip-core.o +obj-$(CONFIG_ALTERA_PR_IP_CORE_PLAT) += altera-pr-ip-core-plat.o # FPGA Bridge Drivers obj-$(CONFIG_FPGA_BRIDGE) += fpga-bridge.o From patchwork Sat Apr 16 13:37:19 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nava kishore Manne X-Patchwork-Id: 12815835 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA48DC433F5 for ; Sat, 16 Apr 2022 13:39:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232093AbiDPNk0 (ORCPT ); Sat, 16 Apr 2022 09:40:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232116AbiDPNkY (ORCPT ); Sat, 16 Apr 2022 09:40:24 -0400 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2055.outbound.protection.outlook.com [40.107.93.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 39165D3996; Sat, 16 Apr 2022 06:37:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VuHQYndd5fr6UunInNhue6UAOEA3OHCRQSHHbfQ1qkS+0YAGOvxWIeRaLpDB/0rQ3YWr9tKYPlgvtWSWIc34A53DVQ3niYkBDW5cXRB4hfPmpntSO2zbgwq6iAEaj46DU9AwUrwxlq0vJQIfsjdUN9+oCP1G11aP9o56u7Rp8xZu85D+IGo79T4mequai0/V8Hh21qPjT1DjOzSktS7gB9qDvrvvLQejGMwfRWlEFJjnvQIJd/TgSNubJ1m1dNmQ2rfsDWRG73bVavTlxqw/URVSuR7OFyDqCW5vP286nUlxTqxbogLYx2Zhxfr+LZg7LGGpibzAd+h+TC/HGVjWJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=82wL+R9Nk3zPle/kbOr+ES8fRDChUjz/L3cNN22UwzA=; b=mk2Cy1dnwRxZ6vLFCNUbdFhJkns9p1GidlDWOIcg/2gP6XMxxlfnRDSR5rAJrYFUt+XOmaanU8o8yH6EuXKJPExn+AI/ujrnS0TfuOEpcG7MGXUhscL6mgO/LLBAKqGOGSfP1EQZu4T9UkJ9Z9yMlaBJC71iug99OfaAi1hUS0tQwq0FvaRFr1irireT4WV2AMklJ2SohlvhnB4SFcujBOwFP/Q6LyXcmsS2LES+zJzPCCzqOnHmZQmIMhMN6OJNNMFqrDLkMmnY2jU4ypciG7xLHQA3eYacfIWBLPmWIh6BaykRtOv8Eto9h9/2wb07kVR5ddZPizbtOF64ZSwG7w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=kernel.org smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=82wL+R9Nk3zPle/kbOr+ES8fRDChUjz/L3cNN22UwzA=; b=ErFCHG2ku+VXC1KklVHI7wjlug3xcWmNI13mpb8TehdTpdsPFXr1LmADJFwnnp6z8QF66ZXRhkRFxBF/aXGcLvVyLLxl4Qq11zgIFlo2zwfYZgi23W3QRb+iCs/2mT77i+PNnwgqKPBy6rbZXKimINiyErIY3dUQX5Mi90iQNqk= Received: from BN9PR03CA0592.namprd03.prod.outlook.com (2603:10b6:408:10d::27) by SA1PR02MB8413.namprd02.prod.outlook.com (2603:10b6:806:1f4::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Sat, 16 Apr 2022 13:37:50 +0000 Received: from BN1NAM02FT036.eop-nam02.prod.protection.outlook.com (2603:10b6:408:10d:cafe::cb) by BN9PR03CA0592.outlook.office365.com (2603:10b6:408:10d::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20 via Frontend Transport; Sat, 16 Apr 2022 13:37:49 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch01.xlnx.xilinx.com; Received: from xsj-pvapexch01.xlnx.xilinx.com (149.199.62.198) by BN1NAM02FT036.mail.protection.outlook.com (10.13.2.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5164.19 via Frontend Transport; Sat, 16 Apr 2022 13:37:49 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch01.xlnx.xilinx.com (172.19.86.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Sat, 16 Apr 2022 06:37:40 -0700 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Sat, 16 Apr 2022 06:37:40 -0700 Envelope-to: git@xilinx.com, mdf@kernel.org, hao.wu@intel.com, yilun.xu@intel.com, trix@redhat.com, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Received: from [10.140.6.60] (port=32988 helo=xhdnavam40.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1nficO-00088I-Bf; Sat, 16 Apr 2022 06:37:40 -0700 From: Nava kishore Manne To: , , , , , , , , CC: Nava kishore Manne Subject: [PATCH v4 5/5] fpga: fpga-region: fix kernel-doc formatting issues Date: Sat, 16 Apr 2022 19:07:19 +0530 Message-ID: <20220416133719.3382895-6-nava.manne@xilinx.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220416133719.3382895-1-nava.manne@xilinx.com> References: <20220416133719.3382895-1-nava.manne@xilinx.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5a129e05-e92c-42ad-2e98-08da1fae4cbd X-MS-TrafficTypeDiagnostic: SA1PR02MB8413:EE_ X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: f0pQmshk/lL5pAsIbjfc31LpNmmwdnZSB1i4oa2ns1FlwddwGjgIETFTf92uFXj1cruHNPdPtjhLAJs+G/GYnhbfhhsiyMBXBajcxeYgpb16kR3NDqP+MujsjFHRWpIb1QGRK3P3YEVzRdihr3aVb4AAJfjF3d5vRxxLduH2U8NX4xXkp4026fgmg9tPdkY3dtaHvaUB2jdymr+LmAuFGWzDGRscOTlVM1UY4rytLvHBuPgl5x1GexaIBkG/UpM4VHGf5tVmr26xegK9xc5HJp6sAwkWpa9wnvXs5LrpfDQ9g4KHxeJsFDnM8+p71wYXsXv47iIR2sx3ICz8Wxu/Ia3V0Gci8xuDCif8MmGT/7h4K2pzeJzfxz7FnR77mQ4DqtFfBYkvoMLvIfFwuJUMBGRg8VlUsiLFLlQ5ZmcIIqjWMwiuqXDESQSp3zML14ykAzj7EUVhhCJ5ijxsrHTLQku+D/GwZxYV0ZSg8AUV7mpgdzIxKWs0rbYK8NKrmnqwwes1wNxx/MOaGZsyaOU4A7yCMU9SePc/1Iv4oEDiv4kMrX/zKXmg6h3VukO8PO41WqDb0ovhoqMxtycMAtvSf0MQ4NcxfaOG0aCz9ccODpYh4afwf2oQQ81atMx2gGMlnDmT4Liwol2qHR/PzFD7xat1yRPC8U9dtS8Ak9Up5v4Cq24mH8pyr/b7QniIL7NkijkJ0dOqGTRex1Ta3nCe+puTgq61sz/o8mS9p6v8/e0= X-Forefront-Antispam-Report: CIP:149.199.62.198;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapexch01.xlnx.xilinx.com;PTR:unknown-62-198.xilinx.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(36860700001)(6636002)(1076003)(110136005)(9786002)(186003)(5660300002)(2616005)(107886003)(26005)(508600001)(356005)(47076005)(8936002)(83380400001)(82310400005)(7636003)(36756003)(40460700003)(336012)(426003)(316002)(7696005)(4326008)(8676002)(6666004)(2906002)(70586007)(70206006)(102446001)(2101003);DIR:OUT;SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Apr 2022 13:37:49.7177 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5a129e05-e92c-42ad-2e98-08da1fae4cbd X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: BN1NAM02FT036.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR02MB8413 Precedence: bulk List-ID: X-Mailing-List: linux-fpga@vger.kernel.org To fix below kernel-doc warnings this patch does the following ->Replaced Return\Returns with 'Return:' keyword. ->Added 'Return' description For __init of_fpga_region_init()' API. ->Added description for 'child_regions_with_firmware()' API. warning: No description found for return value of 'of_fpga_region_find'. warning: No description found for return value of 'of_fpga_region_get_bridges'. warning: missing initial short description on line: * child_regions_with_firmware warning: No description found for return value of 'child_regions_with_firmware'. warning: No description found for return value of 'of_fpga_region_notify_pre_apply'. warning: No description found for return value of 'of_fpga_region_notify'. warning: No description found for return value of 'of_fpga_region_init'. Signed-off-by: Nava kishore Manne Acked-by: Xu Yilun --- Changes for v2: -Replaced s/@return:/Return:/ Changes for v3: -Updated commit description. Changes for v4: -Updated commit description. drivers/fpga/of-fpga-region.c | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/fpga/of-fpga-region.c b/drivers/fpga/of-fpga-region.c index 50b83057c048..9e330a2c0a1b 100644 --- a/drivers/fpga/of-fpga-region.c +++ b/drivers/fpga/of-fpga-region.c @@ -28,7 +28,7 @@ MODULE_DEVICE_TABLE(of, fpga_region_of_match); * * Caller will need to put_device(®ion->dev) when done. * - * Returns FPGA Region struct or NULL + * Return: FPGA Region struct or NULL */ static struct fpga_region *of_fpga_region_find(struct device_node *np) { @@ -80,7 +80,7 @@ static struct fpga_manager *of_fpga_region_get_mgr(struct device_node *np) * Caller should call fpga_bridges_put(®ion->bridge_list) when * done with the bridges. * - * Return 0 for success (even if there are no bridges specified) + * Return: 0 for success (even if there are no bridges specified) * or -EBUSY if any of the bridges are in use. */ static int of_fpga_region_get_bridges(struct fpga_region *region) @@ -139,13 +139,13 @@ static int of_fpga_region_get_bridges(struct fpga_region *region) } /** - * child_regions_with_firmware + * child_regions_with_firmware - Used to check the child region info. * @overlay: device node of the overlay * * If the overlay adds child FPGA regions, they are not allowed to have * firmware-name property. * - * Return 0 for OK or -EINVAL if child FPGA region adds firmware-name. + * Return: 0 for OK or -EINVAL if child FPGA region adds firmware-name. */ static int child_regions_with_firmware(struct device_node *overlay) { @@ -184,7 +184,7 @@ static int child_regions_with_firmware(struct device_node *overlay) * Given an overlay applied to an FPGA region, parse the FPGA image specific * info in the overlay and do some checking. * - * Returns: + * Return: * NULL if overlay doesn't direct us to program the FPGA. * fpga_image_info struct if there is an image to program. * error code for invalid overlay. @@ -279,7 +279,7 @@ static struct fpga_image_info *of_fpga_region_parse_ov( * If the checks fail, overlay is rejected and does not get added to the * live tree. * - * Returns 0 for success or negative error code for failure. + * Return: 0 for success or negative error code for failure. */ static int of_fpga_region_notify_pre_apply(struct fpga_region *region, struct of_overlay_notify_data *nd) @@ -339,7 +339,7 @@ static void of_fpga_region_notify_post_remove(struct fpga_region *region, * This notifier handles programming an FPGA when a "firmware-name" property is * added to an fpga-region. * - * Returns NOTIFY_OK or error if FPGA programming fails. + * Return: NOTIFY_OK or error if FPGA programming fails. */ static int of_fpga_region_notify(struct notifier_block *nb, unsigned long action, void *arg) @@ -446,6 +446,8 @@ static struct platform_driver of_fpga_region_driver = { /** * of_fpga_region_init - init function for fpga_region class * Creates the fpga_region class and registers a reconfig notifier. + * + * Return: 0 on success, negative error code otherwise. */ static int __init of_fpga_region_init(void) {