From patchwork Mon Apr 18 16:43:56 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Rix X-Patchwork-Id: 12816859 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E187EC433EF for ; Mon, 18 Apr 2022 16:45:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=187viT1g4I/HQjuur7/4Zu1Z9wvzbPy7KmjCiyeBPPs=; b=YVc0XdBpo1SdsU qSoouWWqStjuKaRgpY72OPqUXtNXSKoY9LkD2szP0koYx4ufwglaWq4ncV87jXLZOcEb5lp1MvdDD x9HSg77Gq4syEcr/SeaYctaz9POG2/rPpjCYrPoMZS840tRAu4gObsF8kGJwiPGPbKwspp+xvDhVs h8JDPMUI8binIkcm10bt/g9GY5VSmL/wbmj/vzBMnCWqhf0XrVQqY4Wv2ggEPjke2+ay9e4+rziQq eUlWSlyDvAO4id8qr3M2JkRA7iC5K8Nd2l9HZcQk5nakL9HvSW+FbZNBQE0tHE1tPjyxRcCYC+Vkd w2BDX1sqknD+h/Nmhp0Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngUUA-0006Ah-C2; Mon, 18 Apr 2022 16:44:22 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngUU7-00069U-LY for linux-arm-kernel@lists.infradead.org; Mon, 18 Apr 2022 16:44:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1650300258; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hfOUYN9UIIiOEE4PlLjMhtSzjMtNPDZSzWUFehT4Zg4=; b=BC2CiDjvXNqkAx2ump9SQHJX/jiK/F92CDV4UM6zab1dIE3jyZHmSVtHCWMj5pGQ0hcNMp lkE5HgtItn4wn+muV+ZuYlGgSBSkL3cAgkv9QrMtybHgh5ld/RIzQaiBGaobxgnBPrBqsN NjRrPiJ2hMTyTiUkciRmnETsDvfu5R8= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-119-uopp63QWP--wT_rxtxmgjw-1; Mon, 18 Apr 2022 12:44:17 -0400 X-MC-Unique: uopp63QWP--wT_rxtxmgjw-1 Received: by mail-qk1-f199.google.com with SMTP id f21-20020a05620a409500b0069c0ba2ee79so10736466qko.14 for ; Mon, 18 Apr 2022 09:44:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=hfOUYN9UIIiOEE4PlLjMhtSzjMtNPDZSzWUFehT4Zg4=; b=qOsnI5y9qH7o/08DvC2HCTrlFqjqy8Mwuh3JjIzmGAHKTeawg9Ls8f3yCrgBOeexwN KPQuFV48RKbOWCt6/d5rI/QwtAwgm27xsSsoywivknLL5eqTxfvmdVqiFHl1XNjgkyfD 1lUwLbyBUN3WZ29fEYRVQLSWaZ/+b8MCRmoxR0VjjqTvblTl0oRPnzE2yCV2KAhCmqjB /FN7gP2wMoxZCV8hX3uJFCZPTKuT1+KeIRnj+Y7yfS6XBC2LLtTC58GAJgw56t5aKuZc nrMw1/ONcCUcDM9vs2lXrQbnBJSMkdyYa8ab1gx9m4TN3K3zawk7TO1We+/MsdprWz2w Oenw== X-Gm-Message-State: AOAM530EiN48vjL+lkcsj0hOMkcL8fz+/CD5Eq/6VXPz1sKboG0QEZQF Bk99+t5/TNEM9IpBamSvOUpP77Plfe3G5vdS0YdJDYVeIJ36+qpCtp02EugSbmtZX8bERCVeWV5 3bIT2TzRom5Qk65V3dpyhCqZW5tgbCyxakew= X-Received: by 2002:a05:620a:4154:b0:69c:6976:1ee4 with SMTP id k20-20020a05620a415400b0069c69761ee4mr7210412qko.463.1650300256559; Mon, 18 Apr 2022 09:44:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxYPpaPozKKnyQ/NIX2bofZripMjbu2H4MFzW0nKSXBeZharHnP4QWvyOGM0K+33nrpfMsqGQ== X-Received: by 2002:a05:620a:4154:b0:69c:6976:1ee4 with SMTP id k20-20020a05620a415400b0069c69761ee4mr7210387qko.463.1650300256303; Mon, 18 Apr 2022 09:44:16 -0700 (PDT) Received: from dell-per740-01.7a2m.lab.eng.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id m139-20020a37a391000000b0069e88edfdacsm2895896qke.105.2022.04.18.09.44.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Apr 2022 09:44:15 -0700 (PDT) From: Tom Rix To: nsaenz@kernel.org, bcm-kernel-feedback-list@broadcom.com, gregkh@linuxfoundation.org, stefan.wahren@i2se.com, gascoar@gmail.com, ojaswin98@gmail.com Cc: linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tom Rix Subject: [PATCH] staging: vchiq_arm: change vchiq_platform_init from global to static Date: Mon, 18 Apr 2022 12:43:56 -0400 Message-Id: <20220418164356.3532969-1-trix@redhat.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=trix@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220418_094419_835443_D83A9D25 X-CRM114-Status: GOOD ( 12.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Smatch reports this issue vchiq_arm.c:466:5: warning: symbol 'vchiq_platform_init' was not declared. Should it be static? vchiq_platform_init is only used in vchiq_arm.c. Single file variables should not be global so change vchiq_platform_init's storage-class specifier to static. Signed-off-by: Tom Rix Reported-by: kernel test robot Reported-by: kernel test robot --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c index 0596ac61e286..7de98655e8ec 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c @@ -463,7 +463,7 @@ free_pagelist(struct vchiq_pagelist_info *pagelistinfo, cleanup_pagelistinfo(pagelistinfo); } -int vchiq_platform_init(struct platform_device *pdev, struct vchiq_state *state) +static int vchiq_platform_init(struct platform_device *pdev, struct vchiq_state *state) { struct device *dev = &pdev->dev; struct vchiq_drvdata *drvdata = platform_get_drvdata(pdev);