From patchwork Wed Apr 20 06:02:21 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anshuman Khandual X-Patchwork-Id: 12819803 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A96A8C433EF for ; Wed, 20 Apr 2022 06:01:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 017876B0072; Wed, 20 Apr 2022 02:01:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F0A026B0073; Wed, 20 Apr 2022 02:01:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DF8AD6B0074; Wed, 20 Apr 2022 02:01:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id D00F46B0072 for ; Wed, 20 Apr 2022 02:01:57 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 8FAC862484 for ; Wed, 20 Apr 2022 06:01:57 +0000 (UTC) X-FDA: 79376211474.09.D630135 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf05.hostedemail.com (Postfix) with ESMTP id 8DFFF100019 for ; Wed, 20 Apr 2022 06:01:55 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4431B23A; Tue, 19 Apr 2022 23:01:56 -0700 (PDT) Received: from a077893.arm.com (unknown [10.163.41.214]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id B75F33F5A1; Tue, 19 Apr 2022 23:01:52 -0700 (PDT) From: Anshuman Khandual To: linux-mm@kvack.org Cc: Anshuman Khandual , Pasha Tatashin , Andrew Morton , linux-kernel@vger.kernel.org Subject: [PATCH] mm/page_table_check: Drop all redundant EXPORT_SYMBOL() Date: Wed, 20 Apr 2022 11:32:21 +0530 Message-Id: <20220420060221.1107736-1-anshuman.khandual@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Authentication-Results: imf05.hostedemail.com; dkim=none; spf=pass (imf05.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com X-Stat-Signature: 5un7spyy9auxnifsg4iczeu6xk1i4aot X-Rspamd-Queue-Id: 8DFFF100019 X-Rspamd-Server: rspam04 X-Rspam-User: X-HE-Tag: 1650434515-790956 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Function definitions need not be exported via EXPORT_SYMBOL() mechanism. In this case these functions just get called only inside their wrappers. Even __page_table_check_zero() gets called without such an export. Just drop all these redundant EXPORT_SYMBOL(). Cc: Pasha Tatashin Cc: Andrew Morton Cc: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Anshuman Khandual --- This applies on v5.18-rc3 mm/page_table_check.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/mm/page_table_check.c b/mm/page_table_check.c index 2458281bff89..5c2a96159832 100644 --- a/mm/page_table_check.c +++ b/mm/page_table_check.c @@ -167,7 +167,6 @@ void __page_table_check_pte_clear(struct mm_struct *mm, unsigned long addr, PAGE_SIZE >> PAGE_SHIFT); } } -EXPORT_SYMBOL(__page_table_check_pte_clear); void __page_table_check_pmd_clear(struct mm_struct *mm, unsigned long addr, pmd_t pmd) @@ -180,7 +179,6 @@ void __page_table_check_pmd_clear(struct mm_struct *mm, unsigned long addr, PMD_PAGE_SIZE >> PAGE_SHIFT); } } -EXPORT_SYMBOL(__page_table_check_pmd_clear); void __page_table_check_pud_clear(struct mm_struct *mm, unsigned long addr, pud_t pud) @@ -193,7 +191,6 @@ void __page_table_check_pud_clear(struct mm_struct *mm, unsigned long addr, PUD_PAGE_SIZE >> PAGE_SHIFT); } } -EXPORT_SYMBOL(__page_table_check_pud_clear); void __page_table_check_pte_set(struct mm_struct *mm, unsigned long addr, pte_t *ptep, pte_t pte) @@ -208,7 +205,6 @@ void __page_table_check_pte_set(struct mm_struct *mm, unsigned long addr, pte_write(pte)); } } -EXPORT_SYMBOL(__page_table_check_pte_set); void __page_table_check_pmd_set(struct mm_struct *mm, unsigned long addr, pmd_t *pmdp, pmd_t pmd) @@ -223,7 +219,6 @@ void __page_table_check_pmd_set(struct mm_struct *mm, unsigned long addr, pmd_write(pmd)); } } -EXPORT_SYMBOL(__page_table_check_pmd_set); void __page_table_check_pud_set(struct mm_struct *mm, unsigned long addr, pud_t *pudp, pud_t pud) @@ -238,7 +233,6 @@ void __page_table_check_pud_set(struct mm_struct *mm, unsigned long addr, pud_write(pud)); } } -EXPORT_SYMBOL(__page_table_check_pud_set); void __page_table_check_pte_clear_range(struct mm_struct *mm, unsigned long addr,