From patchwork Thu Apr 21 04:47:40 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nava kishore Manne X-Patchwork-Id: 12821038 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03131C433F5 for ; Thu, 21 Apr 2022 04:49:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1384116AbiDUEur (ORCPT ); Thu, 21 Apr 2022 00:50:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37250 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1384111AbiDUEuq (ORCPT ); Thu, 21 Apr 2022 00:50:46 -0400 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2065.outbound.protection.outlook.com [40.107.237.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 88F64B1C8; Wed, 20 Apr 2022 21:47:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XVWXX9MyjO5lbSh9tCQ5IxYCxY52N1xrcYNymFKownc83K6vlPfkCIZAikyOvyTFiU6V30K1pLSNGly5jULwfg+zSWk7wgKDIM9k5mkovLVV4oaPZZm2zOQsEZoJOiPRibi2abQTk3yCmoPGSbanqOzRf+Yj9Pt0S6D/YweGRv4wMvfhwrsT6ysA81GHAMlusUMWW01tmILZgrFbDzMiE/NCwOSRP5j2oFDWcNp1v3IDbvkuC0KcuTxyOFlkWZpts/KBavcEKgAEQIc/wdOgKwDFHsPT7Hi72Bdba/bw5A85bVwFH61ohOZGGBQnvywWQ3zEST+6RQYTgjbznJ0fUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dEFaYm6S5045Fu1uxh5+QFlwmq8IqQmdgNrTj0UAKnA=; b=ABMxpZiuyJeOnolyydv8O8Xw5DPuyRqzxx4cNtRXdKFAC+oaAavmgmrB8RYkB07zSw540I+rZG9yzdRDTuPkSlSwfWIn7pxR+qPKgf9qHr059We06/NSNbmax3geNPYDLfmy+lqImQvqrhXh7BV/q015oObA8DweZWJo0N2/Z6r0J24otdJc7Qa1Q6uT7/c3VTEeQXgdeurBMKr06Qpo3+VPIxqwZmc7uNu2ox2R1iPLAY0H0pr5hOZvTjPW3ukLsTFco/TtZzFEccrIyWKW6feV1kNR+/rcSwBFJoppl1/bvvSt5zeHgrcd+Ib05Zdh+ca+8TkYRbamc+L6qT3w3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=kernel.org smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dEFaYm6S5045Fu1uxh5+QFlwmq8IqQmdgNrTj0UAKnA=; b=JEzp8qF2XtaD2noCyHLzvBIf6X9LWeRH94bbXxTdRzJOHvMJfFN1U4HnQjWSJWTkJcOfiNT4f5hi0zOvS3WBuLjzdNA8QYbhfZ0cUHPqZlTGBkls2lS3s29M54uLfIjXZ6dsW2lJNlq7giZLHSyLR9+XSf08qPPZllIydOFUrHE= Received: from BN9PR03CA0366.namprd03.prod.outlook.com (2603:10b6:408:f7::11) by CH2PR02MB6149.namprd02.prod.outlook.com (2603:10b6:610:4::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Thu, 21 Apr 2022 04:47:55 +0000 Received: from BN1NAM02FT005.eop-nam02.prod.protection.outlook.com (2603:10b6:408:f7:cafe::fd) by BN9PR03CA0366.outlook.office365.com (2603:10b6:408:f7::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13 via Frontend Transport; Thu, 21 Apr 2022 04:47:55 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch02.xlnx.xilinx.com; Received: from xsj-pvapexch02.xlnx.xilinx.com (149.199.62.198) by BN1NAM02FT005.mail.protection.outlook.com (10.13.2.124) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5186.14 via Frontend Transport; Thu, 21 Apr 2022 04:47:54 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Wed, 20 Apr 2022 21:47:53 -0700 Received: from smtp.xilinx.com (172.19.127.95) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Wed, 20 Apr 2022 21:47:53 -0700 Envelope-to: git@xilinx.com, mdf@kernel.org, hao.wu@intel.com, yilun.xu@intel.com, trix@redhat.com, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Received: from [10.140.6.60] (port=35750 helo=xhdnavam40.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1nhOjR-0002Sb-5C; Wed, 20 Apr 2022 21:47:53 -0700 From: Nava kishore Manne To: , , , , , , , , CC: Nava kishore Manne Subject: [PATCH v5 1/5] fpga: zynq: Fix incorrect variable type Date: Thu, 21 Apr 2022 10:17:40 +0530 Message-ID: <20220421044744.3777983-2-nava.manne@xilinx.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220421044744.3777983-1-nava.manne@xilinx.com> References: <20220421044744.3777983-1-nava.manne@xilinx.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: de22d259-713e-4287-0489-08da23521998 X-MS-TrafficTypeDiagnostic: CH2PR02MB6149:EE_ X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yyGyZ6ENd6aGtM1WMpcmAWFWUy8u+fJP/0Ofql7qeDg5dEiG4Xy9Ah/GpgEnj5nX1JUzK2INbBfQ9TQfrCvGxslJVumoh30KN8/UrwBd4sNpwRw9mdG/G3hicMswgUn5nn7Cza+4m5fAxOAxAhJpGS9YtqBpZY/aVB2X7Dgo9RTw4GBZKIKhhm5ivhGSJ3CvcIh2vCw1sfAKC9vWmw5DQFDlhw8Wl0MzFufgfltAwwPKBXLQglfCmQo4tnl4LH5sbn0QnRMP7i8/BHaKf0j6Bl7YzLKgp+ppmWY+WNapmjMqopTEVOSP0Mu64kRKrOZ0pj8TS3/Of+3WDf+NBenSOidRYKUeRaCU/BNxvk2vPsuvY4mueHLB5sXXdDIRqIug83qEN65QDdB6fPnJqHo/aVTo5LRxH+gUoIi5+9xHdair70vAUF/2bmX9Jt9rhchaksW/gYpOhDTnIR0LyeQA68MVMl2mO6pp2mzjx/SnfQdxBzRV1dmzjwZEfladWr+gVRzA43GQMmojlrBy7na9eWflrCmnW2ceLjqbYH/ErXsuo4ueiN8klD1DtQN/6vcyVECH/09o8n1nRA/vgf2C+wnVN10KDAPcaGSIodcHSZaH4K+caDxzfiulrPiAdxnh38KA8j8RoIX4K5L4ZyMyIWDsVxOQBe3Lu87rzdEEniHlCAkuItgNigBRf38WI9enHdkIi0ZF8ANLsBiVwvqHPTcTUra2GmaYykTQt9soITs= X-Forefront-Antispam-Report: CIP:149.199.62.198;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapexch02.xlnx.xilinx.com;PTR:unknown-62-198.xilinx.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(40470700004)(36840700001)(186003)(1076003)(40460700003)(426003)(47076005)(107886003)(2906002)(336012)(36860700001)(36756003)(83380400001)(82310400005)(2616005)(9786002)(8936002)(6636002)(6666004)(70586007)(70206006)(508600001)(5660300002)(110136005)(356005)(4326008)(7636003)(316002)(7696005)(8676002)(26005)(102446001)(2101003);DIR:OUT;SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2022 04:47:54.8623 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: de22d259-713e-4287-0489-08da23521998 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: BN1NAM02FT005.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR02MB6149 Precedence: bulk List-ID: X-Mailing-List: linux-fpga@vger.kernel.org zynq_fpga_has_sync () API is expecting "u8 *" but the formal parameter that was passed is of type "const char *". fixes this issue by changing the buf type to "const char *" Signed-off-by: Nava kishore Manne --- Changes for v2: -None. Changes for v3: - Changed arg buf type to "const char *" as suggested by Tom. - update zynq_fpga_has_sync () API description to align with API functionality. Changes for v4: - None. Changes for v5: - Dropped the irrelevant doc update changes. drivers/fpga/zynq-fpga.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/fpga/zynq-fpga.c b/drivers/fpga/zynq-fpga.c index 426aa34c6a0d..6beaba9dfe97 100644 --- a/drivers/fpga/zynq-fpga.c +++ b/drivers/fpga/zynq-fpga.c @@ -239,7 +239,7 @@ static irqreturn_t zynq_fpga_isr(int irq, void *data) * the correct byte order, and be dword aligned. The input is a Xilinx .bin * file with every 32 bit quantity swapped. */ -static bool zynq_fpga_has_sync(const u8 *buf, size_t count) +static bool zynq_fpga_has_sync(const char *buf, size_t count) { for (; count >= 4; buf += 4, count -= 4) if (buf[0] == 0x66 && buf[1] == 0x55 && buf[2] == 0x99 && From patchwork Thu Apr 21 04:47:41 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nava kishore Manne X-Patchwork-Id: 12821040 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F37FFC433EF for ; Thu, 21 Apr 2022 04:50:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1384121AbiDUEuw (ORCPT ); Thu, 21 Apr 2022 00:50:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37296 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1384123AbiDUEuu (ORCPT ); Thu, 21 Apr 2022 00:50:50 -0400 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2081.outbound.protection.outlook.com [40.107.237.81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3694EDF65; Wed, 20 Apr 2022 21:48:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NHhK7/A7RaSIgGFSFiyENlVZijKr3aO63deYNxTPYjVJLPIDX4RLzhxxZtBWwEOTYytoiPZ/+au1GnOfF1jSK6BW11c2kbOT78bC0BiPfmdAsavixbLrEM1ZB36wfy27vzqpMNIgdMU+kd0R2OLP/2j7S0N5Xn8HX9IJcGIS6TI1SksSZPCDTYUlnhtDUccXQIqzTHgvXPY1GxzdPSmE00oqTodAu8Vi/xQZl/PNzUqF5N2eY91WIGYfjJI6+m1PC6or5+s8CMO+UGw71SC+YifUeEcepF3FkFnsHZHwoPwiPG2JSC0Pkt5kNiP1lcPpBqCiTFyrxqctgyblCXVavw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=56YDIZW1o0MgBlfBVn0+4GJyoxPavJ5PsQ+m93Ej5XU=; b=A7NpPe63MBL2GtXrvCdmiOlmmD9sCjAGQZ86sy8M3eUlzONlbf2zuVtXl1EwfbP2cBYPyfv/bWGVO1ELquVMpaGeVU3QKgitC7Jufo04t4vXBzd774DtMvP+o/MdxomjRnWxbSRLNRdhAv4nQeUCKIaCPrO5SHsBmprBjgGJrtrFCte4kIc7KbaaIWVBtbUi/ebny0zk7K5itdlwdSLMh8Zi6gXeXaR4eQi9Tr10djrfLKTkDuLhbHmQ63OPMUg/0+p46zPhcxIqDlCUrFD+PBUiwPdCWtpOiIELCnbpttC9oshRRKVnARFThTEKOnUwu9z2s3K/D8+4QPqkHd1QBg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=kernel.org smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=56YDIZW1o0MgBlfBVn0+4GJyoxPavJ5PsQ+m93Ej5XU=; b=rjv582jSUuvZ+Km0+OC28y4AFdd4p3KCHKxVxD8Mu50ovUBlG2agbozLRRohbDI/hInAJoOeOBMY+kvtJBdARUs15NSIFtX5eYiisEw+YgAmhX5un06HeWnXaJDeFKZCtz7myqV3q0wtyOTvgHgZq17WnNDAir82+DtPbnjVLHg= Received: from BN9PR03CA0439.namprd03.prod.outlook.com (2603:10b6:408:113::24) by MW4PR02MB7411.namprd02.prod.outlook.com (2603:10b6:303:7c::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Thu, 21 Apr 2022 04:47:58 +0000 Received: from BN1NAM02FT021.eop-nam02.prod.protection.outlook.com (2603:10b6:408:113:cafe::5c) by BN9PR03CA0439.outlook.office365.com (2603:10b6:408:113::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14 via Frontend Transport; Thu, 21 Apr 2022 04:47:58 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch01.xlnx.xilinx.com; Received: from xsj-pvapexch01.xlnx.xilinx.com (149.199.62.198) by BN1NAM02FT021.mail.protection.outlook.com (10.13.2.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5186.14 via Frontend Transport; Thu, 21 Apr 2022 04:47:57 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch01.xlnx.xilinx.com (172.19.86.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Wed, 20 Apr 2022 21:47:56 -0700 Received: from smtp.xilinx.com (172.19.127.95) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Wed, 20 Apr 2022 21:47:56 -0700 Envelope-to: git@xilinx.com, mdf@kernel.org, hao.wu@intel.com, yilun.xu@intel.com, trix@redhat.com, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Received: from [10.140.6.60] (port=35750 helo=xhdnavam40.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1nhOjU-0002Sb-3f; Wed, 20 Apr 2022 21:47:56 -0700 From: Nava kishore Manne To: , , , , , , , , CC: Nava kishore Manne Subject: [PATCH v5 2/5] fpga: fix for coding style issues Date: Thu, 21 Apr 2022 10:17:41 +0530 Message-ID: <20220421044744.3777983-3-nava.manne@xilinx.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220421044744.3777983-1-nava.manne@xilinx.com> References: <20220421044744.3777983-1-nava.manne@xilinx.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 33d21f07-e96f-4b74-0096-08da23521b6f X-MS-TrafficTypeDiagnostic: MW4PR02MB7411:EE_ X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JDNnMXZvR/kB1JjhpBwA2cyJTfQ0DcHf6bm2KCTOKAySbSQYXCy0leQ8Ix0z0yW85sjPM+Ut9HloigxDsBwytoVCbO8viTIbdFhCN+n3Q/+WPhaaAhbWhcrKAN7eOSHQXYwJfp5AqLmw1s3HOnO/VmwXRPWqYejn1QiFtnHlS6BOApbTrP0Id9Xrs1iNvg+SPB9O/Zjv67XEGJ2K+b/4u/RCPCz+h++rzyRFLPwKFXrgqZloqoQtW1UgaLP2+FQ7xmoDkeXIxaKd3LjWDl46MOjwi8iDileT/tFiWTHyEhFdS35fpP/h2b9GRRvSjrgYqsuHLY/FvW/3KXOhPYguhmto5RF8MgadWqjfGSpsxRyW0tBgt3vL2UJYHAs6v1xOdJA0PIaZwXoNXNF8UfXkl4hXMOkmMuiN5yKS8RcnLJNuja4Q6X0/2CZyMBU9MTQ9I0WccK2JOTl7zXFQTLlvN/IfN/+oNAueqJF5VI6Uo0xcTseVpyv2b5KFoeOOcvBN4ewvywfTAYPDZDMqiy37/fLtXBiBqJIx30EJNr34UN+g0BMLqNiD1osQFYnpxtRjfyOGt6pWfXQv53cNzn+ddsIIu4fp+WVKRqAAhnyNTJu/rpvLyW7NAjrMpnkM+KZQsjiRbwLGwRpBhJjiOWPcnY/m9yndj5owhL9ya68MTxn2JO9fVO2qN5yzMvbu49AbBsjnPkozJseS2bwu6E9P4UpoBzhIZypmIvTU3eY6xqQ= X-Forefront-Antispam-Report: CIP:149.199.62.198;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapexch01.xlnx.xilinx.com;PTR:unknown-62-198.xilinx.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(70586007)(82310400005)(6666004)(26005)(7696005)(6636002)(316002)(110136005)(508600001)(7636003)(356005)(70206006)(107886003)(47076005)(40460700003)(2616005)(426003)(336012)(1076003)(186003)(8936002)(9786002)(5660300002)(83380400001)(2906002)(8676002)(4326008)(36860700001)(36756003)(102446001)(2101003);DIR:OUT;SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2022 04:47:57.9646 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 33d21f07-e96f-4b74-0096-08da23521b6f X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: BN1NAM02FT021.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR02MB7411 Precedence: bulk List-ID: X-Mailing-List: linux-fpga@vger.kernel.org fixes the below checks reported by checkpatch.pl: - Lines should not end with a '(' - Alignment should match open parenthesis Signed-off-by: Nava kishore Manne Acked-by: Xu Yilun --- Changes for v2: -None. Changes for v3: -Fixed similar issue exists in "drivers/fpga/*". Changes for v4: -None. Changes for v5: - Reduced the length of the 'fpga_mgr_write_init(...)' API as suggested by Joe. - To align Include declaration and definition of APIs updated the FPGA-region.h file as suggested by joe. drivers/fpga/fpga-mgr.c | 4 ++-- drivers/fpga/fpga-region.c | 7 ++++--- drivers/fpga/of-fpga-region.c | 6 +++--- include/linux/fpga/fpga-region.h | 7 ++++--- 4 files changed, 13 insertions(+), 11 deletions(-) diff --git a/drivers/fpga/fpga-mgr.c b/drivers/fpga/fpga-mgr.c index d49a9ce34568..d9a2aad7b35f 100644 --- a/drivers/fpga/fpga-mgr.c +++ b/drivers/fpga/fpga-mgr.c @@ -148,11 +148,11 @@ static int fpga_mgr_write_init_buf(struct fpga_manager *mgr, int ret; mgr->state = FPGA_MGR_STATE_WRITE_INIT; + count = min(mgr->mops->initial_header_size, count); if (!mgr->mops->initial_header_size) ret = fpga_mgr_write_init(mgr, info, NULL, 0); else - ret = fpga_mgr_write_init( - mgr, info, buf, min(mgr->mops->initial_header_size, count)); + ret = fpga_mgr_write_init(mgr, info, buf, count); if (ret) { dev_err(&mgr->dev, "Error preparing FPGA for writing\n"); diff --git a/drivers/fpga/fpga-region.c b/drivers/fpga/fpga-region.c index b0ac18de4885..3864bf4f8920 100644 --- a/drivers/fpga/fpga-region.c +++ b/drivers/fpga/fpga-region.c @@ -18,9 +18,10 @@ static DEFINE_IDA(fpga_region_ida); static struct class *fpga_region_class; -struct fpga_region *fpga_region_class_find( - struct device *start, const void *data, - int (*match)(struct device *, const void *)) +struct fpga_region *fpga_region_class_find(struct device *start, + const void *data, + int (*match)(struct device *, + const void *)) { struct device *dev; diff --git a/drivers/fpga/of-fpga-region.c b/drivers/fpga/of-fpga-region.c index 50b83057c048..55209737075f 100644 --- a/drivers/fpga/of-fpga-region.c +++ b/drivers/fpga/of-fpga-region.c @@ -189,9 +189,9 @@ static int child_regions_with_firmware(struct device_node *overlay) * fpga_image_info struct if there is an image to program. * error code for invalid overlay. */ -static struct fpga_image_info *of_fpga_region_parse_ov( - struct fpga_region *region, - struct device_node *overlay) +static struct fpga_image_info +*of_fpga_region_parse_ov(struct fpga_region *region, + struct device_node *overlay) { struct device *dev = ®ion->dev; struct fpga_image_info *info; diff --git a/include/linux/fpga/fpga-region.h b/include/linux/fpga/fpga-region.h index 3b87f232425c..7ebf743b8f8a 100644 --- a/include/linux/fpga/fpga-region.h +++ b/include/linux/fpga/fpga-region.h @@ -52,9 +52,10 @@ struct fpga_region { #define to_fpga_region(d) container_of(d, struct fpga_region, dev) -struct fpga_region *fpga_region_class_find( - struct device *start, const void *data, - int (*match)(struct device *, const void *)); +struct fpga_region *fpga_region_class_find(struct device *start, + const void *data, + int (*match)(struct device *, + const void *)); int fpga_region_program_fpga(struct fpga_region *region); From patchwork Thu Apr 21 04:47:42 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nava kishore Manne X-Patchwork-Id: 12821043 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1450FC433F5 for ; Thu, 21 Apr 2022 04:50:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1383385AbiDUEvt (ORCPT ); Thu, 21 Apr 2022 00:51:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37786 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1384144AbiDUEvN (ORCPT ); Thu, 21 Apr 2022 00:51:13 -0400 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2083.outbound.protection.outlook.com [40.107.243.83]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51DEC12775; Wed, 20 Apr 2022 21:48:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YGRxEmJ0oUwhthGRLLVdvB3+DObkKSs83Tnl9USOVY/w5+w3/SI1hAzKWqBS4Jn47rjYSl3AuKGb0LxzMxvOVmJRR7zW0acU2+J+3AVWRouS98p//BiU37WMzLyV97lWWv60IGDzvThXLkWMsLj1W0sKkW+FcgfLfMKPp0M36W8EW5Bo5xMxitHKzS7i3zUhdz+5HDy/WlXoQIhc4uZHqoeJV/Kmb/Zg87x8oRPPuVH36kx961SXotpE5e0oMp2VS0ibWnKZv0gs7qgx0kQcnFXktFdWV/PyWDIxM51aPi7WM/Ae1JmNDS35EGgORClRA/Lw9lnBEaoKGsbxHxAeFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LgrCu266jMQsubVYVEzXTdhKc+k4GI3Rzf7zLOk3OKk=; b=baKaxJGuup3kzeUI/xe+Mtkl0RzbttcYMGPe+MRcNBh/ym1j1zEkIdUvpvPCg9WPOv5aLEZzdmCjGdwufhZW/2Nnt8stR2ATp/vUQ9WIKur1iyWFomdt/SbTUonu8dWLeiZJJF8ndoagD6GpHUlWcbP6o2PSyN4FgIOk8o3gIt0wDIxnfohOcP1HmpKhkymRt9vQkGPAb/UCadmXqeAFPfC6tnuNZ/3OJ3Yce9Lh5aZDfJpjiLBeaf8lrT1NCl9cwqGZidwqxCqAskiAahBIulVRfLgAvVgcB68A6SdgoJY4UsXfhzJqPB1NQfUprRiLLaoxXzisEq6L0C+NQyHN8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=kernel.org smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LgrCu266jMQsubVYVEzXTdhKc+k4GI3Rzf7zLOk3OKk=; b=QTDAqFNtR6sY0cPsJWCk90+SfSLKkGX0HbYd9pZ53+JyGNF6nXEbKDh+4Z2R94fzrByX2xqildsoHDa59uJt/Y9fmhh2lfYOtQfZC9Wu49C0B7kwj1yUeNYhrRZosd3QbdQNvctb87xOyYrPYctVZWjy0N1+yE/qo//CiCySS+o= Received: from BN9PR03CA0663.namprd03.prod.outlook.com (2603:10b6:408:10e::8) by MWHPR02MB2494.namprd02.prod.outlook.com (2603:10b6:300:40::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Thu, 21 Apr 2022 04:48:23 +0000 Received: from BN1NAM02FT018.eop-nam02.prod.protection.outlook.com (2603:10b6:408:10e:cafe::49) by BN9PR03CA0663.outlook.office365.com (2603:10b6:408:10e::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13 via Frontend Transport; Thu, 21 Apr 2022 04:48:23 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch01.xlnx.xilinx.com; Received: from xsj-pvapexch01.xlnx.xilinx.com (149.199.62.198) by BN1NAM02FT018.mail.protection.outlook.com (10.13.3.159) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5186.14 via Frontend Transport; Thu, 21 Apr 2022 04:48:22 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch01.xlnx.xilinx.com (172.19.86.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Wed, 20 Apr 2022 21:47:59 -0700 Received: from smtp.xilinx.com (172.19.127.95) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Wed, 20 Apr 2022 21:47:59 -0700 Envelope-to: git@xilinx.com, mdf@kernel.org, hao.wu@intel.com, yilun.xu@intel.com, trix@redhat.com, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Received: from [10.140.6.60] (port=35750 helo=xhdnavam40.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1nhOjX-0002Sb-2M; Wed, 20 Apr 2022 21:47:59 -0700 From: Nava kishore Manne To: , , , , , , , , CC: Nava kishore Manne Subject: [PATCH v5 3/5] fpga: fpga-mgr: fix kernel-doc warnings Date: Thu, 21 Apr 2022 10:17:42 +0530 Message-ID: <20220421044744.3777983-4-nava.manne@xilinx.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220421044744.3777983-1-nava.manne@xilinx.com> References: <20220421044744.3777983-1-nava.manne@xilinx.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 25ba1a82-8c04-422b-109b-08da23522a44 X-MS-TrafficTypeDiagnostic: MWHPR02MB2494:EE_ X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: u307XgvxK1HhrLK/4D/royOXWHrgDKtL3PHAyf+Ytk5VOmrHB2DJ/x3MH2zdjQ5QsVVF3zvOyU1+K0MM0oZfFjjlAMCN8gMMNPjmZbHueupK/PG4PdElSXL1wqd5Mb7aXmsVH02fnW2Krak7fOH5ZsOUKrhi0/Cty3x+MmGT19a1j8iTuOBnUAB+BMqHID2FEowdIlLXC9deJczU6UNSe4FcBzw8phaAHlKt3xkmnwdaarM7JHoZ9LYMqnNjL/OiipmZoNZfGbNmWg+AJC4c5oeBmIIyWScthZfswWuhc9sL7sg967sryYdRkbmDuSVlMNA8AbvsRkIzO2ZMbGSKSJBDmMQkZwVOw3dvybDpFT3fcW/U8Gp1UQhS73VyqFgHWrdiD5AVh4jDiIQt7posmT7cgOHhjPUSMuMRWA8EyuW4RbKkiCstctD+HM45UBOHOE85h+DDhOo+nyBgf2AYyUAoCPq+5QXeY1IwLhrjxnMdUE0I7roJSu+FOTjeKyFczfmMNaqpj7w3JRgFU2sCfmB2sX3HWe7JyErGNkYnCV2tN+4tFRj5xk315U7O5w0bf1Bu7t7gAy0e8EvlewOdKIRC8c1dJtanpdHMB4Cy6uFwnPVSg0FEJPaOJKqaqsPLe3BnU2xjXVBbOrz2i2iLkO2KmtCcz4CGG7M4BKl77bs+Lqoca84dPRi//oWKmpCZKcDRdnyFNCutrXfNzOfwAM+erOevysAtfBSwWEyOHFV9klE5gvjQoNBcCq/9puPC X-Forefront-Antispam-Report: CIP:149.199.62.198;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapexch01.xlnx.xilinx.com;PTR:unknown-62-198.xilinx.com;CAT:NONE;SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(70206006)(47076005)(8676002)(70586007)(4326008)(508600001)(83380400001)(336012)(8936002)(2616005)(7696005)(2906002)(40460700003)(9786002)(1076003)(6666004)(26005)(5660300002)(426003)(186003)(356005)(107886003)(110136005)(7636003)(36756003)(316002)(82310400005)(36860700001)(6636002)(102446001)(21314003)(2101003);DIR:OUT;SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2022 04:48:22.8334 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 25ba1a82-8c04-422b-109b-08da23522a44 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: BN1NAM02FT018.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR02MB2494 Precedence: bulk List-ID: X-Mailing-List: linux-fpga@vger.kernel.org warnings: No description found for return value of 'xxx' In-order to fix the above kernel-doc warnings added the 'Return' description for 'devm_fpga_mgr_register_full()' and 'devm_fpga_mgr_register()' APIs. Signed-off-by: Nava kishore Manne Acked-by: Xu Yilun --- Changes for v2: -Replaced s/@return:/Return:/ Changes for v3: -Updated commit description. Changes for v4: -Updated commit description. Changes for v5: -Updated commit description. drivers/fpga/fpga-mgr.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/fpga/fpga-mgr.c b/drivers/fpga/fpga-mgr.c index d9a2aad7b35f..6bd018f20793 100644 --- a/drivers/fpga/fpga-mgr.c +++ b/drivers/fpga/fpga-mgr.c @@ -730,6 +730,8 @@ static void devm_fpga_mgr_unregister(struct device *dev, void *res) * @parent: fpga manager device from pdev * @info: parameters for fpga manager * + * Return: fpga manager pointer on success, negative error code otherwise. + * * This is the devres variant of fpga_mgr_register_full() for which the unregister * function will be called automatically when the managing device is detached. */ @@ -763,6 +765,8 @@ EXPORT_SYMBOL_GPL(devm_fpga_mgr_register_full); * @mops: pointer to structure of fpga manager ops * @priv: fpga manager private data * + * Return: fpga manager pointer on success, negative error code otherwise. + * * This is the devres variant of fpga_mgr_register() for which the * unregister function will be called automatically when the managing * device is detached. From patchwork Thu Apr 21 04:47:43 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nava kishore Manne X-Patchwork-Id: 12821041 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B634C433FE for ; Thu, 21 Apr 2022 04:50:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350564AbiDUEvF (ORCPT ); Thu, 21 Apr 2022 00:51:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37452 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1384145AbiDUEvD (ORCPT ); Thu, 21 Apr 2022 00:51:03 -0400 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2057.outbound.protection.outlook.com [40.107.237.57]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0076512AA9; Wed, 20 Apr 2022 21:48:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FrnlJcv1PLbCMNzqa6vdOxfbxP3KkC7ug39kgZO/eGzaG6XLUk6jCTLVdRttEpeUwbz49haw1Ma8bq0Obhs9CX0OElSM+9lcl4gAJ+X2fdcCgQzvWUYk8AqHqCA42FL+eo1Yqhfz7gzopAQhhEtfLTiybVAJAot59onm5iJbntP0+za4KWHjA9f1LoW3xrHO2r7CpxROhaO6xaF1cGhYsTBYaBNY85y86RJgUyuFjM1JI9n4HAfzTuAH57EposDdKHbTJvEUNCXtCtZX/ROPktKxJaObNMgMFbu2NWZ2fWHlnHfJC0z8td+JNKyEP7XvvSebXB48HvGUp6hidWCSNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=C4zM5twy8hBrPLh82bU64FcZmzDh/MNsmzkXbW6S33Q=; b=ebUVr6uLJpnZie41RLpJ/2TCDYVnGvTSzY1QhJlx/kO9iKu5DBqc5Ad4ceFkU0mlUtIUunCEXqbk5WPdw/cNfLYAxP6sPybI51aujhhWtgOFhI0mPK93tIEzNl2Fj7ydn1gKk5uKzZu7hF2s4Glre89oow/rIYQQQye6VZUtDIdSKGbQXNLYz6lO0iNwUbjQY1LpH6F+Rvn0si93PmWlULSuu/2c8YowC8A4Et8iym0NVEZJFlA/PZMQ4GLoJpk1jHYmwN5apdFRUJO+H/5DLXLcFj9Llq0Vpz2Rhm/zMoU5jVu0KVhTWE0pRR7TvXodLohCU/OgEc4x8XtdaDm+OA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=kernel.org smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C4zM5twy8hBrPLh82bU64FcZmzDh/MNsmzkXbW6S33Q=; b=m9/TfxKhrJpEcg8qrGV29Wlyj81Pc73rTJ9/9gr3+3ncLQtd01godvp5+n8sp0u6h7wJLt+jJWrwFvsRwXP4XZO1AGBV2AOzVfNLRmPyst7Xlw5EhTC0Yv2UUz7VFrYoVudZWfPtJXdR75JjKiDbsQ/pZYN7zTh+rLKZdqxTtV4= Received: from BN9PR03CA0612.namprd03.prod.outlook.com (2603:10b6:408:106::17) by DM6PR02MB7100.namprd02.prod.outlook.com (2603:10b6:5:25a::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Thu, 21 Apr 2022 04:48:06 +0000 Received: from BN1NAM02FT022.eop-nam02.prod.protection.outlook.com (2603:10b6:408:106:cafe::98) by BN9PR03CA0612.outlook.office365.com (2603:10b6:408:106::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13 via Frontend Transport; Thu, 21 Apr 2022 04:48:06 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch02.xlnx.xilinx.com; Received: from xsj-pvapexch02.xlnx.xilinx.com (149.199.62.198) by BN1NAM02FT022.mail.protection.outlook.com (10.13.2.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5186.14 via Frontend Transport; Thu, 21 Apr 2022 04:48:06 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Wed, 20 Apr 2022 21:48:02 -0700 Received: from smtp.xilinx.com (172.19.127.95) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Wed, 20 Apr 2022 21:48:02 -0700 Envelope-to: git@xilinx.com, mdf@kernel.org, hao.wu@intel.com, yilun.xu@intel.com, trix@redhat.com, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Received: from [10.140.6.60] (port=35750 helo=xhdnavam40.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1nhOja-0002Sb-0W; Wed, 20 Apr 2022 21:48:02 -0700 From: Nava kishore Manne To: , , , , , , , , CC: Nava kishore Manne Subject: [PATCH v5 4/5] fpga: Use tab instead of space indentation Date: Thu, 21 Apr 2022 10:17:43 +0530 Message-ID: <20220421044744.3777983-5-nava.manne@xilinx.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220421044744.3777983-1-nava.manne@xilinx.com> References: <20220421044744.3777983-1-nava.manne@xilinx.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 483fd419-9da1-4ba2-5796-08da23522075 X-MS-TrafficTypeDiagnostic: DM6PR02MB7100:EE_ X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: b0x8iqgILjvozwOPnOBdRuNmemk11/T2uv0D5NOcJ9iIqQhq+W4qFB2SjIKMT5VJx7N6u/dc/rcGrdmQkiWAew9naXt0fFzlr6kc874pB3f+TaL5SQ5dDLNj0IKw9WlBUTM9oDKNrxXS2xLYbiQJ37wXH4BG/ph+pQ/mtHurHf8WJqrP6jWzXB92J0FnE4mvs8/U7hZp9vP6vdHAiLyeznIeFtrtqwB7Qmby7zQRG2iydKnh7FQICJ/0TvGmwja8Tt2BwrWMEtYi0m0basj8gBvvTsu7ZkvlYKidQ16boVWTBUfTWWFCqMqSuC1m5nFTzWl/lvvTdkk68g55ZKsvbgSHfPHuu4vKCn1VcX0gWHeNl5uXMijYhE0TJ8TXAVhdD848FuNnk1g9o2zKwx2MzUR8mQWQPJPQwyq1DUO5FKjU4J/JpRcxs3FOju+iPySdBOlYriUZUkzoLS6fp9U2+hG3Uyn8EWUNfGHqZBQ5Yq86N+dyETQx5L+igWzPc3hBv+a4AxqIDNDGwM9YLXCltni/2AH1rxoh79xHuq0OC5l/NYPVmNBTdBVSahuLG4kgi+/g6s/0BHaEuxDTC8Zbrcf35m1IUvS3KKTsuj+iIvnDXvi+Tn+XUwfp6UocXJ1EM13gzTUOA+2PmFfMLlTB8wdmg/IxBIXLzbeIK9KLFQAsIGmRjmLAcz5RUbEN22DpI0vu7iX/DqYRCathrkRD6Lb5EjsFtZyO2t3njNo6uvY= X-Forefront-Antispam-Report: CIP:149.199.62.198;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapexch02.xlnx.xilinx.com;PTR:unknown-62-198.xilinx.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(36860700001)(83380400001)(4326008)(8676002)(36756003)(70586007)(70206006)(9786002)(8936002)(316002)(6636002)(186003)(110136005)(5660300002)(2906002)(82310400005)(26005)(1076003)(2616005)(107886003)(508600001)(426003)(336012)(47076005)(40460700003)(7636003)(356005)(6666004)(7696005)(102446001)(2101003);DIR:OUT;SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2022 04:48:06.3791 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 483fd419-9da1-4ba2-5796-08da23522075 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: BN1NAM02FT022.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR02MB7100 Precedence: bulk List-ID: X-Mailing-List: linux-fpga@vger.kernel.org In FPGA Makefile has both space and tab indentation, to make them align use tab instead of space indentation. Signed-off-by: Nava kishore Manne Acked-by: Xu Yilun --- Changes for v2: -None. Changes for v3: -Updated commit description. Changes for v4: -None. Changes for v5: -Updated commit description. drivers/fpga/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/fpga/Makefile b/drivers/fpga/Makefile index 0bff783d1b61..5935b3d0abd5 100644 --- a/drivers/fpga/Makefile +++ b/drivers/fpga/Makefile @@ -18,9 +18,9 @@ obj-$(CONFIG_FPGA_MGR_TS73XX) += ts73xx-fpga.o obj-$(CONFIG_FPGA_MGR_XILINX_SPI) += xilinx-spi.o obj-$(CONFIG_FPGA_MGR_ZYNQ_FPGA) += zynq-fpga.o obj-$(CONFIG_FPGA_MGR_ZYNQMP_FPGA) += zynqmp-fpga.o -obj-$(CONFIG_FPGA_MGR_VERSAL_FPGA) += versal-fpga.o -obj-$(CONFIG_ALTERA_PR_IP_CORE) += altera-pr-ip-core.o -obj-$(CONFIG_ALTERA_PR_IP_CORE_PLAT) += altera-pr-ip-core-plat.o +obj-$(CONFIG_FPGA_MGR_VERSAL_FPGA) += versal-fpga.o +obj-$(CONFIG_ALTERA_PR_IP_CORE) += altera-pr-ip-core.o +obj-$(CONFIG_ALTERA_PR_IP_CORE_PLAT) += altera-pr-ip-core-plat.o # FPGA Bridge Drivers obj-$(CONFIG_FPGA_BRIDGE) += fpga-bridge.o From patchwork Thu Apr 21 04:47:44 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nava kishore Manne X-Patchwork-Id: 12821042 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B491FC433F5 for ; Thu, 21 Apr 2022 04:50:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1384123AbiDUEvO (ORCPT ); Thu, 21 Apr 2022 00:51:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1384141AbiDUEvG (ORCPT ); Thu, 21 Apr 2022 00:51:06 -0400 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam07on2059.outbound.protection.outlook.com [40.107.95.59]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B43931277F; Wed, 20 Apr 2022 21:48:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hejPcYuJB63D9sugL7uq+MOqdUoFpwSNNJGI4dw28a2oy63MYG6DuCzgCvMtpCP02q80qkBdJVyrc2B9+yNB8JHEQsAQ/1nHUDUrRokE/PeJ7B1OG9izYtiEI+/VHrI3w4JJU6yVcWPBjVVOYS6Fmb0aF5D5uQnzkPIgpvE7/+d/7nxhyxipbCrj7yqZA2pTqwPBd5sA7lBai7CIJIjqMhAPsoXUBgIHOrMjk8dbnluilm6K80dW/VqYqxEFA+TJQq579+uAx4qLRQTM9RjIcufo/MtaRMo7lLXHSwQYLnUhRTlSMXeQpuXdJb9eghteDxzIi8Q++Cg1JyanBI433A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Te8RHhwAl+kYv2piiuU9SHbgUVIrEOFFHHhFxIR5XnQ=; b=CZffssDt24B7SaFhdpc7Xek6znK6EOwUwV2sc2Q6QgV61YPeZ9Ww4NJRBZ2cIkKY/ugLbO+Z9if7n6HOx+LtnVP9agUCNQpljUibI9fJMCGaKrKFu3eynRKkNG7OiPzCvHREUhIrhCsE54VYqvwoiZIuvKUaLT7VJzO+8kb0wLggtJACJDHrp/SR8BLtvcaF7aAXikbp8ES95ydQFJkMuoj3CX+Bo4BKYYv2lf8jjQ3NCSyAnOCvJhckObPFdhzguJsOD9jlVVJx4BtuQ70/jxUsImDIsVvaQ1/QWcMum+RGdiN5+6mEcDz8ti9vzkJ/NeP42ZNQHGgHv8aRS/x9tw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=kernel.org smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Te8RHhwAl+kYv2piiuU9SHbgUVIrEOFFHHhFxIR5XnQ=; b=CKYTp1xhBBFxkBJKRlCTDKSRJmtuZbXLr/8QxsR1g84F6XXJvjY3izqil7zMvgKUvJWg1lu4BnUUjRiPI+0Mojs0y9BxLFoYujFPy4GAtXDmGpTfGo+vJkqyNPFkG0RLFBmCnAUTJoc2NJEM+UXGZxnbnIZ2L/MDmAL+xFyXzMU= Received: from BN9PR03CA0615.namprd03.prod.outlook.com (2603:10b6:408:106::20) by BY5PR02MB6082.namprd02.prod.outlook.com (2603:10b6:a03:1fe::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Thu, 21 Apr 2022 04:48:13 +0000 Received: from BN1NAM02FT022.eop-nam02.prod.protection.outlook.com (2603:10b6:408:106:cafe::a9) by BN9PR03CA0615.outlook.office365.com (2603:10b6:408:106::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13 via Frontend Transport; Thu, 21 Apr 2022 04:48:12 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch02.xlnx.xilinx.com; Received: from xsj-pvapexch02.xlnx.xilinx.com (149.199.62.198) by BN1NAM02FT022.mail.protection.outlook.com (10.13.2.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5186.14 via Frontend Transport; Thu, 21 Apr 2022 04:48:12 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Wed, 20 Apr 2022 21:48:05 -0700 Received: from smtp.xilinx.com (172.19.127.95) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Wed, 20 Apr 2022 21:48:05 -0700 Envelope-to: git@xilinx.com, mdf@kernel.org, hao.wu@intel.com, yilun.xu@intel.com, trix@redhat.com, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Received: from [10.140.6.60] (port=35750 helo=xhdnavam40.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1nhOjc-0002Sb-Ux; Wed, 20 Apr 2022 21:48:05 -0700 From: Nava kishore Manne To: , , , , , , , , CC: Nava kishore Manne Subject: [PATCH v5 5/5] fpga: fpga-region: fix kernel-doc formatting issues Date: Thu, 21 Apr 2022 10:17:44 +0530 Message-ID: <20220421044744.3777983-6-nava.manne@xilinx.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220421044744.3777983-1-nava.manne@xilinx.com> References: <20220421044744.3777983-1-nava.manne@xilinx.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 754b2d37-7809-44b0-c7c8-08da23522446 X-MS-TrafficTypeDiagnostic: BY5PR02MB6082:EE_ X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oBRx553Aks3I+u2KQ+39+Sf1XTkG0pUitg+AIdAk4CgaxdZG0bwGEHtIMlOnpOUVk7YpoOdkiq6XJRbkbfCyjDag0jxo+8XiKbhOcRaKALbaTt+NnOhC4qrSb5YakN7v9FUM1uNgJalixTELu4uCQ4V8b861bAUWdDK7jtYO/83J22WSEIbji3NYtpPSc8HSfgeQ57X5exNvLsFKWWDp42gsReXElQ1jAnXWTvdkK/65ln2+WZOKMM4PWJXQTWfRz9fVHJxfU3zWas3iMkYvlIf6eeWVd9jqAipTgN67UZivGZ93JS+Igd17iJM3tTXBRefbNr6yAtAznUBsNXQOcbz61Htbn89/OTpX5Gae7YkJxeXzm/F/L6PubvcrvR2OlZmcokhfPG8wF68jXYLodoEAuNNYHkKW1nisfxglv1rHyPMWXjbRuSQvGSt1BMW8wqBA3l6g3pMmP+zp0x2c8Kt8cONLC1dLGRm7mhrapFM7NfLzYMNdDWFMoWbMHL1IacDDJgNp4kYreyaMiVnn7rUCFSCB3XWmt4v84g6lxJ/JVXsCde23Rt8IZyotmolanfh4xjY7H9ATnxbRgjM8k2yi/mfj00/Jm/gZsHMB1p8oqeFVaCoq8ynMBG+WK8gMVNBLcWZxb8CIy9Y4iAnW3wHl71xtsDlXl2apm+3O2APZDonjYOQ7oPZzIAGkadee7buuDzV99bVXIFs99vg2Y4WkIbenJBYLWU6I6v7LjyE= X-Forefront-Antispam-Report: CIP:149.199.62.198;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:xsj-pvapexch02.xlnx.xilinx.com;PTR:unknown-62-198.xilinx.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(5660300002)(508600001)(9786002)(2906002)(8936002)(7636003)(110136005)(356005)(6636002)(40460700003)(316002)(8676002)(70586007)(70206006)(4326008)(47076005)(83380400001)(107886003)(186003)(1076003)(336012)(2616005)(26005)(426003)(6666004)(82310400005)(7696005)(36860700001)(36756003)(102446001)(2101003);DIR:OUT;SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2022 04:48:12.7849 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 754b2d37-7809-44b0-c7c8-08da23522446 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: BN1NAM02FT022.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR02MB6082 Precedence: bulk List-ID: X-Mailing-List: linux-fpga@vger.kernel.org To fix below kernel-doc warnings this patch does the following ->Replaced Return\Returns with 'Return:' keyword. ->Added 'Return' description For __init of_fpga_region_init()' API. ->Added description for 'child_regions_with_firmware()' API. warning: No description found for return value of 'of_fpga_region_find'. warning: No description found for return value of 'of_fpga_region_get_bridges'. warning: missing initial short description on line: * child_regions_with_firmware warning: No description found for return value of 'child_regions_with_firmware'. warning: No description found for return value of 'of_fpga_region_notify_pre_apply'. warning: No description found for return value of 'of_fpga_region_notify'. warning: No description found for return value of 'of_fpga_region_init'. Signed-off-by: Nava kishore Manne Acked-by: Xu Yilun --- Changes for v2: -Replaced s/@return:/Return:/ Changes for v3: -Updated commit description. Changes for v4: -Updated commit description. Changes for v5: -None. drivers/fpga/of-fpga-region.c | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/fpga/of-fpga-region.c b/drivers/fpga/of-fpga-region.c index 55209737075f..b5ae3e8de5ab 100644 --- a/drivers/fpga/of-fpga-region.c +++ b/drivers/fpga/of-fpga-region.c @@ -28,7 +28,7 @@ MODULE_DEVICE_TABLE(of, fpga_region_of_match); * * Caller will need to put_device(®ion->dev) when done. * - * Returns FPGA Region struct or NULL + * Return: FPGA Region struct or NULL */ static struct fpga_region *of_fpga_region_find(struct device_node *np) { @@ -80,7 +80,7 @@ static struct fpga_manager *of_fpga_region_get_mgr(struct device_node *np) * Caller should call fpga_bridges_put(®ion->bridge_list) when * done with the bridges. * - * Return 0 for success (even if there are no bridges specified) + * Return: 0 for success (even if there are no bridges specified) * or -EBUSY if any of the bridges are in use. */ static int of_fpga_region_get_bridges(struct fpga_region *region) @@ -139,13 +139,13 @@ static int of_fpga_region_get_bridges(struct fpga_region *region) } /** - * child_regions_with_firmware + * child_regions_with_firmware - Used to check the child region info. * @overlay: device node of the overlay * * If the overlay adds child FPGA regions, they are not allowed to have * firmware-name property. * - * Return 0 for OK or -EINVAL if child FPGA region adds firmware-name. + * Return: 0 for OK or -EINVAL if child FPGA region adds firmware-name. */ static int child_regions_with_firmware(struct device_node *overlay) { @@ -184,7 +184,7 @@ static int child_regions_with_firmware(struct device_node *overlay) * Given an overlay applied to an FPGA region, parse the FPGA image specific * info in the overlay and do some checking. * - * Returns: + * Return: * NULL if overlay doesn't direct us to program the FPGA. * fpga_image_info struct if there is an image to program. * error code for invalid overlay. @@ -279,7 +279,7 @@ static struct fpga_image_info * If the checks fail, overlay is rejected and does not get added to the * live tree. * - * Returns 0 for success or negative error code for failure. + * Return: 0 for success or negative error code for failure. */ static int of_fpga_region_notify_pre_apply(struct fpga_region *region, struct of_overlay_notify_data *nd) @@ -339,7 +339,7 @@ static void of_fpga_region_notify_post_remove(struct fpga_region *region, * This notifier handles programming an FPGA when a "firmware-name" property is * added to an fpga-region. * - * Returns NOTIFY_OK or error if FPGA programming fails. + * Return: NOTIFY_OK or error if FPGA programming fails. */ static int of_fpga_region_notify(struct notifier_block *nb, unsigned long action, void *arg) @@ -446,6 +446,8 @@ static struct platform_driver of_fpga_region_driver = { /** * of_fpga_region_init - init function for fpga_region class * Creates the fpga_region class and registers a reconfig notifier. + * + * Return: 0 on success, negative error code otherwise. */ static int __init of_fpga_region_init(void) {