From patchwork Thu Apr 21 09:57:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Filipe Manana X-Patchwork-Id: 12821407 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF4FFC433EF for ; Thu, 21 Apr 2022 09:57:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1387967AbiDUKAG (ORCPT ); Thu, 21 Apr 2022 06:00:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59008 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232617AbiDUKAF (ORCPT ); Thu, 21 Apr 2022 06:00:05 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 687B6237D1; Thu, 21 Apr 2022 02:57:16 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 2B927B82391; Thu, 21 Apr 2022 09:57:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1B55AC385A5; Thu, 21 Apr 2022 09:57:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650535034; bh=pKXdkPe8slEdVuFepa9Tj1DyELC4EFwYH5XyAcK/TV4=; h=From:To:Cc:Subject:Date:From; b=RCuVRz+tW3I4/7MdYvfA5s5W/Iqxv3RxiCNTwLQD6gERiNeEGmPkA9pNxmqIMFgZK pzsKS/X3p84KBxiOsEU8fwJZTTFtAXyC7P99mLtTQss2cRRutUrKIuzeEpAS5nJIAo CV5MsWdMBWVUUTH7YhB+FN0nDAOx2wN0SiO6qnKz5iV9QnCylSV39S1c1ixprTPLxt 0UfiklBqkBbJED+6+r7i8TItyrPcnxbTfSQIprDTcIJF+ouMhbygv0sFWUBWx5g3Pi dLvB6JjMhKYypcjxZBx9wrdB7NlZZyslVWLrYc5fMrAu7EI3o/oNf2NvPtMXQVqNJT g1rSO668+OS7Q== From: fdmanana@kernel.org To: fstests@vger.kernel.org Cc: linux-btrfs@vger.kernel.org, Filipe Manana Subject: [PATCH] generic: test fsync of directory with renamed symlink Date: Thu, 21 Apr 2022 10:57:04 +0100 Message-Id: X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org From: Filipe Manana Test that if we fsync a directory, create a symlink inside it, rename the symlink, fsync again the directory and then power fail, after the filesystem is mounted again, the symlink exists with the new name and it has the correct content. This currently fails on btrfs, because the symlink ends up empty (which is illegal on Linux), but it is fixed by a patch that has the subject: "btrfs: always log symlinks in full mode" Signed-off-by: Filipe Manana --- tests/generic/683 | 89 +++++++++++++++++++++++++++++++++++++++++++ tests/generic/683.out | 2 + 2 files changed, 91 insertions(+) create mode 100755 tests/generic/683 create mode 100644 tests/generic/683.out diff --git a/tests/generic/683 b/tests/generic/683 new file mode 100755 index 00000000..b9a955a3 --- /dev/null +++ b/tests/generic/683 @@ -0,0 +1,89 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2022 SUSE Linux Products GmbH. All Rights Reserved. +# +# FS QA Test 683 +# +# Test that if we fsync a directory, create a symlink inside it, rename the +# symlink, fsync again the directory and then power fail, after the filesystem +# is mounted again, the symlink exists with the new name and it has the correct +# content. +# +# On btrfs this used to result in the symlink being empty (i_size 0), and it was +# fixed by a patch with the subject: +# +# "btrfs: always log symlinks in full mode" +# +. ./common/preamble +_begin_fstest auto quick log + +_cleanup() +{ + _cleanup_flakey + cd / + rm -r -f $tmp.* +} + +. ./common/rc +. ./common/filter +. ./common/dmflakey + +# real QA test starts here + +_supported_fs generic +_require_scratch +_require_symlinks +_require_dm_target flakey + +rm -f $seqres.full + +# f2fs doesn't support fs-op level transaction functionality, so it has no way +# to persist all metadata updates in one transaction. We have to use its mount +# option "fastboot" so that it triggers a metadata checkpoint to persist all +# metadata updates that happen before a fsync call. Without this, after the +# last fsync in the test, the symlink named "baz" will not exist. +if [ $FSTYP = "f2fs" ]; then + export MOUNT_OPTIONS="-o fastboot $MOUNT_OPTIONS" +fi + +_scratch_mkfs >>$seqres.full 2>&1 +_require_metadata_journaling $SCRATCH_DEV +_init_flakey +_mount_flakey + +# Create our test directory. +mkdir $SCRATCH_MNT/testdir + +# Commit the current transaction and persist the directory. +sync + +# Create a file in the test directory, so that the next fsync on the directory +# actually does something (it logs the directory). +echo -n > $SCRATCH_MNT/testdir/foo + +# Fsync the directory. +$XFS_IO_PROG -c "fsync" $SCRATCH_MNT/testdir + +# Now create a symlink inside the test directory. +ln -s $SCRATCH_MNT/testdir/foo $SCRATCH_MNT/testdir/bar + +# Rename the symlink. +mv $SCRATCH_MNT/testdir/bar $SCRATCH_MNT/testdir/baz + +# Fsync again the directory. +$XFS_IO_PROG -c "fsync" $SCRATCH_MNT/testdir + +# Simulate a power failure and then mount again the filesystem to replay the +# journal/log. +_flakey_drop_and_remount + +# The symlink should exist, with the name "baz" and its content must be +# "$SCRATCH_MNT/testdir/foo". +[ -L $SCRATCH_MNT/testdir/baz ] || echo "symlink 'baz' is missing" +echo "symlink content: $(readlink $SCRATCH_MNT/testdir/baz | _filter_scratch)" + +_unmount_flakey + +# success, all done +status=0 +exit diff --git a/tests/generic/683.out b/tests/generic/683.out new file mode 100644 index 00000000..1167be40 --- /dev/null +++ b/tests/generic/683.out @@ -0,0 +1,2 @@ +QA output created by 683 +symlink content: SCRATCH_MNT/testdir/foo