From patchwork Thu Apr 21 15:09:46 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: kernel test robot X-Patchwork-Id: 12821818 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C87F5C433F5 for ; Thu, 21 Apr 2022 15:10:39 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0D14310E033; Thu, 21 Apr 2022 15:10:39 +0000 (UTC) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1457210E033 for ; Thu, 21 Apr 2022 15:10:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1650553838; x=1682089838; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=6s/Jh5/Nw/2YaODYM5uQMsmu5ex+nw0PjlAspdHlwBU=; b=AO7z6tmCft1L5ijTNWUZ/VB0j4JT4YY57EwX4Y3ThcCc3Ym7AsY5M/Bb 8BcnF3Mn0CTEi8k33kNABNPa4SNwXVr4mjVcZROWj05rJF6ln6SzZ36D+ wGVyffmmQDUjlBuPKRWnqAWzgMHg4rCDi+sUj6t50YQ5uAHh2tdjlp73h L4KeThmcuTK1fr8ei0gPMJXGGYZuxWqbCWL00vELBHkIGwpMht/I4dujz F3jZZcTXo20tKm/hGDBWjXrodtZy7pj3zAbSqhB3J6rOnvljY6uaQYJdq jhdTrBvPYZwfG9kVF68S3tovk/YdkE+ztPTuAj1lheH0dAY1iTbiCXYsF A==; X-IronPort-AV: E=McAfee;i="6400,9594,10324"; a="251693233" X-IronPort-AV: E=Sophos;i="5.90,279,1643702400"; d="scan'208";a="251693233" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Apr 2022 08:10:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,279,1643702400"; d="scan'208";a="626547444" Received: from lkp-server01.sh.intel.com (HELO 3abc53900bec) ([10.239.97.150]) by fmsmga004.fm.intel.com with ESMTP; 21 Apr 2022 08:10:21 -0700 Received: from kbuild by 3abc53900bec with local (Exim 4.95) (envelope-from ) id 1nhYRp-0008Vb-6c; Thu, 21 Apr 2022 15:10:21 +0000 Date: Thu, 21 Apr 2022 23:09:46 +0800 From: kernel test robot To: Sandor Yu Subject: [PATCH] drm: bridge: dw_hdmi: Audio: fix returnvar.cocci warnings Message-ID: References: <202204212311.TnfpcTGm-lkp@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <202204212311.TnfpcTGm-lkp@intel.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, Jernej Skrabec , kbuild-all@lists.01.org, Neil Armstrong , David Airlie , Shengjiu Wang , Jonas Karlman , linux-kernel@vger.kernel.org, Robert Foss , Linux Memory Management List , Laurent Pinchart , Andrzej Hajda Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: kernel test robot drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c:80:5-8: Unneeded variable: "ret". Return "0" on line 94 drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c:105:5-8: Unneeded variable: "ret". Return "0" on line 112 Remove unneeded variable used to store return value. Generated by: scripts/coccinelle/misc/returnvar.cocci CC: Sandor Yu Reported-by: kernel test robot Signed-off-by: kernel test robot Reviewed-by: Neil Armstrong Reviewed-by: Sandor Yu --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 65eb92e4c9f0a962656f131521f4fbc0d24c9d4c commit: d970ce303ff80ae57bbd3e784f2772dbf3056e0c [4441/5346] drm: bridge: dw_hdmi: Audio: Add General Parallel Audio (GPA) driver :::::: branch date: 8 hours ago :::::: commit date: 2 days ago drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-gp-audio.c @@ -77,7 +77,6 @@ static int audio_hw_params(struct device struct hdmi_codec_params *params) { struct snd_dw_hdmi *dw = dev_get_drvdata(dev); - int ret = 0; u8 ca; dw_hdmi_set_sample_rate(dw->data.hdmi, params->sample_rate); @@ -91,7 +90,7 @@ static int audio_hw_params(struct device params->iec.status[0] & IEC958_AES0_NONAUDIO); dw_hdmi_set_sample_width(dw->data.hdmi, params->sample_width); - return ret; + return 0; } static void audio_shutdown(struct device *dev, void *data) @@ -102,14 +101,13 @@ static int audio_mute_stream(struct devi bool enable, int direction) { struct snd_dw_hdmi *dw = dev_get_drvdata(dev); - int ret = 0; if (!enable) dw_hdmi_audio_enable(dw->data.hdmi); else dw_hdmi_audio_disable(dw->data.hdmi); - return ret; + return 0; } static int audio_get_eld(struct device *dev, void *data,