From patchwork Fri Apr 22 07:39:37 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hui Wang X-Patchwork-Id: 12822965 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4802BC433F5 for ; Fri, 22 Apr 2022 07:40:46 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 2F1361723; Fri, 22 Apr 2022 09:39:54 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 2F1361723 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1650613244; bh=sad6W7fSsklcw+UfZSdqvXQD6rkLhymaGEPnnZRSXB8=; h=From:To:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=EMRptGchhG1nE8BE5Gw90NuO9N01uixHoIlaAb8yPAL8bvp18rCMN1ju7Sx/b8vBP TlNyRuzG791suSnzSNrL2JzjFk/H/KX1YyteEyuTZyWrpSrJu8L89eVpQzdbeLIdqc 1AFV8HXzxrBQbMdEUxFPG1g0+ZZZvwEY6ZglCVWU= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id C7EB9F80154; Fri, 22 Apr 2022 09:39:53 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id D22FEF80245; Fri, 22 Apr 2022 09:39:52 +0200 (CEST) Received: from smtp-relay-canonical-1.canonical.com (smtp-relay-canonical-1.canonical.com [185.125.188.121]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id BA829F800D1 for ; Fri, 22 Apr 2022 09:39:46 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz BA829F800D1 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=canonical.com header.i=@canonical.com header.b="ClhivhJz" Received: from localhost.localdomain (unknown [123.112.65.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-1.canonical.com (Postfix) with ESMTPSA id 83A3A3F776; Fri, 22 Apr 2022 07:39:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1650613185; bh=DuRiumab7zYn7BMLUjK5U9ntoOKgstDPwsQqBhHpL7g=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=ClhivhJzBOMVbiNj0h8nRKOQCatd/iTJU9YvPfe0DOHNbCZJ92qmjxv/CpY19700V p5AX8O8dJ7h9d+hYsR7OuywJ1Eb38Fngq9htTQ6CRXIBPzjACQXf3WKyJIbF69xcen q1ZfuvuB5vJrLSzlXTzay5QBy2BOjY+M6QEEfUHVYyPLXN76kkPKzsiGJWcD3EERiw u62TkVA+r9zBCgyjc7pfvhpypf8XgBfaGFPkjehwR71cJB8FLtPX9vgIvU4UcBtMF3 yteyhYA01sgp1yXqZDoHTo7/auGGXfL2/SbK6xgq8/Kyp0z65hsF1zgmgDxIlsfFUG 6FvzlKUpnRLXg== From: Hui Wang To: alsa-devel@alsa-project.org, tiwai@suse.de Subject: [PATCH] ALSA: hda/realtek: Fix mute led issue on thinkpad with cs35l41 s-codec Date: Fri, 22 Apr 2022 15:39:37 +0800 Message-Id: <20220422073937.10073-1-hui.wang@canonical.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" The quirk ALC287_FIXUP_CS35L41_I2C_2 needs to chain the quirk ALC269_FIXUP_THINKPAD_ACPI, otherwise the mute led will not work if a thinkpad machine applies that quirk. And it will be safe if non-thinkpad machines apply that quirk since hda_fixup_thinkpad_acpi() will check and return in this case. Fixes: ae7abe36e352e ("ALSA: hda/realtek: Add CS35L41 support for Thinkpad laptops") Signed-off-by: Hui Wang --- sound/pci/hda/patch_realtek.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 4c0c593f3c0a..f9c3b2c9ca12 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -8769,6 +8769,8 @@ static const struct hda_fixup alc269_fixups[] = { [ALC287_FIXUP_CS35L41_I2C_2] = { .type = HDA_FIXUP_FUNC, .v.func = cs35l41_fixup_i2c_two, + .chained = true, + .chain_id = ALC269_FIXUP_THINKPAD_ACPI, }, [ALC287_FIXUP_CS35L41_I2C_2_HP_GPIO_LED] = { .type = HDA_FIXUP_FUNC,