From patchwork Sat Apr 23 05:44:34 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Karthik Alapati X-Patchwork-Id: 12824425 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40FC4C433EF for ; Sat, 23 Apr 2022 05:44:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233345AbiDWFrj (ORCPT ); Sat, 23 Apr 2022 01:47:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59416 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232541AbiDWFrg (ORCPT ); Sat, 23 Apr 2022 01:47:36 -0400 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A9EDDA88A6; Fri, 22 Apr 2022 22:44:40 -0700 (PDT) Received: by mail-pf1-f175.google.com with SMTP id j6so7574633pfe.13; Fri, 22 Apr 2022 22:44:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition; bh=P0diT9iDcYe1TifSZHN2PRcMMU/gU9bovyJTLCWyR74=; b=RXtShu8PuwriYVvaiNb9S0f6DcuyqCZz2jyrD+rfVgi44v9AT5AyHvdjAMaQ3q/pEg DNmhyDWVojm1KbfX7iecHeSlY5d7BqUZFGmm1ra4l/uSPzPrWfYtv/g7hdw8VBh0MtoV +KJXkBlZ/fy0SUnhMVrO9aNhEDsDgYd9Bm+2hASDwIra6Yc3xbhIws1yoHYYeTbupYE7 g6QfLP2cFS/RoymD4FVKEvY6c7qMJN83sK5eSXOdoTNfTA5y+D1wNNsHy1x3gM/CspgP XsS13tIN8tBXtgM5AClJAfAcOy5ipWCAFyIZA2M7wbWaphlhsClS/jNbiVcldsnhHM6R fW8g== X-Gm-Message-State: AOAM532dZnFXqCSC+Zy+M+6A3dZMMOZf8f8pdtokB4MPz12oJd/VnA44 v57kqwsZh6SxFeb/3DjJIOhod+D+MtbPXA== X-Google-Smtp-Source: ABdhPJw2ccwvag5NjSS5+MUAgUQEDEpmqr8eppkw74Vf5Pq3mfzCLLgKvn7hrVXUU3VlbyZAPbdxVg== X-Received: by 2002:a63:5b43:0:b0:39d:1a2b:5904 with SMTP id l3-20020a635b43000000b0039d1a2b5904mr6663505pgm.533.1650692680213; Fri, 22 Apr 2022 22:44:40 -0700 (PDT) Received: from karthik-strix-linux.karthek.com ([117.208.180.32]) by smtp.gmail.com with ESMTPSA id m22-20020a17090aab1600b001cd4989fecbsm7653996pjq.23.2022.04.22.22.44.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Apr 2022 22:44:39 -0700 (PDT) Date: Sat, 23 Apr 2022 11:14:34 +0530 From: Karthik Alapati To: Shuah Khan , Greg Kroah-Hartman , Christian Brauner , Carlos Llamas Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] selftests/binderfs: Improve message to provide more info Message-ID: MIME-Version: 1.0 Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org Currently the binderfs test says what failure it encountered without saying why it may occurred when it fails to mount binderfs. So, Warn about enabling CONFIG_ANDROID_BINDERFS in the running kernel. Signed-off-by: Karthik Alapati Reviewed-by: Christian Brauner (Microsoft) --- tools/testing/selftests/filesystems/binderfs/binderfs_test.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/filesystems/binderfs/binderfs_test.c b/tools/testing/selftests/filesystems/binderfs/binderfs_test.c index 0315955ff0f4..bc1c407651fc 100644 --- a/tools/testing/selftests/filesystems/binderfs/binderfs_test.c +++ b/tools/testing/selftests/filesystems/binderfs/binderfs_test.c @@ -412,7 +412,8 @@ TEST(binderfs_stress) ret = mount(NULL, binderfs_mntpt, "binder", 0, 0); ASSERT_EQ(ret, 0) { - TH_LOG("%s - Failed to mount binderfs", strerror(errno)); + TH_LOG("%s - Failed to mount binderfs, check if CONFIG_ANDROID_BINDERFS is enabled in the running kernel", + strerror(errno)); } for (int i = 0; i < ARRAY_SIZE(fds); i++) {