From patchwork Tue May 3 22:05:31 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 12836418 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 270C0C433F5 for ; Tue, 3 May 2022 22:05:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 87DCF6B0071; Tue, 3 May 2022 18:05:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 82D236B0072; Tue, 3 May 2022 18:05:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6F4876B0073; Tue, 3 May 2022 18:05:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 5D4106B0071 for ; Tue, 3 May 2022 18:05:36 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 1760220499 for ; Tue, 3 May 2022 22:05:36 +0000 (UTC) X-FDA: 79425814272.28.58436C1 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf09.hostedemail.com (Postfix) with ESMTP id 196A7140072 for ; Tue, 3 May 2022 22:05:29 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 66FED61720; Tue, 3 May 2022 22:05:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4D6ADC385A9; Tue, 3 May 2022 22:05:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651615533; bh=UsYHQ2RMFhU+kqPVwKX92XprgxwwCA2T6bnN4o6xFNk=; h=From:To:Cc:Subject:Date:From; b=DWdkr2Zn0xk9I/RIzkgqjqAwye1gPjoCBwYg81adHHk8aJOKVJvquxPtHWZ2f/T7N 4UUC1cYtIHuV/4kDMmqgVmYWZAPKjChzv0VMZ9oSRNpI35+cJdojXbjKj7PbfIwhbm 18QhXlaBtAlUTq5NWFtoYKBxa/ZQWlXkGjQB7oW0XN1QwoAeJiswsuHJyJIbMUo4ZJ Gu1iqZv7IYDG9DMEqYHVQJU/A9roAxikayJ5M/Ala+DhJThDrIVQfdez2W3d7PEAf5 zCsrDiBhbXZbVN6GlsMI88ea8QKsRGsZX2YBWfhWsKiCxpdnSwvWuk0DL7zID+Jfxo LpHAHAsI3RxwQ== From: SeongJae Park To: akpm@linux-foundation.org Cc: damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, SeongJae Park Subject: [PATCH] mm/damon/sysfs: fix pid leak under fvaddr ops use case Date: Tue, 3 May 2022 22:05:31 +0000 Message-Id: <20220503220531.45913-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=DWdkr2Zn; spf=pass (imf09.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 196A7140072 X-Stat-Signature: z96sknxpy6n5hry1tfeshkzfyk5ux83u X-HE-Tag: 1651615529-22761 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Commit c83136469313 ("mm/damon/sysfs: support fixed virtual address ranges monitoring") in 'mm-unstable' does not put the monitoring target pid when fvaddr ops is used. This commit fixes it to put pid properly. Andrew, please merge this into the 'mm-unstable' commit ("mm/damon/sysfs: support fixed virtual address ranges monitoring"). Fixes: c83136469313 ("mm/damon/sysfs: support fixed virtual address ranges monitoring") Signed-off-by: SeongJae Park --- mm/damon/sysfs.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c index 767ab8c33e4d..f753bb405101 100644 --- a/mm/damon/sysfs.c +++ b/mm/damon/sysfs.c @@ -2086,7 +2086,8 @@ static void damon_sysfs_destroy_targets(struct damon_ctx *ctx) struct damon_target *t, *next; damon_for_each_target_safe(t, next, ctx) { - if (ctx->ops.id == DAMON_OPS_VADDR) + if (ctx->ops.id == DAMON_OPS_VADDR || + ctx->ops.id == DAMON_OPS_FVADDR) put_pid(t->pid); damon_destroy_target(t); } @@ -2204,7 +2205,7 @@ static void damon_sysfs_before_terminate(struct damon_ctx *ctx) { struct damon_target *t, *next; - if (ctx->ops.id != DAMON_OPS_VADDR) + if (ctx->ops.id != DAMON_OPS_VADDR && ctx->ops.id != DAMON_OPS_FVADDR) return; mutex_lock(&ctx->kdamond_lock);