From patchwork Wed May 4 16:19:25 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajay Singh X-Patchwork-Id: 12838149 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91CF1C433EF for ; Wed, 4 May 2022 16:19:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353101AbiEDQXG (ORCPT ); Wed, 4 May 2022 12:23:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56556 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236143AbiEDQXF (ORCPT ); Wed, 4 May 2022 12:23:05 -0400 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 21B0746648 for ; Wed, 4 May 2022 09:19:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1651681167; x=1683217167; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=4GMr5UEP8JMEPnvsInnkmcjGZUWA8jXiDyzuUYkrArY=; b=wLg767zF4fP5UqKOd70lV5+K+SoYyizLEU4L5jxBsTqQJKE4EdvqDE6+ WSsaJQfgB6rQfRGvLzdzjAI0FH3rXEpMOP8spb9Z0XXolpozxv5F/RGNS NEdLTNqDSzmYlMCYgvAqH0PCQ1iEqb90IWXDCQvZRR5tLxubdwmpRpA+H rZiDuQl5qt/JGkuyoycb0kMwgeutoKgYKvmQQp6z+u9bngnCWfuZGnpF0 x4hBdRc/5CVGU5raE2NuQ3MiF/1mGyPJcszF0t/QTjkAaFYi06L1nXI64 VHMMzTu652SoLCThhbfXcRnxw/grUzXMcQXxtF66yS4+8Lc0Xdcy5K7C1 Q==; X-IronPort-AV: E=Sophos;i="5.91,198,1647327600"; d="scan'208";a="162723811" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa3.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 04 May 2022 09:19:27 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Wed, 4 May 2022 09:19:27 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17 via Frontend Transport; Wed, 4 May 2022 09:19:27 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jjr0geQgG/SvVaDHU3Kh0hBv+Pia+vUKgTqGdiZRfhapNmtgJ/SuM5MSjr+ywhU+IpMHxRVtcrGCigZ+GA3wThW5uA+Zw5KyGkXD8iMFWNRAexNwPiYtDwq5vwOmXcLKV8kUyXM4vy6Mjgd6VkI56qiX1MNWjRewv1Y4arzBBeypz95Phr0cPD+xfL9AVjH7kH2Z9fiVS66ANN782pScnQANeeRwKfJH7IcDdXi5yWZKwD1bHur6A7O3A1PxS058mkP6KWQTOr5byGcMd+mItC+XYuX+8yzq4CIEOI5SceaeXicXkUQiuzm6vK7OeNYDxA8osaq5/94Cq/2oZBQZhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rF9wsDt6+WbWExWzA8254CFXVMbueQpHgGgJTMUT7JM=; b=Pre8CRJF7aq8p36ccbTjDBD7csc8iT1KRWFPbH2yMLNTVoSiu8k4JCiXjTDO+jiaT69KBnAIfrFe8pjZAN703bt/pzoar16J9Ieecm4mHYVXTrPt85af5XOki/ofp9t8moKttWMZn31Biz0Nr+IE385+Yq8VjuFigg1BQ9f/zS/T/HQNJuCL6wTuRd96Gi/OZmu3LR90kjvMQ+IcSFvsbVHTpR3uqDd7BFNLnE422eKNHgf0W11geUH2F5dnFvjhEx8fkoWGBCqxGiU2HVOyYh0LMGP+sLn6HFxWWPqk8DzwFXua/GNQPrpBRbC13xXPXfF7LpNuLqZFHkRqY9XoZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector2-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rF9wsDt6+WbWExWzA8254CFXVMbueQpHgGgJTMUT7JM=; b=GH/JJ9ueiaxBL0K5/MUQ39aTS4FovMr5xjFOxAFdn5EdP7Z+UyJs9enXiprF3rNxEdAdD1EXBykJdKoprTsbCHvZMfocn1B/j2AuUA85d+906OXJwAsWPcI5RcOWXS3FE+wSaS70HIof65JEwi37hOxaStJj3WHYt2wgdGKRim0= Received: from PH0PR11MB5176.namprd11.prod.outlook.com (2603:10b6:510:3f::5) by BN0PR11MB5710.namprd11.prod.outlook.com (2603:10b6:408:14a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Wed, 4 May 2022 16:19:25 +0000 Received: from PH0PR11MB5176.namprd11.prod.outlook.com ([fe80::d0fc:845b:ce0b:11fa]) by PH0PR11MB5176.namprd11.prod.outlook.com ([fe80::d0fc:845b:ce0b:11fa%7]) with mapi id 15.20.5206.026; Wed, 4 May 2022 16:19:25 +0000 From: To: CC: , , Subject: [PATCH 1/5] wilc1000: increase firmware version array size Thread-Topic: [PATCH 1/5] wilc1000: increase firmware version array size Thread-Index: AQHYX9K4wsanpHFvcEi1AQZILSkwXw== Date: Wed, 4 May 2022 16:19:25 +0000 Message-ID: <20220504161924.2146601-1-ajay.kathat@microchip.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.25.1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microchip.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8fcd3b3d-28cb-48f4-9450-08da2de9db16 x-ms-traffictypediagnostic: BN0PR11MB5710:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: NM2fhqKxcSWl6jeBHxH14Grre8Cqgq1CJdzO+7dNB8N/H8iyOHe70jSewu2mUdcoEeYGvzeFDGBGwFSj8TtP4rUd9+TdNXyPI1cxPJz4XzkeWj9sNNlAtG4gYdy7UtvaF98Pp/Q2GHzhwLd6VsY8TwJslcYDj7i5DvcvC3GbivceqAqq3CpUQrOzzHG97vFXn2egvQPImr3ZV/PWvGOo9IMOmcLlZXj8HT1WlCnX88rReMDtISsYbdJKie8cfowNVwjZjjK8tVgZT+EqIxa4LOxBpiY9bgxXvJXr4H7NbT9RxgrH88fVrCLFYqV3yV12EpFLRt06jXXiOU9mi07oBgCqyB8YBSFbjrP37mWVl7H5TJt1t+6g51r4PFyrbDhfZ0EkuQUJitg3OPMaatj//TxXumE+UuXj/maUdBbATYwSi+mbeRQ/H8nCI4qqL/3lB8Ntl4HXdQZJPNuRQdwPeba4TSGHx3payXXtV2LHIQgmZ6fQ3Z98/vZA6xI6ui9Er8TubxpgdGJzxddV4TFnrLbkRqChvjBtJB5lphimiRH68Tto0Dwtvu/QgJnEQsfKYjxo4upMWJp18/dv1ts125Xk261ud9huav7N7rqszmbZOT905HfGTYerL/J+X2xuvx8MuQQjRXioriRRNYX/fL47ImOqeVAYtIbYrF/Vsw2UnT9xaQaTbnHk5M73YzCXbZcbKtAlqFWR54JV+CyyvQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5176.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(36756003)(107886003)(508600001)(83380400001)(316002)(66946007)(6916009)(122000001)(76116006)(8936002)(54906003)(1076003)(2616005)(5660300002)(186003)(86362001)(6486002)(2906002)(71200400001)(8676002)(4326008)(66556008)(66476007)(64756008)(66446008)(26005)(91956017)(38070700005)(6506007)(6512007)(38100700002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?q?vZlhI6DoYrx7NSG7VHrn41C?= =?iso-8859-1?q?TVfopYEMlPuuGZkO2/ZlssC3zlcNAFXZI7InrfXN5RhRI24dx1UsUMr7Ds83?= =?iso-8859-1?q?a1shoY/MDVW2MXJSAT0FN4lxlznuPHcUhUCqYnkRCHPf+AfeN894keqMSZES?= =?iso-8859-1?q?gHpyUhhTtJEss/8+TuKRge4sXo93NbcCbUXwu3UfOj3VaS97Mku+8RWSKiT6?= =?iso-8859-1?q?ejyAO6LYpEqq95z7BgBpgZkafCpDsBISM/qDgNWYBMUNzqmlSrgIYyrWyn0U?= =?iso-8859-1?q?dr06k7GpQIBDP40NMgcxJLl59SpqpvZc9s7pZ7ZnJNxMKYP1q371cSZBs8er?= =?iso-8859-1?q?3kf2kF7sTcgZg2h+QnNplphQ792yTn/D14sTetZa3TlY0V7fsIu2PhJfyFYT?= =?iso-8859-1?q?uj2khjer62n3BLbBQr3/j5CgXpiM8pnbJMGyGJaDeC5aIeIjlMEpBCte64DK?= =?iso-8859-1?q?N0vWO2V34aMQ2cLvd4kePXrqmKOc3lAA0YIrSW5Wt83lGpId6nC+ph+1uvrK?= =?iso-8859-1?q?jmCQIziDfDAvdPNnEK0kfXKNDGmf/+aWbAOk01DDbWq00DYBd43HnTOecJmi?= =?iso-8859-1?q?RqAsuj7V2FRjD/bKkcGq/pW/ID6zEhWkxwrmvczqAEtlAoDXt6FawtS4qcqr?= =?iso-8859-1?q?fyFCmOLwCTMmZ2jyUrOstTnu+jW9ybeBZNKw72IPel1zed1Yi85sNF/IV0/I?= =?iso-8859-1?q?siDf70o/bbJ8/mOU2bATTEB1DjDqDTxDmpBAW5/n7qjCak3EAAEoXUkopbiy?= =?iso-8859-1?q?K4HRyDpW5kQpFbn9dLFQFYWyi760l6OacF8rTexgjnss5LlFxdUYSUGmF6DT?= =?iso-8859-1?q?wTBV2+QjWTtRY9FDtAcLQ/OtbIyyyLuvsm+DX4XKTWz5sg2dJp7v9uXNyCDn?= =?iso-8859-1?q?D78Cikb3YH1IT2UqScJj0G8GkInSpmUHZtTaYC3fayx96fhX/zXYegf7seVY?= =?iso-8859-1?q?E7hyb6TaVMp/57aj+H8+iBmZiN3cjXs3xSagArJjBXDzVXhkn7x2DgUrVOsR?= =?iso-8859-1?q?dqP+3ZqHWxgCBcWZCKf0VajaBlFAtNQ92fZnW/9mEpeyOwfzED68407o7Btn?= =?iso-8859-1?q?wQmy37ttOC1WbMJvus+8OtXrPQBJinXXF3VxykU22ST2vQlbNU6GZGhNxdbk?= =?iso-8859-1?q?2vpisQSPseQPcCC8ebBAnZgt7kAPnIjYjyXZCXCyDAV2CmQ3zAp7d0FwHbL6?= =?iso-8859-1?q?c7u7omU96fXwP0duAy/NzYI7owRF8JzaoKbcEbwBhuQzV9g1xqqHpXtYjmFt?= =?iso-8859-1?q?JczqC70RsGR+vOKrmvEVTJ1PUwGvkYrgtbS89XDK4lahjp5kFVhUplvzdHYM?= =?iso-8859-1?q?MQ0O5sddN4/OKxb9miLcwsqROkePTGP5cghI2N3ImGiyicMAbkfa8QyaYjPC?= =?iso-8859-1?q?QIQuxtI+kUMHd402vxtOBi9qOQUajVh5FJ+YsXXn6xOydQkax5Iwe0KilMbY?= =?iso-8859-1?q?B+mcClyQEL+Mku1I+7Ba6Z4qNXEEJIX2ZHWMvePDjaBbSbbLO5cSuzZfGhUX?= =?iso-8859-1?q?3D7J7usNuopV/eu2yeJj1njKqr5OAn+Mox0+W3p8DRbOI0o6EUQGo91EDTzS?= =?iso-8859-1?q?21WJJboqVd4/Tj56AevrqwV1lSxMSehzdj1FjWXGvel9S7LQ9xNMMCpn3T0l?= =?iso-8859-1?q?I5CKXsTXDGYBfWUrV/VkqbBJ5HXXeasdHo3do+pGcLrFKrGHfaYaGKQafhx6?= =?iso-8859-1?q?bZ8vZLTJBiOleGnNO74SveKu9YhOJNNL0e7OAilt0YNaaYU9NhN5Mu5rhA7q?= =?iso-8859-1?q?kxYE3z6nAyD3HfWD4kyksUuKEQ/LxeCrzVaREAEg7RmdCsByGyypNuwCGbUO?= =?iso-8859-1?q?hVp7BjgUz4Y96dOY+xkAOHOGg0SuE?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5176.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8fcd3b3d-28cb-48f4-9450-08da2de9db16 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 May 2022 16:19:25.2354 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: lTJNEakACjcLEhxPCizKlOEyNX1wZ0tf9iWxNPT8+251l670son2guapUqe3QOJWyJkrP6dd+2lGFFrUfL3Yyg5tkvOWf3aqyFJhIRaHNTc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR11MB5710 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Ajay Singh Increase firmware version array size to hold complete version information. The firmware commit id(Build:) information is also part of the firmware version string. Firmware version format: WILC_WIFI_FW_REL_XX_XX Build: XXXXX e.g. WILC_WIFI_FW_REL_15_6 Build: 12804 Signed-off-by: Ajay Singh --- drivers/net/wireless/microchip/wilc1000/netdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/microchip/wilc1000/netdev.c b/drivers/net/wireless/microchip/wilc1000/netdev.c index 643bddaae32a..3c292e3464c2 100644 --- a/drivers/net/wireless/microchip/wilc1000/netdev.c +++ b/drivers/net/wireless/microchip/wilc1000/netdev.c @@ -14,6 +14,7 @@ #include "wlan_cfg.h" #define WILC_MULTICAST_TABLE_SIZE 8 +#define WILC_MAX_FW_VERSION_STR_SIZE 50 /* latest API version supported */ #define WILC1000_API_VER 1 @@ -522,7 +523,7 @@ static int wilc_wlan_initialize(struct net_device *dev, struct wilc_vif *vif) if (wilc_wlan_cfg_get(vif, 1, WID_FIRMWARE_VERSION, 1, 0)) { int size; - char firmware_ver[20]; + char firmware_ver[WILC_MAX_FW_VERSION_STR_SIZE]; size = wilc_wlan_cfg_get_val(wl, WID_FIRMWARE_VERSION, firmware_ver, From patchwork Wed May 4 16:19:25 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajay Singh X-Patchwork-Id: 12838150 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A6A1C433F5 for ; Wed, 4 May 2022 16:19:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353288AbiEDQXH (ORCPT ); Wed, 4 May 2022 12:23:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353205AbiEDQXG (ORCPT ); Wed, 4 May 2022 12:23:06 -0400 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3FC524667A for ; Wed, 4 May 2022 09:19:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1651681170; x=1683217170; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=nIgCtjA3T/woosBzj+h8Jo8vfh+HiCIkzPYBhLX4RAw=; b=HmuhlUoq6Pir2NnG72/HHItP6HUn4jdX7glCiEnwGsfkSDIOoo9g1kx1 nPGr7LqQwIfKlnTikBzNBUag7Tg0V3TEq9B14Qmk8VkJtBn5zwHxuO3jj ptDrb4PgR1BEZNQY2r1JO1SBxFk95eobzWpnutA4PAix/XegARmq0zL/e rZ7j5h07/tbkI8WBuX1LLs9uhM0nkombB8c95icKE+S5MtdopANi02skr 9RtklkQHVv59Xfk/JDuxGaWUqoJRd1se0OCkT2//JiKLry4xiRmu9OKrw Vv8kxEI8PE4ptEOJXy5LNqHAkdMBuJOv1MehDXlTU91223LKPsYCg6l5n w==; X-IronPort-AV: E=Sophos;i="5.91,198,1647327600"; d="scan'208";a="162723814" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa3.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 04 May 2022 09:19:27 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Wed, 4 May 2022 09:19:27 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17 via Frontend Transport; Wed, 4 May 2022 09:19:27 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nqcoee7vqm56fvsI4ufjAPgimXXwqYpUHB+GA/ngRZu//Lyd0qu1S8FrND7KSCAIdKnBS1k0Euwr1OC8wBNr0iaTPo57Hf3UR9PqkcsLvIc0RE/Oh6cak0QYGw2vX5o+SKWr37fjEeVKn0ohWnp3Um/XAU/eJvIqRouOC0OKWOxFvdziUv+K8Qwr8gWhjaK7Hoc/gAvQRA34B6DUmtIGWNcnYYkYm0KcnrG1i6qXdZ9/2JddMGP3gm8DqCOzyzditJqIJlj00PAgf1gZeZhjQgXK7zkkgTWCIIwu9s/DG6NnbLPwqnZUsEhCdqyWmQLgUvtRpEDIObg9yRHJSEDZjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mDatDKp90FJsrCHfnlS/I+Olx+O3XfyjayatXTDY/ko=; b=MbB0oKocV8TEdcw1eR2j9SmCRlP0kE3EzCn729yj03GGhiQsFvdqETIVfafblczqTXjFURp4fB4gs5QODTGLilDzsxdaVw0eco3gFoQBRzCTVbTYyTcwORHSByBOJZcT21FCLn2oNU9quHosaIJccRaqTKEK3Y7m1UOAsA+0yIy7ydrCGfOhHJMs62Ru9VYqFOPxjfLRCQjPnliH3HcRgjVmveu1URlP47iP+zPN8vkndLgHNgquW3T7tNbLJ3XI71uIgPAa9nXQLwoItNBy5sucHUxLUeN2eQU7riPvF72MuWcGIWtjU1C646xlyjLI2kdwLj3RCU7rW3gqFZ0xxg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector2-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mDatDKp90FJsrCHfnlS/I+Olx+O3XfyjayatXTDY/ko=; b=Z/VizwtZZNvRxAjoKWr3dhyBSOh6ZRRcrhlhO3aA/w1lF2o0PfW9HZvZyJq7FZG9qmaHU/vrxy9KikYgjDGd+F0mjUmAA4tRflPSFecxeWV7fjNCC4NtBqnm6AlVqBN2Tt8PqTFLJpEZrkEhMO+SVEx69yE9aQXq8VJ2FCVQ2Cw= Received: from PH0PR11MB5176.namprd11.prod.outlook.com (2603:10b6:510:3f::5) by BN0PR11MB5710.namprd11.prod.outlook.com (2603:10b6:408:14a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Wed, 4 May 2022 16:19:26 +0000 Received: from PH0PR11MB5176.namprd11.prod.outlook.com ([fe80::d0fc:845b:ce0b:11fa]) by PH0PR11MB5176.namprd11.prod.outlook.com ([fe80::d0fc:845b:ce0b:11fa%7]) with mapi id 15.20.5206.026; Wed, 4 May 2022 16:19:25 +0000 From: To: CC: , , Subject: [PATCH 2/5] wilc1000: use fixed function base register value to access SDIO_FBR_ENABLE_CSA Thread-Topic: [PATCH 2/5] wilc1000: use fixed function base register value to access SDIO_FBR_ENABLE_CSA Thread-Index: AQHYX9K5c0qYSVlIhESRqTGCYnkStA== Date: Wed, 4 May 2022 16:19:25 +0000 Message-ID: <20220504161924.2146601-2-ajay.kathat@microchip.com> References: <20220504161924.2146601-1-ajay.kathat@microchip.com> In-Reply-To: <20220504161924.2146601-1-ajay.kathat@microchip.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.25.1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microchip.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e19441db-f3fb-4e44-766b-08da2de9db7f x-ms-traffictypediagnostic: BN0PR11MB5710:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ooaxHoVFlxJvdsBc27zFbOl25i6E1trBMn6idMCCrg+CZ9OACR1Gxxq8Oi3qFy39Y1POzWCnoNPeBn8lYnbVUnlDCbBH7XqRCoZyYIB0xeZQfKaK2aoM5bSfprympQdSALhj8IEYzqCZSUpHsoafwJfVsr8cu7/1zJD4M3Y0PxCHTvjWSu+EPmGSplBvvClmwEaJpVT1SxxA+vkn/FIO/QNhEEc7+DOpr9E17avv3fpfq1qlV3+IyVNWE6pUWCh+GAEII7JE5pLsJOF9aLrN8e6krWWk1Zlmg2UYhSeutHazUSGusaaWc1szoQ0Bc4wJbccz6hXf8NnQdlhQTqnHnrF8plM9qTzMlISkfaMF2og9C8dQiByzLKBPjhNEDci0yQgeU01Xc/mohVUbbrF0Qb9zsfhb55GF46qHbzyFhcz62oDXvXAB+l5BTAKfXeyHrqqXWdETIwTDdjtDc8kxamicOakLJT+26JmDpm4nBmkoZrVk20qjB28RoRgZEuq1xAvFekTbWqvflECMllM8yJzw4bRjBY8a/XeZJgjLfUUVEgxkMq/d7kgATzL8/2Dgc2hirHzsuiwDRkahBnaVDSR40kwnGBQnTakC95umrOyzSV4NJsW5WsACk+QqQ1yZAf/OUZxVgKqau/xhwAJ0T2EEW/aPCq9Q7FLmJCL1dBtDyzizdjWOn+t1XLbsy3CA4lGogRyvevZzDrSGsuWvhA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5176.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(36756003)(107886003)(508600001)(83380400001)(316002)(66946007)(6916009)(122000001)(76116006)(8936002)(54906003)(1076003)(2616005)(4744005)(5660300002)(186003)(86362001)(6486002)(2906002)(71200400001)(8676002)(4326008)(66556008)(66476007)(64756008)(66446008)(26005)(91956017)(38070700005)(6506007)(6512007)(38100700002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?q?r2qM4t6ZzGQItAUlzQ+TKjk?= =?iso-8859-1?q?rzHJo7OjTkK34umZwP8DyWeydYH/3YjhKo/LRxZJanQEBrp7ZlrJylqKGMdX?= =?iso-8859-1?q?FdqsI2RRkLW4z+p75E5AaprlvjuEyHu1d/ZWJBmUE9VE6Q0SyzoZRULWtkHs?= =?iso-8859-1?q?173f9LzBzj6c1mysAT0XSMGsMAaCK1/YpQI8plDuhgkZyqqxW/hZJBoEPVcQ?= =?iso-8859-1?q?txuDtnvWhDxOjHvyL5aWYyNOL9NW7D6gegTsyRGoc5YsKuXlTKrRETkUGnCV?= =?iso-8859-1?q?4S3LRusenUvP2tZt6fqYChgf8M0PJwghVTNuuF/DJ3MHepAOIgVMriw3YAjz?= =?iso-8859-1?q?cvW/MY+AqsdnukjK2VLb7DZNhcxdUePWV4P0avSujXzJhvyfxD8uSzV+LvUP?= =?iso-8859-1?q?jKZV+iGo+D/n9/PUE+B6WYMLhcNjZ2klrIrLsDUyDLBDGlfSCEPNxrhpNxPH?= =?iso-8859-1?q?76luHt7AsHBW/2RMB/ILlf3392k3h1u3WV+Qk5KWt0znBsA6JChZG8CsMULk?= =?iso-8859-1?q?3B2gJWZJUYX52A/1on7I7cQHvxhE1fV7kItaMbmjIfmffTtXnPR3vFWd1d6Z?= =?iso-8859-1?q?qQoz6EVKwsTuS4FGczjE+GjvfX+j1O+8RJEXG7I0PVCt07DsWR3iyVHelbeJ?= =?iso-8859-1?q?nIUqmiqYJDibR1rLqseWO0Nu23GU+H/KazNfIvjW+U801IcWZfyjY8kDBK6F?= =?iso-8859-1?q?HLcHJtRBQ9z8RBMjHFKxDrarfsL7Liq/aHC9gW4aRJsFds/iRABBGpVU/rI+?= =?iso-8859-1?q?oIoblUEdIbi2m5RM6ien0BnE+7yAv+/CDYbH5bbbjHz7ZQzv2JpR8FpO/G/e?= =?iso-8859-1?q?Nc48gkHCIfyBQNA5xHu+ia5Z1Ch0hfAVJvklUe0NaX1XnPlprbHwK4T9uXyL?= =?iso-8859-1?q?PK/wRIqCXLX7bwyV8UasPyR4vJodXeYLK4nIgv9Uo4oaRXG3LMIAItcI/+LI?= =?iso-8859-1?q?8mhGDYSDNfTm3VN+XG62uPtI8HTKwE3f8wiG+lNS1/gbACKGapxIQnWBRRtZ?= =?iso-8859-1?q?sRINo3HQkFd1eZ5MYt3pP4Ael+p4AyOeKC07L59odA1DCMDQa+UTufxClvRX?= =?iso-8859-1?q?ZNiirVYz6dWdqbx5Gfqa+x4+UcDfyZ7vhT2HPLMYTdCG10/rO+KEeP/9Sh8V?= =?iso-8859-1?q?V3HD7h5s8+TL0CZtr3m6esdPwBBX2WK4so2IzQaYtKhyt5mUPkAiZvI1CkYV?= =?iso-8859-1?q?OZf8KMiFFq9kTtcAIgXpHkkI4O51Ws0/+n5UrPo09r12nvCTD4uysv5ARPwj?= =?iso-8859-1?q?/PuYNXrtTNo0nHaN3BRDont4LnZ4xT342hXWdutvBgODIMJMocuYTxK/ghj5?= =?iso-8859-1?q?gJs8FcqARPa4WGDiJI/rxwg/tegwp4hPdwCCEhNauzeH506bMdihtnO1H9Al?= =?iso-8859-1?q?TBHrUjk+qNbc7ub8nAmDcaKHJ/WcxgAzKMbyYJ64sWxNMffZOsASg8m/TVMi?= =?iso-8859-1?q?0SkbTztOkpXCoMnU8lmM58zftm8QOLGxnMxN98+2zI5mp+zjfodVqmHBFWhh?= =?iso-8859-1?q?ElPAGGpDZv1FPFGoH2XFP+zwI8+NFIsVyAE5xrEujxOgYJPFyV8JZ4f6nPhl?= =?iso-8859-1?q?UFakeljKM7nAPpJwRMx9aRohsIi4wZBQkdv61bOeMy6L90LysV3U94R9sCjB?= =?iso-8859-1?q?m4RWq9+NS+RsNBVvXBp+3hP8FG9orew0nkLq53vVguhfntF++I606Aq7uGgf?= =?iso-8859-1?q?u0DuU7Rs9n4lPnEcogGodt6I2lFuDxpo+NXp4xVp0NRAqTLuYg4wItZNmccC?= =?iso-8859-1?q?0vKZ5oXDg8djffx78/9eTV6uDZMDZXGinD5mpUq8cKLqF+fvwgqXUQFPvP6w?= =?iso-8859-1?q?gtMBHtTeeEU2sHPTPk7yDqVNgwQXY?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5176.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e19441db-f3fb-4e44-766b-08da2de9db7f X-MS-Exchange-CrossTenant-originalarrivaltime: 04 May 2022 16:19:25.9071 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3hGiwjTaJg996dSbVqWBPjkJANvm85w/Xz+odSt5ZtKd9qbJdmiACFHMxZxtU/fT+FgmfDCnVq3LI+Pq7ct7XevZkFOBC4FhaCm2ocnm+9w= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR11MB5710 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Ajay Singh The function number was not correct(reset to 0) when host resumes from suspend state. Use hardcoded value in function base information register(FBR base address) to re-initialize correctly on host resume. Signed-off-by: Ajay Singh --- drivers/net/wireless/microchip/wilc1000/sdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/microchip/wilc1000/sdio.c b/drivers/net/wireless/microchip/wilc1000/sdio.c index ec595dbd8959..7962c11cfe84 100644 --- a/drivers/net/wireless/microchip/wilc1000/sdio.c +++ b/drivers/net/wireless/microchip/wilc1000/sdio.c @@ -598,7 +598,7 @@ static int wilc_sdio_init(struct wilc *wilc, bool resume) cmd.read_write = 1; cmd.function = 0; cmd.raw = 1; - cmd.address = SDIO_FBR_BASE(func->num); + cmd.address = SDIO_FBR_BASE(1); cmd.data = SDIO_FBR_ENABLE_CSA; ret = wilc_sdio_cmd52(wilc, &cmd); if (ret) { From patchwork Wed May 4 16:19:26 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajay Singh X-Patchwork-Id: 12838153 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE48BC433EF for ; Wed, 4 May 2022 16:20:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353337AbiEDQXM (ORCPT ); Wed, 4 May 2022 12:23:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353323AbiEDQXI (ORCPT ); Wed, 4 May 2022 12:23:08 -0400 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B39446678 for ; Wed, 4 May 2022 09:19:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1651681171; x=1683217171; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=j7XYIGoq/EbhVAslnZ42wQOI6Nh4xcjyUHiR/sOGxwU=; b=m73Q72FKBAFD1OmNUJPBYWKKR+Mvdc5XsZ7BGpW5PGyL+7tzXo6+1c/1 cJMuMu70lVP6WCap6nlx82umM5V2w3ZyDtNBytvHcIEsMNxCrsuAx8G/P thcrXjOFdU+hub9LNHK8Rd3fbLMV/Gq7bBQa9VEzhNIRUkTNmuYy8sWhQ 1HCSLVDt94ZDdIg1kBurfA/kCfmkcOF7ooC4rbAUTzB6ftEp3cef8C69M 2MZYV6UF+Z5GZBoHEQEMZ8eu/HHSWHiUh4cEXWxJXR75lVm9q0LtIDfG7 AUKOCHiM6DpQ3jIBfyvBrHkilQZRlVcpKywJlvDbp4oaVJ/59EGw1PNiI A==; X-IronPort-AV: E=Sophos;i="5.91,198,1647327600"; d="scan'208";a="162723825" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa3.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 04 May 2022 09:19:30 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Wed, 4 May 2022 09:19:30 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17 via Frontend Transport; Wed, 4 May 2022 09:19:29 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ifYMKlw/JaIYF9qXiuPS01dAJM/u9VUrEwAvql5e955e41ZRMOoV4F6eU5y3pPavpceQpTljKDa5Hx6tRBqsylmYKJ7U4pKM7PQ+i15kxGuCvkvpI+4Tm7MfDoR0qQoDwjlB/d2sldVXewDDb93M3TP7yLv0atP8HOTKTxyxMTxnoIMLB3eu0qn6apY3fU45+pcqlcZ+PQ4dIP3FAl6oKobc4fGsDoa5S89Kx2GgSRK2d/DtlMkt+qNiS99Db1TDa6nMzsOCdXFXdYLtWVmwE1mZmtO9F9ip7jjHmv3GbbZUFRt6TnPlRj7HJTdIFDe/ox52Qeq9s7eAnAjUi8IBbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8F4fEAvFW1CPAsTBXRYfeeddmOyJzm9u3ZfHMEaWFFc=; b=Ds7zAWB5lpvdeTbdXBdiW6EySlI+2K2n+RB3zPcMG7XnOw/DOC/MQjQsIgrMx7bXkrAQ2aLIWcM+jSpwUrki03vMqGWCjkZO4bW2qLM1vpT2J7BPNHB2aq1nOhqo6LIikoZT27v3PVyeJ0RjCkPJaKkUoyjj1UYlWRIhPO80hhrurvYsFVFVfgkEZ4y1PmABiGpLjfITdb5c51XqoYinS+L2aPm0nMyYgIHniXguCreeQcFtExDNt6KpbZKIPEBeRlXlfsVvvJmh//Qndpo13xxFQyzmVjGjuPfvaZHWljmjGe3KFARyX2owv6Blke1itx54sDhkX+tWLnkMKCyrrw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector2-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8F4fEAvFW1CPAsTBXRYfeeddmOyJzm9u3ZfHMEaWFFc=; b=a79o/drEFFycAixJSTdPM0QQJixXpB0q0rz0rEUNfwDQK1VcUhFWv7bbnCp6VGzjP0zvXrn30qyR+CZhJyjZlGa4gaK4Q9a4EyW3PkHEiv/y6Y7/ef9FJ7aGPQik7me7F/A64EfB/Btlgw/wyqFzp/icREIisQTIYh2QYu1RdrU= Received: from PH0PR11MB5176.namprd11.prod.outlook.com (2603:10b6:510:3f::5) by SJ0PR11MB5597.namprd11.prod.outlook.com (2603:10b6:a03:300::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Wed, 4 May 2022 16:19:26 +0000 Received: from PH0PR11MB5176.namprd11.prod.outlook.com ([fe80::d0fc:845b:ce0b:11fa]) by PH0PR11MB5176.namprd11.prod.outlook.com ([fe80::d0fc:845b:ce0b:11fa%7]) with mapi id 15.20.5206.026; Wed, 4 May 2022 16:19:26 +0000 From: To: CC: , , Subject: [PATCH 3/5] wilc1000: fix crash observed in AP mode with cfg80211_register_netdevice() Thread-Topic: [PATCH 3/5] wilc1000: fix crash observed in AP mode with cfg80211_register_netdevice() Thread-Index: AQHYX9K5kogwjz9cOUmXVoMCp0LCgw== Date: Wed, 4 May 2022 16:19:26 +0000 Message-ID: <20220504161924.2146601-3-ajay.kathat@microchip.com> References: <20220504161924.2146601-1-ajay.kathat@microchip.com> In-Reply-To: <20220504161924.2146601-1-ajay.kathat@microchip.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.25.1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microchip.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9cd09fed-f918-49fc-2004-08da2de9dbce x-ms-traffictypediagnostic: SJ0PR11MB5597:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6TwySxJg1KTCSl7S10N4H0K1i/SdBaJTpa7MnHBObTmXt2DT02Bdm1yeTKNeIKT24g1nV4RxkQAOkkiHIKhxbgW9OHurkn3zqxxl84LbYh1xzY0lWDAaFXK+xswBsjsMDUumFo6Y1mBxcV8VOdsNG2KZTwqOqtAnddQGigHTMvNS0hkxefo9UKAvZ9Id6y3jIXpIYGi2r5Ref0xl9sntqquVFBAAbaMAwQploHZc0MGW6/fjD7BDoSRlkMcmjx5nCADvWzZnmu5nLvPzNbo5jg3EvWkEM7uDh0ASnk+hlhPec1SOwwGlLVeCG2kmm1N+7qoxYbdMemr44Uh7OP3kWeEAnThCqA096hv834qcVhERIYcYxIKglZ1O/oiyB+3mLGuMpoZteQvQyHko+QIaoYCT0jxp9UtbiIHNcoEmdOtbvoyycdLydBgkH/UBOxQMVfTyTMDmyZEnhZdqt0CKcvysOt3we5CA/+ocXlTB2OZVknfQl9rjYFpywTlxvAB9hyTe2uLloPpG1RHa3UzlRLxl4U5JGXfwfPd5mwrwFPGSDcmV86Dbrtc/6zBxpQeJTrva8xfl9w5xb9Hd5GHw0oW1zFzqcL1KST9489g1esfr9IHTMo48Zf3VnZDCgsco8EGU1wg0LXgYUCdTvL6oRMywzNO1sSgg9vk7qHLMlv7ojZ0GqMlSACRXaZPa9SRxRPkLEXT8Q3vdt0BdqgPtMQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5176.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(36756003)(38070700005)(38100700002)(6486002)(122000001)(2906002)(8936002)(6506007)(508600001)(1076003)(4326008)(86362001)(6916009)(186003)(6512007)(26005)(71200400001)(2616005)(54906003)(5660300002)(316002)(91956017)(107886003)(8676002)(83380400001)(64756008)(76116006)(66556008)(66476007)(66446008)(66946007);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?q?Z12x0fwDKshR2y7608t7GY1?= =?iso-8859-1?q?CpUjRTH1JGrt6hxMmRdBFwWVA2M18kyumBdyGQAroodd8cwA5FwXpXlJV/pM?= =?iso-8859-1?q?Toj/9pTCIussybNYS0ULxptKWX7YUDP/yIVCtMZgKo4esyVEPWhhNm5lqQPA?= =?iso-8859-1?q?S3bL6M3F2r+V8fVpGZQ1CR5TYUz6lE8gb3+vL3Xjk7uETpT33qzdg7vG4WA2?= =?iso-8859-1?q?Xr54se6K++PungsNqXHrQnOeSVu3Hjc6r3yE6+60Us2eAUflBUjrv7ScaKa2?= =?iso-8859-1?q?MpVbBUGUxqer82OrrQLJN4xXbnrL7he40n4/FKxTR2nPfMFKXfm4kq07yquV?= =?iso-8859-1?q?a8ownQXgSICuBIIk2bgWrTQ1cso1tbt6RcGLbOTcCIXWsrPM/L58evJU+7fg?= =?iso-8859-1?q?zA3MBVW23rDfKB++uI93psq8D0waD170RYBbyfBff4KFJMDPAz+pl3CJjG0s?= =?iso-8859-1?q?X3a0oBa7ZaiMAGnQ+U89euH2gJ8qITFL8yPd9IcsV3Tk2b0u6UORNpsxNZpq?= =?iso-8859-1?q?8DsDBvXy8GUCXSgYAJQWr5qLOv94Gcpgy40pn/++7azoOF1HCGbj0YX/E9AB?= =?iso-8859-1?q?NYFC0m8S0GaDI6g4VBhR++eqiOKvT3HbH5Vaj8jtfh7ViO8w/8I0Ke0n+/2A?= =?iso-8859-1?q?TO92IkjMAOGNItKECMyBBx30enxwstlAumz/lkvRpevq7+Nj9lHLb3HS9e/d?= =?iso-8859-1?q?WRBqq4rSj/gcgmZrJYlAbezPdVOVddPVQ9alio/zOzQJebkQEyFgy0k1HA6a?= =?iso-8859-1?q?ZyrVfVK7DKuqAi48no3vfikBknpdkN8JYhZqiRsu9nhQnINUe9bZUas+rgsa?= =?iso-8859-1?q?bpqB2uFBufyKJ5h9bS55xcExn+rYxMpqySSyIEz7a6zSI57Tc9wmPQuC79vM?= =?iso-8859-1?q?PYSHeMjiqIfHuKfU8MMpSiumC3xz7LuyMC3R4vLYf3jC1WOHW8g1qa47rtAY?= =?iso-8859-1?q?1DfXIZnCm0D7r586PagJjzyH5gLchl4oiOBa00MhnBjQ/LxJAxOHdQ92wKeg?= =?iso-8859-1?q?Io5FumWoz/06M8ShfmuuJMUWri/qaexvByeQSTNHhKXvP1YUYKzckbi4iSW7?= =?iso-8859-1?q?U3HbGWlvgdsVQU+Dgx394m6BMcpXt2huMOiRjWHQ6uaM1pSRqlnLvYmuP2AZ?= =?iso-8859-1?q?BBMWhmqBL897kLx7kaLBWT7csZM5opWtARJGSsCqZF/emQo18cVeLX40U6ta?= =?iso-8859-1?q?nlxDcddwOxl+AGwgCr6X4sCEzWIlwE3qR/fpbfcxEq45mhfFlOrACTZPfdif?= =?iso-8859-1?q?xXlVxBkp+GXddN6VVpeQWlt0piD62/DkXv7o3AmAen8a2KC8Dm+aC4z6TPEm?= =?iso-8859-1?q?Kq1KD9yw0VmrhhYFIR2AltmWSPcrxkSBLt474zyPiuRMpKM8eQCEy9qNaJBn?= =?iso-8859-1?q?1YJusKDcypYKYWt8tOgrHwUntsOTOfzr60631Kvq9SUzkFtu8orOUxq9sFOk?= =?iso-8859-1?q?UJYR1+XLBTbvnNjW6e9+teYoLGUGwXi84wOOnE3+JEbMqQBklrOh7TRHwrVu?= =?iso-8859-1?q?mr8pVEa7hvG9KIjGE7bxNbQFyu/sx/JWWPHjpMjsnyUMKlIVZka/GhjGflMp?= =?iso-8859-1?q?38HxC//mMOeefj3wkoNVSp+StjmaCosAs8gIxlc0Mc+NFqn+giAXrFZLKVHZ?= =?iso-8859-1?q?hOWvE+koN1Ex5ds9NP68xrB52y7afXuO1tOTkYtmWD8wI2e29MjFz4uPiJRV?= =?iso-8859-1?q?XSujDPPlTbR2XhmKJvIZvKdL5aqhwtGbLJrXn3iwJze6avYu6J90EHulbZNf?= =?iso-8859-1?q?9WLU+Cw1m4qGc6ic1FOtZ4s5meqZBSjBNr47zea7sLAIUc9KW/NZGqQXggRE?= =?iso-8859-1?q?eO8ADJEeVkJIQww01TJreUAoh/ayk?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5176.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9cd09fed-f918-49fc-2004-08da2de9dbce X-MS-Exchange-CrossTenant-originalarrivaltime: 04 May 2022 16:19:26.4382 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: lGjSsG9H1x6dq7x1NEXir5wL7WUQxiENHcI4vFcqJq8V0S+urqQQ6qLztFzixdojl3spxddZbxv01IRiGOQeJUEP1EiZL5jV9Yf/Ve8APlY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5597 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Ajay Singh Monitor(mon.) interface is used for handling the AP mode and 'ieee80211_ptr' reference is not getting set for it. Like earlier implementation, use register_netdevice() instead of cfg80211_register_netdevice() which expects valid 'ieee80211_ptr' reference to avoid the possible crash. Fixes: 2fe8ef106238 ("cfg80211: change netdev registration/unregistration semantics") Signed-off-by: Ajay Singh --- drivers/net/wireless/microchip/wilc1000/mon.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/microchip/wilc1000/mon.c b/drivers/net/wireless/microchip/wilc1000/mon.c index 6bd63934c2d8..b5a1b65c087c 100644 --- a/drivers/net/wireless/microchip/wilc1000/mon.c +++ b/drivers/net/wireless/microchip/wilc1000/mon.c @@ -233,7 +233,7 @@ struct net_device *wilc_wfi_init_mon_interface(struct wilc *wl, wl->monitor_dev->netdev_ops = &wilc_wfi_netdev_ops; wl->monitor_dev->needs_free_netdev = true; - if (cfg80211_register_netdevice(wl->monitor_dev)) { + if (register_netdevice(wl->monitor_dev)) { netdev_err(real_dev, "register_netdevice failed\n"); free_netdev(wl->monitor_dev); return NULL; @@ -251,7 +251,7 @@ void wilc_wfi_deinit_mon_interface(struct wilc *wl, bool rtnl_locked) return; if (rtnl_locked) - cfg80211_unregister_netdevice(wl->monitor_dev); + unregister_netdevice(wl->monitor_dev); else unregister_netdev(wl->monitor_dev); wl->monitor_dev = NULL; From patchwork Wed May 4 16:19:26 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajay Singh X-Patchwork-Id: 12838151 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 356F4C4332F for ; Wed, 4 May 2022 16:19:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353342AbiEDQXN (ORCPT ); Wed, 4 May 2022 12:23:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353016AbiEDQXI (ORCPT ); Wed, 4 May 2022 12:23:08 -0400 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5EA9F46B05 for ; Wed, 4 May 2022 09:19:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1651681172; x=1683217172; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=d2C90aY0w/W+UzoMzDtV2vEn7MCx1irTf5ttF97P61Q=; b=piCnBuiIHBf+nZcZxIKen2uivM2OHklA0KPMEdB4I8VClwf4lxIdty5W NfsqvsXnheJhIBagrhPSwcpApE5sjHMgXllXmahs+mJ7eGycAPbMFzhfV +eKVRS2Cmb4H2uXpXv3BqwzPG3UO72xlXNjyAl1qX0NenecpZW/GeXIUs sR4VCZBWypJJiMa3pN2YEgmZccNq3mqi0q2alWUp5BK9y51zzfOmLB/na liXQuV7ekuYQd1G2bIUiGF0SeXlHJHWH+hYQ/NcTly/w/w/BUHc+SuPMk 1Xze13VisICN4AG1u4HUtwzWdNeT3FdU12B7Q+fpSqNXrP20lTso9uSOe Q==; X-IronPort-AV: E=Sophos;i="5.91,198,1647327600"; d="scan'208";a="162723826" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa3.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 04 May 2022 09:19:30 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Wed, 4 May 2022 09:19:30 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17 via Frontend Transport; Wed, 4 May 2022 09:19:30 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ev4u81VpZrP8hrt152tfB74RBII4l7EMdJqipFXgGOytYdldOmKSRipmv6cyr1FVfPAVaV5KzEzMpDIQuHic83eFwOBiTYspZhmGuJLlvgAiLVqH/ePdkyzK7sHd1Uk2dUVhq6I3JbtAq00hxKXOl1hKdx8DI6V+SHrmhBdWZCPNd0PaJGWdPt0deYhrrQ9/2c6X9hUlPbm3rS11qKJtLsKHYdn7CmsgewwoWyGEQqdrrmOOGToWu0VSeeLEAWOp8LBUmD8ZChYJtMwpyvVzOlHKOwONlNTEFuW9THY2Fw2l73ozWZU9o+DCJnFivcZmkOM8nBuDTdFb7dJgV1MHtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GNiH4NbQJfXBfuvv3NqnmKNKjMfn9gwb1CLSdDhbNxo=; b=LNhyQjwZMzESx7Smhu6VXLvDLiIRvZ6Nf3IN7BtaA5B2XcZ/WWS9AbpFVr+OmnI9NGejL40dUZWcq0vjbw+9RBgG9YcteXX+hYb64MSkdW8WwwyM3kWfaFAtSQp1bld9JdLGgwHmIQHCJ+63j93LCgRQR8gvDJgnxpm8vrWVnePx5CJIFoYMXpDYhKM6XgeSufYns989lb2SfrO39oedQQ6pb8KIpBHp2zLlkpTinfiX5s4dNsVhS0KVz2W21zd15m9XzYMkPrXLv2VtKvUVZxq+h4ZkSdV3w+Bh7SBaR3U0qTs9ZRV6zpUPJyn0nMnmXy9f/fSg+r/2Zs0Ceq/DpA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector2-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GNiH4NbQJfXBfuvv3NqnmKNKjMfn9gwb1CLSdDhbNxo=; b=uDr/DJKw1/iyMmGFzYloztGBE+3mcB3Ykl/NiZxlfjjYqja/cIm5JQy+mtz+uYZ+xGgiQIARhHEVPgj7WQFILrQvltTQDMwK5LkATiE3AltDP5U220myHBWfwSy8+XahHIoNSlVS207EU0DzUuHSZjsTll8oKS4XqSO0weFSnhQ= Received: from PH0PR11MB5176.namprd11.prod.outlook.com (2603:10b6:510:3f::5) by SJ0PR11MB5597.namprd11.prod.outlook.com (2603:10b6:a03:300::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Wed, 4 May 2022 16:19:27 +0000 Received: from PH0PR11MB5176.namprd11.prod.outlook.com ([fe80::d0fc:845b:ce0b:11fa]) by PH0PR11MB5176.namprd11.prod.outlook.com ([fe80::d0fc:845b:ce0b:11fa%7]) with mapi id 15.20.5206.026; Wed, 4 May 2022 16:19:27 +0000 From: To: CC: , , Subject: [PATCH 4/5] wilc1000: use 'u64' datatype for cookie variable Thread-Topic: [PATCH 4/5] wilc1000: use 'u64' datatype for cookie variable Thread-Index: AQHYX9K54ujdhzQZz0uDjx7eRXX/jw== Date: Wed, 4 May 2022 16:19:26 +0000 Message-ID: <20220504161924.2146601-4-ajay.kathat@microchip.com> References: <20220504161924.2146601-1-ajay.kathat@microchip.com> In-Reply-To: <20220504161924.2146601-1-ajay.kathat@microchip.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.25.1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microchip.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4d1f54df-177b-4ab7-4c24-08da2de9dc2b x-ms-traffictypediagnostic: SJ0PR11MB5597:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: iMMucw775+uhua82LUN3OB27i2blz1ZOFHXZQpAkvf96PCtC4j9GyBktNtx6A7qVrLYVrXqQYIFqMbQZEJu7OPI7PGxm9GjAnoPHGIxc7EnmfRv+vrI3f32UfNd2d7fEQ4IaQiHPTCCUuRfS0rDsxBk2Sj4lY8N07Muk6JhO60AFimFC1la9R0qvbh2d4ptVbTQSZ+S5MDHECQPE5fq1KNKHITyxKTRmKoHmGD+46s6YkugwVe7JSVDvBMFTOabMXcuCe5lptmPkhYXK8LL1zH3eonmU9yaQ3bUVVI3HPjKOw7VcXQp9JBbeLaLlPX+R3G9H9TuwJv7koC4z0MJgfdxJXqHfaQr13e173qT/1IYPEqFGfOd0EF5d+UM9PpDLw5VZly9yYrw6AgbSNXEMOv9I+uz4T7NTOXxVMAbsmjfy7v0XpiWFMYdSTVakI13HB4vB9jHaqmFT1cQ+8IjBkU/9ax0se82x9LDxHcS2C5UUXHgiLEjA+CNm2HiFQkPCQ3QCqzA5KBkjD5q2oCQ80Ha0JKgfBz1EoPyYL4kx7PAaHHZPXJUZ7UPAtbNjOITRiAFO8b/DnGylm0FYVdf1KBv6wFmmZAG9VZhW/JqcchNatN3sxn+DhbmWPxREfkRMmb7D9P/4AtxyesaDrxYdFtKcGu9BRhmsym1mKu5Y2X3W81/IHI3mUiIPlwAynrk+lbOilUUIiJm9hbfKfLeW5Q== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5176.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(36756003)(38070700005)(38100700002)(6486002)(122000001)(4744005)(2906002)(8936002)(6506007)(508600001)(1076003)(4326008)(86362001)(6916009)(186003)(6512007)(26005)(71200400001)(2616005)(54906003)(5660300002)(316002)(91956017)(107886003)(8676002)(83380400001)(64756008)(76116006)(66556008)(66476007)(66446008)(66946007);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?q?B2bkmceXMc1YkMl8FIlBjyy?= =?iso-8859-1?q?2HEEsew0zWVgo1XI/EcG1XTe8mWbYUBdgi4S4AArexQ6txGJhrVvzZ3QFRcK?= =?iso-8859-1?q?7fCrkavf6DFn6e5V/QemP07dIuZLRqJU7XT2S2erf9Eiz/Yy9nxqS8VV1mvz?= =?iso-8859-1?q?vI1lhUN1XaHZSOHgWXo5vVOKLJyqIZGcnWgrwnvP2MbJsrwE6p1wjhvNlEOR?= =?iso-8859-1?q?eLWsrY/k4IBP6I9+2T43Q13NGqLbrSwXreo3APU45rfOctKAYRIBGt6EYkFA?= =?iso-8859-1?q?oMaqP1+Md6bAtM9er6KTI3oXtGtqo1rwiTnEc7/6ywwS1kwjyJwctZKVQpX8?= =?iso-8859-1?q?7dtMLgOtN1EFbmVPR7CsILHvr6AWVkZPiyFywrj6T67bcCAnQtbhYldCBQKP?= =?iso-8859-1?q?e30AgltzRMFJ3mH0dT0HF3xeFUKBa488E5tZmwNhJ1IpbuHYZTtZGzoLWWda?= =?iso-8859-1?q?2tXb7M6MU0SicHlokIOVRDLe8Ad/0psiqBRZ/z95o97KGAAfgEidzRBpHKLI?= =?iso-8859-1?q?+9isf8GHql80pfjdUIDSrDVqWbhJe3mz4w1/QMnzYYA8pnG/dh0kiTcL37iv?= =?iso-8859-1?q?F48B1284IPp3mzSA8F9+apoGKVWCx9+zbqe4QaX4aMSrAU3ALBVqnGV5xTxw?= =?iso-8859-1?q?cArFZ3Pi4LHYimlagKriIV/Sihq+Ne14mY8HqkX1xUUd+kXe4Qw9acZc0tbr?= =?iso-8859-1?q?YPGuLwZobW1fhS0xMJtS+KSmi/luFTaTzGyHUprWL2MFy+Wkp2JIoMxqt7DP?= =?iso-8859-1?q?s3TtKR9G3yUJIIWjI6Cd38X0zIRxtfnVvXJ7KCs4jgu8zIhP2TC7K8L7W4mQ?= =?iso-8859-1?q?5KZ2OOfp/k/HE4jy6t3HNE2ozyP0IqiQmu0MSb0JangdzsP94h4bGeTyo1kd?= =?iso-8859-1?q?y9Vogv+FzZKiP4qg9xNajDKjzORZuAuXj+dtvIBmcttPimtrZee95l1tG72M?= =?iso-8859-1?q?kAe//VzvtypJWiXDqH7QpHWZQymEzVlxPFkEVW+ZlF+s+wodr8AueaZEKVXL?= =?iso-8859-1?q?KiMhHpShz2Tb8B5J5qzuft7hEuHc5rn550vcU5GE8b9wuWpUeQ2A+sCGCihH?= =?iso-8859-1?q?3SLontIVIYGPV9oRam0AeVr1TkFx0WOtv3wQskzJ6Rd+LIU5G++DjyqE2cNl?= =?iso-8859-1?q?ImY0PMDl8fwyJIgcTV5eT5UPOTe24sJS98fnpoz7MCbTH9CqFDIZvIGxBzla?= =?iso-8859-1?q?sBqHnZo1mNaatHCLqnH2X/HMx4FyY4w0Y7cFBhRIVQWaDLUoZpkew8SeJCrM?= =?iso-8859-1?q?vx62rvXHSdUo7lh4ZDp4wEzRfEfKclM8oyhHhx5vPilOvuUe/hkqhj9VHQkn?= =?iso-8859-1?q?4e57kzUI9o9Z3vNnfcImnrrYPnCiA+UQwXP19HgntdkKY+aCWvir27uhtrwY?= =?iso-8859-1?q?1PxbdwqwhWI5G/JMhL6tnrENAW1J+J/lmjJoWyBnoSzFQgm3yC1+KzaJpjPm?= =?iso-8859-1?q?Y5CpqmpTklYX5jFOFyfl+Q04zLRPa8y1ht9xv/2Z4bnfd7sRdoucvzOEIDGl?= =?iso-8859-1?q?eSBEtYfpi/Oykk8XCPFyZiS7/K162XpYxCwrjB2fYkmEIG51guiRfd4R0JGd?= =?iso-8859-1?q?ImB9EdX+rS8BsXfcgg0W1gwW2LgQeGgVBkRRkDGMArU8o7J6zrdxh1Rn5NsX?= =?iso-8859-1?q?BNNH5LM712gW6jhgP78Y3Y7pN9mKExKkREeN8d4MNpHNRLh+HHaKy00Mob1c?= =?iso-8859-1?q?dY4h5MreB7D758bsKBehk8JmuhMCwFCAXk2xl/1pLpv33EhqkqoG1HE7mQHD?= =?iso-8859-1?q?b6LHBVP+/tG56gg8d4lVJ6vnq+NYSlSUG9vR3Gz0G0DlxGpkmPDma+SHf2F9?= =?iso-8859-1?q?dmiNSB04q7PJ2k8PFcn7T4677agwM?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5176.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4d1f54df-177b-4ab7-4c24-08da2de9dc2b X-MS-Exchange-CrossTenant-originalarrivaltime: 04 May 2022 16:19:27.0489 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Y6OxB02Y/Z7qoRPeaLsPcWkL6mACYw/FyCMgkPs/ii9IQfFS7A6YSYKlopQqPFBNwk+6r781rDGoSeuRTuwyttUs8VrveeKTbVsXoVPT+Vw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5597 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Ajay Singh Use 'u64' instead of 'u32' for the cookie variable as expected by cfg80211 callback function argument. Signed-off-by: Ajay Singh --- drivers/net/wireless/microchip/wilc1000/hif.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/microchip/wilc1000/hif.h b/drivers/net/wireless/microchip/wilc1000/hif.h index cccd54ed0518..77616fc77575 100644 --- a/drivers/net/wireless/microchip/wilc1000/hif.h +++ b/drivers/net/wireless/microchip/wilc1000/hif.h @@ -123,7 +123,7 @@ struct wilc_remain_ch { u32 duration; void (*expired)(void *priv, u64 cookie); void *arg; - u32 cookie; + u64 cookie; }; struct wilc; From patchwork Wed May 4 16:19:27 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajay Singh X-Patchwork-Id: 12838152 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74CEEC433F5 for ; Wed, 4 May 2022 16:19:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353312AbiEDQXJ (ORCPT ); Wed, 4 May 2022 12:23:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56600 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353255AbiEDQXH (ORCPT ); Wed, 4 May 2022 12:23:07 -0400 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.154.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A4E2246B13 for ; Wed, 4 May 2022 09:19:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1651681170; x=1683217170; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=72pxP9bTkUbZJGrXlO31Do31M0Oar5HcVSM5xjDmNg4=; b=s4eKAzTe/XV/xTd/gq5X7yRdGl615i++8vYf3xuzoNUwJ06DfdaIqHJU 3qiH18bonAoU63qhwV2weANUdw6RN5qXkGdUGHG95urUhLsoznNe27P96 ps1llc8POao0eBUDhKfIPYjECAS6PMTUEbSE36M+dSZac89xP6Lw6mHJ9 NK3q4fNwBPT1o6kxBewBut+p2rjy4hgygnbvKfZbyuiQSbpqRl/s3txBh zjatjXY/11Zo58FzlomZWajx2A2ezjsKCexshTaQbfVejWLTgpxVAdXwk 5q7zTE1v+SH5Ps4AC6t0cM54wJCwiloVUy3jchDlUn925H3URfc+n43ok Q==; X-IronPort-AV: E=Sophos;i="5.91,198,1647327600"; d="scan'208";a="94549834" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa6.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 04 May 2022 09:19:29 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Wed, 4 May 2022 09:19:29 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17 via Frontend Transport; Wed, 4 May 2022 09:19:29 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eMncWExaTFy6EQWnhjozCXUkiBMZljFpiv76GZsdM/SSkJfMKRBp79VviHJgozmZ+KGp7SkPr5uy3foRozdUD8+SF6Ph3bGjiwCVm9f+kW2RVOnoKwkzjXTxtjcEkFv052N3KL6lQSe6NY3QYgyedDoOUNPBKagwCowaW0Ykm81vO2udf1e3mdvRaZa2eE7omr3dQ56nQo7/35EqldaFKVkTaA3IsBYQNFhTzAqqvtM92op7bUK4dk1AWso4IxKsuXrIr9q8r/9UsIs7YTaYpJfhL8oteC9dTsH6uABjn2FBNzFTexgF9RKuIjw/osr9BH3jkkBUYsitt2lRD8iHFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KwKWL7pLBEUVJfTAi8G8mj+L1+eIlv6eqN3fGqsJd9U=; b=CMZZquZdEIvijcO+JirIW6W/oF+dSvU5c9eo3qxTDHgLCO/yBnUwuvv4zlPq3l0SV5Juy9Sbi8bXz2UUZClQLzECw7sMRdXSSv3INX+s/H/jgtl1EKG475/cUrsVh40Gkms5ZIVrOG3+0/OHiIOFSJDnTbTHHRqcO7V4BJqDjOtvVeG0H35y7dejSWm93NKn8h5S0HkiEStTRHDibRdZNiYIDepaLOGYT6hwbfzPh3bAKs6vUfC3QcUUl3BgzjcOabAsSH52PwphTVmeO06ExRfAeq6sL/75RCGFEB90j/OMfXwgPODTzghqAJhloMhU3ba4pmkpziVIdCj6z6LQ6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector2-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KwKWL7pLBEUVJfTAi8G8mj+L1+eIlv6eqN3fGqsJd9U=; b=t323kt1tHc9r2PzQVVxEgIwOyzUXFQodvq1c7Os2FJld0S6EnET/KkkNnvcckDCTSl2EYI1uoZwFkQe1xOoWt6oL+oEXaaz7Id72f1fco0cgWqGKzQw9/N4RqVbi5hyUVmoIsm6hdiiFKKqHNlnBkTo1q5QttUjCHQU4SeEf3ug= Received: from PH0PR11MB5176.namprd11.prod.outlook.com (2603:10b6:510:3f::5) by SJ0PR11MB5597.namprd11.prod.outlook.com (2603:10b6:a03:300::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Wed, 4 May 2022 16:19:27 +0000 Received: from PH0PR11MB5176.namprd11.prod.outlook.com ([fe80::d0fc:845b:ce0b:11fa]) by PH0PR11MB5176.namprd11.prod.outlook.com ([fe80::d0fc:845b:ce0b:11fa%7]) with mapi id 15.20.5206.026; Wed, 4 May 2022 16:19:27 +0000 From: To: CC: , , Subject: [PATCH 5/5] wilc1000: add valid vmm_entry check before fetching from TX queue Thread-Topic: [PATCH 5/5] wilc1000: add valid vmm_entry check before fetching from TX queue Thread-Index: AQHYX9K5v2GgK0DDa0m7VuNszJu7yA== Date: Wed, 4 May 2022 16:19:27 +0000 Message-ID: <20220504161924.2146601-5-ajay.kathat@microchip.com> References: <20220504161924.2146601-1-ajay.kathat@microchip.com> In-Reply-To: <20220504161924.2146601-1-ajay.kathat@microchip.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.25.1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microchip.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 58bf1942-d966-4c2f-1c70-08da2de9dc81 x-ms-traffictypediagnostic: SJ0PR11MB5597:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: N1bwtPins34bIa3pneTctI+kieebj6KmRRuH0it30o0twNJ7toBwFinqlz7lfXNxA16EB2Rvw61Sui7qXjcadrFJ6ZKRS/CDGBOlj9l7GdukKSry35xv78iqPSzYGHVyM/aTEhNgcsr1TD0z88Zqh/bHaPLTk+ILlL7Lw89V/DF90+XaIh+yJXzbZIZEDbILSy51TxG2ZkBxHLu9lyqRadaqzuOLHZA8EKpAsLg2zI2VF91OavHMesvjdMYBsIx0EVKIrvBuMINOiNMUPZa/9SKA+IvW8Ddr/WYFnH4FJaEugGgHGYbaxBhVicFLZ0w8vtFHrEzG83D7LXFvn9Sa9zMrG6CwHdFv79tByKY+ktCEGs8N3XuS3TB+z/H2TdorUwGILftwQvijnQBUGTi+BYXC/d6N/wkdlPaKDXTpsD8YPAn/myG/Yam/Hs0hHc4JAoNvmmDbPumKJEuvQZBEeCUZme7ZPDkI4q6eqLAJ49ei7JVSW9kRMKeyIMYzmOH57O8HTFRhjhEIvk29l18u3+L9AxwPR7RC5bcZ9leN4BzXrZH6WYeF34y8tuFo/bxzbuvriCyQSZWGLxHKdgfPRd7WFHfwPWaugXU0DmeZSkK/omST1rJhfOtPGLdQlx5AzXwm8ip450ZXchYr3hAjKRAhFXEvTVBjDvEPc8wUTSA+m4DF35XZPCU1YBHlEdIgMr/1gWFTSi8lEU8YMoVX1Q== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5176.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(36756003)(38070700005)(38100700002)(6486002)(122000001)(2906002)(8936002)(6506007)(508600001)(1076003)(4326008)(86362001)(6916009)(186003)(6512007)(26005)(71200400001)(2616005)(54906003)(5660300002)(316002)(91956017)(107886003)(8676002)(83380400001)(64756008)(76116006)(66556008)(66476007)(66446008)(66946007);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?q?/IgpJ3WuWnLgsOJeGyJN10C?= =?iso-8859-1?q?4dVCTfwZN4PkFak5Yz39xbRc3xD8Zp8qrhhfpCKU7CSDwm9ENa60vIeze3rA?= =?iso-8859-1?q?B2GgxO0cuq8gYkF6p87ljCl2lGP+GNarYl/pLC3++eLGAo1EgeyXVprMVjYu?= =?iso-8859-1?q?3XAduT7WHv0e9q4b0E9qSHzdNSQ+CI1blR1Ix46yAc1xE+yW3rKb1SAvThNp?= =?iso-8859-1?q?6j6CylvZ8T+HeR+pBYAZ9sBpbWkKLY5hBsbkgecIZGnkeipmvMjv0SBp5DON?= =?iso-8859-1?q?5K02GsR1n/MZVG42npDnmCyJZu7K83+ycW4h+qw611Eu4rcsh7qLTC23LOOb?= =?iso-8859-1?q?6YstdQ0EDwdgw2Bvzm3+sAzEK6agQBiz3tZJ3yRr7Ct+kfDCzTbR/w/zk8Mh?= =?iso-8859-1?q?O9I3XNIvaFo0Z1Kmiu1LbAbq+fB4WbCdLshTKk8gOvi3Ms22ZsAsoyutRQaA?= =?iso-8859-1?q?BhRP9o2VmOTcFOAHSV+8f+doZwFg2T/HX3wYg4BxmwbR1OK6rfWjLUv2fCSX?= =?iso-8859-1?q?kiBJqwKv2oWZfdLCDarTX0dAkeLq1MrgcMe/2PSZAV32pw1HCfqT1nWLwt4I?= =?iso-8859-1?q?q13R5nn1cPbERpfngkN4OFrmo3RlOc8Cws36etzh9KY46siVYK2CuPaiq9Qk?= =?iso-8859-1?q?SbNU5oDRHl8ED5OzVHatMe2slS1fmLJeaJzffGWYaMgzy8YcmiPsTvK9MZ8u?= =?iso-8859-1?q?XqAvJhQYNCR6xtu0x5dsplr3lKxMGsxBKrElK5+tXkorzGVcia+26bZG2Ww6?= =?iso-8859-1?q?ZyC1JekpKTU5IxPBKNMXe3+wEnf6/JkZKmu4pWTGh8UU9FLSbb95v4beJ8D9?= =?iso-8859-1?q?s8KbhOWAbhl2+KzVLgPmHZlc9ssmzHR6vx/iuuXHXj++XXtMEGvYFp+0G51v?= =?iso-8859-1?q?z3PKDxNYOyEQ1C/Pc0WN5KeClksEAG5tyVHvSPgESDCFaHV6uwUBT8d/kz6C?= =?iso-8859-1?q?059eIN3kIYoGNyH64Ue9rhR8DKyzd+ZlREvsA3QLscsIFwGHX2F/+cZn2Oag?= =?iso-8859-1?q?g4+dd3evkVmZScg3/M/exPF5UcsYJU8Doe8VyX92R7slc1vk3lJ3G3MJgyC7?= =?iso-8859-1?q?l4f/Ysim6WY+KrEbG/Rs/Or6zRZNKVWuXDQ9ougJijcwKnUmapkzALQxtl27?= =?iso-8859-1?q?dhjyHc7LFvG3pUk6JBNfM4R3CMjtaGQ7gLMRK0W912HD3QL5f0dsBfVp9Lsk?= =?iso-8859-1?q?FhuFlXC2s/G+hrccgcNYu1EQ4tgkIXUWz/gPPzCoQ8/M7hy54HnLoL+fe2Ly?= =?iso-8859-1?q?AIAgJFQ/rYuOCcqlrRKm+SHSGd8TFBjnpiZG7a5z+a+RgwF4srQH6HJgBbaS?= =?iso-8859-1?q?4QDqup9fjzsWBtJdcaWrEpUNtE3MpdXbHJXrQ2nHmPxrrqEAcR9KtQZ9ITHM?= =?iso-8859-1?q?s7s70xKgOoXX7LTrapEpLmGWlfty5udWdCs6AGpxr2mu0pVJ3ugzljsJTGlG?= =?iso-8859-1?q?SKW+7OB2LV2pmws9nMFSYGayIsEfV9L0BAVeSwo2WLuxvGekgO4RsJdmBRS9?= =?iso-8859-1?q?MsSwdTSQyYS32yGzgT7wKaBUl/3HvuwBAkrLqCnhQREkIeyhe4Y5SKyPxPy+?= =?iso-8859-1?q?zOtBZvfOSvtAoisK6buDk3X6o3uEM7vMDSm2/h3nM/5LJkD2fyxE5EC+oA6Q?= =?iso-8859-1?q?QLEupfi7/CV0Z6pmfBUeBS+K2rSFECehJLDBx71O46jLRCVPzEDnOUVwWPiW?= =?iso-8859-1?q?L77jmejkX9iAyVOY8JSKYezDie4pXbEkWRRbPd2M7+mR23YN8f9HBCCGpOB4?= =?iso-8859-1?q?l+9AfEj5inWZisfeAgP6191eTL/IGozwp4i/HvziQZWC4B8ty3oD/sOW5CW/?= =?iso-8859-1?q?y5TnjxONTXgCqCBXqi1lJdvnG86eU?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5176.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 58bf1942-d966-4c2f-1c70-08da2de9dc81 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 May 2022 16:19:27.5800 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 70/sOaXaVXlFBvlqNK1rYyBRoP+jzGeWSka5a1kdxrsal9PpgeGaU3aTDVCfnvmlfYkJlOUsoPBg1ol56lK+uePWOydUcAbGKHhJF95r8o8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5597 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Ajay Singh 'vmm_table' array contains the size of data buffer length including host header length. In 'vmm_table' array, the Zero value means the end of vmm_entries that needs to transfer to firmware which is calculated based on VMM free size in firmware. Use 'vmm_table' valid entry check before fetching the entry from TX queue to only copy valid number of entries to avoid possible NULL pointer exception observed sometimes during large file transfers. Signed-off-by: Ajay Singh --- drivers/net/wireless/microchip/wilc1000/wlan.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/microchip/wilc1000/wlan.c b/drivers/net/wireless/microchip/wilc1000/wlan.c index fb5633a05fd5..48441f0389ca 100644 --- a/drivers/net/wireless/microchip/wilc1000/wlan.c +++ b/drivers/net/wireless/microchip/wilc1000/wlan.c @@ -875,14 +875,15 @@ int wilc_wlan_handle_txq(struct wilc *wilc, u32 *txq_count) char *bssid; u8 mgmt_ptk = 0; + if (vmm_table[i] == 0 || vmm_entries_ac[i] >= NQUEUES) + break; + tqe = wilc_wlan_txq_remove_from_head(wilc, vmm_entries_ac[i]); - ac_pkt_num_to_chip[vmm_entries_ac[i]]++; if (!tqe) break; + ac_pkt_num_to_chip[vmm_entries_ac[i]]++; vif = tqe->vif; - if (vmm_table[i] == 0) - break; le32_to_cpus(&vmm_table[i]); vmm_sz = FIELD_GET(WILC_VMM_BUFFER_SIZE, vmm_table[i]);