From patchwork Thu May 5 10:13:37 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hyeonggon Yoo <42.hyeyoo@gmail.com> X-Patchwork-Id: 12839338 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2699AC433F5 for ; Thu, 5 May 2022 10:16:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 510C46B0071; Thu, 5 May 2022 06:16:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4998A6B0073; Thu, 5 May 2022 06:16:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 312DA6B0074; Thu, 5 May 2022 06:16:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 1A8026B0071 for ; Thu, 5 May 2022 06:16:02 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id DFCBC2D461 for ; Thu, 5 May 2022 10:16:01 +0000 (UTC) X-FDA: 79431283722.01.B5BFC94 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by imf15.hostedemail.com (Postfix) with ESMTP id 5C84AA0088 for ; Thu, 5 May 2022 10:15:52 +0000 (UTC) Received: by mail-pf1-f173.google.com with SMTP id h1so3271653pfv.12 for ; Thu, 05 May 2022 03:16:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GOAcDGlSWe2Jb33NzDcQaYtU804KKEt7OooYW1HA4U4=; b=Fgh9cX+m5xcyqwOOpw5Jxn2Co881HgTaFW8hqLvN6T9iFRp6wJxkdwOH9WMnlguJ2B STHoH/FFDYncrqxYbclQyprPLjc4cEQOxZC/21bpPmLblsfF4kHHuIHYd1Y9jDeEnmt2 r+Ygl25+//nu/1sfxpYdaCRv8oqzDVlqqyfdGxynS5IhwTbpbGsKiP6h7D38TakshvkX J8xjRUmfLNowcTQsdX2YJt2leWTJHgOitQuFqz765cEPcMZmXFN2Y1D79t4ykHQCc+/I Fg/e3eDPuu6H18cDUoOKpp4UZpOLEhnEpSJPlEu7BsbdHe0sJ/1MwSv1Ggz10GWgn7Lm etzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GOAcDGlSWe2Jb33NzDcQaYtU804KKEt7OooYW1HA4U4=; b=KagFWyGZlt6O7xIf4tL5YlIxGGhPatuZda2LFduztPxd7Kh0wtTEJpxAGgkCmujPyk ousppHruQzKzVOO+JF/KnbtxP5bSo43Mdvr3/FVfCYvnMjaTtscoHJpqoyXEFfpz0mZJ qeiUISowIZuxsLnOfbhxdKv7jjGf0SjyJh/qiPu1LTfY5N//peKF3ynk1A3OwAfH+ANp PzCfam2AYaeNePV264l0zYGNbWMfcaS2/Ba9fZ8Lv5Xg8+fT4UDBAMeuMtiPZ5ThuwVg j3qwH43YpFHBW/vkyNeJ48PI5WUq6xkWUt+VdlnfxGkD7zm3IXYmmOcXTNVOZlQgwhY1 OBjQ== X-Gm-Message-State: AOAM530QNXzssLshVsg1/zL4zIrmuitH9/lvNBSLwx1RP8E4SFCnlPbc 5s3IN72kl8BOUBsMAS/78HQ= X-Google-Smtp-Source: ABdhPJzAKyeTBDuXcObkzQ4OmbkPGoejP7DzUn+3oqUTtVUamjS34DmwH7xv77k3N2gwPy2YJ9S1aA== X-Received: by 2002:a63:682:0:b0:3c1:5bb1:85ee with SMTP id 124-20020a630682000000b003c15bb185eemr21776271pgg.146.1651745760387; Thu, 05 May 2022 03:16:00 -0700 (PDT) Received: from hyeyoo.. ([114.29.24.243]) by smtp.gmail.com with ESMTPSA id c4-20020aa78804000000b0050dc76281a7sm970648pfo.129.2022.05.05.03.15.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 May 2022 03:15:59 -0700 (PDT) From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Alexander Potapenko , Marco Elver , Dmitry Vyukov , Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Muchun Song , Hyeonggon Yoo <42.hyeyoo@gmail.com> Subject: [PATCH v3] mm/kfence: reset PG_slab and memcg_data before freeing __kfence_pool Date: Thu, 5 May 2022 19:13:37 +0900 Message-Id: <20220505101337.1997819-1-42.hyeyoo@gmail.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220505073920.1880661-1-42.hyeyoo@gmail.com> References: <20220505073920.1880661-1-42.hyeyoo@gmail.com> MIME-Version: 1.0 X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 5C84AA0088 X-Stat-Signature: p1g7uhjmbx4ttkqfruoxxnkoxi17ur5y Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Fgh9cX+m; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf15.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.210.173 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com X-Rspam-User: X-HE-Tag: 1651745752-319958 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: When kfence fails to initialize kfence pool, it frees the pool. But it does not reset PG_slab flag and memcg_data of struct page. Below is a BUG because of this. Let's fix it by resetting PG_slab and memcg_data before free. [ 0.089149] BUG: Bad page state in process swapper/0 pfn:3d8e06 [ 0.089149] page:ffffea46cf638180 refcount:0 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x3d8e06 [ 0.089150] memcg:ffffffff94a475d1 [ 0.089150] flags: 0x17ffffc0000200(slab|node=0|zone=2|lastcpupid=0x1fffff) [ 0.089151] raw: 0017ffffc0000200 ffffea46cf638188 ffffea46cf638188 0000000000000000 [ 0.089152] raw: 0000000000000000 0000000000000000 00000000ffffffff ffffffff94a475d1 [ 0.089152] page dumped because: page still charged to cgroup [ 0.089153] Modules linked in: [ 0.089153] CPU: 0 PID: 0 Comm: swapper/0 Tainted: G B W 5.18.0-rc1+ #965 [ 0.089154] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.14.0-2 04/01/2014 [ 0.089154] Call Trace: [ 0.089155] [ 0.089155] dump_stack_lvl+0x49/0x5f [ 0.089157] dump_stack+0x10/0x12 [ 0.089158] bad_page.cold+0x63/0x94 [ 0.089159] check_free_page_bad+0x66/0x70 [ 0.089160] __free_pages_ok+0x423/0x530 [ 0.089161] __free_pages_core+0x8e/0xa0 [ 0.089162] memblock_free_pages+0x10/0x12 [ 0.089164] memblock_free_late+0x8f/0xb9 [ 0.089165] kfence_init+0x68/0x92 [ 0.089166] start_kernel+0x789/0x992 [ 0.089167] x86_64_start_reservations+0x24/0x26 [ 0.089168] x86_64_start_kernel+0xa9/0xaf [ 0.089170] secondary_startup_64_no_verify+0xd5/0xdb [ 0.089171] Fixes: 0ce20dd84089 ("mm: add Kernel Electric-Fence infrastructure") Fixes: 8f0b36497303 ("mm: kfence: fix objcgs vector allocation") Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> Reviewed-by: Marco Elver Reviewed-by: Muchun Song --- v2 -> v3: - Add Reviewed-by: tags from Marco and Muchun. Thanks! - Initialize folio where it is defined. mm/kfence/core.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/mm/kfence/core.c b/mm/kfence/core.c index a203747ad2c0..b7d3a9667f00 100644 --- a/mm/kfence/core.c +++ b/mm/kfence/core.c @@ -642,6 +642,14 @@ static bool __init kfence_init_pool_early(void) * fails for the first page, and therefore expect addr==__kfence_pool in * most failure cases. */ + for (char *p = (char *)addr; p < __kfence_pool + KFENCE_POOL_SIZE; p += PAGE_SIZE) { + struct folio *folio = virt_to_folio(p); + + __folio_clear_slab(folio); +#ifdef CONFIG_MEMCG + folio->memcg_data = 0; +#endif + } memblock_free_late(__pa(addr), KFENCE_POOL_SIZE - (addr - (unsigned long)__kfence_pool)); __kfence_pool = NULL; return false;