From patchwork Thu May 5 14:36:57 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harshit Mogalapalli X-Patchwork-Id: 12839645 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61863C433EF for ; Thu, 5 May 2022 14:42:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348520AbiEEOqU (ORCPT ); Thu, 5 May 2022 10:46:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38338 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232677AbiEEOqT (ORCPT ); Thu, 5 May 2022 10:46:19 -0400 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62EB456F95; Thu, 5 May 2022 07:42:40 -0700 (PDT) Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 245DSNOq013507; Thu, 5 May 2022 14:37:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding; s=corp-2021-07-09; bh=F5rTyHeM1UHdjfZeC+4fp+ByCrvy4DLRy95uf+aXe0M=; b=nhABQKd2sKLKtmQAVeyi7lj0cPGpM23umg4JykwISwlrbbvwIk5Bhhp9NBmrQk7BM2xM NyLW64mzgzM7anjvPoXmygJLGa+mJMM0PuZAATVrGbPwIRuqDph9yWJYrusUysccTgxX Ys8VdPF6+ifsElGrV3+nhpaQzGfd89HrnS16TrsHxgG+ea/VT9x0ff04/4ilebvPpLwU lGnCXrMbo7de71fyZ45z0nfjLYPqqjl8qBJXk3hSk7qdgphScevgQ9f6BFOJe8AjJkDs w9gTaNdoPZ/zlJ+fHt7hAV4o4z3lBDr62OM2w3PaltiwmbMv1+62Yin5eIExTAn+CXCd JA== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3frvqskjr1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 05 May 2022 14:37:25 +0000 Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.16.1.2/8.16.1.2) with SMTP id 245EZOCd002817; Thu, 5 May 2022 14:37:24 GMT Received: from pps.reinject (localhost [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com with ESMTP id 3fs1a73pdr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 05 May 2022 14:37:24 +0000 Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 245EbNjN008186; Thu, 5 May 2022 14:37:23 GMT Received: from ca-dev112.us.oracle.com (ca-dev112.us.oracle.com [10.147.25.63]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com with ESMTP id 3fs1a73pcs-1; Thu, 05 May 2022 14:37:23 +0000 From: Harshit Mogalapalli Cc: harshit.m.mogalapalli@oracle.com, dan.carpenter@oracle.com, James Smart , Ram Vegesna , "James E.J. Bottomley" , "Martin K. Petersen" , Daniel Wagner , Hannes Reinecke , Nathan Chancellor , Wei Yongjun , linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] scsi: elx: efct: Remove redundant memset statement Date: Thu, 5 May 2022 07:36:57 -0700 Message-Id: <20220505143703.45441-1-harshit.m.mogalapalli@oracle.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 X-Proofpoint-GUID: QneWUrFrThNje_pYJThDiadbzhYRVLDn X-Proofpoint-ORIG-GUID: QneWUrFrThNje_pYJThDiadbzhYRVLDn To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: target-devel@vger.kernel.org As memset of 'bmbx' is immediately followed by a memcpy where 'bmbx' is the destination, memset is redundant. Signed-off-by: Harshit Mogalapalli --- drivers/scsi/elx/efct/efct_hw.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/scsi/elx/efct/efct_hw.c b/drivers/scsi/elx/efct/efct_hw.c index d4bb37960a3c..5a5525054d71 100644 --- a/drivers/scsi/elx/efct/efct_hw.c +++ b/drivers/scsi/elx/efct/efct_hw.c @@ -1402,7 +1402,6 @@ efct_hw_command(struct efct_hw *hw, u8 *cmd, u32 opts, void *cb, void *arg) mutex_lock(&hw->bmbx_lock); bmbx = hw->sli.bmbx.virt; - memset(bmbx, 0, SLI4_BMBX_SIZE); memcpy(bmbx, cmd, SLI4_BMBX_SIZE); if (sli_bmbx_command(&hw->sli) == 0) {