From patchwork Tue May 10 11:51:40 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Abbott X-Patchwork-Id: 12844913 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6A73C433EF for ; Tue, 10 May 2022 11:54:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241262AbiEJL6A (ORCPT ); Tue, 10 May 2022 07:58:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45658 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241274AbiEJLz7 (ORCPT ); Tue, 10 May 2022 07:55:59 -0400 Received: from smtp123.ord1d.emailsrvr.com (smtp123.ord1d.emailsrvr.com [184.106.54.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE724270182 for ; Tue, 10 May 2022 04:51:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mev.co.uk; s=20190130-41we5z8j; t=1652183518; bh=LRMSZmaGPaBfd7950AFVlNtMBAPXjgWJaXpjj29Ai5U=; h=From:To:Subject:Date:From; b=hjjZRaCVYqCrcTxrmr0JO+qG1DtDrN/lX8a55DVZZE3Zm8ztaXsTjNzlFF1f+5jSD 5fcXmXYUXyLUoZ2NbkV7Z3BA1yH6yzlA0BT11ERT1iiyf7DcKlHYusSCyv7KdFGr5G nP8YgXAsWBw243Ip57rYgyo5yGiH/9YmqoIuEX5E= X-Auth-ID: abbotti@mev.co.uk Received: by smtp8.relay.ord1d.emailsrvr.com (Authenticated sender: abbotti-AT-mev.co.uk) with ESMTPSA id CC93AC00B5; Tue, 10 May 2022 07:51:57 -0400 (EDT) From: Ian Abbott To: linux-spi@vger.kernel.org Cc: Mark Brown , linux-kernel@vger.kernel.org, Ian Abbott Subject: [PATCH 1/2] spi: cadence-quadspi: Add missing blank line in cqspi_request_mmap_dma() Date: Tue, 10 May 2022 12:51:40 +0100 Message-Id: <20220510115141.212779-2-abbotti@mev.co.uk> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220510115141.212779-1-abbotti@mev.co.uk> References: <20220510115141.212779-1-abbotti@mev.co.uk> MIME-Version: 1.0 X-Classification-ID: b75da69c-0230-413e-8e5d-188bceb56f6b-2-1 Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org Fix "WARNING: Missing a blank line after declarations" reported by checkpatch.pl. Signed-off-by: Ian Abbott --- drivers/spi/spi-cadence-quadspi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/spi/spi-cadence-quadspi.c b/drivers/spi/spi-cadence-quadspi.c index 30307392c75a..9915704eaf06 100644 --- a/drivers/spi/spi-cadence-quadspi.c +++ b/drivers/spi/spi-cadence-quadspi.c @@ -1481,6 +1481,7 @@ static int cqspi_request_mmap_dma(struct cqspi_st *cqspi) cqspi->rx_chan = dma_request_chan_by_mask(&mask); if (IS_ERR(cqspi->rx_chan)) { int ret = PTR_ERR(cqspi->rx_chan); + cqspi->rx_chan = NULL; return dev_err_probe(&cqspi->pdev->dev, ret, "No Rx DMA available\n"); } From patchwork Tue May 10 11:51:41 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Abbott X-Patchwork-Id: 12844912 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3D56C433EF for ; Tue, 10 May 2022 11:54:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241266AbiEJL57 (ORCPT ); Tue, 10 May 2022 07:57:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45748 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241277AbiEJLz7 (ORCPT ); Tue, 10 May 2022 07:55:59 -0400 Received: from smtp122.ord1d.emailsrvr.com (smtp122.ord1d.emailsrvr.com [184.106.54.122]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A9CB26FA61 for ; Tue, 10 May 2022 04:52:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mev.co.uk; s=20190130-41we5z8j; t=1652183519; bh=vzRwUlGToYcHVeBq8ROmOTE4BYm05ZC+d240t0warA8=; h=From:To:Subject:Date:From; b=MQ/YsUQzXbKiOGKQWGacqxpFyEGIY7pIdpxWs0Qol7ng+gWXXn5CGdLf9L1Yd7ymc Pnl/NTiS9orL3/7LEq/fNG+K33NVqO2vB7kT6/2CuhGHlgcUpsrq702XQEaVgCHlmg 8DTprCXSrY3HdjDVcAIAtOL+YbUBFEYHbc5V4hMw= X-Auth-ID: abbotti@mev.co.uk Received: by smtp8.relay.ord1d.emailsrvr.com (Authenticated sender: abbotti-AT-mev.co.uk) with ESMTPSA id D8407C00B6; Tue, 10 May 2022 07:51:58 -0400 (EDT) From: Ian Abbott To: linux-spi@vger.kernel.org Cc: Mark Brown , linux-kernel@vger.kernel.org, Ian Abbott Subject: [PATCH 2/2] spi: cadence-quadspi: remove unnecessary (void *) casts Date: Tue, 10 May 2022 12:51:41 +0100 Message-Id: <20220510115141.212779-3-abbotti@mev.co.uk> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220510115141.212779-1-abbotti@mev.co.uk> References: <20220510115141.212779-1-abbotti@mev.co.uk> MIME-Version: 1.0 X-Classification-ID: b75da69c-0230-413e-8e5d-188bceb56f6b-3-1 Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org Remove a couple of unnecessary casts to `(void *)` when initializing the `.data` members in the device ID table. Signed-off-by: Ian Abbott --- drivers/spi/spi-cadence-quadspi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-cadence-quadspi.c b/drivers/spi/spi-cadence-quadspi.c index 9915704eaf06..aea6c132cbab 100644 --- a/drivers/spi/spi-cadence-quadspi.c +++ b/drivers/spi/spi-cadence-quadspi.c @@ -1811,11 +1811,11 @@ static const struct of_device_id cqspi_dt_ids[] = { }, { .compatible = "xlnx,versal-ospi-1.0", - .data = (void *)&versal_ospi, + .data = &versal_ospi, }, { .compatible = "intel,socfpga-qspi", - .data = (void *)&socfpga_qspi, + .data = &socfpga_qspi, }, { /* end of table */ } };