From patchwork Fri May 13 10:26:12 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Max Krummenacher X-Patchwork-Id: 12848637 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6F7E8C433EF for ; Fri, 13 May 2022 10:28:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xty+6nSGECMi8J5OcNYd43YCOxAfvN2uaEZium0xnVM=; b=dd0x2J5qjUTRkb f6wTdEKDH+vV0UuCI1WKjyCdcW4hRpPyn0zh+Vkyro2eLgHQ61dFyhvf9nUYMh6+z6yhAA7Ci1p/0 tdkHqMlaOpgtG9hhxjtp4upP4BzfrTzsp6ZdRODIPSfzNMC0n1VvEiesbNwtdYB351fu/9yzSjmZi SwFh8Wyc4rTbqxPwGiKa4HKOHW5GzFDsWoMXJ7tHaubea6HwvQbCy1ddouv8OMlVW6TmiVCQyG3NO v69f8zjzFZTFR7hpbQe1zsXT/nPmHyPFpcaB/LV4Vr4U8LWN652gy/r20sMM72nEJOCz8tfwRL0hn UpI9i3hi3T4cUbZ0gTwQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1npSVy-00FXaL-4c; Fri, 13 May 2022 10:27:18 +0000 Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1npSVm-00FXSK-O8 for linux-arm-kernel@lists.infradead.org; Fri, 13 May 2022 10:27:08 +0000 Received: by mail-ed1-x52c.google.com with SMTP id g23so9359032edy.13 for ; Fri, 13 May 2022 03:27:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZIRDh90qLBvm84n6WkVrFxDl6BpgAk2Zm5Bgq5+AFUk=; b=b7csS6dQWyR/B4w7/AfPzowZ32axPRW+xaxYY/sD//r5JAT4tOd5ghfxuid99JBOpp DRUHa+LPXtBkY7CriVzq/1UOe4uBZACFkzvzVrSV71+GrJ76MY2YezvX2tdosxB0kvWZ cuFJtBu75gCjQmA5I9ddoXOTMe6izuGBb583wvwGCclDisEHLWuBie5dWyZFemAbBqb9 SsM9kOJxYuaZZJE1Q5E2qZsN9O+7yiU/OBqbUcret3qen039LXBBOQ5Z+t9n6bEYdUQU R7VX0NUgfkuDzeiqEsX34zAw1hh56277acq8wA9zDBsZHKShJNcbIWqtvOBdDfu+D/ho wZoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZIRDh90qLBvm84n6WkVrFxDl6BpgAk2Zm5Bgq5+AFUk=; b=XFesaKfu641rmurZSrBJ0CqeKl4w/w8J6iViGYLWftwBSa3FNEs7hXL7x+atU/1Swi pLXAAACyJKOPbLx8w1f75KF5t3ZmoDbNyttkDoWslo+qtIkYVWfkkzKy1NY4zt7oDq8K rbY0ZWMucNJPHnoTZAxPe/LqrKbbPeXRCajHkfK3Z99tbJpRAWXHlu4tl93S79XgNy8l /wQ0sSK8Lzo6r8Lc2NThtoJ1gkTgBUET+1o8ioNQ4nPxKE8wslxrG0rCRBJlPywzk64H uzvyzGzBxaqURwhqVq5pmdZeWziSz4wYSr721W2GP96PMRjnOwzJzGxkb5vJuJhWTSAq JcUA== X-Gm-Message-State: AOAM530RqAuUOC8MnE18qr+o1ygdGajJvuJvbuL2GSr+oAvT58yf4ff9 QhzjsSVvJptCAPIn9VbDzXk= X-Google-Smtp-Source: ABdhPJysbC54HVn2cXqVbW7EoCSUGPzri5soUM98ZiXZrliZVoDcfVEn5+a1rJQnXP14c8VfUy9FWQ== X-Received: by 2002:a05:6402:294e:b0:425:f016:24e7 with SMTP id ed14-20020a056402294e00b00425f01624e7mr39241816edb.111.1652437624212; Fri, 13 May 2022 03:27:04 -0700 (PDT) Received: from linuxdev2.toradex.int (31-10-206-125.static.upc.ch. [31.10.206.125]) by smtp.gmail.com with ESMTPSA id 3-20020a170906100300b006f3ef214e40sm609677ejm.166.2022.05.13.03.27.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 May 2022 03:27:03 -0700 (PDT) From: Max Krummenacher To: max.krummenacher@toradex.com Cc: Fabio Estevam , Krzysztof Kozlowski , NXP Linux Team , Pengutronix Kernel Team , Rob Herring , Sascha Hauer , Shawn Guo , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 1/4] ARM: dts: imx6qdl-colibri: Fix capacitive touch reset polarity Date: Fri, 13 May 2022 12:26:12 +0200 Message-Id: <20220513102616.48040-2-max.oss.09@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220513102616.48040-1-max.oss.09@gmail.com> References: <20220513102616.48040-1-max.oss.09@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220513_032706_821175_531DED04 X-CRM114-Status: GOOD ( 12.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Max Krummenacher The commit feedaacdadfc ("Input: atmel_mxt_ts - fix up inverted RESET handler") requires the reset GPIO to have GPIO_ACTIVE_LOW. Fixes: 1524b27c94a6 ("ARM: dts: imx6dl-colibri: Move common nodes to SoM dtsi") Reviewed-by: Fabio Estevam Signed-off-by: Max Krummenacher --- (no changes since v2) Changes in v2: - Added Fabio's 'Reviewed-by' - Removed blank line in commit text arch/arm/boot/dts/imx6qdl-colibri.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx6qdl-colibri.dtsi b/arch/arm/boot/dts/imx6qdl-colibri.dtsi index c383e0e4110c..7df270cea292 100644 --- a/arch/arm/boot/dts/imx6qdl-colibri.dtsi +++ b/arch/arm/boot/dts/imx6qdl-colibri.dtsi @@ -593,7 +593,7 @@ pinctrl-names = "default"; pinctrl-0 = <&pinctrl_atmel_conn>; reg = <0x4a>; - reset-gpios = <&gpio1 14 GPIO_ACTIVE_HIGH>; /* SODIMM 106 */ + reset-gpios = <&gpio1 14 GPIO_ACTIVE_LOW>; /* SODIMM 106 */ status = "disabled"; }; }; From patchwork Fri May 13 10:26:13 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Max Krummenacher X-Patchwork-Id: 12848638 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 04F06C433F5 for ; Fri, 13 May 2022 10:28:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KXR9yToQOz4XtzYgxtKzswc2eRcuYhYwnZSpzWkbJig=; b=fAWL+bUShyWTdY qUUpt8W64yGoi+uVP2ePUYj5dyAXK/rc2efj3oD/DMCwFEqgT2Qaak+I7rrjRPvI1q0RA1XOPt4Ug bAWtOUlRwK2bLRN3Ug4MM5cCUTkFDPxJ5I6Hi6rj2pWLmcnwkyiTd/0cFowCDhJvKAagx9aoThdeX 3P1A2u1KlIc2rBCaFr13HGE2RLWs0NJ5Fnq0wlKn+RHTJUY81fLcvb+U4asAwWXDXgREc5wSvU5vQ ytCQJ4tsUaS59TKP6ewaVp2Mb9d7HagXGgCNqpEEg5y6IldgBb9m6Z5vU5m8e03EDqVXaBF/AVQO+ GaC1fnUxSI/wFBymGqqQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1npSW7-00FXdv-Lt; Fri, 13 May 2022 10:27:27 +0000 Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1npSVn-00FXSo-Q3 for linux-arm-kernel@lists.infradead.org; Fri, 13 May 2022 10:27:09 +0000 Received: by mail-ed1-x535.google.com with SMTP id z19so9415046edx.9 for ; Fri, 13 May 2022 03:27:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9YzZvCjzSx23GCo5tj+e9SggYb8gkEkdJyT+dWl4gnY=; b=cJcPiPXqp99o/FwSgHSz3dDHbrNByGdaMRoNV0f8aJpS3zg+2rISd3a6PXxKo+wmwD FK3Xn9oICrrm9NlMU1HQ3GlgN/bSqErJ49SydqShN+6HMZj/BccumgW3jNDdB6CTpB7F Lot8D6L90KW1lHnSguAOtEJkp9JWkgE+Hf/SkuGfQ/VMv923goKITVc8VkGRZf+J5jYM r1Vzt8uXbsG/bQOwbSfAet236bz+eLoHrFTnR35Gd+I7otNICzstr9/A9u5FrqoxC2zb MwNeR2FpF2nEQz7Q162KBSh7/+hyMZe0mYPuyIDQFWrHqlqabh4fHdQQEKFsOqYxihHi BpGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9YzZvCjzSx23GCo5tj+e9SggYb8gkEkdJyT+dWl4gnY=; b=E8Uwe2um08dwvtFBo8Jj2xA37ShvPeSsJ6g5h8Qm30/9NjIQW+6wuwidC5lfYGLc2o Zjsg3lXkP1p6j/RzfR8emweEQbVNqymBl4mO/tJ6d3goucbBlXtFk+Cuky8Z6Uy5noHZ qu0J+CQXs23TzQWs2QCqm5eHQC5jl2to9x3Y7oX/Kq0xpJopYb2v8SduC4Uj8ngT/bDw J1VgKcjY0IsVKTLt7mXmdqjBBf7aIXndxVKCSlHVUOn6CpJfKSbsNLLnrbwM0n8suW2k /sM3e/esG28cljUhN+e1j7kDDOX3vArSDPZUNc0nkpOwJJyTmoxV+ssoFdwpFzXfZgiT gmxQ== X-Gm-Message-State: AOAM532tOo/AIyWuEN9GciaMq1xoUf87GuRFtHu6xaezND3R96UqXGpf or5xQwpljnquYu83fy8Lxbo= X-Google-Smtp-Source: ABdhPJw7MD312KW+pbEyX7ADtYmRXzNeWrJMI2J8c7tAQdrK9Sg6kXBQ/efbGcHhj8qAJoQjQPZ6gw== X-Received: by 2002:aa7:d9c8:0:b0:428:364c:df2f with SMTP id v8-20020aa7d9c8000000b00428364cdf2fmr39587358eds.327.1652437625440; Fri, 13 May 2022 03:27:05 -0700 (PDT) Received: from linuxdev2.toradex.int (31-10-206-125.static.upc.ch. [31.10.206.125]) by smtp.gmail.com with ESMTPSA id 3-20020a170906100300b006f3ef214e40sm609677ejm.166.2022.05.13.03.27.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 May 2022 03:27:04 -0700 (PDT) From: Max Krummenacher To: max.krummenacher@toradex.com Cc: Fabio Estevam , Krzysztof Kozlowski , NXP Linux Team , Pengutronix Kernel Team , Rob Herring , Sascha Hauer , Shawn Guo , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 2/4] ARM: dts: imx6qdl-colibri: Mux mclk for sgtl5000 with the codec node Date: Fri, 13 May 2022 12:26:13 +0200 Message-Id: <20220513102616.48040-3-max.oss.09@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220513102616.48040-1-max.oss.09@gmail.com> References: <20220513102616.48040-1-max.oss.09@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220513_032707_888618_32CFF5E3 X-CRM114-Status: GOOD ( 14.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Max Krummenacher Move the pin muxing for MCLK used by the codec to the codec node instead of placing it inside the audmux pinctrl group. While no negative effects have been observed this should make sure that MCLK is provided when the codec driver is probed. Follows commit fa51e1dc4b91 ("ARM: dts: imx6qdl-apalis: Fix sgtl5000 detection issue") Reviewed-by: Fabio Estevam Signed-off-by: Max Krummenacher --- (no changes since v2) Changes in v2: - Added Fabio's 'Reviewed-by' arch/arm/boot/dts/imx6qdl-colibri.dtsi | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/imx6qdl-colibri.dtsi b/arch/arm/boot/dts/imx6qdl-colibri.dtsi index 7df270cea292..f0908b530f86 100644 --- a/arch/arm/boot/dts/imx6qdl-colibri.dtsi +++ b/arch/arm/boot/dts/imx6qdl-colibri.dtsi @@ -520,6 +520,8 @@ compatible = "fsl,sgtl5000"; clocks = <&clks IMX6QDL_CLK_CKO>; lrclk-strength = <3>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_sgtl5000>; reg = <0x0a>; #sound-dai-cells = <0>; VDDA-supply = <®_module_3v3_audio>; @@ -739,8 +741,6 @@ pinctrl_audmux: audmuxgrp { fsl,pins = < - /* SGTL5000 sys_mclk */ - MX6QDL_PAD_GPIO_0__CCM_CLKO1 0x000b0 MX6QDL_PAD_KEY_COL0__AUD5_TXC 0x130b0 MX6QDL_PAD_KEY_ROW0__AUD5_TXD 0x130b0 MX6QDL_PAD_KEY_COL1__AUD5_TXFS 0x130b0 @@ -991,6 +991,13 @@ >; }; + pinctrl_sgtl5000: sgtl5000grp { + fsl,pins = < + /* SGTL5000 sys_mclk */ + MX6QDL_PAD_GPIO_0__CCM_CLKO1 0x000b0 + >; + }; + pinctrl_spdif: spdifgrp { fsl,pins = < MX6QDL_PAD_GPIO_17__SPDIF_OUT 0x1b0b0 From patchwork Fri May 13 10:26:14 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Max Krummenacher X-Patchwork-Id: 12848639 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2219DC433EF for ; Fri, 13 May 2022 10:28:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UJNz2ZaZcO8EMpc+uVP3/6dIOmtA870TzRchiJG/Ex0=; b=ekw/u4Hnp7F3gj 0kNTUym84BakBfBdvRzNUyLmvU/jKH7NafZRLjSdFkVTLM3VgW2EVQQJL0EpWv8eCanyAVuy5Xw/6 B+nkSG8AEwK9hVzr3S/dOAfjN4f3xV6MeAiJap+afWEQDKNM00tNltaYU9aA2jkslGwoqrciAGXQG mgoRvTFNAbKsXU62Z+X53+XIZt+NldF9CeG/8YjLN+jwcWTWR/DH6mZdSXTH/WlgggNDED1qHpJsP Zs12UFtKsa5Qe6WUQdg/UQNHoNH2VkY2WCalwlEitVG+4jnijcu+jD9cIa1OxEuXXhMiPXnTrkh8R gLBM1sWxdSrOEDCugPgw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1npSWH-00FXi0-1K; Fri, 13 May 2022 10:27:37 +0000 Received: from mail-ed1-x533.google.com ([2a00:1450:4864:20::533]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1npSVp-00FXTl-1U for linux-arm-kernel@lists.infradead.org; Fri, 13 May 2022 10:27:10 +0000 Received: by mail-ed1-x533.google.com with SMTP id d6so9438034ede.8 for ; Fri, 13 May 2022 03:27:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Wjttoh5pJ3Cm9OJ+7lfSQscXOm+8KL2ATcs8KqsT+HA=; b=msYuy6T0lARvYyJaJSawEOZr3dDydhikevW3BwFGVTX5wJ7cpXtdPNtbiRqTbtsGLu 0c6iVa3rEbA0+7p4SulwQ4w7vdifgtpidzsJKqqpc11+zB6GbDtJoxT/1WmQQM0W7uID g17a7NjqvSqJaMxJqN81YsBoiLAOpPibkWMt8EXsjxy5vEDRtxn39Te5jBONTlfaUor5 F8V8IgwwmbvX7rwkOfeyGr0hYUsriTB/7UhB8XxKxlZYbkgbmDjTwD7fGaEviEimyNSa 6RGreK8pnkvJ/hIBS52EuXPIiJjOlkFXuuQ6Cb+DzRpM5vUghLRUSn62bV/cAHz/SPDn NQhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Wjttoh5pJ3Cm9OJ+7lfSQscXOm+8KL2ATcs8KqsT+HA=; b=HEKchE3ebho9gPob+herHH3oyDs6VIBykrITYXlNY6qCFnXCyKcCywHVHll5EgVb2K loREQu3kDAaAis9bTFZkWh/sxd0W6n0qH2i23hAbElT8l8jgLJB7jSH4bBYHkSJptUML L/cSZs2RPv7EW4/nVUlflDo43B3KOrTwgBlYcTz7o7Lo7N3BKJ6/hP3U/WgUkCr8/Fp/ rkKRNI4CsXSKpf3gTrR8qns17u28KSkU1/5vAUR7DX83KgkTLgxUbaP12QecBvf1+o4t Z2TFfGWNMLH2v03irRKBuE2QlEr31TCWHO60lRmssC0wbDbGBDNl1wPRf9hJfh4l42sG DpoQ== X-Gm-Message-State: AOAM532d8qkiZ0SvirZlYqdpeduQLVYgTZPxyJLUCiS8g2Ok/+y4Qzec Pl9Dy5aSgzjZAvIjdulpcuM= X-Google-Smtp-Source: ABdhPJzfZZQ0iwoUhAxi7llnxPNl7jZQUVkZxsiuUFC6Gmb/knxfHIKdKy0GUvUJ6TNiDR9mDxE3ag== X-Received: by 2002:a05:6402:42c4:b0:426:a7a8:348f with SMTP id i4-20020a05640242c400b00426a7a8348fmr39951718edc.341.1652437626688; Fri, 13 May 2022 03:27:06 -0700 (PDT) Received: from linuxdev2.toradex.int (31-10-206-125.static.upc.ch. [31.10.206.125]) by smtp.gmail.com with ESMTPSA id 3-20020a170906100300b006f3ef214e40sm609677ejm.166.2022.05.13.03.27.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 May 2022 03:27:06 -0700 (PDT) From: Max Krummenacher To: max.krummenacher@toradex.com Cc: Fabio Estevam , Krzysztof Kozlowski , NXP Linux Team , Pengutronix Kernel Team , Rob Herring , Sascha Hauer , Shawn Guo , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 3/4] ARM: dts: imx6qdl-colibri: backlight pwm: Simplify inverted backlight Date: Fri, 13 May 2022 12:26:14 +0200 Message-Id: <20220513102616.48040-4-max.oss.09@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220513102616.48040-1-max.oss.09@gmail.com> References: <20220513102616.48040-1-max.oss.09@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220513_032709_177385_5CC5154C X-CRM114-Status: GOOD ( 16.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Max Krummenacher Set #pwm-cells to the default 3 to gain access to the parameter which allows inverting the PWM signal. This is useful to specify a backlight which has its highest brightness at 0. With the change to use the PWM with inverted polarity the PWM signal is inverted to how it was before this patch. This changes the meaning of the values in the brightness-levels property. I.e. the duty-cycle changes from x/255 to (255-x)/255. Keeping the brightness-levels will then have a big brightness jump from 0 to 127 duty cycle, the other 6 steps will then be barely noticeable. Change the brightness-levels to provide the same brightness-levels as before. Signed-off-by: Max Krummenacher Reviewed-by: Fabio Estevam --- Changes in v3: - Add the reason why brightness-levels needs a change to commit comment as proposed by Fabio Estevam Changes in v2: - Split to two patches as proposed by Fabio Estevam arch/arm/boot/dts/imx6qdl-colibri.dtsi | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/imx6qdl-colibri.dtsi b/arch/arm/boot/dts/imx6qdl-colibri.dtsi index f0908b530f86..d91fae92c90a 100644 --- a/arch/arm/boot/dts/imx6qdl-colibri.dtsi +++ b/arch/arm/boot/dts/imx6qdl-colibri.dtsi @@ -6,6 +6,7 @@ */ #include +#include / { model = "Toradex Colibri iMX6DL/S Module"; @@ -13,13 +14,13 @@ backlight: backlight { compatible = "pwm-backlight"; - brightness-levels = <0 127 191 223 239 247 251 255>; - default-brightness-level = <1>; + brightness-levels = <0 4 8 16 32 64 128 255>; + default-brightness-level = <6>; enable-gpios = <&gpio3 26 GPIO_ACTIVE_HIGH>; /* Colibri BL_ON */ pinctrl-names = "default"; pinctrl-0 = <&pinctrl_gpio_bl_on>; power-supply = <®_module_3v3>; - pwms = <&pwm3 0 5000000>; + pwms = <&pwm3 0 5000000 PWM_POLARITY_INVERTED>; status = "disabled"; }; @@ -620,7 +621,6 @@ /* Colibri PWM */ &pwm3 { - #pwm-cells = <2>; pinctrl-names = "default"; pinctrl-0 = <&pinctrl_pwm3>; status = "disabled"; From patchwork Fri May 13 10:26:15 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Max Krummenacher X-Patchwork-Id: 12848640 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DC892C433F5 for ; Fri, 13 May 2022 10:28:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Z72HiQSQrORuCChZlh07Dal3k4TIzQ20AKxodBSl6vc=; b=DFR5bExczb7tGY 4twYCDJOifxC+KpNk/iKKMFnkGw89fNeB4QEEusYBunFvPg0G8mZwz/Fm2LCfAmmhblpqz11EgC2Q 0SXJtdFcA77yLnmLJj9Xbku+YOf0DOtwK8Pq+GesWp1SoqAhi6bnZG3ZjA1A+CHxJKNboez9bzLwT Aq9s0FSzEcOsn5r87Z02RYrwY/DF1jt7pFZl/M5+j+X/zrD+huAIgYZZg+1VXoxymtGnXyzOKeMOG qkr/w7XYo608ijkTjX2vL2aQWC2t+kibZ51k8Sia27CBLAYDdF69DwsnzPKe0Y/jrRU5978q3/5kE cTVn1V4OFalz9emW99Qw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1npSWU-00FXrS-Uz; Fri, 13 May 2022 10:27:51 +0000 Received: from mail-ed1-x52e.google.com ([2a00:1450:4864:20::52e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1npSVq-00FXUG-87 for linux-arm-kernel@lists.infradead.org; Fri, 13 May 2022 10:27:11 +0000 Received: by mail-ed1-x52e.google.com with SMTP id w24so9432583edx.3 for ; Fri, 13 May 2022 03:27:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VsZTr9QjspygKqEP/6Io66r11TQgQqrqyops3JYlbzk=; b=qlA92aLVsqewcDDRuuGo1+NpNYJnqGNxX3oXp4Q2KrkoNsfUgm04VVeXMU8BD3Nznx gn1aIOgb+inPUojjmRwdm7UGbMjCiZEtE9LwlqUy90SWFvnfLhf/KA0VthiJDAnCNMGH oIob9jPv9/Kxzt98OCHPydPsJWxNMBR60eK6kyk3RiIhNW2tEO1OcssDtBLgkOwpV2Lh 5dDiUgBR42Xa9GX5HTJ0QUdIHqoueQjPNjkI9TMFRMfD3MNtcCxubOv/j8xX8od7cBT4 QkPkbyFdcD7xbmBHgSt5P6QerjkWimxTGZ+eG/sv3AOivQ0MdiXVbli2IgCMctWh14x7 B/mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=VsZTr9QjspygKqEP/6Io66r11TQgQqrqyops3JYlbzk=; b=dJu46P0wC89pfC4RPyXAtxa9ISRki41HeoTYWvn9PvOA+YAG4fw8Wrx+my2LWjr9z1 l8Rj/7rXItzkGqFGDUFPX+QIRh4wRYUudVQDqWUFTBq1uIGoG/MoYy7qe6mQxHrdXxOD UD6S3XSW/NZX2JAOi+c/wtMLlDsuJeFUE9L0nc+wkaURk36MXhHGLxsaIfAS+SoMg6IA ygzWTijiy4Z7AKm3nmaFksz5GfLGdBSuv5h87+xwM/xg1WyWnS8UPLzSpT5APL/mHGWq j72j+Hh9a874aKCV3AacZv6zAsjcGKeED0nIqdh/RLYHBIXRW5X8yUSEmdvQv/Ey4EH4 m/dg== X-Gm-Message-State: AOAM532299FUOEOWi+7bW55f/lrM7B/iSI4QNavIzW6XY1gyyqPUS32w De9nElVZp+c3Wa1MjCulZ3Q= X-Google-Smtp-Source: ABdhPJxvN5lB6DSJD2MYMERwdhdTFcjVUkbw9vp5dslvwhSUVn2GAyGWfh9eNKuuBmE5E7xd/e2GpA== X-Received: by 2002:a05:6402:1399:b0:410:9fa2:60d6 with SMTP id b25-20020a056402139900b004109fa260d6mr39972511edv.35.1652437627797; Fri, 13 May 2022 03:27:07 -0700 (PDT) Received: from linuxdev2.toradex.int (31-10-206-125.static.upc.ch. [31.10.206.125]) by smtp.gmail.com with ESMTPSA id 3-20020a170906100300b006f3ef214e40sm609677ejm.166.2022.05.13.03.27.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 May 2022 03:27:07 -0700 (PDT) From: Max Krummenacher To: max.krummenacher@toradex.com Cc: Fabio Estevam , Krzysztof Kozlowski , NXP Linux Team , Pengutronix Kernel Team , Rob Herring , Sascha Hauer , Shawn Guo , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 4/4] ARM: dts: imx6qdl-colibri: backlight pwm: Adapt brightness steps Date: Fri, 13 May 2022 12:26:15 +0200 Message-Id: <20220513102616.48040-5-max.oss.09@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220513102616.48040-1-max.oss.09@gmail.com> References: <20220513102616.48040-1-max.oss.09@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220513_032710_334585_65EB1B8E X-CRM114-Status: GOOD ( 12.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Max Krummenacher Adapt the brightness steps as the backlight doesn't light up for very low duty cycles. Reviewed-by: Fabio Estevam Signed-off-by: Max Krummenacher --- (no changes since v2) Changes in v2: - add reviewed-by tags - Split the Backlight PWM patch into two patches, a) #pwm-cells 3, b) adapt brightness steps - Split to two patches as proposed by Fabio Estevam arch/arm/boot/dts/imx6qdl-colibri.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/imx6qdl-colibri.dtsi b/arch/arm/boot/dts/imx6qdl-colibri.dtsi index d91fae92c90a..023e76215064 100644 --- a/arch/arm/boot/dts/imx6qdl-colibri.dtsi +++ b/arch/arm/boot/dts/imx6qdl-colibri.dtsi @@ -14,8 +14,8 @@ backlight: backlight { compatible = "pwm-backlight"; - brightness-levels = <0 4 8 16 32 64 128 255>; - default-brightness-level = <6>; + brightness-levels = <0 45 63 88 119 158 203 255>; + default-brightness-level = <4>; enable-gpios = <&gpio3 26 GPIO_ACTIVE_HIGH>; /* Colibri BL_ON */ pinctrl-names = "default"; pinctrl-0 = <&pinctrl_gpio_bl_on>;