From patchwork Mon May 16 07:52:02 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 12850366 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 64477C433F5 for ; Mon, 16 May 2022 07:53:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=yAzrZ1MKfKxrApWcWRUKjOzJzZBpgbXYlXyxZuX37XE=; b=Z2LnbgQRlAp/bu 2uP8lUVG0zGgPwOSIQgwDfi6nVKiBOEDoJAUv7a5kSZxPR5O0o3GbcHNXMwPB+kkepCNJA2qdrfNN VTcD66iknro0Pcl6CSx14m2qhVLaJytnYyxM/8LhdnlldGMHgcrSKSnUW25+GQZDsdo/6kTG6E5nt WlBy9VVLRPLp8FfuivCiWKu0VCEgcisqDzGCAtiJXBiVsSkEbbJK/4WbuEoLLl8V+hQTXXx7RswPW Qe81zC5fmAvFYfn9RBRzvL6DzXz20NElzym7cVt7hKyUvBqe7EOkK/koaGnDnvxzH7ZwzggVoFJjJ EH1N3elNBagEMRzs72hw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqVWe-006YCL-C0; Mon, 16 May 2022 07:52:20 +0000 Received: from mail-pj1-x1034.google.com ([2607:f8b0:4864:20::1034]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqVWb-006YBR-27 for linux-arm-kernel@lists.infradead.org; Mon, 16 May 2022 07:52:18 +0000 Received: by mail-pj1-x1034.google.com with SMTP id gg20so3655061pjb.1 for ; Mon, 16 May 2022 00:52:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=VHwMpClyQynjA2cM8OcoohBNhLjDi14SgAXOvOdZEbo=; b=nGIjLzNobp+vqVe56g2rvlpS7/7o46TAxZoO0J80VdDyZ0eI8m534CnQp0WOqzc4yl 141mrcvH/BsjZoB0P0n5vSQU9+C7ZxD3kOZlObtSFqfXAd7HcXMioy/WoVP2eQIwTOuE X2N5wDDCqpQJWnKOCB40o88MBMmnshdzaX4dhV8DD22pj7Dx4ToH2q8ARFG2kHlif4/U 0H2/mE+n5ncdNPXE4y1+c8N2NnrFZgrM7zEUP+hJ//vB3wl5eniAmItPwmwYwFOwdX3r wlfrqHSNk0/J/m3CIoH9R+GdS82N2ELf7Zg0NEEwKEK2zHj2ZW1N/Xuoa+2G+MQD+B0t iXSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=VHwMpClyQynjA2cM8OcoohBNhLjDi14SgAXOvOdZEbo=; b=lhiCYJ3Fn5MSG/56pWgtSNPQtCPzf1dMl89YKbUqnnTdgTuL4zbELMSqD4NWlJlekK dLxj8TdP72UFpg+6HSy1FuZssVGY9yzNOvP3NKoGCb3J+PCMOOz5TV/CIVGPLNvyfAE4 MKvOo+C1Hm9F3fPm/C14j9M5tzLa6RjUr/68Y0aTsfImPilMi2H7XuEXI6QgocIp/n/s TdZaQDiGtvw6LhLi70PbJ6oGMR5DyqM88gs8jIRb9744hvPoHU+tiUf7GEjb1SWaYIlY plmj0mibIwQbUHxmb6xeUJeVs4iGswSQv0uILG46+SlhrAg/SWBGyJ2y6bJMREG5mi1J 5+Pg== X-Gm-Message-State: AOAM530vYqUOFD1Y07IBizmDld3t+fSzuqcksaks1hO7V2LdjZzONMvy VpCZpxMBcDUnS4lKCQ9tIvbBNbRUUj5wL/86 X-Google-Smtp-Source: ABdhPJz276ABAIAuW896KA5vz0XXu814EgBO3IQUcxDqw00HuNKFl6XPbstTD15t/E9qCoX4qIZKFw== X-Received: by 2002:a17:90b:1e03:b0:1dc:5a7d:bba8 with SMTP id pg3-20020a17090b1e0300b001dc5a7dbba8mr17849338pjb.156.1652687535848; Mon, 16 May 2022 00:52:15 -0700 (PDT) Received: from localhost.localdomain ([202.120.234.246]) by smtp.googlemail.com with ESMTPSA id hv19-20020a17090ae41300b001cd630f301fsm7809297pjb.36.2022.05.16.00.52.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 May 2022 00:52:15 -0700 (PDT) From: Miaoqian Lin To: Jonathan Cameron , Lars-Peter Clausen , Joel Stanley , Andrew Jeffery , Billy Tsai , Miaoqian Lin , Colin Ian King , linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH] iio: adc: aspeed: Fix refcount leak in aspeed_adc_set_trim_data Date: Mon, 16 May 2022 11:52:02 +0400 Message-Id: <20220516075206.34580-1-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220516_005217_142677_3149BBAD X-CRM114-Status: GOOD ( 10.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org of_find_node_by_name() returns a node pointer with refcount incremented, we should use of_node_put() on it when done. Add missing of_node_put() to avoid refcount leak. Fixes: d0a4c17b4073 ("iio: adc: aspeed: Get and set trimming data.") Signed-off-by: Miaoqian Lin --- drivers/iio/adc/aspeed_adc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/iio/adc/aspeed_adc.c b/drivers/iio/adc/aspeed_adc.c index 0793d2474cdc..9341e0e0eb55 100644 --- a/drivers/iio/adc/aspeed_adc.c +++ b/drivers/iio/adc/aspeed_adc.c @@ -186,6 +186,7 @@ static int aspeed_adc_set_trim_data(struct iio_dev *indio_dev) return -EOPNOTSUPP; } scu = syscon_node_to_regmap(syscon); + of_node_put(syscon); if (IS_ERR(scu)) { dev_warn(data->dev, "Failed to get syscon regmap\n"); return -EOPNOTSUPP;