From patchwork Mon May 16 22:48:00 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Chris Packham X-Patchwork-Id: 12851542 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11B0BC433FE for ; Mon, 16 May 2022 22:48:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349732AbiEPWsP (ORCPT ); Mon, 16 May 2022 18:48:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348868AbiEPWsM (ORCPT ); Mon, 16 May 2022 18:48:12 -0400 Received: from gate2.alliedtelesis.co.nz (gate2.alliedtelesis.co.nz [202.36.163.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C016840E55 for ; Mon, 16 May 2022 15:48:10 -0700 (PDT) Received: from svr-chch-seg1.atlnz.lc (mmarshal3.atlnz.lc [10.32.18.43]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by gate2.alliedtelesis.co.nz (Postfix) with ESMTPS id A7D452C022D; Mon, 16 May 2022 22:48:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alliedtelesis.co.nz; s=mail181024; t=1652741288; bh=yck0K+zg9Rk64Z3+P5kyIChCgdh0HS53j4rjHi8Gkzw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Plsrq3xNg3eLxOgGv947hqy6f7he/F8cFFMdQr955ypBDoj6WY23sunnjksuM5oCT DSZc/UziM9wck6/YAm87OkFc8jpQcPjmA72BDh8RKsQnXqgWaxcZXKTkpsQtvo+qwq MfahU1YBLxw3/JW270TuzmlkPxr+hMYgWax403lmqqAhNaRYRBVeFpmZ7P7DqNejnu fq55PB3WqfaEMZ7qAFgBjUiuY28GTF8c/NlUm90LxsqKSbmBRr73D7mieQCtgWCaO9 p1mOKwCDWvIW+j6G6hVji/VPqyLSV4WaDWryC2x2I3wHeVpIFBWMboX5wygS6LMK3P E2SpMxsYaa9cQ== Received: from pat.atlnz.lc (Not Verified[10.32.16.33]) by svr-chch-seg1.atlnz.lc with Trustwave SEG (v8,2,6,11305) id ; Tue, 17 May 2022 10:48:08 +1200 Received: from chrisp-dl.ws.atlnz.lc (chrisp-dl.ws.atlnz.lc [10.33.22.30]) by pat.atlnz.lc (Postfix) with ESMTP id 5595113ED7D; Tue, 17 May 2022 10:48:08 +1200 (NZST) Received: by chrisp-dl.ws.atlnz.lc (Postfix, from userid 1030) id 52C322A0086; Tue, 17 May 2022 10:48:08 +1200 (NZST) From: Chris Packham To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, andrew@lunn.ch, gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com, kabel@kernel.org Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Chris Packham Subject: [PATCH 1/2] arm64: dts: armada-3720-turris-mox: Correct reg property for mdio devices Date: Tue, 17 May 2022 10:48:00 +1200 Message-Id: <20220516224801.1656752-2-chris.packham@alliedtelesis.co.nz> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220516224801.1656752-1-chris.packham@alliedtelesis.co.nz> References: <20220516224801.1656752-1-chris.packham@alliedtelesis.co.nz> MIME-Version: 1.0 X-SEG-SpamProfiler-Analysis: v=2.3 cv=U+Hs8tju c=1 sm=1 tr=0 a=KLBiSEs5mFS1a/PbTCJxuA==:117 a=oZkIemNP1mAA:10 a=0UGfjhEQY5xZ206faIcA:9 X-SEG-SpamProfiler-Score: 0 x-atlnz-ls: pat Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org MDIO devices have #address-cells = <1>, #size-cells = <0>. Now that we have a schema enforcing this for marvell,orion-mdio we can see that the turris-mox has a unnecessary 2nd cell for the switch nodes reg property of it's switch devices. Remove the unnecessary 2nd cell from the switches reg property. Signed-off-by: Chris Packham Reviewed-by: Marek Behún --- .../boot/dts/marvell/armada-3720-turris-mox.dts | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts index 1cee26479bfe..98c9a3265446 100644 --- a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts +++ b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts @@ -303,7 +303,7 @@ phy1: ethernet-phy@1 { /* switch nodes are enabled by U-Boot if modules are present */ switch0@10 { compatible = "marvell,mv88e6190"; - reg = <0x10 0>; + reg = <0x10>; dsa,member = <0 0>; interrupt-parent = <&moxtet>; interrupts = ; @@ -428,7 +428,7 @@ port-sfp@a { switch0@2 { compatible = "marvell,mv88e6085"; - reg = <0x2 0>; + reg = <0x2>; dsa,member = <0 0>; interrupt-parent = <&moxtet>; interrupts = ; @@ -495,7 +495,7 @@ port@5 { switch1@11 { compatible = "marvell,mv88e6190"; - reg = <0x11 0>; + reg = <0x11>; dsa,member = <0 1>; interrupt-parent = <&moxtet>; interrupts = ; @@ -620,7 +620,7 @@ port-sfp@a { switch1@2 { compatible = "marvell,mv88e6085"; - reg = <0x2 0>; + reg = <0x2>; dsa,member = <0 1>; interrupt-parent = <&moxtet>; interrupts = ; @@ -687,7 +687,7 @@ port@5 { switch2@12 { compatible = "marvell,mv88e6190"; - reg = <0x12 0>; + reg = <0x12>; dsa,member = <0 2>; interrupt-parent = <&moxtet>; interrupts = ; @@ -803,7 +803,7 @@ port-sfp@a { switch2@2 { compatible = "marvell,mv88e6085"; - reg = <0x2 0>; + reg = <0x2>; dsa,member = <0 2>; interrupt-parent = <&moxtet>; interrupts = ; From patchwork Mon May 16 22:48:01 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Packham X-Patchwork-Id: 12851544 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D84B8C433FE for ; Mon, 16 May 2022 22:48:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349744AbiEPWsS (ORCPT ); Mon, 16 May 2022 18:48:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55144 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349720AbiEPWsO (ORCPT ); Mon, 16 May 2022 18:48:14 -0400 Received: from gate2.alliedtelesis.co.nz (gate2.alliedtelesis.co.nz [IPv6:2001:df5:b000:5::4]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E57D14131F for ; Mon, 16 May 2022 15:48:10 -0700 (PDT) Received: from svr-chch-seg1.atlnz.lc (mmarshal3.atlnz.lc [10.32.18.43]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by gate2.alliedtelesis.co.nz (Postfix) with ESMTPS id B34652C02EB; Mon, 16 May 2022 22:48:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alliedtelesis.co.nz; s=mail181024; t=1652741288; bh=ACc6IEVM0bn4IqAX/7zUWdQYsuQJlsTvqpTaLUAizYM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Yuw5zMByE5Ust6J4bHCiROIHJy7u4Dehfhvx7/lmkFvbuphuXrnNOz+tzgaVUf3JE O2hqCYvPFe0bmI1zx92CZdh62rC02j8TkpnVS29F8b9jun//PnpmceH4skZlt7sp9w 6mKRwVqG5vFZPE+7Akzrd96TSuhBWrUtF9h+QWBMAfzPm7tH+1YaUVxqtchdkeiJeF wwgw1K/lbs6f26iPFTWLGyypWWqF0p8seGCzCQ2jSKKQdzGCqbgAh8oi0odspnimap yKFEC+JS3sNkhYLf60WOpYLvXDiVHoksy8urBUgipflbPv/KhWjzx8SQJQsXDPyTbe igTY9qD8byXow== Received: from pat.atlnz.lc (Not Verified[10.32.16.33]) by svr-chch-seg1.atlnz.lc with Trustwave SEG (v8,2,6,11305) id ; Tue, 17 May 2022 10:48:08 +1200 Received: from chrisp-dl.ws.atlnz.lc (chrisp-dl.ws.atlnz.lc [10.33.22.30]) by pat.atlnz.lc (Postfix) with ESMTP id 72E8913ED7D; Tue, 17 May 2022 10:48:08 +1200 (NZST) Received: by chrisp-dl.ws.atlnz.lc (Postfix, from userid 1030) id 700E92A0086; Tue, 17 May 2022 10:48:08 +1200 (NZST) From: Chris Packham To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, andrew@lunn.ch, gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com, kabel@kernel.org Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Chris Packham Subject: [PATCH 2/2] dt-bindings: net: marvell,orion-mdio: Set unevaluatedProperties to false Date: Tue, 17 May 2022 10:48:01 +1200 Message-Id: <20220516224801.1656752-3-chris.packham@alliedtelesis.co.nz> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220516224801.1656752-1-chris.packham@alliedtelesis.co.nz> References: <20220516224801.1656752-1-chris.packham@alliedtelesis.co.nz> MIME-Version: 1.0 X-SEG-SpamProfiler-Analysis: v=2.3 cv=U+Hs8tju c=1 sm=1 tr=0 a=KLBiSEs5mFS1a/PbTCJxuA==:117 a=oZkIemNP1mAA:10 a=QXzqMLctjYEMqmhBL2EA:9 X-SEG-SpamProfiler-Score: 0 x-atlnz-ls: pat Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org When the binding was converted it appeared necessary to set 'unevaluatedProperties: true' because of the switch devices on the turris-mox board. Actually the error was because of the reg property being incorrect causing the rest of the properties to be unevaluated. After the reg properties are fixed for turris-mox we can set 'unevaluatedProperties: false' as is generally expected. Signed-off-by: Chris Packham Acked-by: Rob Herring --- Documentation/devicetree/bindings/net/marvell,orion-mdio.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/net/marvell,orion-mdio.yaml b/Documentation/devicetree/bindings/net/marvell,orion-mdio.yaml index fe3a3412f093..d2906b4a0f59 100644 --- a/Documentation/devicetree/bindings/net/marvell,orion-mdio.yaml +++ b/Documentation/devicetree/bindings/net/marvell,orion-mdio.yaml @@ -39,7 +39,7 @@ required: - compatible - reg -unevaluatedProperties: true +unevaluatedProperties: false examples: - |