From patchwork Wed May 18 17:27:15 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ralph Siemsen X-Patchwork-Id: 12853912 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A4B7C433F5 for ; Wed, 18 May 2022 17:28:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241082AbiERR2e (ORCPT ); Wed, 18 May 2022 13:28:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36536 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241081AbiERR2e (ORCPT ); Wed, 18 May 2022 13:28:34 -0400 Received: from mail-io1-xd30.google.com (mail-io1-xd30.google.com [IPv6:2607:f8b0:4864:20::d30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E7AF1B092B for ; Wed, 18 May 2022 10:28:33 -0700 (PDT) Received: by mail-io1-xd30.google.com with SMTP id f4so3083475iov.2 for ; Wed, 18 May 2022 10:28:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=HCKolOlzzwnZ7+8eELQXskFMIvOTP7lX/YwA+iJBQY4=; b=L3XVYyOQzSOkyyakBykuHe2f+T35o9DcLyQB/B00jC1Odl2Xw7aHVgfeLKWkFyKj+T g9GMQ9yzg+0cMi1cMbb3EXUCeNCzhCAxFJXf+rZPwX6AQlToTO4c6uTfQXWOIAY9O2Bb zaOswkiC/CBKTtMyZ++GdrbUstx2GIOhu08EHG30VJKEdmne3FCnLd/aLEhIVj6bN+GH WhAj0gZqoVD/MGdJVbRp3JdsPbDpgOwCosqD/euUs4RUMtvwMuaARunbetUQ8sgalqZ2 yjzuVU9jLUS6D51QgmrxUHROF0l/PdGcIcTuRoBBl4ptOpqU5riWnV2xj2iJdvsKqCvu IuHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=HCKolOlzzwnZ7+8eELQXskFMIvOTP7lX/YwA+iJBQY4=; b=ue+NH4e1cxS85FviollBvT/uoAAugx7DTvwLgBQa07a/fmELuw+2ruMafjSdsFSs8R 56mXm2w8VS3sdAMIMyG4CZfX7nWOJ3rCE6+Y7Cpcf1RTbfvpfmic//0wCVRf1IUPCRTT bSgIT06pF+x4AfddeY1F8MYD+iFDbAxPE7QqTmGwCs8jz6qi64euYdPqBfsgNG2FE020 1FQRLdNbGesUnVYw2WYorsnmtYosSyNYsQVBUq1tfr15jDmxofZG7YTzBznUeEJsI35+ 7HZptiqY6+S8h4KdimJIKm3Vkzmdz+4VaEDlUPlOy/TvHurHBu7GGuV/122H26agwVTC YO+w== X-Gm-Message-State: AOAM531Oq6eMV+5uX00etLHV5jqhAh/6SeQQ5wHV8VigxURxEmOPyeR4 wiDZP1wmXF+TeHXcvjM5bSKjIGxthJxa2Q== X-Google-Smtp-Source: ABdhPJySGBsjt6QuVeV1RImGuXtBAAbxw/OwHGbMLJ56AyjiA3bw9wf9Kv5xxhyqVjEQuxIgTJE8WA== X-Received: by 2002:a05:6602:3290:b0:657:73af:c385 with SMTP id d16-20020a056602329000b0065773afc385mr365253ioz.58.1652894912494; Wed, 18 May 2022 10:28:32 -0700 (PDT) Received: from maple.netwinder.org (rfs.netwinder.org. [206.248.184.2]) by smtp.gmail.com with ESMTPSA id v11-20020a05663812cb00b0032ba5cbae2esm12858jas.144.2022.05.18.10.28.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 May 2022 10:28:31 -0700 (PDT) From: Ralph Siemsen To: linux-renesas-soc@vger.kernel.org Cc: phil.edworthy@renesas.com, Ralph Siemsen , Geert Uytterhoeven , linux-clk@vger.kernel.org Subject: [PATCH 1/3] clk: renesas: r9a06g032: Fix UART clkgrp bitsel Date: Wed, 18 May 2022 13:27:15 -0400 Message-Id: <20220518172808.1691450-1-ralph.siemsen@linaro.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org There are two UART clock groups, each having a mux to select its upstream clock source. The register/bit definitions for accessing these two muxes appear to have been reversed since introduction. Correct them so as to match the hardware manual. Fixes: 4c3d88526eba ("clk: renesas: Renesas R9A06G032 clock driver") Signed-off-by: Ralph Siemsen Reviewed-by: Phil Edworthy --- drivers/clk/renesas/r9a06g032-clocks.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/renesas/r9a06g032-clocks.c b/drivers/clk/renesas/r9a06g032-clocks.c index c99942f0e4d4..0baa6a06ada8 100644 --- a/drivers/clk/renesas/r9a06g032-clocks.c +++ b/drivers/clk/renesas/r9a06g032-clocks.c @@ -287,7 +287,7 @@ static const struct r9a06g032_clkdesc r9a06g032_clocks[] = { .type = K_BITSEL, .source = 1 + R9A06G032_DIV_UART, /* R9A06G032_SYSCTRL_REG_PWRCTRL_PG1_PR2 */ - .dual.sel = ((0xec / 4) << 5) | 24, + .dual.sel = ((0x34 / 4) << 5) | 30, .dual.group = 0, }, { @@ -296,7 +296,7 @@ static const struct r9a06g032_clkdesc r9a06g032_clocks[] = { .type = K_BITSEL, .source = 1 + R9A06G032_DIV_P2_PG, /* R9A06G032_SYSCTRL_REG_PWRCTRL_PG0_0 */ - .dual.sel = ((0x34 / 4) << 5) | 30, + .dual.sel = ((0xec / 4) << 5) | 24, .dual.group = 1, }, D_UGATE(CLK_UART0, "clk_uart0", UART_GROUP_012, 0, 0, 0x1b2, 0x1b3, 0x1b4, 0x1b5), From patchwork Wed May 18 17:27:16 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ralph Siemsen X-Patchwork-Id: 12853913 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 298DDC433FE for ; Wed, 18 May 2022 17:28:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241119AbiERR24 (ORCPT ); Wed, 18 May 2022 13:28:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36788 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241117AbiERR2x (ORCPT ); Wed, 18 May 2022 13:28:53 -0400 Received: from mail-il1-x12e.google.com (mail-il1-x12e.google.com [IPv6:2607:f8b0:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 343EC19FF43 for ; Wed, 18 May 2022 10:28:51 -0700 (PDT) Received: by mail-il1-x12e.google.com with SMTP id 3so2004556ily.2 for ; Wed, 18 May 2022 10:28:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=AOx1LypXvhJE14nWPZ5PxL9FhVAWWtg9pDE4J4YMhoQ=; b=K0M9wXlEDBj1y6Wt13RE7Zj8BL4HiOajXSxtTGoZiTdjQiNeq4CluQVhZImvkSQbJ1 i0uzSmq/gTkqqRm3em78DU8AYTuiF4zTPdIiiVw2gEFS/sy0xaV73lj9YD8wlNPZ/imK HzECX5Kc62AKFg57kdsUOv6Wduc2vFrCCMpNMmjoZ5MdFv/aH42veIxCRgeu35GtHygw gKsSsUoq/NTYe2onrvoeJ7tLskhs4CuFThgAwnWqao7Z/g5apgXNmL1GksJCFD6u9jH4 Mgivs683kzl3+dllBbHBhIYwB/tos96yvxTsq+ysCFM21YX4fAvnbNzqg7OSYCy4ibs/ CZmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=AOx1LypXvhJE14nWPZ5PxL9FhVAWWtg9pDE4J4YMhoQ=; b=efA4VjvhSGU6CEv9zlGTsmfwgnUyYJ7f8uzvARqUfTRwuTaM8ZxrAuIrJ5mBDtuY5a kAWrE82KRcAdJ12AvcN0qtNaloAE6qcR65qqkofAXaBCOu+xCdyJ54z0L8HzCEsGUk5C v39ZBqCW96plYd/RHkWoRObhZB0oXF2tyRIxzkwQ1Qcc17KIIizEsm+b/CNOTtCyL57e j99i6iajHYcdzqlvE5r+zIMf6e9gRx2oanMPXqyqPlhJ+1UzScpH0+qRyWPCgXrzyiAH TrK6treFkIw1RuChCYmx03fPn0KrTWWgW8jk/KHLFV0yFW8J+sCNe36zsZxxw7xp0xv6 06eA== X-Gm-Message-State: AOAM531f3ZZmEQCJmWFOxStRDiUIyATukQmoB8lY7CU0M/MRFcDlp4tv QSNYBtw7WTWlDqEvVH+Fu8Nu8g== X-Google-Smtp-Source: ABdhPJwUNHQWAYmQo+uc5LNqpMPNDRgZ/USR+VN+WwJn/IJjd0Pn21Yg8dlJhCl4V1z/EpCtb67DUw== X-Received: by 2002:a05:6e02:1485:b0:2cd:fa3d:72b9 with SMTP id n5-20020a056e02148500b002cdfa3d72b9mr423352ilk.247.1652894930650; Wed, 18 May 2022 10:28:50 -0700 (PDT) Received: from maple.netwinder.org (rfs.netwinder.org. [206.248.184.2]) by smtp.gmail.com with ESMTPSA id v11-20020a05663812cb00b0032ba5cbae2esm12858jas.144.2022.05.18.10.28.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 May 2022 10:28:50 -0700 (PDT) From: Ralph Siemsen To: linux-renesas-soc@vger.kernel.org Cc: phil.edworthy@renesas.com, Ralph Siemsen , Geert Uytterhoeven , linux-clk@vger.kernel.org Subject: [PATCH 2/3] clk: renesas: r9a06g032: drop some unused fields Date: Wed, 18 May 2022 13:27:16 -0400 Message-Id: <20220518172808.1691450-2-ralph.siemsen@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220518172808.1691450-1-ralph.siemsen@linaro.org> References: <20220518172808.1691450-1-ralph.siemsen@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Minor cleanup, remove unused fields from struct r9a06g032_clkdesc. Signed-off-by: Ralph Siemsen Reviewed-by: Phil Edworthy Reviewed-by: Geert Uytterhoeven --- drivers/clk/renesas/r9a06g032-clocks.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/clk/renesas/r9a06g032-clocks.c b/drivers/clk/renesas/r9a06g032-clocks.c index 0baa6a06ada8..9dbcf9620fa0 100644 --- a/drivers/clk/renesas/r9a06g032-clocks.c +++ b/drivers/clk/renesas/r9a06g032-clocks.c @@ -47,11 +47,9 @@ struct r9a06g032_clkdesc { struct { u16 div, mul; }; - unsigned int factor; - unsigned int frequency; /* for dual gate */ struct { - uint16_t group : 1, index: 3; + uint16_t group : 1; u16 sel, g1, r1, g2, r2; } dual; }; @@ -84,7 +82,7 @@ struct r9a06g032_clkdesc { #define D_UGATE(_idx, _n, _src, _g, _gi, _g1, _r1, _g2, _r2) \ { .type = K_DUALGATE, .index = R9A06G032_##_idx, \ .source = 1 + R9A06G032_##_src, .name = _n, \ - .dual = { .group = _g, .index = _gi, \ + .dual = { .group = _g, \ .g1 = _g1, .r1 = _r1, .g2 = _g2, .r2 = _r2 }, } enum { K_GATE = 0, K_FFC, K_DIV, K_BITSEL, K_DUALGATE }; From patchwork Wed May 18 17:27:17 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ralph Siemsen X-Patchwork-Id: 12853914 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66339C433FE for ; Wed, 18 May 2022 17:29:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241113AbiERR3R (ORCPT ); Wed, 18 May 2022 13:29:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241093AbiERR3Q (ORCPT ); Wed, 18 May 2022 13:29:16 -0400 Received: from mail-il1-x130.google.com (mail-il1-x130.google.com [IPv6:2607:f8b0:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 033531B1CFF for ; Wed, 18 May 2022 10:29:16 -0700 (PDT) Received: by mail-il1-x130.google.com with SMTP id o16so1979173ilq.8 for ; Wed, 18 May 2022 10:29:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Rkbt5ZVirKns48qhAK32oNhTzBfAgzibIPoeemaAR3g=; b=nUK1oeTrUAfeqqk3C+bw0qeWUnjgBaBkRmxULrrBygyH+hB4XY3AhMJZNoxGD2smEH NKg4xRjMKpGoPcVkytsbluGsvzXwGZ/5XgrQbbhygb9c+w2O0nzk/PDBsDxBQUuh97km rChdta0ljTnT/XVwZMAItPyVL6DifqbBwxWehDVkxUVfnW9wzNIMVnK2WEplpdAswWjj m2XH56f+p7VgJAKA7K43C8vzuS1xEkbcShKT0hb9c2h2yVFm6snDFrslQ+ZCerxLO3kY UCTYgzLa6sIWWSm9DMVOG36M2v7es4GAc1CCg1ZbNHWkxt/pixBaRYUPJrDw+9VZ5bTy iPOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Rkbt5ZVirKns48qhAK32oNhTzBfAgzibIPoeemaAR3g=; b=pbVzIxKHZGehP4jktoeF3Hsw5SuHLFbH4qFv1ZgQyz9jZyaqwsm0t6PAIi7R7qrFTI GosB09VTiPzLlKdpOjEU8c0NmHY1LwOxgIDkUgYSjP6uG+a20I2vRNsnlABBmTkNZ/rE yw47RKVfAhxlvzZ+yJhtvuzI9X1hjr91rOxEh/FxfJzB0R8g4I/vk9NQlVvasrRqCDjk k541L8h45ZaaBKKV0JhujIJYQ5B18tFivxDigbwM5N8gw2tQunqcayjekVb50vJDLH3O TbXMkli8rRnd0UTkhSKmhNbdw5gzNZtl1y9k6WLFvaQ3p/rbQVKounrx5OpBek/vT8kx 6AZw== X-Gm-Message-State: AOAM531DH33rEd7mlAu7CcZ4ZWKXDbuXPYEME+zvkd8xkYM6OECHx51Z l+F6C0OXocyYdPTZrjEblZrsog== X-Google-Smtp-Source: ABdhPJybPTe3txnO3Cq6UgUh1aOBNY4CNC0u4kYHHq2OmtynBN31vFZgDyxhb5p3pYgqYC/L+Urj0g== X-Received: by 2002:a05:6e02:1bea:b0:2cf:5e28:aa5b with SMTP id y10-20020a056e021bea00b002cf5e28aa5bmr419280ilv.183.1652894955436; Wed, 18 May 2022 10:29:15 -0700 (PDT) Received: from maple.netwinder.org (rfs.netwinder.org. [206.248.184.2]) by smtp.gmail.com with ESMTPSA id v11-20020a05663812cb00b0032ba5cbae2esm12858jas.144.2022.05.18.10.29.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 May 2022 10:29:15 -0700 (PDT) From: Ralph Siemsen To: linux-renesas-soc@vger.kernel.org Cc: phil.edworthy@renesas.com, Ralph Siemsen , Geert Uytterhoeven , linux-clk@vger.kernel.org Subject: [PATCH 3/3] clk: renesas: r9a06g032: remove unused field Date: Wed, 18 May 2022 13:27:17 -0400 Message-Id: <20220518172808.1691450-3-ralph.siemsen@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220518172808.1691450-1-ralph.siemsen@linaro.org> References: <20220518172808.1691450-1-ralph.siemsen@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org As the D_UGATE macro no longer uses _gi, drop it from all declarations. Signed-off-by: Ralph Siemsen Reviewed-by: Phil Edworthy Reviewed-by: Geert Uytterhoeven --- drivers/clk/renesas/r9a06g032-clocks.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/clk/renesas/r9a06g032-clocks.c b/drivers/clk/renesas/r9a06g032-clocks.c index 9dbcf9620fa0..fe56560c54df 100644 --- a/drivers/clk/renesas/r9a06g032-clocks.c +++ b/drivers/clk/renesas/r9a06g032-clocks.c @@ -79,7 +79,7 @@ struct r9a06g032_clkdesc { .source = 1 + R9A06G032_##_src, .name = _n, \ .reg = _reg, .div_min = _min, .div_max = _max, \ .div_table = { __VA_ARGS__ } } -#define D_UGATE(_idx, _n, _src, _g, _gi, _g1, _r1, _g2, _r2) \ +#define D_UGATE(_idx, _n, _src, _g, _g1, _r1, _g2, _r2) \ { .type = K_DUALGATE, .index = R9A06G032_##_idx, \ .source = 1 + R9A06G032_##_src, .name = _n, \ .dual = { .group = _g, \ @@ -297,14 +297,14 @@ static const struct r9a06g032_clkdesc r9a06g032_clocks[] = { .dual.sel = ((0xec / 4) << 5) | 24, .dual.group = 1, }, - D_UGATE(CLK_UART0, "clk_uart0", UART_GROUP_012, 0, 0, 0x1b2, 0x1b3, 0x1b4, 0x1b5), - D_UGATE(CLK_UART1, "clk_uart1", UART_GROUP_012, 0, 1, 0x1b6, 0x1b7, 0x1b8, 0x1b9), - D_UGATE(CLK_UART2, "clk_uart2", UART_GROUP_012, 0, 2, 0x1ba, 0x1bb, 0x1bc, 0x1bd), - D_UGATE(CLK_UART3, "clk_uart3", UART_GROUP_34567, 1, 0, 0x760, 0x761, 0x762, 0x763), - D_UGATE(CLK_UART4, "clk_uart4", UART_GROUP_34567, 1, 1, 0x764, 0x765, 0x766, 0x767), - D_UGATE(CLK_UART5, "clk_uart5", UART_GROUP_34567, 1, 2, 0x768, 0x769, 0x76a, 0x76b), - D_UGATE(CLK_UART6, "clk_uart6", UART_GROUP_34567, 1, 3, 0x76c, 0x76d, 0x76e, 0x76f), - D_UGATE(CLK_UART7, "clk_uart7", UART_GROUP_34567, 1, 4, 0x770, 0x771, 0x772, 0x773), + D_UGATE(CLK_UART0, "clk_uart0", UART_GROUP_012, 0, 0x1b2, 0x1b3, 0x1b4, 0x1b5), + D_UGATE(CLK_UART1, "clk_uart1", UART_GROUP_012, 0, 0x1b6, 0x1b7, 0x1b8, 0x1b9), + D_UGATE(CLK_UART2, "clk_uart2", UART_GROUP_012, 0, 0x1ba, 0x1bb, 0x1bc, 0x1bd), + D_UGATE(CLK_UART3, "clk_uart3", UART_GROUP_34567, 1, 0x760, 0x761, 0x762, 0x763), + D_UGATE(CLK_UART4, "clk_uart4", UART_GROUP_34567, 1, 0x764, 0x765, 0x766, 0x767), + D_UGATE(CLK_UART5, "clk_uart5", UART_GROUP_34567, 1, 0x768, 0x769, 0x76a, 0x76b), + D_UGATE(CLK_UART6, "clk_uart6", UART_GROUP_34567, 1, 0x76c, 0x76d, 0x76e, 0x76f), + D_UGATE(CLK_UART7, "clk_uart7", UART_GROUP_34567, 1, 0x770, 0x771, 0x772, 0x773), }; struct r9a06g032_priv {